Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-11-09 Thread Jon Masters
On Thu, 2010-10-21 at 21:52 +0200, Daniel Veillard wrote: The SMBIOS data are a standardized set of data structures available in the BIOS area of PCs. Those blocks of data describe things like BIOS version informations, machine vendor, model and identifiers, as well as various parts of the

[libvirt] [PATCH] qemu: Fix non-literal format string

2010-11-09 Thread Jiri Denemark
--- src/qemu/qemu_conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Pushed as a trivial build breaker. diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 7d2a1d6..a506064 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -4185,7 +4185,7 @@ int

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-11-09 Thread Daniel Veillard
On Tue, Nov 09, 2010 at 04:22:56AM -0500, Jon Masters wrote: On Thu, 2010-10-21 at 21:52 +0200, Daniel Veillard wrote: The SMBIOS data are a standardized set of data structures available in the BIOS area of PCs. Those blocks of data describe things like BIOS version informations, machine

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-11-09 Thread Daniel P. Berrange
On Tue, Nov 09, 2010 at 11:29:31AM +0100, Daniel Veillard wrote: On Tue, Nov 09, 2010 at 04:22:56AM -0500, Jon Masters wrote: On Thu, 2010-10-21 at 21:52 +0200, Daniel Veillard wrote: The SMBIOS data are a standardized set of data structures available in the BIOS area of PCs. Those blocks

[libvirt] [PATCH] maint: Commit .gitignore sorting done by bootstrap

2010-11-09 Thread Jiri Denemark
--- .gitignore |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I pushed this trivial patch. diff --git a/.gitignore b/.gitignore index fc3e9d5..a9235b2 100644 --- a/.gitignore +++ b/.gitignore @@ -14,8 +14,8 @@ .sc-start-sc_* /GNUmakefile /libvirt-[0-9]* -/proxy/ /maint.mk

Re: [libvirt] [PATCH v3] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-11-09 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 03:17:56PM -0700, Eric Blake wrote: Index: libvirt-acl/src/libvirt.c === --- libvirt-acl.orig/src/libvirt.c +++ libvirt-acl/src/libvirt.c @@ -10794,7 +10794,7 @@ virStreamRef(virStreamPtr stream)

Re: [libvirt] [PATCH 2/9] Add a graphics type for SPICE protocol

2010-11-09 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 04:20:51PM -0700, Eric Blake wrote: On 11/08/2010 12:27 PM, Daniel P. Berrange wrote: This adds an element graphics type='spice' port='5903' tlsPort='5904' autoport='yes' listen='127.0.0.1'/ This is the bare minimum that should be exposed in the guest

Re: [libvirt] [PATCH] schema: Move timer element inside clock

2010-11-09 Thread Jiri Denemark
Both conf/domain_conf.c and domain XML documentation have timer elements inside /domain/clock. Change domain.rng schema to be consistent with them. --- docs/schemas/domain.rng |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) Conditional ACK: you also need to add at

Re: [libvirt] [PATCH v4] qemu: call drive_del in DetachPciDiskDevice

2010-11-09 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 08:44:05PM -0600, Ryan Harper wrote: diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e7b37e1..d01bb2c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9037,6 +9037,7 @@ static int qemudDomainDetachPciDiskDevice(struct

[libvirt] [PATCH] virsh: Add .xml suffix to tmp files used in *edit commands

2010-11-09 Thread Jiri Denemark
This helps editors with detecting the temporary files as XML since the temporary files do not contain ?xml ...? declaration. Requested by https://bugzilla.redhat.com/show_bug.cgi?id=602277 --- bootstrap.conf |1 + tools/virsh.c |6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-)

Re: [libvirt] [PATCH v2] show compiled in options in virsh --version

2010-11-09 Thread Daniel Veillard
On Mon, Nov 08, 2010 at 08:26:18AM -0700, Eric Blake wrote: On 11/05/2010 11:20 AM, Daniel Veillard wrote: To ease debugging this trivial patch allows to find what was compiled in in the local version of libvirt, this doesn't work for remote access but that's probably sufficient. With the

Re: [libvirt] [PATCH 07/11] Introduce portability APIs for creating threads

2010-11-09 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 11:40:00PM +0100, Matthias Bolte wrote: 2010/11/8 Daniel P. Berrange berra...@redhat.com: The util/threads.c/h code already has APIs for mutexes, condition variables and thread locals. This commit adds in code for actually creating threads. *

Re: [libvirt] [PATCH] virsh: Add .xml suffix to tmp files used in *edit commands

2010-11-09 Thread Daniel P. Berrange
On Tue, Nov 09, 2010 at 12:27:00PM +0100, Jiri Denemark wrote: This helps editors with detecting the temporary files as XML since the temporary files do not contain ?xml ...? declaration. Requested by https://bugzilla.redhat.com/show_bug.cgi?id=602277 --- bootstrap.conf |1 +

Re: [libvirt] [PATCH] schema: Move timer element inside clock

2010-11-09 Thread Daniel Veillard
On Tue, Nov 09, 2010 at 12:08:27PM +0100, Jiri Denemark wrote: Both conf/domain_conf.c and domain XML documentation have timer elements inside /domain/clock. Change domain.rng schema to be consistent with them. --- docs/schemas/domain.rng |7 +++ 1 files changed, 3

Re: [libvirt] [PATCH v3] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-11-09 Thread Stefan Berger
On 11/09/2010 05:58 AM, Daniel P. Berrange wrote: On Mon, Nov 08, 2010 at 03:17:56PM -0700, Eric Blake wrote: Index: libvirt-acl/src/libvirt.c === --- libvirt-acl.orig/src/libvirt.c +++ libvirt-acl/src/libvirt.c @@ -10794,7

Re: [libvirt] [PATCH v2] show compiled in options in virsh --version

2010-11-09 Thread Justin Clift
On 09/11/2010, at 10:16 PM, Daniel Veillard wrote: I really think that -V was the right pick since it's the usual flag for this kind of informations, but since -v/--version was already used I had no idea how to name the long option, especially starting with letter v... The creative approach:

Re: [libvirt] RFC: Supporting IPv6 on libvirt virtual networks

2010-11-09 Thread Pierre Ossman
On Tue, 02 Nov 2010 14:22:08 -0400 Laine Stump la...@laine.org wrote: There are a couple of bugzilla records open requesting IPv6 support on libvirt's virtual networks: https://bugzilla.redhat.com/show_bug.cgi?id=514749 https://bugzilla.redhat.com/show_bug.cgi?id=586124 This is a first

[libvirt] race condtion in getting VNC port for libvirt

2010-11-09 Thread Guangya Liu
Hi, We are encountering a problem of race conditions for getting VNC port when VM start up. In a very powerful hypervisor, if we try to start up more than 1 VM concurrently, then there might be some VMs failed to start up due to VNC port confilict. We searched libvirt bugs and found

Re: [libvirt] [PATCH] virsh: Add .xml suffix to tmp files used in *edit commands

2010-11-09 Thread Jiri Denemark
This helps editors with detecting the temporary files as XML since the temporary files do not contain ?xml ...? declaration. Requested by https://bugzilla.redhat.com/show_bug.cgi?id=602277 ACK Thanks, I pushed the patch. Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] virsh: fix incorrect help text mentioning non-existent network 'id'

2010-11-09 Thread Daniel Veillard
On Tue, Nov 09, 2010 at 01:50:21AM +1100, Justin Clift wrote: --- Pushed this under the trivial rule. There's no such thing as a network id, so the help text is plainly wrong. tools/virsh.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh.c

Re: [libvirt] [PATCH 00/11] Allow access to text console with virStream APIs (v4)

2010-11-09 Thread Daniel Veillard
On Mon, Nov 08, 2010 at 04:39:57PM +, Daniel P. Berrange wrote: An update of the patches in http://www.redhat.com/archives/libvir-list/2010-November/msg00132.html http://www.redhat.com/archives/libvir-list/2010-November/msg00022.html

Re: [libvirt] [PATCH] esx: Add support for memtune/min_guarantee

2010-11-09 Thread Daniel Veillard
On Sun, Nov 07, 2010 at 01:40:42PM +0100, Matthias Bolte wrote: Also add a test case for the VMX handling of it. [...] +if (esxVI_LookupVirtualMachineByUuidAndPrepareForTask + (priv-primary, domain-uuid, NULL, virtualMachine, + priv-autoAnswer) 0 || [...] +if

Re: [libvirt] [PATCH] schema: Move timer element inside clock

2010-11-09 Thread Jiri Denemark
ACK for a patch with that test added :-) I squashed them and pushed. Thanks. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2] show compiled in options in virsh --version

2010-11-09 Thread Daniel Veillard
On Tue, Nov 09, 2010 at 08:11:21AM -0700, Eric Blake wrote: On 11/09/2010 04:16 AM, Daniel Veillard wrote: +++ b/tools/virsh.c @@ -11525,6 +11525,7 @@ vshUsage(void) -t | --timing print timing information\n -l | --log file

Re: [libvirt] [PATCH v2] show compiled in options in virsh --version

2010-11-09 Thread Eric Blake
On 11/09/2010 04:16 AM, Daniel Veillard wrote: +++ b/tools/virsh.c @@ -11525,6 +11525,7 @@ vshUsage(void) -t | --timing print timing information\n -l | --log file output logging to file\n -v |

Re: [libvirt] race condtion in getting VNC port for libvirt

2010-11-09 Thread Daniel P. Berrange
On Sun, Nov 07, 2010 at 08:53:32PM +0800, Guangya Liu wrote: Hi, We are encountering a problem of race conditions for getting VNC port when VM start up. In a very powerful hypervisor, if we try to start up more than 1 VM concurrently, then there might be some VMs failed to start

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-11-09 Thread Jon Masters
On Tue, 2010-11-09 at 11:29 +0100, Daniel Veillard wrote: On Tue, Nov 09, 2010 at 04:22:56AM -0500, Jon Masters wrote: On Thu, 2010-10-21 at 21:52 +0200, Daniel Veillard wrote: The SMBIOS data are a standardized set of data structures available in the BIOS area of PCs. Those blocks of

[libvirt] First Virsh command Reference Pages online

2010-11-09 Thread Justin Clift
Hi all, Started work on a Virsh Command Reference a few days ago, as a way to Officially Document (!) the many virsh commands. My plan is to add to the commands here as I work on related sections. So, as I'm working on Virtual Networking at the moment, it's the net-* commands that have been

Re: [libvirt] [PATCH] Introduce yet another migration version in API.

2010-11-09 Thread Chris Lalancette
On 11/02/10 - 01:08:53PM, Daniel P. Berrange wrote: This patch attempts to introduce a version 3 that uses the improved 5 step sequence * Src: Begin - Generate XML to pass to dst - Generate optional cookie to pass to dst * Dst: Prepare - Get ready to

Re: [libvirt] process= support for 'qemu-kvm -name' [Bug 576950]

2010-11-09 Thread John Morrissey
On Wed, Oct 20, 2010 at 10:34:00AM +0200, Daniel Veillard wrote: Looks just fine, applied and pushed ! Was just working on some changes for qemu; looking at this fresh made me notice I'd overlooked the unnecessary quoting of the command line. AFAICT the quoting isn't necessary. john diff

[libvirt] [PATCH] Fix syntax-check error in domain.rng

2010-11-09 Thread Matthias Bolte
Replace tab with spaces. --- Pushed under the trivial-build-breaker-fix rule :) docs/schemas/domain.rng |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 43c8c44..bbbc846 100644 --- a/docs/schemas/domain.rng +++

Re: [libvirt] [PATCH] esx: Add support for memtune/min_guarantee

2010-11-09 Thread Matthias Bolte
2010/11/9 Daniel Veillard veill...@redhat.com: On Sun, Nov 07, 2010 at 01:40:42PM +0100, Matthias Bolte wrote: Also add a test case for the VMX handling of it. [...] +    if (esxVI_LookupVirtualMachineByUuidAndPrepareForTask +          (priv-primary, domain-uuid, NULL, virtualMachine, +      

[libvirt] [PATCH] virsh: supply long option for -V

2010-11-09 Thread Eric Blake
* tools/virsh.c (vshParseArgv): Use NULL instead of 0 for pointer, and symbolic names for has_arg. Give --version an optional arg. (vshUsage): Document this. * tools/virsh.pod: Likewise. --- Technically, this treats '--version=anything' as -v, so that only '--version=long' is -V; if you want, I

Re: [libvirt] [PATCH v3] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-11-09 Thread Stefan Berger
On 11/08/2010 05:17 PM, Eric Blake wrote: Merge conflict - you can ignore any changes to these two files, now that they is deleted. ACK. You may find some more instances of close() pop up as you rebase on top of the latest tree, but it shouldn't be too hard to figure out. Push now. Stefan

Re: [libvirt] [PATCH] Introduce yet another migration version in API.

2010-11-09 Thread Daniel P. Berrange
On Tue, Nov 09, 2010 at 01:33:50PM -0500, Chris Lalancette wrote: On 11/02/10 - 01:08:53PM, Daniel P. Berrange wrote: This patch attempts to introduce a version 3 that uses the improved 5 step sequence * Src: Begin - Generate XML to pass to dst - Generate

[libvirt] [PATCH] virsh: fix non-literal string format

2010-11-09 Thread Laine Stump
I just pushed this under the trivial rule. These are in the newly added -V output. --- tools/virsh.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 6a9b5d9..0c91f15 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -11546,8

Re: [libvirt] race condtion in getting VNC port for libvirt

2010-11-09 Thread Daniel P. Berrange
On Wed, Nov 10, 2010 at 01:21:24AM +0800, Guangya Liu wrote: Thanks Daniel for the info. But I still have a question, since we already make the call qemudDomainCreate synced, why do we need to introduce a bitmap to resolve the problem of getting VNC port conflict error? If

[libvirt] [RFC] Proposed API to support block device streaming

2010-11-09 Thread Adam Litke
I've been working with Anthony Liguori and Stefan Hajnoczi to enable data streaming to copy-on-read disk images in qemu. This work is working its way through peer review and I expect it to be upstream soon as part of the support for the new QED disk image format. I would like to enable these

Re: [libvirt] [PATCH] virsh: fix non-literal string format

2010-11-09 Thread Eric Blake
On 11/09/2010 02:06 PM, Laine Stump wrote: I just pushed this under the trivial rule. These are in the newly added -V output. --- tools/virsh.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) Admin note - Laine and I just rebased libvirt.org to fix up 'make

Re: [libvirt] [PATCH] virsh: fix non-literal string format

2010-11-09 Thread Eric Blake
On 11/09/2010 04:03 PM, Eric Blake wrote: On 11/09/2010 02:06 PM, Laine Stump wrote: I just pushed this under the trivial rule. These are in the newly added -V output. --- tools/virsh.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) Admin note - Laine and I just

Re: [libvirt] RH EL5 test failure on interfaceshematest and xencapstest

2010-11-09 Thread Matthias Bolte
2010/11/8 Eric Blake ebl...@redhat.com: On 11/08/2010 02:31 PM, Matthias Bolte wrote: xenHypervisorInit is called from xenRegister and detects the sys_interface_version. As Andy figured out correctly, the xencapstest calls xenHypervisorMakeCapabilitiesInternal with conn == NULL.

[libvirt] [PATCHv2] rpm: fix /var/lib/libvirt permissions

2010-11-09 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=649511 Regression of forcing 0700 permissions (which breaks guest startup because the qemu user can't see /var/lib/libvirt/*.monitor) was introduced in commit 66823690e, as part of libvirt 0.8.2. * libvirt.spec.in (%files): Drop

Re: [libvirt] RH EL5 test failure on interfaceshematest and xencapstest

2010-11-09 Thread Eric Blake
On 11/09/2010 08:13 AM, Andy Howell wrote: Attached is what I'm seeing for the interfaceshematest Regards, Andy interfaceschematest.failures 1) interfaceschemadata/bridge.xml ... FAILED xmllint --relaxng

Re: [libvirt] [PATCH] Allow non-file disk backingStores

2010-11-09 Thread Eric Blake
On 11/03/2010 09:50 AM, Adam Litke wrote: I am trying to use a qcow image with libvirt where the backing 'file' is a qemu-nbd server. Unfortunately virDomainDiskDefForeachPath() assumes that backingStore is always a real file so something like 'nbd:0:' is rejected because a file with that

[libvirt] [PATCH] replace last instances of close()

2010-11-09 Thread Stefan Berger
I am replacing the last instances of close() I found with VIR_CLOSE() / VIR_FORCE_CLOSE respectively. The first patch of virsh I missed out on previously. The 2nd patch I had left out intentionally to look at it more carefully: The 'closed' variable could be easily removed since it wasn't used

[libvirt] Is there an API for clone?

2010-11-09 Thread 黄亮
Hi, guys I know there is a command virt-clone, but I couldn't find the equivalent API here : http://libvirt.org/html/libvirt-libvirt.html So, is there an API to clone an existing VM or not? Thank you! Regards 2010-11-10 Lancer -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] Is there an API for clone?

2010-11-09 Thread Osier Yang
于 2010年11月10日 09:30, 黄亮 写道: Hi, guys I know there is a command virt-clone, but I couldn't find the equivalent API here : http://libvirt.org/html/libvirt-libvirt.html So, is there an API to clone an existing VM or not? Thank you! Regards 2010-11-10

Re: [libvirt] Is there an API for clone?

2010-11-09 Thread 黄亮
Oops... Well, thank you for your reply Regards 2010-11-10 Lancer 发件人: Osier Yang 发送时间: 2010-11-10 12:19:34 收件人: libvir-list 抄送: 主题: Re: [libvirt] Is there an API for clone? 于 2010年11月10日 09:30, 黄亮 写道: Hi, guys I know there is a command virt-clone, but I couldn't find the

Re: [libvirt] First Virsh command Reference Pages online

2010-11-09 Thread Osier Yang
[snip] Creates a new temporary virtual network from an XML file [/snip] libvirt and virsh use term persistent and transient, :-) - Osier 于 2010年11月10日 01:03, Justin Clift 写道: Hi all, Started work on a Virsh Command Reference a few days ago, as a way to Officially Document (!) the many virsh

Re: [libvirt] First Virsh command Reference Pages online

2010-11-09 Thread Justin Clift
On 10/11/2010, at 3:42 PM, Osier Yang wrote: [snip] Creates a new temporary virtual network from an XML file [/snip] libvirt and virsh use term persistent and transient, :-) Yeah. I think transient might need some work. It's something worth discussing, then doing a search-n-replace