[libvirt] [PATCH] [RESEND] qemu: record timestamp in qemu domain log

2010-11-16 Thread Osier Yang
Currently only support domain start and shutdown, for domain start, record timestamp before the qemu command line, and for domain shutdown, just say it's shutting down with timestamp. * src/qemu/qemu_driver.c --- src/qemu/qemu_driver.c | 47 +-- 1

Re: [libvirt] [PATCH v5] qemu: call drive_del in DetachPciDiskDevice

2010-11-16 Thread Daniel P. Berrange
On Fri, Nov 12, 2010 at 12:23:41PM -0600, Ryan Harper wrote: Currently libvirt doesn't confirm whether the guest has responded to the disk removal request. In some cases this can leave the guest with continued access to the device while the mgmt layer believes that it has been removed. With

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Richard W.M. Jones
On Mon, Nov 15, 2010 at 02:41:15AM +1100, Justin Clift wrote: On 15/11/2010, at 2:38 AM, arnaud.champ...@devatom.fr wrote: ?I have used visual studio 2010 to create a standard setup, but for now it just provide dll, no virsh but why not... GAC inscription is now next goal. I'll try to see

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Richard W.M. Jones
On Mon, Nov 15, 2010 at 12:41:35PM +1100, Justin Clift wrote: For the creation of .msi package files, WiX seems to be the right tool these days (open source): http://wix.sourceforge.net Actually kind of think I've heard of it before, as it got some press a few years back from being one of

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Matthias Bolte
2010/11/16 Richard W.M. Jones rjo...@redhat.com: On Mon, Nov 15, 2010 at 02:41:15AM +1100, Justin Clift wrote: On 15/11/2010, at 2:38 AM, arnaud.champ...@devatom.fr wrote: ?I have used visual studio 2010 to create a standard setup, but for now it just provide dll, no virsh but why not...

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Richard W.M. Jones
On Tue, Nov 16, 2010 at 11:56:12AM +0100, Matthias Bolte wrote: 2010/11/16 Richard W.M. Jones rjo...@redhat.com: On Mon, Nov 15, 2010 at 02:41:15AM +1100, Justin Clift wrote: On 15/11/2010, at 2:38 AM, arnaud.champ...@devatom.fr wrote: ?I have used visual studio 2010 to create a standard

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Matthias Bolte
2010/11/16 Richard W.M. Jones rjo...@redhat.com: On Tue, Nov 16, 2010 at 11:56:12AM +0100, Matthias Bolte wrote: 2010/11/16 Richard W.M. Jones rjo...@redhat.com: On Mon, Nov 15, 2010 at 02:41:15AM +1100, Justin Clift wrote: On 15/11/2010, at 2:38 AM, arnaud.champ...@devatom.fr wrote: ?I

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Richard W.M. Jones
[CC-ing to the cross-compiler mailing list] On Tue, Nov 16, 2010 at 12:09:29PM +0100, Matthias Bolte wrote: 2010/11/16 Richard W.M. Jones rjo...@redhat.com: On Tue, Nov 16, 2010 at 11:56:12AM +0100, Matthias Bolte wrote: I recently tested the Fedora provided mingw32-libvirt on Windows and

Re: [libvirt] [PATCH] nwfilter: use /bin/sh rather than requiring bash

2010-11-16 Thread Stefan Berger
On 11/15/2010 09:54 PM, Eric Blake wrote: On 11/15/2010 07:18 PM, Stefan Berger wrote: I've gone ahead and pushed it. diff --git i/src/nwfilter/nwfilter_ebiptables_driver.c w/src/nwfilter/nwfilter_ebiptables_driver.c index c3a0d3e..7b2a505 100644 ---

[libvirt] [PATCH v3] deprecate fclose() and introduce VIR_{FORCE_}FCLOSE()

2010-11-16 Thread Stefan Berger
V3: - fixes from V2 review + one lost hunk - diff(tree+V2, tree+v3) at bottom of email V2: - following Eric's suggestion, deprecating fdclose(), introducing VIR_FDCLOSE() - following some other nits that Eric pointed out - replaced some more fclose () I previously had missed (last 2

[libvirt] [PATCH] nwfilter: also purge ip(6)tables rules before detecting IP address

2010-11-16 Thread Stefan Berger
Rather than only cleaning any remaining ebtables rules, also clean those applied to iptables and ip6tables when detecting the IP address of an interface. Previous applied iptables rules may hinder DHCP packets. Signed-off-by: Stefan Berger stef...@us.ibm.com ---

Re: [libvirt] [PATCH] replace last instances of close()

2010-11-16 Thread Stefan Berger
On 11/10/2010 07:43 AM, Stefan Berger wrote: On 11/10/2010 05:41 AM, Daniel P. Berrange wrote: On Tue, Nov 09, 2010 at 07:43:23PM -0500, Stefan Berger wrote: I am replacing the last instances of close() I found with VIR_CLOSE() / VIR_FORCE_CLOSE respectively. The first patch of virsh I missed

Re: [libvirt] [PATCH] replace last instances of close()

2010-11-16 Thread Daniel P. Berrange
On Tue, Nov 16, 2010 at 08:09:35AM -0500, Stefan Berger wrote: On 11/10/2010 07:43 AM, Stefan Berger wrote: On 11/10/2010 05:41 AM, Daniel P. Berrange wrote: On Tue, Nov 09, 2010 at 07:43:23PM -0500, Stefan Berger wrote: I am replacing the last instances of close() I found with VIR_CLOSE() /

Re: [libvirt] [PATCH] [RESEND] To list basic information about the network.

2010-11-16 Thread Daniel P. Berrange
On Tue, Nov 16, 2010 at 03:48:47PM +0800, Osier Yang wrote: * tools/virsh.c --- tools/virsh.c | 59 + 1 files changed, 59 insertions(+), 0 deletions(-) mode change 100644 = 100755 tools/virsh.c diff --git a/tools/virsh.c

Re: [libvirt] [PATCH] [RESEND] qemu: record timestamp in qemu domain log

2010-11-16 Thread Daniel P. Berrange
On Tue, Nov 16, 2010 at 04:11:40PM +0800, Osier Yang wrote: Currently only support domain start and shutdown, for domain start, record timestamp before the qemu command line, and for domain shutdown, just say it's shutting down with timestamp. * src/qemu/qemu_driver.c ---

Re: [libvirt] [PATCH] replace last instances of close()

2010-11-16 Thread Stefan Berger
On 11/16/2010 08:13 AM, Daniel P. Berrange wrote: On Tue, Nov 16, 2010 at 08:09:35AM -0500, Stefan Berger wrote: On 11/10/2010 07:43 AM, Stefan Berger wrote: On 11/10/2010 05:41 AM, Daniel P. Berrange wrote: On Tue, Nov 09, 2010 at 07:43:23PM -0500, Stefan Berger wrote: I am replacing the

Re: [libvirt] [PATCH] [RESEND] qemu: record timestamp in qemu domain log

2010-11-16 Thread Osier Yang
于 2010年11月16日 21:17, Daniel P. Berrange 写道: On Tue, Nov 16, 2010 at 04:11:40PM +0800, Osier Yang wrote: Currently only support domain start and shutdown, for domain start, record timestamp before the qemu command line, and for domain shutdown, just say it's shutting down with timestamp. *

Re: [libvirt] [PATCH] [RESEND] qemu: record timestamp in qemu domain log

2010-11-16 Thread Daniel P. Berrange
On Tue, Nov 16, 2010 at 10:54:34PM +0800, Osier Yang wrote: 于 2010年11月16日 21:17, Daniel P. Berrange 写道: On Tue, Nov 16, 2010 at 04:11:40PM +0800, Osier Yang wrote: Currently only support domain start and shutdown, for domain start, record timestamp before the qemu command line, and for domain

Re: [libvirt] [PATCH] nwfilter: use /bin/sh rather than requiring bash

2010-11-16 Thread Eric Blake
On 11/16/2010 04:30 AM, Stefan Berger wrote: On 11/15/2010 09:54 PM, Eric Blake wrote: On 11/15/2010 07:18 PM, Stefan Berger wrote: I've gone ahead and pushed it. diff --git i/src/nwfilter/nwfilter_ebiptables_driver.c w/src/nwfilter/nwfilter_ebiptables_driver.c index c3a0d3e..7b2a505

Re: [libvirt] [PATCH v3] deprecate fclose() and introduce VIR_{FORCE_}FCLOSE()

2010-11-16 Thread Eric Blake
On 11/16/2010 04:50 AM, Stefan Berger wrote: V3: - fixes from V2 review + one lost hunk - diff(tree+V2, tree+v3) at bottom of email That helps. And you solved all my findings. ACK. +++ src/xen/xen_driver.c2010-11-16 06:31:49.722481846 -0500 @@ -218,9 +218,9 @@ #endif #ifdef

Re: [libvirt] [PATCH] nwfilter: also purge ip(6)tables rules before detecting IP address

2010-11-16 Thread Eric Blake
On 11/16/2010 05:29 AM, Stefan Berger wrote: Rather than only cleaning any remaining ebtables rules, also clean those applied to iptables and ip6tables when detecting the IP address of an interface. Previous applied iptables rules may hinder DHCP packets. Signed-off-by: Stefan Berger

[libvirt] [PATCH] qemu: record timestamp in qemu domain log

2010-11-16 Thread Osier Yang
Currently only support domain start and shutdown, for domain start, record timestamp before the qemu command line, and for domain shutdown, just say it's shutting down with timestamp. * src/qemu/qemu_driver.c (qemudStartVMDaemon, qemudShutdownVMDaemon introduced two macros - START_POSTFIX,

Re: [libvirt] process= support for 'qemu-kvm -name' [Bug 576950]

2010-11-16 Thread Daniel Veillard
On Fri, Nov 12, 2010 at 03:16:09PM +0100, Matthias Bolte wrote: 2010/11/10 Daniel P. Berrange berra...@redhat.com: On Tue, Nov 09, 2010 at 01:41:43PM -0500, John Morrissey wrote: On Wed, Oct 20, 2010 at 10:34:00AM +0200, Daniel Veillard wrote:   Looks just fine, applied and pushed !

Re: [libvirt] [PATCH] qemu: record timestamp in qemu domain log

2010-11-16 Thread Daniel P. Berrange
On Tue, Nov 16, 2010 at 11:39:26PM +0800, Osier Yang wrote: Currently only support domain start and shutdown, for domain start, record timestamp before the qemu command line, and for domain shutdown, just say it's shutting down with timestamp. * src/qemu/qemu_driver.c (qemudStartVMDaemon,

Re: [libvirt] [PATCH] replace last instances of close()

2010-11-16 Thread Eric Blake
On 11/16/2010 06:20 AM, Stefan Berger wrote: Did I convince you? Yes no. On the surface it looks ok, but I'm still a little worried about the implications, because I put this code in there to avoid some nasty re-entrancy problems. I guessing some later re-factoring might have fixed those

Re: [libvirt] [PATCH] [RESEND] To list basic information about the network.

2010-11-16 Thread Eric Blake
On 11/16/2010 06:14 AM, Daniel P. Berrange wrote: On Tue, Nov 16, 2010 at 03:48:47PM +0800, Osier Yang wrote: * tools/virsh.c --- tools/virsh.c | 59 + 1 files changed, 59 insertions(+), 0 deletions(-) mode change 100644 = 100755

Re: [libvirt] [PATCH] qemu: record timestamp in qemu domain log

2010-11-16 Thread Eric Blake
On 11/16/2010 08:47 AM, Daniel P. Berrange wrote: On Tue, Nov 16, 2010 at 11:39:26PM +0800, Osier Yang wrote: Currently only support domain start and shutdown, for domain start, record timestamp before the qemu command line, and for domain shutdown, just say it's shutting down with timestamp.

[libvirt] Schedule for next libvirt releases

2010-11-16 Thread Daniel Veillard
Let's try to keep with end of month based release cycles, so assuming 0.8.6 gets pushed on the 30th, that means 2 weeks from today, and hence we would enter the freeze on Tuesday 23 next week. This means one more week to push patches for 0.8.6. For the following release, I will try to get

Re: [libvirt] [PATCH] qemu: fix typos in qemu_monitor_text.c

2010-11-16 Thread Eric Blake
On 11/12/2010 04:08 PM, Osier Yang wrote: * src/qemu/qemu_monitor_text.c (qemuMonitorTextChangeMedia) --- src/qemu/qemu_monitor_text.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index

Re: [libvirt] [PATCH] daemon: fix indention problem in daemon/libvirt.c

2010-11-16 Thread Eric Blake
On 11/12/2010 05:24 PM, Osier Yang wrote: * daemon/libvirtd.c --- daemon/libvirtd.c | 40 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index ab2b579..9446638 100644 --- a/daemon/libvirtd.c

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Justin Clift
On 16/11/2010, at 9:44 PM, Richard W.M. Jones wrote: On Mon, Nov 15, 2010 at 12:41:35PM +1100, Justin Clift wrote: For the creation of .msi package files, WiX seems to be the right tool these days (open source): http://wix.sourceforge.net Actually kind of think I've heard of it before,

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Justin Clift
On 16/11/2010, at 9:56 PM, Matthias Bolte wrote: snip I recently tested the Fedora provided mingw32-libvirt on Windows and virsh just segfaults before main() for me. Justin, msys_setup contains a download_libvirt-fedora.sh script that downloads and unpacks to

Re: [libvirt] [PATCH] [RESEND] To list basic information about the network.

2010-11-16 Thread Justin Clift
Hey Osier, Do you have a few minutes to write up the net-info command, for the virsh Command Reference? You don't need to do it in DocBook or anything, just standard text is fine. I can convert it into the DocBook format we're using fairly quickly now. :) Regards and best wishes, Justin

[libvirt] [PATCH] maint: use gnulib configmake rather than open-coding things

2010-11-16 Thread Eric Blake
In some cases, we were just plain confusing (BINDIR expanded to $(libexecdir), GETTEXT_PACKAGE redefined PACKAGE for no apparant reason); in other cases, we might as well benefit from gnulib doing the work for us (PKGDATADIR), sometimes with different spellings (LOCAL_STATE_DIR vs. LOCALSTATEDIR).

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Erik van Pienbroek
Richard W.M. Jones schreef op di 16-11-2010 om 11:20 [+]: [CC-ing to the cross-compiler mailing list] On Tue, Nov 16, 2010 at 12:09:29PM +0100, Matthias Bolte wrote: 2010/11/16 Richard W.M. Jones rjo...@redhat.com: On Tue, Nov 16, 2010 at 11:56:12AM +0100, Matthias Bolte wrote: I

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Richard W.M. Jones
On Wed, Nov 17, 2010 at 04:42:46AM +1100, Justin Clift wrote: On 16/11/2010, at 9:44 PM, Richard W.M. Jones wrote: On Mon, Nov 15, 2010 at 12:41:35PM +1100, Justin Clift wrote: For the creation of .msi package files, WiX seems to be the right tool these days (open source):

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Justin Clift
On 17/11/2010, at 5:26 AM, Richard W.M. Jones wrote: The bottom line is this email: http://www.mailinglistarchive.com/fedora-devel-l...@redhat.com/msg61468.html I don't know whether this is true, or still true, but I do know that the build system for WiX is out of bizarro-land. You will

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Laine Stump
On 11/16/2010 02:57 PM, Justin Clift wrote: On 17/11/2010, at 5:26 AM, Richard W.M. Jones wrote: The bottom line is this email: http://www.mailinglistarchive.com/fedora-devel-l...@redhat.com/msg61468.html I don't know whether this is true, or still true, but I do know that the build system

Re: [libvirt] Experimental 32-bit windows libvirt installer

2010-11-16 Thread Justin Clift
On 17/11/2010, at 8:24 AM, Laine Stump wrote: On 11/16/2010 02:57 PM, Justin Clift wrote: On 17/11/2010, at 5:26 AM, Richard W.M. Jones wrote: The bottom line is this email: http://www.mailinglistarchive.com/fedora-devel-l...@redhat.com/msg61468.html I don't know whether this is true, or

[libvirt] [PATCH 2/3] maint: update to latest gnulib

2010-11-16 Thread Eric Blake
Allows bootstrap to work on FreeBSD, where gzip doesn't have a '.' in its version; and silences false positives in the new 'make syntax-check' rule. * .gnulib: Update to latest. * bootstrap: Synchronize to upstream. * .x-sc_bindtextdomain: New exemptions. * Makefile.am (syntax_check_exceptions):

[libvirt] [PATCH 1/3] maint: improve i18n on non-Linux

2010-11-16 Thread Eric Blake
Per the gettext developer: http://lists.gnu.org/archive/html/bug-gnu-utils/2010-10/msg00019.html http://lists.gnu.org/archive/html/bug-gnu-utils/2010-10/msg00021.html gettext() doesn't work correctly on all platforms unless you have called setlocale(). Furthermore, gnulib's gettext.h has

[libvirt] [PATCH 0/3] improve i18n

2010-11-16 Thread Eric Blake
This patch series depends on these two previous patches (not reviewed yet): https://www.redhat.com/archives/libvir-list/2010-November/msg00733.html https://www.redhat.com/archives/libvir-list/2010-November/msg00626.html It also replaces my earlier patch here:

[libvirt] [PATCH 3/3] virt-aa-helper: translate error messages

2010-11-16 Thread Eric Blake
These messages are visible to the user, so they should be consistently translated. * cfg.mk (msg_gen_function): Add vah_error, vah_warning. * src/security/virt-aa-helper.c: Translate messages. (catchXMLError): Fix capitalization. --- cfg.mk|2 +

[libvirt] [PATCHv3] maint: avoid remaining sprintf uses

2010-11-16 Thread Eric Blake
* cfg.mk (sc_prohibit_sprintf): New rule. (sc_prohibit_asprintf): Avoid false positives. * docs/hacking.html.in (Printf-style functions): Document the policy. * HACKING: Regenerate. * .x-sc_prohibit_sprintf: New exemptions. * Makefile.am (syntax-check_exceptions): Ship new file. *

Re: [libvirt] [PATCH] nwfilter: also purge ip(6)tables rules before detecting IP address

2010-11-16 Thread Stefan Berger
On 11/16/2010 10:38 AM, Eric Blake wrote: On 11/16/2010 05:29 AM, Stefan Berger wrote: Rather than only cleaning any remaining ebtables rules, also clean those applied to iptables and ip6tables when detecting the IP address of an interface. Previous applied iptables rules may hinder DHCP

Re: [libvirt] [PATCH v3] deprecate fclose() and introduce VIR_{FORCE_}FCLOSE()

2010-11-16 Thread Stefan Berger
On 11/16/2010 10:37 AM, Eric Blake wrote: On 11/16/2010 04:50 AM, Stefan Berger wrote: V3: - fixes from V2 review + one lost hunk - diff(tree+V2, tree+v3) at bottom of email That helps. And you solved all my findings. ACK. +++ src/xen/xen_driver.c2010-11-16 06:31:49.722481846

[libvirt] [PATCH v2] replace last instances of close()

2010-11-16 Thread Stefan Berger
v2: - added comments about the monitor lock being used to protect the file descriptor 'fd' - eofcb is not set anywhere, so also removing it; the if statement checking on it seems dead code I am replacing the last instances of close() I found with VIR_CLOSE() / VIR_FORCE_CLOSE

[libvirt] OpenSource-Management of private Clouds and Virtualisation

2010-11-16 Thread acue
Hello, I want to announce the current version of the UnifiedSessionsManager. An OpenSource-Toolset providing a neatless interface for the vendor independent use and administration of virtual and physical systems. Private-Clouds - the Intranet! The license is GPL3+FDL-1.3+CCL-3.0.

Re: [libvirt] [PATCH] [RESEND] To list basic information about the network.

2010-11-16 Thread Osier Yang
于 2010年11月17日 00:18, Eric Blake 写道: On 11/16/2010 06:14 AM, Daniel P. Berrange wrote: On Tue, Nov 16, 2010 at 03:48:47PM +0800, Osier Yang wrote: * tools/virsh.c --- tools/virsh.c | 59 + 1 files changed, 59 insertions(+), 0

Re: [libvirt] [PATCH] [RESEND] To list basic information about the network.

2010-11-16 Thread Osier Yang
于 2010年11月17日 01:49, Justin Clift 写道: Hey Osier, Do you have a few minutes to write up the net-info command, for the virsh Command Reference? You don't need to do it in DocBook or anything, just standard text is fine. I can convert it into the DocBook format we're using fairly quickly now.

Re: [libvirt] OpenSource-Management of private Clouds and Virtualisation

2010-11-16 Thread Justin Clift
On 17/11/2010, at 4:52 PM, a...@i4p.com wrote: I want to announce the current version of the UnifiedSessionsManager. An OpenSource-Toolset providing a neatless interface for the vendor independent use and administration of virtual and physical systems. Sounds interesting. What does neatless

Re: [libvirt] OpenSource-Management of private Clouds and Virtualisation

2010-11-16 Thread Osier Yang
于 2010年11月17日 14:47, Justin Clift 写道: On 17/11/2010, at 4:52 PM, a...@i4p.com wrote: I want to announce the current version of the UnifiedSessionsManager. An OpenSource-Toolset providing a neatless interface for the vendor independent use and administration of virtual and physical systems.

Re: [libvirt] OpenSource-Management of private Clouds and Virtualisation

2010-11-16 Thread Laine Stump
On 11/17/2010 02:08 AM, Osier Yang wrote: 于 2010年11月17日 14:47, Justin Clift 写道: On 17/11/2010, at 4:52 PM, a...@i4p.com wrote: I want to announce the current version of the UnifiedSessionsManager. An OpenSource-Toolset providing a neatless interface for the vendor independent use and

[libvirt] [PATCH 0/2] Support of auto-dump on watchdog event in libvirtd

2010-11-16 Thread Hu Tao
This patch series adds support of auto-dump on watchdog event in libvirtd. If a qemu guest is configured with a watchdog device and libvirtd receives a watchdog event from the guest, it can do something on the guest, currently `dump' action is defined. This patch series adds a new watchdog

[libvirt] [PATCH 2/2] Add a watchdog action `managed'.

2010-11-16 Thread Hu Tao
`managed' watchdog action lets libvirtd decide what to do if a guest watchdog fires. It has a subaction argument which is the action libvirtd will take. Currently only `dump' subaction is defined, it tells libvirtd to dump the guest on a watchdog event. `managed' watchdog action is mapped to

[libvirt] [PATCH 1/2] Add a thread pool implementation

2010-11-16 Thread Hu Tao
--- src/Makefile.am |1 + src/util/threadpool.c | 119 + src/util/threadpool.h | 34 ++ 3 files changed, 154 insertions(+), 0 deletions(-) create mode 100644 src/util/threadpool.c create mode 100644 src/util/threadpool.h

Re: [libvirt] OpenSource-Management of private Clouds and Virtualisation

2010-11-16 Thread Osier Yang
于 2010年11月17日 15:40, Laine Stump 写道: On 11/17/2010 02:08 AM, Osier Yang wrote: 于 2010年11月17日 14:47, Justin Clift 写道: On 17/11/2010, at 4:52 PM, a...@i4p.com wrote: I want to announce the current version of the UnifiedSessionsManager. An OpenSource-Toolset providing a neatless interface for