On Thu, Nov 18, 2010 at 5:13 PM, Sage Weil s...@newdream.net wrote:
On Thu, 18 Nov 2010, Daniel P. Berrange wrote:
On Wed, Nov 17, 2010 at 04:33:07PM -0800, Josh Durgin wrote:
Hi Daniel,
On 11/08/2010 05:16 AM, Daniel P. Berrange wrote:
In any case, before someone goes off and implements
On Fri, Nov 19, 2010 at 09:27:40AM +, Stefan Hajnoczi wrote:
On Thu, Nov 18, 2010 at 5:13 PM, Sage Weil s...@newdream.net wrote:
On Thu, 18 Nov 2010, Daniel P. Berrange wrote:
On Wed, Nov 17, 2010 at 04:33:07PM -0800, Josh Durgin wrote:
Hi Daniel,
On 11/08/2010 05:16 AM, Daniel
* docs/schemas/domain.rng
---
docs/schemas/domain.rng |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
index bbbc846..815134d 100644
--- a/docs/schemas/domain.rng
+++ b/docs/schemas/domain.rng
@@ -2003,7 +2003,7 @@
On Fri, Nov 19, 2010 at 9:50 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Fri, Nov 19, 2010 at 09:27:40AM +, Stefan Hajnoczi wrote:
On Thu, Nov 18, 2010 at 5:13 PM, Sage Weil s...@newdream.net wrote:
On Thu, 18 Nov 2010, Daniel P. Berrange wrote:
On Wed, Nov 17, 2010 at
This is a series of 3 patches to add network management support for
pHyp driver.
Eduardo Otubo (3):
PHYP: Separating UUID functions in another file
PHYP: Adding basic network functions
PHYP: create, destroy and other network functions
po/POTFILES.in |1 +
src/Makefile.am
I am moving all the UUID handling functions to phyp_uuid.[ch] files in
order not to bloat the main files phyp_driver.[ch] too much. Doing this
for two reasons:
1) Network management in pHyp does not have a UUID.
2) Need to create another set of functions to manage it.
I also modified
Now adding some basic operation network functions and its UUID
helpers.
---
src/phyp/phyp_driver.c | 202 ++-
src/phyp/phyp_uuid.c | 177 ++
src/phyp/phyp_uuid.h |8 ++
3 files changed, 382
Adding networkCreateXML, networkDestroy, networkIsActive and
networkLookupByName.
In the function phypCreateNetwork I just use the def-domain information to
create
the new network interface because of the behaviour of the HMC and the
hypervisor:
* HMC can't simply create a network
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/util/conf.c | 19 +++
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/util/conf.c b/src/util/conf.c
index ba1a384..a31bbc4 100644
--- a/src/util/conf.c
+++ b/src/util/conf.c
@@ -394,17 +394,20 @@
This series fixes some xen XM parsing and sexpr generation issues.
The first two patches fix parsing /etc/xen files that use python style
triple quotes (which libvirt will actually generate in certain situations).
The last two patches fix generating xend sexpr with the reserved characters
\ or
Disk image formats that wish to opt-out of version validation are supposed to
set versionOffset to -1 in their fileTypeInfo entry.
By unconditionally returning False for these formats,
virStorageFileMatchesVersion() incorrectly reports a version mismatch when the
test was actually skipped. The
Since we send the sexpr to xend via HTTP, we need to properly escape
''
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/xen/xend_internal.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
index d6d66bd..3ccadde
An incorrect check broke matching the closing set of quotes. Update
tests to cover this case for XM config files, and update the domain schema
to allow more path characters.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
docs/schemas/domain.rng | 10 +-
Add an entry in fileTypeInfo for QED image files.
Signed-off-by: Adam Litke a...@us.ibm.com
Cc: Stefan Hajnoczi stefan.hajno...@uk.ibm.com
Cc: Anthony Liguori aligu...@linux.vnet.ibm.com
---
src/util/storage_file.c |9 -
src/util/storage_file.h |1 +
2 files changed, 9
If we don't escape ' or \ xend can't parse the generated sexpr. This
might over apply the EscapeSexpr routine, but it shouldn't hurt.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/util/buf.c | 79 +++
src/util/buf.h
Changes since V1:
- Fix virStorageFileMatchesVersion() for formats without version info
- Allow backingStore format probing for QED images since it is safe
Qemu is about to gain support for a new disk image format: QED. Details on
this format (including specification) can be found here:
Implement getBackingStore() for QED images. The header format is defined in
the QED spec: http://wiki.qemu.org/Features/QED .
Signed-off-by: Adam Litke a...@us.ibm.com
Cc: Stefan Hajnoczi stefan.hajno...@uk.ibm.com
Cc: Anthony Liguori aligu...@linux.vnet.ibm.com
---
src/util/storage_file.c |
Signed-off-by: Adam Litke a...@us.ibm.com
---
src/conf/domain_conf.c |4
src/util/storage_file.c |2 +-
src/util/storage_file.h |1 +
3 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 2d11785..a08c846 100644
---
On 11/19/2010 12:33 AM, Wen Congyang wrote:
At 2010-11-18 12:28, Eric Blake Write:
* src/util/memory.h (VIR_REALLOC_N): Update docs.
(VIR_EXPAND_N, VIR_SHRINK_N): New macros.
(virAlloc, virAllocN, virReallocN, virAllocVar, virFree): Add some
gcc attributes.
There may be a bug in this
On 11/12/2010 11:36 AM, Daniel P. Berrange wrote:
On Fri, Nov 12, 2010 at 10:21:16AM -0700, Eric Blake wrote:
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
The XML docs describe a 'port' attribute for the
storage source host element, but the parser never
handled it.
*
On 11/19/2010 05:29 AM, Osier Yang wrote:
* docs/schemas/domain.rng
---
docs/schemas/domain.rng |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
index bbbc846..815134d 100644
--- a/docs/schemas/domain.rng
+++
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
The Linux iSCSI initiator toolchain has the dubious feature that
if you ever run the 'sendtargets' command to merely query what
targets are available from a server, the results will be recorded
in /var/lib/iscsi. Any time the
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
Since the previous patch added support for parsing the output of
the 'sendtargets' command, it is now trivial to support the
storage pool discovery API.
Given a hostname and optional portnumber and initiator IQN,
the code can return a full
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
The code generating XML for storage pool source discovery is
hardcoded to only allow a hostname and optional port number.
Refactor this code to make it easier to add support for extra
parameters.
* tools/virsh.c: Refactor XML generator
---
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
Allow an iSCSI initiator IQN to be set with the XML for the
find-storage-pool-sources-as virsh command
* tools/virsh.c: Add iSCSI IQN support
---
tools/virsh.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
@@
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
The find-storage-pool-sources-as command takes two arguments,
a hostname and a port number. For some reason the code would
also then look for a port number appended to the hostname
string by searching for ':'. This totally breaks if the user
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
When libvirt starts up all storage pools default to the inactive
state, even if the underlying storage is already active on the
host. This introduces a new API into the internal storage backend
drivers that checks whether a storage pool is
On 11/19/2010 11:00 AM, Laine Stump wrote:
-param name=pattern[A-Za-z0-9_\.\+\-amp;:/]+/param
+param name=pattern[A-Za-z0-9_\.\+\-\\#amp;:/]+/param
/data
/define
define name=diskSerial
What's your motivation for this?
If domain.rng is used similarly to the other .rng files
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
Many operations are not valid on inactive storage pools. The
storage driver is currently returning VIR_ERR_INTERNAL_ERROR
in these cases, rather than the more suitable error code
VIR_ERR_OPERATION_INVALID
* src/storage/storage_driver.c: Fix
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
The SCSI volumes currently get a name like '17:0:0:1' based
on $host:$bus:$target:$lun. The names are intended to be unique
per pool and stable across pool restarts. The inclusion of the
$host component breaks this, because the $host number for
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote:
virsh was not checking for a error code when listing storage
volumes. So when listing volumes in a pool that was shutoff,
no output was displayed
* tools/virsh.c: Fix error handling when listing volumes
---
tools/virsh.c |6 ++
1
On 11/18/2010 04:20 AM, Osier Yang wrote:
Sorry for the trouble of patch names, anyone who would like
to push these patches, could you please help update it?
s|/4|/5|
Actually, git strips [PATCH 2/5] altogether; the resulting patch name
would be implement public API virDomainIsUpdated
On 11/18/2010 04:49 AM, Stefan Berger wrote:
V2:
- following Eric's suggestions from review of V1
- all scripts started by the main script trap on signal 2 and clean up
- the main program waits for all child processes to have terminated
- the test now requires each child process
On 11/18/2010 05:16 AM, Stefan Berger wrote:
The IP address learning thread was causing a deadlock when it
instantiated a filter while a filter update/change was ongoing. The
reason for this was the ordering of locks due to the following calls
virNWFilterUnlockFilterUpdates()
On 11/19/2010 09:15 AM, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/util/conf.c | 19 +++
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/util/conf.c b/src/util/conf.c
index ba1a384..a31bbc4 100644
---
On 11/19/2010 03:00 PM, Eric Blake wrote:
On 11/19/2010 09:15 AM, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/util/conf.c | 19 +++
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/util/conf.c b/src/util/conf.c
index
On 11/19/2010 09:15 AM, Cole Robinson wrote:
An incorrect check broke matching the closing set of quotes. Update
tests to cover this case for XM config files, and update the domain schema
to allow more path characters.
- param name=pattern/[a-zA-Z0-9_\.\+\-amp;/%]*/param
+ param
On 11/19/2010 09:15 AM, Cole Robinson wrote:
Since we send the sexpr to xend via HTTP, we need to properly escape
''
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/xen/xend_internal.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
ACK.
--
Eric Blake
On 11/19/2010 09:15 AM, Cole Robinson wrote:
If we don't escape ' or \ xend can't parse the generated sexpr. This
might over apply the EscapeSexpr routine, but it shouldn't hurt.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/util/buf.c | 79
On 11/19/2010 07:55 AM, Eduardo Otubo wrote:
I am moving all the UUID handling functions to phyp_uuid.[ch] files in
order not to bloat the main files phyp_driver.[ch] too much. Doing this
for two reasons:
1) Network management in pHyp does not have a UUID.
2) Need to create another
On 11/19/2010 03:38 PM, Eric Blake wrote:
On 11/19/2010 09:15 AM, Cole Robinson wrote:
An incorrect check broke matching the closing set of quotes. Update
tests to cover this case for XM config files, and update the domain schema
to allow more path characters.
- param
On 11/19/2010 07:55 AM, Eduardo Otubo wrote:
Now adding some basic operation network functions and its UUID
helpers.
---
src/phyp/phyp_driver.c | 202 ++-
src/phyp/phyp_uuid.c | 177 ++
On 11/19/2010 02:51 PM, Cole Robinson wrote:
On 11/19/2010 03:38 PM, Eric Blake wrote:
On 11/19/2010 09:15 AM, Cole Robinson wrote:
An incorrect check broke matching the closing set of quotes. Update
tests to cover this case for XM config files, and update the domain schema
to allow more path
On 11/19/2010 07:55 AM, Eduardo Otubo wrote:
Adding networkCreateXML, networkDestroy, networkIsActive and
networkLookupByName.
In the function phypCreateNetwork I just use the def-domain information to
create
the new network interface because of the behaviour of the HMC and the
On 11/19/2010 09:18 AM, Adam Litke wrote:
Disk image formats that wish to opt-out of version validation are supposed to
set versionOffset to -1 in their fileTypeInfo entry.
By unconditionally returning False for these formats,
virStorageFileMatchesVersion() incorrectly reports a version
On 11/19/2010 09:18 AM, Adam Litke wrote:
Add an entry in fileTypeInfo for QED image files.
Signed-off-by: Adam Litke a...@us.ibm.com
Cc: Stefan Hajnoczi stefan.hajno...@uk.ibm.com
Cc: Anthony Liguori aligu...@linux.vnet.ibm.com
---
src/util/storage_file.c |9 -
On 11/18/2010 04:42 PM, MORITA Kazutaka wrote:
On 2010/11/18 19:46, Daniel P. Berrange wrote:
On Wed, Nov 17, 2010 at 06:19:58PM +0900, MORITA Kazutaka wrote:
Sheepdog is a distributed storage system for QEMU. It provides highly
available block level storage volumes to VMs like Amazon EBS.
On 11/19/2010 09:18 AM, Adam Litke wrote:
Signed-off-by: Adam Litke a...@us.ibm.com
---
src/conf/domain_conf.c |4
src/util/storage_file.c |2 +-
src/util/storage_file.h |1 +
3 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/src/conf/domain_conf.c
On Fri, 2010-11-19 at 16:05 -0700, Eric Blake wrote:
Why no backing store extraction function? Not a show-stopper to this
patch, but something to consider adding.
Thanks for the review Eric. Please see patch 4 where I have implemented
qedGetBackingStore().
--
Thanks,
Adam
--
libvir-list
On 11/19/2010 09:18 AM, Adam Litke wrote:
Implement getBackingStore() for QED images. The header format is defined in
the QED spec: http://wiki.qemu.org/Features/QED .
Signed-off-by: Adam Litke a...@us.ibm.com
Cc: Stefan Hajnoczi stefan.hajno...@uk.ibm.com
Cc: Anthony Liguori
On 11/19/2010 09:18 AM, Adam Litke wrote:
Implement getBackingStore() for QED images. The header format is defined in
the QED spec: http://wiki.qemu.org/Features/QED .
+if (offset + size buf_size || offset + size offset)
+return BACKING_STORE_INVALID;
As currently coded,
On 11/18/2010 02:51 AM, Daniel P. Berrange wrote:
On Wed, Nov 17, 2010 at 09:28:59PM -0700, Eric Blake wrote:
From: Daniel P. Berrange berra...@redhat.com
---
src/conf/domain_conf.c |1 -
src/util/hooks.c |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
You might
On 11/18/2010 02:55 AM, Daniel P. Berrange wrote:
On Wed, Nov 17, 2010 at 09:29:00PM -0700, Eric Blake wrote:
From: Daniel P. Berrange berra...@redhat.com
This introduces a new set of APIs in src/util/command.h
to use for invoking commands. This is intended to replace
all current usage of
* cfg.mk (sc_prohibit_close): New syntax-check rule.
* src/util/pci.c (pciWaitForDeviceCleanup): Fix violation.
* .x-sc_prohibit_close: New exceptions.
* Makefile.am (EXTRA_DIST): Distribute new file.
---
As promised, here's my followup to Stefan's recent close() cleanups,
which will help us
On 20/11/2010, at 5:45 AM, Eric Blake ebl...@redhat.com wrote:
\s and \S are GNU-isms, and regcomp() on other platforms will reject it;
is this regex only used on Linux, or do we need to be portable to iscsi
implementations on other platforms?
As a data point, there are other iSCSI
On 11/19/2010 02:09 PM, Eric Blake wrote:
On 11/18/2010 04:49 AM, Stefan Berger wrote:
V2:
- following Eric's suggestions from review of V1
- all scripts started by the main script trap on signal 2 and clean up
- the main program waits for all child processes to have terminated
On 11/19/2010 02:49 PM, Eric Blake wrote:
On 11/18/2010 05:16 AM, Stefan Berger wrote:
The IP address learning thread was causing a deadlock when it
instantiated a filter while a filter update/change was ongoing. The
reason for this was the ordering of locks due to the following calls
于 2010年11月20日 02:57, Eric Blake 写道:
On 11/18/2010 04:20 AM, Osier Yang wrote:
Sorry for the trouble of patch names, anyone who would like
to push these patches, could you please help update it?
s|/4|/5|
Actually, git strips [PATCH 2/5] altogether; the resulting patch name
would be implement
于 2010年11月20日 02:00, Laine Stump 写道:
On 11/19/2010 05:29 AM, Osier Yang wrote:
* docs/schemas/domain.rng
---
docs/schemas/domain.rng | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
index bbbc846..815134d 100644
---
于 2010年11月20日 02:41, Eric Blake 写道:
On 11/19/2010 11:00 AM, Laine Stump wrote:
-param name=pattern[A-Za-z0-9_\.\+\-amp;:/]+/param
+param name=pattern[A-Za-z0-9_\.\+\-\\#amp;:/]+/param
/data
/define
define name=diskSerial
What's your motivation for this?
If domain.rng is used
60 matches
Mail list logo
