Re: [libvirt] Bootstrap fail, but non-useful message :/

2010-11-30 Thread Justin Clift
(resending, missed including the list first time. Also reworded some bits) On 30/11/2010, at 10:51 AM, Eric Blake wrote: > On 11/29/2010 06:23 AM, Justin Clift wrote >> configure.ac:13: warning: macro `AM_SILENT_RULES' not found in library > > Warning, but harmless. We might be able to silence

Re: [libvirt] [PATCH 0/2] Add unit tests for internal CPU APIs

2010-11-30 Thread Jiri Denemark
> > *** BLURB HERE *** > > Ignoring git's hint to add an overview, are we? :) Not really ignoring, just not noticing and forgetting :-) > > Jiri Denemark (2): > > cpu: Add support for overriding path to CPU map XML file > > tests: Add unit tests for internal CPU APIs > > ACK series, but sho

Re: [libvirt] [PATCH 2/8] Basic framework for lock manager plugins

2010-11-30 Thread Daniel P. Berrange
On Wed, Nov 24, 2010 at 03:08:41PM -0500, David Teigland wrote: > On Mon, Nov 22, 2010 at 06:09:21PM +, Daniel P. Berrange wrote: > > +/* > > + * Flags to pass to 'load_drv' and also 'new_drv' method > > + * Plugins must support at least one of the modes. If a > > + * mode is unsupported, it mu

Re: [libvirt] [PATCH 2/8] Basic framework for lock manager plugins

2010-11-30 Thread Daniel P. Berrange
On Mon, Nov 29, 2010 at 02:49:26PM -0500, David Teigland wrote: > On Wed, Nov 24, 2010 at 03:08:41PM -0500, David Teigland wrote: > > LOCK_MODE_NONE - the lock manager is unused, and it's up to the > > application to do its own locking or coordination when accessing the > > resource, e.g. if there'

[libvirt] [PATCH] Log client errors in libvirtd at debug priority

2010-11-30 Thread Matthias Bolte
This reverts commit Log all errors at level INFO to stop polluting syslog 04bd0360f32ec628ecf7943b3fd1468d6eb2dde5. and makes virRaiseErrorFull() log errors at debug priority when called from inside libvirtd. This stops libvirtd from polluting it's own log with client errors at error priority t

Re: [libvirt] [PATCH] Log client errors in libvirtd at debug priority

2010-11-30 Thread Daniel Veillard
On Tue, Nov 30, 2010 at 03:22:59PM +0100, Matthias Bolte wrote: > This reverts commit > > Log all errors at level INFO to stop polluting syslog > 04bd0360f32ec628ecf7943b3fd1468d6eb2dde5. > > and makes virRaiseErrorFull() log errors at debug priority > when called from inside libvirtd. This sto

Re: [libvirt] [PATCH 0/2] Add unit tests for internal CPU APIs

2010-11-30 Thread Eric Blake
On 11/30/2010 03:09 AM, Jiri Denemark wrote: >>> *** BLURB HERE *** >> >> Ignoring git's hint to add an overview, are we? :) > > Not really ignoring, just not noticing and forgetting :-) > >>> Jiri Denemark (2): >>> cpu: Add support for overriding path to CPU map XML file >>> tests: Add unit

Re: [libvirt] [PATCH] Log client errors in libvirtd at debug priority

2010-11-30 Thread Matthias Bolte
2010/11/30 Daniel Veillard : > On Tue, Nov 30, 2010 at 03:22:59PM +0100, Matthias Bolte wrote: >> This reverts commit >> >>  Log all errors at level INFO to stop polluting syslog >>  04bd0360f32ec628ecf7943b3fd1468d6eb2dde5. >> >> and makes virRaiseErrorFull() log errors at debug priority >> when c

Re: [libvirt] [PATCH] OpenVZ: take veid from vmdef->name when defining new domains

2010-11-30 Thread Guido Günther
On Mon, Nov 29, 2010 at 04:23:37PM -0700, Eric Blake wrote: > On 11/28/2010 05:32 PM, Guido Günther wrote: > > Hi, > > We currently use the next free veid although there's one given in the > > domain xml. This currently breaks defining new domains since vmdef->name > > and veid don't match leading

Re: [libvirt] [PATCH v2] 802.1Qbg: use pre-associate state at beginning of incoming migration

2010-11-30 Thread Stefan Berger
On 11/29/2010 06:15 PM, Eric Blake wrote: On 11/24/2010 06:39 AM, Stefan Berger wrote: -v2: - changing the vmOpStr array and vmOperation enum to use VIR_ENUM_IMPL and VIR_ENUM_DECL. Renaming the enum to virVMOperationType and adapting the name of the enum constants. This patch introduces t

[libvirt] [PATCH 7/n] qemu: plug memory leak

2010-11-30 Thread Eric Blake
* src/qemu/qemu_driver.c (qemudShutdown): Free all strings and the ebtables structure. * src/libvirt_private.syms (ebtablesContextFree): Export missing symbol. * src/util/ebtables.c (ebtablesContextFree): Allow early exit. --- This leak triggers on every start/stop of a qemu domain, although it ty

[libvirt] [PATCH 6/n] libvirtd: avoid memory leak on shutdown

2010-11-30 Thread Eric Blake
* daemon/libvirtd.c (qemudRunLoop): Free any remaining client data. --- Since qemudCleanup calls VIR_FREE(server), it only makes sense to first free all of server's contents. Probably not the most important leak to plug (it only triggers at libvirtd exit, where the memory would be abandoned by pr

Re: [libvirt] [PATCH 2/8] Basic framework for lock manager plugins

2010-11-30 Thread David Teigland
On Tue, Nov 30, 2010 at 10:20:38AM +, Daniel P. Berrange wrote: > The AttachObject/DetachObject calls are made by libvirtd, whenever > it is about todo something on behalf of the managed object holding > the lock. eg when libvirtd does disk hotplug it will do > > $man = NewObject() > A

Re: [libvirt] [PATCH 5/n] security: plug memory leak

2010-11-30 Thread Eric Blake
On 11/24/2010 02:57 PM, Eric Blake wrote: > security_context_t happens to be a typedef for char*, and happens to > begin with a string usable as a raw context string. But in reality, > it is an opaque type that may or may not have additional information > after the first NUL byte, where that addit

Re: [libvirt] [PATCH v2] 802.1Qbg: use pre-associate state at beginning of incoming migration

2010-11-30 Thread Daniel Veillard
On Wed, Nov 24, 2010 at 08:39:23AM -0500, Stefan Berger wrote: [...] > Gerhard successfully tested the patch with a recent blade network > 802.1Qbg-compliant switch. [...] > The patch should not have any side-effects on the 802.1Qbh support > in libvirt, but Roopa (cc'ed) may want to verify this. >

[libvirt] Release of libvirt 0.8.6

2010-11-30 Thread Daniel Veillard
As indicated 10 days ago, today was time for a release, I didn't had much time so I simply generated a release from libvirt git without much testing. Hopefully this will be okay ! Release is available as usual at ftp://libvirt.org/libvirt/ There is actually a number of significant feature

Re: [libvirt] libvirt-0.8.5 sometimes crahing

2010-11-30 Thread Nikola Ciprich
> > Unfortunately, I'm not seeing a local race: > > } else if (!priv->jobActive) { > if (qemuDomainObjBeginJob(vm) < 0) > goto cleanup; > if (!virDomainObjIsActive(vm)) > err = 0; > else { > qemuDomainObjE

[libvirt] [PATCH] maint: allow 'make syntax-check' to run again

2010-11-30 Thread Eric Blake
* .x-sc_prohibit_xmlGetProp: Add exception. --- docs/news.html.in broke 'make syntax-check' again (how many releases have we done with that issue?) This is alternative 1. However, I won't push this, if alternative 2 pans out. .x-sc_prohibit_xmlGetProp |1 + 1 files changed, 1 insertions(+)

[libvirt] [PATCH] maint: allow 'make syntax-check' to run again

2010-11-30 Thread Eric Blake
* cfg.mk (VC_LIST_ALWAYS_EXCLUDE_REGEX): Permanently exempt docs/news.html.in from all future syntax checks. --- Alternate 2. It panned out :) and should save us from having to deal with this the next time news.html.in sucks in a commit message that breaks a syntax check. I'm pushing this under

Re: [libvirt] [v3] virsh: Categorize commands into groups for virsh help

2010-11-30 Thread Eric Blake
On 11/30/2010 12:27 AM, Justin Clift wrote: > On 30/11/2010, at 5:37 PM, Osier Yang wrote: >> Change the virsh help out. The new output of "virsh help" and >> "virsh --help" will be like: > > ACK. Pushed, now that 0.8.6 is out. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtua

Re: [libvirt] [PATCH v3 1/5] Add a threadpool implementation

2010-11-30 Thread Eric Blake
On 11/30/2010 12:14 AM, Hu Tao wrote: > --- > src/Makefile.am |1 + > src/util/threadpool.c | 140 > + > src/util/threadpool.h | 35 > 3 files changed, 176 insertions(+), 0 deletions(-) > create mode 100644 src/util/thread

[libvirt] Looking for Hypervisor Vulerability Example

2010-11-30 Thread Shi Jin
Hi there, I am researching on virtualization security and particularly on sVirt. >From this sVirt presentation[1] and this RHEL-6 documentation on sVirt [2], I >read: If there is a security flaw in the hypervisor that can be exploited by a guest instance, this guest may be able to not only at

Re: [libvirt] [PATCH v3 2/5] Fall back to QEMUD_SAVE_FORMAT_RAW if compression method fails.

2010-11-30 Thread Eric Blake
On 11/30/2010 12:12 AM, Hu Tao wrote: > When dumping a domain, it's reasonable to save dump-file in raw format > if dump format is misconfigured or the corresponding compress program > is not available rather then fail dumping. Makes sense to me. > --- > src/qemu/qemu_driver.c | 39 +++

Re: [libvirt] [PATCH v3 3/5] Add a new function doCoreDump

2010-11-30 Thread Eric Blake
On 11/30/2010 12:13 AM, Hu Tao wrote: > This patch prepares for the next patch. > --- > src/qemu/qemu_driver.c | 145 > ++-- > 1 files changed, 78 insertions(+), 67 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index

Re: [libvirt] [PATCH v3 4/5] Add a watchdog action `dump'

2010-11-30 Thread Eric Blake
On 11/30/2010 12:13 AM, Hu Tao wrote: > `dump' watchdog action lets libvirtd to dump the guest when receives a > watchdog event (which probably means a guest crash) > > Currently only qemu is supported. > --- > src/Makefile.am|2 +- > src/conf/domain_conf.c |1 + > src/conf/domain

Re: [libvirt] [v3] virsh: Categorize commands into groups for virsh help

2010-11-30 Thread Osier Yang
于 2010年12月01日 04:39, Eric Blake 写道: On 11/30/2010 12:27 AM, Justin Clift wrote: On 30/11/2010, at 5:37 PM, Osier Yang wrote: Change the virsh help out. The new output of "virsh help" and "virsh --help" will be like: ACK. Pushed, now that 0.8.6 is out. Thanks Eric - Osier -- libvir-list

[libvirt] [PATCH 8/n] selinux: avoid memory overhead of matchpathcon

2010-11-30 Thread Eric Blake
* src/security/security_selinux.c (SELinuxRestoreSecurityFileLabel): Use selabel_lookup instead of matchpathcon. Suggested by Daniel Walsh. --- Makes the huge difference that I originally thought I'd get with patch 5/n earlier in the series. Beforehand, when trying to start a single kvm guest the

Re: [libvirt] [PATCH 8/n] selinux: avoid memory overhead of matchpathcon

2010-11-30 Thread Eric Blake
On 11/30/2010 08:54 PM, Eric Blake wrote: > * src/security/security_selinux.c > (SELinuxRestoreSecurityFileLabel): Use selabel_lookup instead of > matchpathcon. > Suggested by Daniel Walsh. https://bugzilla.redhat.com/show_bug.cgi?id=658657 > @@ -380,14 +382,16 @@ SELinuxRestoreSecurityFileLabel(