On Tue, Dec 07, 2010 at 01:46:40AM -0500, Laine Stump wrote:
This is in reference to the following bugs that are filed against
RHEL, but applicable to all Linux distros:
https://bugzilla.redhat.com/show_bug.cgi?id=560994
https://bugzilla.redhat.com/show_bug.cgi?id=609463
MAC address of
On 07/12/2010, at 6:25 PM, Osier Yang wrote:
echo is already in group virsh, freecell and hostname are
already in group host, so remove them from group domain
* tools/virsh.c
---
ACK.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 12/07/2010 05:23 AM, Daniel P. Berrange wrote:
On Tue, Dec 07, 2010 at 01:46:40AM -0500, Laine Stump wrote:
2) When a bridge's MAC address is set in that way, as Daniel says,
no traffic passes. (Why is that, anyway?)
A bridge device *must* have a MAC address that machines one of
its
On 12/07/2010 07:20 AM, Justin Clift wrote:
On 07/12/2010, at 6:25 PM, Osier Yang wrote:
echo is already in group virsh, freecell and hostname are
already in group host, so remove them from group domain
* tools/virsh.c
---
ACK.
Pushed.
--
Eric Blake ebl...@redhat.com
Hello,
I just encountered a problem with the current snapshot implementation for
qemu/kvm: To revert back to a snapshot, the domain description must closely
match the domain description when the snapshot was created. If the ram-size
doesn't match or the VM now contains fewer CPUs or contains
starting a service during rpm installation is impolite. It is even worse if done
during upgrade, for a service that was explicitly turned off.
---
libvirt.spec.in |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index
On 12/05/2010 12:57 AM, Daniel Veillard wrote:
On Fri, Dec 03, 2010 at 02:56:14PM -0700, Eric Blake wrote:
The log lists things like -smbios type=1,vendor=Red Hat, which
is great for shell parsing, but not so great when you realize that
execve() then passes those literal on as part of the
tests/commandtest.c | 55
+-
1 files changed, 36 insertions(+), 19 deletions(-)
ACK: No semantic changes.
Thanks, I pushed this and patch 4.
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
* src/util/command.c (virCommandAddEnvString): Remove duplicate
code.
(virCommandToString, virCommandRun, virCommandRunAsync)
(virCommandWait): Report NULL command as ENOMEM, not invalid
usage.
Reported by Jiri Denemark.
---
New patch. Fixes the root cause, so that patch 2 can
be
Most leaks could only occur on error cleanup paths.
---
Respin of Jiri's 2/4 v1 patch, now much smaller by relying
on guaranteed semantics.
Jiri's patch 1 and 4 of the v1 series are still okay to apply
as-is, but patch 3/4 needs rebasing onto this patch.
tests/commandtest.c | 72
---
src/qemu/qemu_conf.c |2 +-
src/qemu/qemu_conf.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index d81e6cc..08c084b 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -1449,7 +1449,7 @@ int
On Tue, Dec 07, 2010 at 06:24:45PM +0100, Jiri Denemark wrote:
---
src/qemu/qemu_conf.c |2 +-
src/qemu/qemu_conf.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index d81e6cc..08c084b 100644
---
On 12/06/2010 05:03 AM, Jiri Denemark wrote:
---
tests/commandtest.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/tests/commandtest.c b/tests/commandtest.c
index 48c6335..e8decd3 100644
--- a/tests/commandtest.c
+++ b/tests/commandtest.c
@@ -587,12
On 12/07/2010 10:24 AM, Jiri Denemark wrote:
---
src/qemu/qemu_conf.c |2 +-
src/qemu/qemu_conf.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index d81e6cc..08c084b 100644
--- a/src/qemu/qemu_conf.c
+++
Hi all,
Just put a (temporary) page on the wiki showing all of the virsh commands, the
version of libvirt each was introduced in, and the commit that did it.
http://wiki.libvirt.org/page/VirshCmdAdditionCommits
It's very raw data style, and at some point in the next week the info will
get
On 12/07/2010 10:40 AM, Eric Blake wrote:
+++ b/src/qemu/qemu_conf.h
@@ -44,7 +44,7 @@
# include macvtap.h
# include command.h
-# define qemudDebug(fmt, ...) do {} while(0)
+# define qemudDebug DEBUG
ACK. Hmm; should we rename the use of qemudDebug in daemon/libvirtd.c
to something
---
src/qemu/qemu_conf.c |8
src/qemu/qemu_conf.h |2 --
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index d81e6cc..e5d0206 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -1449,12 +1449,12 @@ int
Here are patches on top of Kazutaka's v2 to add RBD support and fix
some general network disk problems. There's also a test for each type
of network disk.
Josh Durgin (2):
qemu: Add RBD support and some network disk fixes
tests: Add tests for network disks
docs/schemas/domain.rng
Changes common to all network disks:
-Make source name optional in the domain schema, since NBD doesn't use it
-Add a hostName type to the domain schema, and use it instead of genericName,
which doesn't include .
-Don't leak host names or ports
-Set the source protocol in qemuParseCommandline
* src/openvz/openvz_conf.c (openvzLoadDomains): Replace unsafe
sscanf with safe direct parsing.
(openvzGetVEID): Avoid lost integer overflow detection.
(openvzAssignUUIDs): Likewise, and detect readdir failure.
---
v2: new patch; plugs a potential security hole, since
* src/util/sysinfo.c (virSysinfoRead): Use virCommand instead of
virExec.
---
v2: remove unused variable, rebase on top of whitespace cleanups.
This patch is awaiting review on these prerequisites:
https://www.redhat.com/archives/libvir-list/2010-December/msg00318.html
2010/12/7 Eric Blake ebl...@redhat.com:
* src/openvz/openvz_conf.c (openvzLoadDomains): Replace unsafe
sscanf with safe direct parsing.
(openvzGetVEID): Avoid lost integer overflow detection.
(openvzAssignUUIDs): Likewise, and detect readdir failure.
---
v2: new patch; plugs a potential
2010/12/7 Eric Blake ebl...@redhat.com:
* docs/internals/command.html.in: Better documentation of buffer
vs. fd considerations.
* src/util/command.c (virCommandRunAsync): Reject raw execution
with string io.
(virCommandRun): Reject execution with user-specified fds not
visiting a regular
2010/12/7 Eric Blake ebl...@redhat.com:
Guarantee that outbuf/errbuf are allocated on success, even if to the
empty string. Caller always has to free the result, and empty output
check requires checking if *outbuf=='\0'. Makes the API easier to use
safely. Failure is best effort allocation
2010/12/7 Eric Blake ebl...@redhat.com:
popen must be matched with pclose (not fclose), or it will leak
resources. Furthermore, it is a lousy interface when it comes to
signal handling. We're much better off using our decent command
wrapper. Note that virCommand guarantees that
On 12/07/2010 02:59 PM, Matthias Bolte wrote:
2010/12/7 Eric Blake ebl...@redhat.com:
* docs/internals/command.html.in: Better documentation of buffer
vs. fd considerations.
* src/util/command.c (virCommandRunAsync): Reject raw execution
with string io.
(virCommandRun): Reject execution with
On 12/07/2010 03:17 PM, Matthias Bolte wrote:
+if (!outbuf || *outbuf) {
+puts(output string not allocated);
The error message doesn't fit to the *outbuf != \0 test.
Fixed by squashing this in:
diff --git i/tests/commandtest.c w/tests/commandtest.c
index 9dea6f3..e956205 100644
On 12/07/2010 02:49 PM, Matthias Bolte wrote:
2010/12/7 Eric Blake ebl...@redhat.com:
* src/openvz/openvz_conf.c (openvzLoadDomains): Replace unsafe
sscanf with safe direct parsing.
(openvzGetVEID): Avoid lost integer overflow detection.
(openvzAssignUUIDs): Likewise, and detect readdir
---
tools/virsh.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 9ce3202..6c48a62 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -10062,7 +10062,6 @@ static const vshCmdDef nodedevCmds[] = {
{nodedev-list, cmdNodeListDevices,
On 12/07/2010 04:08 PM, Justin Clift wrote:
---
tools/virsh.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
ACK; nodedev is for managing devices attached to a node, but nodeinfo is
more generic than that.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt
On 08/12/2010, at 10:16 AM, Eric Blake wrote:
On 12/07/2010 04:08 PM, Justin Clift wrote:
---
tools/virsh.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
ACK; nodedev is for managing devices attached to a node, but nodeinfo is
more generic than that.
Thanks Eric. Pushed. :)
* .gnulib: Update to latest, for at least a stdint.h fix
* src/storage/storage_driver.c (storageVolumeZeroSparseFile)
(storageWipeExtent): Use better type, although it still triggers
spurious -Wformat warning on MacOS's gcc.
---
* .gnulib 48b1a1a...6491120 (47):
unistr/u8-strcmp: Avoid
This fixes a misleading error message saying the libnl package
needs to be installed, when it's really the libnl-devel package
needing to be installed.
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index d26bc68..dde2cde
On 08/12/2010, at 11:32 AM, Eric Blake wrote:
* .gnulib: Update to latest, for at least a stdint.h fix
Thanks for spending the time on this Eric.
ACK to this.
snip
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 0f099f0..67d043b 100644
---
On 12/07/2010 05:40 PM, Justin Clift wrote:
This fixes a misleading error message saying the libnl package
needs to be installed, when it's really the libnl-devel package
needing to be installed.
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
On 12/07/2010 06:01 PM, Justin Clift wrote:
On 08/12/2010, at 11:32 AM, Eric Blake wrote:
* .gnulib: Update to latest, for at least a stdint.h fix
Thanks for spending the time on this Eric.
ACK to this.
Thanks; pushed.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt
On 08/12/2010, at 1:05 PM, Eric Blake wrote:
On 12/07/2010 05:40 PM, Justin Clift wrote:
This fixes a misleading error message saying the libnl package
needs to be installed, when it's really the libnl-devel package
needing to be installed.
---
configure.ac |2 +-
1 files changed, 1
---
tools/virsh.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 6c48a62..4e37f2d 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -2894,8 +2894,9 @@ cmdSetmaxmem(vshControl *ctl, const vshCmd *cmd)
* memtune command
*/
于 2010年12月08日 12:20, Justin Clift 写道:
---
tools/virsh.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 6c48a62..4e37f2d 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -2894,8 +2894,9 @@ cmdSetmaxmem(vshControl *ctl, const
---
src/util/command.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/util/command.c b/src/util/command.c
index c0520ec..473d1fc 100644
--- a/src/util/command.c
+++ b/src/util/command.c
@@ -956,6 +956,8 @@ virCommandRun(virCommandPtr cmd, int *exitstatus)
* src/util/threadpool.c, src/util/threadpool.h: Thread pool
implementation
* src/Makefile.am: Build thread pool
* src/libvirt_private.syms: Export public functions
---
cfg.mk |1 +
src/Makefile.am |1 +
src/libvirt_private.syms |6 +
src/util/threadpool.c
This patch prepares for the next patch.
---
src/qemu/qemu_driver.c | 132 +++-
1 files changed, 74 insertions(+), 58 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f5164e1..bf101fc 100644
--- a/src/qemu/qemu_driver.c
This patch series adds a new watchdog action `dump' which lets libvirtd
can do auto-dump when receiving a watchdog event from qemu guest.
In order to make the function work, there must be a watchdog device
added to guest, and guest must have a watchdog daemon running, for
example,
`dump' watchdog action lets libvirtd to dump the guest when receives a
watchdog event (which probably means a guest crash)
Currently only qemu is supported.
---
src/conf/domain_conf.c |1 +
src/conf/domain_conf.h |1 +
src/qemu/libvirtd_qemu.aug |1 +
---
daemon/libvirtd.c | 187 -
daemon/libvirtd.h | 16 +
2 files changed, 30 insertions(+), 173 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 791b3dc..229c0cc 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
?Hi,
here is another patch for C# bindings. I have update our project DAVIM with
latest C# bindings and it show some naming errors. This patch correct it.
Arnaud
0001-Naming-update-in-Node-and-StoragePool-classes.patch
Description: Binary data
--
libvir-list mailing list
libvir-list@redhat.com
The new version lists every virsh command, its description, and
the version of libvirt where it became available.
---
docs/virshcmdref.html.in | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/docs/virshcmdref.html.in b/docs/virshcmdref.html.in
index
On 08/12/2010, at 5:36 PM, Justin Clift wrote:
The new version lists every virsh command, its description, and
the version of libvirt where it became available.
---
docs/virshcmdref.html.in | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git
48 matches
Mail list logo
