When attaching a device that already exists, xend driver updates
the device with device_configure, it causes problems (e.g. for
disk device, it only can be used to update device like CDROM),
and actually we provide additional API (virDomainUpdateDevice) to
update device, this fix is to raise up
On 21/12/2010, at 6:52 AM, Eric Blake wrote:
ACK to your additions, and coupled with your ACK of the rest of my
patch, this passed testing on Fedora 14, RHEL 5, a Linux-hosted
cross-build to mingw, and a native cygwin build, so I've gone ahead and
pushed it.
Thanks guys. This also fixed the
* libvirt.spec.in: Provide vmware conditionals.
---
Would you mind preparing a followup patch that modifies libvirt.spec.in
to make it configurable when building an rpm whether vmware support is
built in? See commit e3e31303d54e for an example.
I went ahead and did this, since it was
* autobuild.sh: Alter mingw configuration setup.
---
And a followup to allow autobuild.sh completion when a mingw
cross-toolchain is present.
autobuild.sh |2 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/autobuild.sh b/autobuild.sh
index 91e2ab2..4cb9fde
Hi all,
Has anyone looked at adding support for Parallels virtualisation products, or
have any idea if it's even possible? Google isn't showing much in the way
of search results, so not sure it's been looked at before.
These are the server oriented products:
Hi all,
There's a lot of documentation for libvirt that needs improving, so wondering
if anyone would be interested in forming a libvirt docs team to help make
that happen?
While some of the documentation needs people familiar with specific pieces
of libvirt, there's also a lot that doesn't, and
On 12/21/2010 11:53 AM, Justin Clift wrote:
Hi all,
There's a lot of documentation for libvirt that needs improving, so wondering
if anyone would be interested in forming a libvirt docs team to help make
that happen?
While some of the documentation needs people familiar with specific
Hi Justin,
I can offer some free time :)
Anthony Davis.
On 21 Dec 2010, at 10:53, Justin Clift jcl...@redhat.com wrote:
Hi all,
There's a lot of documentation for libvirt that needs improving, so wondering
if anyone would be interested in forming a libvirt docs team to help make
that
On 12/20/2010 07:30 PM, Josh Durgin wrote:
Network disks are accessed by qemu directly, and have no
associated file on the host, so checking for file ownership etc.
is unnecessary.
Signed-off-by: Josh Durgin jo...@hq.newdream.net
---
src/conf/domain_conf.c |2 +-
On 12/20/2010 11:47 PM, Osier Yang wrote:
a more efficient solution would be to check if errno
is ELOOP or ENOENT (the only possibilities for a dangling symlink; any
other error should return -1), and in those two cases a successful
lstat() is sufficient to detect a broken symlink without
On 12/20/2010 11:45 PM, Osier Yang wrote:
If there is a dangling symbolic link in filesystem pool, the pool
will fail to start or refresh, this patch is to fix it by ignoring
it with a warning log.
---
src/storage/storage_backend.c| 10 +-
src/storage/storage_backend_fs.c |
On 12/20/2010 11:45 PM, Osier Yang wrote:
If there is a dangling symbolic link in filesystem pool, the pool
will fail to start or refresh, this patch is to fix it by ignoring
it with a warning log.
if ((fd = open(path, O_RDONLY|O_NONBLOCK|O_NOCTTY)) 0) {
+if (stat(path, sb) 0
On 21/12/2010, at 10:15 PM, Anthony Davis wrote:
Hi Justin,
I can offer some free time :)
Awesome Anthony, very welcome. :)
There's a pretty broad spectrum of things we need to get improved. :)
From stuff that doesn't take any real virtualisation knowledge:
+ The new Virsh Command
On 12/21/2010 03:11 AM, Jiri Denemark wrote:
* autobuild.sh: Alter mingw configuration setup.
---
And a followup to allow autobuild.sh completion when a mingw
cross-toolchain is present.
autobuild.sh |2 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/autobuild.sh
On 21/12/2010, at 10:32 PM, Zdenek Styblik wrote:
Hello Justin,
could you be more specific, please? How to put it. Your e-mail is too
ambiguous for me :)
Heh, no worries. I often talk in general terms first. :)
The email response to Anthony, sent a few minutes ago, has more detail.
I know
On 12/21/2010 02:59 AM, Jiri Denemark wrote:
* libvirt.spec.in: Provide vmware conditionals.
---
Would you mind preparing a followup patch that modifies libvirt.spec.in
to make it configurable when building an rpm whether vmware support is
built in? See commit e3e31303d54e for an example.
On 22/12/2010, at 3:23 AM, Scott Baker wrote:
On 12/21/2010 03:15 AM, Anthony Davis wrote:
Hi Justin,
I can offer some free time:)
I'd be willing to contribute to a wiki if we had the docs in a wiki.
Yeah I know what you mean. Wiki's are *so* much easier to work with and
revise,
On 12/21/2010 09:03 AM, Matthias Bolte wrote:
Now the VMware driver doesn't depend on the ESX driver anymore.
Add a WITH_VMX option that depends on WITH_ESX and WITH_VMWARE.
Also add a libvirt_vmx.syms file.
Move some escaping functions from esx_util.c to vmx.c.
Adapt the test suite,
On 22/12/2010, at 4:40 AM, Eric Blake wrote:
snip
'git diff' is so awesome with renames :)
Hmmm recently had a problem with it where it *insisted* that one of the
100+ files
in a git repo I'd been messing with was a rename of a different file... even
when it wasn't.
(significantly
On 12/21/2010 10:50 AM, Justin Clift wrote:
On 22/12/2010, at 4:40 AM, Eric Blake wrote:
snip
'git diff' is so awesome with renames :)
Hmmm recently had a problem with it where it *insisted* that one of the
100+ files
in a git repo I'd been messing with was a rename of a different
On 22/12/2010, at 4:57 AM, Eric Blake wrote:
On 12/21/2010 10:50 AM, Justin Clift wrote:
On 22/12/2010, at 4:40 AM, Eric Blake wrote:
snip
'git diff' is so awesome with renames :)
Hmmm recently had a problem with it where it *insisted* that one of the
100+ files
in a git repo I'd
All,
I'll preface this by saying that I'm not 100% sure I'm correct. But I
still think there may be an API break that was introduced with the VMware
player driver. In include/libvirt/virterror.h, VIR_FROM_VMWARE was added to
the *middle* of the enum for virErrorDomain. If any clients of
* src/util/command.c (virCommandRun): Don't capture output on
daemons.
* tests/commandtest.c (test18): Expose the bug.
Reported by Laine Stump.
---
Even though 'test4' in commandtest created a daemon, the daemon
exits rather quickly, so that no one noticed the problem. And
the existing qemu
On 12/21/2010 11:34 AM, Chris Lalancette wrote:
All,
I'll preface this by saying that I'm not 100% sure I'm correct. But I
still think there may be an API break that was introduced with the VMware
player driver. In include/libvirt/virterror.h, VIR_FROM_VMWARE was added to
the *middle*
On 12/21/2010 01:54 PM, Eric Blake wrote:
* src/util/command.c (virCommandRun): Don't capture output on
daemons.
* tests/commandtest.c (test18): Expose the bug.
Reported by Laine Stump.
---
Even though 'test4' in commandtest created a daemon, the daemon
exits rather quickly, so that no one
2010/12/21 Eric Blake ebl...@redhat.com:
On 12/21/2010 11:34 AM, Chris Lalancette wrote:
All,
I'll preface this by saying that I'm not 100% sure I'm correct. But I
still think there may be an API break that was introduced with the VMware
player driver. In include/libvirt/virterror.h,
On 12/21/2010 12:40 PM, Laine Stump wrote:
On 12/21/2010 01:54 PM, Eric Blake wrote:
* src/util/command.c (virCommandRun): Don't capture output on
daemons.
* tests/commandtest.c (test18): Expose the bug.
Reported by Laine Stump.
---
Even though 'test4' in commandtest created a daemon, the
* daemon/Makefile.am: Avoid spurious space before tabs.
* src/Makefile.am: Likewise.
* examples/dominfo/Makefile.am: Likewise.
* examples/domsuspend/Makefile.am: Likewise.
* tools/Makefile.am: Likewise.
* src/datatypes.h (VIR_CONNECT_MAGIC): Likewise.
* src/internal.h (TODO): Likewise.
*
This patch fixes https://bugzilla.redhat.com/show_bug.cgi?id=664406
If qemu is run as a different uid, it has been unable to access mode
0660 files that are owned by a different user, but with a group that
the qemu is a member of (aside from the one group listed in the passwd
file). initgroups
On 12/20/2010 06:40 PM, Eric Blake wrote:
On 12/20/2010 01:03 AM, Laine Stump wrote:
virSocketPrefixToNetmask: Given a 'prefix', which is the number of 1
bits in a netmask, fill in a virSocketAddr object with a netmask as an
IP address (IPv6 or IPv4).
virSocketAddrMask: Mask off the host bits
2010/12/20 Eric Blake ebl...@redhat.com:
On 12/20/2010 12:04 PM, Matthias Bolte wrote:
Connecting to a ESX(i) server that is part of a cluster failed
when the connection also involved a vCenter.
Accept ClusterComputeResource type in addition to ComputeResource
type in the object lookup
2010/12/21 Eric Blake ebl...@redhat.com:
On 12/21/2010 09:03 AM, Matthias Bolte wrote:
Now the VMware driver doesn't depend on the ESX driver anymore.
Add a WITH_VMX option that depends on WITH_ESX and WITH_VMWARE.
Also add a libvirt_vmx.syms file.
Move some escaping functions from
All other drivers are explicitly linked to gnulib. The VMware
driver lacked this, resulting in mdir_name being an undefine
symbol.
Explicitly link the VMware driver to gnulib to fix this.
---
src/Makefile.am |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/Makefile.am
On 12/21/2010 01:45 PM, Laine Stump wrote:
This patch fixes https://bugzilla.redhat.com/show_bug.cgi?id=664406
If qemu is run as a different uid, it has been unable to access mode
0660 files that are owned by a different user, but with a group that
the qemu is a member of (aside from the one
On 12/20/2010 06:52 PM, Eric Blake wrote:
On 12/20/2010 01:03 AM, Laine Stump wrote:
Later patches will add the possibility to define a network's netmask
as a prefix (0-32, or 0-128 in the case of IPv6). To make it easier to
deal with definition of both kinds (prefix or netmask), add two new
On 12/21/2010 02:51 PM, Matthias Bolte wrote:
All other drivers are explicitly linked to gnulib. The VMware
driver lacked this, resulting in mdir_name being an undefine
symbol.
That's the minimum impact on glibc. The impact on other systems like
mingw would be even bigger, due to lots of
Fix glitch in commit cddd2a06 (thankfully post-0.8.6, so no
released version has the glitch).
Document and try to workaround glitch in commit 46e9b0f (in 0.8.0,
which invalidated 6 virErrorNumber dating back to 0.7.1).
Thankfully, my audit did not find any other glitches until pre-0.1.0
days.
2010/12/21 Eric Blake ebl...@redhat.com:
On 12/21/2010 02:51 PM, Matthias Bolte wrote:
All other drivers are explicitly linked to gnulib. The VMware
driver lacked this, resulting in mdir_name being an undefine
symbol.
That's the minimum impact on glibc. The impact on other systems like
By default dnsmasq is spawned with option --conf-file= which disables
reading of global configuration file -- this is fine for most situations.
This patch adds possibility to run customized DNS/DHCP environment, by
spawning dnsmasq with alternative configuration file if such file exists.
This
Run VIR_FREE only for non-NULL pointers.
---
src/network/bridge_driver.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index b0834ae..f2857b4 100644
--- a/src/network/bridge_driver.c
+++
On 12/21/2010 04:52 PM, Laine Stump wrote:
On 12/20/2010 06:52 PM, Eric Blake wrote:
On 12/20/2010 01:03 AM, Laine Stump wrote:
Later patches will add the possibility to define a network's netmask
as a prefix (0-32, or 0-128 in the case of IPv6). To make it easier to
deal with definition of
2010/12/21 Paweł Krześniak pawel.krzesn...@gmail.com:
Run VIR_FREE only for non-NULL pointers.
---
src/network/bridge_driver.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index
On Tue, Dec 21, 2010 at 08:50:04PM +0100, Matthias Bolte wrote:
2010/12/21 Eric Blake ebl...@redhat.com:
On 12/21/2010 11:34 AM, Chris Lalancette wrote:
All,
I'll preface this by saying that I'm not 100% sure I'm correct. But I
still think there may be an API break that was
This fixes the build from a tarball and makes autobuild.sh
work again.
This should actually have been part of this earlier commit:
esx: Move VMX handling code out of the driver directory
42b2f35d36a9e33f03e973130267c19cff910f2e
Reported by Eric Blake.
---
I pushed this under the
On 12/20/2010 06:57 PM, Eric Blake wrote:
On 12/20/2010 01:03 AM, Laine Stump wrote:
The functions in iptables.c all return -1 on failure, but all their
callers (which all happen to be in bridge_driver.c) assume that they
are returning an errno, and the logging is done accordingly. This
patch
On 12/21/2010 04:52 PM, Eric Blake wrote:
On 12/21/2010 01:45 PM, Laine Stump wrote:
This patch fixes https://bugzilla.redhat.com/show_bug.cgi?id=664406
If qemu is run as a different uid, it has been unable to access mode
0660 files that are owned by a different user, but with a group that
the
于 2010年12月21日 22:40, Eric Blake 写道:
On 12/20/2010 11:47 PM, Osier Yang wrote:
a more efficient solution would be to check if errno
is ELOOP or ENOENT (the only possibilities for a dangling symlink; any
other error should return -1), and in those two cases a successful
lstat() is sufficient to
On 12/21/2010 03:40 PM, Paweł Krześniak wrote:
By default dnsmasq is spawned with option --conf-file= which disables
reading of global configuration file -- this is fine for most situations.
In fact, the libvirt policy is that it is essential to NOT allow the use
of global configuration files -
---
tools/virsh.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 4e37f2d..8c123bb 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -10935,8 +10935,10 @@ vshCommandParse(vshControl *ctl, vshCommandParser
*parser)
if
On 12/21/2010 05:50 PM, Justin Clift wrote:
On 21/12/2010, at 10:32 PM, Zdenek Styblik wrote:
Hello Justin,
could you be more specific, please? How to put it. Your e-mail is too
ambiguous for me :)
Heh, no worries. I often talk in general terms first. :)
The email response to Anthony,
50 matches
Mail list logo
