Re: [libvirt] [PATCH 10/15] Convert the remote driver to new RPC client APIs

2010-12-22 Thread Wen Congyang
At 12/16/2010 07:22 PM, Daniel P. Berrange Write: > This guts the current remote driver, removing all its networking > handling code. Instead it calls out to the new virClientPtr and > virClientProgramPtr APIs for all RPC & networking work. > --- > src/Makefile.am|4 +- > src/remot

Re: [libvirt] [PATCH 03/15] Introduce a generic object for using network sockets

2010-12-22 Thread Wen Congyang
At 12/16/2010 07:21 PM, Daniel P. Berrange Write: > Introduces a simple wrapper around the raw POSIX sockets APIs > and name resolution APIs. Allows for easy creation of client > and server sockets with correct usage of name resolution APIs > for protocol agnostic socket setup. > > It can listen f

Re: [libvirt] [PATCH] fix virsh coredumps when using ext transport

2010-12-22 Thread Wen Congyang
At 12/22/2010 11:55 PM, Eric Blake Write: > On 12/22/2010 08:51 AM, Eric Blake wrote: >> On 12/22/2010 02:25 AM, Wen Congyang wrote: >>> when we use an external process to connect remote libvirtd, >>> virsh will coredump: >>> >>> # virsh -c qemu+ext:///system?command=cmd >>> Segmentation fault (cor

Re: [libvirt] [PATCHv2 09/13] Change virtual network XML parsing/formatting to support IPv6

2010-12-22 Thread Eric Blake
On 12/22/2010 11:58 AM, Laine Stump wrote: > This commit adds support for IPv6 parsing and formatting to the > virtual network XML parser, including moving around data definitions > to allow for multiple elements on a single network, but only > changes the consumers of this API to accomodate for t

Re: [libvirt] [PATCH] Fix memory leak in virsh

2010-12-22 Thread Hu Tao
On Wed, Dec 22, 2010 at 08:48:37AM -0700, Eric Blake wrote: > On 12/22/2010 12:12 AM, Hu Tao wrote: > > --- > > tools/virsh.c |4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/tools/virsh.c b/tools/virsh.c > > index 4e37f2d..8c123bb 100644 > > --- a/tools/virs

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Daniel Veillard
On Thu, Dec 23, 2010 at 12:21:31AM +1100, Justin Clift wrote: > On 23/12/2010, at 12:12 AM, Daniel Veillard wrote: > > But I don't see what a release candidate brings that is not available > > from ftp://libvirt.org/libvirt/libvirt-git-snapshot.tar.gz > > Yeah, I can definitely see your point with

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Daniel Veillard
On Thu, Dec 23, 2010 at 05:07:15AM +1100, Justin Clift wrote: > On 23/12/2010, at 12:25 AM, Diego Elio Pettenò wrote: > > Il giorno mer, 22/12/2010 alle 21.12 +0800, Daniel Veillard ha scritto: > >> But I don't see what a release candidate brings that is not available > >> from ftp://libvirt.org/li

Re: [libvirt] [PATCHv2 08/13] make the element optional in network.rng

2010-12-22 Thread Eric Blake
On 12/22/2010 11:58 AM, Laine Stump wrote: > In practice this has always been optional, but the RNG has shown it as > mandatory, and since all the examples for make check had it, it was > never noticed. One of the existing test cases has been changed to > check for this. > > I also noticed that th

Re: [libvirt] [PATCHv2 07/13] Replace brSetInetAddress/brSetInetNetmask with brAddInetAddress

2010-12-22 Thread Eric Blake
On 12/22/2010 11:58 AM, Laine Stump wrote: > brSetInetAddress can only set a single IP address on the bridge, and > uses a method (ioctl(SIOCSETIFADDR)) that only works for IPv4. Replace > it and brSetInetNetmask with a single function that uses the external > "ip addr add" command to add an addres

Re: [libvirt] [PATCHv2 06/13] Make virtual network netmasks optional

2010-12-22 Thread Eric Blake
On 12/22/2010 11:58 AM, Laine Stump wrote: > When a netmask isn't specified for an IPv4 address, one can be implied > based on what network class range the address is in. The > virNetworkDefPrefix function does this for us, so netmask isn't > required. ACK. -- Eric Blake ebl...@redhat.com+

Re: [libvirt] [PATCHv2 05/13] Pass prefix rather than netmask into iptables functions

2010-12-22 Thread Eric Blake
On 12/22/2010 11:58 AM, Laine Stump wrote: > IPv6 will use prefix exclusively, and IPv4 will also optionally be > able to use it, and the iptables functions really need a prefix > anyway, so use the new virNetworkDefPrefix() function to send prefixes > into iptables functions instead of netmasks. >

Re: [libvirt] [PATCHv2 04/13] Consistently return 0 on success, -1 on failure in bridge_driver.c

2010-12-22 Thread Eric Blake
On 12/22/2010 11:58 AM, Laine Stump wrote: > Some functions in this file were returning 1 on success and 0 on > failure, and others were returning 0 on success and -1 on > failure. Switch them all to return the libvirt-preferred 0/-1. ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Lib

Re: [libvirt] [PATCHv2 03/13] Fix logging of failed iptables commands

2010-12-22 Thread Eric Blake
On 12/22/2010 11:58 AM, Laine Stump wrote: > The functions in iptables.c all return -1 on failure, but all their > callers (which all happen to be in bridge_driver.c) assume that they > are returning an errno, and the logging is done accordingly. This > patch fixes all the error checking and loggin

Re: [libvirt] [PATCHv2 02/13] New virNetworkDef utility functions

2010-12-22 Thread Eric Blake
On 12/22/2010 11:58 AM, Laine Stump wrote: > Later patches will add the possibility to define a network's netmask > as a prefix (0-32, or 0-128 in the case of IPv6). To make it easier to > deal with definition of both kinds (prefix or netmask), add two new > functions: > > virNetworkDefNetmask: re

Re: [libvirt] [PATCHv2 01/13] New virSocketAddr utility functions

2010-12-22 Thread Eric Blake
On 12/22/2010 11:58 AM, Laine Stump wrote: > virSocketPrefixToNetmask: Given a 'prefix', which is the number of 1 > bits in a netmask, fill in a virSocketAddr object with a netmask as an > IP address (IPv6 or IPv4). > > virSocketAddrMask: Mask off the host bits in one virSocketAddr > according to

Re: [libvirt] [PATCH 2/2] qemu: use -incoming fd:n to avoid qemu holding fd indefinitely

2010-12-22 Thread Eric Blake
On 12/22/2010 03:27 PM, Eric Blake wrote: > +} else if (STREQ(migrateFrom, "stdio")) { > +if (qemuCmdFlags & QEMUD_CMD_FLAG_MIGRATE_QEMU_FD) { > +virCommandAddArgFormat(cmd, "fd:%d", migrateFd); > +virCommandTransferFD(cmd, migrateFd); This needs

[libvirt] [PATCH 2/2] qemu: use -incoming fd:n to avoid qemu holding fd indefinitely

2010-12-22 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=620363 When using -incoming stdio or -incoming exec:cat, qemu keeps the stdin fd open long after the migration is complete. Not to mention that exec:cat is horribly inefficient, by doubling the I/O and going through a popen interface in qemu. The new -

[libvirt] [PATCH 1/2] qemu: add -incoming fd:n capability checking

2010-12-22 Thread Eric Blake
* src/qemu/qemu_capabilities.h (QEMUD_CMD_FLAG_MIGRATE_QEMU_FD): New enum value. * src/qemu/qemu_capabilities.c (qemuCapsComputeCmdFlags): Populate flags according to qemu version. * tests/qemuhelptest.c (mymain): Adjust test. --- I feel a bit dirty relying on just a version test for whether -inco

Re: [libvirt] [PATCH] qemu: Reparent children when deleting a snapshot

2010-12-22 Thread Justin Clift
On 23/12/2010, at 8:13 AM, Eric Blake wrote: > On 12/22/2010 01:56 PM, Matthias Bolte wrote: >> Shorten qemuDomainSnapshotWriteSnapshotMetadata function name >> and make it take a snapshot pointer instead of dealing with >> the current snapshot. Update other functions accordingly. >> >> Add a qemu

Re: [libvirt] [PATCH] qemu: Reparent children when deleting a snapshot

2010-12-22 Thread Eric Blake
On 12/22/2010 01:56 PM, Matthias Bolte wrote: > Shorten qemuDomainSnapshotWriteSnapshotMetadata function name > and make it take a snapshot pointer instead of dealing with > the current snapshot. Update other functions accordingly. > > Add a qemuDomainSnapshotReparentChildren hash iterator to > re

[libvirt] [PATCH] qemu: improve efficiency of dd during snapshots

2010-12-22 Thread Eric Blake
POSIX states about dd: If the bs=expr operand is specified and no conversions other than sync, noerror, or notrunc are requested, the data returned from each input block shall be written as a separate output block; if the read returns less than a full block and the sync conversion is not specified

Re: [libvirt] potential bug in qemu snapshots

2010-12-22 Thread Eric Blake
On 12/22/2010 11:35 AM, Eric Blake wrote: > Right now, we create qemu snapshots to a file by using an exec: monitor > command that passes 'compressor | { dd && dd; }' with stdout connected > to the target file. However, since dd is using a larger bs= than > PIPE_MAX, it is conceivable that under h

Re: [libvirt] [BUG] intermediate snapshot deleted

2010-12-22 Thread Matthias Bolte
2010/12/8 Philipp Hahn : > Hello, > > I encountered another problem: snapshots are linked to there parent snapshot. > If the parent snapshot is deleted, the chain gets broken and deleting the > child snapshot terminates with an error message: >> error: Domain snapshot not found: no domain snapshot

[libvirt] [PATCH] qemu: Reparent children when deleting a snapshot

2010-12-22 Thread Matthias Bolte
Shorten qemuDomainSnapshotWriteSnapshotMetadata function name and make it take a snapshot pointer instead of dealing with the current snapshot. Update other functions accordingly. Add a qemuDomainSnapshotReparentChildren hash iterator to reparent the children of a snapshot that is being deleted. U

Re: [libvirt] [PATCH] Set bitmap size when allocating a bitmap

2010-12-22 Thread Jim Fehlig
Eric Blake wrote: > On 12/22/2010 01:02 PM, Jim Fehlig wrote: > >> I began noticing a race when reserving VNC ports as described here >> >> https://www.redhat.com/archives/libvir-list/2010-November/msg00379.html >> >> Turns out that we were not initializing the size field of bitmap >> struct whe

Re: [libvirt] [PATCH] Set bitmap size when allocating a bitmap

2010-12-22 Thread Eric Blake
On 12/22/2010 01:02 PM, Jim Fehlig wrote: > I began noticing a race when reserving VNC ports as described here > > https://www.redhat.com/archives/libvir-list/2010-November/msg00379.html > > Turns out that we were not initializing the size field of bitmap > struct when allocating the bitmap. Thi

[libvirt] [PATCH] Set bitmap size when allocating a bitmap

2010-12-22 Thread Jim Fehlig
I began noticing a race when reserving VNC ports as described here https://www.redhat.com/archives/libvir-list/2010-November/msg00379.html Turns out that we were not initializing the size field of bitmap struct when allocating the bitmap. This subsequently caused virBitmapSetBit() to fail since

Re: [libvirt] [PATCH] esx: Add support for storage volume deletion

2010-12-22 Thread Matthias Bolte
2010/12/22 Eric Blake : > On 12/22/2010 10:05 AM, Matthias Bolte wrote: >> --- >>  src/esx/esx_storage_driver.c   |   50 >> +++- >>  src/esx/esx_vi_generator.input |    7 + >>  2 files changed, 56 insertions(+), 1 deletions(-) >> >> diff --git a/src/esx/esx_

Re: [libvirt] [PATCH] esx: Add support for storage volume wiping

2010-12-22 Thread Matthias Bolte
2010/12/22 Eric Blake : > On 12/22/2010 10:05 AM, Matthias Bolte wrote: >> --- >>  src/esx/esx_storage_driver.c   |   50 >> +++- >>  src/esx/esx_vi_generator.input |    7 + >>  2 files changed, 56 insertions(+), 1 deletions(-) >> >> diff --git a/src/esx/esx_

Re: [libvirt] potential bug in qemu snapshots

2010-12-22 Thread Justin Clift
On 23/12/2010, at 5:35 AM, Eric Blake wrote: > Should we refuse to make snapshots if we don't detect the GNU extension > of 'dd iflag=fullblock'? Probably safe to do on GNU/Linux machines, but > I'm wondering if it will have negative effects on BSD machines where GNU > coreutils is not installed.

[libvirt] [PATCHv2 07/13] Replace brSetInetAddress/brSetInetNetmask with brAddInetAddress

2010-12-22 Thread Laine Stump
brSetInetAddress can only set a single IP address on the bridge, and uses a method (ioctl(SIOCSETIFADDR)) that only works for IPv4. Replace it and brSetInetNetmask with a single function that uses the external "ip addr add" command to add an address/prefix to the interface - this supports IPv6, and

[libvirt] [PATCHv2 13/13] Run radvd for virtual networks with IPv6 addresses

2010-12-22 Thread Laine Stump
Running an instance of the router advertisement daemon (radvd) allows guests using the virtual network to automatically acquire an IPv6 address and default route. Note that acquiring an address only works for networks with a prefix length of exactly 64 - radvd is still run in other circumstances, a

[libvirt] [PATCHv2 06/13] Make virtual network netmasks optional

2010-12-22 Thread Laine Stump
When a netmask isn't specified for an IPv4 address, one can be implied based on what network class range the address is in. The virNetworkDefPrefix function does this for us, so netmask isn't required. --- V2 Changes: * Any prefix arg is now unsigned int rather than int. src/conf/network_conf.c

[libvirt] [PATCHv2 12/13] Turn on IPv6 support in the bridge_driver.c virtual network driver

2010-12-22 Thread Laine Stump
At this point everything is already in place to make IPv6 happen, we just need to add a few rules, remove some checks for IPv4-only, and document the changes to the XML on the website. --- No changes from V1. docs/formatnetwork.html.in | 35 +++-- src/network/bridge_driver.c | 186 +++

[libvirt] [PATCHv2 05/13] Pass prefix rather than netmask into iptables functions

2010-12-22 Thread Laine Stump
IPv6 will use prefix exclusively, and IPv4 will also optionally be able to use it, and the iptables functions really need a prefix anyway, so use the new virNetworkDefPrefix() function to send prefixes into iptables functions instead of netmasks. Also, in a couple places where a netmask is actuall

[libvirt] [PATCHv2 03/13] Fix logging of failed iptables commands

2010-12-22 Thread Laine Stump
The functions in iptables.c all return -1 on failure, but all their callers (which all happen to be in bridge_driver.c) assume that they are returning an errno, and the logging is done accordingly. This patch fixes all the error checking and logging to assume < 0 is an error, and nothing else. ---

[libvirt] [PATCHv2 11/13] Update iptables.c to also support ip6tables.

2010-12-22 Thread Laine Stump
All of the iptables functions eventually call down to a single bottom-level function, and fortunately, ip6tables syntax (for all the args that we use) is identical to iptables format (except the addresses), so all we need to do is: 1) Get an address family down to the lowest level function in each

[libvirt] [PATCHv2 02/13] New virNetworkDef utility functions

2010-12-22 Thread Laine Stump
Later patches will add the possibility to define a network's netmask as a prefix (0-32, or 0-128 in the case of IPv6). To make it easier to deal with definition of both kinds (prefix or netmask), add two new functions: virNetworkDefNetmask: return a copy of the netmask into a virSocketAddr. If no

[libvirt] [PATCHv2 10/13] Support multiple IP addresses on one network in bridge_driver.c

2010-12-22 Thread Laine Stump
This patch reorganizes the code in bridge_driver.c to account for the concept of a single network with multiple IP addresses, without adding in the extra variable of IPv6. A small bit of code has been temporarily added that checks all given addresses to verify they are IPv4 - this will be removed w

[libvirt] [PATCHv2 08/13] make the element optional in network.rng

2010-12-22 Thread Laine Stump
In practice this has always been optional, but the RNG has shown it as mandatory, and since all the examples for make check had it, it was never noticed. One of the existing test cases has been changed to check for this. I also noticed that the dhcp/host/ip was still defined as , but should really

[libvirt] [PATCHv2 00/13] IPv6 support for virtual networks using bridge driver

2010-12-22 Thread Laine Stump
This is a resend of https://www.redhat.com/archives/libvir-list/2010-December/msg00765.html incorporating changes due to comments from Eric Blake and Paweł Krześniak. changes from v1 to v2 are noted in each individual mail - Most of this patchset is setup for patch 09/13, which updates t

[libvirt] [PATCHv2 04/13] Consistently return 0 on success, -1 on failure in bridge_driver.c

2010-12-22 Thread Laine Stump
Some functions in this file were returning 1 on success and 0 on failure, and others were returning 0 on success and -1 on failure. Switch them all to return the libvirt-preferred 0/-1. --- No changes from V1. src/network/bridge_driver.c | 28 ++-- 1 files changed, 14 in

[libvirt] [PATCHv2 01/13] New virSocketAddr utility functions

2010-12-22 Thread Laine Stump
virSocketPrefixToNetmask: Given a 'prefix', which is the number of 1 bits in a netmask, fill in a virSocketAddr object with a netmask as an IP address (IPv6 or IPv4). virSocketAddrMask: Mask off the host bits in one virSocketAddr according to the netmask in another virSocketAddr. virSocketAddrMas

[libvirt] potential bug in qemu snapshots

2010-12-22 Thread Eric Blake
Right now, we create qemu snapshots to a file by using an exec: monitor command that passes 'compressor | { dd && dd; }' with stdout connected to the target file. However, since dd is using a larger bs= than PIPE_MAX, it is conceivable that under heavy machine load, that dd will get a short read f

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Justin Clift
On 23/12/2010, at 12:25 AM, Diego Elio Pettenò wrote: > Il giorno mer, 22/12/2010 alle 21.12 +0800, Daniel Veillard ha scritto: >> But I don't see what a release candidate brings that is not available >> from ftp://libvirt.org/libvirt/libvirt-git-snapshot.tar.gz > > A stable checksum, to begin wit

Re: [libvirt] [PATCH 13/13] Run radvd for virtual networks with IPv6 addresses

2010-12-22 Thread Laine Stump
On 12/20/2010 05:46 PM, Paweł Krześniak wrote: On Mon, Dec 20, 2010 at 09:03, Laine Stump wrote: There are two possible solutions for this: 1) Don't attempt to immediately read the pidfile and store the pid in memory. Instead, just read the pidfile later when we want to kill radvd. (This

Re: [libvirt] [PATCH 13/13] Run radvd for virtual networks with IPv6 addresses

2010-12-22 Thread Laine Stump
On 12/20/2010 06:22 PM, Eric Blake wrote: On 12/20/2010 01:03 AM, Laine Stump wrote: 1) Don't attempt to immediately read the pidfile and store the pid in memory. Instead, just read the pidfile later when we want to kill radvd. (This could still lead to a race if networkStart and net

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Dave Allan
On Wed, Dec 22, 2010 at 09:12:30PM +0800, Daniel Veillard wrote: > On Wed, Dec 22, 2010 at 01:32:55PM +0100, Diego Elio Pettenò wrote: > > Il giorno mer, 22/12/2010 alle 19.30 +0800, Daniel Veillard ha scritto: > > > maybe we ought > > > to make a new release at the end of the month to try to catch

Re: [libvirt] [PATCH 07/13] Replace brSetInetAddress/brSetInetNetmask with brAddInetAddress

2010-12-22 Thread Laine Stump
On 12/20/2010 05:46 PM, Paweł Krześniak wrote: On Mon, Dec 20, 2010 at 09:03, Laine Stump wrote: brSetInetAddress can only set a single IP address on the bridge, and uses a method (ioctl(SIOCSETIFADDR)) that only works for IPv4. Replace it and brSetInetNetmask with a single function that uses t

Re: [libvirt] [PATCH] esx: Add support for storage volume wiping

2010-12-22 Thread Eric Blake
On 12/22/2010 10:05 AM, Matthias Bolte wrote: > --- > src/esx/esx_storage_driver.c | 50 > +++- > src/esx/esx_vi_generator.input |7 + > 2 files changed, 56 insertions(+), 1 deletions(-) > > diff --git a/src/esx/esx_storage_driver.c b/src/esx/esx_s

Re: [libvirt] [PATCH] esx: Add support for storage volume deletion

2010-12-22 Thread Eric Blake
On 12/22/2010 10:05 AM, Matthias Bolte wrote: > --- > src/esx/esx_storage_driver.c | 50 > +++- > src/esx/esx_vi_generator.input |7 + > 2 files changed, 56 insertions(+), 1 deletions(-) > > diff --git a/src/esx/esx_storage_driver.c b/src/esx/esx_s

[libvirt] [PATCH] esx: Add support for storage volume wiping

2010-12-22 Thread Matthias Bolte
--- src/esx/esx_storage_driver.c | 50 +++- src/esx/esx_vi_generator.input |7 + 2 files changed, 56 insertions(+), 1 deletions(-) diff --git a/src/esx/esx_storage_driver.c b/src/esx/esx_storage_driver.c index 544551c..12c8f5e 100644 --- a/src/esx/e

[libvirt] [PATCH] esx: Add support for storage volume deletion

2010-12-22 Thread Matthias Bolte
--- src/esx/esx_storage_driver.c | 50 +++- src/esx/esx_vi_generator.input |7 + 2 files changed, 56 insertions(+), 1 deletions(-) diff --git a/src/esx/esx_storage_driver.c b/src/esx/esx_storage_driver.c index e6803c2..544551c 100644 --- a/src/esx/e

Re: [libvirt] [PATCH 06/13] Make virtual network netmasks optional

2010-12-22 Thread Laine Stump
On 12/22/2010 11:34 AM, Laine Stump wrote: On 12/20/2010 07:13 PM, Eric Blake wrote: On 12/20/2010 01:03 AM, Laine Stump wrote: When a netmask isn't specified for an IPv4 address, one can be implied based on what network class range the address is in. The virNetworkDefPrefix function does this

Re: [libvirt] [PATCH 06/13] Make virtual network netmasks optional

2010-12-22 Thread Laine Stump
On 12/20/2010 07:13 PM, Eric Blake wrote: On 12/20/2010 01:03 AM, Laine Stump wrote: When a netmask isn't specified for an IPv4 address, one can be implied based on what network class range the address is in. The virNetworkDefPrefix function does this for us, so netmask isn't required. --- src

Re: [libvirt] [PATCH] qemu: Return SPICE ports on domain shutdown

2010-12-22 Thread Jiri Denemark
> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > > index 1a26a50..1de6f4a 100644 > > --- a/src/qemu/qemu_driver.c > > +++ b/src/qemu/qemu_driver.c > > @@ -2491,6 +2491,19 @@ static int qemudNextFreePort(struct qemud_driver > > *driver, > > } > > > > > > +static void > > +qem

Re: [libvirt] [PATCH] error: avoid API breakage with vmware

2010-12-22 Thread Eric Blake
On 12/22/2010 07:01 AM, Chris Lalancette wrote: > On 12/21/10 - 03:12:43PM, Eric Blake wrote: >> Fix glitch in commit cddd2a06 (thankfully post-0.8.6, so no >> released version has the glitch). >> >> Document and try to workaround glitch in commit 46e9b0f (in 0.8.0, >> which invalidated 6 virErrorN

Re: [libvirt] [PATCH] virsh: Add --force option to update-device

2010-12-22 Thread Eric Blake
On 12/22/2010 09:05 AM, Jiri Denemark wrote: > --- > tools/virsh.c |5 + > tools/virsh.pod | 14 -- > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index 4e37f2d..774d937 100644 > --- a/tools/virsh.c > +++ b/tools/virsh.

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2010-12-22 Thread Laine Stump
On 12/22/2010 04:09 AM, Paweł Krześniak wrote: 2010/12/22 Eric Blake: On 12/21/2010 03:40 PM, Paweł Krześniak wrote: This patch adds possibility to run customized DNS/DHCP environment, by spawning dnsmasq with alternative configuration file if such file exists. This allows you to set any parame

[libvirt] [PATCH] virsh: Add --force option to update-device

2010-12-22 Thread Jiri Denemark
--- tools/virsh.c |5 + tools/virsh.pod | 14 -- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 4e37f2d..774d937 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -8293,6 +8293,7 @@ static const vshCmdOptDef opts_update_d

Re: [libvirt] [PATCH] fix virsh coredumps when using ext transport

2010-12-22 Thread Eric Blake
On 12/22/2010 08:51 AM, Eric Blake wrote: > On 12/22/2010 02:25 AM, Wen Congyang wrote: >> when we use an external process to connect remote libvirtd, >> virsh will coredump: >> >> # virsh -c qemu+ext:///system?command=cmd >> Segmentation fault (core dumped) >> >> This bug was caused by 3348a97b. >

Re: [libvirt] [PATCH] fix virsh coredumps when using ext transport

2010-12-22 Thread Eric Blake
On 12/22/2010 02:25 AM, Wen Congyang wrote: > when we use an external process to connect remote libvirtd, > virsh will coredump: > > # virsh -c qemu+ext:///system?command=cmd > Segmentation fault (core dumped) > > This bug was caused by 3348a97b. Would it be easier instead to switch virsh over t

Re: [libvirt] boot time delay for domains?

2010-12-22 Thread Igor Serebryany
On Wed, Dec 22, 2010 at 04:23:54PM +0100, Paweł Krześniak wrote: > If you'll have some solution share with us, please. my solution was to make all my domains non-persistent. my application monitors the status of the domains and re-creates them if they disappear. this has some major advantages: 1)

Re: [libvirt] [PATCH] Fix memory leak in virsh

2010-12-22 Thread Eric Blake
On 12/22/2010 12:12 AM, Hu Tao wrote: > --- > tools/virsh.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index 4e37f2d..8c123bb 100644 > --- a/tools/virsh.c > +++ b/tools/virsh.c > @@ -10935,8 +10935,10 @@ vshCommandParse(vshCont

Re: [libvirt] [PATCH] qemu: Return SPICE ports on domain shutdown

2010-12-22 Thread Eric Blake
On 12/22/2010 06:42 AM, Jiri Denemark wrote: > Commit ed0d9f6c0cdd56f38ce31b8d9b5293162addaa23 added support for > automatic port allocation for SPICE but forgot to mark such ports as > unused when they are not used anymore. > --- > src/qemu/qemu_driver.c | 30 ++ > 1

Re: [libvirt] boot time delay for domains?

2010-12-22 Thread Maximilian Wilhelm
Anno domini 2010 Paweł Krześniak scripsit: > # cat > /usr/bin/local/qemu-kvm-with-random-delay > #!/bin/bash > # delay running of virtual machine by 0-9 seconds > sleep $(( $RANDOM % 10 )) > exec /usr/bin/qemu-kvm $* > ^D When using $* you might lose quoting of parameters. exec /usr/bin/qemu-kv

Re: [libvirt] boot time delay for domains?

2010-12-22 Thread Paweł Krześniak
On Wed, Dec 22, 2010 at 13:32, Harald Dunkel wrote: > Is there a global "boot time delay" configuration parameter > to make sure that the autostart domains are not started all > in parallel at boot time? AFAIK there is no such option. > Any helpful comment would be highly appreciated. in domain

Re: [libvirt] Test failures building libvirt 0.8.5 rpm on EL5

2010-12-22 Thread Eric Blake
On 12/22/2010 06:48 AM, Daniel Veillard wrote: > On Tue, Dec 21, 2010 at 01:43:52PM -0700, Orion Poplawski wrote: >> I thought I'd take a look at updating my libvirt stack on EL5.5. >> Building the Fedora Rawhide 0.8.5 rpm in mock yields: > [...] >> TEST: interfaceschematest >> !!..!.!.!.

Re: [libvirt] [PATCH] qemu: Return SPICE ports on domain shutdown

2010-12-22 Thread Jiri Denemark
> > Commit ed0d9f6c0cdd56f38ce31b8d9b5293162addaa23 added support for > > automatic port allocation for SPICE but forgot to mark such ports as > > unused when they are not used anymore. > > Out of curiosity, any idea if the Red Hat "system-config-firewall" or > "system-config-firewall-tui" > util

Re: [libvirt] [PATCH] error: avoid API breakage with vmware

2010-12-22 Thread Chris Lalancette
On 12/21/10 - 03:12:43PM, Eric Blake wrote: > Fix glitch in commit cddd2a06 (thankfully post-0.8.6, so no > released version has the glitch). > > Document and try to workaround glitch in commit 46e9b0f (in 0.8.0, > which invalidated 6 virErrorNumber dating back to 0.7.1). > > Thankfully, my audit

Re: [libvirt] [PATCH] qemu: Return SPICE ports on domain shutdown

2010-12-22 Thread Justin Clift
On 23/12/2010, at 12:42 AM, Jiri Denemark wrote: > Commit ed0d9f6c0cdd56f38ce31b8d9b5293162addaa23 added support for > automatic port allocation for SPICE but forgot to mark such ports as > unused when they are not used anymore. Out of curiosity, any idea if the Red Hat "system-config-firewall" or

Re: [libvirt] Test failures building libvirt 0.8.5 rpm on EL5

2010-12-22 Thread Daniel Veillard
On Tue, Dec 21, 2010 at 01:43:52PM -0700, Orion Poplawski wrote: > I thought I'd take a look at updating my libvirt stack on EL5.5. > Building the Fedora Rawhide 0.8.5 rpm in mock yields: [...] > TEST: interfaceschematest > !!..!.!.!. 18 FAILED > FAIL: interface

[libvirt] [PATCH] qemu: Return SPICE ports on domain shutdown

2010-12-22 Thread Jiri Denemark
Commit ed0d9f6c0cdd56f38ce31b8d9b5293162addaa23 added support for automatic port allocation for SPICE but forgot to mark such ports as unused when they are not used anymore. --- src/qemu/qemu_driver.c | 30 ++ 1 files changed, 22 insertions(+), 8 deletions(-) diff --

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Diego Elio Pettenò
Il giorno mer, 22/12/2010 alle 21.12 +0800, Daniel Veillard ha scritto: > But I don't see what a release candidate brings that is not available > from ftp://libvirt.org/libvirt/libvirt-git-snapshot.tar.gz A stable checksum, to begin with, and a make dist-created package. Missing files for instance

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Justin Clift
On 23/12/2010, at 12:12 AM, Daniel Veillard wrote: > On Wed, Dec 22, 2010 at 01:32:55PM +0100, Diego Elio Pettenò wrote: >> Il giorno mer, 22/12/2010 alle 19.30 +0800, Daniel Veillard ha scritto: >>> maybe we ought >>> to make a new release at the end of the month to try to catch possible >>> regre

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Justin Clift
On 23/12/2010, at 12:11 AM, Daniel Veillard wrote: > On Wed, Dec 22, 2010 at 11:31:14PM +1100, Justin Clift wrote: >> On 22/12/2010, at 10:30 PM, Daniel Veillard wrote: >>> Also on the release name, should we go 0.9.0 considering the refactorings >>> (i.e. indicating future patches will be harder t

[libvirt] Test failures building libvirt 0.8.5 rpm on EL5

2010-12-22 Thread Orion Poplawski
I thought I'd take a look at updating my libvirt stack on EL5.5. Building the Fedora Rawhide 0.8.5 rpm in mock yields: make check-TESTS make[2]: Entering directory `/builddir/build/BUILD/libvirt-0.8.5/tests' TEST: virshtest 40 !!!

Re: [libvirt] [libvirt-users] Anyone interested in forming a libvirt "docs" team?

2010-12-22 Thread Scott Baker
On 12/21/2010 03:15 AM, Anthony Davis wrote: Hi Justin, I can offer some free time:) I'd be willing to contribute to a wiki if we had the docs in a wiki. -- Scott Baker - Canby Telcom System Administrator - RHCE - 503.266.8253 -- libvir-list mailing list libvir-list@redhat.com https://www.re

Re: [libvirt] Anyone interested in forming a libvirt "docs" team?

2010-12-22 Thread Justin Clift
On 22/12/2010, at 6:50 PM, Zdenek Styblik wrote: > As for documentation in HTML. How about to write parser which would > download pages from wiki, cut eg. menu, footer => garbage off, and > replace it with whatever you want and like? I have to say I haven't seen > documentation shipped with libvirt

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Daniel Veillard
On Wed, Dec 22, 2010 at 01:32:55PM +0100, Diego Elio Pettenò wrote: > Il giorno mer, 22/12/2010 alle 19.30 +0800, Daniel Veillard ha scritto: > > maybe we ought > > to make a new release at the end of the month to try to catch possible > > regressions introduced as early as possible. > > I'd sugg

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Daniel Veillard
On Wed, Dec 22, 2010 at 11:31:14PM +1100, Justin Clift wrote: > On 22/12/2010, at 10:30 PM, Daniel Veillard wrote: > > Also on the release name, should we go 0.9.0 considering the refactorings > > (i.e. indicating future patches will be harder to apply to earlier branches) > > or stick to 0.8.7 (co

Re: [libvirt] [PATCH] docs: fixed typo, added table of contents

2010-12-22 Thread Justin Clift
On 22/12/2010, at 11:50 PM, Justin Clift wrote: > --- > docs/drvopenvz.html.in | 14 -- > 1 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/docs/drvopenvz.html.in b/docs/drvopenvz.html.in > index e446b1a..485d209 100644 > --- a/docs/drvopenvz.html.in > +++ b/docs/drvop

[libvirt] [PATCH] docs: fixed typo, added table of contents

2010-12-22 Thread Justin Clift
--- docs/drvopenvz.html.in | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/docs/drvopenvz.html.in b/docs/drvopenvz.html.in index e446b1a..485d209 100644 --- a/docs/drvopenvz.html.in +++ b/docs/drvopenvz.html.in @@ -2,6 +2,8 @@ OpenVZ container driver

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Diego Elio Pettenò
Il giorno mer, 22/12/2010 alle 19.30 +0800, Daniel Veillard ha scritto: > maybe we ought > to make a new release at the end of the month to try to catch possible > regressions introduced as early as possible. I'd suggest making a release candidate, rather than a release for now. As per the versio

[libvirt] boot time delay for domains?

2010-12-22 Thread Harald Dunkel
Hi folks, Is there a global "boot time delay" configuration parameter to make sure that the autostart domains are not started all in parallel at boot time? Any helpful comment would be highly appreciated. Harri -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/l

Re: [libvirt] Back and suggested release schedule

2010-12-22 Thread Justin Clift
On 22/12/2010, at 10:30 PM, Daniel Veillard wrote: > Also on the release name, should we go 0.9.0 considering the refactorings > (i.e. indicating future patches will be harder to apply to earlier branches) > or stick to 0.8.7 (considering that there isn't major feature improvement > ... unless I mi

[libvirt] Back and suggested release schedule

2010-12-22 Thread Daniel Veillard
Hello all, as some of you may have noticed, I'm back online, just in a very different timezone now ! I'm still behind on reading the list emails but a lot of the changes in the last month have been refactoring and cleanups, and maybe we ought to make a new release at the end of the month to try

[libvirt] [PATCH] fix virsh coredumps when using ext transport

2010-12-22 Thread Wen Congyang
when we use an external process to connect remote libvirtd, virsh will coredump: # virsh -c qemu+ext:///system?command=cmd Segmentation fault (core dumped) This bug was caused by 3348a97b. Signed-off-by: Wen Congyang --- src/remote/remote_driver.c | 12 1 files changed, 12 inse

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2010-12-22 Thread Paweł Krześniak
2010/12/22 Eric Blake : > On 12/21/2010 03:40 PM, Paweł Krześniak wrote: >> This patch adds possibility to run customized DNS/DHCP environment, by >> spawning dnsmasq with alternative configuration file if such file exists. >> This allows you to set any parameter described in dnsmasq(8). >> Configu