[libvirt] Re: announce mailing list

2011-01-05 Thread Nicolas Sebrecht
The 05/01/11, Justin Clift wrote: Interesting idea. Can see that having the user and developer mailing lists automatically getting the announce list traffic would be useful. Not sure about the developer mailing list getting user traffic. User traffic can led to patches. This is why nested

Re: [libvirt] announce mailing list

2011-01-05 Thread Justin Clift
On 05/01/2011, at 7:56 PM, Nicolas Sebrecht wrote: The 05/01/11, Justin Clift wrote: Interesting idea. Can see that having the user and developer mailing lists automatically getting the announce list traffic would be useful. Not sure about the developer mailing list getting user traffic.

Re: [libvirt] announce mailing list

2011-01-05 Thread Zdenek Styblik
On 01/05/2011 10:03 AM, Justin Clift wrote: On 05/01/2011, at 7:56 PM, Nicolas Sebrecht wrote: The 05/01/11, Justin Clift wrote: Interesting idea. Can see that having the user and developer mailing lists automatically getting the announce list traffic would be useful. Not sure about the

Re: [libvirt] announce mailing list

2011-01-05 Thread Zdenek Styblik
On 01/05/2011 10:08 AM, Zdenek Styblik wrote: On 01/05/2011 10:03 AM, Justin Clift wrote: [...] Wouldn't make more sense simply to sign up for both mailing lists, instead of mirroring them to each other? I fail to see the point of having N mirrored mailing lists then, but just the one. Z.

Re: [libvirt] [PATCHv2] docs: added libvirt-announce to contact page

2011-01-05 Thread Daniel P. Berrange
On Tue, Jan 04, 2011 at 01:00:55PM -0700, Eric Blake wrote: On 01/04/2011 12:24 PM, Justin Clift wrote: Also added explicit links to the subscription and archive pages for the user and developer mailing lists. p - Both mailing lists require that you subscribe before posting

Re: [libvirt] RFC: exposing a config setting to force vhost-net support on/off

2011-01-05 Thread Daniel P. Berrange
On Tue, Jan 04, 2011 at 02:37:15PM -0500, Laine Stump wrote: There's a request to allow libvirt to explicitly turn on/off the new vhost-net feature of virtio network cards. I see a few ways to do it, and am looking for opinions on which is best. (For the uninitiated, vhost-net is a new

Re: [libvirt] Release of libvirt-0.8.7

2011-01-05 Thread Zdenek Styblik
On 01/04/2011 07:37 PM, Justin Clift wrote: [...] 0.8.7 is now available through Homebrew on MacOS X too. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list Should I post link for Slackware package as well? Not like there are any

Re: [libvirt] Release of libvirt-0.8.7

2011-01-05 Thread Justin Clift
On 05/01/2011, at 9:30 PM, Zdenek Styblik wrote: snip https://www.turnovfree.net/pub/linux/slackware/slackware64-13.1/slackware64/ap/qemu-kvm-0.13.0-x86_64-1.txz https://www.turnovfree.net/pub/linux/slackware/slackware64-13.1/slackware64/l/libvirt-0.8.7-x86_64-1.txz But I haven't put them

Re: [libvirt] [PATCH] [v2] API: Improve log for domain related APIs

2011-01-05 Thread Osier Yang
于 2011年01月04日 23:51, Eric Blake 写道: On 01/04/2011 08:30 AM, Daniel P. Berrange wrote: virDomainGetConnect (virDomainPtr dom) { -DEBUG(dom=%p, dom); +const char *name = virDomainGetName(dom); + +DEBUG(dom=%p, (VM: %s), dom, NULLSTR(name)); Calling virDomainGetName() which is

Re: [libvirt] Implementing VNC per VM access control lists

2011-01-05 Thread Neil Wilson
On Tue, 2011-01-04 at 16:22 +, Daniel P. Berrange wrote: Well I'd like us to have fine grained access control across users, objects operations, probably using the role based access control model. Once you have such fine grained access control, then I don't believe you have a clearcut

Re: [libvirt] Release of libvirt-0.8.7

2011-01-05 Thread Zdenek Styblik
On 01/05/2011 11:40 AM, Justin Clift wrote: [...] Cool. I'm thinking we should these to the Downloads page in some way that makes sense. Not sure of the best approach. Will need to think about it (open to suggestions too of course). :) Yes, you can. Although Slackware is a bit

Re: [libvirt] Implementing VNC per VM access control lists

2011-01-05 Thread Daniel P. Berrange
On Wed, Jan 05, 2011 at 11:01:38AM +, Neil Wilson wrote: On Tue, 2011-01-04 at 16:22 +, Daniel P. Berrange wrote: Well I'd like us to have fine grained access control across users, objects operations, probably using the role based access control model. Once you have such fine

Re: [libvirt] Implementing VNC per VM access control lists

2011-01-05 Thread Neil Wilson
On Wed, 2011-01-05 at 11:14 +, Daniel P. Berrange wrote: There's no general library that I'm aware of that'd be suitable. In addition to the general access control solution, we'd like to expand our SELinux support to cover MAC of the entire API (kinda like SEPostgreSQL). That's a very

[libvirt] Re: announce mailing list

2011-01-05 Thread Nicolas Sebrecht
The 05/01/11, Zdenek Styblik wrote: On 01/05/2011 10:08 AM, Zdenek Styblik wrote: On 01/05/2011 10:03 AM, Justin Clift wrote: [...] Wouldn't make more sense simply to sign up for both mailing lists, instead of mirroring them to each other? I fail to see the point of having N mirrored

[libvirt] [PATCH] Device reattach: Check if device is assigned to guest before reattaching

2011-01-05 Thread Yufang Zhang
Reattaching pci device back to host without destroying guest or detaching device from guest would cause host to crash. This patch adds a check before doing device reattach. If the device is being assigned to guest, libvirt refuses to reattach device to host. Note that the patch only works for Xen,

[libvirt] [PATCH] virsh: print error in case of cellno is invalid

2011-01-05 Thread Osier Yang
If invalid cellno is specified, command freecell will still print the amount of available memory of node. As a fix, print error instead. * tools/virsh.c: vshCommandOptInt, return -1 when value for parameter is specified, but invalid, which means strtol was failed, it won't affects other

Re: [libvirt] RFC: exposing a config setting to force vhost-net support on/off

2011-01-05 Thread Laine Stump
On 01/05/2011 05:19 AM, Daniel P. Berrange wrote: We should try to keep terminology matching the diskdriver so I think driver name='qemu|vhost'/ with omission ofdriver resulting in us automatically adding either 'qemu' or 'vhost' to the XML. We don't want to have an explicit 'default'

[libvirt] [PATCH] qemu: Fix bogus warning about uninitialized saveptr

2011-01-05 Thread Jiri Denemark
The warning is bogus since strtok_r doesn't use the value when it's first called and initializes it for the following calls. --- src/qemu/qemu_command.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

Re: [libvirt] Release of libvirt-0.8.7

2011-01-05 Thread Laine Stump
On 01/05/2011 06:12 AM, Zdenek Styblik wrote: What I'm trying to say is I'm not using everything from libvirt, but only what I actually need. Thus eg. iSCSI and NetCF support is disabled atm, although I wanted to look into NetCF. Zdenek - I'd be very happy to have a Slackware port of netcf,

Re: [libvirt] [PATCH] qemu: Fix bogus warning about uninitialized saveptr

2011-01-05 Thread Eric Blake
On 01/05/2011 08:11 AM, Jiri Denemark wrote: The warning is bogus since strtok_r doesn't use the value when it's first called and initializes it for the following calls. --- src/qemu/qemu_command.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] Improve error reporting when parsing dhcp info for virtual networks

2011-01-05 Thread Eric Blake
On 01/04/2011 11:14 PM, Laine Stump wrote: This is partially in response to https://bugzilla.redhat.com/show_bug.cgi?id=653300 The crash in that report was coincidentally fixed when we switched from using inet_pton() to using virSocketParseAddr(), but the absence of an ip address in a

Re: [libvirt] [PATCH] Log an error on attempts to add a NAT rule for non-IPv4 addresses

2011-01-05 Thread Eric Blake
On 01/04/2011 11:14 PM, Laine Stump wrote: Although the upper-layer code protected against it, it was possible to call iptablesForwardMasquerade() with an IPv6 address and have it attempt to add a rule to the MASQUERADE chain of ip6tables (which doesn't exist). This patch changes that

Re: [libvirt] [PATCH] [v2] API: Improve log for domain related APIs

2011-01-05 Thread Eric Blake
On 01/05/2011 03:40 AM, Osier Yang wrote: Then maybe the patch should be altered to output both name and UUID (probably by introducing a helper function, which when given a virDomainPtr outputs all three pieces of debug information rather than the current %p). I like the idea behind the

Re: [libvirt] announce mailing list

2011-01-05 Thread Eric Blake
On 01/05/2011 02:08 AM, Zdenek Styblik wrote: What happens to responses by a developer back to the dev mailing list? How does it get back to the user that asked, and the user mailing list? That's one of the tricks/drawbacks. If

Re: [libvirt] [PATCH] [v2] API: Improve log for domain related APIs

2011-01-05 Thread Daniel P. Berrange
On Wed, Jan 05, 2011 at 09:34:20AM -0700, Eric Blake wrote: On 01/05/2011 03:40 AM, Osier Yang wrote: Then maybe the patch should be altered to output both name and UUID (probably by introducing a helper function, which when given a virDomainPtr outputs all three pieces of debug information

Re: [libvirt] [PATCH] Improve error reporting when parsing dhcp info for virtual networks

2011-01-05 Thread Laine Stump
On 01/05/2011 11:26 AM, Eric Blake wrote: On 01/04/2011 11:14 PM, Laine Stump wrote: This is partially in response to https://bugzilla.redhat.com/show_bug.cgi?id=653300 The crash in that report was coincidentally fixed when we switched from using inet_pton() to using virSocketParseAddr(),

Re: [libvirt] [PATCH] Log an error on attempts to add a NAT rule for non-IPv4 addresses

2011-01-05 Thread Laine Stump
On 01/05/2011 11:28 AM, Eric Blake wrote: On 01/04/2011 11:14 PM, Laine Stump wrote: Although the upper-layer code protected against it, it was possible to call iptablesForwardMasquerade() with an IPv6 address and have it attempt to add a rule to the MASQUERADE chain of ip6tables (which doesn't

Re: [libvirt] [PATCH] virsh: print error in case of cellno is invalid

2011-01-05 Thread Eric Blake
On 01/05/2011 07:03 AM, Osier Yang wrote: If invalid cellno is specified, command freecell will still print the amount of available memory of node. As a fix, print error instead. * tools/virsh.c: vshCommandOptInt, return -1 when value for parameter is specified, but invalid, which means

Re: [libvirt] [PATCH] virsh: print error in case of cellno is invalid

2011-01-05 Thread Daniel P. Berrange
On Wed, Jan 05, 2011 at 10:10:00AM -0700, Eric Blake wrote: Style nit: you used: if (cond) { abc; def; } else xyz; But we prefer either: if (!cond) xyz; else { abc; def; } or: if (cond) { abc; def; } else { xyz; } since HACKING

[libvirt] [PATCH] maint: document dislike of mismatched if/else bracing

2011-01-05 Thread Eric Blake
* docs/hacking.html.in (Curly braces): Tighten recommendations to disallow if (cond) one-line; else { block; }. * HACKING: Regenerate. Suggested by Daniel P. Berrange. --- since HACKING documents that an else clause should only ever omit braces when the if clause also omitted braces, but an

Re: [libvirt] [PATCH] virsh: print error in case of cellno is invalid

2011-01-05 Thread Laine Stump
On 01/05/2011 12:49 PM, Daniel P. Berrange wrote: IMHO the hacking guideline should only allow if (foo) bar; else wizz; Or if (foo) { bar; ... } else { wizz; ... } +1 (just in case we're voting :-) -- libvir-list mailing list

Re: [libvirt] [PATCH] maint: document dislike of mismatched if/else bracing

2011-01-05 Thread Daniel P. Berrange
On Wed, Jan 05, 2011 at 11:07:28AM -0700, Eric Blake wrote: * docs/hacking.html.in (Curly braces): Tighten recommendations to disallow if (cond) one-line; else { block; }. * HACKING: Regenerate. Suggested by Daniel P. Berrange. --- since HACKING documents that an else clause should only

[libvirt] libvirt 0.8.7 msys and xdr weirdness

2011-01-05 Thread Justin Clift
Hi Matthias, Have you tried out libvirt 0.8.7 yet with your msys scripts? Giving it a shot here, but am hitting problems with the --with-remote part. ./configure isn't finding the XDR library. checking for xdrmem_create in -lportablexdr... no checking for library containing

Re: [libvirt] adding smartcard support to libvirt

2011-01-05 Thread Eric Blake
On 01/04/2011 02:17 AM, Alon Levy wrote: [focusing on the spicevmc chardev aspect] domain... devices smartcard mode='passthrough' name='xyz' serial type='spicevmc'/ /smartcard /devices /domain maps to qemu -chardev spicevmc,id=smartcard,name=xyz -usb -device usb-ccid

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2011-01-05 Thread Paweł Krześniak
2011/1/4 Daniel P. Berrange berra...@redhat.com: NB, there was a discussion with the dnsmsaq maintainer a few months back now about changing the dnsmasq architecture such that we only need one dnsmasq process. is this consistent with Laine's arguments about radvd? read last paragraph of this:

Re: [libvirt] [PATCH] bridge_driver: use conffile for dnsmasq if it exists

2011-01-05 Thread Paweł Krześniak
2011/1/4 Daniel P. Berrange berra...@redhat.com: On Wed, Dec 22, 2010 at 10:09:54AM +0100, Paweł Krześniak wrote: I want to create isolated environment for guests - they will be connected to one bridge and will use private DNS data. No single packet from this isolated network can reach

Re: [libvirt] adding smartcard support to libvirt

2011-01-05 Thread Eric Blake
On 01/05/2011 02:09 PM, Alon Levy wrote: So, I'm thinking that this XML representation matches the spicevmc chardev: devices channel type='spicevmc'/ source port='5903' tlsPort='5904' autoport='no' listen='127.0.0.1'/ I got you until now - but what's with the port/tlsPort - all of

[libvirt] [PATCH] Don't chown qemu saved image back to root after save if dynamic_ownership=0

2011-01-05 Thread Laine Stump
When dynamic_ownership=0, saved images must be owned by the same uid as is used to run the qemu process, otherwise restore won't work. To accomplish this, qemuSecurityDACRestoreSavedStateLabel() needs to simply return when it's called. This fix is in response to:

Re: [libvirt] [PATCH] Don't chown qemu saved image back to root after save if dynamic_ownership=0

2011-01-05 Thread Eric Blake
On 01/05/2011 03:03 PM, Laine Stump wrote: When dynamic_ownership=0, saved images must be owned by the same uid as is used to run the qemu process, otherwise restore won't work. To accomplish this, qemuSecurityDACRestoreSavedStateLabel() needs to simply return when it's called. This fix is

[libvirt] [PATCH 2/4] Add support for HAP feature to xen drivers

2011-01-05 Thread Jim Fehlig
xen-unstable c/s 16931 introduced a per-domain setting for hvm guests to enable/disable hardware assisted paging. If disabled, software techniques such as shadow page tables are used. If enabled, and the feature exists in underlying hardware, hardware support for paging is used. This provides

[libvirt] [PATCH 1/4] Add HAP to virDomainFeature enum

2011-01-05 Thread Jim Fehlig
Extend the virDomainFeature enumeration to include HAP (hardware assisted paging) feature. Hardware features such as Extended Page Table and Nested Page Table augment hypervisor software techniques such as shadow page table. Adding HAP to the virDomainFeature enumeration allows users to select

[libvirt] [PATCH 3/4] Add HAP to xen hypervisor capabilities

2011-01-05 Thread Jim Fehlig
xen-unstable c/s 16931 introduced a per-domain setting for hvm guests to enable/disable hardware assisted paging. If disabled, software techniques such as shadow page tables are used. If enabled, and the feature exists in underlying hardware, hardware support for paging is used. Xen does not

Re: [libvirt] adding smartcard support to libvirt

2011-01-05 Thread Eric Blake
On 01/03/2011 11:50 AM, Eric Blake wrote: domain... devices smartcard mode='host-certificates' certificate id='1' path='cert1'/ certificate id='2' path='cert2'/ certificate id='3' path='cert3'/ /smartcard /devices /domain Slight tweak - filenames can be

Re: [libvirt] adding smartcard support to libvirt

2011-01-05 Thread Eric Blake
On 01/05/2011 04:59 PM, Eric Blake wrote: On 01/03/2011 11:50 AM, Eric Blake wrote: domain... devices smartcard mode='host-certificates' certificate id='1' path='cert1'/ certificate id='2' path='cert2'/ certificate id='3' path='cert3'/ /smartcard /devices

[libvirt] [PATCH] schema: tighten serialprotocol type=... relaxNG

2011-01-05 Thread Eric Blake
virDomainChrTcpProtocol only accepts particular protocol type=... values, but we weren't enforcing that in the RelaxNG. The valid types are also already documented in docs/formatdomain.html.in. * docs/schemas/domain.rng (qemucdevSrcDef): Restrict list of supported protocol type= values. ---

Re: [libvirt] [TCK] [PATCH v2] Test cases for network ipv6 support

2011-01-05 Thread Stefan Berger
On 01/05/2011 01:10 AM, Laine Stump wrote: On 01/04/2011 06:44 PM, Stefan Berger wrote: v2: - added test cases using 'ip addr ...' and 'ip route ...' commands This patch adds a couple of test cases for the recently added network ipv6 support. I don't really feel qualified to do a good

[libvirt] [RFC: PATCH 1/n] smartcard: add XML support for smartcard device

2011-01-05 Thread Eric Blake
Assuming a hypervisor that supports multiple smartcard devices in the guest, this would be a valid XML description: devices smartcard mode='host'/ smartcard mode='host-certificates' certificate/path/to/cert1/certificate certificate/path/to/cert2/certificate

Re: [libvirt] [PATCH] [v2] API: Improve log for domain related APIs

2011-01-05 Thread Osier Yang
于 2011年01月06日 00:55, Daniel P. Berrange 写道: On Wed, Jan 05, 2011 at 09:34:20AM -0700, Eric Blake wrote: On 01/05/2011 03:40 AM, Osier Yang wrote: Then maybe the patch should be altered to output both name and UUID (probably by introducing a helper function, which when given a virDomainPtr

Re: [libvirt] [PATCH] virsh: print error in case of cellno is invalid

2011-01-05 Thread Osier Yang
于 2011年01月06日 01:10, Eric Blake 写道: On 01/05/2011 07:03 AM, Osier Yang wrote: If invalid cellno is specified, command freecell will still print the amount of available memory of node. As a fix, print error instead. * tools/virsh.c: vshCommandOptInt, return -1 when value for parameter is

Re: [libvirt] [PATCH] schema: tighten serialprotocol type=... relaxNG

2011-01-05 Thread Daniel Veillard
On Wed, Jan 05, 2011 at 05:15:22PM -0700, Eric Blake wrote: virDomainChrTcpProtocol only accepts particular protocol type=... values, but we weren't enforcing that in the RelaxNG. The valid types are also already documented in docs/formatdomain.html.in. * docs/schemas/domain.rng