Re: [libvirt] [PATCH] qemu: sound: Support intel 'hda' model

2011-01-11 Thread Gerd Hoffmann
On 01/10/11 18:19, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires -device hda-output in order to actually get sound to the host. AIUI this is just HDA configuration and does not require stable addressing, so is not presently represented in the XML. It isn't that

Re: [libvirt] [PATCH] pass correct uri to source host when we do p2p migration

2011-01-11 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 09:37:46AM +0800, Wen Congyang wrote: At 01/10/2011 07:02 PM, Daniel P. Berrange Write: On Mon, Jan 10, 2011 at 11:20:31AM +0800, Wen Congyang wrote: When we migrate a guest from remote host to localhost by p2p, the libvirtd on remote host will be deadlock. This

Re: [libvirt] [PATCH] qemu: sound: Support intel 'hda' model

2011-01-11 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 11:46:14AM +0100, Gerd Hoffmann wrote: On 01/10/11 18:19, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires -device hda-output in order to actually get sound to the host. AIUI this is just HDA configuration and does not require stable

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. * src/qemu/qemu_command.c NACK. Most previous versions of QEMU don't have any explicit -sdl

Re: [libvirt] [PATCH] qemu: sound: Support intel 'hda' model

2011-01-11 Thread Gerd Hoffmann
On 01/11/11 12:10, Daniel P. Berrange wrote: This suggests a setup more like the one we did for virtio-serial where we'd invent a new address type for codecs, and have XML looking something like controller type='hda' model='ich6' address type='pci' domain='0x' bus='0x00'

Re: [libvirt] [RFC] Live disk snapshot API

2011-01-11 Thread Daniel P. Berrange
On Mon, Jan 10, 2011 at 07:34:20PM +, Daniel P. Berrange wrote: On Mon, Jan 10, 2011 at 06:36:57PM +, Daniel P. Berrange wrote: On Thu, Jan 06, 2011 at 02:27:14PM +0100, Jiri Denemark wrote: To create a snapshot of a disk, the following API is introduced: int

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Osier Yang
于 2011年01月11日 19:29, Daniel P. Berrange 写道: On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. * src/qemu/qemu_command.c NACK. Most previous

[libvirt] [PATCH] Watchdog IB700 is not a PCI device (RHBZ#667091).

2011-01-11 Thread Richard W.M. Jones
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/ From c74e8db2ab942e42d8ddff250e867154c211b216

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Richard W.M. Jones
On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal list, as the patch won't conflict with upstream. IMHO it's not reasonable that we have sdl xml in domain config, but

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Justin Clift
On 12/01/2011, at 12:39 AM, Richard W.M. Jones wrote: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal list, as the patch won't conflict with upstream. IMHO it's not

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Osier Yang
于 2011年01月11日 22:01, Justin Clift 写道: On 12/01/2011, at 12:39 AM, Richard W.M. Jones wrote: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal list, as the patch won't

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Osier Yang
于 2011年01月11日 21:39, Richard W.M. Jones 写道: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal list, as the patch won't conflict with upstream. IMHO it's not reasonable

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Daniel P. Berrange
On Wed, Jan 12, 2011 at 01:01:25AM +1100, Justin Clift wrote: On 12/01/2011, at 12:39 AM, Richard W.M. Jones wrote: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal

[libvirt] [RFC] Explicit boot device ordering

2011-01-11 Thread Jiri Denemark
Hi, I'm working on $SUBJ and I can't decide on XML representation of that. The goal is to let users specify an ordered list of devices to boot from, e.g., 2nd NIC, 1st NIC, 1st CD-ROM, 2nd IDE disk. We already have boot elements in /domain/os so we could make use of them or we could add a boot

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Richard W.M. Jones
On Tue, Jan 11, 2011 at 10:03:42PM +0800, Osier Yang wrote: 于 2011年01月11日 21:39, Richard W.M. Jones 写道: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send the patch to Red Hat internal list, as the

Re: [libvirt] [RFC] Explicit boot device ordering

2011-01-11 Thread Richard W.M. Jones
On Tue, Jan 11, 2011 at 03:17:26PM +0100, Jiri Denemark wrote: Hi, I'm working on $SUBJ and I can't decide on XML representation of that. The goal is to let users specify an ordered list of devices to boot from, e.g., 2nd NIC, 1st NIC, 1st CD-ROM, 2nd IDE disk. We already have boot elements

Re: [libvirt] [PATCH] qemu: sound: Support intel 'hda' model

2011-01-11 Thread Cole Robinson
On 01/11/2011 06:10 AM, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 11:46:14AM +0100, Gerd Hoffmann wrote: On 01/10/11 18:19, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires -device hda-output in order to actually get sound to the host. AIUI this is just

Re: [libvirt] [RFC] Explicit boot device ordering

2011-01-11 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 03:17:26PM +0100, Jiri Denemark wrote: Hi, I'm working on $SUBJ and I can't decide on XML representation of that. The goal is to let users specify an ordered list of devices to boot from, e.g., 2nd NIC, 1st NIC, 1st CD-ROM, 2nd IDE disk. We already have boot elements

Re: [libvirt] [PATCH] qemu: sound: Support intel 'hda' model

2011-01-11 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 09:58:42AM -0500, Cole Robinson wrote: On 01/11/2011 06:10 AM, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 11:46:14AM +0100, Gerd Hoffmann wrote: On 01/10/11 18:19, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires -device

Re: [libvirt] [PATCH] pass correct uri to source host when we do p2p migration

2011-01-11 Thread Eric Blake
On 01/11/2011 04:00 AM, Daniel P. Berrange wrote: * normal migration: the URI is an address of the target host as seen from the client machine. * peer2peer migration: the URI is an address of the target host as seen from the source machine. If nothing else, we need to improve the

Re: [libvirt] [PATCH] qemu: sound: Support intel 'hda' model

2011-01-11 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 11:10:04AM +, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 11:46:14AM +0100, Gerd Hoffmann wrote: On 01/10/11 18:19, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires -device hda-output in order to actually get sound to the host.

[libvirt] [PATCH] Basic support for VDE networking

2011-01-11 Thread Renzo Davoli
I have seen several messages asking for VDE networking support. There is an item also in your todo web page. http://libvirt.org/todo.html I have developed a patch to provide a basic support for VDE. It defines and manages the syntax: domain device interface type='vde' ... switch

[libvirt] [PATCH] Basic support for VDE networking

2011-01-11 Thread Renzo Davoli
I have seen several messages asking for VDE networking support. There is an item also in your todo web page. http://libvirt.org/todo.html I have developed a patch to provide a basic support for VDE. It defines and manages the syntax: domain device interface type='vde' ... switch

Re: [libvirt] [PATCH] memtune: Let virsh know the unlimited value for memory tunables

2011-01-11 Thread Eric Blake
On 01/10/2011 10:18 PM, Nikunj A. Dadhania wrote: Display unlimited when the memory cgroup settings says so. Unlimited is represented by INT64_MAX in memory cgroup. Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com Reported-by: Justin Clift jcl...@redhat.com ---

Re: [libvirt] [PATCH] cpu: plug memory leak

2011-01-11 Thread Eric Blake
On 01/10/2011 06:57 PM, Stefan Berger wrote: libvir-list-boun...@redhat.com wrote on 01/10/2011 06:59:12 PM: From: Eric Blake ebl...@redhat.com To: libvir-list@redhat.com Date: 01/10/2011 07:08 PM Subject: [libvirt] [PATCH] cpu: plug memory leak Sent by: libvir-list-boun...@redhat.com *

Re: [libvirt] [PATCH] network: plug memory leak

2011-01-11 Thread Eric Blake
On 01/10/2011 06:47 PM, Laine Stump wrote: On 01/10/2011 05:38 PM, Eric Blake wrote: * src/conf/network_conf.c (virNetworkDefParseXML): Release ipNodes. --- Another memleak found by valgrind; shown with additional context to make review easier. src/conf/network_conf.c |4 +++- 1

Re: [libvirt] [PATCH] network: plug unininitialized read found by valgrind

2011-01-11 Thread Eric Blake
On 01/10/2011 06:54 PM, Laine Stump wrote: On 01/10/2011 05:28 PM, Eric Blake wrote: * src/util/network.c (virSocketAddrMask): Zero out port, so that iptables can initialize just the netmask, then call virSocketFormatAddr without an uninitialized read in getnameinfo. --- I'm not sure if

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Eric Blake
On 01/11/2011 04:29 AM, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. * src/qemu/qemu_command.c NACK. Most

Re: [libvirt] [RFC] Explicit boot device ordering

2011-01-11 Thread Jiri Denemark
So for the first case, we could have something like os boot target='net1'/ boot target='net0'/ boot target='hdc'/ boot target='hdb'/ os Where target attributes would match /domain/devices/*/tar...@dev I'm not a huge fan of using */tar...@dev as the identifier

Re: [libvirt] [PATCH] Watchdog IB700 is not a PCI device (RHBZ#667091).

2011-01-11 Thread Eric Blake
On 01/11/2011 06:37 AM, Richard W.M. Jones wrote: Skip IB700 when assigning PCI slots. Note: the I6300ESB watchdog _is_ a PCI device. To test this: I applied this patch to libvirt-0.8.3-2.fc14 (rebasing it slightly: qemu_command.c didn't exist in that version) and installed this on my

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Osier Yang
于 2011年01月11日 22:25, Richard W.M. Jones 写道: On Tue, Jan 11, 2011 at 10:03:42PM +0800, Osier Yang wrote: 于 2011年01月11日 21:39, Richard W.M. Jones 写道: On Tue, Jan 11, 2011 at 09:21:26PM +0800, Osier Yang wrote: So, it means the newer qemu-kvm (of RHEL) doesn't support sdl anymore. Didn't send

Re: [libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

2011-01-11 Thread Osier Yang
于 2011年01月11日 23:33, Eric Blake 写道: On 01/11/2011 04:29 AM, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote: If the emulator doesn't support SDL graphic, we should reject the use of SDL graphic xml with error messages, but not ignore it silently. *

Re: [libvirt] [PATCH] qemu: sound: Support intel 'hda' model

2011-01-11 Thread Cole Robinson
On 01/11/2011 10:04 AM, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 09:58:42AM -0500, Cole Robinson wrote: On 01/11/2011 06:10 AM, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 11:46:14AM +0100, Gerd Hoffmann wrote: On 01/10/11 18:19, Cole Robinson wrote: In QEMU, the card itself is

Re: [libvirt] Docs team task: Update main docs.html page with index of all pages

2011-01-11 Thread Zdenek Styblik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On 01/08/11 12:00, Justin Clift wrote: [...] I'm thinking the very best thing you can do is get our Docs landing page under control for the main site: http://libvirt.org/docs.html It's very blank, relying on people to realise that

Re: [libvirt] Docs team task: Update main docs.html page with index of all pages

2011-01-11 Thread Justin Clift
On 12/01/2011, at 3:40 AM, Zdenek Styblik wrote: snip Why not to include all of that at that page or ... somewhere, if not already? Yeah, it probably would be better on a page somewhere. Feel like killing time writing a new page for the docs with that info? (maybe rewriting it to be less

Re: [libvirt] Docs team task: Update main docs.html page with index of all pages

2011-01-11 Thread Zdenek Styblik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/11 17:49, Justin Clift wrote: On 12/01/2011, at 3:40 AM, Zdenek Styblik wrote: snip Why not to include all of that at that page or ... somewhere, if not already? Yeah, it probably would be better on a page somewhere. Feel like

Re: [libvirt] Docs team task: Update main docs.html page with index of all pages

2011-01-11 Thread Justin Clift
On 12/01/2011, at 4:12 AM, Zdenek Styblik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/11 17:49, Justin Clift wrote: On 12/01/2011, at 3:40 AM, Zdenek Styblik wrote: snip Why not to include all of that at that page or ... somewhere, if not already? Yeah, it probably

Re: [libvirt] Docs team task: Update main docs.html page with index of all pages

2011-01-11 Thread Daniel P. Berrange
On Tue, Jan 11, 2011 at 05:40:40PM +0100, Zdenek Styblik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On 01/08/11 12:00, Justin Clift wrote: [...] I'm thinking the very best thing you can do is get our Docs landing page under control for the main site:

Re: [libvirt] Docs team task: Update main docs.html page with index of all pages

2011-01-11 Thread Zdenek Styblik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/11 19:18, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 05:40:40PM +0100, Zdenek Styblik wrote: This sounds like just a subset of what's already present in http://libvirt.org/sitemap.html It would be trivial to write some XSL

Re: [libvirt] Docs team task: Update main docs.html page with index of all pages

2011-01-11 Thread Justin Clift
On 12/01/2011, at 5:32 AM, Zdenek Styblik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/11 19:18, Daniel P. Berrange wrote: On Tue, Jan 11, 2011 at 05:40:40PM +0100, Zdenek Styblik wrote: This sounds like just a subset of what's already present in

Re: [libvirt] Docs team task: Update main docs.html page with index of all pages

2011-01-11 Thread Zdenek Styblik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/11 19:12, Justin Clift wrote: I'm thinking the steps on how to update the documentation itself. It's the kind of info that anyone updating the documentation would need to know. ? Justin, I don't want to promise anything here. I've

Re: [libvirt] Docs team task: Update main docs.html page with index of all pages

2011-01-11 Thread Justin Clift
On 12/01/2011, at 6:07 AM, Zdenek Styblik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/11 19:12, Justin Clift wrote: I'm thinking the steps on how to update the documentation itself. It's the kind of info that anyone updating the documentation would need to know. ?

Re: [libvirt] [PATCH] vbox: Silently ignore missing registry key on Windows

2011-01-11 Thread Matthias Bolte
2011/1/10 Eric Blake ebl...@redhat.com: On 01/10/2011 07:09 AM, Matthias Bolte wrote: Don't report an error when the VirtualBox registry key is missing, as this just indicates that VirtualBox is not installed in general. This matches the behavior of the XPCOM glue that silently ignores a

[libvirt] [PATCH] docs: add entry for archipel to the apps page

2011-01-11 Thread Justin Clift
--- docs/apps.html.in | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index 792c145..d4e74bb 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -67,6 +67,26 @@ /dd /dl +h2a

[libvirt] [PATCH] esx: Fix memory leak in HostSystem managed object free function

2011-01-11 Thread Matthias Bolte
--- src/esx/esx_vi_types.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 4ee4110..f3df2b5 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@ -1806,6 +1806,7 @@ ESX_VI__TEMPLATE__FREE(HostSystem,

Re: [libvirt] [PATCH] docs: add entry for archipel to the apps page

2011-01-11 Thread Eric Blake
On 01/11/2011 01:30 PM, Justin Clift wrote: The rest of your patch looked okay, but this caught my attention: dl @@ -122,7 +142,7 @@ dl dta href=http://honk.sigxcpu.org/projects/libvirt/#munin;for munin/a/dt dd -The plugins provided by Guido Günther

Re: [libvirt] [PATCH] esx: Fix memory leak in HostSystem managed object free function

2011-01-11 Thread Eric Blake
On 01/11/2011 01:41 PM, Matthias Bolte wrote: --- src/esx/esx_vi_types.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 4ee4110..f3df2b5 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@

Re: [libvirt] [PATCH] docs: add entry for archipel to the apps page

2011-01-11 Thread Justin Clift
On 12/01/2011, at 7:47 AM, Eric Blake wrote: On 01/11/2011 01:30 PM, Justin Clift wrote: The rest of your patch looked okay, but this caught my attention: dl @@ -122,7 +142,7 @@ dl dta href=http://honk.sigxcpu.org/projects/libvirt/#munin;for munin/a/dt dd -

[libvirt] [PATCH] docs: use xml entity encoding for extended character last name

2011-01-11 Thread Justin Clift
--- This fixes the busted appearance on libvirt.org. Already pushed under the trivial rule. docs/apps.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index 792c145..2ffb087 100644 --- a/docs/apps.html.in +++

Re: [libvirt] [PATCH] docs: use xml entity encoding for extended character last name

2011-01-11 Thread Justin Clift
On 12/01/2011, at 8:02 AM, Justin Clift wrote: --- This fixes the busted appearance on libvirt.org. Already pushed under the trivial rule. docs/apps.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index

[libvirt] [PATCHv2] docs: add entry for archipel to the apps page

2011-01-11 Thread Justin Clift
--- This time without the accidental change of encoding for unrelated parts. docs/apps.html.in | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index 792c145..d4e74bb 100644 --- a/docs/apps.html.in +++

Re: [libvirt] [PATCHv2] docs: add entry for archipel to the apps page

2011-01-11 Thread Eric Blake
On 01/11/2011 02:12 PM, Justin Clift wrote: --- This time without the accidental change of encoding for unrelated parts. docs/apps.html.in | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index

Re: [libvirt] [PATCHv2] docs: add entry for archipel to the apps page

2011-01-11 Thread Justin Clift
On 12/01/2011, at 8:23 AM, Eric Blake wrote: On 01/11/2011 02:12 PM, Justin Clift wrote: --- This time without the accidental change of encoding for unrelated parts. docs/apps.html.in | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git

[libvirt] tests/daemon-conf bug

2011-01-11 Thread Eric Blake
Right now, the daemon-conf test fires up an instance of libvirtd, but that instance tries to probe the installed location of cpu_map.xml rather than an in-tree location, which means the test is liable to fail if run on a just built but uninstalled binary: I/O warning : failed to load external

Re: [libvirt] [PATCH] pass correct uri to source host when we do p2p migration

2011-01-11 Thread Wen Congyang
At 01/11/2011 07:00 PM, Daniel P. Berrange Write: Also, nothing here is actually fixing the deadlock, which could likely be triggered, just by giving 2 URIs explicitly pointing to the same machine which is again requesting a localhost migration: virsh -c qemu+ssh://remotehost IP/system

[libvirt] [Patch v2 0/2] Some fixes about p2p migration

2011-01-11 Thread Wen Congyang
When we migrate a guest from remote host to localhost by p2p, the libvirtd on remote host will be deadlock. This patch fixes a bug and we can avoid the deadlock with this patch. The steps to reproduce this bug: # virsh -c qemu+ssh://remotehost IP/system migrate --p2p domain name

[libvirt] [PATCH v2 1/2] report error when specifying wrong desturi

2011-01-11 Thread Wen Congyang
When we do peer2peer migration, the dest uri is an address of the target host as seen from the source machine. So we must specify the ip or hostname of target host in dest uri. If we do not specify it, report an error to the user. Signed-off-by: Wen Congyang we...@cn.fujitsu.com ---

[libvirt] [PATCH v2 2/2] doc: improve the documentation of desturi

2011-01-11 Thread Wen Congyang
Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- tools/virsh.c |2 +- tools/virsh.pod | 13 + 2 files changed, 14 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 55e2a68..018e363 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -3375,7

[libvirt] [PATCH] Cancel migration if user presses Ctrl-C when migration is in progress

2011-01-11 Thread Hu Tao
While migration is in progress and virsh is waiting for its completion, user may want to terminate the progress by pressing Ctrl-C. But virsh just exits on user's Ctrl-C leaving migration in background that user isn't even aware of. It's not reasonable. This patch lets migration be terminated if