Re: [libvirt] build failure on ubuntu

2011-01-14 Thread Matthias Bolte
2011/1/14 Eric Blake ebl...@redhat.com: I haven't looked into this closely yet, but Daniel's security refactoring broke the Ubuntu 'make check' build when apparmor is enabled:  CC     secaatest.o secaatest.c: In function 'main': secaatest.c:18: error: implicit declaration of function

Re: [libvirt] [RFC PATCHv2 1/5] domain_conf: split source data out from ChrDef

2011-01-14 Thread Daniel P. Berrange
On Thu, Jan 13, 2011 at 05:34:33PM -0700, Eric Blake wrote: This opens up the possibility of reusing the smaller ChrSourceDef for both qemu monitor and a passthrough smartcard device. * src/conf/domain_conf.h (_virDomainChrDef): Factor host details... (_virDomainChrSourceDef): ...into new

Re: [libvirt] [RFC PATCHv2 2/5] qemu: move monitor device out of domain_conf common code

2011-01-14 Thread Daniel P. Berrange
On Thu, Jan 13, 2011 at 05:34:34PM -0700, Eric Blake wrote: * src/conf/domain_conf.h (virDomainChrDeviceType): Drop monitor. * src/conf/domain_conf.c (virDomainChrDevice) (virDomainChrDefParseTargetXML, virDomainChrDefFormat): Drop monitor support. * src/qemu/qemu_command.h

Re: [libvirt] [RFC PATCHv2 3/5] smartcard: add XML support for smartcard device

2011-01-14 Thread Daniel P. Berrange
On Thu, Jan 13, 2011 at 05:34:35PM -0700, Eric Blake wrote: Assuming a hypervisor that supports multiple smartcard devices in the guest, this would be a valid XML description: This looks pretty reasonable, but is going to require additions to the security driver code. In the SetAllLabel method

Re: [libvirt] [RFC PATCHv2 4/5] smartcard: add domain conf support

2011-01-14 Thread Daniel P. Berrange
On Thu, Jan 13, 2011 at 05:34:36PM -0700, Eric Blake wrote: * src/conf/domain_conf.h (virDomainSmartcardType): New enum. (virDomainSmartcardDef): New struct. (virDomainDef): Include smartcards. (virDomainSmartcardDefIterator): New typedef. (virDomainSmartcardDefFree,

[libvirt] [PATCH] cpu: Add support for Westmere CPU model

2011-01-14 Thread Jiri Denemark
--- src/cpu/cpu_map.xml |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 75c6522..35dca20 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -142,6 +142,9 @@ feature name='popcnt' !-- CPUID_EXT_POPCNT

Re: [libvirt] [PATCH] Add XML config switch to enable/disable vhost-net support

2011-01-14 Thread Daniel P. Berrange
On Thu, Jan 13, 2011 at 01:45:28AM -0500, Laine Stump wrote: This patch is in response to https://bugzilla.redhat.com/show_bug.cgi?id=643050 The existing libvirt support for the vhost-net backend to the virtio network driver happens automatically - if the vhost-net device is available,

Re: [libvirt] [PATCH] Enable tuning of qemu network tap device sndbuf size

2011-01-14 Thread Daniel P. Berrange
On Thu, Jan 13, 2011 at 01:45:29AM -0500, Laine Stump wrote: This is in response to a request in: https://bugzilla.redhat.com/show_bug.cgi?id=665293 In short, under heavy load, it's possible for qemu's networking to lock up due to the tap device's default 1MB sndbuf being inadequate.

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-14 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 12:41:13PM +, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 05:34:37PM -0700, Eric Blake wrote: +virCommandAddArgBuffer(cmd, smartcard_buf); +break; +case VIR_DOMAIN_SMARTCARD_TYPE_PASSTHROUGH: +

Re: [libvirt] [PATCH 3/3] qemu: Add conf option to auto setup VNC unix sockets

2011-01-14 Thread Cole Robinson
On 01/13/2011 08:21 AM, Daniel P. Berrange wrote: On Wed, Jan 12, 2011 at 12:32:44PM -0500, Cole Robinson wrote: If vnc_auto_unix_socket is enabled, any VNC devices without a hardcoded listen or socket value will be setup to serve over a unix socket in /var/lib/libvirt/qemu/$vmname.vnc. We

Re: [libvirt] [PATCH 2/3] qemu: improve device flag parsing

2011-01-14 Thread Jiri Denemark
* src/qemu/qemu_capabilities.h (qemuCapsParseDeviceStr): New prototype. * src/qemu/qemu_capabilities.c (qemuCapsParsePCIDeviceStrs) Rename and split... (qemuCapsExtractDeviceStr, qemuCapsParseDeviceStr): ...to make it easier to add and test device-specific checks.

[libvirt] virsh setmaxmem granularity for vSphere/ESX?

2011-01-14 Thread Justin Clift
Hi Matthias, Do you know if the virsh setmaxmem has the same MB granularity as setmem (on vSphere/ESX)? Regards and best wishes, Justin Clift -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] OpenVZ and Libvirt

2011-01-14 Thread Nathan Stratton
I have been working to get libvirt to work with openvz and kvm. I have had no issues with KVM but libvirt is hit or miss. Sometimes I get it to work, but most of the time I get back out of memory. I have tried all recent versions of libvirt and vzctl from openvz. Any pointers? 17:52:31.974:

Re: [libvirt] [PATCH] util: add missing string-integer conversion functions

2011-01-14 Thread Eric Blake
On 01/13/2011 11:09 PM, Laine Stump wrote: On 01/13/2011 05:10 PM, Eric Blake wrote: It was awkward having only int conversion in the virStrToLong family, but only long conversion in the virXPath family. Make both families support both types. ACK. Just what that doctor ordered! Pushed.

Re: [libvirt] [PATCH] cpu: Add support for Westmere CPU model

2011-01-14 Thread Eric Blake
On 01/14/2011 06:22 AM, Jiri Denemark wrote: --- src/cpu/cpu_map.xml |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 75c6522..35dca20 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -142,6

Re: [libvirt] [PATCH 2/3] qemu: improve device flag parsing

2011-01-14 Thread Eric Blake
On 01/14/2011 08:03 AM, Jiri Denemark wrote: * src/qemu/qemu_capabilities.h (qemuCapsParseDeviceStr): New prototype. * src/qemu/qemu_capabilities.c (qemuCapsParsePCIDeviceStrs) Rename and split... (qemuCapsExtractDeviceStr, qemuCapsParseDeviceStr): ...to make it easier to add and test

[libvirt] virsh setmem and setmaxmem: which XML do they match?

2011-01-14 Thread Justin Clift
Hi all, Updating the man pages for the virsh setmem and setmaxmem commands at the moment. These two commands only run on active guest domains. So, as a helpful pointer on how to make the change with an inactive domain, I'm going to mention what the equivalent XML tag is for use with virsh

Re: [libvirt] [PATCH 1/4] Add HAP to virDomainFeature enum

2011-01-14 Thread Jim Fehlig
Eric Blake wrote: On 01/13/2011 10:20 AM, Jim Fehlig wrote: Daniel P. Berrange wrote: On Wed, Jan 05, 2011 at 04:32:39PM -0700, Jim Fehlig wrote: Extend the virDomainFeature enumeration to include HAP (hardware assisted paging) feature. Hardware features such as

Re: [libvirt] [PATCH 1/4] Add HAP to virDomainFeature enum

2011-01-14 Thread Eric Blake
On 01/14/2011 09:05 AM, Jim Fehlig wrote: Hmm, a bug in my test scripts caused me to miss this. Looking at logs make check actually failed for me here: CC secaatest.o cc1: warnings being treated as errors secaatest.c: In function 'main': Yep, secaatest is an independent failure,

Re: [libvirt] build failure on ubuntu

2011-01-14 Thread Eric Blake
On 01/14/2011 02:56 AM, Matthias Bolte wrote: 2011/1/14 Eric Blake ebl...@redhat.com: I haven't looked into this closely yet, but Daniel's security refactoring broke the Ubuntu 'make check' build when apparmor is enabled: CC secaatest.o secaatest.c: In function 'main': secaatest.c:18:

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-14 Thread Eric Blake
On 01/13/2011 02:45 PM, Cole Robinson wrote: @@ -3751,6 +3753,12 @@ qemuBuildCommandLine(virConnectPtr conn, goto error; virCommandAddArg(cmd, str); + +if (sound-model == VIR_DOMAIN_SOUND_MODEL_ICH6) { +

Re: [libvirt] [PATCH] Add XML config switch to enable/disable vhost-net support

2011-01-14 Thread Laine Stump
On 01/14/2011 08:22 AM, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 01:45:28AM -0500, Laine Stump wrote: This patch is in response to https://bugzilla.redhat.com/show_bug.cgi?id=643050 The existing libvirt support for the vhost-net backend to the virtio network driver happens

Re: [libvirt] [PATCH] cpu: Add support for Westmere CPU model

2011-01-14 Thread Jiri Denemark
src/cpu/cpu_map.xml |9 + 1 files changed, 9 insertions(+), 0 deletions(-) ACK. Thanks, pushed. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Add XML config switch to enable/disable vhost-net support

2011-01-14 Thread Laine Stump
On 01/13/2011 03:59 PM, Eric Blake wrote: On 01/12/2011 11:45 PM, Laine Stump wrote: This patch is in response to https://bugzilla.redhat.com/show_bug.cgi?id=643050 The existing libvirt support for the vhost-net backend to the virtio network driver happens automatically - if the vhost-net

[libvirt] [PATCH v2 0/4] Explicit boot device ordering

2011-01-14 Thread Jiri Denemark
Currently, boot order can be specified per device class but there is no way to specify exact disk/NIC device to boot from. This patchset fixes that. There were two options suggested for how this should be modeled in domain XML: 1) os boot target='net1'/ boot target='net0'/

[libvirt] [PATCH v2 3/4] qemu: Support per-device boot ordering

2011-01-14 Thread Jiri Denemark
Support for this is included in qemu and seabios from upstream git. --- Notes: Version 2: - support for floppy devices - rebased on top of Eric's capabilities changes src/qemu/qemu_capabilities.c |9 + src/qemu/qemu_capabilities.h |1 + src/qemu/qemu_command.c |

[libvirt] [PATCH v2 2/4] Introduce per-device boot element

2011-01-14 Thread Jiri Denemark
Currently, boot order can be specified per device class but there is no way to specify exact disk/NIC device to boot from. This patch adds boot order='N'/ element which can be used inside disk/ and interface/. This is incompatible with the older os/boot element. Since not all hypervisors support

[libvirt] [PATCH v2 4/4] tests: Add tests for per-device boot elements

2011-01-14 Thread Jiri Denemark
--- Notes: Version 2: - support for floppy devices .../qemuxml2argvdata/qemuxml2argv-boot-order.args |1 + tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml | 52 tests/qemuxml2argvtest.c |2 + tests/qemuxml2xmltest.c

[libvirt] [PATCH v2 1/4] conf: Move boot parsing into a separate function

2011-01-14 Thread Jiri Denemark
--- src/conf/domain_conf.c | 99 1 files changed, 58 insertions(+), 41 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2c54683..7c7a6fa 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4583,6

Re: [libvirt] [PATCH] Enable tuning of qemu network tap device sndbuf size

2011-01-14 Thread Laine Stump
On 01/14/2011 08:27 AM, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 01:45:29AM -0500, Laine Stump wrote: This is in response to a request in: https://bugzilla.redhat.com/show_bug.cgi?id=665293 In short, under heavy load, it's possible for qemu's networking to lock up due to the tap

Re: [libvirt] [PATCH] Enable tuning of qemu network tap device sndbuf size

2011-01-14 Thread Laine Stump
On 01/13/2011 04:21 PM, Eric Blake wrote: On 01/12/2011 11:45 PM, Laine Stump wrote: This is in response to a request in: https://bugzilla.redhat.com/show_bug.cgi?id=665293 In short, under heavy load, it's possible for qemu's networking to lock up due to the tap device's default 1MB

Re: [libvirt] [PATCH v2 1/4] conf: Move boot parsing into a separate function

2011-01-14 Thread Eric Blake
On 01/14/2011 10:04 AM, Jiri Denemark wrote: --- src/conf/domain_conf.c | 99 1 files changed, 58 insertions(+), 41 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c ACK; simple refactoring. -- Eric Blake

Re: [libvirt] [RFC PATCHv2 3/5] smartcard: add XML support for smartcard device

2011-01-14 Thread Eric Blake
On 01/14/2011 05:24 AM, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 05:34:35PM -0700, Eric Blake wrote: Assuming a hypervisor that supports multiple smartcard devices in the guest, this would be a valid XML description: This looks pretty reasonable, but is going to require additions

[libvirt] [PATCHv2] Add XML config switch to enable/disable vhost-net support

2011-01-14 Thread Laine Stump
This patch is in response to https://bugzilla.redhat.com/show_bug.cgi?id=643050 The existing libvirt support for the vhost-net backend to the virtio network driver happens automatically - if the vhost-net device is available, it is always enabled, otherwise the standard userland virtio backend

[libvirt] [PATCHv2] Enable tuning of qemu network tap device sndbuf size

2011-01-14 Thread Laine Stump
This is in response to a request in: https://bugzilla.redhat.com/show_bug.cgi?id=665293 In short, under heavy load, it's possible for qemu's networking to lock up due to the tap device's default 1MB sndbuf being inadequate. adding sndbuf=0 to the qemu commandline -netdevice option will

Re: [libvirt] [PATCH v2 2/4] Introduce per-device boot element

2011-01-14 Thread Eric Blake
On 01/14/2011 10:04 AM, Jiri Denemark wrote: Currently, boot order can be specified per device class but there is no way to specify exact disk/NIC device to boot from. This patch adds boot order='N'/ element which can be used inside disk/ and interface/. This is incompatible with the older

Re: [libvirt] [RFC PATCHv2 4/5] smartcard: add domain conf support

2011-01-14 Thread Eric Blake
On 01/14/2011 05:29 AM, Daniel P. Berrange wrote: +case VIR_DOMAIN_SMARTCARD_TYPE_HOST_CERTIFICATES: +i = 0; +for (cur = node-children; + cur cur-type == XML_ELEMENT_NODE + xmlStrEqual(cur-name, BAD_CAST certificate); + cur =

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-14 Thread Eric Blake
On 01/13/2011 08:45 AM, Cole Robinson wrote: @@ -3751,6 +3753,12 @@ qemuBuildCommandLine(virConnectPtr conn, goto error; virCommandAddArg(cmd, str); + +if (sound-model == VIR_DOMAIN_SOUND_MODEL_ICH6) { +

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-14 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 11:13:06AM -0700, Eric Blake wrote: On 01/13/2011 08:45 AM, Cole Robinson wrote: @@ -3751,6 +3753,12 @@ qemuBuildCommandLine(virConnectPtr conn, goto error; virCommandAddArg(cmd, str); + +if

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-14 Thread Eric Blake
On 01/14/2011 05:41 AM, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 05:34:37PM -0700, Eric Blake wrote: Still to go - add .args files to match .xml files in testsuite * src/qemu/qemu_command.c (qemuBuildCommandLine): Emit smartcard options. (qemuAssignDeviceAliases): Assign an alias

[libvirt] [PATCH] Fix 'make check' after commit 04197350

2011-01-14 Thread Jim Fehlig
I broke 'make check' with commit 04197350 by unconditionally emitting 'hap=' in xen xm driver. Only emit 'hap=' if xendConfigVersion = 3. I've tested sending 'hap=' to a Xen 3.2 machine without support for hap setting and verified that xend silently drops the unrecognized setting. ---

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-14 Thread Eric Blake
On 01/14/2011 06:46 AM, Daniel P. Berrange wrote: On Fri, Jan 14, 2011 at 12:41:13PM +, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 05:34:37PM -0700, Eric Blake wrote: +virCommandAddArgBuffer(cmd, smartcard_buf); +break; +case

Re: [libvirt] [PATCH v2 3/4] qemu: Support per-device boot ordering

2011-01-14 Thread Eric Blake
On 01/14/2011 10:04 AM, Jiri Denemark wrote: Support for this is included in qemu and seabios from upstream git. --- Notes: Version 2: - support for floppy devices - rebased on top of Eric's capabilities changes diff --git a/src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH] Fix 'make check' after commit 04197350

2011-01-14 Thread Eric Blake
On 01/14/2011 11:29 AM, Jim Fehlig wrote: I broke 'make check' with commit 04197350 by unconditionally emitting 'hap=' in xen xm driver. Only emit 'hap=' if xendConfigVersion = 3. I've tested sending 'hap=' to a Xen 3.2 machine without support for hap setting and verified that xend silently

Re: [libvirt] [PATCH v2 4/4] tests: Add tests for per-device boot elements

2011-01-14 Thread Eric Blake
On 01/14/2011 10:04 AM, Jiri Denemark wrote: --- Notes: Version 2: - support for floppy devices + devices +emulator/usr/bin/qemu/emulator +disk type='block' device='disk' + source dev='/dev/HostVG/QEMUGuest1'/ + target dev='hda' bus='ide'/ + address

Re: [libvirt] [PATCH] Fix 'make check' after commit 04197350

2011-01-14 Thread Jim Fehlig
Eric Blake wrote: On 01/14/2011 11:29 AM, Jim Fehlig wrote: I broke 'make check' with commit 04197350 by unconditionally emitting 'hap=' in xen xm driver. Only emit 'hap=' if xendConfigVersion = 3. I've tested sending 'hap=' to a Xen 3.2 machine without support for hap setting and

Re: [libvirt] [PATCH 1/2] qemu: add set_password and expire_password monitor commands

2011-01-14 Thread Daniel P. Berrange
On Mon, Jan 10, 2011 at 12:12:32PM +0100, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com --- src/qemu/qemu_monitor.c | 77 ++ src/qemu/qemu_monitor.h |7 src/qemu/qemu_monitor_json.c | 56

Re: [libvirt] [PATCH 2/2] Use the new set_password monitor command to set password.

2011-01-14 Thread Daniel P. Berrange
On Mon, Jan 10, 2011 at 12:12:33PM +0100, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com We try to use that command first when setting a VNC/SPICE password. If that doesn't work we fallback to the legacy VNC only password Allow an expiry time to be set, if

Re: [libvirt] [PATCHv2] Add XML config switch to enable/disable vhost-net support

2011-01-14 Thread Eric Blake
interface type=network model type=virtio/ driver name=vhost/ will force use of vhost-net (if it's not available, the domain will fail to start). if driver name=qemu, vhost-net will not be used even if it is available. Changes from V1: enum now starts at 0 instead

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-14 Thread Daniel P. Berrange
On Thu, Jan 13, 2011 at 10:45:41AM -0500, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires a codec (either -device hda-output or -device hda-duplex) to actually output sound. We set up an hda-duplex codec by default: I think it's important that a simple sound

Re: [libvirt] [PATCHv2] Enable tuning of qemu network tap device sndbuf size

2011-01-14 Thread Eric Blake
On 01/14/2011 10:35 AM, Laine Stump wrote: The sndbuf value is put inside a tune element of each interface in the domain. The intent is that further tunable settings will also be placed inside this element. interface type='network' ... tune sndbuf0/sndbuf

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-14 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 11:25:36AM -0700, Eric Blake wrote: On 01/14/2011 05:41 AM, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 05:34:37PM -0700, Eric Blake wrote: +virCommandAddArg(cmd, devstr); +VIR_FREE(devstr); + +virCommandAddArg(cmd,

Re: [libvirt] [PATCHv2] Add XML config switch to enable/disable vhost-net support

2011-01-14 Thread Laine Stump
On 01/14/2011 02:02 PM, Eric Blake wrote: interface type=network model type=virtio/ driver name=vhost/ will force use of vhost-net (if it's not available, the domain will fail to start). if driver name=qemu, vhost-net will not be used even if it is available. @@ -2559,6

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-14 Thread Eric Blake
On 01/14/2011 12:23 PM, Daniel P. Berrange wrote: Alon's docs are showing the simplified syntax suitable for end users. This doesn't guarentee a stable guest visible ABI. Looking at the code, we need to set the 'slot' parameter on each ccid device we have. This means we need a new address type

Re: [libvirt] [PATCH 2/2] Use the new set_password monitor command to set password.

2011-01-14 Thread Eric Blake
On 01/14/2011 11:59 AM, Daniel P. Berrange wrote: On Mon, Jan 10, 2011 at 12:12:33PM +0100, Marc-André Lureau wrote: From: Marc-André Lureau marcandre.lur...@redhat.com We try to use that command first when setting a VNC/SPICE password. If that doesn't work we fallback to the legacy VNC only

Re: [libvirt] cont command failing via JSON monitor on restore

2011-01-14 Thread Laine Stump
On 01/13/2011 04:29 PM, Jim Fehlig wrote: Daniel P. Berrange wrote: Yep, it wasn't really intended as a fix. It was intended to make the error scenario clearly detectable, which has succeeded as per Jim's report. The fact that QMP returned an error in this way, means we can now

Re: [libvirt] OpenVZ and Libvirt

2011-01-14 Thread Laine Stump
On 01/14/2011 10:39 AM, Nathan Stratton wrote: I have been working to get libvirt to work with openvz and kvm. I have had no issues with KVM but libvirt is hit or miss. Sometimes I get it to work, but most of the time I get back out of memory. I have tried all recent versions of libvirt and

[libvirt] [PATCH 0/7] patch queue cleanup

2011-01-14 Thread Eric Blake
I've been building up several (unrelated) patches that haven't been reviewed yet; here they are in no particular order except that 6 depends on 5, and that 4 depends on 3. Eric Blake (6): datatypes: avoid redundant __FUNCTION__ maint: improve sc_prohibit_strncmp syntax check build: let

[libvirt] [PATCH 1/7] datatypes: avoid redundant __FUNCTION__

2011-01-14 Thread Eric Blake
virLibConnError already includes __FUNCTION__ in its output, so we were redundant. Furthermore, clang warns that __FUNCTION__ is not a string literal (at least __FUNCTION__ will never contain %, so it was not a security risk). * src/datatypes.c: Replace __FUNCTION__ with a descriptive string.

[libvirt] [PATCH 2/7] maint: improve sc_prohibit_strncmp syntax check

2011-01-14 Thread Eric Blake
* .gnulib: Update, for sc_prohibit_strcmp fix. * cfg.mk: Adjust copyright; the only FSF portions come from when this file was copied from coreutils. (sc_prohibit_strncmp): Copy bug-fixes from sc_prohibit_strcmp. * .x-sc_prohibit_strcmp: Delete, now that rule is smarter. * .x-sc_prohibit_strncmp:

[libvirt] [PATCH 4/7] build: let xgettext see strings in libvirt-guests

2011-01-14 Thread Eric Blake
* tools/libvirt-guests.init.in: Rename... * tools/libvirt-guests.init.sh: ...so that xgettext's language detection via suffix will work. * po/POTFILES.in: Update all references. * tools/Makefile.am (EXTRA_DIST, libvirt-guests.init): Likewise. --- po/POTFILES.in

[libvirt] [PATCH 3/7] libvirt-guests: remove bashisms

2011-01-14 Thread Eric Blake
From: Laurent Léonard laur...@open-minds.org * tools/libvirt-guests.init.sh: Use only POSIX shell features, which includes using gettext.sh for translation rather than $. * tools/Makefile.am (libvirt-guests.init): Supply a few more substitutions. * po/POTFILES.in: Mark that libvirt-guests.init

[libvirt] [PATCH 7/7] qemu: improve efficiency of dd during snapshots

2011-01-14 Thread Eric Blake
POSIX states about dd: If the bs=expr operand is specified and no conversions other than sync, noerror, or notrunc are requested, the data returned from each input block shall be written as a separate output block; if the read returns less than a full block and the sync conversion is not

[libvirt] [PATCH 5/7] qemu: use -incoming fd:n to avoid qemu holding fd indefinitely

2011-01-14 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=620363 When using -incoming stdio or -incoming exec:, qemu keeps the stdin fd open long after the migration is complete. Not to mention that exec:cat is horribly inefficient, by doubling the I/O and going through a popen interface in qemu. The new

[libvirt] [PATCH 6/7] qemu: use lighter-weight fd:n on incoming tunneled migration

2011-01-14 Thread Eric Blake
Outgoing migration still has to use a Unix socket and or exec netcat, since there is no way to pass a migration fd into qemu via monitor commands, but incoming migration need not suffer from the complexity. * src/qemu/qemu_driver.c (qemudDomainMigratePrepareTunnel): Replace Unix socket with

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-14 Thread Daniel P. Berrange
On Fri, Jan 14, 2011 at 12:34:21PM -0700, Eric Blake wrote: On 01/14/2011 12:23 PM, Daniel P. Berrange wrote: Alon's docs are showing the simplified syntax suitable for end users. This doesn't guarentee a stable guest visible ABI. Looking at the code, we need to set the 'slot' parameter on

Re: [libvirt] cont command failing via JSON monitor on restore

2011-01-14 Thread Jim Fehlig
Laine Stump wrote: On 01/13/2011 04:29 PM, Jim Fehlig wrote: Daniel P. Berrange wrote: Yep, it wasn't really intended as a fix. It was intended to make the error scenario clearly detectable, which has succeeded as per Jim's report. The fact that QMP returned an error in this way,

Re: [libvirt] [PATCH 1/7] datatypes: avoid redundant __FUNCTION__

2011-01-14 Thread Matthias Bolte
2011/1/14 Eric Blake ebl...@redhat.com: virLibConnError already includes __FUNCTION__ in its output, so we were redundant.  Furthermore, clang warns that __FUNCTION__ is not a string literal (at least __FUNCTION__ will never contain %, so it was not a security risk). @@ -344,8 +344,16 @@

[libvirt] [PATCH] virsh: Use WITH_SECDRIVER_APPARMOR to detect AppArmor support

2011-01-14 Thread Matthias Bolte
There is no ENABLE_SECDRIVER_APPARMOR. --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 4f103ae..b86d92f 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -11847,7 +11847,7 @@ vshShowVersion(vshControl *ctl

[libvirt] [PATCH] tests: Remove obsolete secaatest

2011-01-14 Thread Matthias Bolte
Before the security driver was refactored in d6623003 seclabeltest and secaatest were basically the same. seclabeltest was meant for SELinux and secaatest for AppArmor. Both tests exited early when the specific security driver backend wasn't enabled. With the new security manager trying to

Re: [libvirt] [PATCH] virsh: Use WITH_SECDRIVER_APPARMOR to detect AppArmor support

2011-01-14 Thread Eric Blake
On 01/14/2011 02:47 PM, Matthias Bolte wrote: There is no ENABLE_SECDRIVER_APPARMOR. --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 4f103ae..b86d92f 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@

Re: [libvirt] [PATCH] tests: Remove obsolete secaatest

2011-01-14 Thread Eric Blake
On 01/14/2011 02:48 PM, Matthias Bolte wrote: Before the security driver was refactored in d6623003 seclabeltest and secaatest were basically the same. seclabeltest was meant for SELinux and secaatest for AppArmor. Both tests exited early when the specific security driver backend wasn't

Re: [libvirt] [PATCH 2/7] maint: improve sc_prohibit_strncmp syntax check

2011-01-14 Thread Matthias Bolte
2011/1/14 Eric Blake ebl...@redhat.com: * .gnulib: Update, for sc_prohibit_strcmp fix. * cfg.mk: Adjust copyright; the only FSF portions come from when this file was copied from coreutils. (sc_prohibit_strncmp): Copy bug-fixes from sc_prohibit_strcmp. * .x-sc_prohibit_strcmp: Delete, now that

Re: [libvirt] [PATCH 1/7] datatypes: avoid redundant __FUNCTION__

2011-01-14 Thread Eric Blake
On 01/14/2011 02:45 PM, Matthias Bolte wrote: 2011/1/14 Eric Blake ebl...@redhat.com: virLibConnError already includes __FUNCTION__ in its output, so we were redundant. Furthermore, clang warns that __FUNCTION__ is not a string literal (at least __FUNCTION__ will never contain %, so it was

Re: [libvirt] [PATCH 2/7] maint: improve sc_prohibit_strncmp syntax check

2011-01-14 Thread Eric Blake
On 01/14/2011 03:01 PM, Matthias Bolte wrote: 2011/1/14 Eric Blake ebl...@redhat.com: * .gnulib: Update, for sc_prohibit_strcmp fix. * cfg.mk: Adjust copyright; the only FSF portions come from when this file was copied from coreutils. (sc_prohibit_strncmp): Copy bug-fixes from

[libvirt] [PATCH 2/3] qemu aio: parse aio support from qemu -help

2011-01-14 Thread Eric Blake
From: Matthias Dahl mdv...@designassembly.de Signed-off-by: Eric Blake ebl...@redhat.com --- src/qemu/qemu_capabilities.c |2 ++ src/qemu/qemu_capabilities.h |3 ++- tests/qemuhelptest.c | 12 3 files changed, 12 insertions(+), 5 deletions(-) diff --git

[libvirt] [PATCH 0/3] qemu aio mode per disk

2011-01-14 Thread Eric Blake
I've taken the patch that Matthias Dahl originally posted _months_ ago: https://www.redhat.com/archives/libvir-list/2010-April/msg00888.html and updated it by splitting into three patches, adding more testsuite coverage, improving documentation, and altering the names slightly. The end result is

[libvirt] [PATCH 1/3] qemu aio: add XML parsing

2011-01-14 Thread Eric Blake
From: Matthias Dahl mdv...@designassembly.de Allows io={threads|native} as an optional attribute to driver. Signed-off-by: Eric Blake ebl...@redhat.com --- AUTHORS |1 + docs/formatdomain.html.in | 40 +--- docs/schemas/domain.rng |

[libvirt] [PATCH 3/3] qemu aio: enable support

2011-01-14 Thread Eric Blake
qemu allows the user to choose what io storage api should be used, either the default (threads) or native (linux aio) which in the latter case can result in better performance. Based on a patch originally by Matthias Dahl. Red Hat Bugzilla #591703 Signed-off-by: Eric Blake ebl...@redhat.com ---

Re: [libvirt] [PATCHv4] PHYP: Adding network interface management

2011-01-14 Thread Eric Blake
On 12/29/2010 11:04 AM, Eduardo Otubo wrote: This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details: Finally getting around to reviewing this again. I'm not intentionally

Re: [libvirt] [PATCH v5] memtune: Let virsh know the unlimited value for memory tunables

2011-01-14 Thread Eric Blake
On 01/13/2011 02:18 AM, Nikunj A. Dadhania wrote: Here is one more spin and guess we would be finally there :) Here's hoping. From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com Display or set unlimited values for memory paramters. Unlimited is s/paramters/parameters/ represented by