[libvirt] [PATCH] Use VIR_ERR_OPERATION_INVALID when appropriated

VIR_ERR_OPERATION_INVALID means that the operation is not valid for the current state of the involved object. --- src/esx/esx_driver.c|1 - src/lxc/lxc_driver.c|2 +- src/network/bridge_driver.c |2 +- src/opennebula/one_driver.c |2 +- src/openvz/openvz_driver.c |

[libvirt] [PATCH] Remove two unused PATH_MAX-sized char arrays from the stack

--- src/storage/storage_driver.c | 16 ++-- src/uml/uml_driver.c |8 ++-- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 67d043b..5373025 100644 --- a/src/storage/storage_driver.c +++ b

[libvirt] [PATCH] Fix misuse of VIR_ERR_INVALID_* error code

VIR_ERR_INVALID_* is meant for invalid pointers only. --- src/conf/nwfilter_conf.c |6 +++--- src/conf/storage_conf.c |2 +- src/network/bridge_driver.c | 20 ++-- src/nwfilter/nwfilter_driver.c|6 +++--- sr

[libvirt] [PATCH] Simplify "NWFilterPool" to "NWFilter"

The public object is called NWFilter but the corresponding private object is called NWFilterPool. I don't see compelling reasons for this Pool suffix. One might argue that an NWFilter is a "pool" of rules, etc. Remove the Pool suffix from NWFilterPool. No functional change included. --- cfg.mk

[libvirt] [PATCH] datatypes: Fix outdated function names in the documentation

--- src/datatypes.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/datatypes.c b/src/datatypes.c index b43a571..5197863 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -821,7 +821,7 @@ virUnrefInterface(virInterfacePtr iface) { * Lookup if the storage p

[libvirt] [PATCH] Add documentation for VIR_DOMAIN_MEMORY_PARAM_UNLIMITED

Otherwise apibuild.py complains about it. --- include/libvirt/libvirt.h.in |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 055eb2e..7ecbeb6 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvi

[libvirt] [PATCH] datatypes: Get virSecretFreeName in sync with the other free functions

--- src/datatypes.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/datatypes.c b/src/datatypes.c index c549c74..b43a571 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -113,19 +113,16 @@ virStorageVolFreeName(virStorageVolPtr vol, const char *name

Re: [libvirt] [PATCH] tests: Remove obsolete secaatest

2011/1/14 Eric Blake : > On 01/14/2011 02:48 PM, Matthias Bolte wrote: >> Before the security driver was refactored in d6623003 seclabeltest and >> secaatest were basically the same. seclabeltest was meant for SELinux >> and secaatest for AppArmor. Both tests exited early when the specific >> secur

Re: [libvirt] [PATCH 5/7] qemu: use -incoming fd:n to avoid qemu holding fd indefinitely

2011/1/14 Eric Blake : > https://bugzilla.redhat.com/show_bug.cgi?id=620363 > > When using -incoming stdio or -incoming exec:, qemu keeps the > stdin fd open long after the migration is complete.  Not to > mention that exec:cat is horribly inefficient, by doubling the > I/O and going through a pope

Re: [libvirt] [PATCH 3/7] libvirt-guests: remove bashisms

2011/1/14 Eric Blake : > From: Laurent Léonard > > * tools/libvirt-guests.init.sh: Use only POSIX shell features, which > includes using gettext.sh for translation rather than $"". > * tools/Makefile.am (libvirt-guests.init): Supply a few more substitutions. > * po/POTFILES.in: Mark that libvirt-g

Re: [libvirt] [PATCH 4/7] build: let xgettext see strings in libvirt-guests

2011/1/14 Eric Blake : > * tools/libvirt-guests.init.in: Rename... > * tools/libvirt-guests.init.sh: ...so that xgettext's language > detection via suffix will work. > * po/POTFILES.in: Update all references. > * tools/Makefile.am (EXTRA_DIST, libvirt-guests.init): Likewise. > --- ACK. Matthias

Re: [libvirt] [PATCH] virsh: Use WITH_SECDRIVER_APPARMOR to detect AppArmor support

2011/1/14 Eric Blake : > On 01/14/2011 02:47 PM, Matthias Bolte wrote: >> There is no ENABLE_SECDRIVER_APPARMOR. >> --- >>  tools/virsh.c |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/tools/virsh.c b/tools/virsh.c >> index 4f103ae..b86d92f 100644 >> --- a/tools/v

[libvirt] [PATCH] docs: Move the "Network Filtering" page one level up in the hierarchy

"Network Filtering" is not directly related to "Networks". Suggested by Daniel P. Berrange. --- docs/sitemap.html.in | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/docs/sitemap.html.in b/docs/sitemap.html.in index 490450e..7077038 100644 --- a/docs/sitemap.html.

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

On Fri, Jan 14, 2011 at 07:23:17PM +, Daniel P. Berrange wrote: > On Fri, Jan 14, 2011 at 11:25:36AM -0700, Eric Blake wrote: > > On 01/14/2011 05:41 AM, Daniel P. Berrange wrote: > > > On Thu, Jan 13, 2011 at 05:34:37PM -0700, Eric Blake wrote: > > > > > >> +virCommandAddArg(cmd,

Re: [libvirt] [RFC PATCHv2 3/5] smartcard: add XML support for device

On Fri, Jan 14, 2011 at 10:22:19AM -0700, Eric Blake wrote: > On 01/14/2011 05:24 AM, Daniel P. Berrange wrote: > > On Thu, Jan 13, 2011 at 05:34:35PM -0700, Eric Blake wrote: > >> Assuming a hypervisor that supports multiple smartcard devices in the > >> guest, this would be a valid XML descriptio