Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-18 Thread Alon Levy
On Mon, Jan 17, 2011 at 01:12:28PM -0700, Eric Blake wrote: On 01/17/2011 11:42 AM, Alon Levy wrote: dev: ccid-card-emulated, id dev-prop: backend = nss-emulated dev-prop: cert1 = null dev-prop: cert2 = null

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-18 Thread Alon Levy
On Mon, Jan 17, 2011 at 01:12:28PM -0700, Eric Blake wrote: On 01/17/2011 11:42 AM, Alon Levy wrote: dev: ccid-card-emulated, id dev-prop: backend = nss-emulated dev-prop: cert1 = null dev-prop: cert2 = null

Re: [libvirt] [PATCH 2/3] qemu: improve device flag parsing

2011-01-18 Thread Eric Blake
On 01/17/2011 10:39 PM, Wen Congyang wrote: +cmd = virCommandNewArgList(qemu, + -device, pci-assign,?, + NULL); The qemu that I used does not support '-device pci-assign,?'... So, I can not start the guest with this patch.

Re: [libvirt] [RFC PATCHv2 5/5] WIP: smartcard: turn on qemu support

2011-01-18 Thread Eric Blake
On 01/18/2011 02:14 AM, Alon Levy wrote: I think it is pretty easy to add one smartcard mode='' per new backend. The toughest part would be how to query whether a given backend is available in a given qemu binary, but if you can please make sure that 'qemu -device usb-ccid,?' lists all valid

Re: [libvirt] [PATCH 2/3] qemu: improve device flag parsing

2011-01-18 Thread Eric Blake
[replying to myself] On 01/18/2011 08:16 AM, Eric Blake wrote: On 01/17/2011 10:39 PM, Wen Congyang wrote: +cmd = virCommandNewArgList(qemu, + -device, pci-assign,?, + NULL); The qemu that I used does not support '-device

[libvirt] [PATCH] qemu: don't fail capabilities check on 0.12.x

2011-01-18 Thread Eric Blake
Fixes regression introduced in commit 2211518, where all qemu 0.12.x fails to start, as does qemu 0.13.x lacking the pci-assign device. * src/qemu/qemu_capabilities.c (qemuCapsExtractVersionInfo): Check for -device driver,? support. (qemuCapsExtractDeviceStr): Avoid failure if all probed devices

Re: [libvirt] [PATCHv3] handle DNS over IPv6

2011-01-18 Thread Laine Stump
(Sorry for the delay in responding. We're in a bit of a crunch ;-) On 01/12/2011 04:24 PM, Paweł Krześniak wrote: 2011/1/7 Daniel P. Berrangeberra...@redhat.com: Practically no apps will be do this and so they typically can't make use of the link-local address. I agree. v2 of patch attached.

[libvirt] [PATCH 2/3] Increase size of driver table to make UML work again

2011-01-18 Thread Daniel P. Berrange
The driver table only has 10 slots, but there are potentially 11 drivers that need activating. Improve the error message when driver registration fails * src/libvirt.c: Increase driver table size improve errors --- src/libvirt.c | 34 +- 1 files changed, 25

[libvirt] [PATCH 0/3] Misc fixes/cleanups to libvirt API entry points

2011-01-18 Thread Daniel P. Berrange
Just some misc fixes/cleanups i have queued against src/libvirt.c -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/3] Increase size of driver table to make UML work again

2011-01-18 Thread Eric Blake
On 01/18/2011 10:31 AM, Daniel P. Berrange wrote: The driver table only has 10 slots, but there are potentially 11 drivers that need activating. Improve the error message when driver registration fails * src/libvirt.c: Increase driver table size improve errors --- src/libvirt.c | 34

Re: [libvirt] Installing libvirt 0.8.7 Ubuntu 9.10

2011-01-18 Thread Justin Clift
On 18/01/2011, at 10:06 PM, Marcela Castro León wrote: Hello: I'm installing libvirt 0.8.7 on Ubuntu 9.10 to work at a project at Autonomous University. But when make ./configure, I've got: checking pkg-config is at least version 0.9.0... yes checking for XMLRPC... no checking for

Re: [libvirt] [PATCH 1/3] Turn libvirt.c error reporting functions into macros

2011-01-18 Thread Eric Blake
On 01/18/2011 10:31 AM, Daniel P. Berrange wrote: The virLibConnError() function (and related ones) do not correctly report line number info. Turn them all into macros so line numbers are reported correctly. Drop the connection object in all of them since it is no longer used. Also from the

Re: [libvirt] [PATCH 3/3] Remove redundant brackets around return values

2011-01-18 Thread Eric Blake
On 01/18/2011 10:31 AM, Daniel P. Berrange wrote: A large number of return values used 'return (0)' instead of simply 'return 0'. Remove all these redundant brackets so the style is consistent throughout the file * src/libvirt.c: Remove redundant brackets --- src/libvirt.c | 472

[libvirt] [PATCH] docs: updated windows page for new 0.8.7 installer

2011-01-18 Thread Justin Clift
--- docs/windows.html.in | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/docs/windows.html.in b/docs/windows.html.in index 9acf67d..4850a54 100644 --- a/docs/windows.html.in +++ b/docs/windows.html.in @@ -18,7 +18,7 @@ version is

[libvirt] [PATCH] Fix error reporting when machine type probe fails

2011-01-18 Thread Daniel P. Berrange
Avoid overwriting the real error message with a generic OOM failure message, when machine type probe fails * src/qemu/qemu_driver.c: Don't overwrite error --- src/qemu/qemu_driver.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH] Avoid crash in security driver if model is NULL

2011-01-18 Thread Daniel P. Berrange
If the XML security model is NULL, it is assumed that the current model will be used with dynamic labelling. The verify step is meaningless and potentially crashes if dereferencing NULL * src/security/security_manager.c: Skip NULL model on verify --- src/security/security_manager.c |7

Re: [libvirt] cont command failing via JSON monitor on restore

2011-01-18 Thread Jim Fehlig
Laine Stump wrote: On 01/14/2011 04:26 PM, Jim Fehlig wrote: Laine Stump wrote: On 01/13/2011 04:29 PM, Jim Fehlig wrote: Daniel P. Berrange wrote: Yep, it wasn't really intended as a fix. It was intended to make the error scenario clearly detectable, which has succeeded as per Jim's

Re: [libvirt] [PATCH] docs: updated windows page for new 0.8.7 installer

2011-01-18 Thread Eric Blake
On 01/18/2011 11:02 AM, Justin Clift wrote: --- docs/windows.html.in | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc

Re: [libvirt] [PATCH] Avoid crash in security driver if model is NULL

2011-01-18 Thread Eric Blake
On 01/18/2011 11:04 AM, Daniel P. Berrange wrote: If the XML security model is NULL, it is assumed that the current model will be used with dynamic labelling. The verify step is meaningless and potentially crashes if dereferencing NULL * src/security/security_manager.c: Skip NULL model on

Re: [libvirt] Libvirt 0.8.7 installer ready for testing

2011-01-18 Thread Justin Clift
On 11/01/2011, at 1:51 AM, Matthias Bolte wrote: The readme suggests (at least to me) that the TLS certs for libvirt's TLS transport and the ESX driver using HTTPS are the same: TLS certificates are needed prior to connecting to either QEMU instances with TLS, or connecting to VMware

Re: [libvirt] [PATCH] Fix error reporting when machine type probe fails

2011-01-18 Thread Eric Blake
On 01/18/2011 11:04 AM, Daniel P. Berrange wrote: Avoid overwriting the real error message with a generic OOM failure message, when machine type probe fails * src/qemu/qemu_driver.c: Don't overwrite error --- src/qemu/qemu_driver.c |4 +--- 1 files changed, 1 insertions(+), 3

Re: [libvirt] [PATCH] docs: updated windows page for new 0.8.7 installer

2011-01-18 Thread Justin Clift
On 19/01/2011, at 5:16 AM, Eric Blake wrote: On 01/18/2011 11:02 AM, Justin Clift wrote: --- docs/windows.html.in | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) ACK. Thanks Eric, pushed. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] Fix startup with VNC password expiry on old QEMU

2011-01-18 Thread Daniel P. Berrange
The code which set VNC passwords correctly had fallback for the set_password command, but was lacking it for the expire_password command. This made it impossible to start a guest. It also failed to check whether QEMU was still running after the initial 'set_password' command completed *

[libvirt] Libvirt Windows 0.8.7 installer available

2011-01-18 Thread Justin Clift
Hi all, The Libvirt 0.8.7 installer for Windows is now available online: http://libvirt.org/sources/win32_experimental/Libvirt-0.8.7-2.exe Changes for this release include: + VirtualBox support on Windows, as added to the main Libvirt 0.8.7 release. I haven't personally tested this

[libvirt] [PATCH] docs: document sysinfo and symbios elements

2011-01-18 Thread Eric Blake
* docs/formatdomain.html.in: Talk about sysinfo throughout. --- More in the vein of adding missing documentation. docs/formatdomain.html.in | 79 - 1 files changed, 78 insertions(+), 1 deletions(-) diff --git a/docs/formatdomain.html.in

Re: [libvirt] [PATCH] Fix startup with VNC password expiry on old QEMU

2011-01-18 Thread Eric Blake
On 01/18/2011 11:39 AM, Daniel P. Berrange wrote: The code which set VNC passwords correctly had fallback for the set_password command, but was lacking it for the expire_password command. This made it impossible to start a guest. It also failed to check whether QEMU was still running after

Re: [libvirt] [PATCH] qemu: don't fail capabilities check on 0.12.x

2011-01-18 Thread Matthias Bolte
2011/1/18 Eric Blake ebl...@redhat.com: Fixes regression introduced in commit 2211518, where all qemu 0.12.x fails to start, as does qemu 0.13.x lacking the pci-assign device. * src/qemu/qemu_capabilities.c (qemuCapsExtractVersionInfo): Check for -device driver,? support.

Re: [libvirt] [PATCH] build: use more gnulib modules for simpler code

2011-01-18 Thread Matthias Bolte
2011/1/17 Eric Blake ebl...@redhat.com: * .gnulib: Update to latest, for sigpipe and sigaction modules. * bootstrap.conf (gnulib_modules): Add siaction, sigpipe, strerror_r. * tools/virsh.c (vshSetupSignals) [!SIGPIPE]: Delete, now that gnulib guarantees it. (SA_SIGINFO): Define for mingw

[libvirt] [PATCH] docs: add new conversion heading to the apps listing

2011-01-18 Thread Justin Clift
--- docs/apps.html.in | 43 +++ 1 files changed, 39 insertions(+), 4 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index 9a8ffc0..153584c 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -93,6 +93,40 @@ /dd /dl +

Re: [libvirt] [PATCH] docs: add new conversion heading to the apps listing

2011-01-18 Thread Eric Blake
On 01/18/2011 02:24 PM, Justin Clift wrote: --- docs/apps.html.in | 43 +++ 1 files changed, 39 insertions(+), 4 deletions(-) ACK -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc

Re: [libvirt] [PATCH] docs: add new conversion heading to the apps listing

2011-01-18 Thread Justin Clift
On 19/01/2011, at 8:32 AM, Eric Blake wrote: On 01/18/2011 02:24 PM, Justin Clift wrote: --- docs/apps.html.in | 43 +++ 1 files changed, 39 insertions(+), 4 deletions(-) ACK Thanks Eric, pushed. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] docs: add buildbot to the apps page

2011-01-18 Thread Justin Clift
--- Should have probably included this in the previous commit, but didn't notice this BuildBot project until closing other browser windows. :/ docs/apps.html.in | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index

Re: [libvirt] [PATCH] qemu: don't fail capabilities check on 0.12.x

2011-01-18 Thread Eric Blake
On 01/18/2011 02:00 PM, Matthias Bolte wrote: 2011/1/18 Eric Blake ebl...@redhat.com: Fixes regression introduced in commit 2211518, where all qemu 0.12.x fails to start, as does qemu 0.13.x lacking the pci-assign device. * src/qemu/qemu_capabilities.c (qemuCapsExtractVersionInfo): Check for

Re: [libvirt] [PATCH] docs: add buildbot to the apps page

2011-01-18 Thread Justin Clift
On 19/01/2011, at 9:00 AM, Eric Blake wrote: On 01/18/2011 02:49 PM, Justin Clift wrote: --- Should have probably included this in the previous commit, but didn't notice this BuildBot project until closing other browser windows. :/ docs/apps.html.in | 12 1 files changed, 12

Re: [libvirt] [PATCH] docs: document controller element

2011-01-18 Thread Matthias Bolte
2011/1/17 Eric Blake ebl...@redhat.com: * docs/formatdomain.html.in: Talk about controller and address throughout. --- Adding a new controller type='ccid' index='0'/ and use of smartcardaddress//smartcard for use by smartcard will be a lot easier if I can compare the changes to existing

Re: [libvirt] [PATCH] docs: document sysinfo and symbios elements

2011-01-18 Thread Matthias Bolte
2011/1/18 Eric Blake ebl...@redhat.com: * docs/formatdomain.html.in: Talk about sysinfo throughout. --- More in the vein of adding missing documentation. Typos in the subject: s/symbios/smbios/ ACK. Matthias -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] docs: document controller element

2011-01-18 Thread Eric Blake
On 01/18/2011 03:06 PM, Matthias Bolte wrote: + dtcodeaddress/code/dt + ddIf present, the codeaddress/code element ties the disk + to a given slot of a controller (the + actual codelt;controllergt;/code device can often be + inferred by libvirt, although it can +

Re: [libvirt] Installing libvirt 0.8.7 Ubuntu 9.10

2011-01-18 Thread Laurent Léonard
Le mardi 18 janvier 2011 12:06:00, Marcela Castro León a écrit : Hello: I'm installing libvirt 0.8.7 on Ubuntu 9.10 to work at a project at Autonomous University. But when make ./configure, I've got: checking pkg-config is at least version 0.9.0... yes checking for XMLRPC... no checking

Re: [libvirt] [PATCH] Remove two unused PATH_MAX-sized char arrays from the stack

2011-01-18 Thread Matthias Bolte
2011/1/17 Daniel P. Berrange berra...@redhat.com: On Sun, Jan 16, 2011 at 12:05:32AM +0100, Matthias Bolte wrote: ---  src/storage/storage_driver.c |   16 ++--  src/uml/uml_driver.c         |    8 ++--  2 files changed, 4 insertions(+), 20 deletions(-) diff --git

Re: [libvirt] [PATCH] docs: document controller element

2011-01-18 Thread Matthias Bolte
2011/1/18 Eric Blake ebl...@redhat.com: On 01/18/2011 03:06 PM, Matthias Bolte wrote: +      virtio-serial controller has two additional optional +      attributes codeports/code and codevectors/code, which +      control how many devices can be connected through the +      controller.  Some

Re: [libvirt] [PATCH] build: use more gnulib modules for simpler code

2011-01-18 Thread Eric Blake
On 01/18/2011 02:06 PM, Matthias Bolte wrote: 2011/1/17 Eric Blake ebl...@redhat.com: * .gnulib: Update to latest, for sigpipe and sigaction modules. * bootstrap.conf (gnulib_modules): Add siaction, sigpipe, strerror_r. * tools/virsh.c (vshSetupSignals) [!SIGPIPE]: Delete, now that gnulib

Re: [libvirt] [PATCH] docs: document sysinfo and symbios elements

2011-01-18 Thread Eric Blake
On 01/18/2011 03:10 PM, Matthias Bolte wrote: 2011/1/18 Eric Blake ebl...@redhat.com: * docs/formatdomain.html.in: Talk about sysinfo throughout. --- More in the vein of adding missing documentation. Typos in the subject: s/symbios/smbios/ Yep, I noticed that shortly after hitting send.

[libvirt] [PATCHv2] docs: document controller element

2011-01-18 Thread Eric Blake
* docs/formatdomain.html.in: Talk about controller and address throughout. --- v2: wording improvements suggested by Matthias Bolte docs/formatdomain.html.in | 104 - 1 files changed, 102 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH] docs: correct setmem text plus expand setmaxmem text

2011-01-18 Thread Justin Clift
This completes the man page updates required for BZ # 622534: https://bugzilla.redhat.com/show_bug.cgi?id=622534 --- tools/virsh.pod | 15 +++ 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 1f15fef..c0cda79 100644 ---

Re: [libvirt] [PATCH 2/3] qemu: improve device flag parsing

2011-01-18 Thread Wen Congyang
At 01/18/2011 11:16 PM, Eric Blake Write: On 01/17/2011 10:39 PM, Wen Congyang wrote: +cmd = virCommandNewArgList(qemu, + -device, pci-assign,?, + NULL); The qemu that I used does not support '-device pci-assign,?'... So, I can

Re: [libvirt] [PATCH] qemu: don't fail capabilities check on 0.12.x

2011-01-18 Thread Wen Congyang
At 01/19/2011 12:51 AM, Eric Blake Write: Fixes regression introduced in commit 2211518, where all qemu 0.12.x fails to start, as does qemu 0.13.x lacking the pci-assign device. * src/qemu/qemu_capabilities.c (qemuCapsExtractVersionInfo): Check for -device driver,? support.

Re: [libvirt] [PATCH 2/3] qemu: improve device flag parsing

2011-01-18 Thread Eric Blake
On 01/18/2011 06:22 PM, Wen Congyang wrote: At 01/18/2011 11:16 PM, Eric Blake Write: On 01/17/2011 10:39 PM, Wen Congyang wrote: +cmd = virCommandNewArgList(qemu, + -device, pci-assign,?, + NULL); The qemu that I used does not

Re: [libvirt] [PATCH 2/3] qemu: improve device flag parsing

2011-01-18 Thread Wen Congyang
At 01/19/2011 09:54 AM, Eric Blake Write: On 01/18/2011 06:22 PM, Wen Congyang wrote: At 01/18/2011 11:16 PM, Eric Blake Write: On 01/17/2011 10:39 PM, Wen Congyang wrote: +cmd = virCommandNewArgList(qemu, + -device, pci-assign,?, +

Re: [libvirt] Installing libvirt 0.8.7 Ubuntu 9.10

2011-01-18 Thread Marcela Castro León
Thank you, I've solved. 2011/1/18 Justin Clift jcl...@redhat.com On 18/01/2011, at 10:06 PM, Marcela Castro León wrote: Hello: I'm installing libvirt 0.8.7 on Ubuntu 9.10 to work at a project at Autonomous University. But when make ./configure, I've got: checking pkg-config is at