[libvirt] [PATCH] qemu: Fix a possible deadlock in p2p migration

2011-01-21 Thread Wen Congyang
The function virUnrefConnect() may call virReleaseConnect() to release the dest connection, and the function virReleaseConnect() will call conn-driver-close(). So the function virUnrefConnect() should be surrounded by qemuDomainObjEnterRemoteWithDriver() and qemuDomainObjExitRemoteWithDriver() to

Re: [libvirt] [PATCH] maint: support --no-git option during autogen.sh

2011-01-21 Thread Daniel Veillard
On Thu, Jan 20, 2011 at 01:45:36PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=562743 * .gnulib: Update to latest, for improved bootstrap. * bootstrap: Resync from gnulib. * autogen.sh (bootstrap): Add --bootstrap-sync, to make it easier to keep bootstrap

Re: [libvirt] [RFC] libxenlight driver

2011-01-21 Thread Daniel Veillard
On Thu, Jan 20, 2011 at 04:49:25PM -0700, Jim Fehlig wrote: I'm looking into creating a driver for the new Xen xl/libxl toolstack (aka libxenlight [1]), set to become the default in upcoming Xen 4.1.0 release. My first hurdle is deciding whether this should be a new driver or integrated

[libvirt] [PATCH] vmx: Use VIR_ERR_CONFIG_UNSUPPORTED when appropriated

2011-01-21 Thread Matthias Bolte
Inspired by Osier Yang's similar patch for the QEMU driver. Matthias From eef05848898e4e32a898588760247dac1049bfe0 Mon Sep 17 00:00:00 2001 From: Matthias Bolte matthias.bo...@googlemail.com Date: Fri, 21 Jan 2011 09:15:43 +0100 Subject: [PATCH] vmx: Use VIR_ERR_CONFIG_UNSUPPORTED when

Re: [libvirt] [PATCH] qemu: report more proper error for unsupported graphics

2011-01-21 Thread Matthias Bolte
2011/1/21 Osier Yang jy...@redhat.com: Report VIR_ERR_CONFIG_UNSUPPORTED instead of VIR_ERR_INTERNAL_ERROR, as it's valid in our domain schema, just unsupported by hypervisor here. * src/qemu/qemu_command.c ACK. Matthias -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [RFD] Add/Modify some API functions about Host Information

2011-01-21 Thread Daniel P. Berrange
On Thu, Jan 20, 2011 at 08:20:20AM -0700, Eric Blake wrote: On 01/20/2011 05:13 AM, Daniel P. Berrange wrote: * virSysinfoRead() This API is completely internal. But DMI type1 information(dmidecode -t1) is useful for above purpose, because it's one of the information which

Re: [libvirt] [RFC] libxenlight driver

2011-01-21 Thread Daniel P. Berrange
On Thu, Jan 20, 2011 at 04:49:25PM -0700, Jim Fehlig wrote: I'm looking into creating a driver for the new Xen xl/libxl toolstack (aka libxenlight [1]), set to become the default in upcoming Xen 4.1.0 release. My first hurdle is deciding whether this should be a new driver or integrated

Re: [libvirt] [PATCH] event: fix two event-handling bugs

2011-01-21 Thread Daniel P. Berrange
On Thu, Jan 20, 2011 at 05:01:13PM -0700, Eric Blake wrote: Regression introduced in commit e6b68d7. Prior to that point, handlesAlloc was always a multiple of EVENT_ALLOC_EXTENT, and was an integer (so even if the subtraction wrapped, a negative value was less than the count and did not

Re: [libvirt] [PATCH] qemu: Fix a possible deadlock in p2p migration

2011-01-21 Thread Daniel P. Berrange
On Fri, Jan 21, 2011 at 04:28:07PM +0800, Wen Congyang wrote: The function virUnrefConnect() may call virReleaseConnect() to release the dest connection, and the function virReleaseConnect() will call conn-driver-close(). So the function virUnrefConnect() should be surrounded by

Re: [libvirt] [PATCH] vmx: Use VIR_ERR_CONFIG_UNSUPPORTED when appropriated

2011-01-21 Thread Daniel P. Berrange
On Fri, Jan 21, 2011 at 09:55:17AM +0100, Matthias Bolte wrote: Inspired by Osier Yang's similar patch for the QEMU driver. Matthias From eef05848898e4e32a898588760247dac1049bfe0 Mon Sep 17 00:00:00 2001 From: Matthias Bolte matthias.bo...@googlemail.com Date: Fri, 21 Jan 2011 09:15:43

Re: [libvirt] [PATCH] qemu: Fix a possible deadlock in p2p migration

2011-01-21 Thread Eric Blake
On 01/21/2011 04:21 AM, Daniel P. Berrange wrote: On Fri, Jan 21, 2011 at 04:28:07PM +0800, Wen Congyang wrote: The function virUnrefConnect() may call virReleaseConnect() to release the dest connection, and the function virReleaseConnect() will call conn-driver-close(). So the function

Re: [libvirt] [RFC] libxenlight driver

2011-01-21 Thread Jim Fehlig
Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 04:49:25PM -0700, Jim Fehlig wrote: I'm looking into creating a driver for the new Xen xl/libxl toolstack (aka libxenlight [1]), set to become the default in upcoming Xen 4.1.0 release. My first hurdle is deciding whether this should be a

Re: [libvirt] [PATCH] qemu: report more proper error for unsupported graphics

2011-01-21 Thread Eric Blake
On 01/21/2011 01:56 AM, Matthias Bolte wrote: 2011/1/21 Osier Yang jy...@redhat.com: Report VIR_ERR_CONFIG_UNSUPPORTED instead of VIR_ERR_INTERNAL_ERROR, as it's valid in our domain schema, just unsupported by hypervisor here. * src/qemu/qemu_command.c ACK. Pushed. -- Eric Blake

Re: [libvirt] [Xen-devel] Re: [RFC] libxenlight driver

2011-01-21 Thread Gianni Tedesco
On Fri, 2011-01-21 at 15:48 +, Jim Fehlig wrote: Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 04:49:25PM -0700, Jim Fehlig wrote: I'm looking into creating a driver for the new Xen xl/libxl toolstack (aka libxenlight [1]), set to become the default in upcoming Xen 4.1.0

Re: [libvirt] [PATCH] [v2] qemu: Retry JSON monitor cont cmd on MigrationExpected error

2011-01-21 Thread Jim Fehlig
Daniel Veillard wrote: On Thu, Jan 20, 2011 at 07:27:14PM -0700, Jim Fehlig wrote: When restoring a saved qemu instance via JSON monitor, the vm is left in a paused state. Turns out the 'cont' cmd was failing with MigrationExpected error class and An incoming migration is expected before

Re: [libvirt] [Xen-devel] Re: [RFC] libxenlight driver

2011-01-21 Thread Daniel P. Berrange
On Fri, Jan 21, 2011 at 04:33:55PM +, Gianni Tedesco wrote: On Fri, 2011-01-21 at 15:48 +, Jim Fehlig wrote: Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 04:49:25PM -0700, Jim Fehlig wrote: I'm looking into creating a driver for the new Xen xl/libxl toolstack (aka

Re: [libvirt] [PATCH] maint: support --no-git option during autogen.sh

2011-01-21 Thread Eric Blake
On 01/21/2011 01:34 AM, Daniel Veillard wrote: On Thu, Jan 20, 2011 at 01:45:36PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=562743 * .gnulib: Update to latest, for improved bootstrap. * bootstrap: Resync from gnulib. * autogen.sh (bootstrap): Add --bootstrap-sync,

Re: [libvirt] [Xen-devel] Re: [RFC] libxenlight driver

2011-01-21 Thread Stefano Stabellini
On Fri, 21 Jan 2011, Jim Fehlig wrote: Daniel P. Berrange wrote: On Thu, Jan 20, 2011 at 04:49:25PM -0700, Jim Fehlig wrote: I'm looking into creating a driver for the new Xen xl/libxl toolstack (aka libxenlight [1]), set to become the default in upcoming Xen 4.1.0 release. My

Re: [libvirt] [Xen-devel] Re: [RFC] libxenlight driver

2011-01-21 Thread Ian Campbell
On Fri, 2011-01-21 at 16:44 +, Daniel P. Berrange wrote: On a related note, where does XenAPI fit into this picture ? Previously XenD would provide (at least some of) the XenAPI functionality in the open source stack, while I understand that the XenEnterprise had a separate impl of

Re: [libvirt] [Xen-devel] Re: [RFC] libxenlight driver

2011-01-21 Thread Stefano Stabellini
On Fri, 21 Jan 2011, Daniel P. Berrange wrote: Ok, so basically the mgmt app that is using the libxenlight API is taking the place of XenD. Thus in the new scheme libvirtd would have to handle those kind of events. Right. Libxenlight provides all the functions needed to do that and you can

Re: [libvirt] [Xen-devel] Re: [RFC] libxenlight driver

2011-01-21 Thread Jim Fehlig
Ian Campbell wrote: On Fri, 2011-01-21 at 16:44 +, Daniel P. Berrange wrote: On a related note, where does XenAPI fit into this picture ? Previously XenD would provide (at least some of) the XenAPI functionality in the open source stack, while I understand that the XenEnterprise had

Re: [libvirt] [PATCH] event: fix two event-handling bugs

2011-01-21 Thread Eric Blake
On 01/21/2011 04:15 AM, Daniel P. Berrange wrote: Prior to that point, handlesAlloc was always a multiple of EVENT_ALLOC_EXTENT, and was an integer (so even if the subtraction wrapped, a negative value was less than the count and did not try to free the handles array). But after that point,

Re: [libvirt] [Xen-devel] Re: [RFC] libxenlight driver

2011-01-21 Thread Gianni Tedesco
On Fri, 2011-01-21 at 17:01 +, Stefano Stabellini wrote: On Fri, 21 Jan 2011, Daniel P. Berrange wrote: Ok, so basically the mgmt app that is using the libxenlight API is taking the place of XenD. Thus in the new scheme libvirtd would have to handle those kind of events. Right.

Re: [libvirt] [Xen-devel] Re: [RFC] libxenlight driver

2011-01-21 Thread Ian Campbell
On Fri, 2011-01-21 at 17:02 +, Jim Fehlig wrote: Ian Campbell wrote: On Fri, 2011-01-21 at 16:44 +, Daniel P. Berrange wrote: On a related note, where does XenAPI fit into this picture ? Previously XenD would provide (at least some of) the XenAPI functionality in the open

[libvirt] [PATCH 2/3] Revert all previous error log priority hacks

2011-01-21 Thread Daniel P. Berrange
This reverts the additions in commit abff683f78ffd01df5005fb7a457c0b38b8eb6e1 taking us back to state where all errors are fully logged in both libvirtd and normal clients. THe intent was to stop VIR_ERR_NO_DOMAIN (No such domain with UUID ) messages from client apps polluting syslog The

[libvirt] [PATCH 0/3] Yet another attempt at cleaning libvirtd error logging

2011-01-21 Thread Daniel P. Berrange
THe previous changes commit 04bd0360f32ec628ecf7943b3fd1468d6eb2dde5 Author: Daniel P. Berrange berra...@redhat.com Date: Thu Nov 18 13:14:08 2010 + Log all errors at level INFO to stop polluting syslog commit abff683f78ffd01df5005fb7a457c0b38b8eb6e1 Author: Matthias Bolte

[libvirt] [PATCH 1/3] Cleanup code style in logging APIs

2011-01-21 Thread Daniel P. Berrange
Remove use of brackets around following return statement. Fix indentation of two switch statements --- src/util/logging.c | 102 ++-- 1 files changed, 51 insertions(+), 51 deletions(-) diff --git a/src/util/logging.c b/src/util/logging.c index

[libvirt] [PATCH 3/3] Filter out certain expected error messages from libvirtd

2011-01-21 Thread Daniel P. Berrange
Add a hook to the error reporting APIs to allow specific error messages to be filtered out. Wire up libvirtd to remove VIR_ERR_NO_DOMAIN similar error codes from the logs. THey are still logged at DEBUG level. * daemon/libvirtd.c: Filter VIR_ERR_NO_DOMAIN and friends * src/libvirt_private.syms,

[libvirt] [PATCH] Fix setup of lib directory with autogen.sh --system

2011-01-21 Thread Daniel P. Berrange
On x86_64 hosts, /usr/lib64 must be used instead of /usr/lib Rather than attempt to whitelist architectures, just check for existance of /usr/lib64 * autogen.sh: Fix to use /usr/lib64 if it exists --- autogen.sh |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git

[libvirt] [PATCH] Add check for poll error events in monitor

2011-01-21 Thread Daniel P. Berrange
Handle poll errors in the same way as hangup event * src/qemu/qemu_monitor.c: Handle error events --- src/qemu/qemu_monitor.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 3026733..0c14277 100644 ---

Re: [libvirt] [Xen-devel] Re: [RFC] libxenlight driver

2011-01-21 Thread Ian Jackson
Jim Fehlig writes (Re: [Xen-devel] Re: [libvirt] [RFC] libxenlight driver): Ian Campbell wrote: The xapi toolstack which implements XenAPI is now open source as well and is used in XCP (as well as XenServer). But there is no intent on putting this toolstack in the traditional Xen releases

Re: [libvirt] [PATCH] Fix setup of lib directory with autogen.sh --system

2011-01-21 Thread Eric Blake
On 01/21/2011 10:40 AM, Daniel P. Berrange wrote: On x86_64 hosts, /usr/lib64 must be used instead of /usr/lib Rather than attempt to whitelist architectures, just check for existance of /usr/lib64 * autogen.sh: Fix to use /usr/lib64 if it exists --- autogen.sh |9 - 1 files

Re: [libvirt] [PATCH] Add check for poll error events in monitor

2011-01-21 Thread Eric Blake
On 01/21/2011 10:40 AM, Daniel P. Berrange wrote: Handle poll errors in the same way as hangup event * src/qemu/qemu_monitor.c: Handle error events --- src/qemu/qemu_monitor.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_monitor.c

Re: [libvirt] [PATCH 1/3] Cleanup code style in logging APIs

2011-01-21 Thread Eric Blake
On 01/21/2011 10:30 AM, Daniel P. Berrange wrote: Remove use of brackets around following return statement. Fix indentation of two switch statements ACK - just cosmetic. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc

Re: [libvirt] [PATCH 2/3] Revert all previous error log priority hacks

2011-01-21 Thread Eric Blake
On 01/21/2011 10:30 AM, Daniel P. Berrange wrote: This reverts the additions in commit abff683f78ffd01df5005fb7a457c0b38b8eb6e1 taking us back to state where all errors are fully logged in both libvirtd and normal clients. THe intent was to stop VIR_ERR_NO_DOMAIN (No such domain with

Re: [libvirt] [PATCH 3/3] Filter out certain expected error messages from libvirtd

2011-01-21 Thread Eric Blake
On 01/21/2011 10:30 AM, Daniel P. Berrange wrote: Add a hook to the error reporting APIs to allow specific error messages to be filtered out. Wire up libvirtd to remove VIR_ERR_NO_DOMAIN similar error codes from the logs. THey are still logged at DEBUG level. s/THey/They/ *

[libvirt] [PATCHv2] event: fix two event-handling bugs

2011-01-21 Thread Eric Blake
The first bug has been present since before the time that commit f8a519 (Dec 2008) tried to make the dispatch loop re-entrant. Dereferencing eventLoop.handles outside the lock risks crashing, since any other thread could have reallocated the array in the meantime. It's a narrow race window,

Re: [libvirt] [PATCHv2] event: fix two event-handling bugs

2011-01-21 Thread Eric Blake
On 01/21/2011 01:06 PM, Eric Blake wrote: The first bug has been present since before the time that commit f8a519 (Dec 2008) tried to make the dispatch loop re-entrant. The second is a regression introduced in commit e6b68d7 (Nov 2010). I'm splitting this into two commits (to make it easier

Re: [libvirt] [PATCH 3/3] qemu: Add conf option to auto setup VNC unix sockets

2011-01-21 Thread Cole Robinson
On 01/14/2011 09:26 AM, Cole Robinson wrote: On 01/13/2011 08:21 AM, Daniel P. Berrange wrote: On Wed, Jan 12, 2011 at 12:32:44PM -0500, Cole Robinson wrote: If vnc_auto_unix_socket is enabled, any VNC devices without a hardcoded listen or socket value will be setup to serve over a unix socket

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-21 Thread Cole Robinson
On 01/14/2011 11:20 AM, Eric Blake wrote: On 01/13/2011 02:45 PM, Cole Robinson wrote: @@ -3751,6 +3753,12 @@ qemuBuildCommandLine(virConnectPtr conn, goto error; virCommandAddArg(cmd, str); + +if (sound-model ==

Re: [libvirt] [PATCH v2] qemu: sound: Support intel 'ich6' model

2011-01-21 Thread Cole Robinson
On 01/14/2011 02:05 PM, Daniel P. Berrange wrote: On Thu, Jan 13, 2011 at 10:45:41AM -0500, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires a codec (either -device hda-output or -device hda-duplex) to actually output sound. We set up an hda-duplex codec by

[libvirt] [PATCH v3] qemu: sound: Support intel 'ich6' model

2011-01-21 Thread Cole Robinson
In QEMU, the card itself is a PCI device, but it requires a codec (either -device hda-output or -device hda-duplex) to actually output sound. Specifying sound model='ich6'/ gives us -device intel-hda -device hda-duplex I think it's important that a simple sound model='ich6'/ sets up a useful

[libvirt] [PATCH] build: fix 'make check' with older git

2011-01-21 Thread Eric Blake
* .gnulib: Update to latest, for maintainer-makefile fix. Reported by Matthias Bolte. --- Pushing under the build-breaker rule, as I confirmed the breakage when trying 'make check' on Ubuntu 10.10. * .gnulib 54c0573...2f41af6 (1): maintainer-makefile: work with older git for submodule check

Re: [libvirt] [PATCHv2] event: fix two event-handling bugs

2011-01-21 Thread Eric Blake
On 01/21/2011 02:07 PM, Eric Blake wrote: On 01/21/2011 01:06 PM, Eric Blake wrote: The first bug has been present since before the time that commit f8a519 (Dec 2008) tried to make the dispatch loop re-entrant. The second is a regression introduced in commit e6b68d7 (Nov 2010). I'm

Re: [libvirt] [PATCH v3] qemu: sound: Support intel 'ich6' model

2011-01-21 Thread Eric Blake
On 01/21/2011 03:53 PM, Cole Robinson wrote: In QEMU, the card itself is a PCI device, but it requires a codec (either -device hda-output or -device hda-duplex) to actually output sound. Specifying sound model='ich6'/ gives us -device intel-hda -device hda-duplex I think it's important that a

Re: [libvirt] [PATCH] build: fix 'make check' with older git

2011-01-21 Thread Matthias Bolte
2011/1/21 Eric Blake ebl...@redhat.com: * .gnulib: Update to latest, for maintainer-makefile fix. Reported by Matthias Bolte. --- Pushing under the build-breaker rule, as I confirmed the breakage when trying 'make check' on Ubuntu 10.10. * .gnulib 54c0573...2f41af6 (1):  

Re: [libvirt] [PATCH] vmx: Use VIR_ERR_CONFIG_UNSUPPORTED when appropriated

2011-01-21 Thread Matthias Bolte
2011/1/21 Daniel P. Berrange berra...@redhat.com: On Fri, Jan 21, 2011 at 09:55:17AM +0100, Matthias Bolte wrote: Inspired by Osier Yang's similar patch for the QEMU driver. Matthias From eef05848898e4e32a898588760247dac1049bfe0 Mon Sep 17 00:00:00 2001 From: Matthias Bolte