Re: [libvirt] [PATCHv5 7/9] RFC: spicevmc: call out vdagent as a channel target

2011-02-04 Thread Daniel P. Berrange
On Thu, Feb 03, 2011 at 09:16:09PM -0700, Eric Blake wrote: Not sure this makes sense to do; posting it for comments, but I'm okay with ditching the idea (especially since existing RHEL 6.0 guests have already been using XML that targets virtio, which means changing to vdagent would cause the

Re: [libvirt] [PATCHv5 1/9] smartcard: add XML support for smartcard device

2011-02-04 Thread Jiri Denemark
Assuming a hypervisor that supports multiple smartcard devices in the guest, this would be a valid XML description: devices smartcard mode='host'/ smartcard mode='host-certificates' certificate/path/to/cert1/certificate certificate/path/to/cert2/certificate

Re: [libvirt] [PATCHv5 2/9] smartcard: add domain conf support

2011-02-04 Thread Jiri Denemark
On Thu, Feb 03, 2011 at 21:01:13 -0700, Eric Blake wrote: * src/conf/domain_conf.h (virDomainSmartcardType): New enum. (virDomainSmartcardDef, virDomainDeviceCcidAddress): New structs. (virDomainDef): Include smartcards. (virDomainSmartcardDefIterator): New typedef.

Re: [libvirt] [PATCHv5 3/9] smartcard: check for qemu capability

2011-02-04 Thread Jiri Denemark
On Thu, Feb 03, 2011 at 21:01:14 -0700, Eric Blake wrote: Qemu smartcard/spicevmc support exists on branches (such as http://cgit.freedesktop.org/~alon/qemu/commit/?h=usb_ccid.v15id=024a37b) but is not yet upstream. The added -help output matches a scratch build that will be close to the RHEL

Re: [libvirt] [PATCHv5 4/9] smartcard: enable SELinux support

2011-02-04 Thread Jiri Denemark
On Thu, Feb 03, 2011 at 21:01:15 -0700, Eric Blake wrote: * src/security/security_selinux.c (SELinuxRestoreSecuritySmartcardCallback) (SELinuxSetSecuritySmartcardCallback): New helper functions. (SELinuxRestoreSecurityAllLabel, SELinuxSetSecurityAllLabel): Use them. --- Notes: v3:

Re: [libvirt] [PATCHv5 5/9] smartcard: turn on qemu support

2011-02-04 Thread Jiri Denemark
On Thu, Feb 03, 2011 at 21:01:16 -0700, Eric Blake wrote: * src/qemu/qemu_command.c (qemuBuildCommandLine): Emit smartcard options. (qemuAssignDeviceAliases): Assign an alias for smartcards. (qemuBuildControllerDevStr): Manage the usb-ccid controller. * tests/qemuxml2argvtest.c (mymain): Add

Re: [libvirt] [PATCHv5 6/9] spicevmc: support new qemu chardev

2011-02-04 Thread Jiri Denemark
On Thu, Feb 03, 2011 at 21:16:08 -0700, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com Inspired by https://bugzilla.redhat.com/show_bug.cgi?id=615757 Add a new character device backend for virtio serial channels that activates the QEMU spice agent on the main channel using

[libvirt] [PATCHv5 10/9] spicevmc: support older -device spicevmc of qemu 0.13.0

2011-02-04 Thread Eric Blake
qemu 0.13.0 (at least as built for Fedora 14, and also backported to RHEL 6.0 qemu) supported an older syntax for a spicevmc channel; it's not as flexible (it has an implicit name and hides the chardev aspect), but now that we support spicevmc, we might as well target both variants. *

Re: [libvirt] [PATCHv5 9/9] smartcard: add spicevmc support

2011-02-04 Thread Jiri Denemark
On Thu, Feb 03, 2011 at 21:16:11 -0700, Eric Blake wrote: Adds smartcard mode='passthrough' type='spicevmc'/, which uses the new channel name='smartcard'/ of graphics type='spice'. ... diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index d91fdb9..43c78fc 100644 ---

Re: [libvirt] [PATCHv5 10/9] spicevmc: support older -device spicevmc of qemu 0.13.0

2011-02-04 Thread Jiri Denemark
On Fri, Feb 04, 2011 at 09:16:25 -0700, Eric Blake wrote: qemu 0.13.0 (at least as built for Fedora 14, and also backported to RHEL 6.0 qemu) supported an older syntax for a spicevmc channel; it's not as flexible (it has an implicit name and hides the chardev aspect), but now that we support

Re: [libvirt] [PATCHv5 9/9] smartcard: add spicevmc support

2011-02-04 Thread Eric Blake
On 02/04/2011 09:25 AM, Jiri Denemark wrote: On Thu, Feb 03, 2011 at 21:16:11 -0700, Eric Blake wrote: Adds smartcard mode='passthrough' type='spicevmc'/, which uses the new channel name='smartcard'/ of graphics type='spice'. ... diff --git a/docs/formatdomain.html.in

Re: [libvirt] [PATCHv5 9/9] smartcard: add spicevmc support

2011-02-04 Thread Eric Blake
On 02/04/2011 09:38 AM, Eric Blake wrote: + and span class=sincesince 0.8.8/span: codesmartcard/code. /p pre ^^ tabs before spaces, but that's in a context, not your fault. It could be worth fixing while touching the lines above. But it's not a big deal.

[libvirt] [PATCH] maint: whitespace cleanup

2011-02-04 Thread Eric Blake
* cfg.mk (sc_TAB_in_indentation): Check more files. * .dir-locals.el (html-mode): Let emacs help out. * docs/internals/command.html.in: Fix offenders. * docs/formatdomain.html.in: Likewise. * docs/internals.html.in: Likewise. Reported by Jiri Denemark. --- Here's the git diff -b output; actual

[libvirt] [PATCH 0/2] Add tx_alg attribute to interface XML for virtio backend

2011-02-04 Thread Laine Stump
These two patches provide the ability to configure which of two algorithms is used on the TX side of the virtio-net-pci device. Details are in the comments for PATCH 2/2. There are also at least a couple of open questions about the patch, which are posed in the comments of 2/2. It's highly

[libvirt] [PATCH 1/2] Restructure domain struct interface driver data for easier expansion

2011-02-04 Thread Laine Stump
When the driver element (and its name attribute) was added to the domain XML's interface element, a backend enum was simply added to the toplevel of the virDomainNetDef struct. Ignoring the naming inconsistency (name vs. backend), this is fine when there's only a single item contained in the

[libvirt] [PATCH 2/2] Add tx_alg attribute to interface XML for virtio backend

2011-02-04 Thread Laine Stump
qemu's virtio-net-pci driver allows setting the algorithm used for tx packets to either bh or timer. I don't know exactly how these algorithms differ, but someone has requested the ability to choose between them in libvirt's domain XML. See: https://bugzilla.redhat.com/show_bug.cgi?id=629662