Re: [libvirt] [PATCH libvirt-site v2] Add information about libvirt-php new location [was Change PHP binding link to new one hosted on libvirt.org]

2011-02-10 Thread Michal Novotny
On 02/09/2011 08:30 PM, Eric Blake wrote: On 02/09/2011 11:44 AM, Michal Novotny wrote: Signed-off-by: Michal Novotnyminov...@redhat.com That created a rather long commit subject for 'git am', so I pruned it. p The project is now maintained by Michal Novotny and it's

[libvirt] [libvirt-snmp][PATCH v2] Remove the hard coded connection URI.

2011-02-10 Thread Michal Privoznik
So now we rely on libvirt LIBVIRT_DEFAULT_URI environment variable. --- src/libvirtSnmp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/libvirtSnmp.c b/src/libvirtSnmp.c index ce21369..39b74bd 100644 --- a/src/libvirtSnmp.c +++ b/src/libvirtSnmp.c @@ -180,7 +180,8

[libvirt] [PATCH] Fix spice's passwdValidTo setting

2011-02-10 Thread Michal Privoznik
This fix the typo in the source. https://bugzilla.redhat.com/show_bug.cgi?id=676374 --- src/conf/domain_conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7c1fb47..59adf36 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCHv3 2/2] Add txmode attribute to interface XML for virtio backend

2011-02-10 Thread Laine Stump
== V3 changes: 0) The actual code remains untouched from V2. 1) Add txmode attribute to the domain schema, and to an xml2xml and xml2argv test (note that the particular file used for the xml2xml test was previously only being used for xml2argv, and it needed

[libvirt] [PATCHv2 2/2] Give each virtual network bridge its own fixed MAC address

2011-02-10 Thread Laine Stump
Changes in V2: 1) auto-generate mac addresses in networkDefine and networkCreate instead of networkStartNetworkDaemon, and add the %post script to fixup existing networks. 2) instead of mac being an attribute of the bridge element, make it its own

Re: [libvirt] [libvirt-snmp][PATCH] New environment variable managing connection URI.

2011-02-10 Thread Daniel P. Berrange
On Thu, Feb 10, 2011 at 10:43:08AM +0800, Daniel Veillard wrote: On Wed, Feb 09, 2011 at 04:43:25PM +0100, Michal Privoznik wrote: Add environment variable LIBVIRT_MIB_CONNECT_URI to control URI which snmp agent is connecting to. It is now possible to connect to all hypervisors (including

Re: [libvirt] [RFC PATCH 1/6] util: Add API for converting virBitmap into printable string

2011-02-10 Thread Jiri Denemark
+for ( ; sz 0; sz--) +virBufferVSprintf(buf, %08x, bitmap-map[sz - 1]); I probably would have written: while (sz--) virBufferVSprintf(buf, %08x, bitmap-map[sz]); Yeah, it looks nicer; I'll use that since I'll send a new version anyway. since sz is guaranteed to be

Re: [libvirt] [libvirt-snmp][PATCH v2] Remove the hard coded connection URI.

2011-02-10 Thread Daniel P. Berrange
On Thu, Feb 10, 2011 at 10:02:35AM +0100, Michal Privoznik wrote: So now we rely on libvirt LIBVIRT_DEFAULT_URI environment variable. --- src/libvirtSnmp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/libvirtSnmp.c b/src/libvirtSnmp.c index

Re: [libvirt] [PATCH] Fix spice's passwdValidTo setting

2011-02-10 Thread Daniel P. Berrange
On Thu, Feb 10, 2011 at 10:35:08AM +0100, Michal Privoznik wrote: This fix the typo in the source. https://bugzilla.redhat.com/show_bug.cgi?id=676374 --- src/conf/domain_conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [libvirt-snmp][PATCH v2] Remove the hard coded connection URI.

2011-02-10 Thread Daniel Veillard
On Thu, Feb 10, 2011 at 10:20:04AM +, Daniel P. Berrange wrote: On Thu, Feb 10, 2011 at 10:02:35AM +0100, Michal Privoznik wrote: So now we rely on libvirt LIBVIRT_DEFAULT_URI environment variable. --- src/libvirtSnmp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

[libvirt] [PATCH] Avoid warnings from nwfilter driver when run non-root

2011-02-10 Thread Daniel P. Berrange
When run non-root the nwfilter driver logs error messages about being unable to find iptables/ebtables commands (they are in /sbin which isn't in $PATH). The nwfilter driver can't ever work as non-root, so simply skip it entirely thus avoiding the error messages * src/conf/nwfilter_conf.h,

[libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-10 Thread Daniel P. Berrange
Win32 doesn't have a concept of signal masks so disable that code. It is unclear how SIGINT is delivered (if at all) on Win32, so this might further work to provide an alternative to pthread_sigmask * tools/virsh.c: Avoid pthread_sigmask on Win32 --- tools/virsh.c | 20 +++- 1

Re: [libvirt] [RFC PATCH 3/6] qemu: Use helper functions for handling cmd line capabilities

2011-02-10 Thread Jiri Denemark
@@ -3181,12 +3181,18 @@ qemuBuildCommandLine(virConnectPtr conn, devices. Fortunately, those don't need static PCI addresses, so we don't really care that we can't use -device */ -if ((qemuCmdFlags QEMU_CAPS_DEVICE) -

Re: [libvirt] [PATCH] Reduce log level when cgroups aren't mounted

2011-02-10 Thread Laine Stump
On 02/10/2011 05:48 AM, Daniel P. Berrange wrote: Quite a few hosts don't have cgroups mounted and so see warnings from libvirt logged, which then cause bug reports, etc. Reduce the log level to INFO so they're not visible by default * src/qemu/qemu_driver.c: Reduce log level for cgroups ---

Re: [libvirt] [PATCH] Avoid warnings from nwfilter driver when run non-root

2011-02-10 Thread Laine Stump
On 02/10/2011 05:49 AM, Daniel P. Berrange wrote: When run non-root the nwfilter driver logs error messages about being unable to find iptables/ebtables commands (they are in /sbin which isn't in $PATH). The nwfilter driver can't ever work as non-root, so simply skip it entirely thus avoiding

[libvirt] [PATCH 0/3] Basic libxenlight driver

2011-02-10 Thread Markus Groß
Hi, I started working on a libxenlight driver for libvirt a few weeks ago. By that time I didn't knew Jim Fehlig was also working on a driver for that api: http://article.gmane.org/gmane.comp.emulators.libvirt/33024 Because I already did some work and there is no driver from Jim yet, I am

[libvirt] [PATCH 3/3] Add myself to AUTHORS

2011-02-10 Thread Markus Groß
--- AUTHORS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/AUTHORS b/AUTHORS index 38ea4bb..24ae98b 100644 --- a/AUTHORS +++ b/AUTHORS @@ -154,6 +154,7 @@ Patches have also been contributed by: Zdenek Styblik sty...@turnovfree.net Gui Jianfeng

[libvirt] [PATCH 2/3] Integrate libxenlight driver into libvirt

2011-02-10 Thread Markus Groß
--- configure.ac| 35 +-- include/libvirt/virterror.h |1 + po/POTFILES.in |2 ++ src/Makefile.am | 25 + src/driver.h|3 ++- src/libvirt.c | 13

Re: [libvirt] [RFC PATCH 5/6] qemu: Switch over command line capabilities to virBitmap

2011-02-10 Thread Jiri Denemark
On 02/09/2011 09:02 AM, Jiri Denemark wrote: This is done for two reasons: - we are getting very close to 64 flags which is the maximum we can use with unsigned long long - by using LL constants in enum we already violates C99 constraint that enum values have to fit into int Does

Re: [libvirt] [RFC PATCH 6/6] tests: Use virBitmap for qemu command line caps

2011-02-10 Thread Jiri Denemark
On Wed, Feb 09, 2011 at 10:33:01 -0700, Eric Blake wrote: On 02/09/2011 09:02 AM, Jiri Denemark wrote: This needs to be squashed into the previous patch but is provided separately for easier review. --- src/qemu/qemu_capabilities.c | 14 + src/qemu/qemu_capabilities.h |2 +

Re: [libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-10 Thread Matthias Bolte
2011/2/10 Daniel P. Berrange berra...@redhat.com: Win32 doesn't have a concept of signal masks so disable that code. It is unclear how SIGINT is delivered (if at all) on Win32, so this might further work to provide an alternative to pthread_sigmask * tools/virsh.c: Avoid pthread_sigmask on

Re: [libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-10 Thread Daniel P. Berrange
On Thu, Feb 10, 2011 at 03:20:37PM +0100, Matthias Bolte wrote: 2011/2/10 Daniel P. Berrange berra...@redhat.com: Win32 doesn't have a concept of signal masks so disable that code. It is unclear how SIGINT is delivered (if at all) on Win32, so this might further work to provide an

Re: [libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-10 Thread Matthias Bolte
2011/2/10 Daniel P. Berrange berra...@redhat.com: On Thu, Feb 10, 2011 at 03:20:37PM +0100, Matthias Bolte wrote: 2011/2/10 Daniel P. Berrange berra...@redhat.com: Win32 doesn't have a concept of signal masks so disable that code. It is unclear how SIGINT is delivered (if at all) on Win32,

Re: [libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms

2011-02-10 Thread Daniel P. Berrange
On Thu, Feb 10, 2011 at 03:38:08PM +0100, Matthias Bolte wrote: 2011/2/10 Daniel P. Berrange berra...@redhat.com: On Thu, Feb 10, 2011 at 03:20:37PM +0100, Matthias Bolte wrote: 2011/2/10 Daniel P. Berrange berra...@redhat.com: Win32 doesn't have a concept of signal masks so disable that

Re: [libvirt] Entering freeze for libvirt-0.8.8

2011-02-10 Thread Matthias Bolte
2011/2/10 Daniel Veillard veill...@redhat.com:  We're entering the week freeze for 0.8.8, so let's delay new feature until the end of next week and let's focuse on bug fixes. I have put an initial release candidate at:  ftp://libvirt.org/libvirt/libvirt-0.8.8-rc1.tar.gz it seems to compile

[libvirt] domain.rng updated ?

2011-02-10 Thread arnaud.champion
?Hi, I'm working on C# bindings, my goal is to expose xml descriptions (domain, node, storage and so on...) as real C# objects, for this, I'm studying the rng files provided in /docs/schemas/ directory of the sources. I'm currently working on domain.rng. I don't know if the domain.rng file is

Re: [libvirt] domain.rng updated ?

2011-02-10 Thread Eric Blake
On 02/10/2011 09:59 AM, arnaud.champ...@devatom.fr wrote: ?Hi, I'm working on C# bindings, my goal is to expose xml descriptions (domain, node, storage and so on...) as real C# objects, for this, I'm studying the rng files provided in /docs/schemas/ directory of the sources. I'm currently

Re: [libvirt] domain.rng updated ?

2011-02-10 Thread arnaud.champion
?Ooopps, my fault, seems I have missreaded the nrg sorry, address are well defined in the rng :S Sorry, Arnaud From: arnaud.champ...@devatom.fr Sent: Thursday, February 10, 2011 5:59 PM To: libvir-list@redhat.com Subject: [libvirt] domain.rng updated ? Hi, I'm working on C# bindings, my

Re: [libvirt] [PATCH 1/2] Get cpuMhz of virNodeGetInfo() from cpufreq/cpuinfo_max_freq, if exist

2011-02-10 Thread Matthias Bolte
2011/2/10 Minoru Usui u...@mxm.nes.nec.co.jp: Hi, Eric On Tue, 1 Feb 2011 10:26:36 +0900 Minoru Usui u...@mxm.nes.nec.co.jp wrote: Hi, Eric On Mon, 31 Jan 2011 15:46:39 -0700 Eric Blake ebl...@redhat.com wrote: On 01/27/2011 02:51 AM, Minoru Usui wrote: virNodeGetInfo() gets from

Re: [libvirt] [PATCH 4/6] Remote driver implementation of new migration API

2011-02-10 Thread Eric Blake
On 02/09/2011 09:58 AM, Daniel P. Berrange wrote: * src/remote/remote_protocol.x: Define wire protocol for migration protocol v3 * daemon/remote.c: Server side dispatch * src/remote/remote_driver.c: Client side serialization * src/remote/remote_protocol.c, src/remote/remote_protocol.h,

Re: [libvirt] [PATCH 5/6] Introduce migration cookies to QEMU driver

2011-02-10 Thread Eric Blake
On 02/09/2011 09:58 AM, Daniel P. Berrange wrote: The migration protocol has support for a 'cookie' parameter which is an opaque array of bytes as far as libvirt is concerned. Drivers may use this for passing around arbitrary extra data they might need during migration. The QEMU driver needs

Re: [libvirt] [PATCH 6/6] Implement migration v3 protocol in QEMU driver

2011-02-10 Thread Eric Blake
On 02/09/2011 09:58 AM, Daniel P. Berrange wrote: Implement the v3 migration protocol, which has two extra steps, 'begin' on the source host and 'confirm' on the source host. All other methods also gain both input and output cookies to allow bi-directional data passing at all stages *

Re: [libvirt] [PATCH 1/6] Split all QEMU process mangement code into separate file

2011-02-10 Thread Eric Blake
On 02/09/2011 12:43 PM, Eric Blake wrote: On 02/09/2011 09:58 AM, Daniel P. Berrange wrote: Move the qemudStartVMDaemon and qemudShutdownVMDaemon methods into a separate file, renaming them to qemuProcessStart, qemuProcessStop. All helper methods called by these are also moved renamed to

Re: [libvirt] [PATCH 2/2] tests: set QEMUD_CMD_FLAG_PCI_MULTIBUS in testCompareXMLToArgvFiles()

2011-02-10 Thread Eric Blake
On 02/09/2011 07:19 PM, Wen Congyang wrote: set QEMUD_CMD_FLAG_PCI_MULTIBUS before calling qemuBuildCommandLine() as the flags is not set by qemuCapsExtractVersionInfo(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- tests/qemuxml2argvtest.c |9 + 1 files changed, 9

Re: [libvirt] [PATCHv3 2/2] Add txmode attribute to interface XML for virtio backend

2011-02-10 Thread Eric Blake
On 02/10/2011 02:53 AM, Laine Stump wrote: == V3 changes: 0) The actual code remains untouched from V2. 1) Add txmode attribute to the domain schema, and to an xml2xml and xml2argv test (note that the particular file used for the xml2xml test was

Re: [libvirt] [PATCHv2 2/2] Give each virtual network bridge its own fixed MAC address

2011-02-10 Thread Eric Blake
On 02/10/2011 02:57 AM, Laine Stump wrote: The solution is to create a dummy tap interface with a MAC guaranteed to be lower than any guest interface's MAC, and attach that tap to the bridge as soon as it's created. Since all guest MAC addresses start with 0xFE, we can just generate a MAC with

Re: [libvirt] [PATCH ruby-libvirt] Add a control file for automated builds

2011-02-10 Thread Chris Lalancette
On 02/10/11 - 06:07:26PM, Daniel P. Berrange wrote: * autobuild.sh: Automated build control * ruby-libvirt.spec: Add autobuild release tag --- autobuild.sh | 29 + ruby-libvirt.spec |2 +- 2 files changed, 30 insertions(+), 1 deletions(-) create mode

Re: [libvirt] [PATCH 0/3] Basic libxenlight driver

2011-02-10 Thread Jim Fehlig
Markus Groß wrote: Hi, I started working on a libxenlight driver for libvirt a few weeks ago. By that time I didn't knew Jim Fehlig was also working on a driver for that api: http://article.gmane.org/gmane.comp.emulators.libvirt/33024 Because I already did some work and there is no driver

Re: [libvirt] [PATCH 2/2] tests: set QEMUD_CMD_FLAG_PCI_MULTIBUS in testCompareXMLToArgvFiles()

2011-02-10 Thread Eric Blake
On 02/10/2011 12:18 PM, Eric Blake wrote: On 02/09/2011 07:19 PM, Wen Congyang wrote: set QEMUD_CMD_FLAG_PCI_MULTIBUS before calling qemuBuildCommandLine() as the flags is not set by qemuCapsExtractVersionInfo(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com ---

Re: [libvirt] [PATCH 0/3] Basic libxenlight driver

2011-02-10 Thread Jim Fehlig
Jim Fehlig wrote: Markus Groß wrote: 2. The driver supports libvirtxml - xen-xm conversion, thanks to the unified xen driver which already offered this functionality. But since this driver is not part of xen unified, I had to copy this functionality, rather than reusing it.

Re: [libvirt] Entering freeze for libvirt-0.8.8

2011-02-10 Thread Daniel Veillard
On Thu, Feb 10, 2011 at 04:16:39PM +0100, Matthias Bolte wrote: [...] it seems to compile and work fine for me. there is however a small problem at configure time: - thinkpad:~/tmp/libvirt-0.8.8 - ./autogen.sh --system ; make Running ./configure with