Re: [libvirt] Html docs for win32 build?

2011-02-16 Thread Matthias Bolte
2011/2/14 Justin Clift jcl...@redhat.com: Hi Matthias, Thinking we should include the generated html docs in the win32 installer. Any thoughts/objections? Sure we can do that. Also, thinking that if we do, it shouldn't be too hard to install the xhtml1-dtds and use them during the

Re: [libvirt] Html docs for win32 build?

2011-02-16 Thread Justin Clift
On 16/02/2011, at 7:49 PM, Matthias Bolte wrote: snip I think, I'm going to integrate your script nevertheless as it makes the dev environment more complete. Thanks for the script :) You're welcome, no stress at all. Use it if/when/how it makes sense to, etc, no worries. :) -- libvir-list

[libvirt] [PATCH v2] qemu: Error prompt when saving a shutoff domain

2011-02-16 Thread Osier Yang
qemudDomainSaveFlag goto wrong label endjob, which will cause error when security manager trying to restore label (regression). As it's more reasonable to check if vm is shutoff immediately, and return right away if it is, remove the checking in qemudDomainSaveFlag, and add checking in

Re: [libvirt] [PATCH] qemu: Error prompt when saving a shutoff domain

2011-02-16 Thread Osier Yang
于 2011年02月15日 17:52, Daniel Veillard 写道: On Tue, Feb 15, 2011 at 04:26:37PM +0800, Osier Yang wrote: * src/qemu/qemu_driver.c --- src/qemu/qemu_driver.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] CfP 6th Workshop on Virtualization in High-Performance Cloud Computing (VHPC'11)

2011-02-16 Thread VHPC2011
Apologies if you received multiple copies of this message. = CALL FOR PAPERS 6th Workshop on Virtualization in High-Performance Cloud Computing VHPC'11 as part of Euro-Par 2011, Bordeaux, France

Re: [libvirt] [libvirt-php 2/2] Added libvirt-php.obs.spec

2011-02-16 Thread Michal Novotny
On 02/15/2011 01:42 PM, Lyre wrote: On Tue, Feb 15, 2011 at 7:48 PM, Justin Clift jcl...@redhat.com mailto:jcl...@redhat.com wrote: On 15/02/2011, at 10:35 PM, Lyre wrote: snip The problem was, I'm not quite sure what to do with this spec file. Currently, It may be

Re: [libvirt] [libvirt-php 0/3] Eliminated complilation warnings

2011-02-16 Thread Michal Novotny
On 02/15/2011 10:49 AM, Lyre wrote: Hi all: These patch added the -Wall option for compiler, and eliminated all warnings. Lyre (3): Added -Wall option Fixed some compilation warnings Eliminated ununsed variables src/Makefile.am |4 +- src/libvirt.c | 65

Re: [libvirt] [libvirt-php] Merge rpm spec files

2011-02-16 Thread Michal Novotny
On 02/16/2011 04:33 AM, Lyre wrote: Merge php-libvirt.spec libvirt-php.obs.spec to libvirt-php.spec, which will pack libvirt-php into two packages: libvirt-php: the extension itself with the configuration file. libvirt-php-doc: document package for libvirt-php This spec file

[libvirt] [libvirt-snmp][PATCH] Add SNMP trap/notification support.

2011-02-16 Thread Michal Privoznik
This patch adds support for domain lifecycle notification support over SNMP traps. SNMP subagent monitors any domain events and when something interesting happens, it sends trap. Monitoring is done in a joinable thread using polling (used domain-events example from libvirt) so we won't block

Re: [libvirt] [PATCH SNMP] Add automated build control script

2011-02-16 Thread Michal Prívozník
On 02/11/2011 06:14 PM, Daniel P. Berrange wrote: * .gitignore: Ignore build directory * autobuild.sh: Add automated build script * autogen.sh: Helper for re-generating autotools files * libvirt-snmp.spec.in: Add extra_release and remove substitution of mibdir since RPM path shouldn't change

Re: [libvirt] [PATCH] cgroup: preserve correct errno on failure

2011-02-16 Thread Laine Stump
On 02/15/2011 07:33 PM, Eric Blake wrote: On 02/15/2011 05:01 PM, Eric Blake wrote: * src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr) (virCgroupRemoveRecursively): VIR_DEBUG can clobber errno. (virCgroupRemove): Use VIR_DEBUG rather than DEBUG. --- rc =

Re: [libvirt] [PATCH] cgroup: preserve correct errno on failure

2011-02-16 Thread Eric Blake
On 02/15/2011 08:34 PM, Daniel Veillard wrote: On Tue, Feb 15, 2011 at 05:01:18PM -0700, Eric Blake wrote: * src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr) (virCgroupRemoveRecursively): VIR_DEBUG can clobber errno. (virCgroupRemove): Use VIR_DEBUG rather than DEBUG. ---

Re: [libvirt] [PATCH] Add support for multiple serial ports into the Xen driver

2011-02-16 Thread Michal Novotny
Ping ... could somebody review this one please? Thanks, Michal On 01/22/2011 05:49 PM, Michal Novotny wrote: Hi, this is the patch to add support for multiple serial ports to the libvirt Xen driver. It support both old style (serial = pty) and new style (serial = [ /dev/ttyS0, /dev/ttyS1 ])

Re: [libvirt] [libvirt-php] Merge rpm spec files

2011-02-16 Thread Jim Fehlig
Lyre wrote: Merge php-libvirt.spec libvirt-php.obs.spec to libvirt-php.spec, which will pack libvirt-php into two packages: libvirt-php: the extension itself with the configuration file. libvirt-php-doc: document package for libvirt-php This spec file should works for Fedora 14,

Re: [libvirt] [PATCH] Add support for multiple serial ports into the Xen driver

2011-02-16 Thread Eric Blake
On 02/16/2011 08:19 AM, Michal Novotny wrote: Ping ... could somebody review this one please? Thanks, Michal On 01/22/2011 05:49 PM, Michal Novotny wrote: Hi, this is the patch to add support for multiple serial ports to the libvirt Xen driver. It support both old style (serial = pty)

[libvirt] [PATCH] build: Fix VPATH build

2011-02-16 Thread Jiri Denemark
Even VPATH make dist succeeds now --- docs/Makefile.am |8 docs/apibuild.py | 23 +-- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 473bbbf..8c96e79 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am

Re: [libvirt] [PATCH] maint: Replace tabs in apibuild.py with spaces

2011-02-16 Thread Eric Blake
On 02/16/2011 09:01 AM, Jiri Denemark wrote: --- docs/apibuild.py | 3194 +++--- 1 files changed, 1597 insertions(+), 1597 deletions(-) ACK; confirmed by 'git diff -b' that there is no substance change. However, should we be tweaking cfg.mk's

Re: [libvirt] [PATCH v2] qemu: Error prompt when saving a shutoff domain

2011-02-16 Thread Eric Blake
On 02/16/2011 03:06 AM, Osier Yang wrote: qemudDomainSaveFlag goto wrong label endjob, which will cause error when security manager trying to restore label (regression). As it's more reasonable to check if vm is shutoff immediately, and return right away if it is, remove the checking in

[libvirt] [PATCH] maint: delete unused 'make install' step

2011-02-16 Thread Eric Blake
Libxml2-Logo-90x34.gif was removed from the repository in Sep 2009 (commit d6d528c) because our docs no longer reference it. * docs/Makefile.am (install-data-local): Don't install missing file. --- Pushing this under the trivial rule. docs/Makefile.am |1 - 1 files changed, 0

Re: [libvirt] [PATCH] build: Fix VPATH build

2011-02-16 Thread Eric Blake
On 02/16/2011 09:01 AM, Jiri Denemark wrote: Even VPATH make dist succeeds now --- docs/Makefile.am |8 docs/apibuild.py | 23 +-- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 473bbbf..8c96e79

Re: [libvirt] [PATCH] build: Fix VPATH build

2011-02-16 Thread Eric Blake
On 02/16/2011 09:41 AM, Eric Blake wrote: On 02/16/2011 09:01 AM, Jiri Denemark wrote: Even VPATH make dist succeeds now ACK. I think this is okay for 0.8.8, since it doesn't invalidate any .c code, and since it makes the tarball more useful. I still maintain the ACK, and would like to

[libvirt] [PATCHv5] PHYP: Adding network interface management

2011-02-16 Thread Eduardo Otubo
This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details: * MAC size and interface name are fixed due to specifications on HMC, both are created automatically and CAN'T be

Re: [libvirt] [RFC PATCH 0/2] audit cgroup ACL actions in qemu

2011-02-16 Thread Steve Grubb
On Tuesday, February 15, 2011 09:59:59 pm Eric Blake wrote: I'm following up on danpb's patches to add initial audit support to qemu actions (see around commit 8dc136b in Oct 2010). Another useful thing to audit is all changes to the device ACL whitelist via the cgroup device controller -

Re: [libvirt] [PATCH] build: Fix VPATH build

2011-02-16 Thread Jiri Denemark
On Wed, Feb 16, 2011 at 09:41:17 -0700, Eric Blake wrote: ACK. I think this is okay for 0.8.8, since it doesn't invalidate any .c code, and since it makes the tarball more useful. While I believe this change is save, I tend to be careful about build system changes since they may break in some

Re: [libvirt] [PATCH] build: Fix VPATH build

2011-02-16 Thread Eric Blake
On 02/16/2011 09:50 AM, Eric Blake wrote: On 02/16/2011 09:41 AM, Eric Blake wrote: On 02/16/2011 09:01 AM, Jiri Denemark wrote: Even VPATH make dist succeeds now ACK. I think this is okay for 0.8.8, since it doesn't invalidate any .c code, and since it makes the tarball more useful. I

Re: [libvirt] [PATCH] build: Fix VPATH build

2011-02-16 Thread Jiri Denemark
On Wed, Feb 16, 2011 at 09:50:57 -0700, Eric Blake wrote: I still maintain the ACK, and would like to see this go in as-is. However, this patch is incomplete... And I'm going to dig up my attempted patch from long ago that converts ./autobuild.sh to use a VPATH build. My modified

[libvirt] [PATCH] maint: avoid 'make syntax-check' from tarball

2011-02-16 Thread Eric Blake
* .gnulib: update to latest gnulib for maint.mk fixes --- In testing the latest release candidate, I ran 'make syntax-check' out of habit, and it died miserably (even hanging waiting for input on stdin). So I fixed maint.mk upstream: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/25340

Re: [libvirt] [PATCH] build-sys: distribute the man pages in the tarball

2011-02-16 Thread Eric Blake
On 08/09/2010 05:12 PM, Eric Blake wrote: On 08/09/2010 04:55 PM, Diego Elio Pettenò wrote: This slightly reduces the requirements for building libvirt. The man pages are deleted with make maintainer-clean. Reviving an old thread... --- daemon/Makefile.am |5 +++-- tools/Makefile.am

[libvirt] [PATCH] build: don't require pod2man for tarball builds

2011-02-16 Thread Eric Blake
Right now, 'man libvirtd' includes information that depends on configure results, so it must be generated on the fly and live in $(builddir); however, requiring pod2man on all end user machines is overkill. Meanwhile, 'man virsh' doesn't mention any configure results, so it can be built at 'make

[libvirt] [PATCH] logging: make VIR_ERROR and friends preserve errno

2011-02-16 Thread Eric Blake
Followup to commit 17e19add, and would have prevented the bug independently fixed in commit 76c57a7c. * src/util/logging.c (virLogMessage): Preserve errno, since logging should be as unintrusive as possible. --- Per list discussion, this is post-0.8.8 material. src/util/logging.c | 23

Re: [libvirt] Still in freeze, third rc tarball available

2011-02-16 Thread Jim Fehlig
Jim Fehlig wrote: Daniel Veillard wrote: Thanks everybody for the testing feedback and fixes, in retrospect I should really had done this in previous releases ! So the third rc tarball is out, it's likely to be the last one before the release (within 48 hours):

Re: [libvirt] [PATCH v2] qemu: Error prompt when saving a shutoff domain

2011-02-16 Thread Osier Yang
于 2011年02月17日 00:22, Eric Blake 写道: On 02/16/2011 03:06 AM, Osier Yang wrote: qemudDomainSaveFlag goto wrong label endjob, which will cause error when security manager trying to restore label (regression). As it's more reasonable to check if vm is shutoff immediately, and return right away if

[libvirt] [PATCH] [libvirt-tck] Fix expected error code

2011-02-16 Thread Jim Fehlig
Attempting to set a transient domain autostart results in ERR_OPERATION_INVALID not ERR_INTERNAL_ERROR. --- scripts/domain/051-transient-autostart.t |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/domain/051-transient-autostart.t

Re: [libvirt] [PATCH] [libvirt-tck] Fix expected error code

2011-02-16 Thread Eric Blake
On 02/16/2011 07:34 PM, Jim Fehlig wrote: Attempting to set a transient domain autostart results in ERR_OPERATION_INVALID not ERR_INTERNAL_ERROR. --- scripts/domain/051-transient-autostart.t |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] RFC: support vram and heads for qxl vga

2011-02-16 Thread Osier Yang
于 2011年02月15日 22:13, Daniel P. Berrange 写道: On Tue, Feb 15, 2011 at 09:47:28PM +0800, Osier Yang wrote: qemu command line to specify vram: -global qxl.vram_size=uint qemu command line to specify heads, (no need of '-device' for the first 'head'): -device qxl,id=qxl-N (N is natural

Re: [libvirt] [PATCH] [libvirt-tck] Fix expected error code

2011-02-16 Thread Jim Fehlig
Eric Blake wrote: On 02/16/2011 07:34 PM, Jim Fehlig wrote: Attempting to set a transient domain autostart results in ERR_OPERATION_INVALID not ERR_INTERNAL_ERROR. --- scripts/domain/051-transient-autostart.t |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] maint: avoid 'make syntax-check' from tarball

2011-02-16 Thread Daniel Veillard
On Wed, Feb 16, 2011 at 02:39:30PM -0700, Eric Blake wrote: * .gnulib: update to latest gnulib for maint.mk fixes --- In testing the latest release candidate, I ran 'make syntax-check' out of habit, and it died miserably (even hanging waiting for input on stdin). So I fixed maint.mk

[libvirt] [PATCH] check more error info about whether drive_add failed

2011-02-16 Thread Wen Congyang
When we attach a disk, but we specify a wrong format of disk image, qemu monitor command drive_add will fail, but libvirt does not detect this error. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- src/qemu/qemu_monitor_text.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-)

[libvirt] [PATCH] update domain status forcibly even if attach a device failed

2011-02-16 Thread Wen Congyang
Steps to reproduce this bug: 1. virsh attach-disk domain --source diskimage --target sdb --sourcetype file --driver qemu --subdriver qcow2 error: Failed to attach disk error: operation failed: adding scsi-disk,bus=scsi0.0,scsi-id=1,drive=drive-scsi0-0-1,id=scsi0-0-1 device failed:

[libvirt] Release of libvirt-0.8.8

2011-02-16 Thread Daniel Veillard
As scheduled the release is out, and available from the site: ftp://libvirt.org/libvirt/ Thanks everybody for the earlier testing on the release candidate series that was I think quite useful ! So this release is again mostly consisting of a very large batch of small improvements and bug

[libvirt] [PATCH] Check return value of qemuMonitorDriveDel.

2011-02-16 Thread Hu Tao
If we don't check it, virsh users will get Disk detached successfully even when qemuMonitorDriveDel fails. --- src/qemu/qemu_hotplug.c | 10 -- src/qemu/qemu_monitor_json.c |2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c

Re: [libvirt] [PATCH v3] storage: Allow to delete device mapper disk partition

2011-02-16 Thread Osier Yang
于 2011年02月15日 10:02, Osier Yang 写道: 于 2011年02月15日 00:27, Eric Blake 写道: On 02/12/2011 12:36 AM, Osier Yang wrote: The name convention of device mapper disk is different, and 'parted' can't be used to delete a device mapper disk partition. e.g. Name Path