Re: [libvirt] libvirt-ask

2011-02-21 Thread Justin Clift
On 21/02/2011, at 4:08 PM, Osier Yang wrote: > 于 2011年02月21日 10:12, stone1927 写道: >> I'm use an url format that is qemu+tcp://root@192.168.1.8/system or >> qemu+tcp://192.168.1.8/system >> >> error:unable to connect to libvirtd at '192.168.1.8':errno=10061 >> >> error:failed to connect to the hy

Re: [libvirt] blkio cgroup

2011-02-21 Thread Dominik Klein
Hi first of all: Thanks for taking the time. On 02/18/2011 05:31 PM, Vivek Goyal wrote: > So you have only one root SATA disk and setup a linear logical volume on > that? I not, can you give more info about the storage configuration? The logical volumes reside on a JBOD-device [1] connected wit

Re: [libvirt] [PATCH 0/6] new virsh command "blkiotune" support

2011-02-21 Thread Daniel Veillard
On Wed, Feb 16, 2011 at 11:53:06AM +0800, Gui Jianfeng wrote: > Hi All, > > This series implements a new command "blkiotune" for virsh. > A lot of code borrows from memtune. > You are able to tune blkio cgroup tunables by this command as follows. > > Show tunables > #virsh blkiotune My_guest > we

Re: [libvirt] [PATCH 0/6] new virsh command "blkiotune" support

2011-02-21 Thread Gui Jianfeng
Daniel Veillard wrote: > On Wed, Feb 16, 2011 at 11:53:06AM +0800, Gui Jianfeng wrote: >> Hi All, >> >> This series implements a new command "blkiotune" for virsh. >> A lot of code borrows from memtune. >> You are able to tune blkio cgroup tunables by this command as follows. >> >> Show tunables >>

Re: [libvirt] blkio cgroup

2011-02-21 Thread Dominik Klein
> I was also running "vmstat 2" when throttled machine did IO and noticed > that number of blocked processes went up, around 25-35. I am assuming > these all are qemu IO threads blocked waiting for throttled IO to finish. > I am not sure if blocked processes also contribute towards load average.

Re: [libvirt] blkio cgroup

2011-02-21 Thread Dominik Klein
>> - Is it possible to capture 10-15 second blktrace on your underlying >> physical device. That should give me some idea what's happening. > > Will do, read on. Just realized I missed this one ... Had better done it right away. So here goes. Setup as in first email. 8 Machines, 2 important,

Re: [libvirt] [PATCH 0/6 v3] Add blkio cgroup support

2011-02-21 Thread Gui Jianfeng
Dominik Klein wrote: > Hi > > back with some testing results. > >>> how about the start Guest with option "cache=none" to bypass pagecache? >>> This should help i think. >> I will read up on where to set that and give it a try. Thanks for the hint. > > So here's what I did and found out: > > Th

Re: [libvirt] blkio cgroup

2011-02-21 Thread Dominik Klein
On 02/21/2011 09:19 AM, Dominik Klein wrote: >>> - Is it possible to capture 10-15 second blktrace on your underlying >>> physical device. That should give me some idea what's happening. >> >> Will do, read on. > > Just realized I missed this one ... Had better done it right away. > > So here g

[libvirt] [RFC] virt-disk : a command line tool for modify domain XML's disk of inactive domains.

2011-02-21 Thread KAMEZAWA Hiroyuki
Hi, now, with qemu, virsh attach-disk doesn't work with inactive disks and we need to edit XML with virsh edit. IIUC, libvirt and virsh is designed as it is. But I want to modify domain XML via commandline tools - for middleware, which modify domains by scripting. - for concsoles, where curses c

Re: [libvirt] [PATCH] build: improve 'make install' for VPATH builds

2011-02-21 Thread Daniel Veillard
On Fri, Feb 18, 2011 at 12:09:02PM +0100, Jiri Denemark wrote: > On Thu, Feb 17, 2011 at 15:22:13 -0700, Eric Blake wrote: > > On 02/17/2011 08:06 AM, Jiri Denemark wrote: > > > I haven't tried that but xsltproc should support -o directory/ > > > > My recollection was that it didn't quite work: >

Re: [libvirt] [PATCH] maint: kill all remaining uses of old DEBUG macro

2011-02-21 Thread Daniel Veillard
On Wed, Feb 16, 2011 at 04:46:10PM -0700, Eric Blake wrote: > Done mechanically with: > $ git grep -l '\bDEBUG0\? *(' | xargs -L1 sed -i 's/\bDEBUG0\? *(/VIR_&/' > > followed by manual deletion of qemudDebug in daemon/libvirtd.c, along > with a single 'make syntax-check' fallout in the same file,

Re: [libvirt] [PATCH 2/2 v3] Add support for multiple serial ports into the Xen driver

2011-02-21 Thread Michal Novotny
On 02/18/2011 06:09 PM, Eric Blake wrote: On 02/18/2011 07:11 AM, Michal Novotny wrote: Hi, this is the patch to add support for multiple serial ports to the libvirt Xen driver. It support both old style (serial = "pty") and new style (serial = [ "/dev/ttyS0", "/dev/ttyS1" ]) definition and test

Re: [libvirt] [PATCH 1/2 v3] Fix virDomainChrDefParseTargetXML() to parse the target port if available

2011-02-21 Thread Michal Novotny
On 02/18/2011 05:49 PM, Eric Blake wrote: On 02/18/2011 07:11 AM, Michal Novotny wrote: Hi, this is the patch to fix the virDomainChrDefParseTargetXML() functionality to parse the target port from XML if available. This is necessary for multiple serial port support which is the second part of th

[libvirt] [PATCH 1/6] libvirt: Add virDomainSetBlkioParameters virDomainGetBlkioParameters

2011-02-21 Thread Gui Jianfeng
Add virDomainSetBlkioParameters virDomainGetBlkioParameters Signed-off-by: Gui Jianfeng --- .gnulib |2 +- include/libvirt/libvirt.h.in| 67 +++ python/generator.py |2 + python/libvirt-override-api.xml | 12

[libvirt] [PATCH 4/6] virsh: Adding blkiotune command to virsh tool

2011-02-21 Thread Gui Jianfeng
Adding blkiotune command to virsh tool Signed-off-by: Gui Jianfeng --- tools/virsh.c | 127 + 1 files changed, 127 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index ce275f1..5d6e06e 100644 --- a/tools/virsh.c

[libvirt] [PATCH 3/6] qemu: Implement domainSetBlkioParamters and domainGetBlkioParamters for QEmu

2011-02-21 Thread Gui Jianfeng
Implement domainSetBlkioParamters and domainGetBlkioParamters for QEmu Signed-off-by: Gui Jianfeng --- src/qemu/qemu_driver.c | 162 +++- 1 files changed, 160 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

[libvirt] [PATCH 5/6] remote-protocol: Remote protocol implementation of virDomainSetBlkioParameters and virDomainGetBlkioParameters.

2011-02-21 Thread Gui Jianfeng
Remote protocol implementation of virDomainSetBlkioParameters and virDomainGetBlkioParameters. Signed-off-by: Gui Jianfeng --- daemon/remote.c | 210 +++ daemon/remote_dispatch_args.h |2 + daemon/remote_dispatch_prototypes.h | 16

[libvirt] [PATCH 6/6] virsh: Documents for blkiotune

2011-02-21 Thread Gui Jianfeng
Documents for blkiotune Signed-off-by: Gui Jianfeng --- tools/virsh.pod |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index a2ca384..72dc1a2 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -610,6 +610,11 @@ of 4MB, while 2662

Re: [libvirt] [PATCH 1/2 v3] Fix virDomainChrDefParseTargetXML() to parse the target port if available

2011-02-21 Thread Michal Novotny
[snip] We've got other code in domain_conf.c that assigns ports to the first available slot; for example, look near line 5628 at how virtio-serial ports are assigned using maxport and traversal of all previously assigned ports. Is the code correct there? The code is: if (chr->info.typ

[libvirt] [PATCH 2/6] libvirt: Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and initialization

2011-02-21 Thread Gui Jianfeng
Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and initialization Signed-off-by: Gui Jianfeng --- src/driver.h | 14 ++ src/esx/esx_driver.c |2 + src/libvirt.c | 108 src/libvirt_pu

Re: [libvirt] Vietnamese Translation for libvirt

2011-02-21 Thread Hero Phương
Is that mean I need to "Create a personal page at https://fedoraproject.org/wiki/User:Username. This is very useful for Fedora contributors to get to know and contact each other. " And it's true that I have followed that guide. But now I only need to be approved in the translation site for libvirt

[libvirt] [PATCH] qemu: Support vram for video of qxl type

2011-02-21 Thread Osier Yang
For qemu names the primary vga as "qxl-vga": 1) if vram is specified for 2nd qxl device: -vga qxl -global qxl-vga.vram_size=$SIZE \ -device qxl,id=video1,vram_size=$SIZE,... 2) if vram is not specified for 2nd qxl device, (use the default set by global): -vga qxl -global qx

[libvirt] [PATCH 2/6] libvirt: Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and initialization

2011-02-21 Thread Gui Jianfeng
Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and initialization Signed-off-by: Gui Jianfeng --- src/driver.h | 14 ++ src/esx/esx_driver.c |2 + src/libvirt.c | 108 src/libvirt_pu

Re: [libvirt] [PATCH 5/5] don't check for NULL before calling virHashFree

2011-02-21 Thread Daniel P. Berrange
On Fri, Feb 18, 2011 at 01:22:41PM -0700, Eric Blake wrote: > On 02/18/2011 12:30 PM, Jim Meyering wrote: > >>> -if (doms->objs) > >>> -virHashFree(doms->objs, virDomainObjListDeallocator); > >>> +virHashFree(doms->objs, virDomainObjListDeallocator); > >> > >> I tried adding --name=

Re: [libvirt] RFC: make element required?

2011-02-21 Thread Daniel P. Berrange
On Fri, Feb 18, 2011 at 06:51:36PM +0100, Michal Prívozník wrote: > Hi, > > I am about to fix https://bugzilla.redhat.com/show_bug.cgi?id=616721 > It seems to me that problem is libvirt inserts a new element address='...'> during parsing interface XML with random mac address > which result in err

Re: [libvirt] [PATCH] RFC: experimental libvirtd upstart job

2011-02-21 Thread Daniel P. Berrange
On Fri, Feb 18, 2011 at 03:48:29PM -0600, Serge E. Hallyn wrote: > Quoting ape...@gmail.com (ape...@gmail.com): > > From: Alan Pevec > > > > To install it, disable libvirtd sysv initscript: > > chkconfig libvirtd off > > service libvirtd stop > > > > and enable libvirtd upstart job: > >

Re: [libvirt] [PATCH] qemu: Support vram for video of qxl type

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 06:17:25PM +0800, Osier Yang wrote: > For qemu names the primary vga as "qxl-vga": > > 1) if vram is specified for 2nd qxl device: > > -vga qxl -global qxl-vga.vram_size=$SIZE \ > -device qxl,id=video1,vram_size=$SIZE,... > > 2) if vram is not specified for 2n

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Diego Elio Pettenò
Il giorno lun, 21/02/2011 alle 09.51 +0800, Lyre ha scritto: > +# PKG_PROG_PKG_CONFIG([MIN-VERSION]) > +# -- I don't think you're supposed to inline pkg.m4 within aclocal... -- Diego Elio Pettenò — Flameeyes http://blog.flameeyes.eu/ -- libvir-list mailing list l

Re: [libvirt] [libvirt-php] About the inconsistency in libvirt-php

2011-02-21 Thread Michal Novotny
On 02/21/2011 03:50 AM, Lyre wrote: Hi all: I noticed that there's some inconsistent behaviors in libvirt-php, and wondering what's the best way to handle them. In libvirt-php: libvirt_list_domains() returns an array of all domain resource; libvirt_list_active_domains() returns an array of r

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Michal Novotny
On 02/21/2011 01:07 PM, Diego Elio Pettenò wrote: Il giorno lun, 21/02/2011 alle 09.51 +0800, Lyre ha scritto: +# PKG_PROG_PKG_CONFIG([MIN-VERSION]) +# -- I don't think you're supposed to inline pkg.m4 within aclocal... Do you think this code is bad ? Michal

[libvirt] [PATCH 1/8] Moved SEXPR unit to utils

2011-02-21 Thread Markus Groß
--- src/Makefile.am |2 +- src/{xen => util}/sexpr.c |0 src/{xen => util}/sexpr.h |0 3 files changed, 1 insertions(+), 1 deletions(-) rename src/{xen => util}/sexpr.c (100%) rename src/{xen => util}/sexpr.h (100%) diff --git a/src/Makefile.am b/src/Makefile.am index 30c6

[libvirt] [PATCH 2/8] Moved some SEXPR functions from xen-unified

2011-02-21 Thread Markus Groß
--- src/util/sexpr.c| 64 ++ src/util/sexpr.h|6 src/xen/xend_internal.c | 65 --- 3 files changed, 70 insertions(+), 65 deletions(-) diff --git a/src/util/sexpr.c b/src/util/sexpr

[libvirt] [PATCH 7/8] Renamed functions in xenxs

2011-02-21 Thread Markus Groß
--- src/xen/xen_driver.c|8 +- src/xen/xend_internal.c | 54 +++--- src/xen/xm_internal.c |6 +- src/xenxs/xen_sxpr.c| 184 +++ src/xenxs/xen_sxpr.h| 60 +--- src/xenxs/xen_xm.c | 35 +- src/x

[libvirt] [PATCH 0/8] Refactored SEXPR and XM code

2011-02-21 Thread Markus Groß
Hi, this is a reworked version of my patch that refactors the XM and SEXPR parsing routines from the xen-unified driver into a seperate directory (xenxs; x for xm and s for sexpr). This way different xen-drivers besides xen-unified are able to use the parsing functionality. For example the upco

[libvirt] [PATCH 8/8] Added to AUTHORS

2011-02-21 Thread Markus Groß
--- AUTHORS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/AUTHORS b/AUTHORS index 6ff7c14..fb42662 100644 --- a/AUTHORS +++ b/AUTHORS @@ -155,6 +155,7 @@ Patches have also been contributed by: Gui Jianfeng Michal Novotny Christophe Fergeau +

[libvirt] [PATCH 6/8] Moved XM formatting functions to xenxs

2011-02-21 Thread Markus Groß
--- src/xen/xen_driver.c |2 +- src/xen/xm_internal.c | 723 + src/xen/xm_internal.h |2 - src/xenxs/xen_sxpr.h |6 - src/xenxs/xen_xm.c| 715 src/xenxs/xen_xm.h

[libvirt] [v2] qemu: Support vram for video of qxl type

2011-02-21 Thread Osier Yang
For qemu names the primary vga as "qxl-vga": 1) if vram is specified for 2nd qxl device: -vga qxl -global qxl-vga.vram_size=$SIZE \ -device qxl,id=video1,vram_size=$SIZE,... 2) if vram is not specified for 2nd qxl device, (use the default set by global): -vga qxl -global qx

Re: [libvirt] [PATCH] build: Fix API docs generation in VPATH build

2011-02-21 Thread Jiri Denemark
On Fri, Feb 18, 2011 at 09:54:39 -0700, Eric Blake wrote: > On 02/18/2011 06:31 AM, Jiri Denemark wrote: > >>> +++ b/docs/devhelp/devhelp.xsl > >>> @@ -13,6 +13,13 @@ > >>> > >>> > >>> > >>> + > >>> +http://www.devhelp.net/book"; > >>> href="libvirt.devhelp" > >>> +

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Diego Elio Pettenò
Il giorno lun, 21/02/2011 alle 14.40 +0100, Michal Novotny ha scritto: > > Do you think this code is bad ? I think that from a distribution point of view, doing this is a huge pain. The moment pkg-config is upgraded and the macros need updating, a simple rebuild of autotools is not going to fix

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Lyre
> > I don't think you're supposed to inline pkg.m4 within aclocal... I didn't check it carefully. But it was generated by autoreconf -fi, I'm not quite sure what exactly it did. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 10:16:04PM +0800, Lyre wrote: > > > > I don't think you're supposed to inline pkg.m4 within aclocal... > > > I didn't check it carefully. > > But it was generated by autoreconf -fi, I'm not quite sure what exactly it > did. The problem here is that 'aclocal.m4' is an au

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Michal Novotny
On 02/21/2011 03:11 PM, Diego Elio Pettenò wrote: Il giorno lun, 21/02/2011 alle 14.40 +0100, Michal Novotny ha scritto: Do you think this code is bad ? I think that from a distribution point of view, doing this is a huge pain. The moment pkg-config is upgraded and the macros need updating, a s

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Michal Novotny
So it was generated automatically using autoreconf -fi? If yes then I guess it could be fine to use it. Any opinion Diego? Michal On 02/21/2011 03:16 PM, Lyre wrote: I don't think you're supposed to inline pkg.m4 within aclocal... I didn't check it carefully. But it was generated by a

Re: [libvirt] [libvirt-php] About the inconsistency in libvirt-php

2011-02-21 Thread Justin Clift
On 22/02/2011, at 12:32 AM, Michal Novotny wrote: > libvirt_list_defined_domains() - return pointers for inactive domains, also > we should consider renaming it to list_inactive_domains() Ouch, yeah that looks pretty non-optimal. Probably better to fix it now, rather than leave it completely w

Re: [libvirt] [libvirt-php] About the inconsistency in libvirt-php

2011-02-21 Thread Michal Novotny
Thanks for your reply Justin. We should definitely do something with that. I'll work on that after my shift finishes, maybe even tomorrow shift, since I need to concentrate on something else now. However we should document the naming conventions with functionality described. It should be writte

Re: [libvirt] [virt-tools-list] [RFC] virt-disk : a command line tool for modify domain XML's disk of inactive domains.

2011-02-21 Thread Cole Robinson
On 02/21/2011 03:23 AM, KAMEZAWA Hiroyuki wrote: > Hi, now, with qemu, virsh attach-disk doesn't work with inactive disks and > we need to edit XML with virsh edit. > IIUC, libvirt and virsh is designed as it is. > > But I want to modify domain XML via commandline tools > - for middleware, which

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Diego Elio Pettenò
Il giorno lun, 21/02/2011 alle 15.32 +0100, Michal Novotny ha scritto: > Well, I am not that much familiar with autotools. > > Lyre, could you please rewrite without the code Diego doesn't like, > i.e. > this code? Let me explain: the pkg.m4 macro file that is here inlined is part of pkg-config

Re: [libvirt] [virt-tools-list] [RFC] virt-disk : a command line tool for modify domain XML's disk of inactive domains.

2011-02-21 Thread Eric Blake
On 02/21/2011 01:23 AM, KAMEZAWA Hiroyuki wrote: > Hi, now, with qemu, virsh attach-disk doesn't work with inactive disks and > we need to edit XML with virsh edit. > IIUC, libvirt and virsh is designed as it is. Actually, libvirt should be patched to learn how to modify xml of inactive disks for

Re: [libvirt] [PATCH] hash: make virHashFree more free-like

2011-02-21 Thread Eric Blake
On 02/18/2011 02:49 PM, Laine Stump wrote: > On 02/18/2011 04:31 PM, Eric Blake wrote: >> Two-argument free functions are uncommon; match the style elsewhere >> by caching the callback at creation. >> > > ACK. Pretty mechanical conversion, and a great idea! Thanks; applied. -- Eric Blake ebl.

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Michal Novotny
On 02/21/2011 04:23 PM, Diego Elio Pettenò wrote: Il giorno lun, 21/02/2011 alle 15.32 +0100, Michal Novotny ha scritto: Well, I am not that much familiar with autotools. Lyre, could you please rewrite without the code Diego doesn't like, i.e. this code? Let me explain: the pkg.m4 macro file t

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Diego Elio Pettenò
Il giorno lun, 21/02/2011 alle 15.34 +0100, Michal Novotny ha scritto: > > Any opinion Diego? As Daniel said, if you're using autoreconf you should not handle aclocal.m4 in git at all. For whatever reason I assumed you weren't using automake (in which case aclocal can be hand-edited). -- Diego

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 03:32:38PM +0100, Michal Novotny wrote: > On 02/21/2011 03:11 PM, Diego Elio Pettenò wrote: > >Il giorno lun, 21/02/2011 alle 14.40 +0100, Michal Novotny ha scritto: > >>Do you think this code is bad ? > >I think that from a distribution point of view, doing this is a huge >

Re: [libvirt] blkio cgroup

2011-02-21 Thread Vivek Goyal
On Mon, Feb 21, 2011 at 03:36:14PM +0800, Gui Jianfeng wrote: > Dominik, > > Would you try "oflag=direct" when you do tests in Guests. And make sure > /sys/block/xxx/queue/iosched/group_isolation is set to 1. oflag=direct in guest might be good for testing and understanding the problem, but in pr

Re: [libvirt] [libvirt-php] rewrite checking for libxml2

2011-02-21 Thread Michal Novotny
On 02/21/2011 04:43 PM, Daniel P. Berrange wrote: On Mon, Feb 21, 2011 at 03:32:38PM +0100, Michal Novotny wrote: On 02/21/2011 03:11 PM, Diego Elio Pettenò wrote: Il giorno lun, 21/02/2011 alle 14.40 +0100, Michal Novotny ha scritto: Do you think this code is bad ? I think that from a distri

Re: [libvirt] [PATCH] maint: kill all remaining uses of old DEBUG macro

2011-02-21 Thread Eric Blake
On 02/21/2011 01:55 AM, Daniel Veillard wrote: > On Wed, Feb 16, 2011 at 04:46:10PM -0700, Eric Blake wrote: >> Done mechanically with: >> $ git grep -l '\bDEBUG0\? *(' | xargs -L1 sed -i 's/\bDEBUG0\? *(/VIR_&/' >> >> followed by manual deletion of qemudDebug in daemon/libvirtd.c, along >> with a

Re: [libvirt] [PATCH 1/2 v3] Fix virDomainChrDefParseTargetXML() to parse the target port if available

2011-02-21 Thread Eric Blake
On 02/21/2011 02:38 AM, Michal Novotny wrote: > [snip] >> We've got other code in domain_conf.c that assigns ports >> to the first available slot; for example, look near line 5628 at how >> virtio-serial ports are assigned using maxport and traversal of all >> previously assigned ports. >> > Is the

Re: [libvirt] [PATCH 1/2 v3] Fix virDomainChrDefParseTargetXML() to parse the target port if available

2011-02-21 Thread Michal Novotny
On 02/21/2011 05:01 PM, Eric Blake wrote: On 02/21/2011 02:38 AM, Michal Novotny wrote: [snip] We've got other code in domain_conf.c that assigns ports to the first available slot; for example, look near line 5628 at how virtio-serial ports are assigned using maxport and traversal of all previo

Re: [libvirt] [PATCHv3 3/3] autobuild.sh: use VPATH build

2011-02-21 Thread Daniel P. Berrange
On Fri, Feb 18, 2011 at 03:24:57PM -0700, Eric Blake wrote: > Try to avoid future regressions on the VPATH front. > > * autobuild.sh: Uncomment VPATH use. > * .gitignore: Exclude build directory. > --- > > v2, not that much changed since: > https://www.redhat.com/archives/libvir-list/2010-April/m

Re: [libvirt] [PATCH 2/2] virt-*-validate.in: quote all variable references

2011-02-21 Thread Daniel P. Berrange
On Sun, Feb 20, 2011 at 10:29:26PM +0200, Dan Kenigsberg wrote: > Alas, the shell is not a real programming language. > > Patch generated by manual confirmation of vim's > s/[^"]\@<=\$\S\+\s\@=/"&"/gc > and > s/\(echo \)\@<=[^"].*\$.*$/"&"/c matches. > > This patch generate a lot of noise and car

Re: [libvirt] [PATCHv2 1/3] build: don't require pod2man for tarball builds

2011-02-21 Thread Daniel P. Berrange
On Fri, Feb 18, 2011 at 03:24:55PM -0700, Eric Blake wrote: > Right now, 'man libvirtd' includes information that depends on > configure results, so it must be generated on the fly and live > in $(builddir); however, requiring pod2man on all end user > machines is overkill. Meanwhile, 'man virsh'

Re: [libvirt] [PATCH] libxenlight driver

2011-02-21 Thread Daniel P. Berrange
On Thu, Feb 17, 2011 at 06:28:36PM -0700, Jim Fehlig wrote: > Here's the latest version of a libxenlight driver for libvirt. > > I've added a per-domain libxl_ctx in addition to the driver wide > context. The former is stored in virDomainObject privateData and used > for operations on the domain.

Re: [libvirt] [PATCH 1/8] Moved SEXPR unit to utils

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 02:40:06PM +0100, Markus Groß wrote: > --- > src/Makefile.am |2 +- > src/{xen => util}/sexpr.c |0 > src/{xen => util}/sexpr.h |0 > 3 files changed, 1 insertions(+), 1 deletions(-) > rename src/{xen => util}/sexpr.c (100%) > rename src/{xen => util

Re: [libvirt] [PATCH] protect the scsi controller to be deleted when it is in use

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 03:35:52PM +0800, Wen Congyang wrote: > Steps to reproduce this bug: > 1. virsh attach-disk domain --source imagefile --target sdb --sourcetype file > --driver qemu --subdriver raw > 2. virsh detach-device controller.xml # remove scsi controller 0 > 3. virsh detach-disk dom

Re: [libvirt] [PATCH 1/2] virt-pki-validate: behave when CERTTOOL is missing

2011-02-21 Thread Daniel P. Berrange
On Sun, Feb 20, 2011 at 10:29:25PM +0200, Dan Kenigsberg wrote: > --- > tools/virt-pki-validate.in |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/virt-pki-validate.in b/tools/virt-pki-validate.in > index 207fa76..96659cf 100755 > --- a/tools/virt-pki-validate

Re: [libvirt] [PATCH 2/8] Moved some SEXPR functions from xen-unified

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 02:40:07PM +0100, Markus Groß wrote: > --- > src/util/sexpr.c| 64 ++ > src/util/sexpr.h|6 > src/xen/xend_internal.c | 65 > --- > 3 files changed, 70 inse

Re: [libvirt] [PATCHv2 2/3] maint: fix 'make dist' in VPATH build

2011-02-21 Thread Daniel P. Berrange
On Fri, Feb 18, 2011 at 03:24:56PM -0700, Eric Blake wrote: > A diff of 'make dist' from in-tree vs. a VPATH build showed > that we were missing docs/api_extension/*.patch files, but > shipping other files that we didn't need. > > * bootstrap.conf (gnulib_extra_files): Don't distribute files we >

Re: [libvirt] [PATCH 3/8] Moved SEXPR parsing functions to xenxs

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 02:40:08PM +0100, Markus Groß wrote: > --- > po/POTFILES.in|1 + > src/Makefile.am | 13 + > src/xen/xen_driver.c | 12 +- > src/xen/xend_internal.c | 1329 +--- > src/xen/xend_internal.h | 18

Re: [libvirt] [PATCH 5/8] Moved XM parsing functions to xenxs

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 02:40:10PM +0100, Markus Groß wrote: > --- > po/POTFILES.in|1 + > src/Makefile.am |3 +- > src/xen/xen_driver.c |3 +- > src/xen/xm_internal.c | 976 +--- > src/xen/xm_internal.h |1

Re: [libvirt] [PATCH 4/8] Moved SEXPR formatting functions to xenxs

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 02:40:09PM +0100, Markus Groß wrote: > --- > src/xen/xend_internal.c | 876 > - > src/xen/xend_internal.h | 12 - > src/xenxs/xen_sxpr.c | 850 +++- > src/xenxs/xen_sxpr.h

Re: [libvirt] [PATCHv3 3/3] autobuild.sh: use VPATH build

2011-02-21 Thread Eric Blake
On 02/21/2011 10:03 AM, Daniel P. Berrange wrote: > On Fri, Feb 18, 2011 at 03:24:57PM -0700, Eric Blake wrote: >> Try to avoid future regressions on the VPATH front. >> >> * autobuild.sh: Uncomment VPATH use. >> * .gitignore: Exclude build directory. >> --- >> >> v2, not that much changed since: >

Re: [libvirt] [PATCH 6/8] Moved XM formatting functions to xenxs

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 02:40:11PM +0100, Markus Groß wrote: > --- > src/xen/xen_driver.c |2 +- > src/xen/xm_internal.c | 723 > + > src/xen/xm_internal.h |2 - > src/xenxs/xen_sxpr.h |6 - > src/xenxs/xen_xm.c|

Re: [libvirt] [PATCH 7/8] Renamed functions in xenxs

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 02:40:12PM +0100, Markus Groß wrote: > --- > src/xen/xen_driver.c|8 +- > src/xen/xend_internal.c | 54 +++--- > src/xen/xm_internal.c |6 +- > src/xenxs/xen_sxpr.c| 184 > +++ > src/xenxs/xen_sxpr.h

Re: [libvirt] [PATCH 2/2] virt-*-validate.in: quote all variable references

2011-02-21 Thread Eric Blake
On 02/20/2011 01:29 PM, Dan Kenigsberg wrote: > Alas, the shell is not a real programming language. > > Patch generated by manual confirmation of vim's > s/[^"]\@<=\$\S\+\s\@=/"&"/gc > and > s/\(echo \)\@<=[^"].*\$.*$/"&"/c matches. > > This patch generate a lot of noise and carries little benefi

[libvirt] [PATCH] maint: fix grammar in error message

2011-02-21 Thread Eric Blake
* python/tests/create.py: Use correct wording. --- Pushed under the trivial rule. python/tests/create.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python/tests/create.py b/python/tests/create.py index 4e5f644..95e31a9 100755 --- a/python/tests/create.py +++ b/py

[libvirt] open source with power devices

2011-02-21 Thread JamesTessier
Hi, I am Jim Tessier from Eaton Corporation. We are a major producer of UPSs and other data center power distribution equipment (and software). Eaton is developing an open-source presence and would like to become involved with libvert. Our software is currently compatible with MicroSoft SCVMM an

Re: [libvirt] [PATCH] protect the scsi controller to be deleted when it is in use

2011-02-21 Thread Eric Blake
On 02/21/2011 10:00 AM, Daniel P. Berrange wrote: > On Mon, Feb 21, 2011 at 03:35:52PM +0800, Wen Congyang wrote: >> Steps to reproduce this bug: >> 1. virsh attach-disk domain --source imagefile --target sdb --sourcetype >> file --driver qemu --subdriver raw >> 2. virsh detach-device controller.x

[libvirt] [PATCH] build: add dependency on gnutls-utils

2011-02-21 Thread Eric Blake
* libvirt.spec.in (Requires): Add gnutls-utils, for virt-pki-validate. Suggested by Daniel P. Berrange. --- > > -if [ ! -x $CERTOOL ] > > +if [ ! -x "$CERTOOL" ] > > then > > echo "Could not locate the certtool program" > > echo "make sure the gnutls-utils (or gnutls-bin) package is ins

Re: [libvirt] [PATCH 8/8] Added to AUTHORS

2011-02-21 Thread Eric Blake
On 02/21/2011 06:40 AM, Markus Groß wrote: > --- > AUTHORS |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Technically, for bisection purposes of 'make syntax-check', this should be squashed into patch 1/8. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization

Re: [libvirt] [PATCH 3/8] Moved SEXPR parsing functions to xenxs

2011-02-21 Thread Eric Blake
On 02/21/2011 10:19 AM, Daniel P. Berrange wrote: > On Mon, Feb 21, 2011 at 02:40:08PM +0100, Markus Groß wrote: >> +XENXS_SOURCES = \ >> +xenxs/xenxs_private.h \ >> +xenxs/xen_sxpr.c xenxs/xen_sxp

Re: [libvirt] [PATCH] build: add dependency on gnutls-utils

2011-02-21 Thread Daniel P. Berrange
On Mon, Feb 21, 2011 at 10:44:13AM -0700, Eric Blake wrote: > * libvirt.spec.in (Requires): Add gnutls-utils, for virt-pki-validate. > Suggested by Daniel P. Berrange. > --- > > > > -if [ ! -x $CERTOOL ] > > > +if [ ! -x "$CERTOOL" ] > > > then > > > echo "Could not locate the certtool progr

Re: [libvirt] [PATCH 4/8] Moved SEXPR formatting functions to xenxs

2011-02-21 Thread Eric Blake
On 02/21/2011 06:40 AM, Markus Groß wrote: > --- > src/xen/xend_internal.c | 876 > - > src/xen/xend_internal.h | 12 - > src/xenxs/xen_sxpr.c | 850 +++- > src/xenxs/xen_sxpr.h | 32 ++ > src/

Re: [libvirt] [PATCH 4/8] Moved SEXPR formatting functions to xenxs

2011-02-21 Thread Eric Blake
On 02/21/2011 11:01 AM, Eric Blake wrote: > On 02/21/2011 06:40 AM, Markus Groß wrote: >> --- >> src/xen/xend_internal.c | 876 >> - >> src/xen/xend_internal.h | 12 - >> src/xenxs/xen_sxpr.c | 850 >> ++

Re: [libvirt] [PATCH] build: add dependency on gnutls-utils

2011-02-21 Thread Eric Blake
On 02/21/2011 10:57 AM, Daniel P. Berrange wrote: > On Mon, Feb 21, 2011 at 10:44:13AM -0700, Eric Blake wrote: >> * libvirt.spec.in (Requires): Add gnutls-utils, for virt-pki-validate. >> Suggested by Daniel P. Berrange. >> +++ b/libvirt.spec.in >> @@ -418,6 +418,8 @@ Requires: ncurses >> Requir

Re: [libvirt] blkio cgroup

2011-02-21 Thread Vivek Goyal
On Mon, Feb 21, 2011 at 09:30:32AM +0100, Dominik Klein wrote: > On 02/21/2011 09:19 AM, Dominik Klein wrote: > >>> - Is it possible to capture 10-15 second blktrace on your underlying > >>> physical device. That should give me some idea what's happening. > >> > >> Will do, read on. > > > > Just

[libvirt] [PATCH] virExec: avoid uninitialized memory usage

2011-02-21 Thread Eric Blake
valgrind warns: ==21079== Syscall param rt_sigaction(act->sa_mask) points to uninitialised byte(s) ==21079==at 0x329840F63E: __libc_sigaction (sigaction.c:67) ==21079==by 0x4E5A8E7: __virExec (util.c:661) Regression introduced in commit ab07533e. Technically, sa_mask shouldn't affect op

Re: [libvirt] [PATCH 2/6] libvirt: Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and initialization

2011-02-21 Thread Eric Blake
On 02/21/2011 02:47 AM, Gui Jianfeng wrote: > Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and > initialization > > Signed-off-by: Gui Jianfeng > --- > src/driver.h | 14 ++ > src/esx/esx_driver.c |2 + > src/libvirt.c | 108

Re: [libvirt] [PATCH 3/6] qemu: Implement domainSetBlkioParamters and domainGetBlkioParamters for QEmu

2011-02-21 Thread Eric Blake
On 02/21/2011 02:24 AM, Gui Jianfeng wrote: > Implement domainSetBlkioParamters and domainGetBlkioParamters for QEmu > > Signed-off-by: Gui Jianfeng > --- > src/qemu/qemu_driver.c | 162 > +++- > 1 files changed, 160 insertions(+), 2 deletions(-) >

Re: [libvirt] [PATCH 5/6] remote-protocol: Remote protocol implementation of virDomainSetBlkioParameters and virDomainGetBlkioParameters.

2011-02-21 Thread Eric Blake
On 02/21/2011 02:28 AM, Gui Jianfeng wrote: > Remote protocol implementation of virDomainSetBlkioParameters and > virDomainGetBlkioParameters. > > Signed-off-by: Gui Jianfeng > --- > daemon/remote.c | 210 > +++ > daemon/remote_dispatch_args

Re: [libvirt] [PATCH 2/6] libvirt: Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and initialization

2011-02-21 Thread Eric Blake
On 02/21/2011 02:47 AM, Gui Jianfeng wrote: > Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and > initialization > > Signed-off-by: Gui Jianfeng > --- > src/driver.h | 14 ++ > src/esx/esx_driver.c |2 + > src/libvirt.c | 108

Re: [libvirt] [PATCH] storage: make debug log more useful

2011-02-21 Thread Eric Blake
On 02/21/2011 12:08 AM, Osier Yang wrote: > "__func__" should be replaced with "__FUNCTION__" instead for > better portability, Actually, __FUNCTION__ is gcc-specific, while __func__ is the more portable C99 construct (we #define __FUNCTION__ __func__ in internal.h, and rely on the gnulib module f

Re: [libvirt] [PATCH] virsh: replace vshPrint with vshPrintExtra for snapshot list

2011-02-21 Thread Eric Blake
On 02/20/2011 11:06 PM, Osier Yang wrote: > Otherwise extra information will be printed even if "--quiet" > is specified. > > * tools/virsh.c > --- > tools/virsh.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index ce275f1..2837

Re: [libvirt] [PATCH 1/6] libvirt: Add virDomainSetBlkioParameters virDomainGetBlkioParameters

2011-02-21 Thread Eric Blake
On 02/21/2011 02:21 AM, Gui Jianfeng wrote: > Add virDomainSetBlkioParameters virDomainGetBlkioParameters > > Signed-off-by: Gui Jianfeng > --- > .gnulib |2 +- That was unintended - it rewinds .gnulib backwards in time, which reintroduces some upstream gnulib bugs.

[libvirt] [PATCH] security: avoid memory leak

2011-02-21 Thread Eric Blake
Leak introduced in commit d6623003. * src/qemu/qemu_driver.c (qemuSecurityInit): Avoid leak on failure. * src/security/security_stack.c (virSecurityStackClose): Avoid leaking component drivers. --- src/qemu/qemu_driver.c|5 - src/security/security_stack.c |7 ++- 2 files c

Re: [libvirt] [PATCH] build: fix broken mingw cross-compilation

2011-02-21 Thread Eric Blake
On 02/20/2011 06:57 PM, Wen Congyang wrote: >> * configure.ac (devmapper): Arrange to define HAVE_LIBDEVMAPPER_H. >> devmapper issue reported by Wen Congyang. > > Currently, we need virIsDevMapperDevice() when we build libvirt with disk or > mpath storage drivers. > So we should check device-mapp

Re: [libvirt] [virt-tools-list] [RFC] virt-disk : a command line tool for modify domain XML's disk of inactive domains.

2011-02-21 Thread KAMEZAWA Hiroyuki
On Mon, 21 Feb 2011 10:08:46 -0500 Cole Robinson wrote: > On 02/21/2011 03:23 AM, KAMEZAWA Hiroyuki wrote: > > Hi, now, with qemu, virsh attach-disk doesn't work with inactive disks and > > we need to edit XML with virsh edit. > > IIUC, libvirt and virsh is designed as it is. > > > > But I want

Re: [libvirt] [virt-tools-list] [RFC] virt-disk : a command line tool for modify domain XML's disk of inactive domains.

2011-02-21 Thread KAMEZAWA Hiroyuki
On Mon, 21 Feb 2011 08:17:30 -0700 Eric Blake wrote: > On 02/21/2011 01:23 AM, KAMEZAWA Hiroyuki wrote: > > Hi, now, with qemu, virsh attach-disk doesn't work with inactive disks and > > we need to edit XML with virsh edit. > > IIUC, libvirt and virsh is designed as it is. > > Actually, libvirt

Re: [libvirt] [virt-tools-list] [RFC] virt-disk : a command line tool for modify domain XML's disk of inactive domains.

2011-02-21 Thread Eric Blake
On 02/21/2011 04:48 PM, KAMEZAWA Hiroyuki wrote: >>> What I wanted to hear opinions as 'RFC' is >>> - Can this be shipped with libvirt as one of a tool ? (with more documents) >>>(If so, we'll write other scripts for cpu,network,memory,etc...) What's wrong with directly patch libvirt's virsh

Re: [libvirt] [virt-tools-list] [RFC] virt-disk : a command line tool for modify domain XML's disk of inactive domains.

2011-02-21 Thread Eric Blake
On 02/21/2011 05:04 PM, KAMEZAWA Hiroyuki wrote: > On Mon, 21 Feb 2011 08:17:30 -0700 > Eric Blake wrote: > >> On 02/21/2011 01:23 AM, KAMEZAWA Hiroyuki wrote: >>> Hi, now, with qemu, virsh attach-disk doesn't work with inactive disks and >>> we need to edit XML with virsh edit. >>> IIUC, libvirt

Re: [libvirt] [virt-tools-list] [RFC] virt-disk : a command line tool for modify domain XML's disk of inactive domains.

2011-02-21 Thread Eric Blake
On 02/21/2011 05:20 PM, Eric Blake wrote: >> 1. When we asked "Is it a spec that we cannot modify inactive domain ?" to >>a Redhat guy, he answered "it's a spec". >>Do you, maintainers, have some concensus about this ? > > 'virsh attach-disk --persistent' is supposed to be able to modify a

[libvirt] [RFC PATCH 3/2] audit: audit qemu memory and vcpu adjusments

2011-02-21 Thread Eric Blake
* src/qemu/qemu_audit.h (qemuDomainMemoryAudit) (qemuDomainVcpuAudit): New prototypes. * src/qemu/qemu_audit.c (qemuDomainResourceAudit) (qemuDomainMemoryAudit, qemuDomainVcpuAudit): New functions. (qemuDomainStartAudit): Call as appropriate. * src/qemu/qemu_driver.c (qemudDomainSetMemory) (qemudDo

  1   2   >