Hello Jim,
Am Donnerstag 17 März 2011 21:11:34 schrieb Jim Fehlig:
Philipp Hahn wrote:
Today I encountered the bug again: virsh list was not showing any
domain, while virsh -c xen+unix:/// did show Domain 0 and my other
domain.
Are you using xen unstable or Xen 4.1 (i.e. something
Hi,
I've been investigating the virConnectDomainXMLToNative() format option
and I found out the virConnectDomainXMLToNative() calls the
conn-driver-domainXMLToNative() function and passes the format to the
driver function where the check whether format is valid or not is being
performed.
On Thu, Mar 17, 2011 at 02:26:36PM -0600, Alex Williamson wrote:
I'm proposing we make use of $PCIDIR/reset in qemu-kvm to reset
devices on VM reset. We need to add it to libvirt's list of
files that get ownership for device assignment.
What does access to the 'reset' file allow you todo ?
On Wed, Mar 16, 2011 at 06:29:30PM +0800, Hu Tao wrote:
virObject is a base struct that manages reference-counting. structs
that need the ability of reference-counting can inherit from
virObject and implement ref/unref interface easily.
The goal of this series is to make reference-counting
On Wed, Mar 16, 2011 at 06:29:52PM +0800, Hu Tao wrote:
virObject is the base struct that manages reference-counting
for all structs that need the ability of reference-counting.
---
src/Makefile.am |1 +
src/libvirt_private.syms |5
src/util/object.c| 55
On Wed, Mar 16, 2011 at 06:30:20PM +0800, Hu Tao wrote:
---
src/qemu/qemu_domain.c | 26 +---
src/qemu/qemu_monitor.c | 106 ++
src/qemu/qemu_monitor.h |4 +-
3 files changed, 64 insertions(+), 72 deletions(-)
diff --git
On Thu, Mar 17, 2011 at 09:17:58PM -0600, Jim Fehlig wrote:
diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c
index 7d08df3..bec9577 100644
--- a/src/xen/xen_driver.c
+++ b/src/xen/xen_driver.c
@@ -50,6 +50,7 @@
#include uuid.h
#include fdstream.h
#include files.h
+#include
On Fri, Mar 18, 2011 at 09:42:12AM +0100, Michal Novotny wrote:
Hi,
I've been investigating the virConnectDomainXMLToNative() format
option and I found out the virConnectDomainXMLToNative() calls the
conn-driver-domainXMLToNative() function and passes the format to
the driver function where
On 03/17/2011 08:17 PM, Daniel Veillard wrote:
+ for debugging purposes by sending the daemon an USR2 signal:/p
s/an USR2/a USR2/
BTW I'm clearly not a native english speaker, but a USR2 signal sounds
strange to me, or rather hard to pronounce, and I would have assumed that
an would
On Fri, 2011-03-18 at 10:18 +, Daniel P. Berrange wrote:
On Thu, Mar 17, 2011 at 02:26:36PM -0600, Alex Williamson wrote:
I'm proposing we make use of $PCIDIR/reset in qemu-kvm to reset
devices on VM reset. We need to add it to libvirt's list of
files that get ownership for device
This patch adds missing curly brackets to an if
statement in openvzListDefinedDomains()
---
src/openvz/openvz_driver.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c
index 0d64e19..7792136 100644
---
On Tue, Mar 15, 2011 at 09:53:40AM -0600, Eric Blake wrote:
On 03/15/2011 06:30 AM, Daniel P. Berrange wrote:
The O_NONBLOCK flag doesn't work as desired on plain files
or block devices. Introduce an I/O helper program that does
the blocking I/O operations, communicating over a pipe that
On Tue, Mar 15, 2011 at 10:37:01AM -0600, Eric Blake wrote:
On 03/15/2011 06:30 AM, Daniel P. Berrange wrote:
New APIs are added allowing streaming of content to/from
storage volumes. A new API for creating volumes is also
added allowing the content to be provided immediately at
time of
The ref count was assigned to 1 at creation, then never modified again
until it was decremented just before freeing the object.
* src/conf/domain_conf.h (_virDomainSnapshotObj): Delete unused
field.
(virDomainSnapshotObjUnref): Delete unused prototype.
* src/libvirt_private.syms: Likewise.
*
On 03/17/2011 01:30 PM, Eric Blake wrote:
+++ b/src/util/hash.c
@@ -35,6 +35,12 @@
/* #define DEBUG_GROW */
+#define virHashIterationError(ret) \
+do {\
+VIR_ERROR0(_(Hash
On 03/18/2011 08:59 AM, Jean-Baptiste Rouault wrote:
This patch adds missing curly brackets to an if
statement in openvzListDefinedDomains()
---
src/openvz/openvz_driver.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/openvz/openvz_driver.c
On 03/17/2011 06:07 PM, Daniel P. Berrange wrote:
On Thu, Mar 17, 2011 at 12:55:50PM -0400, Laine Stump wrote:
On 03/17/2011 10:38 AM, Michal Privoznik wrote:
---
src/conf/domain_conf.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c
Daniel P. Berrange wrote:
On Thu, Mar 17, 2011 at 09:17:58PM -0600, Jim Fehlig wrote:
diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c
index 7d08df3..bec9577 100644
--- a/src/xen/xen_driver.c
+++ b/src/xen/xen_driver.c
@@ -50,6 +50,7 @@
#include uuid.h
#include fdstream.h
Add src/util/hash.c to po/POTFILES.in since it now has
translatable strings.
---
po/POTFILES.in |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 4bd2b13..805e5ca 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -91,6 +91,7 @@
On 03/18/2011 10:08 AM, Jim Fehlig wrote:
Add src/util/hash.c to po/POTFILES.in since it now has
translatable strings.
---
po/POTFILES.in |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 4bd2b13..805e5ca 100644
---
On Fri, Mar 18, 2011 at 04:45:17PM +0100, Michal Prívozník wrote:
On 03/17/2011 06:07 PM, Daniel P. Berrange wrote:
On Thu, Mar 17, 2011 at 12:55:50PM -0400, Laine Stump wrote:
On 03/17/2011 10:38 AM, Michal Privoznik wrote:
---
src/conf/domain_conf.c | 11 ---
1 files changed,
On 03/18/2011 10:13 AM, Daniel P. Berrange wrote:
I am not completely convinced this is what we want. If domain has
exactly one NIC, device-detach semantic is clear. Or if we want to
allow detaching interface by PCI address - MAC shouldn't be
required, because it is redundant.
You're
On Tue, Mar 15, 2011 at 11:07:53AM -0600, Eric Blake wrote:
On 03/15/2011 06:30 AM, Daniel P. Berrange wrote:
* tools/virsh.c: Add vol-create-upload, vol-upload
and vol-download commands
---
.x-sc_avoid_write |1 +
tools/virsh.c | 225
On Tue, Mar 15, 2011 at 01:09:09PM -0600, Eric Blake wrote:
On 03/15/2011 06:30 AM, Daniel P. Berrange wrote:
* daemon/remote.c, src/remote/remote_driver.c: Implementation
of storage vol upload/download APIs
* src/remote/remote_protocol.x: Wire protocol definition for
upload/download
An update of
http://www.redhat.com/archives/libvir-list/2011-March/msg00655.html
Addressing all the feedback from v1 series. The most notable change is that
'iohelper' now takes an explicit flags+mode parameter, instead of the operation
name.
--
libvir-list mailing list
libvir-list@redhat.com
qemuDomainSetMemoryParameters and qemuDomainGetMemoryParameters
forgot to do a check on virDomainIsActive(), resulting in bogus
error messages from later parts of their impl
* src/qemu/qemu_driver.c: Add missing checks on virDomainIsActive()
---
src/qemu/qemu_driver.c | 12
1
* tools/virsh.c: Add vol-create-upload, vol-upload
and vol-download commands
---
tools/virsh.c | 218 +
1 files changed, 218 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 50ca50f..e30d39c 100644
---
The daemon loops over the linked list of streams when a client
quits, closing any that the client hadn't already closed. Except
it didn't ever move to the next element in the list!
* daemon/stream.c: Fix loop over linked list of streams
---
daemon/stream.c |1 +
1 files changed, 1
On Fri, Mar 18, 2011 at 10:28:34AM -0600, Eric Blake wrote:
On 03/18/2011 10:13 AM, Daniel P. Berrange wrote:
I am not completely convinced this is what we want. If domain has
exactly one NIC, device-detach semantic is clear. Or if we want to
allow detaching interface by PCI address - MAC
* src/storage/storage_driver.c: Wire up upload/download APIs
---
src/storage/storage_driver.c | 133 +-
1 files changed, 131 insertions(+), 2 deletions(-)
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index ce528cf..706db74
* daemon/remote.c, src/remote/remote_driver.c: Implementation
of storage vol upload/download APIs
* src/remote/remote_protocol.x: Wire protocol definition for
upload/download
* daemon/remote_dispatch_args.h, daemon/remote_dispatch_prototypes.h,
daemon/remote_dispatch_table.h,
On 03/18/2011 10:47 AM, Daniel P. Berrange wrote:
The xen RPM in Fedora isn't new enough to support libxl builds
yet. Disable it until Fedora 16
Q: What actually is the min required Xen ? Is xen 4.0.1
in fact sufficient ? If so I'll change this to s/16/15/
* libvirt.spec.in: Disable libxl
This is detailed in:
https://bugzilla.redhat.com/show_bug.cgi?id=688957
Since radvd is executed by daemonizing it, the attempt to exec the
radvd binary doesn't happen until after libvirtd has already received
an exit code from the intermediate forked process, so no error is
detected or logged
On 03/18/2011 11:08 AM, Laine Stump wrote:
This is detailed in:
https://bugzilla.redhat.com/show_bug.cgi?id=688957
Since radvd is executed by daemonizing it, the attempt to exec the
radvd binary doesn't happen until after libvirtd has already received
an exit code from the intermediate
Daniel P. Berrange wrote:
The xen RPM in Fedora isn't new enough to support libxl builds
yet. Disable it until Fedora 16
Q: What actually is the min required Xen ? Is xen 4.0.1
in fact sufficient ? If so I'll change this to s/16/15/
Xen 4.0.x contains some tech preview libxenlight bits,
The next patch will change reference counting idioms; consolidating
this pattern now makes the next patch smaller (touch only the new
macro rather than every caller).
* src/qemu/qemu_monitor.c (QEMU_MONITOR_CALLBACK): New helper.
(qemuMonitorGetDiskSecret, qemuMonitorEmitShutdown)
Add the compiler attribute to ensure we don't introduce any more
ref bugs like were just patched in commit 9741f34, then explicitly
mark the remaining places in code that are safe.
* src/qemu/qemu_monitor.h (qemuMonitorUnref): Mark
ATTRIBUTE_RETURN_CHECK.
* src/conf/domain_conf.h
On 03/18/2011 11:36 AM, Jim Fehlig wrote:
Daniel P. Berrange wrote:
The xen RPM in Fedora isn't new enough to support libxl builds
yet. Disable it until Fedora 16
Q: What actually is the min required Xen ? Is xen 4.0.1
in fact sufficient ? If so I'll change this to s/16/15/
Xen 4.0.x
Eric Blake wrote:
On 03/18/2011 11:36 AM, Jim Fehlig wrote:
Daniel P. Berrange wrote:
The xen RPM in Fedora isn't new enough to support libxl builds
yet. Disable it until Fedora 16
Q: What actually is the min required Xen ? Is xen 4.0.1
in fact sufficient ? If so I'll change this
On Mon, Mar 14, 2011 at 08:38:09PM -0600, Eric Blake wrote:
THREADS.txt states that the contents of vm should not be read or
modified while the vm lock is not held, but that the lock must not
be held while performing a monitor command. This fixes all the
offenders that I could find.
*
On Tue, Mar 15, 2011 at 01:34:53PM -0600, Eric Blake wrote:
On 03/15/2011 11:51 AM, Daniel P. Berrange wrote:
This provides a new struct that contains a buffer for the RPC
message header+payload, as well as a decoded copy of the message
header. There is an API for applying a XDR encoding
On Tue, Mar 15, 2011 at 03:23:38PM -0600, Eric Blake wrote:
On 03/15/2011 11:51 AM, Daniel P. Berrange wrote:
+#ifndef WIN32
+static int virNetSocketForkDaemon(const char *binary)
+{
+int ret;
+virCommandPtr cmd = virCommandNewArgList(binary,
+
On Tue, Mar 15, 2011 at 04:34:33PM -0600, Eric Blake wrote:
On 03/15/2011 11:51 AM, Daniel P. Berrange wrote:
This provides two modules for handling TLS
* virNetTLSContext provides the process-wide state, in particular
all the x509 credentials, DH params and x509 whitelists
*
This provides two modules for handling TLS
* virNetTLSContext provides the process-wide state, in particular
all the x509 credentials, DH params and x509 whitelists
* virNetTLSSession provides the per-connection state, ie the
TLS session itself.
The virNetTLSContext provides APIs for
Introduces a simple wrapper around the raw POSIX sockets APIs
and name resolution APIs. Allows for easy creation of client
and server sockets with correct usage of name resolution APIs
for protocol agnostic socket setup.
It can listen for UNIX and TCP stream sockets.
It can connect to UNIX, TCP
This is an update of the series posted
http://www.redhat.com/archives/libvir-list/2011-March/msg00686.html
Since that time
- Include the missing first patch and missing last patch
- Incorporate review feedback for first 3 patches.
- Fix copyright year and free-functions on all other
This patch defines the basics of a generic RPC protocol in XDR.
This is wire ABI compatible with the original remote_protocol.x.
It takes everything except for the RPC calls / events from that
protocol
- The basic header virNetMessageHeader (aka remote_message_header)
- The error object
This provides a new struct that contains a buffer for the RPC
message header+payload, as well as a decoded copy of the message
header. There is an API for applying a XDR encoding decoding
of the message headers and payloads. There are also APIs for
maintaining a simple FIFO queue of message
Add a test case which validates the RPC message encoding decoding
to/from XDR representation. Covers the core message header, the
error class and streams.
* testutils.c, testutils.h: Helper for printing binary differences
* virnetmessagetest.c: Validate all XDR encoding/decoding
---
A variant on the old remote_generate_stubs.pl which can generate
generic stubs for RPC dispatch
* src/rpc/gendispatch.pl: A script for generating RPC dispatchers
---
src/Makefile.am|4 +
src/rpc/gendispatch.pl | 232
2 files changed,
Allow RPC servers to advertize themselves using MDNS,
via Avahi
* src/rpc/virnetserver.c, src/rpc/virnetserver.h: Allow
registration of MDNS services via avahi
* src/rpc/virnetserverservice.c, src/rpc/virnetserverservice.h: Add
API to fetch the listen port number
* src/rpc/virnetsocket.c,
Start of a trivial test case for the socket APIs. Only tests
simple server setup client connect for UNIX sockets so far
* tests/Makefile.am: Add socket test
* tests/virnetsockettest.c: New test case
* tests/testutils.c: Avoid overriding LIBVIRT_DEBUG settings
* tests/ssh.c: Dumb helper program
On 03/18/2011 01:16 PM, Eric Blake wrote:
On 03/18/2011 11:08 AM, Laine Stump wrote:
This is detailed in:
https://bugzilla.redhat.com/show_bug.cgi?id=688957
Since radvd is executed by daemonizing it, the attempt to exec the
radvd binary doesn't happen until after libvirtd has already
On 03/18/2011 12:55 PM, Laine Stump wrote:
+if (access(RADVD, X_OK) 0) {
Hmm, should this use
if (!virFileIsExecutable(RADVD)) {
instead? Then again, I count 10 instances of 'access.*X_OK', but only 5
of FileIsExecutable, so maybe it's worth a separate cleanup (and a
cfg.mk rule to
On 03/18/2011 12:11 PM, Daniel P. Berrange wrote:
On Mon, Mar 14, 2011 at 08:38:09PM -0600, Eric Blake wrote:
THREADS.txt states that the contents of vm should not be read or
modified while the vm lock is not held, but that the lock must not
be held while performing a monitor command. This
If virFileIsExecutable is to replace access(file,X_OK), then
errno must be usable on failure.
* src/util/util.c (virFileIsExecutable): Set errno on failure.
---
src/util/util.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/util/util.c b/src/util/util.c
This simplifies several callers that were repeating checks already
guaranteed by util.c, and makes other callers more robust to now
reject directories. remote_driver.c was over-strict - access(,X_OK)
is not strictly needed to execute a file (although its unusual to see
a file with X_OK but not
On 03/18/2011 03:06 PM, Jim Fehlig wrote:
The libxenlight driver does not build against the tech preview
version of libxenlight in Xen 4.0. Only enable building the
driver against more complete libxenlight found in Xen 4.1.
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1
Eric Blake wrote:
On 03/18/2011 03:06 PM, Jim Fehlig wrote:
The libxenlight driver does not build against the tech preview
version of libxenlight in Xen 4.0. Only enable building the
driver against more complete libxenlight found in Xen 4.1.
---
configure.ac |2 +-
1 files
* .gnulib: Update to latest.
---
I plan to squash this in, to avoid more cases like this where
Jirka's VPATH build skipped a syntax-check:
https://www.redhat.com/archives/libvir-list/2011-March/msg00870.html
* .gnulib 0baae9c...a01e7c4 (1):
maint.mk: let po check work in VPATH build
.gnulib
On 03/11/2011 08:39 AM, Laine Stump wrote:
path, mode);
goto childerror;
}
-if (flags VIR_FILE_OP_RETURN_FD) {
+{
VIR_FORCE_CLOSE(pair[0]);
This VIR_FORCE_CLOSE(pair[0]) should be moved up to the very start of
the child
61 matches
Mail list logo
