Re: [libvirt] [PATCH 0/5] RFC: configure inactive domains' maximum memory size

2011-03-22 Thread Taku Izumi
Daniel, Eric, Wen, Thank you for reviewing. I'll respin according to Daniel's point. Thank you. Taku Izumi -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php] add get name and path for storage volume

2011-03-22 Thread Michal Novotny
On 03/22/2011 05:11 AM, Lyre wrote: --- src/libvirt.c | 44 src/libvirt_php.h |2 ++ 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 1608774..3678974 100644 --- a/src/libvirt.c +++

Re: [libvirt] [PATCH 3/3] Wire up virDomainMigrateSetSpeed into QEMU driver

2011-03-22 Thread Daniel P. Berrange
On Mon, Mar 21, 2011 at 12:07:12PM -0600, Eric Blake wrote: On 03/21/2011 10:13 AM, Daniel P. Berrange wrote: Enhance the QEMU migration monitoring loop, so that it can get a signal to change migration speed on the fly * src/qemu/qemu_domain.h: Add signal for changing speed on the fly

Re: [libvirt] CPU compare and baseline

2011-03-22 Thread Daniel P. Berrange
On Mon, Mar 21, 2011 at 06:34:40PM +0100, Edouard Thuleau wrote: Hi, I try to understand the compare and baseline CPU commands with libvirt. This functions are useful for the migration ? Before migrate a domain to other host, libvirt verifies the CPU compatibility, that's right ? I've got

Re: [libvirt] [PATCH 2/3] Wire up virDomainMigrateSetSpeed for the remote RPC driver

2011-03-22 Thread Daniel P. Berrange
On Mon, Mar 21, 2011 at 12:04:33PM -0600, Eric Blake wrote: On 03/21/2011 10:13 AM, Daniel P. Berrange wrote: * src/remote/remote_protocol.x: Define wire protocol * daemon/remote.c, src/remote/remote_driver.c: Add new functions for virDomainMigrateSetSpeed API *

[libvirt] [PATCH 1/6] Enhance the streams helper to support plain file I/O

2011-03-22 Thread Daniel P. Berrange
The O_NONBLOCK flag doesn't work as desired on plain files or block devices. Introduce an I/O helper program that does the blocking I/O operations, communicating over a pipe that can support O_NONBLOCK * src/fdstream.c, src/fdstream.h: Add non-blocking I/O on plain files/block devices *

Re: [libvirt] [PATCH 0/6] v2: Allow data upload/download to/from storage volumes

2011-03-22 Thread Daniel P. Berrange
On Mon, Mar 21, 2011 at 03:39:28PM -0600, Eric Blake wrote: On 03/18/2011 10:36 AM, Daniel P. Berrange wrote: An update of http://www.redhat.com/archives/libvir-list/2011-March/msg00655.html Addressing all the feedback from v1 series. The most notable change is that 'iohelper' now

Re: [libvirt] [PATCH 2/6] Add public APIs for storage volume upload/download

2011-03-22 Thread Daniel P. Berrange
On Mon, Mar 21, 2011 at 03:04:39PM -0600, Eric Blake wrote: On 03/18/2011 10:36 AM, Daniel P. Berrange wrote: New APIs are added allowing streaming of content to/from storage volumes. A new API for creating volumes is also added allowing the content to be provided immediately at time of

Re: [libvirt] [PATCH 3/6] Add vol-create-upload, vol-upload and vol-download commands to virsh

2011-03-22 Thread Daniel P. Berrange
On Mon, Mar 21, 2011 at 03:23:24PM -0600, Eric Blake wrote: On 03/18/2011 10:36 AM, Daniel P. Berrange wrote: * tools/virsh.c: Add vol-create-upload, vol-upload and vol-download commands Another stale commit message. s/vol-create-upload, // +static int +cmdVolUpload (vshControl

Re: [libvirt] [PATCH] qemu: add two hook script events prepare and release

2011-03-22 Thread Daniel Veillard
On Tue, Mar 22, 2011 at 11:47:03AM +0100, Thibault VINCENT wrote: On 22/03/2011 10:59, Daniel Veillard wrote: On Mon, Mar 21, 2011 at 10:36:55AM +0100, Thibault VINCENT wrote: From 827261dbe2ab8f1cfd8c84df14bb42fd04df2307 Mon Sep 17 00:00:00 2001 From: Thibault VINCENT

Re: [libvirt] CPU compare and baseline

2011-03-22 Thread Jiri Denemark
On Mon, Mar 21, 2011 at 18:34:40 +0100, Edouard Thuleau wrote: Hi, I try to understand the compare and baseline CPU commands with libvirt. This functions are useful for the migration ? Before migrate a domain to other host, libvirt verifies the CPU compatibility, that's right ? Right. *$

Re: [libvirt] [PATCH v2 0/3] qemu: fallback to HMP drive_add/drive_del

2011-03-22 Thread Jiri Denemark
On Mon, Mar 21, 2011 at 13:52:35 +0100, Jiri Denemark wrote: Version 2: - provide nicer errors when human-monitor-command is not available Hu Tao (1): qemu: fallback to HMP drive_add/drive_del Jiri Denemark (2): qemu: Detect support for HMP passthrough qemu: Only use HMP

Re: [libvirt] [PATCH 2/6] Add public APIs for storage volume upload/download

2011-03-22 Thread Eric Blake
On 03/22/2011 05:45 AM, Daniel P. Berrange wrote: What happens if the stream hits EOF before all data read from the volume has been written to the stream? Should the API support a way to tell how many bytes were successfully downloaded in the case of a short stream? That is, instead of

Re: [libvirt] [PATCH 2/6] Add public APIs for storage volume upload/download

2011-03-22 Thread Daniel P. Berrange
On Tue, Mar 22, 2011 at 08:22:05AM -0600, Eric Blake wrote: On 03/22/2011 05:45 AM, Daniel P. Berrange wrote: What happens if the stream hits EOF before all data read from the volume has been written to the stream? Should the API support a way to tell how many bytes were successfully

Re: [libvirt] [PATCH 1/3] Add public API for setting migration speed on the fly

2011-03-22 Thread Daniel Veillard
On Tue, Mar 22, 2011 at 11:01:31AM +, Daniel P. Berrange wrote: On Mon, Mar 21, 2011 at 11:55:58AM -0600, Eric Blake wrote: On 03/21/2011 10:13 AM, Daniel P. Berrange wrote: It is possible to set a migration speed limit when starting migration. This new API allows the speed limit to

Re: [libvirt] [PATCH] Fix uninitialized variable error reporting in LXC veth setup

2011-03-22 Thread Daniel Veillard
On Mon, Mar 21, 2011 at 03:36:30PM +, Daniel P. Berrange wrote: On Thu, Mar 17, 2011 at 12:46:55PM -0400, Laine Stump wrote: On 03/17/2011 11:57 AM, Daniel P. Berrange wrote: THe veth setup in LXC had a couple of flaws, first brInit did not report any error when it failed. Second

Re: [libvirt] CPU compare and baseline

2011-03-22 Thread Edouard Thuleau
Thanks for your help. Ok, I didn't understand how to use cpu-baseline, it's not clear in the help command. So cpu-baseline give me the CPU XML file I need to use to be able to migrate between two hosts but how I use this XML file ? Another question, why Libvirt consider CPUs with non-matching

Re: [libvirt] [PATCH 1/6] Enhance the streams helper to support plain file I/O

2011-03-22 Thread Eric Blake
On 03/22/2011 05:29 AM, Daniel P. Berrange wrote: The O_NONBLOCK flag doesn't work as desired on plain files or block devices. Introduce an I/O helper program that does the blocking I/O operations, communicating over a pipe that can support O_NONBLOCK * src/fdstream.c, src/fdstream.h: Add

Re: [libvirt] [PATCH RFC] Remove the Open Nebula driver

2011-03-22 Thread Laine Stump
On 03/22/2011 12:23 PM, Daniel P. Berrange wrote: The Open Nebula driver has been unmaintained since it was first introduced. The only commits have been for tree-wide cleanups. It also has a major design flaw, in that it only knows about guests that it has created itself, which makes it of very

Re: [libvirt] [PATCH RFC] Remove the Open Nebula driver

2011-03-22 Thread Eric Blake
On 03/22/2011 10:23 AM, Daniel P. Berrange wrote: The Open Nebula driver has been unmaintained since it was first introduced. The only commits have been for tree-wide cleanups. It also has a major design flaw, in that it only knows about guests that it has created itself, which makes it of

Re: [libvirt] [PATCH] 8021Qbh: use preassociate-rr during the migration prepare stage

2011-03-22 Thread Stefan Berger
On 03/22/2011 03:03 PM, Roopa Prabhu wrote: From: Roopa Prabhuropra...@cisco.com This patch introduces PREASSOCIATE-RR during incoming VM migration on the destination host. This is similar to the usage of PREASSOCIATE during migration in 8021qbg libvirt code today. PREASSOCIATE-RR is a VDP

Re: [libvirt] [PATCH] 8021Qbh: use preassociate-rr during the migration prepare stage

2011-03-22 Thread Stefan Berger
On 03/22/2011 03:15 PM, Stefan Berger wrote: On 03/22/2011 03:03 PM, Roopa Prabhu wrote: From: Roopa Prabhuropra...@cisco.com This patch introduces PREASSOCIATE-RR during incoming VM migration on the destination host. This is similar to the usage of PREASSOCIATE during migration in 8021qbg

[libvirt] [PATCH] qemu: Fix -chardev udp if parameters are omitted

2011-03-22 Thread Cole Robinson
The following XML: serial type='udp' source mode='connect' service=''/ /serial is accepted by domain_conf.c but maps to the qemu command line: -chardev udp,host=127.0.0.1,port=,localaddr=(null),localport=(null) qemu can cope with everything omitting except the connection

[libvirt] [PATCH] build: fix missing initializer

2011-03-22 Thread Eric Blake
Commit cb4aba9b6 forgot xenapi. * src/xenapi/xenapi_driver.c (xenapiDriver): Adjust to recent API. --- Pushing under the build-breaker rule. src/xenapi/xenapi_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/xenapi/xenapi_driver.c

[libvirt] [PATCH 1/2] build: fix driver module build

2011-03-22 Thread Eric Blake
* src/libvirt_xenxs.syms: New file. * src/Makefile.am (USED_SYM_FILES, EXTRA_DIST): Add new file. * src/libvirt_private.syms (domain_conf.h): Add missing exports. * tests/Makefile.am (xml2sexprtest_LDADD, sexpr2xmltest_LDADD) (xmconfigtest_LDADD, xencapstest_LDADD): Add missing library. (LDADDS):

[libvirt] [PATCH 0/2] improve driver module building

2011-03-22 Thread Eric Blake
This comment: https://www.redhat.com/archives/libvir-list/2011-March/msg00899.html No change to src/libvirt_private.syms to list all these new functions? Nothing required this (yet) made me double check behavior of ./autogen.sh --with-driver-modules, and sure enough, things were broken.

[libvirt] [PATCH 2/2] build: let autobuild check module build

2011-03-22 Thread Eric Blake
Many times, we don't notice a bug in src/libvirt_private.syms until someone attempts a build with modules enabled. Having autobuild.sh stress that can only help. * autobuild.sh: Add test of --with-driver-modules. Update mingw build to skip recent driver additions. --- autobuild.sh | 10

Re: [libvirt] [PATCH] qemu: Fix -chardev udp if parameters are omitted

2011-03-22 Thread Eric Blake
On 03/22/2011 02:36 PM, Cole Robinson wrote: The following XML: serial type='udp' source mode='connect' service=''/ /serial is accepted by domain_conf.c but maps to the qemu command line: -chardev udp,host=127.0.0.1,port=,localaddr=(null),localport=(null) qemu

[libvirt] [PATCH 3/1] command: add virCommandAbort for cleanup paths

2011-03-22 Thread Eric Blake
Sometimes, an asynchronous helper is started (such as a compressor or iohelper program), but a later error means that we want to abort that child. Make this easier. * src/util/command.h (virCommandAbort): New prototype. * src/util/command.c (_virCommand): Add new field. (virCommandRunAsync,

[libvirt] [PATCH 2/1] command: reject pidfile on non-daemon

2011-03-22 Thread Eric Blake
* src/util/command.c (virCommandRunAsync): Since virExec only creates pidfiles for daemon, enforce this in virCommand. --- src/util/command.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/util/command.c b/src/util/command.c index 89f82c7..7b4337f 100644 ---

Re: [libvirt] [PATCH 03/12] Introduce a generic object for using network sockets

2011-03-22 Thread Eric Blake
On 03/18/2011 12:54 PM, Daniel P. Berrange wrote: Introduces a simple wrapper around the raw POSIX sockets APIs and name resolution APIs. Allows for easy creation of client and server sockets with correct usage of name resolution APIs for protocol agnostic socket setup. +int

Re: [libvirt] [PATCH 1/2] qemu: simplify monitor callbacks

2011-03-22 Thread Eric Blake
On 03/19/2011 08:06 AM, Matthias Bolte wrote: 2011/3/18 Eric Blake ebl...@redhat.com: The next patch will change reference counting idioms; consolidating this pattern now makes the next patch smaller (touch only the new macro rather than every caller). * src/qemu/qemu_monitor.c

Re: [libvirt] [PATCH 07/12] Introduce generic RPC server objects

2011-03-22 Thread Eric Blake
On 03/18/2011 12:54 PM, Daniel P. Berrange wrote: To facilitate creation of new daemons providing XDR RPC services, pull alot of the libvirtd daemon code into a set of reusable objects. Continuing my review... +virNetServerPtr virNetServerNew(size_t min_workers, +

Re: [libvirt] [PATCH v2 0/3] qemu: fallback to HMP drive_add/drive_del

2011-03-22 Thread Hu Tao
On Tue, Mar 22, 2011 at 03:08:19PM +0100, Jiri Denemark wrote: On Mon, Mar 21, 2011 at 13:52:35 +0100, Jiri Denemark wrote: Version 2: - provide nicer errors when human-monitor-command is not available Hu Tao (1): qemu: fallback to HMP drive_add/drive_del Jiri Denemark (2):

[libvirt] [PATCH] Initialization error of qemuCgroupData in Qemu host usb hotplug

2011-03-22 Thread Wen Congyang
Steps to reproduce this bug: # cat usb.xml hostdev mode='subsystem' type='usb' source address bus='0x001' device='0x003'/ /source /hostdev # virsh attach-device vm1 usb.xml error: Failed to attach device from usb.xml error: server closed connection: The reason of this bug is that we set

Re: [libvirt] [PATCHv5 1/3] libivrt/qemu - support persistent modification of devices

2011-03-22 Thread KAMEZAWA Hiroyuki
On Mon, 21 Mar 2011 14:38:08 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/16/2011 02:38 PM, KAMEZAWA Hiroyuki Write: Thank you for review and feedbacks. This is v5 onto the latest git tree. Any comments are welcome. == From ef85d268a0b553cdb784a1d1916ff8cf171adace Mon Sep 17

Re: [libvirt] [PATCHv5 2/3] libvirt/qemu - support persistent modification of qemu disks

2011-03-22 Thread KAMEZAWA Hiroyuki
On Mon, 21 Mar 2011 16:05:19 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/16/2011 02:45 PM, KAMEZAWA Hiroyuki Write: From ddcd9cb499dd73dfc91c9f2cc97c064d6dda17fc Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Wed, 16 Mar 2011 14:05:21 +0900

Re: [libvirt] [PATCHv5 3/3] libvirt/qemu - support support persistent modification of qemu interfaces

2011-03-22 Thread KAMEZAWA Hiroyuki
On Mon, 21 Mar 2011 16:48:23 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/16/2011 02:46 PM, KAMEZAWA Hiroyuki Write: From d69f7c07571c8adfc7720aab77aa1f103eb6e95b Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Wed, 16 Mar 2011 15:39:14 +0900

Re: [libvirt] [PATCHv5 2/3] libvirt/qemu - support persistent modification of qemu disks

2011-03-22 Thread Wen Congyang
At 03/23/2011 12:39 PM, KAMEZAWA Hiroyuki Write: On Mon, 21 Mar 2011 16:05:19 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/16/2011 02:45 PM, KAMEZAWA Hiroyuki Write: From ddcd9cb499dd73dfc91c9f2cc97c064d6dda17fc Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki

Re: [libvirt] [PATCHv5 2/3] libvirt/qemu - support persistent modification of qemu disks

2011-03-22 Thread KAMEZAWA Hiroyuki
On Wed, 23 Mar 2011 13:15:39 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/23/2011 12:39 PM, KAMEZAWA Hiroyuki Write: On Mon, 21 Mar 2011 16:05:19 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/16/2011 02:45 PM, KAMEZAWA Hiroyuki Write: From

Re: [libvirt] [PATCHv5 2/3] libvirt/qemu - support persistent modification of qemu disks

2011-03-22 Thread Wen Congyang
At 03/23/2011 01:22 PM, KAMEZAWA Hiroyuki Write: On Wed, 23 Mar 2011 13:15:39 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/23/2011 12:39 PM, KAMEZAWA Hiroyuki Write: On Mon, 21 Mar 2011 16:05:19 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/16/2011 02:45 PM, KAMEZAWA

[libvirt] [PATCH 0/3] setmem: add --current option to virsh setmem command

2011-03-22 Thread Taku Izumi
Hi all, This patchset adds --current option to virsh setmem command. This is based on the discussion at http://www.redhat.com/archives/libvir-list/2011-March/msg00564.html *[PATCH 1/3] setmem: introduce VIR_DOMAIN_MEM_CURRENT flag *[PATCH 2/3] setmem: add

[libvirt] [PATCH 3/3] setmem: add --current option to virsh setmem command

2011-03-22 Thread Taku Izumi
This patch adds the new option (--current) to the virsh setmem command. When --current option is specified, it affects a current domain. The word current denotes that if a domain is running, it affects a running domain only; otherwise it affects a persistent domain. Signed-off-by: Taku Izumi

[libvirt] [PATCH 1/3] setmem: introduce VIR_DOMAIN_MEM_CURRENT flag

2011-03-22 Thread Taku Izumi
This patch introduces VIR_DOMAIN_MEM_CURRENT flag and modifies virDomainSetMemoryFlags function to support it. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- include/libvirt/libvirt.h.in |1 + src/libvirt.c| 13 +++-- 2 files changed, 8 insertions(+), 6

[libvirt] [PATCH 2/3] setmem: add virDomainSetMemroyFlags(, , VIR_DOMAIN_MEM_CURRENT) support to qemu driver

2011-03-22 Thread Taku Izumi
This patch adds virDomainSetMemroyFlags(,,VIR_DOMAIN_MEM_CURRENT) support code to qemu driver. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- src/qemu/qemu_driver.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) Index: libvirt/src/qemu/qemu_driver.c