Re: [libvirt] [PATCH] update domain status forcibly even if attach a device failed

2011-03-24 Thread Wen Congyang
At 03/24/2011 03:26 AM, Eric Blake Write: On 02/17/2011 02:09 PM, Eric Blake wrote: On 02/16/2011 08:32 PM, Wen Congyang wrote: Steps to reproduce this bug: 1. virsh attach-disk domain --source diskimage --target sdb --sourcetype file --driver qemu --subdriver qcow2 error: Failed to

[libvirt] [PATCH] Don't allow two or more disks to be mapped to the same image file

2011-03-24 Thread Hu Tao
If two or more disks are mapped to the same image file, operating on these disks at the same time may corrupt data stored in the image file. --- src/conf/domain_conf.c | 22 ++ src/conf/domain_conf.h |2 ++ src/libvirt_private.syms |1 + src/qemu/qemu_driver.c

Re: [libvirt] [PATCH] Don't allow two or more disks to be mapped to the same image file

2011-03-24 Thread Wen Congyang
At 03/24/2011 03:02 PM, Hu Tao Write: If two or more disks are mapped to the same image file, operating on these disks at the same time may corrupt data stored in the image file. If two disks are mapped to the same image and these two disks are read only, operating on these two disks at the

Re: [libvirt] [PATCHv6 2/3] libvirt/qemu - support persistent modification of qemu disks

2011-03-24 Thread Wen Congyang
At 03/24/2011 09:31 AM, KAMEZAWA Hiroyuki Write: From 1d2630896a950b87043c9e77fdbcdc23626098ee Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Thu, 24 Mar 2011 10:05:18 +0900 Subject: [PATCHv6 2/3] libvirt/qemu - support persistent modification of qemu

Re: [libvirt] [PATCHv6 3/3] libvirt/qemu - support persistent modification of qemu nics.

2011-03-24 Thread Wen Congyang
At 03/24/2011 09:33 AM, KAMEZAWA Hiroyuki Write: From fa4ecbfabe3ec0bcf120bedf20583a2045430f65 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Thu, 24 Mar 2011 10:26:56 +0900 Subject: [PATCHv6 3/3] libvirt/qemu - support persistent modification of qemu

Re: [libvirt] [PATCHv6 2/3] libvirt/qemu - support persistent modification of qemu disks

2011-03-24 Thread KAMEZAWA Hiroyuki
On Thu, 24 Mar 2011 15:44:05 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/24/2011 09:31 AM, KAMEZAWA Hiroyuki Write: From 1d2630896a950b87043c9e77fdbcdc23626098ee Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Thu, 24 Mar 2011 10:05:18 +0900

Re: [libvirt] [PATCH] Make error reporting in libvirtd thread safe

2011-03-24 Thread Jiri Denemark
On Wed, Mar 23, 2011 at 11:01:32 -0600, Eric Blake wrote: diff --git a/daemon/remote.c b/daemon/remote.c index a8fef4d..4b42ed2 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -757,8 +757,8 @@ remoteDispatchDomainGetSchedulerType (struct qemud_server *server ATTRIBUTE_UNUS

[libvirt] [PATCHv2] Don't allow two or more disks to be mapped to the same image file

2011-03-24 Thread Hu Tao
If two or more disks are mapped to the same image file, operating on these disks at the same time may corrupt data stored in the image file. changes: v2: - allow it for read-only disks - compare source files by inode number --- src/conf/domain_conf.c | 54

Re: [libvirt] [PATCHv6 2/3] libvirt/qemu - support persistent modification of qemu disks

2011-03-24 Thread Wen Congyang
At 03/24/2011 04:35 PM, KAMEZAWA Hiroyuki Write: On Thu, 24 Mar 2011 15:44:05 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/24/2011 09:31 AM, KAMEZAWA Hiroyuki Write: From 1d2630896a950b87043c9e77fdbcdc23626098ee Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki

Re: [libvirt] [PATCHv6 2/3] libvirt/qemu - support persistent modification of qemu disks

2011-03-24 Thread KAMEZAWA Hiroyuki
On Thu, 24 Mar 2011 17:35:19 +0900 KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com wrote: On Thu, 24 Mar 2011 15:44:05 +0800 Wen Congyang we...@cn.fujitsu.com wrote: Do not report error when qemuDomainAssignPCIAddresses() or virDomainDefAddImplicitControllers() failed, because we have

[libvirt] [PATCH] fix the check of the output of monitor command 'device_add'

2011-03-24 Thread Wen Congyang
Hotpluging host usb device by text mode will fail, because the monitor command 'device_add' outputs 'husb: using...' if it succeeds, but we think the command should not output anything. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- src/qemu/qemu_monitor_text.c | 10 +- 1 files

Re: [libvirt] [PATCHv6 2/3] libvirt/qemu - support persistent modification of qemu disks

2011-03-24 Thread KAMEZAWA Hiroyuki
On Thu, 24 Mar 2011 16:49:29 +0800 Wen Congyang we...@cn.fujitsu.com wrote: Sometimes, qemuDomainAssignPCIAddress() failed, and it does not report error. qemuDomainAssignPCIAddress() calls qemuDomainPCIAddressSetCreate() that calls virDomainDeviceInfoIterate() that calls

Re: [libvirt] [PATCH 4/8] Add memory functions to libxl driver

2011-03-24 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_driver.c | 131 -- 1 files changed, 127 insertions(+), 4 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 49fc90f..32bf12e 100644 --- a/src/libxl/libxl_driver.c +++

[libvirt] Update on the goal page, patch and discussion

2011-03-24 Thread Daniel Veillard
It is a patch but beyond the unevitable spelling errors it contains I would appreciate some feedback on the content, which also defines the limits of the project. Some significant things to note in the diff below: - we do extend libvirt scope beyond purely managing domains, there is

Re: [libvirt] [PATCHv2] Don't allow two or more disks to be mapped to the same image file

2011-03-24 Thread Nathan Baum
On Thu, 24 Mar 2011 16:46:14 +0800 Hu Tao hu...@cn.fujitsu.com wrote: If two or more disks are mapped to the same image file, operating on these disks at the same time may corrupt data stored in the image file. changes: v2: - allow it for read-only disks - compare source files by

[libvirt] [PATCH] Add support for DNS TXT records

2011-03-24 Thread Michal Novotny
Hi, this is the patch to add DNS TXT record support to libvirt networking driver since this is feature that's supported by DNSMasq that's being used by the bridge driver. Maybe you fail to understand the reasons why to implement such a feature however it's a good thing IMHO since user could

Re: [libvirt] [PATCH 5/8] Add domainXMLFromNative/domainXMLToNative to libxl driver

2011-03-24 Thread Jim Fehlig
Markus Groß wrote: --- configure.ac |2 + daemon/Makefile.am |3 + src/Makefile.am |8 ++- src/libxl/libxl_driver.c | 94 +- 4 files changed, 102 insertions(+), 5 deletions(-) diff --git a/configure.ac

Re: [libvirt] [PATCH 6/8] Add domainGetSchedulerType to libxl driver

2011-03-24 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_driver.c | 64 +- 1 files changed, 63 insertions(+), 1 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index b05cd77..c72a570 100644 --- a/src/libxl/libxl_driver.c +++

Re: [libvirt] [PATCH 7/8] Add domainGetOSType to libxl driver

2011-03-24 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_driver.c | 29 - 1 files changed, 28 insertions(+), 1 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index c72a570..4b31197 100644 --- a/src/libxl/libxl_driver.c +++

Re: [libvirt] [PATCH] fix the check of the output of monitor command 'device_add'

2011-03-24 Thread Eric Blake
On 03/24/2011 02:56 AM, Wen Congyang wrote: Hotpluging host usb device by text mode will fail, because the monitor command 'device_add' outputs 'husb: using...' if it succeeds, but we think the command should not output anything. Signed-off-by: Wen Congyang we...@cn.fujitsu.com ---

Re: [libvirt] [PATCH 8/8] Add domainSuspend/Resume to libxl driver

2011-03-24 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_driver.c | 114 +- 1 files changed, 112 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 4b31197..669c170 100644 --- a/src/libxl/libxl_driver.c +++

Re: [libvirt] [PATCH 1/8] Add event callbacks to libxl driver

2011-03-24 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_conf.h |8 ++- src/libxl/libxl_driver.c | 199 +- 2 files changed, 202 insertions(+), 5 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index bb49d35..a86df9a 100644 ---

[libvirt] What about Trusted Virtual Domains???

2011-03-24 Thread Paolo Smiraglia
Hi guys... I need an opinion from the Libvirt community about the development of a new possible Libvirt feature: the Trusted Virtual Domains (TVD). Conceptually, a TVD can be compared to a mix of Virtual Private Network (VPN) and Virtual LAN (VLAN). My idea is to define a new Libvirt entity

[libvirt] cgroup memoryinfo handling

2011-03-24 Thread Zvi Dubitzky
Hi 1) Daniel Smith of IBM wrote (2008) code for implementing 'virsh schedinfo' in src/util/cgroup.c He also added some code for cgroup memory subsystem (util/cgroup.c/ virCgroupSetMemoryHardLimit () etc.), I see also src/qemu_driver.c/qemuDomainSetMemoryParameters() But that

Re: [libvirt] cgroup memoryinfo handling

2011-03-24 Thread Eric Blake
On 03/24/2011 12:04 PM, Zvi Dubitzky wrote: Hi 1) Daniel Smith of IBM wrote (2008) code for implementing 'virsh schedinfo' in src/util/cgroup.c He also added some code for cgroup memory subsystem (util/cgroup.c/ virCgroupSetMemoryHardLimit () etc.), I see also

Re: [libvirt] [PATCH 2/8] Get cpu time and current memory balloon from libxl

2011-03-24 Thread Jim Fehlig
Jim Fehlig wrote: Markus Groß wrote: --- src/libxl/libxl_driver.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index ad95e2b..7ee3930 100644 --- a/src/libxl/libxl_driver.c +++

Re: [libvirt] [PATCH 2/2] maint: prohibit access(,X_OK)

2011-03-24 Thread Laine Stump
I noticed you hadn't committed this yet, so I came back to take a look... On 03/18/2011 04:46 PM, Eric Blake wrote: This simplifies several callers that were repeating checks already guaranteed by util.c, and makes other callers more robust to now reject directories. remote_driver.c was

Re: [libvirt] [PATCH 2/2] build: enforce reference count checking

2011-03-24 Thread Laine Stump
On 03/18/2011 01:37 PM, Eric Blake wrote: Add the compiler attribute to ensure we don't introduce any more ref bugs like were just patched in commit 9741f34, then explicitly mark the remaining places in code that are safe. * src/qemu/qemu_monitor.h (qemuMonitorUnref): Mark

[libvirt] ANNOUNCE: virt-manager 0.8.7 and virtinst 0.500.6 released

2011-03-24 Thread Cole Robinson
I'm happy to announce two new releases: virt-manager 0.8.7: virt-manager is a desktop application for managing KVM and Xen virtual machines via libvirt. virtinst 0.500.6: virtinst is a collection of command line tools for provisioning libvirt virtual machines, including virt-install and

Re: [libvirt] [PATCH 2/2] maint: prohibit access(,X_OK)

2011-03-24 Thread Eric Blake
On 03/24/2011 02:28 PM, Laine Stump wrote: I noticed you hadn't committed this yet, so I came back to take a look... On 03/18/2011 04:46 PM, Eric Blake wrote: This simplifies several callers that were repeating checks already guaranteed by util.c, and makes other callers more robust to now

Re: [libvirt] [PATCH 2/2] build: enforce reference count checking

2011-03-24 Thread Eric Blake
On 03/24/2011 02:43 PM, Laine Stump wrote: On 03/18/2011 01:37 PM, Eric Blake wrote: Add the compiler attribute to ensure we don't introduce any more ref bugs like were just patched in commit 9741f34, then explicitly mark the remaining places in code that are safe. * src/qemu/qemu_monitor.h

Re: [libvirt] [PATCHv2] Don't allow two or more disks to be mapped to the same image file

2011-03-24 Thread Eric Blake
On 03/24/2011 02:46 AM, Hu Tao wrote: If two or more disks are mapped to the same image file, operating on these disks at the same time may corrupt data stored in the image file. changes: v2: - allow it for read-only disks - compare source files by inode number + +if

Re: [libvirt] cgroup memoryinfo handling

2011-03-24 Thread Zvi Dubitzky
As per the 'virsh memtune' how are the items :hard_limit, soft_limit, min_guarantee mapped to the items mentioned in RedHat 'Resource Manangement Guide' , such as : memory.limit_in_bytesetc. thanks Zvi Dubitzky Email:d...@il.ibm.com Eric Blake ebl...@redhat.com wrote on

Re: [libvirt] cgroup memoryinfo handling

2011-03-24 Thread Eric Blake
On 03/24/2011 04:09 PM, Zvi Dubitzky wrote: As per the 'virsh memtune' how are the items :hard_limit, soft_limit, min_guarantee mapped to the items mentioned in RedHat 'Resource Manangement Guide' , such as : memory.limit_in_bytesetc. Specific support questions are probably best

Re: [libvirt] [PATCH 1/6] Enhance the streams helper to support plain file I/O

2011-03-24 Thread Eric Blake
On 03/23/2011 11:36 AM, Daniel P. Berrange wrote: The O_NONBLOCK flag doesn't work as desired on plain files or block devices. Introduce an I/O helper program that does the blocking I/O operations, communicating over a pipe that can support O_NONBLOCK * src/fdstream.c, src/fdstream.h: Add

Re: [libvirt] [PATCH 2/6] Add public APIs for storage volume upload/download

2011-03-24 Thread Eric Blake
On 03/23/2011 11:36 AM, Daniel P. Berrange wrote: New APIs are added allowing streaming of content to/from storage volumes. * include/libvirt/libvirt.h.in: Add virStorageVolUpload and virStorageVolDownload APIs * src/driver.h, src/libvirt.c, src/libvirt_public.syms: Stub code for new

Re: [libvirt] [PATCH 3/6] Add vol-upload and vol-download commands to virsh

2011-03-24 Thread Eric Blake
On 03/23/2011 11:36 AM, Daniel P. Berrange wrote: The new commands vol-upload and vol-download, allow a local file to be transferred to/from a storage volume. * tools/virsh.c: Add vol-upload and vol-download commands --- tools/virsh.c | 230

Re: [libvirt] [PATCH 4/6] Support volume data upload/download APIs in storage driver

2011-03-24 Thread Eric Blake
On 03/23/2011 11:36 AM, Daniel P. Berrange wrote: Use generic FD streams to allow data upload/download to/from any storage volume * src/storage/storage_driver.c: Wire up upload/download APIs --- src/storage/storage_driver.c | 132 +- 1 files

Re: [libvirt] [PATCHv2] Don't allow two or more disks to be mapped to the same image file

2011-03-24 Thread Josh Durgin
On 03/24/2011 02:45 PM, Eric Blake wrote: On 03/24/2011 02:46 AM, Hu Tao wrote: If two or more disks are mapped to the same image file, operating on these disks at the same time may corrupt data stored in the image file. changes: v2: - allow it for read-only disks - compare source files

Re: [libvirt] [PATCH 5/6] Remote protocol support for storage vol upload/download APIs

2011-03-24 Thread Eric Blake
On 03/23/2011 11:36 AM, Daniel P. Berrange wrote: * daemon/remote.c, src/remote/remote_driver.c: Implementation of storage vol upload/download APIs * src/remote/remote_protocol.x: Wire protocol definition for upload/download * daemon/remote_dispatch_args.h,

Re: [libvirt] [PATCH RFC] Remove the Open Nebula driver

2011-03-24 Thread Daniel Veillard
On Wed, Mar 23, 2011 at 11:30:35PM +0100, Ruben S. Montero wrote: Hi, Thanks for the headup. We totally agree with the reasoning in the thread. In fact, the last version of OpenNebula is not compatible with the libvirt driver. We planned to propose the removal of the OpenNebula driver, and

Re: [libvirt] [PATCHv2 2/3] command: don't mix RunAsync and daemons

2011-03-24 Thread Daniel Veillard
On Wed, Mar 23, 2011 at 05:48:12PM -0600, Eric Blake wrote: It doesn't make sense to run a daemon without synchronously waiting for the child process to reply whether the daemon has been kicked off and pidfile written yet. * src/util/command.c (VIR_EXEC_RUN_SYNC): New constant.

Re: [libvirt] [PATCHv2 3/3] command: add virCommandAbort for cleanup paths

2011-03-24 Thread Daniel Veillard
On Wed, Mar 23, 2011 at 05:48:13PM -0600, Eric Blake wrote: Sometimes, an asynchronous helper is started (such as a compressor or iohelper program), but a later error means that we want to abort that child. Make this easier. Note that since daemons and virCommandRunAsync can't mix, the only

Re: [libvirt] [PATCH] fix the check of the output of monitor command 'device_add'

2011-03-24 Thread Wen Congyang
At 03/24/2011 11:25 PM, Eric Blake Write: On 03/24/2011 02:56 AM, Wen Congyang wrote: Hotpluging host usb device by text mode will fail, because the monitor command 'device_add' outputs 'husb: using...' if it succeeds, but we think the command should not output anything. Signed-off-by: Wen

[libvirt] About to enter freeze for 0.9.0, on Monday

2011-03-24 Thread Daniel Veillard
As posted previously I was thinking of entering freeze today, but we have a number of patchsets which are relatively advanced but don't have a final version, like Dan's patches and support of persistent device by Kame. So I suggest to extend the development Friday and over the week-end if needed