[libvirt] Entering 0.9.0 freeze week, RC1 version to test

2011-03-28 Thread Daniel Veillard
Okay, I pushed new localization updates around and generated a first release candidate build for 0.9.0 at: ftp://libvirt.org/libvirt/libvirt-0.9.0-rc1.tar.gz I will regenerate a rc2 as soon as Eric pending patch queue and outgoing fd patches are in as I think they should really make 0.9.0

Re: [libvirt] [PATCH 1/8] Add event callbacks to libxl driver

2011-03-28 Thread Markus Groß
Am Donnerstag 24 März 2011 17:24:26 schrieb Jim Fehlig: Markus Groß wrote: @@ -225,6 +284,9 @@ static void libxlEventHandler(int watch, switch (info.shutdown_reason) { case SHUTDOWN_poweroff: case SHUTDOWN_crash: +dom_event =

[libvirt] [PATCH 0/3] reattach pci devices when qemuPrepareHostdevPCIDevices() failed

2011-03-28 Thread Wen Congyang
When I try to attach a pci device to guest OS, libvirtd resets the pci failed. But I can not use this pci device after attaching pci device failed. I must rollback the operation by hand. I think libvirtd should auto rollback the operation when it failed. Wen Congyang (3): remove devices from

[libvirt] [PATCH 2/3] reattach pci device when pciBindDeviceToStub() failed

2011-03-28 Thread Wen Congyang
We should bind pci device to original driver when pciBindDeviceToStub() failed. If the pci device is not bound to any driver before calling pciBindDeviceToStub(), we should only unbind it from pci-stub. If it is bound to pci-stub, we should not unbid it from pci-stub. --- src/util/pci.c | 90

[libvirt] [PATCH 1/3] remove devices from driver-activePciHostdevs when qemuPrepareHostdevPCIDevices() failed

2011-03-28 Thread Wen Congyang
We should not mark pci devices as active when qemuPrepareHostdevPCIDevices() failed. --- src/qemu/qemu_hostdev.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index f4b2108..30db0e2 100644 ---

[libvirt] [PATCH 3/3] reattach pci devices when qemuPrepareHostdevPCIDevices() failed

2011-03-28 Thread Wen Congyang
Reattach all pci devices that we detached when qemuPrepareHostdevPCIDevices() failed. --- src/qemu/qemu_hostdev.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 30db0e2..7f5ad51 100644 ---

Re: [libvirt] [PATCH 3/8] Add vcpu functions to libxl driver

2011-03-28 Thread Markus Groß
Am Mittwoch 23 März 2011 17:59:11 schrieb Jim Fehlig: Markus Groß wrote: +maplen = (unsigned int) ceil((double) nvcpus / 8); +if (VIR_ALLOC_N(bitmask, maplen) 0) { +virReportOOMError(); +goto cleanup; +} + +memset(bitmask, 0, maplen); +for (i =

Re: [libvirt] [PATCH 6/8] Add domainGetSchedulerType to libxl driver

2011-03-28 Thread Markus Groß
Am Donnerstag 24 März 2011 15:48:20 schrieb Jim Fehlig: Markus Groß wrote: --- src/libxl/libxl_driver.c | 64 +- 1 files changed, 63 insertions(+), 1 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index

Re: [libvirt] Entering 0.9.0 freeze week, RC1 version to test

2011-03-28 Thread Matthias Bolte
2011/3/28 Daniel Veillard veill...@redhat.com:  Okay, I pushed new localization updates around and generated a first release candidate build for 0.9.0 at:  ftp://libvirt.org/libvirt/libvirt-0.9.0-rc1.tar.gz I will regenerate a rc2 as soon as Eric pending patch queue and outgoing fd patches

Re: [libvirt] [PATCH 8/8] Add domainSuspend/Resume to libxl driver

2011-03-28 Thread Markus Groß
Am Donnerstag 24 März 2011 16:55:23 schrieb Jim Fehlig: Markus Groß wrote: --- src/libxl/libxl_driver.c | 114 +- 1 files changed, 112 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index

[libvirt] [PATCH 0/2] Log enhancement

2011-03-28 Thread Naoya Horiguchi
Hi, Following patches improve logging feature of libvirt. Please see individual patches for more details. [PATCH 1/2] extend logging to record configuration-related events on host machine [PATCH 2/2] qemu: extend logging to record guest configuration events Thanks, Naoya Horiguchi --

[libvirt] [PATCH 1/2] extend logging to record configuration-related events on host machine

2011-03-28 Thread Naoya Horiguchi
Currently libvirt's logging is so poor that it's difficult to determine what was happening when a proglem occurred (especially on someone's machines you don't know the detail.) This patch helps us to do that by making additional logging available for the following events:

[libvirt] [PATCH 2/2] qemu: extend logging to record guest configuration events

2011-03-28 Thread Naoya Horiguchi
The following events can be logged onto /var/log/libvirt/qemu/domain.log: starting/shutting down/suspending/resuming/migrating domains changing the amount of memory changing the number of VCPUs inserting/ejecting a media into/from CDROM/Floppy devices attaching/detaching PCI/SCSI/USB

[libvirt] [PATCHv2 6/8] Add domainGetSchedulerType to libxl driver

2011-03-28 Thread Markus Groß
--- src/libxl/libxl_driver.c | 64 +- 1 files changed, 63 insertions(+), 1 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 7d83975..1a70f79 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@

[libvirt] [PATCHv2 1/8] Ignore return value of virDomainObjUnref

2011-03-28 Thread Markus Groß
--- src/libxl/libxl_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index b8b8ee8..80a43a0 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -107,7 +107,7 @@ libxlDomainObjUnref(void

[libvirt] [PATCHv2 3/8] List authors in copyright headers

2011-03-28 Thread Markus Groß
--- src/libxl/libxl_conf.c |3 +++ src/libxl/libxl_conf.h |3 +++ src/libxl/libxl_driver.c |6 ++ src/libxl/libxl_driver.h |3 +++ 4 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 9dc35fc..5054422 100644

[libvirt] [PATCHv2 0/8] Additional functionality for libxl driver

2011-03-28 Thread Markus Groß
This series of patches adds new functionality to the libxl driver. V2: - Incorporated review from Jim Fehlig - Allow domainGetSchedulerType only on active domains - Fix warnings about virDomainObjUnref Markus Groß (8): Ignore return value of virDomainObjUnref Add event callbacks to libxl

[libvirt] [PATCHv2 2/8] Add event callbacks to libxl driver

2011-03-28 Thread Markus Groß
--- src/libxl/libxl_conf.h |8 ++- src/libxl/libxl_driver.c | 194 +- 2 files changed, 197 insertions(+), 5 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index bb49d35..a86df9a 100644 --- a/src/libxl/libxl_conf.h +++

[libvirt] [PATCHv2 8/8] Add domainSuspend/Resume to libxl driver

2011-03-28 Thread Markus Groß
--- src/libxl/libxl_driver.c | 122 +- 1 files changed, 120 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 47b7e56..3409340 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@

[libvirt] [PATCHv2 4/8] Add vcpu functions to libxl driver

2011-03-28 Thread Markus Groß
--- src/libxl/libxl_driver.c | 310 +- 1 files changed, 305 insertions(+), 5 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index aa135dd..3251e66 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@

[libvirt] [PATCHv2 7/8] Add domainGetOSType to libxl driver

2011-03-28 Thread Markus Groß
--- src/libxl/libxl_driver.c | 29 - 1 files changed, 28 insertions(+), 1 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 1a70f79..47b7e56 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -1174,6 +1174,33 @@

[libvirt] [PATCHv2 5/8] Add domainXMLFromNative/domainXMLToNative to libxl driver

2011-03-28 Thread Markus Groß
--- configure.ac |2 + daemon/Makefile.am |3 + src/Makefile.am |8 ++- src/libxl/libxl_driver.c | 94 +- 4 files changed, 102 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [libvirt] [libvirt-php] Add volume clone support

2011-03-28 Thread Michal Novotny
Hi Lyre, I'm having some (inline) comments to consider... - struct _virDomainMemoryStat stats[VIR_DOMAIN_MEMORY_STAT_NR]; + + struct _virDomainMemoryStat stats[VIR_DOMAIN_MEMORY_STAT_NR] = + { + {VIR_DOMAIN_MEMORY_STAT_SWAP_IN, 0}, +

Re: [libvirt] [libvirt-php] Add lookup function for pool volume

2011-03-28 Thread Michal Novotny
Hi Lyre, + set_error (Cannot find storage pool TSRMLS_CC); This is being set by the function itself and caught using the catch_error() so please avoid this line in v2 of the patch. + volume=virStorageVolLookupByPath (conn-conn,name); + if (volume==NULL) + { +

Re: [libvirt] Entering 0.9.0 freeze week, RC1 version to test

2011-03-28 Thread Diego Elio Pettenò
Il giorno lun, 28/03/2011 alle 14.25 +0800, Daniel Veillard ha scritto: thanks for giving it a try, it seems to work fine here at least for basic tasks, All looks fine in Gentoo, now it's in testing, will report if I hit any issue. -- Diego Elio Pettenò — Flameeyes

Re: [libvirt] [PATCH 5/8] Add domainXMLFromNative/domainXMLToNative to libxl driver

2011-03-28 Thread Daniel P. Berrange
On Thu, Mar 24, 2011 at 08:23:06AM -0600, Jim Fehlig wrote: Markus Groß wrote: --- configure.ac |2 + daemon/Makefile.am |3 + src/Makefile.am |8 ++- src/libxl/libxl_driver.c | 94 +- 4 files

Re: [libvirt] [PATCH 1/8] Add event callbacks to libxl driver

2011-03-28 Thread Markus Groß
Am Montag 28 März 2011 11:26:15 schrieb Daniel P. Berrange: On Thu, Mar 24, 2011 at 10:24:26AM -0600, Jim Fehlig wrote: Markus Groß wrote: --- src/libxl/libxl_conf.h |8 ++- src/libxl/libxl_driver.c | 199 +- 2 files changed,

Re: [libvirt] [PATCHv2 0/8] Additional functionality for libxl driver

2011-03-28 Thread Daniel Veillard
On Mon, Mar 28, 2011 at 10:32:47AM +0200, Markus Groß wrote: This series of patches adds new functionality to the libxl driver. V2: - Incorporated review from Jim Fehlig - Allow domainGetSchedulerType only on active domains - Fix warnings about virDomainObjUnref Markus Groß (8):

Re: [libvirt] [PATCHv2 5/8] Add domainXMLFromNative/domainXMLToNative to libxl driver

2011-03-28 Thread Markus Groß
I reworked this patch according to Daniel's comments in https://www.redhat.com/archives/libvir-list/2011-March/msg01272.html Find the new version below. --- configure.ac |2 + src/Makefile.am | 10 +++-- src/libvirt_private.syms | 16

Re: [libvirt] Entering 0.9.0 freeze week, RC1 version to test

2011-03-28 Thread Osier Yang
于 2011年03月28日 14:25, Daniel Veillard 写道: Okay, I pushed new localization updates around and generated a first release candidate build for 0.9.0 at: ftp://libvirt.org/libvirt/libvirt-0.9.0-rc1.tar.gz I will regenerate a rc2 as soon as Eric pending patch queue and outgoing fd patches are

Re: [libvirt] [libvirt-php] Add volume clone support

2011-03-28 Thread Lyre
于 2011年03月28日 17:19, Michal Novotny 写道: Hi Lyre, I'm having some (inline) comments to consider... - struct _virDomainMemoryStat stats[VIR_DOMAIN_MEMORY_STAT_NR]; + + struct _virDomainMemoryStat stats[VIR_DOMAIN_MEMORY_STAT_NR] = + { +

Re: [libvirt] [libvirt-php] Add volume clone support

2011-03-28 Thread Michal Novotny
[snip] Hi Michal: Sorry about that, I didn't noticed the error handling mechanism in libvirt before. I've been overloaded these days. And I'll resent those patches. t Hi Lyre, that's fine. Everybody is doing mistakes or overlooks something some time. Nothing happened, I just noticed you

Re: [libvirt] Entering 0.9.0 freeze week, RC1 version to test

2011-03-28 Thread Daniel Veillard
On Mon, Mar 28, 2011 at 06:12:29PM +0800, Osier Yang wrote: 于 2011年03月28日 14:25, Daniel Veillard 写道: Okay, I pushed new localization updates around and generated a first release candidate build for 0.9.0 at: ftp://libvirt.org/libvirt/libvirt-0.9.0-rc1.tar.gz I will regenerate a rc2

Re: [libvirt] Entering 0.9.0 freeze week, RC1 version to test

2011-03-28 Thread Osier Yang
于 2011年03月28日 18:41, Daniel Veillard 写道: On Mon, Mar 28, 2011 at 06:12:29PM +0800, Osier Yang wrote: 于 2011年03月28日 14:25, Daniel Veillard 写道: Okay, I pushed new localization updates around and generated a first release candidate build for 0.9.0 at:

[libvirt] [PATCH] Add autostart support to libxl driver

2011-03-28 Thread Markus Groß
This patch is rebased against the patchset from here: https://www.redhat.com/archives/libvir-list/2011-March/msg01260.html The domainSetAutostart function is nearly identical to the one from qemu. --- src/libxl/libxl_driver.c | 137 -- 1 files

[libvirt] [libvirt-php PATCH v2 3/4] Volume: add clone support

2011-03-28 Thread Lyre
New API: libvirt_storagevolume_create_xml_from() It may need some asynchronous mechanism to use this fuction, since it may taks a long long time. --- src/libvirt-php.c | 42 ++ src/libvirt-php.h |1 + 2 files changed, 43 insertions(+), 0 deletions(-)

[libvirt] [libvirt-php PATCH v2 2/4] Storagepool: make flag for pool refresh optional

2011-03-28 Thread Lyre
--- src/libvirt-php.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index b43da7a..4835e59 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -3058,7 +3058,7 @@ PHP_FUNCTION(libvirt_storagepool_refresh) zval *zpool;

[libvirt] [libvirt-php PATCH v2 0/4] new API for storage

2011-03-28 Thread Lyre
Hi all: Those patches fixed some minor mistakes, and added 3 functions for storage. Lyre (4): Comment: fix typo Storagepool: make flag for pool refresh optional Volume: add clone support Storage: add lookup functions src/libvirt-php.c | 110

[libvirt] [libvirt-php PATCH v2 1/4] Comment: fix typo

2011-03-28 Thread Lyre
--- src/libvirt-php.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 890b447..b43da7a 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -2704,7 +2704,7 @@ PHP_FUNCTION(libvirt_storagevolume_get_name) } /* -

[libvirt] [libvirt-php PATCH v2 4/4] Storage: add lookup functions

2011-03-28 Thread Lyre
--- src/libvirt-php.c | 64 + src/libvirt-php.h |2 + 2 files changed, 66 insertions(+), 0 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 6e8dea8..6ca7c50 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@

[libvirt] access with VNC and graphic interface

2011-03-28 Thread Kenneth Nagin
libvirt provides vnc to access the VMs under its control. However, I can not get applications with graphical interface to run when I use vnc to access a VM. The same applications will display properly if I ssh -X to the VM. Is there anyway to overcome this problem? Best Regards, Kenneth Nagin

Re: [libvirt] [libvirt-php PATCH v2 0/4] new API for storage

2011-03-28 Thread Michal Novotny
On 03/28/2011 01:06 PM, Lyre wrote: Hi all: Those patches fixed some minor mistakes, and added 3 functions for storage. Lyre (4): Comment: fix typo Storagepool: make flag for pool refresh optional Volume: add clone support Storage: add lookup functions src/libvirt-php.c

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-28 Thread Michal Novotny
Hi Laine, thanks for your reply. Comments inline... On 03/25/2011 10:02 PM, Laine Stump wrote: I haven't had time yet to look at the code in detail, but thought I should send this preliminary commentary. On 03/24/2011 09:58 AM, Michal Novotny wrote: Hi, this is the patch to add DNS TXT

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-28 Thread Michal Novotny
[snip] Is this really necessary? We're not talking about a shell commandline here, but an array of null terminated strings. If it's a restriction placed by dnsmasq itself, then we should just disallow ' ' during parsing rather than silently changing it, to avoid surprises. Well, I've

Re: [libvirt] [PATCH RFC] Remove the Open Nebula driver

2011-03-28 Thread Daniel P. Berrange
On Wed, Mar 23, 2011 at 03:22:12PM +0800, Daniel Veillard wrote: On Tue, Mar 22, 2011 at 02:08:00PM -0400, Laine Stump wrote: On 03/22/2011 12:23 PM, Daniel P. Berrange wrote: The Open Nebula driver has been unmaintained since it was first introduced. The only commits have been for

Re: [libvirt] access with VNC and graphic interface

2011-03-28 Thread Zdenek Styblik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/28/11 13:10, Kenneth Nagin wrote: libvirt provides vnc to access the VMs under its control. However, I can not get applications with graphical interface to run when I use vnc to access a VM. The same applications will display properly if I

Re: [libvirt] [PATCH RFC] Remove the Open Nebula driver

2011-03-28 Thread Daniel Veillard
On Mon, Mar 28, 2011 at 01:11:04PM +0100, Daniel P. Berrange wrote: On Wed, Mar 23, 2011 at 03:22:12PM +0800, Daniel Veillard wrote: On Tue, Mar 22, 2011 at 02:08:00PM -0400, Laine Stump wrote: On 03/22/2011 12:23 PM, Daniel P. Berrange wrote: The Open Nebula driver has been unmaintained

Re: [libvirt] Entering 0.9.0 freeze week, RC1 version to test

2011-03-28 Thread Daniel Veillard
On Mon, Mar 28, 2011 at 11:25:51AM +0200, Diego Elio Pettenò wrote: Il giorno lun, 28/03/2011 alle 14.25 +0800, Daniel Veillard ha scritto: thanks for giving it a try, it seems to work fine here at least for basic tasks, All looks fine in Gentoo, now it's in testing, will report

Re: [libvirt] [PATCHv5 00/13] outgoing fd: migration and virFileOpenAs

2011-03-28 Thread Daniel Veillard
On Sat, Mar 26, 2011 at 06:52:29AM -0600, Eric Blake wrote: This addresses the comments raised during v4: https://www.redhat.com/archives/libvir-list/2011-March/msg00421.html More comments in individual patches. It could still use a bit more testing with root-squash NFS, and I'm also

Re: [libvirt] [PATCH] Reserve first 3 PCI slots for hardcoded devices

2011-03-28 Thread Daniel P. Berrange
On Fri, Mar 25, 2011 at 07:47:45PM +0100, Philipp Hahn wrote: If a domain is initially created without a vidoe device but with other devices (like interface), PCI device slots normally reserved for hardcoded devices (host bridge, IDE controller, video) get assigned to these. If than later on a

Re: [libvirt] access with VNC and graphic interface

2011-03-28 Thread Dmitry ilyin
28.03.2011 15:10, Kenneth Nagin пишет: libvirt provides vnc to access the VMs under its control. However, I can not get applications with graphical interface to run when I use vnc to access a VM. The same applications will display properly if I ssh -X to the VM. Is there anyway to overcome this

Re: [libvirt] [PATCH 2/8] qemu: don't restore state label twice

2011-03-28 Thread Eric Blake
On 03/27/2011 02:31 AM, Laine Stump wrote: On 03/26/2011 08:12 AM, Eric Blake wrote: Otherwise, if something like doStopVcpus fails after the first restore, a second restore is attempted and throws a useless warning. * src/qemu/qemu_driver.c (qemudDomainSaveFlag): Avoid second restore of

Re: [libvirt] [PATCH] Add support for DNS TXT records

2011-03-28 Thread Paolo Bonzini
On 03/28/2011 01:34 PM, Michal Novotny wrote: Hi Laine, thanks for your reply. Comments inline... On 03/25/2011 10:02 PM, Laine Stump wrote: I haven't had time yet to look at the code in detail, but thought I should send this preliminary commentary. On 03/24/2011 09:58 AM, Michal Novotny

Re: [libvirt] [PATCH 3/8] docs: document recent hook additions

2011-03-28 Thread Eric Blake
On 03/27/2011 02:35 AM, Laine Stump wrote: On 03/26/2011 08:12 AM, Eric Blake wrote: * src/qemu/qemu_process.c (qemuProcessStart, qemuProcessStop): Fix typos. * docs/hooks.html.in: Document 'prepare' and 'release' hooks. --- Original post:

Re: [libvirt] [PATCH 4/8] tests: don't alter state in $HOME

2011-03-28 Thread Eric Blake
On 03/27/2011 02:59 AM, Laine Stump wrote: On 03/26/2011 08:12 AM, Eric Blake wrote: Diego reported a bug where virsh tries to initialize a readline history directory during 'make check' run as root, but fails because /root was read-only. It turns out that I could reproduce this as non-root,

Re: [libvirt] [PATCHv5 00/13] outgoing fd: migration and virFileOpenAs

2011-03-28 Thread Eric Blake
On 03/28/2011 07:01 AM, Daniel Veillard wrote: On Sat, Mar 26, 2011 at 06:52:29AM -0600, Eric Blake wrote: This addresses the comments raised during v4: https://www.redhat.com/archives/libvir-list/2011-March/msg00421.html More comments in individual patches. It could still use a bit more

Re: [libvirt] [PATCHv2 1/8] Ignore return value of virDomainObjUnref

2011-03-28 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index b8b8ee8..80a43a0 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -107,7 +107,7 @@

Re: [libvirt] [PATCHv2 2/8] Add event callbacks to libxl driver

2011-03-28 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_conf.h |8 ++- src/libxl/libxl_driver.c | 194 +- 2 files changed, 197 insertions(+), 5 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index bb49d35..a86df9a 100644 ---

Re: [libvirt] [PATCH] qemu: Only restore security label when saving is successfull.

2011-03-28 Thread Eric Blake
On 03/27/2011 10:16 PM, Osier Yang wrote: 于 2011年03月25日 23:54, Eric Blake 写道: On 03/25/2011 02:54 AM, Osier Yang wrote: qemudDomainSaveFlag trys to restore security label even if the saving fails, a useless warning will be thowed then, e.g. if doStopVcpus fails. * src/qemu/qemu_driver.c

Re: [libvirt] [PATCH 5/8] Add domainXMLFromNative/domainXMLToNative to libxl driver

2011-03-28 Thread Eric Blake
On 03/28/2011 03:29 AM, Daniel P. Berrange wrote: if WITH_LIBXL libvirtd_LDADD += ../src/libvirt_driver_libxl.la +libvirtd_LDADD += ../src/libvirt_xenxs.la +libvirtd_LDADD += ../src/libvirt_util.la +libvirtd_LDADD += ../src/libvirt_conf.la endif I'd like to get

Re: [libvirt] [PATCHv5] PHYP: Adding network interface management

2011-03-28 Thread Eduardo Otubo
I understand that sending a big giant patch is not the best way the get things done. I split the patch into two parts: The first part I'll send it right away, regarding ONLY the addition of the interface management stuff. The second, that I'll send it later on, regards the regressions, leaks

[libvirt] [PATCHv6] PHYP: Adding network interface

2011-03-28 Thread Eduardo Otubo
This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details: * MAC size and interface name are fixed due to specifications on HMC, both are created automatically and CAN'T be

Re: [libvirt] [PATCHv2 6/8] Add domainGetSchedulerType to libxl driver

2011-03-28 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_driver.c | 64 +- 1 files changed, 63 insertions(+), 1 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 7d83975..1a70f79 100644 --- a/src/libxl/libxl_driver.c +++

Re: [libvirt] [PATCHv2 8/8] Add domainSuspend/Resume to libxl driver

2011-03-28 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_driver.c | 122 +- 1 files changed, 120 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 47b7e56..3409340 100644 --- a/src/libxl/libxl_driver.c +++

Re: [libvirt] [PATCH 3/8] Add vcpu functions to libxl driver

2011-03-28 Thread Jim Fehlig
Markus Groß wrote: Am Mittwoch 23 März 2011 17:59:11 schrieb Jim Fehlig: Markus Groß wrote: +maplen = (unsigned int) ceil((double) nvcpus / 8); +if (VIR_ALLOC_N(bitmask, maplen) 0) { +virReportOOMError(); +goto cleanup; +} + +memset(bitmask, 0,

Re: [libvirt] [PATCHv2 4/8] Add vcpu functions to libxl driver

2011-03-28 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_driver.c | 310 +- 1 files changed, 305 insertions(+), 5 deletions(-) ACK. diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index aa135dd..3251e66 100644 ---

Re: [libvirt] [PATCHv2 3/8] List authors in copyright headers

2011-03-28 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_conf.c |3 +++ src/libxl/libxl_conf.h |3 +++ src/libxl/libxl_driver.c |6 ++ src/libxl/libxl_driver.h |3 +++ 4 files changed, 15 insertions(+), 0 deletions(-) ACK. diff --git a/src/libxl/libxl_conf.c

Re: [libvirt] [PATCHv2 5/8] Add domainXMLFromNative/domainXMLToNative to libxl driver

2011-03-28 Thread Jim Fehlig
Markus Groß wrote: I reworked this patch according to Daniel's comments in https://www.redhat.com/archives/libvir-list/2011-March/msg01272.html Find the new version below. I'm currently not able to test this new version, but didn't notice any issues by visual review. ACK. Regards, Jim

[libvirt] [PATCH] qemu: fix regression with fd labeling on migration

2011-03-28 Thread Eric Blake
My earlier testing for commit 34fa0de0 was done while starting just-built libvirt from an unconfined_t shell, where the fds happened to work when transferring to qemu. But when installed and run under virtd_t, failure to label the raw file (with no compression) or the pipe (with compression)

Re: [libvirt] [PATCHv2 7/8] Add domainGetOSType to libxl driver

2011-03-28 Thread Jim Fehlig
Markus Groß wrote: --- src/libxl/libxl_driver.c | 29 - 1 files changed, 28 insertions(+), 1 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 1a70f79..47b7e56 100644 --- a/src/libxl/libxl_driver.c +++

[libvirt] [PATCH] qemu: fix regression that hangs on save failure

2011-03-28 Thread Eric Blake
Regression introduced in commit 6034ddd55. * src/qemu/qemu_driver.c (qemudDomainSaveFlag): Jump to correct label. --- Aargh - I introduced a regression that hangs libvirtd due to an inadvertent change in label names (copied and pasted from doCoreDump, where the correct label was indeed named

Re: [libvirt] mingw: virsh event loop failure in current git

2011-03-28 Thread Eric Blake
[adding bug-gnulib and Paolo as author of rpl_ioctl] On 03/15/2011 02:29 AM, Matthias Bolte wrote: Commit 2ed6cc7bec41dd344d41ea1531f6760c93099128 Expose event loop implementation as a public API turned a failure to initialize the default event loop into a fatal error in virsh on Windows.

Re: [libvirt] mingw: virsh event loop failure in current git

2011-03-28 Thread Eric Blake
On 03/15/2011 05:02 AM, Daniel P. Berrange wrote: On Tue, Mar 15, 2011 at 09:29:14AM +0100, Matthias Bolte wrote: Commit 2ed6cc7bec41dd344d41ea1531f6760c93099128 Expose event loop implementation as a public API turned a failure to initialize the default event loop into a fatal error in virsh

Re: [libvirt] [PATCH] qemu: improve error message on failed fd transfer

2011-03-28 Thread Daniel Veillard
On Mon, Mar 28, 2011 at 03:19:30PM -0600, Eric Blake wrote: First fallout of fd: migration - it looks like SELinux enforcing _does_ require fd labeling (running uninstalled libvirtd from an unconstrained shell had no problems, but once faked out by doing chcon `stat -c %C /usr/sbin/libvirtd`

Re: [libvirt] [PATCH] qemu: fix regression with fd labeling on migration

2011-03-28 Thread Daniel Veillard
On Mon, Mar 28, 2011 at 04:33:58PM -0600, Eric Blake wrote: My earlier testing for commit 34fa0de0 was done while starting just-built libvirt from an unconfined_t shell, where the fds happened to work when transferring to qemu. But when installed and run under virtd_t, failure to label the

Re: [libvirt] [PATCHv7 3/4] libvirt/qemu - check address confliction before addition.

2011-03-28 Thread Hu Tao
On Fri, Mar 25, 2011 at 05:17:03PM +0900, KAMEZAWA Hiroyuki wrote: From 638341bdf3eaac824e36d265e134608279750049 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Fri, 25 Mar 2011 17:10:58 +0900 Subject: [PATCHv7 3/4] libvirt/qemu - check address confliction

Re: [libvirt] [Patch v7 1/4] libvirt/qemu - persistent modification of domain.

2011-03-28 Thread Hu Tao
On Fri, Mar 25, 2011 at 05:10:12PM +0900, KAMEZAWA Hiroyuki wrote: This is v7. Dropped patches for Nics and added 2 sanity checks and show correct error messages. This series looks good to me(except some minor problems in patch 3). Eric, will you have some time to have a review on this? --

Re: [libvirt] [PATCHv7 3/4] libvirt/qemu - check address confliction before addition.

2011-03-28 Thread KAMEZAWA Hiroyuki
On Tue, 29 Mar 2011 10:41:57 +0800 Hu Tao hu...@cn.fujitsu.com wrote: On Fri, Mar 25, 2011 at 05:17:03PM +0900, KAMEZAWA Hiroyuki wrote: From 638341bdf3eaac824e36d265e134608279750049 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Fri, 25 Mar 2011

Re: [libvirt] [PATCHv7 3/4] libvirt/qemu - check address confliction before addition.

2011-03-28 Thread Hu Tao
On Tue, Mar 29, 2011 at 11:40:44AM +0900, KAMEZAWA Hiroyuki wrote: On Tue, 29 Mar 2011 10:41:57 +0800 Hu Tao hu...@cn.fujitsu.com wrote: On Fri, Mar 25, 2011 at 05:17:03PM +0900, KAMEZAWA Hiroyuki wrote: From 638341bdf3eaac824e36d265e134608279750049 Mon Sep 17 00:00:00 2001 From:

Re: [libvirt] [Patch v7 1/4] libvirt/qemu - persistent modification of domain.

2011-03-28 Thread Wen Congyang
At 03/25/2011 04:10 PM, KAMEZAWA Hiroyuki Write: This is v7. Dropped patches for Nics and added 2 sanity checks and show correct error messages. = From 948597237bd9ecfc5c7343fd30efdca37733274e Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Fri, 25 Mar

Re: [libvirt] [PATCH] qemu: Only restore security label when saving is successfull.

2011-03-28 Thread Osier Yang
于 2011年03月29日 03:07, Eric Blake 写道: On 03/27/2011 10:16 PM, Osier Yang wrote: 于 2011年03月25日 23:54, Eric Blake 写道: On 03/25/2011 02:54 AM, Osier Yang wrote: qemudDomainSaveFlag trys to restore security label even if the saving fails, a useless warning will be thowed then, e.g. if doStopVcpus

Re: [libvirt] [Patch v7 1/4] libvirt/qemu - persistent modification of domain.

2011-03-28 Thread KAMEZAWA Hiroyuki
On Tue, 29 Mar 2011 11:24:23 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/25/2011 04:10 PM, KAMEZAWA Hiroyuki Write: This is v7. Dropped patches for Nics and added 2 sanity checks and show correct error messages. = From 948597237bd9ecfc5c7343fd30efdca37733274e Mon Sep 17

Re: [libvirt] [PATCHv7 3/4] libvirt/qemu - check address confliction before addition.

2011-03-28 Thread Wen Congyang
At 03/25/2011 04:17 PM, KAMEZAWA Hiroyuki Write: From 638341bdf3eaac824e36d265e134608279750049 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Fri, 25 Mar 2011 17:10:58 +0900 Subject: [PATCHv7 3/4] libvirt/qemu - check address confliction before addition.

Re: [libvirt] [Patch v7 1/4] libvirt/qemu - persistent modification of domain.

2011-03-28 Thread Wen Congyang
At 03/29/2011 12:32 PM, KAMEZAWA Hiroyuki Write: On Tue, 29 Mar 2011 11:24:23 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/25/2011 04:10 PM, KAMEZAWA Hiroyuki Write: This is v7. Dropped patches for Nics and added 2 sanity checks and show correct error messages. = From

Re: [libvirt] [PATCHv7 3/4] libvirt/qemu - check address confliction before addition.

2011-03-28 Thread KAMEZAWA Hiroyuki
On Tue, 29 Mar 2011 13:09:37 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/25/2011 04:17 PM, KAMEZAWA Hiroyuki Write: From 638341bdf3eaac824e36d265e134608279750049 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Fri, 25 Mar 2011 17:10:58 +0900

Re: [libvirt] [PATCHv7 3/4] libvirt/qemu - check address confliction before addition.

2011-03-28 Thread Wen Congyang
At 03/29/2011 01:13 PM, KAMEZAWA Hiroyuki Write: On Tue, 29 Mar 2011 13:09:37 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/25/2011 04:17 PM, KAMEZAWA Hiroyuki Write: From 638341bdf3eaac824e36d265e134608279750049 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki

Re: [libvirt] [Patch v7 1/4] libvirt/qemu - persistent modification of domain.

2011-03-28 Thread KAMEZAWA Hiroyuki
On Tue, 29 Mar 2011 13:17:55 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/29/2011 12:32 PM, KAMEZAWA Hiroyuki Write: On Tue, 29 Mar 2011 11:24:23 +0800 Wen Congyang we...@cn.fujitsu.com wrote: Hmm ? I'll add a spec. on qemuDomainAt(De)tachDevicePersistent() to never update vmdef

Re: [libvirt] [PATCHv7 3/4] libvirt/qemu - check address confliction before addition.

2011-03-28 Thread KAMEZAWA Hiroyuki
On Tue, 29 Mar 2011 13:30:03 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/29/2011 01:13 PM, KAMEZAWA Hiroyuki Write: On Tue, 29 Mar 2011 13:09:37 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/25/2011 04:17 PM, KAMEZAWA Hiroyuki Write: From

Re: [libvirt] [PATCHv7 3/4] libvirt/qemu - check address confliction before addition.

2011-03-28 Thread Wen Congyang
At 03/29/2011 01:31 PM, KAMEZAWA Hiroyuki Write: On Tue, 29 Mar 2011 13:30:03 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/29/2011 01:13 PM, KAMEZAWA Hiroyuki Write: On Tue, 29 Mar 2011 13:09:37 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 03/25/2011 04:17 PM, KAMEZAWA