[libvirt] [PATCH] esx: Cleanup VI generator code

2011-04-10 Thread Matthias Bolte
--- src/esx/esx_vi_generator.py | 177 +-- 1 files changed, 71 insertions(+), 106 deletions(-) diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py index 3d068f3..622a34a 100755 --- a/src/esx/esx_vi_generator.py +++

[libvirt] [PATCH] esx: Cleanup and refactor CastFromAnyType macros

2011-04-10 Thread Matthias Bolte
Add CastFromAnyType functions for the String type. --- src/esx/esx_vi_generator.py |5 +-- src/esx/esx_vi_types.c | 64 +++--- src/esx/esx_vi_types.h |2 + 3 files changed, 51 insertions(+), 20 deletions(-) diff --git

[libvirt] [PATCH] esx: Mark error message in macros for translation

2011-04-10 Thread Matthias Bolte
--- src/esx/esx_vi_types.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 9e23030..29a3c39 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@ -77,12 +77,12 @@ int

[libvirt] [PATCH] virsh: Add --name and --description options to snapshot-create

2011-04-10 Thread Matthias Bolte
This options are shortcuts to set name and description of a snapshot. Suggested by Elias Probst --- I'm not sure if this is be best approach. In case of the vol-* commands there is vol-create that takes and XML file and vol-create-as that takes a set of arguments. So, should there actually be a

Re: [libvirt] [PATCH v2] xen: Remove PATH_MAX sized stack allocation from block stats code

2011-04-10 Thread Matthias Bolte
2011/4/10 Daniel Veillard veill...@redhat.com: On Sat, Apr 09, 2011 at 12:05:17PM +0200, Matthias Bolte wrote: ---  src/xen/block_stats.c |   51 +  1 files changed, 26 insertions(+), 25 deletions(-) diff --git a/src/xen/block_stats.c

[libvirt] [PATCH] docs: Serial and parallel device target ports actually start from 0

2011-04-10 Thread Matthias Bolte
Reported by Igor Galić --- docs/formatdomain.html.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 574fee5..ea021e8 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1807,7 +1807,7

[libvirt] [PATCH] esx: Move CURL handling code to it's own type

2011-04-10 Thread Matthias Bolte
--- src/esx/esx_driver.c |4 +- src/esx/esx_vi.c | 348 ++ src/esx/esx_vi.h | 29 +++- 3 files changed, 205 insertions(+), 176 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index deda372..ef76350 100644 ---

[libvirt] [PATCH] esx: Add a wrapper for shared CURL handles

2011-04-10 Thread Matthias Bolte
To be used to share a CURL handle between multiple threads in the upcoming domain event support. --- src/esx/esx_vi.c | 176 ++ src/esx/esx_vi.h | 19 ++ 2 files changed, 195 insertions(+), 0 deletions(-) diff --git a/src/esx/esx_vi.c

[libvirt] [PATCH] esx: Make the parsed URI part of the private connection data

2011-04-10 Thread Matthias Bolte
This will be used to make esxVI_Context clonable. Also move cleanup code for esxPrivate to esxFreePrivate(). --- src/esx/esx_driver.c | 103 - src/esx/esx_private.h |4 +- 2 files changed, 52 insertions(+), 55 deletions(-) diff --git

[libvirt] Paused networking on VM up/down with NAT fwd

2011-04-10 Thread Serge Hallyn
Hi all, some time ago bug https://bugs.launchpad.net/ubuntu/maverick/+source/qemu-kvm/+bug/584048 was fixed in libvirt. It's the one where when a VM is started or stopped which has a lower macaddr than what the bridge currently has, the bridge changes macaddr and networking pauses. The fix was

Re: [libvirt] [PATCH] docs: remove returns word from beginning of lines

2011-04-10 Thread Daniel Veillard
On Fri, Apr 08, 2011 at 04:31:38PM -0600, Eric Blake wrote: On 04/07/2011 02:47 AM, Jean-Baptiste Rouault wrote: Move returns keyword from beginning of API doc lines when it does not describe return values. ACK, and pushed. Maybe the API doc extractor could be changed to look for

Re: [libvirt] [PATCH 2/3] maxmem: implement virDomainSetMaxMemory API of the qemu driver

2011-04-10 Thread Daniel Veillard
On Fri, Apr 08, 2011 at 05:39:36PM -0600, Eric Blake wrote: On 04/07/2011 11:08 PM, Taku Izumi wrote: This patch implements the code to support virDomainSetMaxMemory API, and to support VIR_DOMAIN_MEM_MAXIMUM flag in qemudDomainSetMemoryFlags function. As a result, we can change the

Re: [libvirt] [PATCH 3/5] phyp: Don't try to use a string from a failed virAsprintf

2011-04-10 Thread Daniel Veillard
On Sat, Apr 09, 2011 at 11:59:09AM +0200, Matthias Bolte wrote: --- src/phyp/phyp_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index f441261..24165fb 100644 --- a/src/phyp/phyp_driver.c +++

Re: [libvirt] [PATCH 5/5] phyp: Don't overwrite error from virDomainDeviceDefParse by OOM error

2011-04-10 Thread Daniel Veillard
On Sat, Apr 09, 2011 at 11:59:11AM +0200, Matthias Bolte wrote: --- src/phyp/phyp_driver.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 226946d..f36b357 100644 --- a/src/phyp/phyp_driver.c +++

Re: [libvirt] [PATCH 4/5] phyp: Fix too small buffer allocation in phypAttachDevice

2011-04-10 Thread Daniel Veillard
On Sat, Apr 09, 2011 at 11:59:10AM +0200, Matthias Bolte wrote: sizeof(domain-name) is the wrong thing. Instead of using strdup here rewrite escape_specialcharacters to allocate the buffer itself. Add a contains_specialcharacters to be used in phypOpen, as phypOpen is not interested in the

Re: [libvirt] [PATCH] migrate VMs between different-endian hosts

2011-04-10 Thread Daniel Veillard
On Sat, Apr 09, 2011 at 11:48:41AM -0400, Stefan Berger wrote: This patch enables the migration of Qemu VMs between hosts of different endianess. I tested this by migrating a i686 VM between a x86 and ppc64 host. OMG, there is really a use case for this :-) ? I am converting the 'int's in

Re: [libvirt] [PATCH] docs: document freecell --all

2011-04-10 Thread Daniel Veillard
On Wed, Apr 06, 2011 at 11:28:37AM -0600, Eric Blake wrote: Based on a smaller patch developed by Moritoshi Oshiro: https://bugzilla.redhat.com/show_bug.cgi?id=693963 * tools/virsh.pod (freecell): Mention all, and clarify that optional cellno requires --cellno. --- I think this is the

[libvirt] [RFC PATCH] check whether domain is active after qemuDomainObjExitMonitor* returns

2011-04-10 Thread Wen Congyang
qemu may quited unexpectedly when invoking a monitor command. And priv-mon will be NULL after qemuDomainObjExitMonitor* returns. So we must not use it. Unfortunately we still use it, and it will cause libvirtd crashed. As Eric suggested, qemuDomainObjExitMonitor* should be made to return the