On 04/21/2011 10:24 AM, Daniel P. Berrange wrote:
On Thu, Apr 21, 2011 at 09:33:42AM -0400, Stefan Berger wrote:
On 04/21/2011 07:43 AM, Daniel P. Berrange wrote:
On Thu, Apr 21, 2011 at 07:37:30AM -0400, Stefan Berger wrote:
and simply doesn't start the VM. After this function is called all
On 04/21/2011 06:08 PM, Eric Blake wrote:
On 04/21/2011 09:27 AM, Michal Privoznik wrote:
Up to now we missed parser for cpuinfo on x390(x) machines. Those machines
have only 1 thread, core, socket. What is missing is information about
CPU frequency.
---
src/nodeinfo.c | 29
The patch which moved libpciaccess initialization to one place caused
regression - we were not able to run on system with no PCI bus, like
s390(x). This patch fix it.
---
src/node_device/node_device_udev.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git
On Fri, Apr 22, 2011 at 09:58:38 +0200, Michal Privoznik wrote:
The patch which moved libpciaccess initialization to one place caused
regression - we were not able to run on system with no PCI bus, like
s390(x). This patch fix it.
---
src/node_device/node_device_udev.c |6 ++
1
On 04/22/2011 10:19 AM, Jiri Denemark wrote:
On Fri, Apr 22, 2011 at 09:58:38 +0200, Michal Privoznik wrote:
The patch which moved libpciaccess initialization to one place caused
regression - we were not able to run on system with no PCI bus, like
s390(x). This patch fix it.
---
This patch makes the options --crash and --live of virsh dump mutually
exclusive
diff --git a/tools/virsh.c b/tools/virsh.c
index 2e35021..ef77d7f 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -1869,14 +1869,19 @@ cmdDump(vshControl *ctl, const vshCmd *cmd)
flags |=
This patch makes the options --crash and --live of virsh dump mutually
exclusive
diff --git a/tools/virsh.c b/tools/virsh.c
index 2e35021..ef77d7f 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -1869,14 +1869,19 @@ cmdDump(vshControl *ctl, const vshCmd *cmd)
flags |=
Hello there,
I wrote in February this year following:
boromir:/ # qemu-system-s390x --enable-kvm -monitor stdio
VNC server running on `::1:5900'
QEMU 0.12.50 monitor - type 'help' for more information
(qemu) info qtree
bus: main-system-bus
type System
dev: s390-virtio-bridge, id
bus:
The patch which moved libpciaccess initialization to one place caused
regression - we were not able to run on system with no PCI bus, like
s390(x).
---
src/node_device/node_device_udev.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git
Il giorno ven, 22/04/2011 alle 14.24 +0200, Michal Privoznik ha scritto:
+/* On x390(x) system there is no PCI bus.
Looks like a typo?
--
Diego Elio Pettenò — Flameeyes
http://blog.flameeyes.eu/
--
libvir-list mailing list
libvir-list@redhat.com
On 04/22/2011 04:03 AM, Jiri Denemark wrote:
---
src/qemu/qemu_driver.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f6e503a..f35616d 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@
On 04/22/2011 03:57 AM, Jiri Denemark wrote:
This patch makes the options --crash and --live of virsh dump mutually
exclusive
Moreover, this would only protect virsh. It's better to have this check in
virDomainCoreDump() so that all users can get the error.
Agreed.
The following patch
---
daemon/remote.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index 54fef64..1c98bba 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -3681,7 +3681,7 @@ remoteDispatchListNetworks(struct qemud_server *server
On 04/22/2011 10:11 AM, Matthias Bolte wrote:
---
daemon/remote.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index 54fef64..1c98bba 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -3681,7 +3681,7 @@
On Fri, Apr 22, 2011 at 10:17:01AM -0600, Eric Blake wrote:
On 04/22/2011 10:11 AM, Matthias Bolte wrote:
remoteDispatchError(rerr);
-VIR_FREE(ret-names.names_len);
+VIR_FREE(ret-names.names_val);
And to think I missed those in the huge patch. Oops.
Maybe
On 04/22/2011 10:31 AM, Christophe Fergeau wrote:
On Fri, Apr 22, 2011 at 10:17:01AM -0600, Eric Blake wrote:
On 04/22/2011 10:11 AM, Matthias Bolte wrote:
remoteDispatchError(rerr);
-VIR_FREE(ret-names.names_len);
+VIR_FREE(ret-names.names_val);
And to think I
On Fri, Apr 22, 2011 at 10:55:04AM -0600, Eric Blake wrote:
On 04/22/2011 10:31 AM, Christophe Fergeau wrote:
-# define VIR_FREE(ptr) virFree((ptr))
+# define VIR_FREE(ptr) \
+do { void *check_type = (ptr); virFree((check_type)); } while (0)
Not quite. That assigns check_type to
2011/4/22 Eric Blake ebl...@redhat.com:
On 04/22/2011 10:11 AM, Matthias Bolte wrote:
Commit 36b652138be renamed err to rerr, do the same in the generator.
---
daemon/qemu_dispatch_prototypes.h | 2 +-
daemon/remote_dispatch_prototypes.h | 404
+-
2011/4/22 Eric Blake ebl...@redhat.com:
On 04/22/2011 10:11 AM, Matthias Bolte wrote:
---
daemon/remote.c | 8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index 54fef64..1c98bba 100644
--- a/daemon/remote.c
+++
2011/4/22 Eric Blake ebl...@redhat.com:
On 04/22/2011 10:31 AM, Christophe Fergeau wrote:
On Fri, Apr 22, 2011 at 10:17:01AM -0600, Eric Blake wrote:
On 04/22/2011 10:11 AM, Matthias Bolte wrote:
remoteDispatchError(rerr);
- VIR_FREE(ret-names.names_len);
+
On Fri, Apr 22, 2011 at 07:06:18PM +0200, Matthias Bolte wrote:
I just took a look at it and the first instances are mostly const
char* used for allocated strings. I didn't spot a real error yet.
Same here, looked at a dozen of these warnings, and just const char * being
used for allocated
On 04/10/2011 07:39 AM, Matthias Bolte wrote:
---
src/esx/esx_driver.c |4 +-
src/esx/esx_vi.c | 348
++
src/esx/esx_vi.h | 29 +++-
3 files changed, 205 insertions(+), 176 deletions(-)
+++ b/src/esx/esx_vi.h
@@ -82,6 +82,7
There were recently some bugs where VIR_FREE was called with an
int parameter. Try to affect the value passed to VIR_FREE to
a const void* so that the compiler gets a chance to emit a warning
if we didn't pass a pointer to VIR_FREE.
---
src/util/memory.h |6 +-
1 files changed, 5
On Fri, Apr 22, 2011 at 08:21:24PM +0200, Christophe Fergeau wrote:
There were recently some bugs where VIR_FREE was called with an
int parameter. Try to affect the value passed to VIR_FREE to
a const void* so that the compiler gets a chance to emit a warning
if we didn't pass a pointer to
On 04/22/2011 12:21 PM, Christophe Fergeau wrote:
There were recently some bugs where VIR_FREE was called with an
int parameter. Try to affect the value passed to VIR_FREE to
a const void* so that the compiler gets a chance to emit a warning
if we didn't pass a pointer to VIR_FREE.
---
mingw lacks the counterpart to PTHREAD_MUTEX_INITIALIZER, so the
best we can do is portably expose once-only runtime initialization.
* src/util/threads.h (virOnceControlPtr): New opaque type.
(virOnceFunc): New callback type.
(virOnce): New prototype.
* src/util/threads-pthread.h
26 matches
Mail list logo
