Re: [libvirt] RFC: APIs for managing a subset of a domain's disks

2011-05-07 Thread Igor Serebryany
On Fri, May 06, 2011 at 06:00:09PM +0100, Richard W.M. Jones wrote: How about just adding flags into the disk XML, eg: disk ... flags migratefalse/migrate snapshotfalse/snapshot /flags /disk I would love to see this in libvirt. On a somewhat related note ...

[libvirt] [PATCH] apparmor: Fix uninitalized variable warning in virt-aa-helper

2011-05-07 Thread Matthias Bolte
--- src/security/virt-aa-helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index a4e8549..e481095 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -245,7 +245,7 @@

Re: [libvirt] [PATCHv2 4/3] build: translate generated strings

2011-05-07 Thread Matthias Bolte
2011/5/7 Eric Blake ebl...@redhat.com: Make sure that xgettext scans generated files for translatable strings, rather than just files stored in libvirt.git. * .gnulib: Update, for bootstrap and syntax-check fixes. * bootstrap: Resynchronize with gnulib. * cfg.mk (generated_files): Define. *

Re: [libvirt] [PATCHv2 5/3] build: fix VPATH builds

2011-05-07 Thread Matthias Bolte
2011/5/7 Eric Blake ebl...@redhat.com: * src/Makefile.am (REMOTE_DRIVER_GENERATED): Generated files should live in $(srcdir). Update rules to reflect this. --- This still doesn't fix the fact that 'make dist' under WITH_REMOTE false is broken, but one thing at a time.  src/Makefile.am |  

Re: [libvirt] [PATCHv2 6/3] build: rebuild generated files after rpcgen_fix.pl tweak

2011-05-07 Thread Matthias Bolte
2011/5/7 Eric Blake ebl...@redhat.com: Noticed this while trying to run rpcgen on cygwin. * src/Makefile.am ($(srcdir)/remote/%_protocol.h) ($(srcdir)/remote/%_protocol.c): Add a dependency. --- ACK. Matthias -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 0/5] Improvements for the remote generator

2011-05-07 Thread Matthias Bolte
Adds whitelists and moves black and whitelists to their own files. Also makes parsing stricter and more uniform. Matthias -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/5] remote generator: Fix comment ignoring regex

2011-05-07 Thread Matthias Bolte
--- daemon/remote_generator.pl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl index b06e51a..8d62c37 100755 --- a/daemon/remote_generator.pl +++ b/daemon/remote_generator.pl @@ -380,7 +380,7 @@ elsif ($opt_b) {

[libvirt] [PATCH 1/5] Rename internal DumpXML functions to GetXMLDesc

2011-05-07 Thread Matthias Bolte
This matches the public API and helps to get rid of some speical case code in the remote generator. Rename driver API functions and XDR protocol structs. No functional change included outside of the remote generator. --- daemon/remote_generator.pl |6 +--- src/driver.h

[libvirt] [PATCH 3/5] remote generator: Unify unsigned int notation in .x files

2011-05-07 Thread Matthias Bolte
Rename u_int and unsigned to unsigned int. This gets rid of some special case code in the generator. --- daemon/remote_generator.pl | 10 +++--- src/remote/remote_protocol.x | 72 +- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git

[libvirt] [PATCH 4/5] remote generator: Make parsing stricter

2011-05-07 Thread Matthias Bolte
Anchor matches at the beginning of a line. Specialize some general matches. Add some comments to special cases. --- daemon/remote_generator.pl | 172 +++- 1 files changed, 105 insertions(+), 67 deletions(-) diff --git a/daemon/remote_generator.pl

[libvirt] [PATCH 5/5] remote generator: Move blacklist to a file and add explicit whitelist

2011-05-07 Thread Matthias Bolte
--- daemon/Makefile.am | 20 - daemon/qemu_dispatch.blacklist |3 + daemon/qemu_dispatch.whitelist |1 + daemon/remote_dispatch.blacklist | 37 daemon/remote_dispatch.whitelist | 169 +++

[libvirt] how to assign an ip when assign a NIC or VF to the Virtual Machine?

2011-05-07 Thread guan qin
Hi, I use the *Intel Virtualization Technology for Directed I/O*(VT-d) or *Single-Root I/O Virtualization*(SR-IOV) to assign a network card or Virtual Function(VF) to a Virtual Machine(VM) to access the network by the hostdev element in libvirt Domain XML. But the ethX in the VM hasn't an ip,I

Re: [libvirt] how to assign an ip when assign a NIC or VF to the Virtual Machine?

2011-05-07 Thread Richard W.M. Jones
On Sat, May 07, 2011 at 11:24:23PM +0800, guan qin wrote: So how can I assign an ip to the VM when assign the NIC or VF to the VM It doesn't work like this. Just like with real hardware, all the virtual hardware has is a MAC address. The (real or virtual) machine has to use some other method

[libvirt] Potential problems in virFDStreamClose

2011-05-07 Thread Matthias Bolte
virFDStreamClose calls virFDStreamFree that frees fdst, but virFDStreamClose access fdst-lock after that. virFDStreamClose doesn't destroy fdst-lock. static int virFDStreamClose(virStreamPtr st) { struct virFDStreamData *fdst = st-privateData; int ret; VIR_DEBUG(st=%p, st); if

Re: [libvirt] how to assign an ip when assign a NIC or VF to the Virtual Machine?

2011-05-07 Thread guan qin
thanks for your reply ! The second solution you mentioned may be difficult , because when I assign the ethX to the VM, the X in the 'ethX' is random (the 'X' in the host may be different in the VM),I don't know it before I boot the VM . so maybe I couldn't edit the guest correctly before booting