Re: [libvirt] [PATCH RFC] Add domainSave/Restore to libxl driver

2011-05-27 Thread Markus Groß
Quoting Jim Fehlig jfeh...@novell.com: Markus Groß wrote: Am Dienstag 24 Mai 2011 06:06:08 schrieb Jim Fehlig: + +event = virDomainEventNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, + VIR_DOMAIN_EVENT_STOPPED_SAVED); + +if

Re: [libvirt] [PATCH] Add domainCoreDump to libxl driver

2011-05-27 Thread Markus Groß
Quoting Jim Fehlig jfeh...@novell.com: Markus Groß wrote: For core dumping to work correctly the following patch for xen is needed: http://lists.xensource.com/archives/html/xen-devel/2011-05/msg01469.html This patch is in xen-unstable and is considered for backport to the xen stable branches.

Re: [libvirt] [PATCH 3/3] Add disk attach/detach support to libxl driver

2011-05-27 Thread Markus Groß
Quoting Jim Fehlig jfeh...@novell.com: Markus Groß wrote: Based on the device attach/detach code from the QEMU driver. --- src/libxl/libxl_driver.c | 519 ++ 1 files changed, 519 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH] Fix build with --with-driver-modules enabled

2011-05-27 Thread Daniel Veillard
On Thu, May 26, 2011 at 11:32:09PM +0200, Matthias Bolte wrote: Export a bunch of missing symbols and link the remote driver to gnulib. --- src/Makefile.am |8 +++- src/libvirt_private.syms |3 +++ src/libvirt_xenxs.syms | 21 + 3 files changed,

Re: [libvirt] [PATCHv4 0/7] interface: new public API for network config change transactions

2011-05-27 Thread Daniel Veillard
On Thu, May 26, 2011 at 12:17:38PM -0400, Laine Stump wrote: (This is v3 of some of the patches and v4 of some others. Changes from previous versions are noted in the individual patches.) This patch series implements three new APIs for the interface driver which support transactional

Re: [libvirt] [PATCH v2] qemu : support persistent add/delete network interface

2011-05-27 Thread Daniel Veillard
On Wed, May 18, 2011 at 06:21:30PM +0900, KAMEZAWA Hiroyuki wrote: v2 here. error path tested. == From 73887fd3a37e3aa38bf4e031df9cf230e2635137 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Date: Wed, 18 May 2011 15:14:28 +0900 Subject: [PATCH] qemu -

[libvirt] virsh list didn't show anything

2011-05-27 Thread YAO
Hi, I tried to connect xen using latest libvirt When I connected to xend, virsh list --all gave me the right output. But when I connected to libxl, the virsh didn't show anything only as follows Id Name State -- I think at least Domain-0 should show up.

Re: [libvirt] [RESEND PATCH 0/3] support for changing memory parameters for inactive domains

2011-05-27 Thread Daniel Veillard
On Wed, May 25, 2011 at 04:54:43PM +0800, Hu Tao wrote: This series enables user to change memory parameters for inactive domains from virsh command line. This series is rebased on the latest git tree since patch 2 of the previous sent series is applied wrongly by git on the latest git tree.

Re: [libvirt] [PATCH] Fix build with --with-driver-modules enabled

2011-05-27 Thread Matthias Bolte
2011/5/27 Daniel Veillard veill...@redhat.com: On Thu, May 26, 2011 at 11:32:09PM +0200, Matthias Bolte wrote: Export a bunch of missing symbols and link the remote driver to gnulib. ---  src/Makefile.am          |    8 +++-  src/libvirt_private.syms |    3 +++  src/libvirt_xenxs.syms  

Re: [libvirt] [PATCH 0/3] Allow extra URI and target VM XML when migrating

2011-05-27 Thread Daniel Veillard
On Wed, May 18, 2011 at 01:23:22PM -0400, Daniel P. Berrange wrote: This series takes advantage of the fact that we've not yet released the v3 migration protocol, to add support for some extra migration parameters. Looked at the patches, looks fine, I didn't spot anything. ACK It's fairly

Re: [libvirt] [PATCH 01/10] Allow handshake with child process during startup

2011-05-27 Thread Daniel Veillard
On Thu, May 19, 2011 at 07:24:16AM -0400, Daniel P. Berrange wrote: Allow the parent process to perform a bi-directional handshake with the child process during fork/exec. The child process will fork and do its initial setup. Immediately prior to the exec(), it will stop wait for a handshake

[libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Jean-Baptiste Rouault
openvzGetUUID did not work since openvz_readline() was replaced by getline() --- src/openvz/openvz_conf.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 2cccd81..7b939b2 100644 ---

Re: [libvirt] [PATCH 02/10] Support leases in guest XML and lock manager

2011-05-27 Thread Daniel Veillard
On Thu, May 19, 2011 at 07:24:17AM -0400, Daniel P. Berrange wrote: A lock manager may operate in various modes. The direct mode of operation is to obtain locks based on the resources associated with devices in the XML. The indirect mode is where the app creating the domain provides explicit

Re: [libvirt] [PATCH 03/10] Basic framework for lock manager plugins

2011-05-27 Thread Daniel Veillard
On Thu, May 19, 2011 at 07:24:18AM -0400, Daniel P. Berrange wrote: Define the basic framework lock manager plugins. The basic plugin API for 3rd parties to implemented is defined in src/locking/lock_driver.h This allows dlopen()able modules for alternative locking schemes, however, we

Re: [libvirt] [PATCH 02/10] Support leases in guest XML and lock manager

2011-05-27 Thread Daniel Veillard
On Fri, May 27, 2011 at 04:31:36PM +0800, Daniel Veillard wrote: On Thu, May 19, 2011 at 07:24:17AM -0400, Daniel P. Berrange wrote: --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-lease.args @@ -0,0 +1,4 @@ +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu

Re: [libvirt] [PATCH 04/10] Add a 'nop' lock driver implementation.

2011-05-27 Thread Daniel Veillard
On Thu, May 19, 2011 at 07:24:19AM -0400, Daniel P. Berrange wrote: To allow hypervisor drivers to assume that a lock driver impl will be guaranteed to exist, provide a 'nop' impl that is compiled into the library Also has to good property of being usable as a template for new ones... *

Re: [libvirt] [PATCH 05/10] Add higher level lock API for domain objects

2011-05-27 Thread Daniel Veillard
On Thu, May 19, 2011 at 07:24:20AM -0400, Daniel P. Berrange wrote: To facilitate use of the locking plugins from hypervisor drivers, introduce a higher level API for locking virDomainObjPtr instances. In includes APIs targetted to VM startup, and hotplug/unplug * src/Makefile.am: Add domain

Re: [libvirt] [PATCH 06/10] Add initial docs about the lock managers

2011-05-27 Thread Daniel Veillard
On Thu, May 19, 2011 at 07:24:21AM -0400, Daniel P. Berrange wrote: --- docs/internals/locking.html.in | 257 docs/sitemap.html.in |4 + 2 files changed, 261 insertions(+), 0 deletions(-) create mode 100644

Re: [libvirt] [PATCH 07/10] Integrate the QEMU driver with the lock manager infrastructure

2011-05-27 Thread Daniel Veillard
On Thu, May 19, 2011 at 07:24:22AM -0400, Daniel P. Berrange wrote: The QEMU integrates with the lock manager instructure in a number of key places * During startup, a lock is acquired in between the fork exec * During startup, the libvirtd process acquires a lock before setting file

Re: [libvirt] [PATCH 08/10] Support passing QEMU lock state to dest during migration

2011-05-27 Thread Daniel Veillard
On Thu, May 19, 2011 at 07:24:23AM -0400, Daniel P. Berrange wrote: Some lock managers associate state with leases, allowing a process to temporarily release its leases, and re-acquire them later, safe in the knowledge that no other process has acquired + released the leases in between.

Re: [libvirt] [PATCH 08/10] Support passing QEMU lock state to dest during migration

2011-05-27 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 05:12:38PM +0800, Daniel Veillard wrote: On Thu, May 19, 2011 at 07:24:23AM -0400, Daniel P. Berrange wrote: Some lock managers associate state with leases, allowing a process to temporarily release its leases, and re-acquire them later, safe in the knowledge that no

Re: [libvirt] [PATCH 09/10] Allow leases to be hotpluged with QEMU guests

2011-05-27 Thread Daniel Veillard
On Thu, May 19, 2011 at 07:24:24AM -0400, Daniel P. Berrange wrote: * src/conf/domain_conf.c, src/conf/domain_conf.h: APIs for inserting/finding/removing virDomainLeaseDefPtr instances * src/qemu/qemu_driver.c: Wire up hotplug/unplug for leases * src/qemu/qemu_hotplug.h,

Re: [libvirt] [PATCH 10/10] Add a plugin for the 'sanlock' project

2011-05-27 Thread Daniel Veillard
On Thu, May 19, 2011 at 07:24:25AM -0400, Daniel P. Berrange wrote: Sanlock is a project that implements a disk-paxos locking algorithm. This is suitable for cluster deployments with shared storage. * src/Makefile.am: Add dlopen plugin for sanlock * src/locking/lock_driver_sanlock.c:

Re: [libvirt] [PATCH 10/10] Add a plugin for the 'sanlock' project

2011-05-27 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 05:37:51PM +0800, Daniel Veillard wrote: On Thu, May 19, 2011 at 07:24:25AM -0400, Daniel P. Berrange wrote: Sanlock is a project that implements a disk-paxos locking algorithm. This is suitable for cluster deployments with shared storage. * src/Makefile.am: Add

Re: [libvirt] Fwd: Re: ports/157024: [new port] devel/libvirt: Toolkit to interact with virtualization capabilities

2011-05-27 Thread Daniel Veillard
On Fri, May 20, 2011 at 11:18:30AM -0700, Jason Helfman wrote: Port was committed to the FreeBSD portstree! Ah ah !!! Cool :-) thanks for the info ! Daniel Many thanks, Jason -- Jason Helfman System Administrator experts-exchange.com

Re: [libvirt] FYI: qemu silently clipping large integers in JSON protocol

2011-05-27 Thread Daniel Veillard
On Fri, May 20, 2011 at 08:20:33PM +0100, Richard W.M. Jones wrote: This thread may be of interest: http://lists.gnu.org/archive/html/qemu-devel/2011-05/threads.html#02162 Currently, qemu silently clips any JSON integer in the range 0x8000___ - 0x___ (all

Re: [libvirt] [PATCH 7/7] remote generator: Annotate hyper with the actual C type

2011-05-27 Thread Daniel P. Berrange
On Wed, May 25, 2011 at 10:33:06AM -0600, Eric Blake wrote: On 05/25/2011 10:23 AM, Daniel P. Berrange wrote: On Mon, May 23, 2011 at 07:36:10PM +0200, Matthias Bolte wrote: Remove some special case code that took care of mapping hyper to the correct C types. Use macros for hyper to

[libvirt] [PATCH] Don't kill QEMU process when a monitor I/O parsing error occurs

2011-05-27 Thread Daniel P. Berrange
Currently whenever there is any failure with parsing the monitor, this is treated in the same was as end-of-file (ie QEMU quit). The domain is terminated, if not already dead. With this change, failures in parsing the monitor stream do not result in the death of QEMU. The guest continues running

[libvirt] [PATCH] Ensure hvsupport.html.in is built before HTML validation

2011-05-27 Thread Daniel P. Berrange
In a parallel make, HTML validation tries to run before hvsupport.html.in has been built. * docs/Makefile.am: List hvsupport.html.in as a built source --- docs/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index

[libvirt] [PATCH V2 0/7] support multi function PCI device

2011-05-27 Thread Wen Congyang
We want to use more than 200+ device. Libvirt does not use multi function PCI device and PCI-to-PCI bridge. So we can not use more than 200+ device if it's a PCI device or it's controller is a PCI device. This patchset adds the support of multi function PCI device. It does not support to hot

[libvirt] [PATCH 1/7] check whether qemu supports multi function PCI device

2011-05-27 Thread Wen Congyang
qemu supports multi function PCI device after version 0.13.0. --- src/qemu/qemu_capabilities.c |5 + src/qemu/qemu_capabilities.h |1 + tests/qemuhelptest.c |3 ++- 3 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH 2/7] prevent hot unplugging multi function PCI device

2011-05-27 Thread Wen Congyang
We do not support to hot unplug multi function PCI device now. If the device is one function of multi function PCI device, we shoul not allow to hot unplugg it. --- src/qemu/qemu_hotplug.c | 52 +++ 1 files changed, 52 insertions(+), 0 deletions(-)

[libvirt] [PATCH 3/7] the key of hash table should include the function value

2011-05-27 Thread Wen Congyang
We save all used PCI address in the hash table. The key is generated by domain, bus and slot now. We will support multi function PCI device, so the key should be generated by domain, bus, slot and function. --- src/qemu/qemu_command.c |7 +-- 1 files changed, 5 insertions(+), 2

[libvirt] [PATCH 4/7] Reimplement qemuDomainPCIAddressReserveSlot(): reserve all functions in the slot

2011-05-27 Thread Wen Congyang
We will support multi function PCI device. So we should reserve all functions in the slot if we want to reserve a slot. --- src/qemu/qemu_command.c | 37 ++--- src/qemu/qemu_command.h |4 2 files changed, 38 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCH 5/7] assign the whole slot to the PCI device that has no address

2011-05-27 Thread Wen Congyang
If user does not specify the PCI address, we should auto assign an unused slot. --- src/qemu/qemu_command.c | 36 1 files changed, 32 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 48834f1..6f9540c 100644

[libvirt] [PATCH 6/7] the hotplugged PCI device should use the whole slot

2011-05-27 Thread Wen Congyang
Hot pluging/unpluging multi PCI device is not supported now. So the function of hotplugged PCI device must be 0. When we hot unplug it, we should set release all functions in the slot. --- src/qemu/qemu_command.c | 46 +++--- src/qemu/qemu_command.h |

[libvirt] [PATCH] Remove unused 'target' field in virDomainHostdevDef

2011-05-27 Thread Daniel P. Berrange
The virDomainHostdevDef struct contains a 'char *target' field. This is set to 'NULL' when parsing XML and never used / set anywhere else. Clearly it is bogus unused * src/conf/domain_conf.c, src/conf/domain_conf.h: Remove target from virDomainHostdevDef --- src/conf/domain_conf.c |2 --

[libvirt] [PATCH 7/7] support multifunction PCI device

2011-05-27 Thread Wen Congyang
If qemu supports multi function PCI device, the format of the PCI address passed to qemu is bus=pci.0,multifunction=on,addr=slot.function. If qemu does not support multi function PCI device, the format of the PCI address passed to qemu is bus=pci.0,addr=slot. --- src/conf/domain_conf.c |3

[libvirt] [PATCH] openvz: Handle getline failures in openvzReadConfigParam properly

2011-05-27 Thread Matthias Bolte
The regression fix in 3aab7f2d6b068f0 altered the error handling. getline returns -1 on failure to read a line (including EOF). The original openvzReadConfigParam function using openvz_readline only treated EOF as not-found. The current getline version treats all getline failures as not-found.

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Matthias Bolte
2011/5/27 Jean-Baptiste Rouault jean-baptiste.roua...@diateam.net: openvzGetUUID did not work since openvz_readline() was replaced by getline() ---  src/openvz/openvz_conf.c |   13 ++---  1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/openvz/openvz_conf.c

[libvirt] [PATCH 0/4] Allow changing guest XML during QEMU migration

2011-05-27 Thread Daniel P. Berrange
This patch series updates the QEMU driver to allow it to take advantage of the migration v3 protocol support for changing guest XML during migration. eg virsh migrate --xml migtest.xml migtest qemu+ssh://somehost/system NB the XML is strictly validated for guest ABI compatibility so only things

[libvirt] [PATCH 1/4] Add an API for comparing the ABI of two guest configurations

2011-05-27 Thread Daniel P. Berrange
To allow a client app to pass in custom XML during migration of a guest it is neccessary to ensure the guest ABI remains unchanged. The virDomainDefCheckABIStablity method accepts two virDomainDefPtr structs and compares everything in them that could impact the guest machine ABI *

[libvirt] [PATCH 4/4] Remove unused 'target' field in virDomainHostdevDef

2011-05-27 Thread Daniel P. Berrange
The virDomainHostdevDef struct contains a 'char *target' field. This is set to 'NULL' when parsing XML and never used / set anywhere else. Clearly it is bogus unused * src/conf/domain_conf.c, src/conf/domain_conf.h: Remove target from virDomainHostdevDef --- src/conf/domain_conf.c |2 --

[libvirt] [PATCH 3/4] Allow custom XML to be passed in during migration

2011-05-27 Thread Daniel P. Berrange
Update the qemuDomainMigrateBegin method so that it accepts an optional incoming XML document. This will be validated for ABI compatibility against the current domain config, and if this check passes, will be passed back out for use by the qemuDomainMigratePrepare method on the target *

[libvirt] [PATCH 2/4] Allow virsh to pass in a custom XML document for migration

2011-05-27 Thread Daniel P. Berrange
Switch virsh migrate over to use virDomainMigrate2 and virDomainMigrateToURI2. This is still compatible with older libvirts, because these methods dynamically choose whether to perform v1, v2 or v3 migration based on declared RPC support from the libvirtd instances Add a --xml arg which allows

Re: [libvirt] [PATCH] storage: List directory volumes for dir/fs/netfs pools

2011-05-27 Thread Richard W.M. Jones
On Thu, May 26, 2011 at 01:25:24PM -0600, Eric Blake wrote: On 05/26/2011 12:58 PM, Daniel P. Berrange wrote: On Thu, May 26, 2011 at 02:10:24PM -0400, Cole Robinson wrote: Since directories can be used for filesystem passthrough, they are basically storage volumes. Not sure if anyone has

Re: [libvirt] [PATCH] Ensure hvsupport.html.in is built before HTML validation

2011-05-27 Thread Richard W.M. Jones
On Fri, May 27, 2011 at 11:17:37AM +0100, Daniel P. Berrange wrote: In a parallel make, HTML validation tries to run before hvsupport.html.in has been built. * docs/Makefile.am: List hvsupport.html.in as a built source --- docs/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0

Re: [libvirt] [PATCH] Ensure hvsupport.html.in is built before HTML validation

2011-05-27 Thread Daniel Veillard
On Fri, May 27, 2011 at 11:17:37AM +0100, Daniel P. Berrange wrote: In a parallel make, HTML validation tries to run before hvsupport.html.in has been built. * docs/Makefile.am: List hvsupport.html.in as a built source --- docs/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0

Re: [libvirt] [PATCHv4 1/7] interface: new public API for network config change transactions

2011-05-27 Thread Daniel P. Berrange
On Thu, May 26, 2011 at 12:17:39PM -0400, Laine Stump wrote: From: Michal Privoznik mpriv...@redhat.com No change from previously ACKed patch. This is the API agreed on in: https://www.redhat.com/archives/libvir-list/2011-May/msg00026.html (with a slight name change to use ...begin

[libvirt] [PATCH] sexpr: Improve serialization error reporting

2011-05-27 Thread Matthias Bolte
--- src/util/sexpr.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/util/sexpr.c b/src/util/sexpr.c index d8d4c2d..0e30087 100644 --- a/src/util/sexpr.c +++ b/src/util/sexpr.c @@ -215,7 +215,7 @@ sexpr2string(const struct sexpr *sexpr, virBufferPtr buffer)

Re: [libvirt] [PATCHv4 2/7] interface: define internal driver API for network config transactions

2011-05-27 Thread Daniel P. Berrange
On Thu, May 26, 2011 at 12:17:40PM -0400, Laine Stump wrote: From: Michal Privoznik mpriv...@redhat.com No change from previous version of ACKed patch. --- src/driver.h | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/driver.h b/src/driver.h index

Re: [libvirt] [PATCHv4 3/7] interface: implement public APIs for libvirt transactional network changes

2011-05-27 Thread Daniel P. Berrange
On Thu, May 26, 2011 at 12:17:41PM -0400, Laine Stump wrote: From: Michal Privoznik mpriv...@redhat.com change from previous version: modified to be the same code style as other libvirt public API functions. --- src/libvirt.c | 182

Re: [libvirt] [PATCHv4 4/7] interface: implement remote protocol for network config transaction API

2011-05-27 Thread Daniel P. Berrange
On Thu, May 26, 2011 at 12:17:42PM -0400, Laine Stump wrote: From: Michal Privoznik mpriv...@redhat.com No change from previously ACKed patch --- src/remote/remote_driver.c |3 +++ src/remote/remote_protocol.x | 17 - src/remote_protocol-structs |9 +

Re: [libvirt] [PATCHv4 5/7] interface: expose network config transaction API to virsh

2011-05-27 Thread Daniel P. Berrange
On Thu, May 26, 2011 at 12:17:43PM -0400, Laine Stump wrote: From: Michal Privoznik mpriv...@redhat.com This implements the commands iface-begin, iface-commit, and iface-rollback, which simply call the corresponding functions in the libvirt API. change from previous version: follow the

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Jean-Baptiste Rouault
On Friday 27 May 2011 13:51:05 Matthias Bolte wrote: We need distinguish between getline returning -1 because of EOF and because of another error. I missed this problem in the other regression fix and posted a follow up patch [1] for this. I propose the attached patch as v2 for you patch. I

Re: [libvirt] [PATCHv4 6/7] interface: Implement driver methods for network config transaction API

2011-05-27 Thread Daniel P. Berrange
On Thu, May 26, 2011 at 12:17:44PM -0400, Laine Stump wrote: From: Michal Privoznik mpriv...@redhat.com This is the functionality at the end of the libvirt part of the call chain - for each function, the corresponding netcf API is called. Change from previous version: modify the error log

Re: [libvirt] [PATCHv4 7/7] interface: implement a test driver for network config transaction API.

2011-05-27 Thread Daniel P. Berrange
On Thu, May 26, 2011 at 12:17:45PM -0400, Laine Stump wrote: From: Michal Privoznik mpriv...@redhat.com Changes from previous version: 1) don't print extra/incorrect error on format failure. 2) use cleanup: instead of no_memory: and end: 3) always clear out the destination list at the

Re: [libvirt] [PATCH] sexpr: Improve serialization error reporting

2011-05-27 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 03:09:36PM +0200, Matthias Bolte wrote: --- src/util/sexpr.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/util/sexpr.c b/src/util/sexpr.c index d8d4c2d..0e30087 100644 --- a/src/util/sexpr.c +++ b/src/util/sexpr.c @@

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Daniel Veillard
On Fri, May 27, 2011 at 03:12:26PM +0200, Jean-Baptiste Rouault wrote: On Friday 27 May 2011 13:51:05 Matthias Bolte wrote: We need distinguish between getline returning -1 because of EOF and because of another error. I missed this problem in the other regression fix and posted a follow

Re: [libvirt] [PATCH] sexpr: Improve serialization error reporting

2011-05-27 Thread Matthias Bolte
2011/5/27 Daniel P. Berrange berra...@redhat.com: On Fri, May 27, 2011 at 03:09:36PM +0200, Matthias Bolte wrote: ---  src/util/sexpr.c |   12 +---  1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/util/sexpr.c b/src/util/sexpr.c index d8d4c2d..0e30087 100644 ---

Re: [libvirt] [PATCHv6 0/6] Add virNodeGetCPUStats() API

2011-05-27 Thread Daniel P. Berrange
On Wed, May 25, 2011 at 03:01:29PM +0900, Minoru Usui wrote: Hi, This is v6 of virNodeGetCPUTimeParameters() API. (This time, I rename it to virNodeGetCPUStats()) It returns cpu utilization or cumulative cpu time of the node from /proc/stat since node boots up. This patch only supports

Re: [libvirt] [PATCH 0/6] Add virNodeGetMemoryStats() API

2011-05-27 Thread Daniel P. Berrange
On Wed, May 25, 2011 at 05:53:02PM +0900, Minoru Usui wrote: Hi, everyone. I wrote new API called virNodeGetMemoryStats(). It returns total/free/buffer/cached memory of the node from /proc/meminfo. The user I/F is like virNodeGetCPUStats(). Previous discussion is here. (See about

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Matthias Bolte
2011/5/27 Daniel Veillard veill...@redhat.com: On Fri, May 27, 2011 at 03:12:26PM +0200, Jean-Baptiste Rouault wrote: On Friday 27 May 2011 13:51:05 Matthias Bolte wrote: We need distinguish between getline returning -1 because of EOF and because of another error. I missed this problem in

Re: [libvirt] [PATCHv6 0/6] Add virNodeGetCPUStats() API

2011-05-27 Thread Daniel Veillard
On Fri, May 27, 2011 at 02:34:50PM +0100, Daniel P. Berrange wrote: On Wed, May 25, 2011 at 03:01:29PM +0900, Minoru Usui wrote: Hi, This is v6 of virNodeGetCPUTimeParameters() API. (This time, I rename it to virNodeGetCPUStats()) It returns cpu utilization or cumulative cpu time

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Jean-Baptiste Rouault
On Friday 27 May 2011 16:01:32 Matthias Bolte wrote: Thanks, pushed then. There are other usages of getline in the OpenVZ driver, but they should all be safe because they don't distinguish between 0 and -1, except openvzGetProcessInfo. Jean-Baptiste could you test virsh dominfo of a

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Matthias Bolte
2011/5/27 Jean-Baptiste Rouault jean-baptiste.roua...@diateam.net: On Friday 27 May 2011 16:01:32 Matthias Bolte wrote: Thanks, pushed then. There are other usages of getline in the OpenVZ driver, but they should all be safe because they don't distinguish between 0 and -1, except

[libvirt] [PATCH] openvz: Restore original EOF handling in openvzGetProcessInfo

2011-05-27 Thread Matthias Bolte
This function is also affected by getline conversion. But this didn't result in a regression in general, because the difference whould only affect the behavior of the function when the line in /proc/vz/vestat for the given vpsid wasn't found. Under normal conditions this should not happen. ---

Re: [libvirt] [PATCH] Add domainCoreDump to libxl driver

2011-05-27 Thread Jim Fehlig
Markus Groß wrote: Quoting Jim Fehlig jfeh...@novell.com: Markus Groß wrote: For core dumping to work correctly the following patch for xen is needed: http://lists.xensource.com/archives/html/xen-devel/2011-05/msg01469.html This patch is in xen-unstable and is considered for backport to

Re: [libvirt] [Qemu-devel] [RFC] live snapshot, live merge, live block migration

2011-05-27 Thread Stefan Hajnoczi
On Mon, May 23, 2011 at 2:02 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sun, May 22, 2011 at 10:52 AM, Dor Laor dl...@redhat.com wrote: On 05/20/2011 03:19 PM, Stefan Hajnoczi wrote: I'm interested in what the API for snapshots would look like. Specifically how does user software do the

Re: [libvirt] [PATCH] interface: reformat error logs

2011-05-27 Thread Laine Stump
On 05/26/2011 01:27 PM, Eric Blake wrote: On 05/26/2011 11:18 AM, Laine Stump wrote: It was suggested during review of a different patch that the libvirt interface driver API's should have netcf: in their log messages. This patch eliminates that from all interface driver API functions, and also

Re: [libvirt] [PATCHv4 0/7] interface: new public API for network config change transactions

2011-05-27 Thread Laine Stump
On 05/27/2011 02:42 AM, Daniel Veillard wrote: ACK from me for the whole set, please push :-) Daniel Thanks to both Dans for all the reviews! I just pushed the series, and will be releasing a new upstream netcf over the weekend so that interested parties can experiment. -- libvir-list

Re: [libvirt] [PATCH] nwfilter: reorder locks

2011-05-27 Thread Stefan Berger
On 05/26/2011 03:19 PM, Eric Blake wrote: On 05/11/2011 02:36 PM, Stefan Berger wrote: This patch reorders the locks for the nwfilter updates and the access the nwfilter objects. In the case that the IP address learning thread was instantiating filters while an update happened, the previous