Re: [libvirt] virsh version problem with remote connection

2011-06-01 Thread Daniel P. Berrange
On Tue, May 31, 2011 at 11:52:12PM +0200, Matthias Bolte wrote: virsh version does basically this hvType = virConnectGetType(...) virGetVersion(..., hvType, ...) [...] Assuming a remote connection virConnectGetType calls the remote driver that returns the type of the underlying driver on

Re: [libvirt] [Libvirt-announce] Libvirt 0.9.2 week freeze, RC1 version to test

2011-06-01 Thread Matthias Bolte
2011/5/29 Daniel Veillard veill...@redhat.com:  So we are entering the week freeze for the new version. I have made an rc1 tarball available at:    ftp://libvirt.org/libvirt/libvirt-0.9.2-rc1.tar.gz I also made rpms too for those interested. I didn't included the locking patches from Dan

[libvirt] [PATCH] openvz: Set virtType to openvz in openvzLoadDomains

2011-06-01 Thread Matthias Bolte
Otherwise virsh dumpxml will report domain type='qemu' instead of the expected domain type='openvz'. --- I pushed this one as Eric already ACK'ed it as part of another patch [1] where I accientially included it and Jean-Baptiste confirmed that the problem exists [2]. [1]

Re: [libvirt] [PATCH] openvz: fix bridge devices parsing in openvzReadNetworkConf()

2011-06-01 Thread Matthias Bolte
2011/5/31 Jean-Baptiste Rouault jean-baptiste.roua...@diateam.net: On Tuesday 31 May 2011 14:41:55 Matthias Bolte wrote: I also added a testcase and looked at the other config parsing code in the OpenVZ driver. I thing that openvzLoadDomains is missing this line:   dom-def-virtType =

[libvirt] [PATCH 0/2] libxl driver additions

2011-06-01 Thread Markus Groß
I know it is very late for 0.9.2 but perhabs we could squeeze these patches in (then the version numbers of the functions in patch 2 have to be changed to 0.9.2). Markus Groß (2): Get maximum memory of running domain in libxl driver Add managedSave support to libxl driver

[libvirt] [PATCH 1/2] Get maximum memory of running domain in libxl driver

2011-06-01 Thread Markus Groß
--- src/libxl/libxl_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 3491f40..61c3494 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -1639,6 +1639,7 @@

[libvirt] [PATCH 2/2] Add managedSave support to libxl driver

2011-06-01 Thread Markus Groß
--- src/libxl/libxl_driver.c | 353 -- 1 files changed, 276 insertions(+), 77 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 61c3494..9bcc3b9 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@

Re: [libvirt] [Libvirt-announce] Libvirt 0.9.2 week freeze, RC1 version to test

2011-06-01 Thread Ruben Kerkhof
On Wed, Jun 1, 2011 at 10:31, Matthias Bolte matthias.bo...@googlemail.com wrote: 2011/5/29 Daniel Veillard veill...@redhat.com:  So we are entering the week freeze for the new version. I have made an rc1 tarball available at:    ftp://libvirt.org/libvirt/libvirt-0.9.2-rc1.tar.gz I also made

Re: [libvirt] [PATCH 2/2] Add managedSave support to libxl driver

2011-06-01 Thread Markus Groß
Forgot to mention that most of this patch is duplicated from the qemu driver (perhabs this helps in testing and review). Am Mittwoch 01 Juni 2011 12:55:34 schrieb Markus Groß: --- src/libxl/libxl_driver.c | 353 -- 1 files changed, 276

[libvirt] Git write access for wrote C# bindings

2011-06-01 Thread Anthony Fox
Hi all! I wanna try to get help with C# bindings. I ask Arnaud Champion to get me git write access. He wrote that I should write to the mailing list. Can someone get me access? -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Git write access for wrote C# bindings

2011-06-01 Thread Matthias Bolte
2011/6/1 Anthony Fox a.podava...@gmail.com: Hi all! I wanna try to get help with C# bindings. I ask Arnaud Champion to get me git write access. He wrote that I should write to the mailing list. Can someone get me access? As already state in IRC you should just work on the C# bindings if you

Re: [libvirt] [PATCH] Use common parameter order for remote(De)SerializeTypedParameters

2011-06-01 Thread Matthias Bolte
2011/5/31 Eric Blake ebl...@redhat.com: On 05/30/2011 12:33 PM, Matthias Bolte wrote: We commonly use value, length order, let's stick to this. ---  daemon/remote.c            |   40  src/remote/remote_driver.c |   40

Re: [libvirt] [PATCH] Remove call to deprecated gnutls_certificate_type_set_priority

2011-06-01 Thread Jiri Denemark
On Wed, Jun 01, 2011 at 13:24:26 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The gnutls_certificate_type_set_priority method is deprecated. Since we already set the default gnutls priority, and do not support OpenGPG credentials in any case, it was not

Re: [libvirt] remote generator: Legacy support for hyper to long mappings

2011-06-01 Thread Matthias Bolte
2011/5/31 Eric Blake ebl...@redhat.com: On 05/30/2011 07:03 AM, Matthias Bolte wrote: From 726dae7b4c21d4c17ac19808c06d7fc978b36778 Mon Sep 17 00:00:00 2001 From: Matthias Bolte matthias.bo...@googlemail.com Date: Mon, 30 May 2011 12:58:57 +0200 Subject: [PATCH] remote generator: Legacy

Re: [libvirt] [libvirt 2/2] remote generator: Legacy support for hyper to long mappings

2011-06-01 Thread Matthias Bolte
2011/5/31 Eric Blake ebl...@redhat.com: On 05/30/2011 07:03 AM, Matthias Bolte wrote: From 3bb05f7543f86e3b47772f0fabecbda4f167b3bc Mon Sep 17 00:00:00 2001 From: Matthias Bolte matthias.bo...@googlemail.com Date: Mon, 30 May 2011 14:36:41 +0200 Subject: [PATCH] apibuild: Restrict long usage

[libvirt] [PATCH 2/2] tests: Add a test for correct disk device ordering

2011-06-01 Thread Jiri Denemark
--- .../qemuxml2argvdata/qemuxml2argv-disk-order.args | 20 +++ tests/qemuxml2argvdata/qemuxml2argv-disk-order.xml | 37 tests/qemuxml2argvtest.c |2 + 3 files changed, 59 insertions(+), 0 deletions(-) create mode 100644

[libvirt] [PATCH 1/2] Fix order of disks and controllers

2011-06-01 Thread Jiri Denemark
Commit 2d6adabd53c8f1858191d521dc9b4948d1205955 replaced qsorting disk and controller devices with inserting them at the right position. That was to fix unnecessary reordering of devices. However, when parsing domain XML devices are just taken in the order in which they appear in the XML since.

[libvirt] [PATCH] Fix QEMU XML-2-ARGV graphics-spice-timeout test

2011-06-01 Thread Matthias Bolte
The test used an emulator that is not supported in testutilsqemu.c. Swicth from qemu-kvm to kvm to fix this. --- This patch addresses the problem discussed here: https://www.redhat.com/archives/libvir-list/2011-May/msg01914.html .../qemuxml2argv-graphics-spice-timeout.args |2 +-

Re: [libvirt] [PATCH 2/2] tests: Add a test for correct disk device ordering

2011-06-01 Thread Eric Blake
On 06/01/2011 09:58 AM, Jiri Denemark wrote: --- .../qemuxml2argvdata/qemuxml2argv-disk-order.args | 20 +++ tests/qemuxml2argvdata/qemuxml2argv-disk-order.xml | 37 tests/qemuxml2argvtest.c |2 + 3 files changed, 59

Re: [libvirt] [PATCH] Fix QEMU XML-2-ARGV graphics-spice-timeout test

2011-06-01 Thread Eric Blake
On 06/01/2011 10:13 AM, Matthias Bolte wrote: The test used an emulator that is not supported in testutilsqemu.c. Swicth from qemu-kvm to kvm to fix this. s/Swicth/Switch/ --- This patch addresses the problem discussed here:

[libvirt] [PATCH 7/7] test: Python Unittests for DomainBlockPull API

2011-06-01 Thread Adam Litke
*** Please do not consider for merging, example tests only *** Here are the testcases I am currently running to verify the correctness of this API. These are continuing to evolve. Signed-off-by: Adam Litke a...@us.ibm.com --- blockPull-test.py | 215

[libvirt] [PATCH 3/7] Implement virDomainBlockPull for the qemu driver

2011-06-01 Thread Adam Litke
The virDomainBlockPull* family of commands are enabled by the 'block_stream' and 'info block_stream' qemu monitor commands. * src/qemu/qemu_driver.c src/qemu/qemu_monitor_text.[ch]: implement disk streaming by using the stream and info stream text monitor commands *

[libvirt] [PATCH 6/7] Asynchronous event for BlockPull completion

2011-06-01 Thread Adam Litke
When an operation started by virDomainBlockPullAll completes (either with success or with failure), raise an event to indicate the final status. This allows an API user to avoid polling on virDomainBlockPullInfo if they would prefer to use the event mechanism. * daemon/remote.c: Dispatch events

[libvirt] [PATCH 5/7] Enable virDomainBlockPull in the python API.

2011-06-01 Thread Adam Litke
virDomainBlockPullAll and virDomainBlockPullAbort are handled automatically. virDomainBlockPull and virDomainBlockPullInfo require manual overrides since they return a custom type. * python/generator.py: reenable bindings for this entry point * python/libvirt-override-api.xml

[libvirt] [PATCH 4/7] Enable the virDomainBlockPull API in virsh

2011-06-01 Thread Adam Litke
Define three new virsh commands: * blockpull: Perform incremental block pull * blockpull: Start/stop full device block pull * blockpullinfo: Retrieve progress info for full device block pull Share print_job_progress() with the migration code. * tools/virsh.c: implement the new commands

[libvirt] [PATCH 2/7] Add virDomainBlockPull support to the remote driver. The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be written

2011-06-01 Thread Adam Litke
* src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c: implement the client and server side * daemon/remote_generator.pl: Specify the manually-written functions Signed-off-by: Adam Litke a...@us.ibm.com --- daemon/remote.c

[libvirt] RFC: Add virDomainBlockPull API family to libvirt

2011-06-01 Thread Adam Litke
To help speed the provisioning process for large domains, new QED disks are created with backing to a template image. These disks are configured with copy on read such that blocks that are read from the backing file are copied to the new disk. This reduces I/O over a potentially costly path to

[libvirt] [PATCH 1/7] virDomainBlockPull: Add public symbols to libvirt API

2011-06-01 Thread Adam Litke
* src/libvirt.c: implement the main entry points * src/libvirt_public.syms: add them to the exported symbols Signed-off-by: Adam Litke a...@us.ibm.com --- src/libvirt.c | 252 +++ src/libvirt_public.syms |7 ++ 2 files changed, 259

Re: [libvirt] [PATCH 2/7] Add virDomainBlockPull support to the remote driver. The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be wri

2011-06-01 Thread Matthias Bolte
2011/6/1 Adam Litke a...@us.ibm.com: This commit has a pretty long summary line. * src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c: implement the client and  server side * daemon/remote_generator.pl: Specify the

Re: [libvirt] [PATCH 2/2] tests: Add a test for correct disk device ordering

2011-06-01 Thread Jiri Denemark
On Wed, Jun 01, 2011 at 10:13:13 -0600, Eric Blake wrote: On 06/01/2011 09:58 AM, Jiri Denemark wrote: --- .../qemuxml2argvdata/qemuxml2argv-disk-order.args | 20 +++ tests/qemuxml2argvdata/qemuxml2argv-disk-order.xml | 37 tests/qemuxml2argvtest.c

Re: [libvirt] [PATCH] remote generator: Handle some virTypedParameterPtr using functions

2011-06-01 Thread Matthias Bolte
2011/5/31 Eric Blake ebl...@redhat.com: On 05/30/2011 12:34 PM, Matthias Bolte wrote: This doesn't cover the getters that allow to query nparams yet. --- This patch depends on https://www.redhat.com/archives/libvir-list/2011-May/msg01856.html  daemon/remote.c              |  182

Re: [libvirt] [PATCH 2/7] Add virDomainBlockPull support to the remote driver. The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be wri

2011-06-01 Thread Matthias Bolte
2011/6/1 Adam Litke a...@us.ibm.com: * src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c: implement the client and  server side * daemon/remote_generator.pl: Specify the manually-written functions Signed-off-by: Adam Litke

Re: [libvirt] [PATCH] Fix QEMU XML-2-ARGV graphics-spice-timeout test

2011-06-01 Thread Matthias Bolte
2011/6/1 Eric Blake ebl...@redhat.com: On 06/01/2011 10:13 AM, Matthias Bolte wrote: The test used an emulator that is not supported in testutilsqemu.c. Swicth from qemu-kvm to kvm to fix this. s/Swicth/Switch/ My typo rate is quite high recently. --- This patch addresses the problem

[libvirt] [PATCH] Add new API virDomainBlockPull* to header and drivers

2011-06-01 Thread Adam Litke
Set up the types for the block pull functions and insert them into the virDriver structure definition. Because of static initializers, update every driver and set the new fields to NULL. * include/libvirt/libvirt.h.in: new API * src/driver.h src/*/*_driver.c src/vbox/vbox_tmpl.c: add the new

Re: [libvirt] [PATCH 2/7] Add virDomainBlockPull support to the remote driver. The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be wri

2011-06-01 Thread Adam Litke
On 06/01/2011 12:13 PM, Matthias Bolte wrote: 2011/6/1 Adam Litke a...@us.ibm.com: This commit has a pretty long summary line. Fixed. * src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c: implement the client and server

Re: [libvirt] [PATCH 2/7] Add virDomainBlockPull support to the remote driver. The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be wri

2011-06-01 Thread Adam Litke
On 06/01/2011 12:27 PM, Matthias Bolte wrote: 2011/6/1 Adam Litke a...@us.ibm.com: * src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c: implement the client and server side * daemon/remote_generator.pl: Specify the

[libvirt] [PATCH] build: avoid corrupting / in RHEL 5

2011-06-01 Thread Eric Blake
I noticed this while building from libvirt.git on RHEL 5.6: Generating internals/command.html.tmp mkdir: cannot create directory `/internals': Permission denied If I had been building as root instead, this pollutes /. Older autoconf lacks $(builddir), but it is rigorously equal to '.' in newer

Re: [libvirt] [PATCH] Add new API virDomainBlockPull* to header and drivers

2011-06-01 Thread Adam Litke
Sorry, this one was left off from the initial post. It comes first in the series. -- Adam Litke IBM Linux Technology Center -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Add new API virDomainBlockPull* to header and drivers

2011-06-01 Thread Matthias Bolte
2011/6/1 Adam Litke a...@us.ibm.com: Set up the types for the block pull functions and insert them into the virDriver structure definition.  Because of static initializers, update every driver and set the new fields to NULL. * include/libvirt/libvirt.h.in: new API * src/driver.h

Re: [libvirt] [PATCH 2/7] Add virDomainBlockPull support to the remote driver. The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be wri

2011-06-01 Thread Matthias Bolte
2011/6/1 Adam Litke a...@us.ibm.com: On 06/01/2011 12:13 PM, Matthias Bolte wrote: 2011/6/1 Adam Litke a...@us.ibm.com: This commit has a pretty long summary line. Fixed. * src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c:

Re: [libvirt] [PATCH 2/7] Add virDomainBlockPull support to the remote driver. The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be wri

2011-06-01 Thread Matthias Bolte
2011/6/1 Adam Litke a...@us.ibm.com: On 06/01/2011 12:27 PM, Matthias Bolte wrote: 2011/6/1 Adam Litke a...@us.ibm.com: * src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c: implement the client and  server side *

Re: [libvirt] [PATCH v2] screenshot: Expose the new API in virsh

2011-06-01 Thread Eric Blake
On 05/16/2011 10:57 AM, Michal Privoznik wrote: * tools/virsh.c: Add screenshot command * tools/virsh.pod: Document new command * src/libvirt.c: Fix off-be-one error --- diff to v1: - make filename optional and generate filename when missing + +static int cmdScreenshotSink(virStreamPtr

Re: [libvirt] [PATCH] Fix netdev detection on RHEL6x versions of qemu

2011-06-01 Thread Eric Blake
On 05/24/2011 03:42 AM, Neil Wilson wrote: On Tue, 2011-05-24 at 10:37 +0100, Daniel P. Berrange wrote: Use the libvirt that ships with RHEL6, or apply the RHEL6 specific patches manually when building an alternative libvirt for RHEL6. It isn't sustainable for upstream projects to deal with

Re: [libvirt] [PATCH 1/4] qemu: Convert virExec usage to virCommand

2011-06-01 Thread Eric Blake
On 05/17/2011 09:06 AM, Cole Robinson wrote: v2: Have virCommand cleanup intermediate process for us v3: Preserve original FD closing behavior Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c | 26 --

Re: [libvirt] [PATCH 2/4] util: Remove unused virExec wrapper

2011-06-01 Thread Eric Blake
On 05/17/2011 09:06 AM, Cole Robinson wrote: v3: Remove obsolete comment Signed-off-by: Cole Robinson crobi...@redhat.com --- cfg.mk |1 - src/libvirt_private.syms |1 - src/util/util.c | 35 --- src/util/util.h

Re: [libvirt] [PATCH 3/4] util: Implement virRun as a wrapper around virCommand

2011-06-01 Thread Eric Blake
On 05/17/2011 09:06 AM, Cole Robinson wrote: v2: Simplify command building Handle command building failure v3: Remove unneeded NULL check Signed-off-by: Cole Robinson crobi...@redhat.com --- src/util/util.c | 73 +++

Re: [libvirt] [PATCH 4/4] Move virRun, virExec*, virFork to util/command

2011-06-01 Thread Eric Blake
On 05/17/2011 09:06 AM, Cole Robinson wrote: Seems reasonable to have all command wrappers in the same place v2: Dont move SetInherit v3: Comment spelling fix Adjust WARN0 comment Remove spurious #include movement Don't include sys/types.h Combine virExec enums

Re: [libvirt] [PATCH 4/4] Move virRun, virExec*, virFork to util/command

2011-06-01 Thread Cole Robinson
On 06/01/2011 03:52 PM, Eric Blake wrote: On 05/17/2011 09:06 AM, Cole Robinson wrote: Seems reasonable to have all command wrappers in the same place v2: Dont move SetInherit v3: Comment spelling fix Adjust WARN0 comment Remove spurious #include movement Don't

Re: [libvirt] [PATCH] build: avoid corrupting / in RHEL 5

2011-06-01 Thread Jiri Denemark
On Wed, Jun 01, 2011 at 11:52:00 -0600, Eric Blake wrote: I noticed this while building from libvirt.git on RHEL 5.6: Generating internals/command.html.tmp mkdir: cannot create directory `/internals': Permission denied If I had been building as root instead, this pollutes /. Older

Re: [libvirt] [PATCH] build: avoid corrupting / in RHEL 5

2011-06-01 Thread Eric Blake
On 06/01/2011 02:30 PM, Jiri Denemark wrote: On Wed, Jun 01, 2011 at 11:52:00 -0600, Eric Blake wrote: I noticed this while building from libvirt.git on RHEL 5.6: Generating internals/command.html.tmp mkdir: cannot create directory `/internals': Permission denied If I had been building as

[libvirt] [PATCH] tests: really fix QEMU XML-2-ARGV graphics-spice-timeout test

2011-06-01 Thread Eric Blake
Alas, /usr/bin/kvm is also not directly supported by testutilsqemu.c. In fact, _any_ test that uses cpu match=... has to use our faked qemu.sh in order to properly answer the 'qemu -cpu ?' probe done during qemu command line building. * tests/qemuxml2argvdata/*graphics-spice-timeout*: Switch

Re: [libvirt] [PATCH] security: plug regression introduced in disk probe logic

2011-06-01 Thread Eric Blake
On 05/31/2011 05:35 PM, Eric Blake wrote: Regression introduced in commit d6623003 (v0.8.8) - using the wrong sizeof operand meant that security manager private data was overlaying the allowDiskFOrmatProbing member of struct _virSecurityManager. This reopens disk probing, which was supposed

Re: [libvirt] [PATCH] security: plug regression introduced in disk probe logic

2011-06-01 Thread Matthias Bolte
2011/6/1 Eric Blake ebl...@redhat.com: Regression introduced in commit d6623003 (v0.8.8) - using the wrong sizeof operand meant that security manager private data was overlaying the allowDiskFOrmatProbing member of struct s/FOrmat/Format/ _virSecurityManager.  This reopens disk probing,

Re: [libvirt] [PATCH] security: plug regression introduced in disk probe logic

2011-06-01 Thread Matthias Bolte
2011/6/2 Eric Blake ebl...@redhat.com: On 05/31/2011 05:35 PM, Eric Blake wrote: Regression introduced in commit d6623003 (v0.8.8) - using the wrong sizeof operand meant that security manager private data was overlaying the allowDiskFOrmatProbing member of struct _virSecurityManager.  This

Re: [libvirt] [PATCH] security: plug regression introduced in disk probe logic

2011-06-01 Thread Eric Blake
On 06/01/2011 04:52 PM, Matthias Bolte wrote: +++ b/src/security/security_manager.c @@ -107,7 +107,7 @@ virSecurityManagerPtr virSecurityManagerNew(const char *name, void *virSecurityManagerGetPrivateData(virSecurityManagerPtr mgr) { -return ((char*)mgr) + sizeof(mgr); +return

Re: [libvirt] [PATCHv6 0/6] Add virNodeGetCPUStats() API

2011-06-01 Thread Minoru Usui
On Tue, 31 May 2011 14:50:30 -0600 Eric Blake ebl...@redhat.com wrote: On 05/29/2011 07:54 PM, Minoru Usui wrote: So I wonder if we should add a parameter for the CPU num to the API: int virNodeGetCPUStats (virConnectPtr conn,