Re: [libvirt] Building on Solaris 11 Express

2011-06-03 Thread Matthias Bolte
2011/6/3 Ruben Kerkhof ru...@rubenkerkhof.com: On Mon, May 30, 2011 at 08:52, Matthias Bolte matthias.bo...@googlemail.com wrote: 2011/5/30 Ruben Kerkhof ru...@rubenkerkhof.com: On Sun, May 29, 2011 at 19:45, Matthias Bolte matthias.bo...@googlemail.com wrote: 2011/5/29 Richard Laager

[libvirt] [PATCH] qemu: Parse current balloon value returned by query_balloon.

2011-06-03 Thread Osier Yang
Qemu once supported following memory stats which will returned by query_balloon: stat_put(dict, actual, actual); stat_put(dict, mem_swapped_in, dev-stats[VIRTIO_BALLOON_S_SWAP_IN]); stat_put(dict, mem_swapped_out, dev-stats[VIRTIO_BALLOON_S_SWAP_OUT]); stat_put(dict,

Re: [libvirt] [PATCH] qemu: Parse current balloon value returned by query_balloon.

2011-06-03 Thread Matthias Bolte
2011/6/3 Osier Yang jy...@redhat.com: Qemu once supported following memory stats which will returned by query_balloon:    stat_put(dict, actual, actual);    stat_put(dict, mem_swapped_in, dev-stats[VIRTIO_BALLOON_S_SWAP_IN]);    stat_put(dict, mem_swapped_out,

Re: [libvirt] [PATCH v2 1/3] unify PARAM_CURRENT/PARAM_LIVE/PARAM_CONFIG flags

2011-06-03 Thread Daniel P. Berrange
On Fri, Jun 03, 2011 at 10:15:29AM +0800, Hu Tao wrote: This patch unify the PARAM_CURRENT/PARAM_LIVE/PARAM_CONFIG flags as Daniel Veillard suggested. --- include/libvirt/libvirt.h.in | 58 - src/esx/esx_driver.c | 10 +- src/libvirt.c|4 +-

Re: [libvirt] [Libvirt-announce] Libvirt 0.9.2 week freeze, RC2 available

2011-06-03 Thread Matthias Bolte
2011/6/2 Daniel Veillard veill...@redhat.com:  I just pushed a second release candidate    ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz with corresponding rpm builds, this includes the extrenal lock support. On Wed, Jun 01, 2011 at 12:49:52PM +0200, Ruben Kerkhof wrote: On Wed, Jun 1,

Re: [libvirt] [PATCH 1/7] check whether qemu supports multi function PCI device

2011-06-03 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 06:19:42PM +0800, Wen Congyang wrote: qemu supports multi function PCI device after version 0.13.0. --- src/qemu/qemu_capabilities.c |5 + src/qemu/qemu_capabilities.h |1 + tests/qemuhelptest.c |3 ++- 3 files changed, 8 insertions(+), 1

Re: [libvirt] [PATCH 2/7] prevent hot unplugging multi function PCI device

2011-06-03 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 06:20:10PM +0800, Wen Congyang wrote: We do not support to hot unplug multi function PCI device now. If the device is one function of multi function PCI device, we shoul not allow to hot unplugg it. --- src/qemu/qemu_hotplug.c | 52

Re: [libvirt] [PATCH 3/7] the key of hash table should include the function value

2011-06-03 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 06:20:41PM +0800, Wen Congyang wrote: We save all used PCI address in the hash table. The key is generated by domain, bus and slot now. We will support multi function PCI device, so the key should be generated by domain, bus, slot and function. ---

Re: [libvirt] [PATCH 5/7] assign the whole slot to the PCI device that has no address

2011-06-03 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 06:22:08PM +0800, Wen Congyang wrote: If user does not specify the PCI address, we should auto assign an unused slot. --- src/qemu/qemu_command.c | 36 1 files changed, 32 insertions(+), 4 deletions(-) diff --git

Re: [libvirt] [PATCH 6/7] the hotplugged PCI device should use the whole slot

2011-06-03 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 06:22:34PM +0800, Wen Congyang wrote: Hot pluging/unpluging multi PCI device is not supported now. So the function of hotplugged PCI device must be 0. When we hot unplug it, we should set release all functions in the slot. --- src/qemu/qemu_command.c | 46

Re: [libvirt] [PATCH 4/7] Reimplement qemuDomainPCIAddressReserveSlot(): reserve all functions in the slot

2011-06-03 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 06:21:43PM +0800, Wen Congyang wrote: We will support multi function PCI device. So we should reserve all functions in the slot if we want to reserve a slot. --- src/qemu/qemu_command.c | 37 ++--- src/qemu/qemu_command.h |4

Re: [libvirt] [PATCH 7/7] support multifunction PCI device

2011-06-03 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 06:23:16PM +0800, Wen Congyang wrote: If qemu supports multi function PCI device, the format of the PCI address passed to qemu is bus=pci.0,multifunction=on,addr=slot.function. If qemu does not support multi function PCI device, the format of the PCI address

Re: [libvirt] [PATCH V2 0/7] support multi function PCI device

2011-06-03 Thread Daniel P. Berrange
On Fri, May 27, 2011 at 06:17:21PM +0800, Wen Congyang wrote: We want to use more than 200+ device. Libvirt does not use multi function PCI device and PCI-to-PCI bridge. So we can not use more than 200+ device if it's a PCI device or it's controller is a PCI device. This patchset adds the

Re: [libvirt] [PATCH] Fix regressions BlockStats/Info APIs in QEMU driver

2011-06-03 Thread Daniel P. Berrange
On Thu, Jun 02, 2011 at 01:27:46PM -0600, Eric Blake wrote: On 06/02/2011 10:03 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The change 18c2a592064d69499f70428e498f4a3cb5161cda caused some regressions in behaviour of virDomainBlockStats and

Re: [libvirt] [Libvirt-announce] Libvirt 0.9.2 week freeze, RC2 available

2011-06-03 Thread Daniel Veillard
On Fri, Jun 03, 2011 at 01:27:04PM +0200, Matthias Bolte wrote: 2011/6/2 Daniel Veillard veill...@redhat.com:  I just pushed a second release candidate    ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz with corresponding rpm builds, this includes the extrenal lock support. On Wed,

Re: [libvirt] [PATCH 7/7] support multifunction PCI device

2011-06-03 Thread Eric Blake
On 05/27/2011 04:23 AM, Wen Congyang wrote: If qemu supports multi function PCI device, the format of the PCI address passed to qemu is bus=pci.0,multifunction=on,addr=slot.function. If qemu does not support multi function PCI device, the format of the PCI address passed to qemu is

Re: [libvirt] [PATCH 1/7] check whether qemu supports multi function PCI device

2011-06-03 Thread Eric Blake
On 05/27/2011 04:19 AM, Wen Congyang wrote: qemu supports multi function PCI device after version 0.13.0. After ( 0.13.0) or at least (= 0.13.0)? @@ -1024,6 +1026,9 @@ qemuCapsComputeCmdFlags(const char *help, */ if (version = 13000) qemuCapsSet(flags,

Re: [libvirt] [PATCH] qemu: Parse current balloon value returned by query_balloon.

2011-06-03 Thread Eric Blake
On 06/03/2011 02:24 AM, Osier Yang wrote: Qemu once supported following memory stats which will returned by query_balloon: stat_put(dict, actual, actual); stat_put(dict, mem_swapped_in, dev-stats[VIRTIO_BALLOON_S_SWAP_IN]); stat_put(dict, mem_swapped_out,

Re: [libvirt] [Libvirt-announce] Libvirt 0.9.2 week freeze, RC2 available

2011-06-03 Thread Daniel P. Berrange
On Fri, Jun 03, 2011 at 01:27:04PM +0200, Matthias Bolte wrote: 2011/6/2 Daniel Veillard veill...@redhat.com:  I just pushed a second release candidate    ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz with corresponding rpm builds, this includes the extrenal lock support. On Wed,

[libvirt] [PATCH] qemu: Avoid use after free in qemuCaps parsing

2011-06-03 Thread Jiri Denemark
--- src/qemu/qemu_domain.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 46414cd..332c09e 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -264,12 +264,13 @@ static int

Re: [libvirt] [PATCH 03/10] storage: avoid memory leak

2011-06-03 Thread Eric Blake
On 06/02/2011 06:38 PM, Daniel Veillard wrote: On Thu, Jun 02, 2011 at 05:07:55PM -0600, Eric Blake wrote: Coverity detected that options was being set by strdup but never freed. But why even bother with an options variable? The options parameter never changes! Leak present since commit

Re: [libvirt] [PATCH v2 1/3] unify PARAM_CURRENT/PARAM_LIVE/PARAM_CONFIG flags

2011-06-03 Thread Eric Blake
On 06/02/2011 08:15 PM, Hu Tao wrote: This patch unify the PARAM_CURRENT/PARAM_LIVE/PARAM_CONFIG flags as Daniel Veillard suggested. I concur with danpb's NACK. See how I kept existing enum names while adding a new consolidation enum in commit 824dcaf, as well as how I sunk deprecated enum

Re: [libvirt] [PATCH] qemu: Avoid use after free in qemuCaps parsing

2011-06-03 Thread Daniel P. Berrange
On Fri, Jun 03, 2011 at 04:34:30PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_domain.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 46414cd..332c09e 100644 --- a/src/qemu/qemu_domain.c +++

Re: [libvirt] [PATCH] qemu: Avoid use after free in qemuCaps parsing

2011-06-03 Thread Michal Prívozník
On 03.06.2011 16:34, Jiri Denemark wrote: --- src/qemu/qemu_domain.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 46414cd..332c09e 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@

Re: [libvirt] [PATCH] docs: Add doc for video element

2011-06-03 Thread Eric Blake
On 06/02/2011 03:45 AM, Osier Yang wrote: For backwards compatability, if no video is set but there is a s/compatability/compatibility/ graphics tag, then we add a default video according to the guest type. Add docs to tell the user about this to not make them confused. Especially if they

Re: [libvirt] [PATCH] Correct 'cputune' documentation example.

2011-06-03 Thread Eric Blake
On 06/03/2011 07:43 AM, Neil Wilson wrote: Signed-off-by: Neil Wilson n...@aldur.co.uk --- docs/formatdomain.html.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 0517119..225e0c8 100644 ---

Re: [libvirt] [Libvirt-announce] Libvirt 0.9.2 week freeze, RC2 available

2011-06-03 Thread Matthias Bolte
2011/6/3 Daniel P. Berrange berra...@redhat.com: On Fri, Jun 03, 2011 at 01:27:04PM +0200, Matthias Bolte wrote: 2011/6/2 Daniel Veillard veill...@redhat.com:  I just pushed a second release candidate    ftp://libvirt.org/libvirt/libvirt-0.9.2-rc2.tar.gz with corresponding rpm builds, this

Re: [libvirt] [PATCH] Use VIR_USE_CPU instead of new wheel

2011-06-03 Thread Eric Blake
On 06/02/2011 03:45 AM, Osier Yang wrote: * src/libxl/libxl_driver.c * src/qemu/qemu_process.c --- src/libxl/libxl_driver.c |7 ++- src/qemu/qemu_process.c | 13 ++--- 2 files changed, 4 insertions(+), 16 deletions(-) ACK. Trivial cleanup, so safe for 0.9.2.

Re: [libvirt] [PATCH v2 2/3] update qemuDomainGetBlkioParameters to use flags

2011-06-03 Thread Eric Blake
On 06/02/2011 08:15 PM, Hu Tao wrote: --- src/qemu/qemu_driver.c | 124 +--- 1 files changed, 86 insertions(+), 38 deletions(-) Caveat: I have not reviewed this closely. By mere description, this looks useful, and similar to other recent

Re: [libvirt] [PATCH] virsh: Document nodeinfo output

2011-06-03 Thread Eric Blake
On 06/02/2011 03:21 AM, Jiri Denemark wrote: --- tools/virsh.pod |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 9251db6..1f41652 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -235,7 +235,9 @@ Print the XML

Re: [libvirt] Building on Solaris 11 Express

2011-06-03 Thread Ruben Kerkhof
On Fri, Jun 3, 2011 at 16:16, Eric Blake ebl...@redhat.com wrote: On 06/03/2011 01:11 AM, Matthias Bolte wrote: That might be the problem. I don't have a Solaris at hand right now to test it so here is a speculative patch for this. And while I have access to a Solaris machine, I don't have

[libvirt] [PATCH] security driver: ignore EINVAL when chowning an image file

2011-06-03 Thread Laine Stump
This fixes: https://bugzilla.redhat.com/show_bug.cgi?id=702044 https://bugzilla.redhat.com/show_bug.cgi?id=709454 Both of these complain of a failure to use an image file that resides on a read-only NFS volume. The function in the DAC security driver that chowns image files to the qemu

Re: [libvirt] Building on Solaris 11 Express

2011-06-03 Thread Richard Laager
On Thu, 2011-06-02 at 17:33 +0200, Ruben Kerkhof wrote: In my default OpenIndiana b151 install, /usr/lib/xenstore.so exists (from the xvmstore package), but not the xvm headers. They're in the xvm-headers package. Do you actually have Xen running or know much about the Xen on Solaris

Re: [libvirt] Building on Solaris 11 Express

2011-06-03 Thread Richard Laager
On Fri, 2011-06-03 at 09:11 +0200, Matthias Bolte wrote: It has probably something to do with this piece of code, in daemon/libvirtd.c: I finally got back to looking at this, and that's what I discovered as well. (I hadn't checked my email in the interim.) I stopped it from dropping

[libvirt] [PATCH] API: consolidate common unreleased enums

2011-06-03 Thread Eric Blake
This commit is safe precisely because there has been no release for any of the enum values being deleted (they were added post-0.9.1). After the 0.9.2 release, we can then take advantage of virDomainModificationImpact in more places. * include/libvirt/libvirt.h.in (virDomainModificationImpact):

Re: [libvirt] [PATCH] security driver: ignore EINVAL when chowning an image file

2011-06-03 Thread Eric Blake
On 06/03/2011 10:04 AM, Laine Stump wrote: This fixes: https://bugzilla.redhat.com/show_bug.cgi?id=702044 https://bugzilla.redhat.com/show_bug.cgi?id=709454 Both of these complain of a failure to use an image file that resides on a read-only NFS volume. The function in the DAC

Re: [libvirt] Building on Solaris 11 Express

2011-06-03 Thread Ruben Kerkhof
On Fri, Jun 3, 2011 at 18:07, Richard Laager rlaa...@wiktel.com wrote: On Fri, 2011-06-03 at 09:11 +0200, Matthias Bolte wrote: It has probably something to do with this piece of code, in daemon/libvirtd.c: I finally got back to looking at this, and that's what I discovered as well. (I

Re: [libvirt] [PATCH] virsh: Document nodeinfo output

2011-06-03 Thread Jiri Denemark
On Fri, Jun 03, 2011 at 08:54:25 -0600, Eric Blake wrote: On 06/02/2011 03:21 AM, Jiri Denemark wrote: --- tools/virsh.pod |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 9251db6..1f41652 100644 ---

Re: [libvirt] [PATCH] qemu: Avoid use after free in qemuCaps parsing

2011-06-03 Thread Jiri Denemark
On Fri, Jun 03, 2011 at 15:41:53 +0100, Daniel P. Berrange wrote: On Fri, Jun 03, 2011 at 04:34:30PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_domain.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

Re: [libvirt] Building on Solaris 11 Express

2011-06-03 Thread Matthias Bolte
2011/6/3 Richard Laager rlaa...@wiktel.com: On Fri, 2011-06-03 at 09:11 +0200, Matthias Bolte wrote: It has probably something to do with this piece of code, in daemon/libvirtd.c: I finally got back to looking at this, and that's what I discovered as well. (I hadn't checked my email in

Re: [libvirt] [PATCH] security driver: ignore EINVAL when chowning an image file

2011-06-03 Thread Laine Stump
On 06/03/2011 12:13 PM, Eric Blake wrote: On 06/03/2011 10:04 AM, Laine Stump wrote: This fixes: https://bugzilla.redhat.com/show_bug.cgi?id=702044 https://bugzilla.redhat.com/show_bug.cgi?id=709454 Both of these complain of a failure to use an image file that resides on a read-only NFS

Re: [libvirt] Building on Solaris 11 Express

2011-06-03 Thread Ruben Kerkhof
On Fri, Jun 3, 2011 at 21:07, Matthias Bolte matthias.bo...@googlemail.com wrote: 2011/6/3 Richard Laager rlaa...@wiktel.com: On Fri, 2011-06-03 at 09:11 +0200, Matthias Bolte wrote: It has probably something to do with this piece of code, in daemon/libvirtd.c: I finally got back to

Re: [libvirt] [PATCH 10/10] Add a plugin for the 'sanlock' project

2011-06-03 Thread Eric Blake
On 05/24/2011 09:21 AM, Daniel P. Berrange wrote: Sanlock is a project that implements a disk-paxos locking algorithm. This is suitable for cluster deployments with shared storage. * src/Makefile.am: Add dlopen plugin for sanlock * src/locking/lock_driver_sanlock.c: Sanlock driver *

Re: [libvirt] Building on Solaris 11 Express

2011-06-03 Thread Richard Laager
On Fri, 2011-06-03 at 22:06 +0200, Ruben Kerkhof wrote: If I don't have the VirtualBox GUI running, virsh fails to connect: /usr/local/bin/virsh -c vbox:///session ... hangs for 10 or so seconds ... error: internal error nsIEventQueue object is null error: failed to connect to the