On Fri, Jun 03, 2011 at 10:10:58AM -0600, Eric Blake wrote:
This commit is safe precisely because there has been no release
for any of the enum values being deleted (they were added post-0.9.1).
After the 0.9.2 release, we can then take advantage of
virDomainModificationImpact in more
2011/6/4 Daniel Veillard veill...@redhat.com:
On Fri, Jun 03, 2011 at 10:10:58AM -0600, Eric Blake wrote:
This commit is safe precisely because there has been no release
for any of the enum values being deleted (they were added post-0.9.1).
After the 0.9.2 release, we can then take advantage
On Sat, Jun 04, 2011 at 10:05:43AM +0200, Matthias Bolte wrote:
2011/6/4 Daniel Veillard veill...@redhat.com:
ACK, as stated before I think it's a good step to try to make the
API more uniform across similar calls, and since there is more coming
we should really do this,
Please push
2011/6/4 Richard Laager rlaa...@wiktel.com:
On Fri, 2011-06-03 at 22:06 +0200, Ruben Kerkhof wrote:
If I don't have the VirtualBox GUI running, virsh fails to connect:
/usr/local/bin/virsh -c vbox:///session
... hangs for 10 or so seconds ...
error: internal error nsIEventQueue object
VirtualBox 4.0.8 changed the registry key layout. Before the version
number was in a Version key. Now the Version key contains %VER% and
the actual version number is in VersionExt now.
Move value lookup code into its own function: vboxLookupRegistryValue.
---
src/vbox/vbox_MSCOMGlue.c | 87
On Sat, Jun 04, 2011 at 10:53:06AM +0200, Matthias Bolte wrote:
VirtualBox 4.0.8 changed the registry key layout. Before the version
number was in a Version key. Now the Version key contains %VER% and
the actual version number is in VersionExt now.
Move value lookup code into its own
2011/6/4 Daniel Veillard veill...@redhat.com:
On Sat, Jun 04, 2011 at 10:53:06AM +0200, Matthias Bolte wrote:
VirtualBox 4.0.8 changed the registry key layout. Before the version
number was in a Version key. Now the Version key contains %VER% and
the actual version number is in VersionExt now.
The v2 migration protocol doesn't use cookies, so we should not
be raising an error if the cookie parameters are NULL.
* src/qemu/qemu_migration.c: Don't raise error if cookie is NULL
---
src/qemu/qemu_migration.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git
The error code for virKillProcess is returned in the errno variable
not the return value. THis mistake caused the logs to be filled with
errors when shutting down QEMU processes
* src/qemu/qemu_process.c: Fix process kill check.
---
src/qemu/qemu_process.c |6 ++
1 files changed, 2
2011/6/4 Daniel P. Berrange berra...@redhat.com:
The error code for virKillProcess is returned in the errno variable
not the return value. THis mistake caused the logs to be filled with
errors when shutting down QEMU processes
* src/qemu/qemu_process.c: Fix process kill check.
---
2011/6/4 Daniel P. Berrange berra...@redhat.com:
The v2 migration protocol doesn't use cookies, so we should not
be raising an error if the cookie parameters are NULL.
* src/qemu/qemu_migration.c: Don't raise error if cookie is NULL
---
src/qemu/qemu_migration.c | 7 ++-
1 files
When peer-2-peer migration was invoked by a client supporting
v3, but where the target server only supported v2, we'd not
correctly shutdown the guest.
* src/qemu/qemu_migration.c: Ensure guest is shutdown in
v2 peer 2 peer migration
---
src/qemu/qemu_migration.c | 17 +++--
1
On Sat, Jun 4, 2011 at 10:40, Matthias Bolte
matthias.bo...@googlemail.com wrote:
Okay VirtualBox 4.0.8 work with libvirt on Windows too. So this seems
to be a Solaris specific problem. Does an earlier version of
VirtualBox work, for example 4.0.0 or 3.2.10, or did it never work?
I just tried
2011/6/4 Ruben Kerkhof ru...@rubenkerkhof.com:
On Sat, Jun 4, 2011 at 10:40, Matthias Bolte
matthias.bo...@googlemail.com wrote:
Okay VirtualBox 4.0.8 work with libvirt on Windows too. So this seems
to be a Solaris specific problem. Does an earlier version of
VirtualBox work, for example
On Sat, Jun 4, 2011 at 16:37, Matthias Bolte
matthias.bo...@googlemail.com wrote:
2011/6/4 Ruben Kerkhof ru...@rubenkerkhof.com:
On Sat, Jun 4, 2011 at 10:40, Matthias Bolte
matthias.bo...@googlemail.com wrote:
Okay VirtualBox 4.0.8 work with libvirt on Windows too. So this seems
to be a
On Sat, Jun 4, 2011 at 17:20, Ruben Kerkhof ru...@rubenkerkhof.com wrote:
On Sat, Jun 4, 2011 at 16:37, Matthias Bolte
matthias.bo...@googlemail.com wrote:
2011/6/4 Ruben Kerkhof ru...@rubenkerkhof.com:
On Sat, Jun 4, 2011 at 10:40, Matthias Bolte
matthias.bo...@googlemail.com wrote:
Okay
---
I'm pushing this under the trivial rule.
src/vbox/vbox_XPCOMCGlue.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox/vbox_XPCOMCGlue.c
index 0caeef9..e7e9c37 100644
--- a/src/vbox/vbox_XPCOMCGlue.c
+++
On Fri, 2011-06-03 at 09:11 +0200, Matthias Bolte wrote:
That might be the problem. I don't have a Solaris at hand right now to
test it so here is a speculative patch for this.
I tested this patch. I'll discuss that first and then recount the
problems I experienced along the way.
The patch
On Sat, 2011-06-04 at 21:57 -0500, Richard Laager wrote:
From there, virsh connects. It seems to intermittently have problems;
I'm trying to reproduce that issue before I can go much further.
As the user xvm:
This works: /usr/local/bin/virsh -c vbox:///session list
This doesn't:
19 matches
Mail list logo
