Add --config, --live and --current for command blkiotune
---
tools/virsh.c | 26 +++---
tools/virsh.pod |7 +++
2 files changed, 30 insertions(+), 3 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index d98be1c..d458b92 100644
--- a/tools/virsh.c
+++
This series enables user to change blkio parameters for inactive
domains from virsh command line.
CHANGES:
v2-v3:
- based on new macros VIR_DOMAIN_AFFECT_XXX
Hu Tao (3):
Add new parameters for blkiotune
update qemuDomainGetBlkioParameters to use flags
Update qemuDomainSetBlkioParameters
---
src/qemu/qemu_driver.c | 124 +---
1 files changed, 86 insertions(+), 38 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2957467..8ebb7d4 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4824,18
---
src/qemu/qemu_driver.c | 126 ++--
1 files changed, 90 insertions(+), 36 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 8ebb7d4..fb2f63a 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4745,14
Those checks are already performed at the public API level.
---
src/esx/esx_driver.c | 10 --
src/esx/esx_storage_driver.c |5 -
2 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index 500dc52..a5b96a9 100644
---
2011/6/6 Eric Blake ebl...@redhat.com:
On 06/06/2011 05:59 AM, Matthias Bolte wrote:
When virConnectGetType is called on a remote connection then the remote
driver returns the type of the underlying driver on the server side, for
example QEMU. Then virGetVersion compares hvType to a set of
Hi,
Recently USB 2.0 support was merged into upstream qemu, I guess libvirt
and virt-manager needs some bits to support this ...
The docs/usb2.txt file in the qemu source tree carries some information
on how to use it, and also some hints for USB pass-through. The most
recent version
On 06/03/2011 10:47 PM, Eric Blake wrote:
On 06/02/2011 03:45 AM, Osier Yang wrote:
* src/libxl/libxl_driver.c
* src/qemu/qemu_process.c
---
src/libxl/libxl_driver.c |7 ++-
src/qemu/qemu_process.c | 13 ++---
2 files changed, 4 insertions(+), 16 deletions(-)
ACK.
On 06/03/2011 10:44 PM, Eric Blake wrote:
On 06/02/2011 03:45 AM, Osier Yang wrote:
For backwards compatability, if novideo is set but there is a
s/compatability/compatibility/
graphics tag, then we add a defaultvideo according to the
guest type. Add docs to tell the user about this to
Add public virDomainSendKey() and enum libvirt_keycode_set
for the @codeset.
Python version of virDomainSendKey() has not been implemented yet,
it will be done soon.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
include/libvirt/libvirt.h.in |7 +++
include/libvirt/virtkeys.h |
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
tools/virsh.c | 47 ---
1 files changed, 24 insertions(+), 23 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 61eb11e..638029c 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@
Add API virDomainSendKey() and virsh send-key command.
PATCH 01~04 prepare
PATCH 05~10 Add support for send keys to guest
Python version of virDomainSendKey() has not been implemented yet,
it will be done soon.
Some usage-improvment patches will be sent later(after these 10 are applied)
these
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
daemon/remote_generator.pl | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl
index 632972c..532fe63 100755
--- a/daemon/remote_generator.pl
+++
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
tools/virsh.c | 102 +++
tools/virsh.pod |4 ++
2 files changed, 106 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index d13c12b..7b5847f 100644
---
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
src/driver.h |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/src/driver.h b/src/driver.h
index 5df798a..2e335a1 100644
--- a/src/driver.h
+++ b/src/driver.h
@@ -542,6 +542,13 @@ typedef int
typedef int
A name will improve the usege, example
# virsh help echo
NAME
echo - echo arguments
SYNOPSIS
echo [--shell] [--xml] [string]...
DESCRIPTION
Echo back arguments, possibly with quoting.
OPTIONS
--shell escape for shell use
--xmlescape for XML use
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
src/libvirt.c | 63 +
1 files changed, 63 insertions(+), 0 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index cbe1926..112f690 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
src/remote/remote_driver.c |1 +
src/remote/remote_protocol.x | 16 +++-
src/remote_protocol-structs | 11 +++
3 files changed, 27 insertions(+), 1 deletions(-)
diff --git a/src/remote/remote_driver.c
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
src/qemu/qemu_driver.c | 50 ++
src/qemu/qemu_monitor.c | 27 ++
src/qemu/qemu_monitor.h |6 +
src/qemu/qemu_monitor_json.c | 15
A VSH_OFLAG_REQ_OPT option means --optionname is required when used.
It will kill any ambiguity even !VSH_OFLAG_REQ option listed before
VSH_OFLAG_REQ option if the !VSH_OFLAG_REQ option is a VSH_OFLAG_REQ_OPT option.
It will help us use optional arguement with VSH_OT_ARGV argument.
On Tue, Jun 07, 2011 at 10:17:30AM +0200, Gerd Hoffmann wrote:
Hi,
Recently USB 2.0 support was merged into upstream qemu, I guess
libvirt and virt-manager needs some bits to support this ...
Yes, we'll need todo more modelling of USB controllers/hubs in
the XML, and introduce a USB
Qemu once supported following memory stats which will returned by
query_balloon:
stat_put(dict, actual, actual);
stat_put(dict, mem_swapped_in, dev-stats[VIRTIO_BALLOON_S_SWAP_IN]);
stat_put(dict, mem_swapped_out, dev-stats[VIRTIO_BALLOON_S_SWAP_OUT]);
stat_put(dict,
At 06/03/2011 10:07 PM, Eric Blake Write:
On 05/27/2011 04:19 AM, Wen Congyang wrote:
qemu supports multi function PCI device after version 0.13.0.
After ( 0.13.0) or at least (= 0.13.0)?
at least.
@@ -1024,6 +1026,9 @@ qemuCapsComputeCmdFlags(const char *help,
*/
if
On 06/07/2011 12:52 PM, Taku Izumi wrote:
There is the case where cpu affinites for vcpu of qemu doesn't work
correctly.
For example, if only one vcpupin setting entry is provided and its setting
is
not for vcpu0, it doesn't work.
# virsh dumpxml VM
...
vcpu4/vcpu
cputune
XenAPI session login can fail for a number of reasons, but currently no specific
reason is displayed to the user, e.g.:
virsh -c XenAPI://citrix-xen.example.com/
Enter username for citrix-xen.example.com: root
Enter root's password for citrix-xen.example.com:
error: authentication failed: (null)
Shared folders are handled as filesystems and can also be hotplugged.
---
Currently this just maps shared folder to a filesystem element with type
mount. The filesystem element has an accessmode attribute that is not
useful for VirtualBox. Als the target element only has a dir attribute,
but
API virDomainMigrateSetMaxSpeed was introduced since 0.9.0, but
no command in virsh yet.
---
tools/virsh.c | 46 ++
tools/virsh.pod |5 +
2 files changed, 51 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
---
src/test/test_driver.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 2da24f1..68ab2fe 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -499,7 +499,6 @@ cleanup:
static int
On 06/07/2011 01:36 AM, Matthias Bolte wrote:
Those checks are already performed at the public API level.
---
src/esx/esx_driver.c | 10 --
src/esx/esx_storage_driver.c |5 -
2 files changed, 0 insertions(+), 15 deletions(-)
ACK.
--
Eric Blake ebl...@redhat.com
On 06/07/2011 06:20 AM, Jiri Denemark wrote:
---
src/test/test_driver.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
ACK.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
On 06/07/2011 05:01 AM, Matthew Booth wrote:
XenAPI session login can fail for a number of reasons, but currently no
specific
reason is displayed to the user, e.g.:
virsh -c XenAPI://citrix-xen.example.com/
Enter username for citrix-xen.example.com: root
Enter root's password for
On 06/07/2011 06:45 AM, Osier Yang wrote:
API virDomainMigrateSetMaxSpeed was introduced since 0.9.0, but
no command in virsh yet.
---
tools/virsh.c | 46 ++
tools/virsh.pod |5 +
2 files changed, 51 insertions(+), 0 deletions(-)
ACK.
---
src/qemu/qemu_domain.c |4 +++
src/qemu/qemu_domain.h |2 +
src/qemu/qemu_driver.c | 61 +++
src/qemu/qemu_process.c |3 ++
4 files changed, 70 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_domain.c
---
src/libvirt_private.syms |1 +
src/util/util.c | 24
src/util/util.h |2 ++
3 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index e6ab870..2415a89 100644
---
The API can be used to query current state of an interface to VMM used
to control a domain.
In QEMU world this translates into monitor connection and one can use the API,
e.g., to check whether (and for how long) libvirtd is currently waiting for a
reply from qemu process.
Jiri Denemark (6):
The API can be used to query current state of an interface to VMM used
to control a domain. In QEMU world this translates into monitor
connection.
---
include/libvirt/libvirt.h.in| 40
python/generator.py |1 +
python/libvirt-override-api.xml
---
src/qemu/qemu_domain.c| 24
src/qemu/qemu_driver.c| 11 ++-
src/qemu/qemu_migration.c | 31 ++-
src/util/event_poll.c | 45 -
4 files changed, 36 insertions(+), 75
---
tools/virsh.c | 66 +++
tools/virsh.pod |7 +
2 files changed, 73 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index d98be1c..2c81cf4 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -350,6 +350,7 @@
---
daemon/remote_generator.pl | 20 ++--
src/remote/remote_driver.c |1 +
src/remote/remote_protocol.x | 14 +-
src/remote_protocol-structs |9 +
4 files changed, 37 insertions(+), 7 deletions(-)
diff --git a/daemon/remote_generator.pl
2011/6/7 Eric Blake ebl...@redhat.com:
On 06/07/2011 01:36 AM, Matthias Bolte wrote:
Those checks are already performed at the public API level.
---
src/esx/esx_driver.c | 10 --
src/esx/esx_storage_driver.c | 5 -
2 files changed, 0 insertions(+), 15 deletions(-)
2011/6/6 Eric Blake ebl...@redhat.com:
Coverity 5.3.0 still outputs lots of COVERITY_* variables, but no
longer modifies COVERITY_BUILD_COMMAND in the environment. Pick
one that seems likely to stay around.
* configure.ac (STATIC_ANALYSIS): Detect newer Coverity.
---
configure.ac | 4
2011/6/6 Eric Blake ebl...@redhat.com:
Similar in nature to commit fd21ecfd, which shut up valgrind.
sigaction is apparently a nasty interface for code analyzers.
* src/util/util.c (virExecWithHook): Initialize entire var, since
coverity gripes about the (unused and non-standard)
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. cpumap was allocated with a value of
(unsigned short)*(int), which is an int computation, and then
promotes to size_t. On a 64-bit platform, this fails if bit
32 of the product is set (because of sign extension giving
a HUGE value
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. The code was doing math on shifted unsigned
char (which promotes to int), then promoting that to unsigned long
during assignment to size. On 64-bit platforms, this risks sign
extending values of size 2GiB. Bug present since
The algorithm for autoassigning vethXXX devices, was always
skipping over the starting dev index when finding a free
name for the guest device. This should only be done if the host
device was autoallocated.
* src/lxc/veth.c: Don't skip over veth indexes
---
src/lxc/veth.c | 14 +-
The LXC driver networking uses veth device pairs. These can
be easily hooked into the network filtering code.
* src/lxc/lxc_driver.c: Add calls to setup/teardown nwfilter
---
src/lxc/lxc_driver.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. Commit a98d8f0d tried to make uuid debugging
more robust, but missed some APIs. And on the APIs that it visited,
the mere act of preparing the debug message ends up dereferencing
uuid prior to the null check. Which means the APIs
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. All existing callers happen to be in
range, so this isn't too serious.
* src/qemu/qemu_cgroup.c (qemuCgroupControllerActive): Check
bounds before dereference.
---
src/qemu/qemu_cgroup.c | 4 ++--
1 files changed, 2
2011/6/6 Eric Blake ebl...@redhat.com:
Coverity already saw through a NULL dereference without these
annotations, and gcc is still too puny to do good NULL analysis.
But clang still benefits (and is easier to run than coverity),
not to mention that adding this bit of documentation to the code
On 06/07/2011 07:35 AM, Daniel P. Berrange wrote:
The algorithm for autoassigning vethXXX devices, was always
skipping over the starting dev index when finding a free
name for the guest device. This should only be done if the host
device was autoallocated.
* src/lxc/veth.c: Don't skip over
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. The only ways to get to the cleanup label
were by an early abort (list still NULL) or after successfully
transferring list to dest, so there is no list to clean up.
* src/secret/secret_driver.c (loadSecrets): Kill dead code.
---
On 06/07/2011 07:36 AM, Daniel P. Berrange wrote:
The LXC driver networking uses veth device pairs. These can
be easily hooked into the network filtering code.
* src/lxc/lxc_driver.c: Add calls to setup/teardown nwfilter
---
src/lxc/lxc_driver.c | 12 ++--
1 files changed, 10
2011/6/6 Eric Blake ebl...@redhat.com:
Coverity complained about these intentional fallthrough cases, but
not about other cases that were explicitly marked with nice comments.
For some reason, Coverity doesn't seem smart enough to parse the
up-front English comment in virsh about intentional
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. Bug introduced in commit 9d73efd (v0.8.8).
* src/qemu/qemu_hotplug.c (qemuDomainChangeGraphics): Don't report
error on success.
ACK.
Matthias
--
libvir-list mailing list
libvir-list@redhat.com
2011/6/6 Eric Blake ebl...@redhat.com:
As long as I was already touching the function...
* src/qemu/qemu_hotplug.c (qemuDomainChangeGraphics): Line wrap.
---
src/qemu/qemu_hotplug.c | 46 ++
1 files changed, 30 insertions(+), 16 deletions(-)
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. Commit ef21beda was incomplete; it solved
a leak one one path, but not on the other.
* daemon/libvirtd.c (qemudSetLogging): Avoid leak on success.
---
How embarrassing that I was just barely fixing a leak of the
same variable in
Daniel P. Berrange berra...@redhat.com wrote on 06/07/2011 09:36:22
AM:
The LXC driver networking uses veth device pairs. These can
be easily hooked into the network filtering code.
* src/lxc/lxc_driver.c: Add calls to setup/teardown nwfilter
---
src/lxc/lxc_driver.c | 12
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. The beginning of the function already filtered
out NULL objectContentList as invalid; more likely, the code was
trying to see if esxVI_RetrieveProperties modified *objectContentList.
* src/esx/esx_vi.c
On 06/01/2011 04:02 PM, Cole Robinson wrote:
On 06/01/2011 03:52 PM, Eric Blake wrote:
On 05/17/2011 09:06 AM, Cole Robinson wrote:
Seems reasonable to have all command wrappers in the same place
v2:
Dont move SetInherit
v3:
Comment spelling fix
Adjust WARN0 comment
On 06/02/2011 04:19 PM, Eric Blake wrote:
On 06/02/2011 01:40 PM, Cole Robinson wrote:
Add a simple handshake with the lxc_controller process so we can detect
process startup failures. We do this by adding a new --handshake cli arg
to lxc_controller for passing a file descriptor. If the
On 06/07/2011 11:45 AM, Jan Kiszka wrote:
Improve the layout when listing non-vlan clients via 'info network'. The
result looks like this:
(qemu) info network
Devices not on any VLAN:
orphan: net=10.0.2.0, restricted=n
virtio-net-pci.0: model=virtio-net-pci,macaddr=52:54:00:12:34:56
\
Hi all,
./configure --without-vbox
make
make check
produces on my F-13 and F-15 machines.
make[1]: Entering directory `/home/ruben/src/libvirt/tests'
make virshtest conftest sockettest nodeinfotest qparamtest virbuftest
commandtest commandhelper seclabeltest hashtest qemuxml2argvtest
2011/6/7 Ruben Kerkhof ru...@rubenkerkhof.com:
Hi all,
./configure --without-vbox
make
make check
produces on my F-13 and F-15 machines.
make[1]: Entering directory `/home/ruben/src/libvirt/tests'
make virshtest conftest sockettest nodeinfotest qparamtest virbuftest
commandtest
On 06/07/2011 03:55 PM, Anthony Liguori wrote:
On 06/07/2011 11:45 AM, Jan Kiszka wrote:
Improve the layout when listing non-vlan clients via 'info network'. The
result looks like this:
(qemu) info network
Devices not on any VLAN:
orphan: net=10.0.2.0, restricted=n
virtio-net-pci.0:
On 06/07/2011 08:38 PM, Eric Blake wrote:
On 06/07/2011 06:45 AM, Osier Yang wrote:
API virDomainMigrateSetMaxSpeed was introduced since 0.9.0, but
no command in virsh yet.
---
tools/virsh.c | 46 ++
tools/virsh.pod |5 +
2 files
Hi Yukihiro,
On Thu, Jun 02, 2011 at 06:26:27AM +, warp.kaw...@gmail.com wrote:
screenshot of remote host is available.
get_domain_object make so many error to message log, so you had
better not use .
I must admit I don't fully understand the problem you are having,
do you mean that
Hi,
I am trying to update the port for libvirt to 0.9.2, but am receiving a new
compiling error, that I have not seen yet.
console.c:280: warning: declaration of 'devname' shadows a global declaration
[-Wshadow]
/usr/include/stdlib.h:264: warning: shadowed declaration is here [-Wshadow]
CC
On 06/07/2011 09:27 PM, Jason Helfman wrote:
Hi,
I am trying to update the port for libvirt to 0.9.2, but am receiving a new
compiling error, that I have not seen yet.
Is this a VPATH build?
`/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.2/docs'
GENlibvirt-api.xml
---
.../qemuxml2argv-multifunction-pci-device.args | 15 ++
.../qemuxml2argv-multifunction-pci-device.xml | 51
tests/qemuxml2argvtest.c |4 ++
3 files changed, 70 insertions(+), 0 deletions(-)
create mode 100644
69 matches
Mail list logo