Re: [libvirt] FreeBSD Port, update to 0.9.2 compile error

2011-06-08 Thread Jason Helfman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Tue, Jun 07, 2011 at 09:45:41PM -0600, Eric Blake thus spake: On 06/07/2011 09:27 PM, Jason Helfman wrote: Hi, I am trying to update the port for libvirt to 0.9.2, but am receiving a new compiling error, that I have not seen yet. Is this a

[libvirt] [PATCH] Deprecate several CURRENT/LIVE/CONFIG enums

2011-06-08 Thread Hu Tao
This patch deprecates following enums: VIR_DOMAIN_MEM_CURRENT VIR_DOMAIN_MEM_LIVE VIR_DOMAIN_MEM_CONFIG VIR_DOMAIN_VCPU_LIVE VIR_DOMAIN_VCPU_CONFIG VIR_DOMAIN_DEVICE_MODIFY_CURRENT VIR_DOMAIN_DEVICE_MODIFY_LIVE VIR_DOMAIN_DEVICE_MODIFY_CONFIG And modify internal codes to use

[libvirt] [PATCH] build: Fix typos in configure.ac

2011-06-08 Thread Osier Yang
--- configure.ac |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 5307a1d..7982e21 100644 --- a/configure.ac +++ b/configure.ac @@ -1705,9 +1705,9 @@ if test $with_storage_lvm = yes || test $with_storage_lvm = check; then

[libvirt] [PATCH] storage: Deactive lv before remove it

2011-06-08 Thread Osier Yang
This is to address BZ# https://bugzilla.redhat.com/show_bug.cgi?id=702260, though even if with this patch, the user might see error like Unable to deactivate logical volume, it could fix the problem if the lv is referred to by another existing LVs, allowing the user remove the lv successfully

Re: [libvirt] [PATCH] build: Fix typos in configure.ac

2011-06-08 Thread Osier Yang
On 06/08/2011 03:46 PM, Osier Yang wrote: --- configure.ac |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 5307a1d..7982e21 100644 --- a/configure.ac +++ b/configure.ac @@ -1705,9 +1705,9 @@ if test $with_storage_lvm = yes ||

Re: [libvirt] [libvirt-php][PATCH] screenshot of remote host is available

2011-06-08 Thread Michal Novotny
On 06/08/2011 05:13 AM, Daniel Veillard wrote: Hi Yukihiro, On Thu, Jun 02, 2011 at 06:26:27AM +, warp.kaw...@gmail.com wrote: screenshot of remote host is available. get_domain_object make so many error to message log, so you had better not use . I must admit I don't fully

Re: [libvirt] [libvirt-php] Work on ./example

2011-06-08 Thread Michal Novotny
On 04/25/2011 03:14 PM, David Streibl wrote: Hello, as part of my student project I am working on simple web interface which would support multiple virtualisation platforms. This of course led me to libvirt and libvirt-php more specificly. David, this is fine. You can do it, of course and in

Re: [libvirt] FreeBSD Port, update to 0.9.2 compile error

2011-06-08 Thread Daniel Veillard
On Tue, Jun 07, 2011 at 11:08:02PM -0700, Jason Helfman wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Tue, Jun 07, 2011 at 09:45:41PM -0600, Eric Blake thus spake: On 06/07/2011 09:27 PM, Jason Helfman wrote: Hi, I am trying to update the port for libvirt to 0.9.2, but am

Re: [libvirt] RFC: extending sVirt to confine host apps which talk to libvirtd

2011-06-08 Thread Daniel P. Berrange
On Mon, Jun 06, 2011 at 02:51:15PM -0400, Daniel J Walsh wrote: On 06/06/2011 10:41 AM, Daniel P. Berrange wrote: Technical Notes / Issues 1. Adding new SELinux security classes / access vectors The selinux security classes are defined in

[libvirt] Driver development

2011-06-08 Thread Carlos N . A . Corrêa
Hi, I'm interested in developing a new network driver for libvirt (one for the definition and management of OpenVSwitch datapaths). I've read some of the code already, and by now my general directions are: - Change the function virNetworkDefParseXML in src/conf/network_conf.c to define and

Re: [libvirt] [PATCH 02/12] storage: avoid mishandling backing store 2GB

2011-06-08 Thread Eric Blake
On 06/07/2011 07:34 AM, Matthias Bolte wrote: 2011/6/6 Eric Blake ebl...@redhat.com: Detected by Coverity. The code was doing math on shifted unsigned char (which promotes to int), then promoting that to unsigned long during assignment to size. On 64-bit platforms, this risks sign extending

Re: [libvirt] [PATCH 03/12] build: silence coverity false positive

2011-06-08 Thread Eric Blake
On 06/07/2011 07:31 AM, Matthias Bolte wrote: 2011/6/6 Eric Blake ebl...@redhat.com: Similar in nature to commit fd21ecfd, which shut up valgrind. sigaction is apparently a nasty interface for code analyzers. * src/util/util.c (virExecWithHook): Initialize entire var, since coverity gripes

Re: [libvirt] [PATCH 09/12] esx: avoid dead code

2011-06-08 Thread Eric Blake
On 06/07/2011 08:01 AM, Matthias Bolte wrote: 2011/6/6 Eric Blake ebl...@redhat.com: Detected by Coverity. The beginning of the function already filtered out NULL objectContentList as invalid; more likely, the code was trying to see if esxVI_RetrieveProperties modified *objectContentList. *

Re: [libvirt] [libvirt-php][PATCH] screenshot of remote host is available

2011-06-08 Thread Michal Novotny
[snip] function domain_get_screenshot($domain) { - $dom = $this-get_domain_object($domain); - - $tmp = libvirt_domain_get_screenshot($dom); + $dom = libvirt_domain_lookup_by_uuid_string($this-conn, $domain); + $hostname = $this-get_hostname(); + $tmp = libvirt_domain_get_screenshot($dom,

[libvirt] [RFC PATCH] Set and reset MAC for PASSTHROUGH mode

2011-06-08 Thread D. Herrendoerfer
Hi to all, there is a problem present in libvirt that when a PASSTHROUGH mode DIRECT NIC connection is made the MAC address of the NIC is not automatically set and reset to the configured VM MAC and back again. The attached patch fixes this problem by setting and resetting the MAC while

[libvirt] [PATCH] build: update to latest gnulib

2011-06-08 Thread Eric Blake
* .gnulib: Update to latest, for more strerror_r fixes. --- strerror_r has proven tricker than I first thought. There's a couple of other useful improvements in here, too. * .gnulib 9d196fa...79d4e75 (70): strerror_r-posix: fix on MacOS gnulib-tool: Better isolation between different

[libvirt] [PATCH] virt-aa-helper: add missing include

2011-06-08 Thread Eric Blake
Regression introduced in commit 02e8691. * src/security/virt-aa-helper.c (includes): Reflect move of virRun. --- Pushing under the build-breaker rule, for Ubuntu. src/security/virt-aa-helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] FreeBSD Port, update to 0.9.2 compile error

2011-06-08 Thread Jason Helfman
On Tue, Jun 07, 2011 at 11:08:02PM -0700, Jason Helfman wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Tue, Jun 07, 2011 at 09:45:41PM -0600, Eric Blake thus spake: On 06/07/2011 09:27 PM, Jason Helfman wrote: Hi, I am trying to update the port for libvirt to 0.9.2, but am

Re: [libvirt] [PATCH 02/12] storage: avoid mishandling backing store 2GB

2011-06-08 Thread Richard W.M. Jones
On Tue, Jun 07, 2011 at 03:34:58PM +0200, Matthias Bolte wrote: Using unsigned int instead of uint32_t would also work and avoid stdint.h types that the libvirt codebase avoids. Out of interest, why is libvirt avoiding these int types? Rich. -- Richard Jones, Virtualization Group, Red Hat

[libvirt] [PATCH 2/2] qemu: Fix parsing 'info chardev'

2011-06-08 Thread Cole Robinson
If qemu supports -chardev, our char frontend aliases are ex. 'charserial0' not just 'serial0'. Typically we don't use this code path because the pty's are scraped from stdout. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_process.c | 29 ++--- 1

[libvirt] [PATCH 1/2] qemu: Scrape stdout for virtio console pty

2011-06-08 Thread Cole Robinson
Currently we forget to do this and have to fallback to info chardev (which also fails, see following patch) Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_process.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_process.c

[libvirt] FreeBSD Port update, 0.9.2

2011-06-08 Thread Jason Helfman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hello All, Here is a link to the update for FreeBSD, if you are interested: http://www.freebsd.org/cgi/query-pr.cgi?pr=157712 This patch is to update the version available in the FreeBSD portstree. Thanks, Jason - -- Jason Helfman System

Re: [libvirt] migration of vnlink VMs

2011-06-08 Thread Laine Stump
I'll send a separate email (in a new thread, so it doesn't get lost! ;-) with a new draft of what the network XML should look like, but wanted to respond to Dan's comments inline... On 05/24/2011 10:21 AM, Daniel P. Berrange wrote: On Fri, Apr 29, 2011 at 04:12:55PM -0400, Laine Stump wrote:

Re: [libvirt] [RFC PATCH] Set and reset MAC for PASSTHROUGH mode

2011-06-08 Thread Cole Robinson
Hi Dirk, Your patch mail is line wrapped. I'd recommend resending your patch using git send-email if possible, will at least increase the chances that someone reviews/comments. Thanks, Cole On 06/08/2011 08:10 AM, D. Herrendoerfer wrote: Hi to all, there is a problem present in libvirt that

Re: [libvirt] Driver development

2011-06-08 Thread Cole Robinson
On 06/08/2011 07:10 AM, Carlos N. A. Corrêa wrote: Hi, I'm interested in developing a new network driver for libvirt (one for the definition and management of OpenVSwitch datapaths). I've read some of the code already, and by now my general directions are: - Change the function

[libvirt] CFS Hardlimits and the libvirt cgroups implementation

2011-06-08 Thread Adam Litke
Hi all. In this post I would like to bring up 3 issues which are tightly related: 1. unwanted behavior when using cfs hardlimits with libvirt, 2. Scaling cputune.share according to the number of vcpus, 3. API proposal for CFS hardlimits support. === 1 === Mark Peloquin (on cc:) has been looking

Re: [libvirt] Make check on current git fails when building --with-vbox

2011-06-08 Thread Ruben Kerkhof
On Tue, Jun 7, 2011 at 23:00, Matthias Bolte matthias.bo...@googlemail.com wrote: This is because of the locking manager using dlopen but not linking against libdl explicitly. The VirtualBox driver happens to link libdl in, but without it libdl is missing, We currently link libvirt with libdl

Re: [libvirt] Driver development

2011-06-08 Thread Carlos N . A . Corrêa
Hi, I gathered information about that and I'll produce relevant documentation of my point tonight. I'll be glad to do an informed and well structured work. Thanks! Best regards, Carlos Bill Nilton CISSP, RHCE, ITIL Foundations http://carlosnilton.com.br/ Em 8 de junho de 2011 15:41, Cole

Re: [libvirt] [PATCH] storage: Deactive lv before remove it

2011-06-08 Thread Jun'ichi Nomura
Hi On 06/08/11 17:01, Osier Yang wrote: This is to address BZ# https://bugzilla.redhat.com/show_bug.cgi?id=702260, though even if with this patch, the user might see error like Unable to deactivate logical volume, Can you try the attached patch? (in addition to the upstream lvm fix you

[libvirt] [PATCH v4 0/4] vcpupin: configure inactive domain's CPU affinity setting

2011-06-08 Thread Taku Izumi
Hi all, This patchset enables us to configure inactive domains' CPU affinity setting. This is the rebased version, but retains the version number. *[PATCH v4 1/4] vcpupin: introduce a new libvirt API (virDomainPinVcpuFlags) *[PATCH v4 2/4] vcpupin: implement the code to address the new API in

[libvirt] [RFC] OpenVSwitch datapath support (was: Driver development)

2011-06-08 Thread Carlos N . A . Corrêa
Hi, Cole! As I said, I gone through the list archives and got some insight on how to present my ideas. I tried to use the thread started by Laine Stump ( https://www.redhat.com/archives/libvir-list/2011-April/msg00591.html) as a model. Please, forgive me if my RFC is too verbose: I tried to

[libvirt] [PATCH v4 1/4] vcpupin: introduce a new libvirt API

2011-06-08 Thread Taku Izumi
This patch introduces a new libvirt API (virDomainPinVcpuFlags). Signd-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- include/libvirt/libvirt.h.in |5 ++ src/driver.h |7 +++ src/libvirt.c| 76 +++

[libvirt] [PATCH v4 2/4] vcpupin: implement the code to address the new API in the qemu driver

2011-06-08 Thread Taku Izumi
This patch implements the code to address the new API (virDomainPinVcpuFlags) in the qemu driver. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- src/qemu/qemu_driver.c | 99 + 1 file changed, 76 insertions(+), 23 deletions(-) Index:

[libvirt] [PATCH v4 3/4] vcpupin: implement the remote protocol to address the new API

2011-06-08 Thread Taku Izumi
This patch implements the remote protocol to address the new API (virDomainPinVcpuFlags). Signd-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- daemon/remote.c | 42 ++ src/remote/remote_driver.c |1 + src/remote/remote_protocol.x |

[libvirt] [PATCH v4 4/4] vcpupin: add the new option to virsh vcpupin command

2011-06-08 Thread Taku Izumi
This patch adds the new option (--live, --config and --current) to virsh vcpupin command. The behavior of above aption is the same as that of virsh setmem, virsh setvcpus, and whatnot. When the --config option is specified, the command affects a persistent domain, while --live option is

[libvirt] [PATCH 0/4] RFC: vcpupin: some improvements of virsh vcpupin command

2011-06-08 Thread Taku Izumi
Hi all, This patchset improves virsh vcpupin command like the following: (i) introduce special markup - and ^ which are similar to XML schema of cpuset attribute # virsh vcpupin VM 0 0-8,^4 --config # virsh dumpxml VM ... vcpu4/vcpu cputune vcpupin vcpu='0' cpuset='0-3,5-8'/

[libvirt] [PATCH 1/4] vcpupin: improve vcpupin definition of virsh vcpupin

2011-06-08 Thread Taku Izumi
When using vcpupin command, we have to speficy comma-separated list as cpulist, but this is tedious in case the number of phsycal cpus is large. This patch improves this by introducing special markup - and ^ which are similar to XML schema of cpuset attribute. That is: # virsh vcpupin Guest

[libvirt] [PATCH 2/4] vcpupin: add reset option to virsh vcpupin command

2011-06-08 Thread Taku Izumi
When resetting vcpupin setting, we have to specify all host physical cpus as a cpulist parameter of virsh vcpupin command. It's a little tedious. This patch changes to allow to receive the special keyword 'r' as a cpulist parameter of virsh vcpupin command when resetting vcpupin setting. If you

[libvirt] [PATCH 3/4] vcpupin: add virDomainVcpupinDel function

2011-06-08 Thread Taku Izumi
This patch add the private API (virDomainVcpupinDel). This API can delete the vcpupin setting of a specified virtual cpu. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- src/conf/domain_conf.c | 39 +++ src/conf/domain_conf.h |2 ++