[libvirt] [PATCH 4/4] vcpupin: add vcpupin resetting feature to qemu driver

2011-06-09 Thread Taku Izumi
Pinning to all physical cpus means resetting, hence it is preferable to delete vcpupin setting of XML. This patch changes qemu driver to delete vcpupin setting by invoking virDomainVcpupinDel API when pinning the specified virtual cpu to all host physical cpus. Signed-off-by: Taku Izumi --- s

[libvirt] [PATCH 3/4] vcpupin: add virDomainVcpupinDel function

2011-06-09 Thread Taku Izumi
This patch add the private API (virDomainVcpupinDel). This API can delete the vcpupin setting of a specified virtual cpu. Signed-off-by: Taku Izumi --- src/conf/domain_conf.c | 39 +++ src/conf/domain_conf.h |2 ++ src/libvirt_private.syms |1 +

[libvirt] [PATCH 2/4] vcpupin: add reset option to virsh vcpupin command

2011-06-09 Thread Taku Izumi
When resetting vcpupin setting, we have to specify all host physical cpus as a cpulist parameter of virsh vcpupin command. It's a little tedious. This patch changes to allow to receive the special keyword 'r' as a cpulist parameter of virsh vcpupin command when resetting vcpupin setting. If you

[libvirt] [PATCH 1/4] vcpupin: improve vcpupin definition of virsh vcpupin

2011-06-09 Thread Taku Izumi
When using vcpupin command, we have to speficy comma-separated list as cpulist, but this is tedious in case the number of phsycal cpus is large. This patch improves this by introducing special markup "-" and "^" which are similar to XML schema of "cpuset" attribute. That is: # virsh vcpupin

[libvirt] [PATCH 0/4] RFC: vcpupin: some improvements of virsh vcpupin command

2011-06-09 Thread Taku Izumi
Hi all, I'll resend this patchset because what sent yesterday was broken. Sorry to be a nuisance. --- This patchset improves virsh vcpupin command like the following: (i) introduce special markup "-" and "^" which are similar to XML schema of "cpuset" attribute # virsh vcpupin VM 0 0-

[libvirt] [PATCH v4 4/4] vcpupin: add the new option to "virsh vcpupin" command

2011-06-09 Thread Taku Izumi
This patch adds the new option (--live, --config and --current) to "virsh vcpupin" command. The behavior of above aption is the same as that of "virsh setmem", "virsh setvcpus", and whatnot. When the --config option is specified, the command affects a persistent domain, while --live option is spec

[libvirt] [PATCH v4 3/4] vcpupin: implement the remote protocol to address the new API

2011-06-09 Thread Taku Izumi
This patch implements the remote protocol to address the new API (virDomainPinVcpuFlags). Signd-off-by: Taku Izumi --- daemon/remote.c | 42 ++ src/remote/remote_driver.c |1 + src/remote/remote_protocol.x | 10 +- src/remot

[libvirt] [PATCH v4 2/4] vcpupin: implement the code to address the new API in the qemu driver

2011-06-09 Thread Taku Izumi
This patch implements the code to address the new API (virDomainPinVcpuFlags) in the qemu driver. Signed-off-by: Taku Izumi --- src/qemu/qemu_driver.c | 99 + 1 file changed, 76 insertions(+), 23 deletions(-) Index: libvirt/src/qemu/qemu_driver

[libvirt] [PATCH v4 1/4] vcpupin: introduce a new libvirt API (virDomainPinVcpuFlags)

2011-06-09 Thread Taku Izumi
This patch introduces a new libvirt API (virDomainPinVcpuFlags). Signd-off-by: Taku Izumi --- include/libvirt/libvirt.h.in |5 ++ src/driver.h |7 +++ src/libvirt.c| 76 +++ src/libvirt_public.syms |5 ++

[libvirt] [PATCH v4 0/4] vcpupin: configure inactive domain's CPU affinity setting

2011-06-09 Thread Taku Izumi
Hi all, I'll resend this patchset because what sent yesterday was broken. Sorry to be a nuisance. -- This patchset enables us to configure inactive domains' CPU affinity setting. This is the rebased version, but retains the version number. *[PATCH v4 1/4] vcpupin: introduce a new libvirt API (

[libvirt] [PATCH] qemu: Fix one type in the error prompt string

2011-06-09 Thread Osier Yang
Pushed in trivial rule. --- src/qemu/qemu_command.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ef2d002..4e68241 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -553,7 +553,7 @@ qemuAssignDe

Re: [libvirt] Make check on current git fails when building --with-vbox

2011-06-09 Thread Matthias Bolte
2011/6/8 Ruben Kerkhof : > On Tue, Jun 7, 2011 at 23:00, Matthias Bolte > wrote: >> This is because of the locking manager using dlopen but not linking >> against libdl explicitly. The VirtualBox driver happens to link libdl >> in, but without it libdl is missing, We currently link libvirt with >>

[libvirt] [PATCH] Fix dlopen dependency

2011-06-09 Thread Matthias Bolte
Since the addition of the lock manager framework in 6a943419c528fdd7 dlopen is always required, but the checks in configure wasn't changed to reflect that. This didn't show up directly because the VirtualBox driver linking dlopen in covered it. But disabling the VirtualBox driver makes the build fa

Re: [libvirt] [PATCH] Move VMware Workstation/Player driver to correct spec file section

2011-06-09 Thread Matthias Bolte
2011/6/9 Jiri Denemark : > On Thu, Jun 09, 2011 at 20:29:01 +0200, Matthias Bolte wrote: >> The VMware driver works like the OpenVZ driver by using a commandline >> tool for management. It dosen't use it's own remote protocol. >> --- >>  libvirt.spec.in |    2 +- >>  1 files changed, 1 insertions(+

Re: [libvirt] [PATCH] Move VMware Workstation/Player driver to correct spec file section

2011-06-09 Thread Jiri Denemark
On Thu, Jun 09, 2011 at 20:29:01 +0200, Matthias Bolte wrote: > The VMware driver works like the OpenVZ driver by using a commandline > tool for management. It dosen't use it's own remote protocol. > --- > libvirt.spec.in |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) ACK Jirka -

[libvirt] [PATCH] Move VMware Workstation/Player driver to correct spec file section

2011-06-09 Thread Matthias Bolte
The VMware driver works like the OpenVZ driver by using a commandline tool for management. It dosen't use it's own remote protocol. --- libvirt.spec.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c7ef8d0..97ebd65 100644 --- a/li

[libvirt] [PATCH 1/8] Add new API virDomainBlockPull* to headers

2011-06-09 Thread Adam Litke
Set up the types for the block pull functions and insert them into the virDriver structure definition. Symbols are exported in this patch to prevent documentation compile failures. * include/libvirt/libvirt.h.in: new API * src/driver.h: add the new entry to the driver structure * python/generator

[libvirt] [PATCH 3/8] Add virDomainBlockPull support to the remote driver

2011-06-09 Thread Adam Litke
The generator can handle DomainBlockPullAll and DomainBlockPullAbort. DomainBlockPull and DomainBlockPullInfo must be written by hand. * src/remote/remote_protocol.x: provide defines for the new entry points * src/remote/remote_driver.c daemon/remote.c: implement the client and server side * src

[libvirt] [PATCH 2/8] virDomainBlockPull: Implement the main entry points

2011-06-09 Thread Adam Litke
* src/libvirt.c: implement the main entry points Signed-off-by: Adam Litke --- src/libvirt.c | 252 + 1 files changed, 252 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 997d4a2..71afea9 100644 --- a/src/li

[libvirt] [PATCH 7/8] Asynchronous event for BlockPull completion

2011-06-09 Thread Adam Litke
When an operation started by virDomainBlockPullAll completes (either with success or with failure), raise an event to indicate the final status. This allows an API user to avoid polling on virDomainBlockPullInfo if they would prefer to use the event mechanism. * daemon/remote.c: Dispatch events t

[libvirt] [PATCH 5/8] Enable the virDomainBlockPull API in virsh

2011-06-09 Thread Adam Litke
Define three new virsh commands: * blockpull: Perform incremental block pull * blockpull: Start/stop full device block pull * blockpullinfo: Retrieve progress info for full device block pull Share print_job_progress() with the migration code. * tools/virsh.c: implement the new commands Signed

[libvirt] [PATCH 4/8] Implement virDomainBlockPull for the qemu driver

2011-06-09 Thread Adam Litke
The virDomainBlockPull* family of commands are enabled by the 'block_stream' and 'info block_stream' qemu monitor commands. * src/qemu/qemu_driver.c src/qemu/qemu_monitor_text.[ch]: implement disk streaming by using the stream and info stream text monitor commands * src/qemu/qemu_monitor_json.[c

[libvirt] [PATCH 6/8] Enable virDomainBlockPull in the python API.

2011-06-09 Thread Adam Litke
virDomainBlockPullAll and virDomainBlockPullAbort are handled automatically. virDomainBlockPull and virDomainBlockPullInfo require manual overrides since they return a custom type. * python/generator.py: reenable bindings for this entry point * python/libvirt-override-api.xml python/libvirt-overri

[libvirt] [PATCH 8/8] test: Python Unittests for DomainBlockPull API

2011-06-09 Thread Adam Litke
*** Please do not consider for merging, example tests only *** Here are the testcases I am currently running to verify the correctness of this API. These are continuing to evolve. Signed-off-by: Adam Litke --- blockPull-test.py | 301 + 1 fi

[libvirt] RFC (v3): Add virDomainBlockPull API family to libvirt

2011-06-09 Thread Adam Litke
I didn't receive too many comments on the last round. That probably means everybody has been busy with the 0.9.2 release. I think this is ready to be committed but we can wait until the qemu side has gone up (which should happen any day now). Changes since V2: - Rebased - Ensure error messages

Re: [libvirt] FreeBSD Port, update to 0.9.2 compile error

2011-06-09 Thread Jason Helfman
On Thu, Jun 09, 2011 at 03:12:42PM +0200, Jiri Denemark thus spake: On Thu, Jun 09, 2011 at 20:55:01 +0800, Daniel Veillard wrote: > > another way would be to launch python directly giving the path to the > > python script, this is likely to solve the issue there. That IMHO avoids the probl

Re: [libvirt] RFC: extending sVirt to confine host apps which talk to libvirtd

2011-06-09 Thread Jamie Strandboge
On Thu, 2011-06-09 at 11:15 -0400, Eric Paris wrote: > On Mon, 2011-06-06 at 15:41 +0100, Daniel P. Berrange wrote: > > What follows is a document outlining some thoughts I've been having > > on extending sVirt to allow confinement of applications which talk > > to libvirtd on the host, primarily f

Re: [libvirt] RFC: extending sVirt to confine host apps which talk to libvirtd

2011-06-09 Thread Eric Paris
On Mon, 2011-06-06 at 15:41 +0100, Daniel P. Berrange wrote: > What follows is a document outlining some thoughts I've been having > on extending sVirt to allow confinement of applications which talk > to libvirtd on the host, primarily focusing on use of SELinux, but > also allowing a simple non-S

Re: [libvirt] [PATCH 3/6] Introduce virDomainGetControlInfo API

2011-06-09 Thread Jiri Denemark
On Thu, Jun 09, 2011 at 17:08:14 +0200, Federico Simoncelli wrote: > Hi Jiri, > I don't see the libvirt_virDomainGetControlInfo implementation in > libvirt-override.c. > > $ nm -D python/.libs/libvirtmod.so | grep virDomainGetControlInfo > (empty) > > Is the python binding postponed to a future p

Re: [libvirt] [PATCH 3/6] Introduce virDomainGetControlInfo API

2011-06-09 Thread Federico Simoncelli
Hi Jiri, I don't see the libvirt_virDomainGetControlInfo implementation in libvirt-override.c. $ nm -D python/.libs/libvirtmod.so | grep virDomainGetControlInfo (empty) Is the python binding postponed to a future patch? -- Federico On Tue, Jun 7, 2011 at 3:01 PM, Jiri Denemark wrote: > The AP

Re: [libvirt] [PATCH 1/6] Introduce virTimeMs for getting current time in ms

2011-06-09 Thread Michal Privoznik
On 07.06.2011 15:01, Jiri Denemark wrote: > --- > src/libvirt_private.syms |1 + > src/util/util.c | 24 > src/util/util.h |2 ++ > 3 files changed, 27 insertions(+), 0 deletions(-) > > diff --git a/src/libvirt_private.syms b/src/libvirt_privat

Re: [libvirt] [PATCH 0/6] Introduce virDomainGetControlInfo API

2011-06-09 Thread Jiri Denemark
On Tue, Jun 07, 2011 at 15:01:54 +0200, Jiri Denemark wrote: > The API can be used to query current state of an interface to VMM used > to control a domain. > > In QEMU world this translates into monitor connection and one can use the API, > e.g., to check whether (and for how long) libvirtd is cu

[libvirt] Availability of patchchecker

2011-06-09 Thread Daniel Veillard
As some may have noticed, I'm often behind on patch review and it happens I notice patches way too late i.e. just before a release. For some time I though that having something automatic to remind me about unreviewed/unapplied patches would be a good way to fight this. I know that Eric, Matthias,

Re: [libvirt] FreeBSD Port, update to 0.9.2 compile error

2011-06-09 Thread Jiri Denemark
On Thu, Jun 09, 2011 at 20:55:01 +0800, Daniel Veillard wrote: > > > another way would be to launch python directly giving the path to the > > > python script, this is likely to solve the issue there. > > That IMHO avoids the problem completely and I doubt anybody would > complain I agree, an

Re: [libvirt] RFC: extending sVirt to confine host apps which talk to libvirtd

2011-06-09 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/08/2011 06:34 AM, Daniel P. Berrange wrote: > On Mon, Jun 06, 2011 at 02:51:15PM -0400, Daniel J Walsh wrote: >> On 06/06/2011 10:41 AM, Daniel P. Berrange wrote: >>> Technical Notes / Issues >>> >>> >>> 1. Adding new SEL

Re: [libvirt] FreeBSD Port, update to 0.9.2 compile error

2011-06-09 Thread Daniel Veillard
On Wed, Jun 08, 2011 at 07:44:43AM -0700, Jason Helfman wrote: > > On Tue, Jun 07, 2011 at 11:08:02PM -0700, Jason Helfman wrote: > >> I found the issue in building was an absolute path for apibuild.py for > >> python, that is incorrect on FreeBSD. > > > > okay, where is it on FreeBSD ? > > /usr/

[libvirt] [PATCH v2] virsh: Add daemon version reporting

2011-06-09 Thread Michal Prívozník
From: Michal Privoznik 'virsh version' might report against which version of libvirtd is running. --- diff to v1: - added 'daemon' switch - don't fail when no deamon version is available tools/virsh.c | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a

[libvirt] [PATCH v3] graphics: add support for action_if_connected in qemu

2011-06-09 Thread Michal Prívozník
From: Michal Privoznik This option accepts 3 values: -keep, to keep current client connected (Spice+VNC) -disconnect, to disconnect client (Spice) -fail, to fail setting password if there is a client connected (Spice) --- diff to v2: -fixed typo -added test. However, functionality provided by thi

Re: [libvirt] [PATCH] storage: Deactive lv before remove it

2011-06-09 Thread Osier Yang
On 06/09/2011 08:33 AM, Jun'ichi Nomura wrote: Hi On 06/08/11 17:01, Osier Yang wrote: This is to address BZ# https://bugzilla.redhat.com/show_bug.cgi?id=702260, though even if with this patch, the user might see error like "Unable to deactivate logical volume", Can you try the attached patch

Re: [libvirt] [PATCH v4 2/4] vcpupin: implement the code to address the new API in the qemu driver

2011-06-09 Thread Osier Yang
On 06/09/2011 11:38 AM, Taku Izumi wrote: This patch implements the code to address the new API (virDomainPinVcpuFlags) in the qemu driver. Signed-off-by: Taku Izumi --- src/qemu/qemu_driver.c | 99 + 1 file changed, 76 insertions(+), 23 dele

Re: [libvirt] 答复: does libvirt get disk->info.alias, when attaching a disk by virDomainAttachDevice?

2011-06-09 Thread Wen Congyang
At 06/09/2011 05:26 PM, 李敬伟 Write: > Thank you ,Wen Congyang. > Do you know any rpm repository of libvirt 0.9.2 for Centos 5? > You are using libvirt 0.9.2 on Centos 5? I use the newest libvirt on RHEL6. And I build rpm by hand. You can use git to clone the tree from libvirt.org. The steps to bui

Re: [libvirt] [PATCH v4 3/4] vcpupin: implement the remote protocol to address the new API

2011-06-09 Thread Taku Izumi
Sorry. I've just changed MTA. I'll resend them all. Best regards, Taku Izumi -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/7] prevent hot unplugging multi function PCI device

2011-06-09 Thread shu ming
Wen Congyang: At 06/09/2011 04:37 PM, shu ming Write: Hi I applied these pacches to libvirt tree 8077d64f964705c1034555abeea38773532b762f And built a qemu-kvm from the upstream qemu-kvm tree version 0.14. I tested these new binaries on my Redhat Enterprise Linux 6.1 GA. Now I can have mu

Re: [libvirt] [PATCH 2/7] prevent hot unplugging multi function PCI device

2011-06-09 Thread Wen Congyang
At 06/09/2011 04:37 PM, shu ming Write: > Hi >I applied these pacches to libvirt tree > > 8077d64f964705c1034555abeea38773532b762f > > And built a qemu-kvm from the upstream qemu-kvm tree version 0.14. I > tested these new binaries on my Redhat Enterprise Linux 6.1 GA. > > Now I can have mu

Re: [libvirt] [PATCH v4 4/4] vcpupin: add the new option to "virsh vcpupin" command

2011-06-09 Thread Hu Tao
On Thu, Jun 09, 2011 at 12:40:36PM +0900, Taku Izumi wrote: > > This patch adds the new option (--live, --config and --current) to > "virsh vcpupin" command. The behavior of above aption is the same as > that of "virsh setmem", "virsh setvcpus", and whatnot. > When the --config option is specified

Re: [libvirt] [PATCH v4 3/4] vcpupin: implement the remote protocol to address the new API

2011-06-09 Thread Hu Tao
On Thu, Jun 09, 2011 at 12:39:47PM +0900, Taku Izumi wrote: > > This patch implements the remote protocol to address the new API > (virDomainPinVcpuFlags). > > Signd-off-by: Taku Izumi > --- > daemon/remote.c | 42 > ++ > src/remote/remote_

Re: [libvirt] [PATCH 2/7] prevent hot unplugging multi function PCI device

2011-06-09 Thread shu ming
Hi I applied these pacches to libvirt tree 8077d64f964705c1034555abeea38773532b762f And built a qemu-kvm from the upstream qemu-kvm tree version 0.14. I tested these new binaries on my Redhat Enterprise Linux 6.1 GA. Now I can have multiple function devices after I changed the VM XML con

Re: [libvirt] [PATCH v4 1/4] vcpupin: introduce a new libvirt API

2011-06-09 Thread Hu Tao
On Thu, Jun 09, 2011 at 12:37:47PM +0900, Taku Izumi wrote: > > This patch introduces a new libvirt API (virDomainPinVcpuFlags). > > Signd-off-by: Taku Izumi > --- > include/libvirt/libvirt.h.in |5 ++ > src/driver.h |7 +++ > src/libvirt.c| 76 > ++

Re: [libvirt] does libvirt get disk->info.alias, when attaching a disk by virDomainAttachDevice?

2011-06-09 Thread Wen Congyang
At 06/09/2011 01:26 PM, 李敬伟 Write: > Hi, > I am using libvirt 0.9.1 on CentOS 5.5 64bit , > Created a vm :virsh create libvirt.xml > Attached a disk ,virsh attach-disk 3 /opt/vms/test.img vdb > When getting blosk stats ,virsh domblkstats 3 vdb ,it showed >

[libvirt] does libvirt get disk->info.alias, when attaching a disk by virDomainAttachDevice?

2011-06-09 Thread 李敬伟
Hi, I am using libvirt 0.9.1 on CentOS 5.5 64bit , Created a vm :virsh create libvirt.xml Attached a disk ,virsh attach-disk 3 /opt/vms/test.img vdb When getting blosk stats ,virsh domblkstats 3 vdb ,it showed error: Failed to get block stats 3