于 2011-6-27 23:17, Laine Stump 写道:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simonsimon...@linux.vnet.ibm.com:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3
I have made an rc1 tarball available at:
---
src/conf/network_conf.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index d0860d8..45ddee2 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -945,6 +945,7 @@ virNetworkDNSDefFormat(virBufferPtr
If we pass VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG to
qemuGetSchedulerParametersFlags() or *nparams is less than 1,
we will unlock qemu_driver without locking it. It's very dangerous.
We should lock qemu_driver after calling virCheckFlags().
---
src/qemu/qemu_driver.c |3 ++-
1
2011/6/28 simon jin simon...@linux.vnet.ibm.com:
于 2011-6-27 23:17, Laine Stump 写道:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simonsimon...@linux.vnet.ibm.com:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3
I have made
Detected when playing with make -C tests valgrind.
---
tests/virnetmessagetest.c | 35 ---
1 files changed, 24 insertions(+), 11 deletions(-)
diff --git a/tests/virnetmessagetest.c b/tests/virnetmessagetest.c
index e707b67..61f457c 100644
---
于 2011-6-28 16:20, Matthias Bolte 写道:
2011/6/28 simon jinsimon...@linux.vnet.ibm.com:
于 2011-6-27 23:17, Laine Stump 写道:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simonsimon...@linux.vnet.ibm.com:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze
It will be nice if you could explain what the patch series does
with git send-email --compose, and also each patch should have
a description, as your patches are not tiny patch which one can
get the sense at a glance.
Only a patch subject is hard for one reviewing it.
Regards
Osier
于
On 27.06.2011 21:39, Eric Blake wrote:
On 06/27/2011 12:06 PM, Michal Privoznik wrote:
That is, if you have command-based custom generators, then each command
has to repeat parsing functionality, then call back to common list
generators; whereas if you have option-based custom generators, then
On 27.06.2011 11:27, Jiri Denemark wrote:
When CURRENT and FORCE flags were used together, UpdateDeviceFlags did
nothing because it failed to transform CURRENT into either LIVE or
CONFIG.
---
src/qemu/qemu_driver.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff
On 28.06.2011 10:06, Osier Yang wrote:
---
src/conf/network_conf.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index d0860d8..45ddee2 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@
On 28.06.2011 09:58, Wen Congyang wrote:
If we pass VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG to
qemuGetSchedulerParametersFlags() or *nparams is less than 1,
we will unlock qemu_driver without locking it. It's very dangerous.
We should lock qemu_driver after calling virCheckFlags().
On Mon, Jun 27, 2011 at 02:08:07PM -0600, Eric Blake wrote:
On 06/27/2011 08:24 AM, Daniel P. Berrange wrote:
This guts the current remote driver, removing all its networking
handling code. Instead it calls out to the new virClientPtr and
virClientProgramPtr APIs for all RPC networking
On Mon, Jun 27, 2011 at 02:49:37PM -0600, Eric Blake wrote:
On 06/27/2011 02:08 PM, Eric Blake wrote:
Aargh, I hit send too soon.
+case trans_ext: {
+char const *cmd_argv[] = { command, NULL };
+if (!(priv-client = virNetClientNewExternal(cmd_argv)))
This appears
On 28.06.2011 05:43, Wen Congyang wrote:
We should save domain status after modifing vcpupin. If not,
we will get wrong vcpupin information after rebooting libvirtd.
---
src/qemu/qemu_driver.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git
On 28.06.2011 05:41, Wen Congyang wrote:
virDomainVcpuPinDefFree() does not free def-cputune.vcpupin if nvcpupin
is 0, and does not set def-cputune.vcpupin to NULL.
If we set nvcpupin to 0 but do not free vcpupin, vcpupin will not be freed
when vm-def is freed.
Use VIR_FREE() instead of
On Mon, Jun 27, 2011 at 04:01:53PM -0600, Eric Blake wrote:
On 06/27/2011 08:24 AM, Daniel P. Berrange wrote:
This guts the libvirtd daemon, removing all its networking and
RPC handling code. Instead it calls out to the new virServerPtr
APIs for all its RPC networking work
As a
networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010).
It has a force flag. If the dnsmasq hostsfile already exists force
needs to be true to overwrite it. networkBuildDnsmasqArgv sets force
to false, networkDefine sets it to true. This results in the
hostsfile being written only in
2011/6/28 simon jin simon...@linux.vnet.ibm.com:
于 2011-6-28 16:20, Matthias Bolte 写道:
2011/6/28 simon jin simon...@linux.vnet.ibm.com:
于 2011-6-27 23:17, Laine Stump 写道:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simonsimon...@linux.vnet.ibm.com:
于 2011-6-27 13:01, Daniel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/27/2011 08:20 AM, Daniel P. Berrange wrote:
This patch series adds two new features
- The ability to override 'system_u:system_r:svirt_t:s0' from
/etc/selinux/targeted/contexts/virtual_domain_context using
the guest XML
- The
On Mon, Jun 27, 2011 at 13:55:06 -0400, Laine Stump wrote:
On 06/27/2011 05:50 AM, Jiri Denemark wrote:
On Sat, Jun 25, 2011 at 00:21:29 -0400, Laine Stump wrote:
(bootindex was showing up as 1 in the log; not knowing anything about
how it worked, I decided to try just changing it to 0.
2011/6/15 Eric Blake ebl...@redhat.com:
On 06/15/2011 07:40 AM, Matthias Bolte wrote:
---
daemon/remote.c | 4 +-
include/libvirt/libvirt.h.in | 99
--
src/driver.h | 4 +-
src/libvirt.c | 38
---
This patch depends on
https://www.redhat.com/archives/libvir-list/2011-June/msg01423.html
src/network/bridge_driver.c | 23 +--
src/util/dnsmasq.c | 10 --
src/util/dnsmasq.h |4 ++--
3 files changed, 19 insertions(+), 18 deletions(-)
On Tue, Jun 28, 2011 at 07:29:28AM -0400, Daniel J Walsh wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/27/2011 08:20 AM, Daniel P. Berrange wrote:
This patch series adds two new features
- The ability to override 'system_u:system_r:svirt_t:s0' from
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/28/2011 08:23 AM, Daniel P. Berrange wrote:
On Tue, Jun 28, 2011 at 07:29:28AM -0400, Daniel J Walsh wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/27/2011 08:20 AM, Daniel P. Berrange wrote:
This patch series adds two new
On 06/28/2011 03:16 AM, Osier Yang wrote:
Detected when playing with make -C tests valgrind.
---
tests/virnetmessagetest.c | 35 ---
1 files changed, 24 insertions(+), 11 deletions(-)
if (VIR_ALLOC(err.str3) 0)
-return -1;
+goto
On Tue, Jun 28, 2011 at 11:50:00 +0200, Michal Privoznik wrote:
On 27.06.2011 11:27, Jiri Denemark wrote:
When CURRENT and FORCE flags were used together, UpdateDeviceFlags did
nothing because it failed to transform CURRENT into either LIVE or
CONFIG.
---
src/qemu/qemu_driver.c |7
On 06/27/2011 08:24 AM, Daniel P. Berrange wrote:
This patch set actually switches the libvirtd daemon and remote
driver client code to use the new RPC code.
While it has had a fair amount of testing, it has also been
rebased many many many times. There are bound to be things in
it which
On Tue, Jun 28, 2011 at 01:51:29PM +0200, Matthias Bolte wrote:
2011/6/15 Eric Blake ebl...@redhat.com:
On 06/15/2011 07:40 AM, Matthias Bolte wrote:
---
daemon/remote.c | 4 +-
include/libvirt/libvirt.h.in | 99
--
On Mon, Jun 27, 2011 at 03:24:35PM +0100, Daniel P. Berrange wrote:
This patch set actually switches the libvirtd daemon and remote
driver client code to use the new RPC code.
While it has had a fair amount of testing, it has also been
rebased many many many times. There are bound to be
On 06/28/2011 04:09 AM, Michal Privoznik wrote:
On 28.06.2011 09:58, Wen Congyang wrote:
If we pass VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG to
qemuGetSchedulerParametersFlags() or *nparams is less than 1,
we will unlock qemu_driver without locking it. It's very dangerous.
We should
On 06/28/2011 05:10 AM, Matthias Bolte wrote:
networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010).
It has a force flag. If the dnsmasq hostsfile already exists force
needs to be true to overwrite it. networkBuildDnsmasqArgv sets force
to false, networkDefine sets it to true. This
On 06/28/2011 01:10 PM, Matthias Bolte wrote:
networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010).
It has a force flag. If the dnsmasq hostsfile already exists force
needs to be true to overwrite it. networkBuildDnsmasqArgv sets force
to false, networkDefine sets it to true. This
2011/6/28 Daniel P. Berrange berra...@redhat.com:
On Tue, Jun 28, 2011 at 01:51:29PM +0200, Matthias Bolte wrote:
2011/6/15 Eric Blake ebl...@redhat.com:
On 06/15/2011 07:40 AM, Matthias Bolte wrote:
---
daemon/remote.c | 4 +-
include/libvirt/libvirt.h.in | 99
On 06/28/2011 06:08 AM, Matthias Bolte wrote:
---
This patch depends on
https://www.redhat.com/archives/libvir-list/2011-June/msg01423.html
which is now ACK'd.
src/network/bridge_driver.c | 23 +--
src/util/dnsmasq.c | 10 --
Hi,
Linux host systems running KVM support various power management
capabilities. Most of the features like DVFS and sleep states can be
independently exploited by the host system itself based on system
utilisation subject to policies set by the administrator.
However, system-wide low power
* libvirt.spec.in (with_sanlock): Only default on in rawhide.
Reported by Gerhard Stenzel.
---
libvirt.spec.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 0111519..a4f050d 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@
On Tue, Jun 28, 2011 at 11:35:11AM +0100, Daniel P. Berrange wrote:
On Mon, Jun 27, 2011 at 02:49:37PM -0600, Eric Blake wrote:
On 06/27/2011 02:08 PM, Eric Blake wrote:
@@ -874,26 +646,14 @@ doRemoteOpen (virConnectPtr conn,
/* Now try and find out what URI the daemon used */
On 06/24/2011 07:04 AM, Daniel P. Berrange wrote:
On Mon, Jun 20, 2011 at 02:51:53PM +0100, Daniel P. Berrange wrote:
An update of
http://www.redhat.com/archives/libvir-list/2011-May/msg00223.html
New in this series:
- Split the patch up into more pieces for easier review
- Add
On 06/24/2011 07:02 AM, Daniel P. Berrange wrote:
This is an update to
http://www.redhat.com/archives/libvir-list/2011-June/msg00813.html
Changed in this v2 posting
- Incorporated feedback from v1
- Removed the cron job. This should be manually setup by the
admin on only one host
On 06/24/2011 07:02 AM, Daniel P. Berrange wrote:
Allow a 'configFile' parameter to be passed into the lock
drivers to provide configuration. Wire up the QEMU driver
to pass in file names '/etc/libvirt/qemu-$NAME.conf
eg qemu-sanlock.conf
* src/locking/lock_driver.h,
On 06/24/2011 07:02 AM, Daniel P. Berrange wrote:
Introduce a configuration file with a single parameter
'require_lease_for_disks', which is used to decide whether
it is allowed to start a guest which has read/write disks,
but without any leases.
* libvirt.spec.in: Add sanlock config file
If a callback being invoked from a stream issues a virStreamAbort
operation, the stream data will be free'd but the callback will
then stil try to use this. Delay free'ing of the stream data when
a callback is dispatching
* src/fdstream.c: Delay stream free when callback is active
---
This is a series of bug fixes to the new RPC code I have done
since I posted the original series, which is now merged.
Most of these fixes relate to handling of I/O streams.
Patches 1 and 9 also impacted the original code prior to the
RPC rewrite, and should be backported by people maintaining
If a streams error is raised, virNetClientIOEventLoop
returns 0, but an error is set. Check for this and
propagate it if present
* src/rpc/virnetclient.c: Propagate streams error
---
src/rpc/virnetclient.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git
The RPC client treats failure to register a socket watch
as non-fatal, since we do not mandate that a libvirt client
application provide an event loop implementation. It is
thus inappropriate to a log a message at VIR_LOG_WARN
* src/rpc/virnetsocket.c: Lower logging level
---
Improve log messages issued when encountering a bogus
message length to include the actual length and the
limit violated
* src/rpc/virnetmessage.c: Improve log messages
---
src/rpc/virnetmessage.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git
When a filter steals an RPC message, that message must
not be freed, except by the filter code itself
* src/rpc/virnetserverclient.c: Don't free stolen RPC
messages
---
src/rpc/virnetserverclient.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git
* src/rpc/virnetclientstream.c: Avoid referencing NULL
---
src/rpc/virnetclientstream.c | 21 -
1 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/src/rpc/virnetclientstream.c b/src/rpc/virnetclientstream.c
index 44c9acf..99c7b41 100644
---
When the remote client receives end of file on the stream
it never invokes the stream callback. Applications relying
on async event driven I/O will thus never see the EOF
condition on the stream
* src/rpc/virnetclient.c, src/rpc/virnetclientstream.c:
Ensure EOF is dispatched
---
On 06/27/2011 01:57 PM, Eric Blake wrote:
On 06/24/2011 11:33 PM, Laine Stump wrote:
If a domain name is defined for a network, add the --expand-hosts
option to the dnsmasq commandline. This results in the domain being
added to any hostname that is defined in a dnshost element and
contains no
On 06/24/2011 07:02 AM, Daniel P. Berrange wrote:
The current sanlock plugin requires a central management
application to manually add lease elements to each guest,
to protect resources that are assigned to it (eg writable
disks). This makes the sanlock plugin useless for usage
in more adhoc
On 06/24/2011 07:02 AM, Daniel P. Berrange wrote:
Add a page which documents how to configure lock managers,
focusing on use of sanlock with the QEMU/KVM driver
* docs/locking.html.in: Docs about lock managers
* docs/sitemap.html.in: Add lock manager config to
the deployment section
---
On Tue, Jun 28, 2011 at 09:52:27AM -0600, Eric Blake wrote:
* libvirt.spec.in (with_sanlock): Only default on in rawhide.
Reported by Gerhard Stenzel.
---
libvirt.spec.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index
On Tue, Jun 28, 2011 at 11:10:57AM -0600, Eric Blake wrote:
On 06/24/2011 07:02 AM, Daniel P. Berrange wrote:
Add a page which documents how to configure lock managers,
focusing on use of sanlock with the QEMU/KVM driver
* docs/locking.html.in: Docs about lock managers
*
On Tue, Jun 28, 2011 at 11:02:24AM -0600, Eric Blake wrote:
+if (virAsprintf(path, %s/%s,
+driver-autoDiskLeasePath,
+VIR_LOCK_MANAGER_SANLOCK_AUTO_DISK_LOCKSPACE) 0) {
+virReportOOMError();
+goto error;
+}
+
+
On Mon, Jun 27, 2011 at 10:07:23AM -0600, Eric Blake wrote:
On 06/27/2011 06:20 AM, Daniel P. Berrange wrote:
Normally the dynamic labelling mode will always use a base
label of 'svirt_t' for VMs. Introduce a baselabel field
in the seclabel XML to allow this base label to be changed
eg
On 06/28/2011 11:16 AM, Daniel P. Berrange wrote:
On Tue, Jun 28, 2011 at 09:52:27AM -0600, Eric Blake wrote:
* libvirt.spec.in (with_sanlock): Only default on in rawhide.
Reported by Gerhard Stenzel.
---
libvirt.spec.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
If a callback being invoked from a stream issues a virStreamAbort
operation, the stream data will be free'd but the callback will
then stil try to use this. Delay free'ing of the stream data when
s/stil/still/
a callback is dispatching
*
On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
If a streams error is raised, virNetClientIOEventLoop
returns 0, but an error is set. Check for this and
propagate it if present
* src/rpc/virnetclient.c: Propagate streams error
---
src/rpc/virnetclient.c |5 +
1 files changed, 5
Problem introduced in commit 6818cf86.
* src/remote_protocol-structs: Delete unused struct.
---
Pushing under the build-breaker rule.
Normally, deleting a struct from remote_protocol-structs is a
sign of an over-the-wire API breakage; but in this case, I've
verified that the new RPC code
On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
The RPC client treats failure to register a socket watch
as non-fatal, since we do not mandate that a libvirt client
application provide an event loop implementation. It is
thus inappropriate to a log a message at VIR_LOG_WARN
*
On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
On stream completion it is neccessary to send back a
s/neccessary/necessary/ (must be one of your finger-memory typos ;)
message with an empty payload. The message header was
not being filled out correctly, since we were not writing
any
On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
Improve log messages issued when encountering a bogus
message length to include the actual length and the
limit violated
* src/rpc/virnetmessage.c: Improve log messages
---
src/rpc/virnetmessage.c | 10 ++
1 files changed, 6
On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
When a filter steals an RPC message, that message must
not be freed, except by the filter code itself
* src/rpc/virnetserverclient.c: Don't free stolen RPC
messages
---
src/rpc/virnetserverclient.c |6 +-
1 files changed, 5
On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
* src/rpc/virnetclientstream.c: Avoid referencing NULL
---
src/rpc/virnetclientstream.c | 21 -
1 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/src/rpc/virnetclientstream.c b/src/rpc/virnetclientstream.c
On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
The client stream object can be used independantly of the
s/independantly/independently/
virNetClientPtr object, so must have full locking of its
own and not rely on any caller.
* src/remote/remote_driver.c: Remove locking around stream
On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
When the remote client receives end of file on the stream
it never invokes the stream callback. Applications relying
on async event driven I/O will thus never see the EOF
condition on the stream
* src/rpc/virnetclient.c,
Detected by gcc -O2:
remote/remote_driver.c: In function 'doRemoteOpen':
remote/remote_driver.c:2753:26: error: 'sasl' may be used uninitialized in this
function [-Werror=uninitialized]
* src/remote/remote_driver.c (remoteAuthSASL): Initialize sasl.
---
Pushing under the build-breaker rule.
daemon/remote_dispatch_bodies.h is no longer with us and shouldn't be
searched for translatable strings.
---
Pushed under the build-breaker rule.
po/POTFILES.in |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index a81fc55..1f226fd 100644
---
Pushed under the build-breaker rule.
daemon/libvirtd.c | 10 +-
daemon/remote.c |2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 62f089d..d1f80e4 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -874,7
On 06/28/2011 01:22 PM, Jiri Denemark wrote:
daemon/remote_dispatch_bodies.h is no longer with us and shouldn't be
searched for translatable strings.
---
Pushed under the build-breaker rule.
ACK; however, this patch is incomplete.
+++ b/po/POTFILES.in
@@ -1,6 +1,5 @@
daemon/libvirtd.c
Detected by gcc -O2, introduced in commit 532ce9c2. If dmidecode
outputs a field unrecognized by the parsers, then the code would
dereference an uninitialized eol variable.
* src/util/sysinfo.c (virSysinfoParseBIOS)
(virSysinfoParseSystem, virSysinfoParseProcessor)
(virSysinfoParseMemory): Avoid
For good or for bad, I did a fresh checkout, ./autogen.sh, then
'configure', then 'make syntax-check', and was surprised that it
failed. Running 'make' before 'make syntax-check' cleaned up the
issue, but this patch makes it work up front.
* cfg.mk (sc_po_check): Add prerequisite.
---
I debated
./autobuild.sh died on several messages resembling:
../../src/rpc/virnetsocket.c: In function 'virNetSocketNewListenTCP':
../../src/rpc/virnetsocket.c:231:9: error: implicit declaration of function
'bind_used_without_requesting_gnulib_module_bind'
[-Wimplicit-function-declaration]
Version 1.3 uses this macro
#define STAP_CAST(t) (size_t)t
that breaks if t is a function. For that to work it should probably
look like this
#define STAP_CAST(t) ((size_t)(t))
In systemtap 1.4 this was completely rewritten.
Anyway, before commit df0b57a95a767c t was always a variable,
s/compliation/compilation/ in the subject
On 06/28/2011 04:34 PM, Matthias Bolte wrote:
Version 1.3 uses this macro
version 1.3 of sys/sdt.h
#define STAP_CAST(t) (size_t)t
that breaks if t is a function. For that to work it should probably
look like this
#define STAP_CAST(t)
For good or for bad, I did a fresh checkout, ./autogen.sh, then
'configure', then 'make syntax-check', and was surprised that it
failed. Running 'make' before 'make syntax-check' cleaned up the
issue, but this patch makes it work up front.
* cfg.mk (sc_po_check): Add prerequisite.
---
I
2011/6/29 Eric Blake ebl...@redhat.com:
s/compliation/compilation/ in the subject
On 06/28/2011 04:34 PM, Matthias Bolte wrote:
Version 1.3 uses this macro
version 1.3 of sys/sdt.h
#define STAP_CAST(t) (size_t)t
that breaks if t is a function. For that to work it should probably
look
2011/6/28 Eric Blake ebl...@redhat.com:
On 06/28/2011 05:10 AM, Matthias Bolte wrote:
networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010).
It has a force flag. If the dnsmasq hostsfile already exists force
needs to be true to overwrite it. networkBuildDnsmasqArgv sets force
to
2011/6/28 Eric Blake ebl...@redhat.com:
On 06/28/2011 06:08 AM, Matthias Bolte wrote:
---
This patch depends on
https://www.redhat.com/archives/libvir-list/2011-June/msg01423.html
which is now ACK'd.
src/network/bridge_driver.c | 23 +--
src/util/dnsmasq.c
addnhostsSave and hostsfileSave expect 0 return value on error from
addnhostsWrite and hostsfileWrite but then pass err instead of -err
to virReportSystemError that expects an errno value.
Also addnhostsWrite returns -ENOMEM and errno, change this to -errno.
addnhostsWrite and hostsfileWrite
于 2011年06月28日 18:06, Michal Privoznik 写道:
On 28.06.2011 10:06, Osier Yang wrote:
---
src/conf/network_conf.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index d0860d8..45ddee2 100644
--- a/src/conf/network_conf.c
Hi, Eric
Thank you for your review.
On Mon, 27 Jun 2011 09:03:57 -0600
Eric Blake ebl...@redhat.com wrote:
On 06/27/2011 04:13 AM, Daniel P. Berrange wrote:
On Mon, Jun 27, 2011 at 05:25:17PM +0900, Minoru Usui wrote:
sysinfo: delete unnecessary white space of sysinfo.
* Add
于 2011年06月28日 21:10, Eric Blake 写道:
On 06/28/2011 03:16 AM, Osier Yang wrote:
Detected when playing with make -C tests valgrind.
---
tests/virnetmessagetest.c | 35 ---
1 files changed, 24 insertions(+), 11 deletions(-)
if (VIR_ALLOC(err.str3) 0)
On Wed, Jun 29, 2011 at 02:14:19AM +0200, Matthias Bolte wrote:
addnhostsSave and hostsfileSave expect 0 return value on error from
addnhostsWrite and hostsfileWrite but then pass err instead of -err
to virReportSystemError that expects an errno value.
Also addnhostsWrite returns -ENOMEM
When configured --without-remote, the files remote_protocol.[ch]
are not built by src/Makefile, but are still used by daemon/Makefile.
The solution is to copy the implicit rule.
* daemon/Makefile.am (%protocol.c, %protocol.h): Copy from src.
---
Not quite trivial enough to claim the
On 06/28/2011 05:03 PM, Osier Yang wrote:
It will be nice if you could explain what the patch series does
with git send-email --compose, and also each patch should have
a description, as your patches are not tiny patch which one can
get the sense at a glance.
Only a patch subject is hard for
virt-sanlock-cleanup.8 has static contents (no dependency on
configure), but is generated by pod2man (a perl dependency that
maintainers must have, but which ordinary tarball users need
not have). Therefore, ensure that it is always part of the
tarball, even though it is only conditionally
None of these instances cause any semantic differences, but
consistency is nice.
* src/Makefile.am: Replace leading spaces with tabs.
---
Pushing under the trivial rule.
src/Makefile.am | 26 +-
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git
EXTRA_DIST is intended for files that must unconditionally be
part of the tarball, so it should be outside HAVE_SANLOCK.
Once that is fixed, then there is no need to cp an unchanged
qemu-sanlock.conf from srcdir to builddir in a VPATH build,
not to mention that $(builddir) is not supported in the
Eric Blake ebl...@redhat.com writes:
EXTRA_DIST is intended for files that must unconditionally be
part of the tarball, so it should be outside HAVE_SANLOCK.
Once that is fixed, then there is no need to cp an unchanged
qemu-sanlock.conf from srcdir to builddir in a VPATH build,
not to
If virSysinfoParse{BIOS,System,Processor,Memory}()
can't find newline('\n'), these return NULL.
This patch fixes this.
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
src/util/sysinfo.c | 23 +--
1 files changed, 13 insertions(+), 10 deletions(-)
diff --git
sysinfo: add virSkipSpacesBackwards()
* Add virSkipSpacesBackwards() to src/util/util.[ch]
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
src/util/util.c | 25 +
src/util/util.h |1 +
2 files changed, 26 insertions(+), 0 deletions(-)
diff --git
sysinfo: delete unnecessary white space of sysinfo.
This is v2 of delete unnecessary white space of sysinfo.
Changes
v1-v2:
- Rebase latest libvirt GIT tree.
- Use c_isspace() in virSkipSpacesBackwards().
Minoru Usui (2):
sysinfo: add virSkipSpacesBackwards()
sysinfo: delete
sysinfo: delete unnecessary white space of sysinfo.
* Trim each element and delete null entry of sysinfo by
virSkipSpacesBackwards().
Signed-off-by: Minoru Usui u...@mxm.nes.nec.co.jp
---
src/util/sysinfo.c | 21 +
1 files changed, 21 insertions(+), 0 deletions(-)
diff
95 matches
Mail list logo
