Re: [libvirt] [PATCH 10/10] network: internal API functions to manage assignment of physdev to guest

2011-07-09 Thread Laine Stump
On 07/08/2011 04:23 PM, Eric Blake wrote: On 07/05/2011 10:18 PM, Laine Stump wrote: I realized that PATCH 10/10 would cause the build to fail if someone did a build --with-qemu but --without-network. I'm squashing the following into the original patch to remedy that. I'm not really a fan of pu

Re: [libvirt] Disk snapshot mode proposal: patch for storing the snapshot mode from .vmx to .xml

2011-07-09 Thread Matthias Bolte
2011/7/7 computern...@rambler.ru : > Hello, > > Few days ago I have proposed to implement the snapshot mode functionality > for esx/vpx: > Mail subject: "[libvirt] VMWare "independent disk" processing needed" > Sent: "04.07.2011" > Sender: "computern...@rambler.ru" > > What I meant is to allow "lib

Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Matthias Bolte
2011/7/9 Eric Blake : > On 07/09/2011 07:27 AM, Eric Blake wrote: >>> >>> Also seq isn't portable. Therefore, calculate the correct padding >>> length directly and use printf to output it at once. >>> --- >>>  tests/test-lib.sh |    9 ++--- >>>  1 files changed, 2 insertions(+), 7 deletions(-)

Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Eric Blake
On 07/09/2011 07:27 AM, Eric Blake wrote: >> >> Also seq isn't portable. Therefore, calculate the correct padding >> length directly and use printf to output it at once. >> --- >> tests/test-lib.sh |9 ++--- >> 1 files changed, 2 insertions(+), 7 deletions(-) > > ACK. On second thought,

Re: [libvirt] [PATCH] vbox: Fix logic in storage driver open function

2011-07-09 Thread Matthias Bolte
2011/7/7 Eric Blake : > On 07/07/2011 01:24 AM, Matthias Bolte wrote: >> If the main driver is the vbox driver, then the open function >> has to return an error if the private data is invalid. >> --- >>  src/vbox/vbox_tmpl.c |    7 ++- >>  1 files changed, 2 insertions(+), 5 deletions(-) > > AC

Re: [libvirt] 2/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Matthias Bolte
2011/7/9 Eric Blake : > On 07/09/2011 03:51 AM, Matthias Bolte wrote: >> Here's a v2 that does this. >> >> -- Matthias Bolte http://photron.blogspot.com >> Subject: [PATCH] tests: Improve output of tests that decide to skip at >> runtime >> >> Don't print OK/FAIL for test that decide to be skipped

Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Matthias Bolte
2011/7/9 Eric Blake : > On 07/09/2011 02:44 AM, Matthias Bolte wrote: >> Yes, that approach is nicer and also the logic it a bit simpler. Here's a v2. >> >> -- Matthias Bolte http://photron.blogspot.com >> >> Subject: [PATCH] tests: Fix compressed test output padding logic >> >> The current logic t

Re: [libvirt] [PATCH] Add domain type checking

2011-07-09 Thread Matthias Bolte
2011/7/8 Eric Blake : > On 07/08/2011 02:13 AM, Matthias Bolte wrote: >> The drivers were accepting domain configs without checking if those >> were actually meant for them. For example the LXC driver happily >> accepts configs with type QEMU. >> >> For convenience add an optional check for the dom

Re: [libvirt] testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Eric Blake
On 07/09/2011 03:53 AM, Matthias Bolte wrote: >> if (!virTestGetVerbose()) { > > When we add && ret != EXIT_AM_SKIP here ... as you did in https://www.redhat.com/archives/libvir-list/2011-July/msg00522.html > >> -int i; >> -for (i = (testCounter % 40) ; i > 0 && i < 40 ; i++

Re: [libvirt] 2/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Eric Blake
On 07/09/2011 03:51 AM, Matthias Bolte wrote: > Here's a v2 that does this. > > -- Matthias Bolte http://photron.blogspot.com > Subject: [PATCH] tests: Improve output of tests that decide to skip at runtime > > Don't print OK/FAIL for test that decide to be skipped after > calling virtTestMain. D

Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Eric Blake
On 07/09/2011 02:44 AM, Matthias Bolte wrote: > Yes, that approach is nicer and also the logic it a bit simpler. Here's a v2. > > -- Matthias Bolte http://photron.blogspot.com > > Subject: [PATCH] tests: Fix compressed test output padding logic > > The current logic tries to count from 1 to 40 a

Re: [libvirt] testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Matthias Bolte
2011/7/9 Eric Blake : > On 07/08/2011 05:28 PM, Matthias Bolte wrote: >>> TEST: virsh-all >>>       40 >>>       80 >>>       120 >>>      ...

Re: [libvirt] 2/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Matthias Bolte
2011/7/9 Eric Blake : > On 07/08/2011 05:28 PM, Matthias Bolte wrote: >> >> From a1508239af921289cd6e357e8521ff42faf535bd Mon Sep 17 00:00:00 2001 >> From: Matthias Bolte >> Date: Sat, 9 Jul 2011 01:24:16 +0200 >> Subject: [PATCH] tests: Add the logic to skip the statstest to the right >> place >

Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Matthias Bolte
2011/7/9 Eric Blake : > On 07/08/2011 05:28 PM, Matthias Bolte wrote: >> >> From cb39f79417dce294c654435c1a783065b4983adb Mon Sep 17 00:00:00 2001 >> From: Matthias Bolte >> Date: Sat, 9 Jul 2011 01:20:05 +0200 >> Subject: [PATCH] tests: Fix compressed test output padding logic >> >> The current l

Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Matthias Bolte
2011/7/9 Eric Blake : > On 07/08/2011 07:40 PM, Eric Blake wrote: >>> >>> Instead count from 0 to 39 to fix this. >>> --- >>>  tests/test-lib.sh |    6 +++--- >>>  1 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/tests/test-lib.sh b/tests/test-lib.sh >>> index 768f96b..9eb6864

Re: [libvirt] 3/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

2011-07-09 Thread Matthias Bolte
2011/7/9 Eric Blake : > On 07/08/2011 05:28 PM, Matthias Bolte wrote: >> >> From 79e8a7e876722a67c37d930762e7a8b32701c6ca Mon Sep 17 00:00:00 2001 >> From: Matthias Bolte >> Date: Sat, 9 Jul 2011 01:24:44 +0200 >> Subject: [PATCH] tests: Use EXIT_AM_SKIP instead of 77 directly >> >> --- >>  tests/