On Thu, Jul 14, 2011 at 11:38:54 -0600, Eric Blake wrote:
optional is not a very good meta-syntactic construct in our man
page. I scrubbed this, and additionally improved some documentation
on mutually exclusive options. For example,
{[--live] [--config] | --current}
implies that the
Introduce the function virCgroupForVcpu() to create sub directory for each vcpu.
---
src/libvirt_private.syms |1 +
src/util/cgroup.c| 72 ++---
src/util/cgroup.h|5 +++
3 files changed, 73 insertions(+), 5 deletions(-)
diff --git
---
src/qemu/qemu_driver.c | 259 +++-
1 files changed, 234 insertions(+), 25 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 8d54e58..c5d0e05 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5111,6
---
src/conf/domain_conf.c | 20 +++-
src/conf/domain_conf.h |2 +
src/qemu/qemu_cgroup.c | 127 +++
src/qemu/qemu_cgroup.h |4 +
src/qemu/qemu_process.c
---
docs/formatdomain.html.in | 19 +++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 269fc30..d388332 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -307,6 +307,8 @@
于 2011年07月18日 17:33, Michal Privoznik 写道:
We missed ending tag for paragraph element
---
docs/formatdomain.html.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 269fc30..a54ee6a 100644
---
On 18.07.2011 12:00, Osier Yang wrote:
于 2011年07月18日 17:33, Michal Privoznik 写道:
We missed ending tag for paragraph element
---
docs/formatdomain.html.in | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index
On Fri, Jul 15, 2011 at 16:18:54 +0100, Daniel P. Berrange wrote:
On Fri, Jul 15, 2011 at 04:41:38PM +0200, Jiri Denemark wrote:
When an asynchronous job is running while another API that is
incompatible with that job is called, we now try to wait until the job
finishes and either run the
On Fri, Jul 15, 2011 at 09:09:52 -0600, Eric Blake wrote:
On 07/15/2011 08:41 AM, Jiri Denemark wrote:
When an asynchronous job is running while another API that is
incompatible with that job is called, we now try to wait until the job
finishes and either run the API or fail with timeout. I
On Sun, Jul 17, 2011 at 06:44:57PM +0800, Guannan Ren wrote:
---
src/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 54b1ca0..90c4393 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -878,7 +878,7 @@
On Sun, Jul 17, 2011 at 06:45:00PM +0800, Guannan Ren wrote:
---
src/storage/storage_backend.c |9
src/storage/storage_driver.c | 83
-
2 files changed, 82 insertions(+), 10 deletions(-)
diff --git a/src/storage/storage_backend.c
On 07/18/2011 06:57 PM, Daniel P. Berrange wrote:
On Sun, Jul 17, 2011 at 06:45:00PM +0800, Guannan Ren wrote:
---
src/storage/storage_backend.c |9
src/storage/storage_driver.c | 83 -
2 files changed, 82 insertions(+), 10 deletions(-)
duplicate documents for iface-name, lacks of document for
iface-mac, inconsistent option names with virsh help strings.
---
tools/virsh.pod | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 377fac0..4f218d3 100644
---
On Tue, Jul 12, 2011 at 13:57:07 +0200, Michal Privoznik wrote:
Define new 'bandwidth' element with possible child element 'inbound'
and 'outbound' addressing incoming and outgoing traffic respectively:
bandwidth
inbound average='1mbit' peak='2mbit' burst='5m'/
outbound
On Tue, Jul 12, 2011 at 13:57:08 +0200, Michal Privoznik wrote:
---
src/util/network.h | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/src/util/network.h b/src/util/network.h
index ed0b78c..568bca1 100644
--- a/src/util/network.h
+++
On Tue, Jul 12, 2011 at 13:57:09 +0200, Michal Privoznik wrote:
These functions take on input decimal numbers optionally followed
by unit. Units are exactly the same as 'tc' accepts.
---
src/conf/domain_conf.c |3 +
src/conf/domain_conf.h |1 +
src/conf/network_conf.c |5 +
On Tue, Jul 12, 2011 at 13:57:10 +0200, Michal Privoznik wrote:
---
src/conf/domain_conf.c |3 +
src/conf/network_conf.c |3 +
src/libvirt_private.syms |3 +
src/util/network.c | 153
++
src/util/network.h |7 ++
On Mon, 2011-07-18 at 17:34 +0800, Wen Congyang wrote:
TODO:
1. We create sub directory for each vcpu in cpu subsystem. So
we should recalculate cpu.shares for each vcpu.
Is the per vcpu cgroup optional? I.e., is is possible to set the period
and quota for the entire domain and let the
On Tue, Jul 12, 2011 at 13:57:11 +0200, Michal Privoznik wrote:
These function executes 'tc' with appropriate arguments to set
desired QoS setting on interface or bridge during its creation.
---
configure.ac|4 +
src/libvirt_private.syms|2 +
On Tue, Jul 12, 2011 at 13:57:12 +0200, Michal Privoznik wrote:
---
tests/networkxml2xmlin/bandwidth-network.xml | 16
tests/networkxml2xmlout/bandwidth-network.xml | 16
tests/networkxml2xmltest.c|1 +
3 files changed, 33
On Tue, Jul 12, 2011 at 13:57:13 +0200, Michal Privoznik wrote:
---
tests/domainschemadata/domain-bandwidth.xml | 72
+++
1 files changed, 72 insertions(+), 0 deletions(-)
create mode 100644 tests/domainschemadata/domain-bandwidth.xml
No units, please :-)
Jirka
On Tue, Jul 12, 2011 at 13:57:06 +0200, Michal Privoznik wrote:
This patch series add support for setting traffic shaping and policing
on both domain's interface and network's virtual bridge. Basically,
this is done via 'tc' from iproute2 package. For shaping is HTB used,
for policing we need
On Fri, Jul 15, 2011 at 3:09 PM, Adam Litke a...@us.ibm.com wrote:
On 07/15/2011 05:39 AM, Stefan Hajnoczi wrote:
On Thu, Jul 14, 2011 at 7:47 PM, Adam Litke a...@us.ibm.com wrote:
On 07/13/2011 08:04 PM, Daniel Veillard wrote:
On Wed, Jul 13, 2011 at 03:46:30PM -0500, Adam Litke wrote:
When auto-starting a domain on libvirtd startup, let the user
configure whether to have the VIR_DOMAIN_START_DIRECT flag effect.
* src/qemu/qemu.conf (auto_start_direct): Document new variable.
* src/qemu/libvirtd_qemu.aug (vnc_entry): Let augeas parse it.
* src/qemu/qemu_conf.h (qemud_driver):
* tools/libvirt-guests.init.sh (start): Use SAVE_DIRECT.
---
Patch 10/8 has a bug fixed here - the code must use $direct rather
than $direct so as to elide the argument rather than inject an
empty string argument when the option is not in use.
The more I look at this series, the more I like the
On 07/17/2011 07:17 PM, Wen Congyang wrote:
At 07/17/2011 11:29 PM, a...@redhat.com Write:
From: Alex Jiaa...@redhat.com
* tools/virsh.c: avoid double free of domain, when weight value of blkiotune
less than 0, codes will free domain and jump to cleanup section, however,
cleanup will
On 07/15/2011 10:36 AM, Michal Privoznik wrote:
On 15.07.2011 16:29, Eric Blake wrote:
On 07/15/2011 07:58 AM, Michal Privoznik wrote:
Right now it is possible to undefine an active interface, or
destroy inactive. This patch add some checking to these operations
to prevent this. Also fix test
On 07/15/2011 03:06 AM, Osier Yang wrote:
---
tools/virsh.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
Your rebuttals to my arguments about positioning are sound, so I'm okay
with leaving the positioning of this output prior to Security strings.
However, on
HI, Eric,
I download the libvirt-0.9.3.tar.gz, compile, and install it.
Then when I tried the command virsh migrate-setspeed vm --bandwidth
1000.
It gives me the error error: unknown procedure: 207
Do you have any solution to this? Thanks.
- Hui
On 7/15/11 2:57 PM, Eric Blake ebl...@redhat.com
On 07/18/2011 11:34 AM, Eric Blake wrote:
Here, we print managed state, but the command that creates that state
is called managedsave, and the API we call is
virDomainHasManagedSaveImage. Not to mention that it surpasses 15
columns, which makes the output not lined up with all the other rows.
On 07/18/2011 11:34 AM, Hui Kang wrote:
HI, Eric,
I download the libvirt-0.9.3.tar.gz, compile, and install it.
Then when I tried the command virsh migrate-setspeed vm --bandwidth
1000.
It gives me the error error: unknown procedure: 207
Do you have any solution to this? Thanks.
That means
On 07/18/2011 05:13 AM, Guannan Ren wrote:
Independantly of this, IMHO pthread cancellation handlers are a recipe
for trouble because it is incredibly hard to make sure you correctly
cleanup all resources in the thread, even with use of cleanup handlers.
IMHO, threads should be made to monitor
On 07/18/2011 05:45 AM, Osier Yang wrote:
duplicate documents for iface-name, lacks of document for
iface-mac, inconsistent option names with virsh help strings.
---
tools/virsh.pod | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/tools/virsh.pod
On 07/15/2011 05:12 PM, Eric Blake wrote:
There were two API in driver.c that were silently masking flags
bits prior to calling out to the drivers, and several others
that were explicitly masking flags bits. This is not
forward-compatible - if we ever have that many flags in the
future, then
This patch series add support for setting traffic shaping and policing
on both domain's interface and network's virtual bridge. Basically,
this is done via 'tc' from iproute2 package. For shaping is HTB used,
for policing we need u32 match selector. Both should be available in
RHEL-6 kernel.
How
---
src/util/network.h | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/src/util/network.h b/src/util/network.h
index ed0b78c..af32558 100644
--- a/src/util/network.h
+++ b/src/util/network.h
@@ -45,6 +45,20 @@ typedef struct {
typedef virSocketAddr
---
tests/domainschemadata/domain-bandwidth.xml | 72 +++
1 files changed, 72 insertions(+), 0 deletions(-)
create mode 100644 tests/domainschemadata/domain-bandwidth.xml
diff --git a/tests/domainschemadata/domain-bandwidth.xml
---
src/conf/domain_conf.c |3 ++
src/conf/network_conf.c |3 ++
src/libvirt_private.syms |1 +
src/util/network.c | 72 ++
src/util/network.h |4 ++
5 files changed, 83 insertions(+), 0 deletions(-)
diff --git
These function executes 'tc' with appropriate arguments to set
desired QoS setting on interface or bridge during its creation.
---
configure.ac|4 +
src/libvirt_private.syms|2 +
src/network/bridge_driver.c | 12 +++
src/qemu/qemu_command.c | 10 +++-
These functions parse given XML node and store the output at given
pointer. Unknown elements are silently ignored. Attributes must be
integer and must fit in unsigned long.
---
src/conf/domain_conf.c |3 +
src/conf/domain_conf.h |1 +
src/conf/network_conf.c |5 ++
---
tests/networkxml2xmlin/bandwidth-network.xml | 16
tests/networkxml2xmlout/bandwidth-network.xml | 16
tests/networkxml2xmltest.c|1 +
3 files changed, 33 insertions(+), 0 deletions(-)
create mode 100644
On 07/18/2011 09:35 AM, Stefan Hajnoczi wrote:
On the other hand I suspect that we are missing the mechanism to
control the rate of the transfer in the new API, which is something
which could be implemented in the old incremental mechanism, but not
anymore. So I wonder if the
On 07/18/2011 04:41 AM, Wen Congyang wrote:
---
docs/schemas/domain.rng | 26 +-
1 files changed, 25 insertions(+), 1 deletions(-)
diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
index 8a4e3fe..5f8151d 100644
--- a/docs/schemas/domain.rng
+++
On 07/18/2011 01:27 PM, Eric Blake wrote:
On 07/15/2011 05:12 PM, Eric Blake wrote:
There were two API in driver.c that were silently masking flags
bits prior to calling out to the drivers, and several others
that were explicitly masking flags bits. This is not
forward-compatible - if we ever
On 07/18/2011 02:39 PM, Eric Blake wrote:
On second thought, I don't like this. It's nicer to have all the driver
callbacks match the public API as much as possible, and to instead
create a new entry point in libvirt_private.syms that qemu can use for
the case where it needs to call the internal
On 07/18/2011 04:42 AM, Wen Congyang wrote:
@@ -5983,7 +6169,30 @@ out:
goto cleanup;
}
-*nparams = 1;
+if (*nparams 1) {
+params[1].value.ul = period;
+params[1].type = VIR_TYPED_PARAM_ULLONG;
+if (virStrcpyStatic(params[1].field,
On 07/18/2011 04:42 AM, Wen Congyang wrote:
+int qemuSetupCgroupForVcpu(struct qemud_driver *driver, virDomainObjPtr vm)
+{
+virCgroupPtr cgroup = NULL;
+virCgroupPtr cgroup_vcpu = NULL;
+qemuDomainObjPrivatePtr priv = vm-privateData;
+int rc;
+unsigned int i;
+
A bit of refactoring so that the public APIs are easier to match
to at least one driver callback, by making the internal flags
go through a new driver callback.
* docs/hvsupport.pl: Allow for internal-only callbacks.
* src/driver.h (virDrvSecretGetValue): Revert previous change.
On Mon, Jul 18, 2011 at 13:11:42 -0600, Eric Blake wrote:
On 07/18/2011 04:11 AM, Osier Yang wrote:
于 2011年07月18日 10:07, zhang xintao 写道:
Dear All
I try to migration a kvm guest os to another host failed
server: ubuntu 11.04 server
virsh:migrate --live --tunnelled vm1
On 07/18/2011 02:53 PM, Laine Stump wrote:
On 07/15/2011 07:12 PM, Eric Blake wrote:
There were two API in driver.c that were silently masking flags
bits prior to calling out to the drivers, and several others
that were explicitly masking flags bits. This is not
forward-compatible - if we ever
On 07/18/2011 03:17 PM, Jiri Denemark wrote:
That said, why can't virsh be smarter, and automatically request the
right underlying flags without making the user also type --p2p? Any
problems with this patch?
No problem at all, I think it's a very good idea.
From
Rename the existing --current flag to the new name --active,
while adding a new flag --current to expose the new
VIR_DOMAIN_AFFECT_CURRENT flag of virDomainGetVcpusFlags.
For backwards compability, the output does not change (even
though the label current no longer matches the spelling of
the
This is the rest of the original 19 patch series updated with some bugfixes
and rebased on current master, which is also available at
https://gitorious.org/~jirka/libvirt/jirka-staging/commits/migration-recovery
I didn't manage to run this through the libvirt-tck migration test but I did
some
This patch introduces several helper methods to deal with jobs and
phases during migration in a simpler manner.
---
src/qemu/MIGRATION.txt| 55 +++
src/qemu/qemu_domain.c|5 ++
src/qemu/qemu_migration.c | 91 +
Like other query commands, this can now be called directly during
migration.
---
src/qemu/qemu_domain.h|4
src/qemu/qemu_driver.c| 42 --
src/qemu/qemu_migration.c | 14 --
3 files changed, 12 insertions(+), 48 deletions(-)
Make MIGRATION_IN use the new helper methods.
---
src/qemu/qemu_domain.c|2 +-
src/qemu/qemu_domain.h|1 -
src/qemu/qemu_migration.c | 97 ++--
3 files changed, 41 insertions(+), 59 deletions(-)
diff --git a/src/qemu/qemu_domain.c
Like other query commands, this can now be called directly during
migration.
---
src/qemu/qemu_domain.h|4 ---
src/qemu/qemu_driver.c| 54 +++--
src/qemu/qemu_migration.c | 18 ---
3 files changed, 18 insertions(+), 58
---
src/qemu/qemu_process.c | 110 ++-
1 files changed, 109 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 448b06e..48bd435 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -37,6
Call qemu monitor command directly within a special job that is only
allowed during outgoing migration.
---
src/qemu/qemu_domain.c|1 +
src/qemu/qemu_domain.h|3 +--
src/qemu/qemu_driver.c| 23 +++
src/qemu/qemu_migration.c | 21 +
---
src/qemu/qemu_domain.h|1 -
src/qemu/qemu_driver.c| 46 ++--
src/qemu/qemu_migration.c |6 +
3 files changed, 24 insertions(+), 29 deletions(-)
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index 1593257..503b9ad
Call qemu monitor command directly within a special job that is only
allowed during outgoing migration.
---
src/qemu/qemu_domain.c|1 -
src/qemu/qemu_domain.h|6 --
src/qemu/qemu_driver.c| 23 +++
src/qemu/qemu_migration.c | 13 -
4
This doesn't abort migration job in any phase, yet.
---
src/qemu/qemu_domain.c|9 +---
src/qemu/qemu_domain.h| 12 +++---
src/qemu/qemu_driver.c| 36 ++---
src/qemu/qemu_migration.c | 48 -
At 07/19/2011 04:35 AM, Adam Litke Write:
This is looking good to me. I am pleased to see that the global case is
handled as expected when per-vcpu threads are not active.
On 07/18/2011 04:42 AM, Wen Congyang wrote:
snip
+int qemuSetupCgroupForVcpu(struct qemud_driver *driver,
At 07/19/2011 04:59 AM, Adam Litke Write:
On 07/18/2011 04:42 AM, Wen Congyang wrote:
+int qemuSetupCgroupForVcpu(struct qemud_driver *driver, virDomainObjPtr vm)
+{
+virCgroupPtr cgroup = NULL;
+virCgroupPtr cgroup_vcpu = NULL;
+qemuDomainObjPrivatePtr priv = vm-privateData;
At 07/19/2011 04:44 AM, Adam Litke Write:
On 07/18/2011 04:42 AM, Wen Congyang wrote:
@@ -5983,7 +6169,30 @@ out:
goto cleanup;
}
-*nparams = 1;
+if (*nparams 1) {
+params[1].value.ul = period;
+params[1].type = VIR_TYPED_PARAM_ULLONG;
+
At 07/18/2011 09:36 PM, Lee Schermerhorn Write:
On Mon, 2011-07-18 at 17:34 +0800, Wen Congyang wrote:
TODO:
1. We create sub directory for each vcpu in cpu subsystem. So
we should recalculate cpu.shares for each vcpu.
Is the per vcpu cgroup optional? I.e., is is possible to set the
于 2011年07月19日 03:24, Eric Blake 写道:
On 07/18/2011 05:45 AM, Osier Yang wrote:
duplicate documents for iface-name, lacks of document for
iface-mac, inconsistent option names with virsh help strings.
---
tools/virsh.pod | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff
于 2011年07月19日 02:43, Eric Blake 写道:
On 07/18/2011 01:53 AM, Osier Yang wrote:
This is just similiar as changes on qemu driver.
* src/libxl/libxl_driver.c: New callback for libxl_driver,
new function libxlDomainUndefineFlags, and changes libxlDomainUndefine
as a wrapper of
68 matches
Mail list logo
