于 2011年07月19日 01:37, Eric Blake 写道:
On 07/18/2011 11:34 AM, Eric Blake wrote:
Here, we print managed state, but the command that creates that state
is called managedsave, and the API we call is
virDomainHasManagedSaveImage. Not to mention that it surpasses 15
columns, which makes the output not
* src/util/event_poll.c: fix file descriptors leak on virEventPollInit.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open at exit.
==1254== Open file descriptor 5:
==1254==at 0x30736D9D47: pipe2 (syscall-template.S:82)
==1254==by 0x4DD6267: rpl_pipe2 (pipe2.c:61)
于 2011年07月19日 16:25, Alex Jia 写道:
* src/util/event_poll.c: fix file descriptors leak on virEventPollInit.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open at exit.
==1254== Open file descriptor 5:
==1254==at 0x30736D9D47: pipe2 (syscall-template.S:82)
==1254==by
2011/7/19 a...@redhat.com:
* src/util/event_poll.c: fix file descriptors leak on virEventPollInit.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open at exit.
==1254== Open file descriptor 5:
==1254== at 0x30736D9D47: pipe2 (syscall-template.S:82)
==1254== by
On 07/19/2011 05:00 PM, Osier Yang wrote:
于 2011年07月19日 16:25, Alex Jia 写道:
* src/util/event_poll.c: fix file descriptors leak on virEventPollInit.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open at exit.
==1254== Open file descriptor 5:
==1254==at 0x30736D9D47: pipe2
On 07/19/2011 05:00 PM, Matthias Bolte wrote:
2011/7/19a...@redhat.com:
* src/util/event_poll.c: fix file descriptors leak on virEventPollInit.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open at exit.
==1254== Open file descriptor 5:
==1254==at 0x30736D9D47: pipe2
On 07/19/2011 05:12 PM, Alex Jia wrote:
On 07/19/2011 05:00 PM, Matthias Bolte wrote:
2011/7/19a...@redhat.com:
* src/util/event_poll.c: fix file descriptors leak on virEventPollInit.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open at exit.
==1254== Open file descriptor
On Mon, Jul 18, 2011 at 01:11:42PM -0600, Eric Blake wrote:
On 07/18/2011 04:11 AM, Osier Yang wrote:
于 2011年07月18日 10:07, zhang xintao 写道:
Dear All
I try to migration a kvm guest os to another host failed
server: ubuntu 11.04 server
virsh:migrate --live --tunnelled vm1
* src/util/event_poll.c: only fix file descriptors leak on when
virEventPollAddHandle fail on virEventPollInit function.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open at exit.
==1254== Open file descriptor 5:
==1254==at 0x30736D9D47: pipe2 (syscall-template.S:82)
On Tue, Jul 19, 2011 at 05:34:28PM +0800, a...@redhat.com wrote:
* src/util/event_poll.c: only fix file descriptors leak on when
virEventPollAddHandle fail on virEventPollInit function.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open at exit.
==1254== Open file
On Tue, Jul 19, 2011 at 11:00:21AM +0200, Matthias Bolte wrote:
2011/7/19 a...@redhat.com:
* src/util/event_poll.c: fix file descriptors leak on virEventPollInit.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open at exit.
==1254== Open file descriptor 5:
==1254==
2011/7/19 Daniel Veillard veill...@redhat.com:
On Tue, Jul 19, 2011 at 11:00:21AM +0200, Matthias Bolte wrote:
2011/7/19 a...@redhat.com:
* src/util/event_poll.c: fix file descriptors leak on virEventPollInit.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open at
* src/util/event_poll.c: avoid file descriptors leak when
virEventPollAddHandle fail on virEventPollInit function.
---
src/util/event_poll.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/util/event_poll.c b/src/util/event_poll.c
index 285ba50..e2ae3a6 100644
On Tue, Jul 19, 2011 at 12:19:34PM +0200, Matthias Bolte wrote:
2011/7/19 Daniel Veillard veill...@redhat.com:
On Tue, Jul 19, 2011 at 11:00:21AM +0200, Matthias Bolte wrote:
2011/7/19 a...@redhat.com:
* src/util/event_poll.c: fix file descriptors leak on virEventPollInit.
Detected
On 07/19/2011 03:23 AM, Daniel P. Berrange wrote:
On Mon, Jul 18, 2011 at 01:11:42PM -0600, Eric Blake wrote:
On 07/18/2011 04:11 AM, Osier Yang wrote:
于 2011年07月18日 10:07, zhang xintao 写道:
Dear All
I try to migration a kvm guest os to another host failed
server: ubuntu 11.04 server
From: Daniel P. Berrange berra...@redhat.com
The current API build scripts will continue and exit with a zero
status even if they find problems. This has been the cause of many
build problems, or hidden build errors, in the past. Change the
scripts so they always exit with a non-zero status for
Currently there are no such procedures in the protocol, but programming
errors like a missing _args or _ret suffix on the structs in the .x files
can create such a situation by accident. Making the generator aware of
this avoids bogus errors from the generator such as:
Use of uninitialized
On Tue, Jul 19, 2011 at 06:19:13AM -0600, Eric Blake wrote:
On 07/19/2011 03:23 AM, Daniel P. Berrange wrote:
On Mon, Jul 18, 2011 at 01:11:42PM -0600, Eric Blake wrote:
On 07/18/2011 04:11 AM, Osier Yang wrote:
于 2011年07月18日 10:07, zhang xintao 写道:
Dear All
I try to migration a kvm guest os
2011/7/19 Daniel P. Berrange berra...@redhat.com:
From: Daniel P. Berrange berra...@redhat.com
The current API build scripts will continue and exit with a zero
status even if they find problems. This has been the cause of many
build problems, or hidden build errors, in the past. Change the
On Tue, Jul 19, 2011 at 02:22:10PM +0200, Matthias Bolte wrote:
Currently there are no such procedures in the protocol, but programming
errors like a missing _args or _ret suffix on the structs in the .x files
can create such a situation by accident. Making the generator aware of
this avoids
Caused by the new changed dominfo command. Pushed under trival
rule.
---
tests/virshtest.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tests/virshtest.c b/tests/virshtest.c
index 0932efd..e22e582 100644
--- a/tests/virshtest.c
+++ b/tests/virshtest.c
@@ -22,6 +22,7 @@
On Tue, Jul 19, 2011 at 02:29:04PM +0200, Matthias Bolte wrote:
2011/7/19 Daniel P. Berrange berra...@redhat.com:
From: Daniel P. Berrange berra...@redhat.com
The current API build scripts will continue and exit with a zero
status even if they find problems. This has been the cause of
On 07/18/2011 07:46 PM, Wen Congyang wrote:
At 07/19/2011 04:35 AM, Adam Litke Write:
This is looking good to me. I am pleased to see that the global case is
handled as expected when per-vcpu threads are not active.
On 07/18/2011 04:42 AM, Wen Congyang wrote:
snip
+int
On 07/19/2011 06:20 AM, Daniel P. Berrange wrote:
* docs/Makefile.am: Use $(AM_V_GEN) for API/HTML scripts
* docs/apibuild.py, python/generator.py: Exit with non-zero status
if problems are found. Also be silent, not outputting any debug
messages.
* src/Makefile.am: Use $(AM_V_GEN) for ESX
On 07/19/2011 06:23 AM, Daniel P. Berrange wrote:
Basically, virsh shouldn't make any assumptions based on the current
way things are implemented in libvirtd, since it cannot expect to be
running against a matching version. Old virsh should work against new
libvirtd, and vica-verca. This is the
Wen previously posted a report of a crash with migration. I could
not reproduce it at the time, but since then someone else did and
pointed out that it only occurs when TLS is in use
https://www.redhat.com/archives/libvir-list/2011-July/msg00547.html
This series of patches make the event handler
From: Daniel P. Berrange berra...@redhat.com
When unregistering an I/O callback from a virNetSocket object,
there is still a chance that an event may come in on the callback.
In this case it is possible that the virNetSocket might have been
freed already. Make use of a virFreeCallback when
From: Daniel P. Berrange berra...@redhat.com
Remove the need for a virNetSocket object to be protected by
locks from the object using it, by introducing its own native
locking and reference counting
* src/rpc/virnetsocket.c: Add locking reference counting
---
src/rpc/virnetsocket.c | 147
From: Daniel P. Berrange berra...@redhat.com
* src/rpc/virnetclient.c: Add debugging of ref counts
---
src/rpc/virnetclient.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c
index 9eaecfc..4a9eabc 100644
---
From: Daniel P. Berrange berra...@redhat.com
Since the I/O callback registered against virNetSocket will
hold a reference on the virNetClient, we can't rely on the
virNetClientFree to be able to close the network connection.
The last reference will only go away when the event callback
fires
On Tue, Jul 19, 2011 at 07:13:46AM -0600, Eric Blake wrote:
On 07/19/2011 06:20 AM, Daniel P. Berrange wrote:
* docs/Makefile.am: Use $(AM_V_GEN) for API/HTML scripts
* docs/apibuild.py, python/generator.py: Exit with non-zero status
if problems are found. Also be silent, not outputting any
On 07/19/2011 03:54 AM, Daniel P. Berrange wrote:
On Tue, Jul 19, 2011 at 05:34:28PM +0800, a...@redhat.com wrote:
* src/util/event_poll.c: only fix file descriptors leak on when
virEventPollAddHandle fail on virEventPollInit function.
@@ -657,6 +658,8 @@ int virEventPollInit(void)
On 07/18/2011 07:51 PM, Wen Congyang wrote:
At 07/19/2011 04:59 AM, Adam Litke Write:
On 07/18/2011 04:42 AM, Wen Congyang wrote:
+int qemuSetupCgroupForVcpu(struct qemud_driver *driver, virDomainObjPtr vm)
+{
+virCgroupPtr cgroup = NULL;
+virCgroupPtr cgroup_vcpu = NULL;
+
On 07/19/2011 07:23 AM, Daniel P. Berrange wrote:
- $(srcdir)/newapi.xsl $(srcdir)/libvirt-api.xml ; fi
- -@if test -x $(XMLLINT) test -x $(XMLCATALOG) ; then \
+ $(srcdir)/newapi.xsl $(srcdir)/libvirt-api.xml ; fi ; \
+ if test -x $(XMLLINT) test -x $(XMLCATALOG)
On 07/19/2011 07:22 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Remove the need for a virNetSocket object to be protected by
locks from the object using it, by introducing its own native
locking and reference counting
* src/rpc/virnetsocket.c: Add locking
If the libvirt daemon or libvirt client is configured with bogus
certificates, it is very unhelpful to only find out about this
when a TLS connection is actually attempted. Not least because
the error messages you get back for failures are incredibly
obscure.
This adds some basic sanity checking
Gnutls requires that certificates have basic constraints present
to be used as a CA certificate. OpenSSL doesn't add this data
by default, so add a sanity check to catch this situation. Also
validate that the key usage and key purpose constraints contain
correct data
* src/rpc/virnettlscontext.c:
[adding the libvir-list]
On 07/19/2011 08:09 AM, Jes Sorensen wrote:
On 07/19/11 15:58, Eric Blake wrote:
On 07/19/2011 07:27 AM, Jes Sorensen wrote:
Eric, what happens if libvirt in an selinux environment tells QEMU to
launch using an image file that is backed by backing file(s)?
Before
On 07/19/2011 07:22 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
* src/rpc/virnetclient.c: Add debugging of ref counts
---
src/rpc/virnetclient.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
ACK.
--
Eric Blake ebl...@redhat.com
On 07/19/2011 07:22 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
When unregistering an I/O callback from a virNetSocket object,
there is still a chance that an event may come in on the callback.
In this case it is possible that the virNetSocket might have been
freed
On 07/19/11 16:24, Eric Blake wrote:
[adding the libvir-list]
On 07/19/2011 08:09 AM, Jes Sorensen wrote:
Urgh, libvirt parsing image files is really unfortunate, it really
doesn't give me warm fuzzy feelings :( libvirt really should not know
about internals of image formats.
But even if
On 07/19/2011 07:22 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Since the I/O callback registered against virNetSocket will
hold a reference on the virNetClient, we can't rely on the
virNetClientFree to be able to close the network connection.
The last reference
On Fri, Jul 15, 2011 at 10:18:39AM -0500, Adam Litke wrote:
In light of discussion on V1 of this API, here is V2 of the next generation
BlockPull API. In this series we make the abort and info operations more
generic so that they may apply to future block jobs (such as compression,
live
On Tue, Jul 19, 2011 at 10:46:49AM -0400, Cole Robinson wrote:
Maybe we can cache the png data per detected OS value rather than per
VM? Not sure if that collides with licensing issues, but would likely
mean storing less data on disk.
You can't do that without getting into trademark issues.
Starting/ending jobs when closing the connection may reset any
error which was reported earlier in p2p migration. We must
save the original error before doing so. This means we can also
just call virConnectClose as normal, instead of virUnrefConnect
* src/qemu/qemu_migration.c: Preserve errors in
DMI is Intel Intel-compatible specific. Don't try to dump information
on non-compatible architectures, which results only in error message in
logs.
---
NB: libsmbios is exclusively for x86_64 ia64 %{ix86}
src/node_device/node_device_udev.c |5 +
1 files changed, 5 insertions(+), 0
On 07/19/2011 08:47 AM, Richard W.M. Jones wrote:
On Tue, Jul 19, 2011 at 10:46:49AM -0400, Cole Robinson wrote:
Maybe we can cache the png data per detected OS value rather than per
VM? Not sure if that collides with licensing issues, but would likely
mean storing less data on disk.
You
On 07/19/2011 08:52 AM, Daniel P. Berrange wrote:
Starting/ending jobs when closing the connection may reset any
error which was reported earlier in p2p migration. We must
save the original error before doing so. This means we can also
just call virConnectClose as normal, instead of
On Thu, Jul 14, 2011 at 11:32:15AM +0800, Lai Jiangshan wrote:
From: Daniel P. Berrange berra...@redhat.com
Should keep it as the same as:
http://git.gnome.org/browse/gtk-vnc/commit/src/keymaps.csv
All master keymaps are defined in a CSV file. THis covers
Linux keycodes, OSX keycodes, AT
On 07/19/2011 08:52 AM, Michal Privoznik wrote:
DMI is Intel Intel-compatible specific. Don't try to dump information
on non-compatible architectures, which results only in error message in
logs.
---
NB: libsmbios is exclusively for x86_64 ia64 %{ix86}
src/node_device/node_device_udev.c |
On Thu, Jul 14, 2011 at 11:32:17AM +0800, Lai Jiangshan wrote:
Also support string names for the linux keycode(auto detect).
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
Acked-by: Daniel P. Berrange berra...@redhat.com
---
tools/virsh.c | 94
On Thu, Jul 14, 2011 at 11:32:16AM +0800, Lai Jiangshan wrote:
Add virtkey lib for usage-improvment and keycode translating.
Add 4 internal API for the aim
const char *virKeycodeSetTypeToString(int codeset);
int virKeycodeSetTypeFromString(const char *name);
int
On Thu, Jul 14, 2011 at 11:32:18AM +0800, Lai Jiangshan wrote:
qemu driver just accept xt_kbd codeset's keycode, so the lib virtkey
is used for translating keycodes from other codesets.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
src/qemu/qemu_driver.c | 71
On Tue, Jul 19, 2011 at 08:54:59AM -0600, Eric Blake wrote:
On 07/19/2011 08:47 AM, Richard W.M. Jones wrote:
On Tue, Jul 19, 2011 at 10:46:49AM -0400, Cole Robinson wrote:
Maybe we can cache the png data per detected OS value rather than per
VM? Not sure if that collides with licensing
On 19.07.2011 17:01, Eric Blake wrote:
On 07/19/2011 08:52 AM, Michal Privoznik wrote:
DMI is Intel Intel-compatible specific. Don't try to dump information
on non-compatible architectures, which results only in error message in
logs.
---
NB: libsmbios is exclusively for x86_64 ia64 %{ix86}
On Tue, Jul 19, 2011 at 3:30 PM, Jes Sorensen jes.soren...@redhat.com wrote:
On 07/19/11 16:24, Eric Blake wrote:
[adding the libvir-list]
On 07/19/2011 08:09 AM, Jes Sorensen wrote:
Urgh, libvirt parsing image files is really unfortunate, it really
doesn't give me warm fuzzy feelings :(
On 07/19/2011 09:12 AM, Michal Privoznik wrote:
On 19.07.2011 17:01, Eric Blake wrote:
On 07/19/2011 08:52 AM, Michal Privoznik wrote:
DMI is Intel Intel-compatible specific. Don't try to dump information
on non-compatible architectures, which results only in error message in
logs.
---
NB:
---
src/remote/remote_driver.c |3 ++-
src/remote/remote_protocol.x |9 -
src/remote_protocol-structs |5 +
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index c2f8bbd..db60089 100644
---
* src/libxl/libxl_driver.c: New callback for libxl_driver,
new function libxlDomainUndefineFlags, and changes libxlDomainUndefine
as a wrapper of libxlDomainUndefineFlags.
---
src/libxl/libxl_driver.c | 33 -
1 files changed, 32 insertions(+), 1 deletions(-)
This introduces a new API virDomainUndefineFlags to control the
domain undefine process, as the existing API virDomainUndefine
doesn't support flags.
Currently only flag VIR_DOMAIN_UNDEFINE_MANAGED_SAVE is supported.
If the domain has a managed save image, including
---
src/esx/esx_driver.c | 11 ++-
src/lxc/lxc_driver.c | 11 ++-
src/openvz/openvz_driver.c | 11 ++-
src/test/test_driver.c | 12 +++-
src/uml/uml_driver.c | 12 +++-
src/vmware/vmware_driver.c | 12 +++-
* src/qemu/qemu_driver.c: New call back for qemu_driver,
New function qemudDomainUndefineFlags, and changes on
qemudDomainUndefine.
---
src/qemu/qemu_driver.c | 36 +++-
1 files changed, 35 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_driver.c
If the domain has managed save image, and --managed-save is
not specified, then it fails with an error telling the user
that a managed save image still exists.
If the domain has managed save image, and --managed-save is
specified, it invokes virDomainUndefineFlags. If
virDomainUndefineFlags
On 07/19/2011 09:57 AM, Osier Yang wrote:
This introduces a new API virDomainUndefineFlags to control the
domain undefine process, as the existing API virDomainUndefine
doesn't support flags.
Currently only flag VIR_DOMAIN_UNDEFINE_MANAGED_SAVE is supported.
If the domain has a managed save
On 07/19/2011 09:57 AM, Osier Yang wrote:
---
src/remote/remote_driver.c |3 ++-
src/remote/remote_protocol.x |9 -
src/remote_protocol-structs |5 +
3 files changed, 15 insertions(+), 2 deletions(-)
ACK.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
On 07/19/2011 09:57 AM, Osier Yang wrote:
* src/qemu/qemu_driver.c: New call back for qemu_driver,
New function qemudDomainUndefineFlags, and changes on
qemudDomainUndefine.
---
src/qemu/qemu_driver.c | 36 +++-
1 files changed, 35 insertions(+), 1
On Thu, Jun 30, 2011 at 11:56:15AM -0600, Eric Blake wrote:
[adding libvirt]
On 06/04/2011 12:24 AM, Paolo Bonzini wrote:
On Sat, Jun 4, 2011 at 00:37, Matthias Bolte
matthias.bo...@googlemail.com wrote:
After testing a while and reading MSDN docs the problem seems to be
that
On 07/19/2011 09:30 AM, Daniel P. Berrange wrote:
I'm wondering if the problem here is that libvirt is trying to use the
pipe-to-self mechanism as a fundamental event loop idiom. That is, the
reason libvirt is calling poll is in order to minimize CPU until
something interesting happens, where
On Tue, Jul 19, 2011 at 08:36:33AM -0600, Eric Blake wrote:
On 07/19/2011 07:22 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Since the I/O callback registered against virNetSocket will
hold a reference on the virNetClient, we can't rely on the
virNetClientFree
On Tue, Jul 19, 2011 at 08:40:50AM -0600, Eric Blake wrote:
On 07/19/2011 07:55 AM, Daniel P. Berrange wrote:
If the libvirt daemon or libvirt client is configured with bogus
certificates, it is very unhelpful to only find out about this
when a TLS connection is actually attempted. Not least
On 07/19/2011 09:57 AM, Osier Yang wrote:
* src/libxl/libxl_driver.c: New callback for libxl_driver,
new function libxlDomainUndefineFlags, and changes libxlDomainUndefine
as a wrapper of libxlDomainUndefineFlags.
---
src/libxl/libxl_driver.c | 33 -
1 files
On 07/19/2011 09:57 AM, Osier Yang wrote:
---
src/esx/esx_driver.c | 11 ++-
src/lxc/lxc_driver.c | 11 ++-
src/openvz/openvz_driver.c | 11 ++-
src/test/test_driver.c | 12 +++-
src/uml/uml_driver.c | 12 +++-
On Tue, Jul 19, 2011 at 09:31:59AM -0600, Eric Blake wrote:
On 07/19/2011 09:30 AM, Daniel P. Berrange wrote:
I'm wondering if the problem here is that libvirt is trying to use the
pipe-to-self mechanism as a fundamental event loop idiom. That is, the
reason libvirt is calling poll is in
On 07/19/2011 09:57 AM, Osier Yang wrote:
If the domain has managed save image, and --managed-save is
not specified, then it fails with an error telling the user
that a managed save image still exists.
If the domain has managed save image, and --managed-save is
specified, it invokes
On Thu, Jul 14, 2011 at 08:34:46AM -0600, Eric Blake wrote:
On 07/14/2011 08:24 AM, Eric Blake wrote:
O_DIRECT has stringent requirements - I/O must occur with buffers
that have both alignment and size as multiples of the file system
block size (used to be 512 bytes, but these days, 4k is
On 07/19/2011 10:06 AM, Daniel P. Berrange wrote:
The motivation for using O_DIRECT is that allowing pollution of the
host cache causes stability problems for the host as a whole. As
such IMHO, apps would likely want an error back if O_DIRECT cannot
be supported,
NB, even some Linux
On Thu, Jul 14, 2011 at 08:24:28AM -0600, Eric Blake wrote:
In order to choose whether to use O_DIRECT when saving a domain image
to a file, we need a new flag. But virDomainSave was implemented
before our policy of all new APIs having a flag argument.
* include/libvirt/libvirt.h.in
On Thu, Jul 14, 2011 at 08:24:29AM -0600, Eric Blake wrote:
* src/remote/remote_driver.c (remote_driver): Add new callback.
* src/remote/remote_protocol.x (remote_procedure): New RPC.
(remote_domain_save_flags_args): New struct.
* src/remote_protocol-structs: Update.
---
On Thu, Jul 14, 2011 at 08:24:30AM -0600, Eric Blake wrote:
For all hypervisors that support save, the new API now performs
the same functions as the old.
* src/libxl/libxl_driver.c (libxlDomainSave): Move guts...
(libxlDomainSaveFlags): ...to new function.
* src/test/test_driver.c
Hi,
Some people appear to have autostart VMs residing on slow storage. If
libvirtd starts too early, it'll simply fail trying to start those VMs.
It'd be nice to know when all the storage on which autostart containers
depend becomes available, so as to safely start libvirt.
The python script
On 07/19/2011 09:30 AM, Jes Sorensen wrote:
On 07/19/11 16:24, Eric Blake wrote:
[adding the libvir-list]
On 07/19/2011 08:09 AM, Jes Sorensen wrote:
Urgh, libvirt parsing image files is really unfortunate, it really
doesn't give me warm fuzzy feelings :( libvirt really should not know
about
On Thu, Jul 14, 2011 at 08:24:31AM -0600, Eric Blake wrote:
Wire up the new flag to virsh. Also, the 'dump' command had
undocumented flags.
* tools/virsh.c (cmdSave, cmdManagedSave, cmdDump): Add new flag.
* tools/virsh.pod (save, managedsave, dump): Document flags.
---
tools/virsh.c |
On 07/19/2011 10:10 AM, Daniel P. Berrange wrote:
On Thu, Jul 14, 2011 at 08:24:28AM -0600, Eric Blake wrote:
In order to choose whether to use O_DIRECT when saving a domain image
to a file, we need a new flag. But virDomainSave was implemented
before our policy of all new APIs having a flag
On Thu, Jul 14, 2011 at 08:24:32AM -0600, Eric Blake wrote:
Rather than making the iohelper subject to a race in reopening
the file, it is nicer to pass an already-open fd by inheritance.
The old synopsis form must continue to work - if someone updates
their libvirt package and installs a
On Thu, Jul 14, 2011 at 08:24:33AM -0600, Eric Blake wrote:
Required for a coming patch where iohelper will operate on O_DIRECT
fds. There, the user-space memory must be aligned to file system
boundaries (at least page-aligned works best, and some file systems
prefer 64k). Made tougher by
On Tue, Jul 19, 2011 at 10:08:21AM -0600, Eric Blake wrote:
On 07/19/2011 10:06 AM, Daniel P. Berrange wrote:
The motivation for using O_DIRECT is that allowing pollution of the
host cache causes stability problems for the host as a whole. As
such IMHO, apps would likely want an error back
On Tue, Jul 19, 2011 at 04:14:27PM +0100, Stefan Hajnoczi wrote:
On Tue, Jul 19, 2011 at 3:30 PM, Jes Sorensen jes.soren...@redhat.com wrote:
On 07/19/11 16:24, Eric Blake wrote:
[adding the libvir-list]
On 07/19/2011 08:09 AM, Jes Sorensen wrote:
Urgh, libvirt parsing image files is
On Tue, Jul 19, 2011 at 04:30:19PM +0200, Jes Sorensen wrote:
On 07/19/11 16:24, Eric Blake wrote:
[adding the libvir-list]
On 07/19/2011 08:09 AM, Jes Sorensen wrote:
Urgh, libvirt parsing image files is really unfortunate, it really
doesn't give me warm fuzzy feelings :( libvirt really
I have some code if you want that work. If you could test, I wil lsend
you. I have no time to create m4 and proper gnulib integration. It is
up to you
Bastien
On Tue, Jul 19, 2011 at 5:44 PM, Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Jul 19, 2011 at 09:31:59AM -0600, Eric Blake
n Tue, Jul 19, 2011 at 6:54 PM, Bastien ROUCARIES
roucaries.bast...@gmail.com wrote:
I have some code if you want that work. If you could test, I wil lsend
you. I have no time to create m4 and proper gnulib integration. It is
up to you
Please test, I do not even have compiled it.
Bastien
On Thu, Jul 14, 2011 at 08:24:34AM -0600, Eric Blake wrote:
O_DIRECT has stringent requirements - I/O must occur with buffers
that have both alignment and size as multiples of the file system
block size (used to be 512 bytes, but these days, 4k is safer, and
64k allows for better throughput).
On 07/19/2011 11:45 AM, Daniel P. Berrange wrote:
On Thu, Jul 14, 2011 at 08:24:34AM -0600, Eric Blake wrote:
O_DIRECT has stringent requirements - I/O must occur with buffers
that have both alignment and size as multiples of the file system
block size (used to be 512 bytes, but these days, 4k
On Fri, Jul 15, 2011 at 08:05:02PM -0600, Eric Blake wrote:
For all hypervisors that support restore, the new API now performs
the same functions as the old.
* src/libxl/libxl_driver.c (libxlDomainRestore): Move guts...
(libxlDomainRestoreFlags): ...to new function.
* src/qemu/qemu_driver.c
On Thu, Jul 14, 2011 at 07:02:23PM -0600, Eric Blake wrote:
* include/libvirt/libvirt.h.in (virDomainCreateFlags): Add a flag.
(virDomainRestoreFlags): New prototype.
* src/libvirt.c (virDomainRestoreFlags): New function.
* src/libvirt_public.syms: Export it.
* src/driver.h
On Fri, Jul 15, 2011 at 08:42:44PM -0600, Eric Blake wrote:
* tools/virsh.c (cmdStart, cmdRestore): Add new flag.
* tools/virsh.pod (start, restore): Document flags.
---
Counterpart to 4/8
tools/virsh.c |9 -
tools/virsh.pod | 10 --
2 files changed, 16
On Thu, Jul 14, 2011 at 07:03:46PM -0600, Eric Blake wrote:
* src/remote/remote_driver.c (remote_driver): Add new callback.
* src/remote/remote_protocol.x (remote_procdure): New RPC.
(remote_domain_restore_flags_args): New struct.
* src/remote_protocol-structs: Update.
---
Again, I'm
On Fri, Jul 15, 2011 at 08:48:18PM -0600, Eric Blake wrote:
Constraining the problem makes the solution easier to think about.
* src/util/iohelper.c (runIO): Make read support easy.
---
Could be squashed into 6/8.
src/util/iohelper.c |9 -
1 files changed, 8 insertions(+),
On Sat, Jul 16, 2011 at 05:09:06PM -0600, Eric Blake wrote:
Wire up the restore direction to use iohelper for O_DIRECT.
* src/qemu/qemu_driver.c (qemuddDomainObjStart)
(qemuDomainSaveImageOpen, qemuDomainObjRestore)
(qemuDomainObjStart): Add parameter.
(qemudDomainStartWithFlags,
On Mon, Jul 18, 2011 at 09:45:34AM -0600, Eric Blake wrote:
When auto-starting a domain on libvirtd startup, let the user
configure whether to have the VIR_DOMAIN_START_DIRECT flag effect.
* src/qemu/qemu.conf (auto_start_direct): Document new variable.
* src/qemu/libvirtd_qemu.aug
New optional parameter keyfile for ssh transport allows the user to select
the private key to be used to authenticate to the remote host.
---
docs/remote.html.in| 16
src/remote/remote_driver.c |9 -
src/rpc/virnetclient.c |4 +++-
1 - 100 of 135 matches
Mail list logo
