[libvirt] [libvirt-test-API][PATCH 2/2] Add four helpful functions in utils.py.

2011-07-27 Thread Guannan Ren
* get_local_hostname() get hostname on local machine * exec_cmd() execute shell command * remote_exec_pexpect() execture command on remote host * scp_file() copy file to remote host --- utils/Python/utils.py | 69 + 1 files

[libvirt] [libvirt-test-API][PATCH 1/2] add remoteAccess directory and tls authentication testcase

2011-07-27 Thread Guannan Ren
--- repos/remoteAccess/tls_setup.py | 374 +++ 1 files changed, 374 insertions(+), 0 deletions(-) create mode 100644 repos/remoteAccess/__init__.py create mode 100644 repos/remoteAccess/tls_setup.py diff --git a/repos/remoteAccess/__init__.py

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-27 Thread Laine Stump
On 07/26/2011 07:10 PM, Eric Blake wrote: On 07/26/2011 08:50 AM, Laine Stump wrote: I think it is a somewhat overkill to have 'autoport' be a setting per-listen element. I can't imagine people want a fixed port number on one IP addr, but a dynamic port number on another IP addr. So we could

Re: [libvirt] [libvirt-test-API][PATCH 1/2] add remoteAccess directory and tls authentication testcase

2011-07-27 Thread Osier Yang
? 2011?07?27? 14:58, Guannan Ren ??: --- repos/remoteAccess/tls_setup.py | 374 +++ 1 files changed, 374 insertions(+), 0 deletions(-) create mode 100644 repos/remoteAccess/__init__.py create mode 100644 repos/remoteAccess/tls_setup.py diff --git

Re: [libvirt] [PATCH ] send-key: Implement Python API

2011-07-27 Thread Wen Congyang
At 07/26/2011 06:26 PM, Daniel P. Berrange Write: On Thu, Jul 21, 2011 at 05:21:10PM +0800, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/python/libvirt-override.c b/python/libvirt-override.c index b713b6a..1ef5bfa 100644 ---

Re: [libvirt] [libvirt-test-API][PATCH 2/2] Add four helpful functions in utils.py.

2011-07-27 Thread Guannan Sun
ACK Thanks! Best Regards! Wayne Sun Redhat QE, Beijing, China +86-10-6260-8238 - Original Message - From: Guannan Ren g...@redhat.com To: libvir-list@redhat.com Sent: Wednesday, July 27, 2011 2:58:33 PM Subject: [libvirt] [libvirt-test-API][PATCH 2/2] Add four helpful functions in

[libvirt] Fix for newer yajl

2011-07-27 Thread Brecht Sanders
Hi, I just notices that compiling libvirt against yail version 2 there were some errors, mainly because yajl_parser_config is no longer used. The patch below fixed this for me. Regards Brecht Sanders --- src/util/json.c 2011-03-24 08:10:26 +0100 +++ src/util/json.c 2011-07-27 09:29:52

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-27 Thread Laine Stump
On 07/26/2011 08:09 PM, Eric Blake wrote: On 07/25/2011 03:00 AM, Laine Stump wrote: Once it's plugged in, thelisten element will be an optional replacement for the listen, port, tlsPort, and autoport attributes that graphics elements already have. If thelisten type='address', it will have an

Re: [libvirt] Fix for newer yajl

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 09:40:47AM +0200, Brecht Sanders wrote: Hi, I just notices that compiling libvirt against yail version 2 there were some errors, mainly because yajl_parser_config is no longer used. What version of libvirt is your patch against ? The latest releases already have fixed

Re: [libvirt] [PATCH] build: support warnings on RHEL 5

2011-07-27 Thread Daniel P. Berrange
On Tue, Jul 26, 2011 at 02:25:40PM -0600, Eric Blake wrote: Without this, a configure built by autoconf 2.59 was broken when trying to detect which compiler warning flags were supported. * .gnulib: Update to latest, for warnings.m4 fix. * src/qemu/qemu_conf.c (includes): Drop unused include.

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Kevin Wolf
Am 26.07.2011 18:57, schrieb Corey Bryant: Kevin, thanks for the input. On 07/26/2011 11:18 AM, Kevin Wolf wrote: Am 26.07.2011 14:51, schrieb Corey Bryant: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: Am 26.07.2011 18:57, schrieb Corey Bryant: diff --git a/block/cow.c b/block/cow.c index 4cf543c..e17f8e7 100644 --- a/block/cow.c +++ b/block/cow.c @@ -82,6 +82,11 @@ static int cow_open(BlockDriverState *bs, int flags)

Re: [libvirt] Fix for newer yajl

2011-07-27 Thread Brecht Sanders
Hi, I just notices that compiling libvirt against yail version 2 there were some errors, mainly because yajl_parser_config is no longer used. What version of libvirt is your patch against ? The latest releases already have fixed compatibility with YAJL 2, so I'm assuming you have an old

Re: [libvirt] [PATCH] bandwidth: Integrate bandwidth into portgroups

2011-07-27 Thread Michal Privoznik
On 26.07.2011 20:04, Laine Stump wrote: diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 031862a..f99294c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8867,8 +8867,7 @@ virDomainNetDefFormat(virBufferPtr buf, virBufferAddLit(buf, /tune\n);

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Kevin Wolf
Am 27.07.2011 10:22, schrieb Daniel P. Berrange: On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: Am 26.07.2011 18:57, schrieb Corey Bryant: diff --git a/block/cow.c b/block/cow.c index 4cf543c..e17f8e7 100644 --- a/block/cow.c +++ b/block/cow.c @@ -82,6 +82,11 @@ static int

[libvirt] libvirt-0.9.1 to 0.9.3-r1: managedsave/save won't start/restore at saved state

2011-07-27 Thread Nicolas Sebrecht
I'm seeing strange behaviour, here. Any guests saved using both managedsave and save commands from virsh won't restore at saved state. A new full boot sequence happen. - Tested against libvirt v0.9.1, v0.9.2, v0.9.3-r1 (Gentoo) - Confirmed on three different hosts Gentoo amd64 systems. - Tested

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 10:36:25AM +0200, Kevin Wolf wrote: Am 27.07.2011 10:22, schrieb Daniel P. Berrange: On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: Am 26.07.2011 18:57, schrieb Corey Bryant: diff --git a/block/cow.c b/block/cow.c index 4cf543c..e17f8e7 100644 ---

[libvirt] [libvirt-test-API][PATCH V2] add remoteAccess directory and tls authentication testcase

2011-07-27 Thread Guannan Ren
--- repos/remoteAccess/tls_setup.py | 386 +++ 1 files changed, 386 insertions(+), 0 deletions(-) create mode 100644 repos/remoteAccess/__init__.py create mode 100644 repos/remoteAccess/tls_setup.py diff --git a/repos/remoteAccess/__init__.py

[libvirt] [PATCH] daemon: Unlink unix sockets at daemon shutdown

2011-07-27 Thread Osier Yang
--- daemon/libvirtd.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 9e044e2..61f5a2d 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -1572,6 +1572,12 @@ cleanup: if (pid_file) unlink (pid_file);

Re: [libvirt] [PATCH] daemon: Unlink unix sockets at daemon shutdown

2011-07-27 Thread Osier Yang
于 2011年07月27日 18:07, Osier Yang 写道: --- daemon/libvirtd.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 9e044e2..61f5a2d 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -1572,6 +1572,12 @@ cleanup:

Re: [libvirt] [PATCH] daemon: Unlink unix sockets at daemon shutdown

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 05:34:19PM +0800, Osier Yang wrote: 于 2011年07月27日 18:07, Osier Yang 写道: --- daemon/libvirtd.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 9e044e2..61f5a2d 100644 ---

Re: [libvirt] Fix for newer yajl

2011-07-27 Thread Brecht Sanders
On 27/07/2011 10:24, Brecht Sanders wrote: Hi, I just notices that compiling libvirt against yail version 2 there were some errors, mainly because yajl_parser_config is no longer used. What version of libvirt is your patch against ? The latest releases already have fixed compatibility with

Re: [libvirt] [PATCH] daemon: Unlink unix sockets at daemon shutdown

2011-07-27 Thread Osier Yang
于 2011年07月27日 17:51, Daniel P. Berrange 写道: On Wed, Jul 27, 2011 at 05:34:19PM +0800, Osier Yang wrote: 于 2011年07月27日 18:07, Osier Yang 写道: --- daemon/libvirtd.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index

Re: [libvirt] RFC: API additions for enhanced snapshot support

2011-07-27 Thread Stefan Hajnoczi
On Thu, Jun 16, 2011 at 6:41 AM, Eric Blake ebl...@redhat.com wrote: Right now, libvirt has a snapshot API via virDomainSnapshotCreateXML, but for qemu domains, it only works if all the guest disk images are qcow2, and qemu rather than libvirt does all the work.  However, it has a couple of

[libvirt] [v2] qemu: Improve docs for virsh dump format

2011-07-27 Thread Osier Yang
The error in getCompressionType will never be reported, change the errors codes into warning (VIR_WARN(%s, _(foo)); doesn't break syntax-check rule), and also improve the docs in qemu.conf to tell user the truth. --- src/qemu/qemu.conf | 10 -- src/qemu/qemu_driver.c | 15

Re: [libvirt] [libvirt-test-API][PATCH V2] add remoteAccess directory and tls authentication testcase

2011-07-27 Thread Guannan Sun
ACK Thanks! Best Regards! Wayne Sun Redhat QE, Beijing, China +86-10-6260-8238 - Original Message - From: Guannan Ren g...@redhat.com To: libvir-list@redhat.com Sent: Wednesday, July 27, 2011 5:31:10 PM Subject: [libvirt] [libvirt-test-API][PATCH V2] add remoteAccess directory and

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Corey Bryant
On 07/27/2011 04:43 AM, Daniel P. Berrange wrote: On Wed, Jul 27, 2011 at 10:36:25AM +0200, Kevin Wolf wrote: Am 27.07.2011 10:22, schrieb Daniel P. Berrange: On Wed, Jul 27, 2011 at 10:11:06AM +0200, Kevin Wolf wrote: Am 26.07.2011 18:57, schrieb Corey Bryant: diff --git a/block/cow.c

Re: [libvirt] [PATCH 00/10] Rollback migration when libvirtd restarts

2011-07-27 Thread Daniel P. Berrange
On Tue, Jul 19, 2011 at 02:27:29AM +0200, Jiri Denemark wrote: This is the rest of the original 19 patch series updated with some bugfixes and rebased on current master, which is also available at https://gitorious.org/~jirka/libvirt/jirka-staging/commits/migration-recovery I didn't manage

[libvirt] Memory leak of the remoteDomainSet* functions

2011-07-27 Thread Osier Yang
Hello, there Per bug https://bugzilla.redhat.com/show_bug.cgi?id=725322, should we change the remoteDomainSet* functions into skipgen, and fix the leaks like below? (NB, new VIR_FREE statements) static int remoteDomainSetBlkioParameters(virDomainPtr dom, virTypedParameterPtr params, int nparams,

Re: [libvirt] RFC: API additions for enhanced snapshot support

2011-07-27 Thread Eric Blake
On 07/27/2011 04:04 AM, Stefan Hajnoczi wrote: On Thu, Jun 16, 2011 at 6:41 AM, Eric Blakeebl...@redhat.com wrote: Right now, libvirt has a snapshot API via virDomainSnapshotCreateXML, but for qemu domains, it only works if all the guest disk images are qcow2, and qemu rather than libvirt does

Re: [libvirt] [PATCH] build: support warnings on RHEL 5

2011-07-27 Thread Eric Blake
On 07/27/2011 02:03 AM, Daniel P. Berrange wrote: On Tue, Jul 26, 2011 at 02:25:40PM -0600, Eric Blake wrote: Without this, a configure built by autoconf 2.59 was broken when trying to detect which compiler warning flags were supported. * .gnulib: Update to latest, for warnings.m4 fix. *

Re: [libvirt] Memory leak of the remoteDomainSet* functions

2011-07-27 Thread Matthias Bolte
2011/7/27 Osier Yang jy...@redhat.com: Hello, there Per bug https://bugzilla.redhat.com/show_bug.cgi?id=725322, should we change the remoteDomainSet* functions into skipgen, and fix the leaks like below? (NB, new VIR_FREE statements) Why not fix the generator instead? static int

[libvirt] FW: Error configuring my Virtual machine network

2011-07-27 Thread Matthew Omogbai Ehiwere
I am a newbie to linux and was given a task to fine out what could be wrong with the configuration of the software we are working on. The error displayed on my screen is as capture below.Can you help me out. ncftool define netmask.xml xmlXPathCompiledEval: evaluation failed error: XSLT

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Kevin Wolf
Am 27.07.2011 15:09, schrieb Corey Bryant: Kevin/Daniel, thanks a lot for your input. In terms of the support that libvirt requires, I just want to make sure all bases are covered. In order for this support to be useful to libvirt, the following are required (sorry if this is

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-27 Thread Laine Stump
On 07/27/2011 02:41 AM, Laine Stump wrote: On 07/26/2011 07:10 PM, Eric Blake wrote: On 07/26/2011 08:50 AM, Laine Stump wrote: I think it is a somewhat overkill to have 'autoport' be a setting per-listen element. I can't imagine people want a fixed port number on one IP addr, but a dynamic

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 11:20:42AM -0400, Laine Stump wrote: On 07/27/2011 02:41 AM, Laine Stump wrote: On 07/26/2011 07:10 PM, Eric Blake wrote: On 07/26/2011 08:50 AM, Laine Stump wrote: I think it is a somewhat overkill to have 'autoport' be a setting per-listen element. I can't imagine

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-27 Thread Eric Blake
On 07/27/2011 01:47 AM, Laine Stump wrote: I'm not sure this is right. I think we want to require either type=address (which implies address=nnn must also be present, and network=nnn must not be present) or type=network (which implies that network=nnn must be present, and address=nnn might show

Re: [libvirt] [PATCHv3 1/2] conf: add listen subelement to domain graphics element

2011-07-27 Thread Daniel P. Berrange
On Wed, Jul 27, 2011 at 04:37:13PM +0100, Daniel P. Berrange wrote: On Wed, Jul 27, 2011 at 11:20:42AM -0400, Laine Stump wrote: One further thought, is should we even store 'port' on the listen element. I know technically this lets you configure different port numbers for different

Re: [libvirt] [PATCHv3 2/2] qemu: support type=network in domain graphics listen

2011-07-27 Thread Eric Blake
On 07/25/2011 03:00 AM, Laine Stump wrote: The domain XML now understands thelisten subelement of its graphics element (including when listen type='network'), and the network driver has an internal API that will turn a network name into an IP address, so the final logical step is to put the

Re: [libvirt] [PATCH 00/10] Rollback migration when libvirtd restarts

2011-07-27 Thread Eric Blake
On 07/27/2011 07:29 AM, Daniel P. Berrange wrote: On Tue, Jul 19, 2011 at 02:27:29AM +0200, Jiri Denemark wrote: This is the rest of the original 19 patch series updated with some bugfixes and rebased on current master, which is also available at

[libvirt] [PATCH] virsh: expose change-protection during migration

2011-07-27 Thread Eric Blake
* tools/virsh.c (doMigrate): Add --change-protection flag. * tools/virsh.pod (migrate): Document it. --- As promised here: https://www.redhat.com/archives/libvir-list/2011-July/msg01919.html tools/virsh.c |4 tools/virsh.pod |9 +++-- 2 files changed, 11 insertions(+), 2

Re: [libvirt] [v2] qemu: Improve docs for virsh dump format

2011-07-27 Thread Eric Blake
On 07/27/2011 04:58 AM, Osier Yang wrote: The error in getCompressionType will never be reported, change the errors codes into warning (VIR_WARN(%s, _(foo)); doesn't break syntax-check rule), and also improve the docs in qemu.conf to tell user the truth. --- src/qemu/qemu.conf | 10

Re: [libvirt] libvirt-0.9.1 to 0.9.3-r1: managedsave/save won't start/restore at saved state

2011-07-27 Thread Eric Blake
On 07/27/2011 02:37 AM, Nicolas Sebrecht wrote: I'm seeing strange behaviour, here. Any guests saved using both managedsave and save commands from virsh won't restore at saved state. A new full boot sequence happen. - Tested against libvirt v0.9.1, v0.9.2, v0.9.3-r1 (Gentoo) - Confirmed on

Re: [libvirt] [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

2011-07-27 Thread Cole Robinson
On 07/27/2011 12:28 PM, Whit Blauvelt wrote: Looks like my real problem may be not incorporating a Debian/Ubuntu patch before building 0.9.x, since netcat differs: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/517478 Hmm, what was the error message you were getting? We've made

Re: [libvirt] [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

2011-07-27 Thread Eric Blake
[adding libvir-list] On 07/27/2011 10:28 AM, Whit Blauvelt wrote: Looks like my real problem may be not incorporating a Debian/Ubuntu patch before building 0.9.x, since netcat differs: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/517478 Reading that bug report, it looks like

Re: [libvirt] [PATCH ] send-key: Implement Python API

2011-07-27 Thread Eric Blake
On 07/26/2011 04:26 AM, Daniel P. Berrange wrote: On Thu, Jul 21, 2011 at 05:21:10PM +0800, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshanla...@cn.fujitsu.com ACK Pushed. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org --

[libvirt] Add support for image write mode in virtualbox driver

2011-07-27 Thread Boris FELD
Hi everyone, We currently using libvirt for PYTI GSOC Project (it works very well!) and we encounter a problem. We use VM with two disk images, one which must to be snapshoted/rollbacked and the other one which must be not. We use VirtualBox as hypervisor and to do so, VirtualBox define Special

[libvirt] Environmental Variables inside a container

2011-07-27 Thread Devendra K. Modium
Hi All I am trying to pass an environmental flag to the LXC container when it is started.I found libvirt_lxc is already doing it in lxc_container.c as shown below static virCommandPtr lxcContainerBuildInitCmd(virDomainDefPtr vmDef) { char uuidstr[VIR_UUID_STRING_BUFLEN]; virCommandPtr

Re: [libvirt] Environmental Variables inside a container

2011-07-27 Thread Eric Blake
On 07/27/2011 12:44 PM, Devendra K. Modium wrote: Hi All I am trying to pass an environmental flag to the LXC container when it is started.I found libvirt_lxc is already doing it in lxc_container.c as shown below static virCommandPtr lxcContainerBuildInitCmd(virDomainDefPtr vmDef) {

[libvirt] [PATCH] rpc: Fix memory leak in remoteDomainSet*Parameters functions

2011-07-27 Thread Matthias Bolte
Add a new helper remoteFreeTypedParameters and teach the generator to add it to the cleanup section. https://bugzilla.redhat.com/show_bug.cgi?id=725322 --- src/remote/remote_driver.c | 22 +- src/rpc/gendispatch.pl |5 + 2 files changed, 22 insertions(+), 5

Re: [libvirt] Memory leak of the remoteDomainSet* functions

2011-07-27 Thread Matthias Bolte
2011/7/27 Matthias Bolte matthias.bo...@googlemail.com: 2011/7/27 Osier Yang jy...@redhat.com: Hello, there Per bug https://bugzilla.redhat.com/show_bug.cgi?id=725322, should we change the remoteDomainSet* functions into skipgen, and fix the leaks like below? (NB, new VIR_FREE statements)

Re: [libvirt] [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

2011-07-27 Thread Guido Günther
On Wed, Jul 27, 2011 at 10:53:01AM -0600, Eric Blake wrote: [adding libvir-list] On 07/27/2011 10:28 AM, Whit Blauvelt wrote: Looks like my real problem may be not incorporating a Debian/Ubuntu patch before building 0.9.x, since netcat differs:

Re: [libvirt] [PATCH] rpc: Fix memory leak in remoteDomainSet*Parameters functions

2011-07-27 Thread Eric Blake
On 07/27/2011 01:18 PM, Matthias Bolte wrote: Add a new helper remoteFreeTypedParameters and teach the generator to add it to the cleanup section. https://bugzilla.redhat.com/show_bug.cgi?id=725322 --- src/remote/remote_driver.c | 22 +- src/rpc/gendispatch.pl |

Re: [libvirt] Environmental Variables inside a container

2011-07-27 Thread Devendra K. Modium
Hi Eric Thanks for the reply. I am trying to run standard Ubuntu lxc file System(lxc-ubuntu) and /sbin/init of Ubuntu is the root process of lxc process tree. I believe most of the lxc containers start with /sbin/init as first process. Since I didn't exactly find the code of /sbin/init, I

Re: [libvirt] [PATCH] rpc: Fix memory leak in remoteDomainSet*Parameters functions

2011-07-27 Thread Matthias Bolte
2011/7/27 Eric Blake ebl...@redhat.com: On 07/27/2011 01:18 PM, Matthias Bolte wrote: Add a new helper remoteFreeTypedParameters and teach the generator to add it to the cleanup section. https://bugzilla.redhat.com/show_bug.cgi?id=725322 ---  src/remote/remote_driver.c |   22

Re: [libvirt] [PATCH] virsh: expose change-protection during migration

2011-07-27 Thread Matthias Bolte
2011/7/27 Eric Blake ebl...@redhat.com: * tools/virsh.c (doMigrate): Add --change-protection flag. * tools/virsh.pod (migrate): Document it. --- As promised here: https://www.redhat.com/archives/libvir-list/2011-July/msg01919.html ACK. -- Matthias Bolte http://photron.blogspot.com --

[libvirt] virNetClientPtr leak in remote driver

2011-07-27 Thread Matthias Bolte
doRemoteClose doesn't free the virNetClientPtr and this creates a 260kb leak per remote connection. This happens because virNetClientFree doesn't remove the last ref, because virNetClientNew creates the virNetClientPtr with a refcount of 2. static virNetClientPtr virNetClientNew(virNetSocketPtr

Re: [libvirt] [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

2011-07-27 Thread Eric Blake
On 07/27/2011 01:32 PM, Guido Günther wrote: On Wed, Jul 27, 2011 at 10:53:01AM -0600, Eric Blake wrote: [adding libvir-list] On 07/27/2011 10:28 AM, Whit Blauvelt wrote: Looks like my real problem may be not incorporating a Debian/Ubuntu patch before building 0.9.x, since netcat differs:

Re: [libvirt] [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

2011-07-27 Thread Whit Blauvelt
On Wed, Jul 27, 2011 at 09:32:09PM +0200, Guido Günther wrote: This is the patch we're currently using in Debian for that (based on a version originally forwarded from Ubuntu):

Re: [libvirt] [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

2011-07-27 Thread Whit Blauvelt
On Wed, Jul 27, 2011 at 12:46:02PM -0400, Cole Robinson wrote: Hmm, what was the error message you were getting? We've made efforts at the libvirt level to have useful error reporting here, so that the cause of failure is more obvious. Debug-level error sequence at

Re: [libvirt] [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

2011-07-27 Thread Whit Blauvelt
The error from virt-manager 0.9.0's perspective is: Unable to open a connection to the libvirt management daemon. Libvirt URI is: qemu+ssh://root@192.168.1.65/system Verify that: - The 'libvirtd' daemon has been started [yes, it is] Cannot recv data: 15:42:02.778: 29831:

[libvirt] PCI devices passthough to LXC containers using libvirt

2011-07-27 Thread Devendra K. Modium
Hi All Please let me know if anyone have given access to PCI devices for a LXC container. I have tried getting the xml from virsh nodedev-dumpxml pci_device and added to the libvirt xml file as shown below device namepci__03_00_0/name parentpci__00_03_0/parent driver

Re: [libvirt] [PATCH] virsh: expose change-protection during migration

2011-07-27 Thread Eric Blake
On 07/27/2011 02:00 PM, Matthias Bolte wrote: 2011/7/27 Eric Blakeebl...@redhat.com: * tools/virsh.c (doMigrate): Add --change-protection flag. * tools/virsh.pod (migrate): Document it. --- As promised here: https://www.redhat.com/archives/libvir-list/2011-July/msg01919.html ACK. Thanks;

Re: [libvirt] [Qemu-devel] [PATCH v3] Add support for fd: protocol

2011-07-27 Thread Blue Swirl
On Tue, Jul 26, 2011 at 3:51 PM, Corey Bryant cor...@linux.vnet.ibm.com wrote: sVirt provides SELinux MAC isolation for Qemu guest processes and their corresponding resources (image files). sVirt provides this support by labeling guests and resources with security labels that are stored in

Re: [libvirt] [PATCH 00/19] Rollback migration when libvirtd restarts

2011-07-27 Thread Eric Blake
On 07/07/2011 05:34 PM, Jiri Denemark wrote: This series is also available at https://gitorious.org/~jirka/libvirt/jirka-staging/commits/migration-recovery The series does several things: - persists current job and its phase in status xml - allows safe monitor commands to be run during

Re: [libvirt] [PATCH 04/19] qemu: Allow all query commands to be run during long jobs

2011-07-27 Thread Eric Blake
On 07/07/2011 05:34 PM, Jiri Denemark wrote: Query commands are safe to be called during long running jobs (such as migration). This patch makes them all work without the need to special-case every single one of them. Git bisect says that this was the culprit commit that broke 'virsh

[libvirt] [PATCH] qemu: improve thread documentation

2011-07-27 Thread Eric Blake
* src/qemu/THREADS.txt: Fix problems with typos, grammar, and outdated examples. --- Doc only, so pushing under the trivial rule. src/qemu/THREADS.txt | 30 -- 1 files changed, 16 insertions(+), 14 deletions(-) diff --git a/src/qemu/THREADS.txt

Re: [libvirt] [v2] qemu: Improve docs for virsh dump format

2011-07-27 Thread Osier Yang
于 2011年07月28日 00:18, Eric Blake 写道: On 07/27/2011 04:58 AM, Osier Yang wrote: The error in getCompressionType will never be reported, change the errors codes into warning (VIR_WARN(%s, _(foo)); doesn't break syntax-check rule), and also improve the docs in qemu.conf to tell user the truth. ---

[libvirt] [PATCH] qemu: fix nested job with driver lock held

2011-07-27 Thread Eric Blake
qemuMigrationUpdateJobStatus (called in a loop by migration and save tasks) uses qemuDomainObjEnterMonitorWithDriver; however, that function ended up starting a nested job without releasing the driver. Since no one else is making nested calls, we can inline the internal functions to properly

Re: [libvirt] Memory leak of the remoteDomainSet* functions

2011-07-27 Thread Osier Yang
于 2011年07月28日 03:19, Matthias Bolte 写道: 2011/7/27 Matthias Boltematthias.bo...@googlemail.com: 2011/7/27 Osier Yangjy...@redhat.com: Hello, there Per bug https://bugzilla.redhat.com/show_bug.cgi?id=725322, should we change the remoteDomainSet* functions into skipgen, and fix the leaks like

Re: [libvirt] [PATCH] virsh: fix memory leak in cmdVolPath code

2011-07-27 Thread Osier Yang
于 2011年07月27日 11:48, Osier Yang 写道: 于 2011年07月27日 11:33, Alex Jia 写道: * tools/virsh.c: avoid memory leak in cmdVolPath. * how to reproduce? % dd if=/dev/zero of=/var/lib/libvirt/images/foo.img count=1 bs=10M % virsh pool-refresh default % valgrind -v --leak-check=full virsh vol-path

Re: [libvirt] libvirt-0.9.1 to 0.9.3-r1: managedsave/save won't start/restore at saved state

2011-07-27 Thread Laine Stump
On 07/27/2011 04:37 AM, Nicolas Sebrecht wrote: I'm seeing strange behaviour, here. Any guests saved using both managedsave and save commands from virsh won't restore at saved state. A new full boot sequence happen. - Tested against libvirt v0.9.1, v0.9.2, v0.9.3-r1 (Gentoo) - Confirmed on

Re: [libvirt] [PATCH] qemu: fix nested job with driver lock held

2011-07-27 Thread Laine Stump
On 07/27/2011 10:04 PM, Eric Blake wrote: qemuMigrationUpdateJobStatus (called in a loop by migration and save tasks) uses qemuDomainObjEnterMonitorWithDriver; however, that function ended up starting a nested job without releasing the driver. Since no one else is making nested calls, we can

Re: [libvirt] [PATCH] virsh: fix memory leak in cmdVolPath code

2011-07-27 Thread Alex Jia
On 07/28/2011 11:06 AM, Osier Yang wrote: 于 2011年07月27日 11:48, Osier Yang 写道: 于 2011年07月27日 11:33, Alex Jia 写道: * tools/virsh.c: avoid memory leak in cmdVolPath. * how to reproduce? % dd if=/dev/zero of=/var/lib/libvirt/images/foo.img count=1 bs=10M % virsh pool-refresh default %