* tools/virsh.pod: change 'live' to 'abort' based on actual option.
Signed-off-by: Alex Jia
---
tools/virsh.pod |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index f6f9908..01b8fd6 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@
On Mon, Aug 01, 2011 at 10:15:11PM +0800, Wen Congyang wrote:
> At 08/01/2011 05:04 PM, Daniel Veillard write:
> >
> > Okay, so I count 3 issues we should fix before pushing 0.9.4 out
> >- this one (can you open a bugzilla for tracking), are you gonna
> > provide a patch ? Dan Berrange w
Make sure the unique storage pool defined and create from different
directory to avoid inconsistent version of volume pool created.
Signed-off-by: Lei Li
---
src/conf/storage_conf.c | 25 +
src/conf/storage_conf.h |2 ++
src/libvirt_private.syms |1 +
3 files
At 08/02/2011 03:53 AM, Eric Blake Write:
> Steps to reproduce this problem (vm1 is not running):
> for i in `seq 50`; do virsh managedsave vm1& done; killall virsh
>
> Pre-patch, virNetServerClientClose could end up setting client->sock
> to NULL prior to other cleanup functions trying to use cli
On Mon, Aug 01, 2011 at 04:56:58PM -0700, Roopa Prabhu wrote:
> This patch tries to fix getPhysFn in macvtap.c to get the physical
> function(PF) of the direct attach interface, if the interface is a SR-IOV VF.
> It derives the PF/VF relationship from sysfs.
>
> There is some code to do this in n
On 08/01/2011 07:57 PM, Roopa Prabhu wrote:
From: Roopa Prabhu
This patch adds helper functions to derive the PF/VF relationship of an sriov
network device
Signed-off-by: Roopa Prabhu
Signed-off-by: Christian Benvenuti
Signed-off-by: David Wang
---
src/util/interface.c | 122
On 08/01/2011 07:57 PM, Roopa Prabhu wrote:
From: Roopa Prabhu
This patch adds code to the existing getPhysfn to get the PF device name
and VF index if the linkdev is a sriov VF.
The idea is to send the port profile message to a PF if the direct attach
interface is a VF. Eventually interface.c i
On 08/01/2011 07:57 PM, Roopa Prabhu wrote:
From: Roopa Prabhu
This function looks at sysfs "net" directory to get the network interface
name associated with the pci device
Signed-off-by: Roopa Prabhu
Signed-off-by: Christian Benvenuti
Signed-off-by: David Wang
---
src/util/pci.c | 42 +
From: Roopa Prabhu
This patch adds helper functions to derive the PF/VF relationship of an sriov
network device
Signed-off-by: Roopa Prabhu
Signed-off-by: Christian Benvenuti
Signed-off-by: David Wang
---
src/util/interface.c | 122 ++
src/uti
From: Roopa Prabhu
This patch adds code to the existing getPhysfn to get the PF device name
and VF index if the linkdev is a sriov VF.
The idea is to send the port profile message to a PF if the direct attach
interface is a VF. Eventually interface.c is probably the right place for
getPhysfn
Sig
This patch tries to fix getPhysFn in macvtap.c to get the physical
function(PF) of the direct attach interface, if the interface is a SR-IOV VF.
It derives the PF/VF relationship from sysfs.
There is some code to do this in node device driver. But it is local
to the node device driver . I did not
From: Roopa Prabhu
This function looks at sysfs "net" directory to get the network interface
name associated with the pci device
Signed-off-by: Roopa Prabhu
Signed-off-by: Christian Benvenuti
Signed-off-by: David Wang
---
src/util/pci.c | 42 ++
src/
[adding libvirt, for a virsh idea]
On 08/01/2011 02:19 PM, Cole Robinson wrote:
On 07/30/2011 04:15 PM, Miklos Vajna wrote:
Hi,
So far in virt-manager one had to click on a shut off vm in the
"Shutoff" state to see if it has a saved image: once the item is
selected then the "play" icon will be
On 07/29/2011 02:41 AM, Jean-Baptiste Rouault wrote:
This patch adds an internal function openvzGetVEStatus to
get the real state of the domain. This function is used in
various places in the driver, in particular to detect when
the domain has been shut down by the user with the "halt"
command.
-
On Mon, Aug 01, 2011 at 02:28:59PM -0600, Eric Blake wrote:
> On 07/29/2011 03:12 AM, Guido Günther wrote:
> >Quote strings so they're safe to pass to the shell. Based on glib's
> >g_quote_string.
> >---
> > src/libvirt_private.syms |1 +
> > src/util/buf.c | 29 +++
On 07/29/2011 03:12 AM, Guido Günther wrote:
Quote strings so they're safe to pass to the shell. Based on glib's
g_quote_string.
---
src/libvirt_private.syms |1 +
src/util/buf.c | 29 +
src/util/buf.h |1 +
3 files changed, 31 insert
On 07/29/2011 02:30 AM, Peter Krempa wrote:
Well, yes, I found that out while looking for an interactive query
method which I didn't find.
I'm not opposed to an interactive query, but it does indeed put us into
new territory for virsh, and we still have to think about scriptable
non-interacti
On 07/31/2011 10:58 PM, Lei Li wrote:
Make sure the unique storage pool defined and create from different directory
to avoid inconsistent version of volume pool created.
Wrap your commit messages; typically at 70 columns or so (since 'git
log' adds some indentation, but you want the end resul
Steps to reproduce this problem (vm1 is not running):
for i in `seq 50`; do virsh managedsave vm1& done; killall virsh
Pre-patch, virNetServerClientClose could end up setting client->sock
to NULL prior to other cleanup functions trying to use client->sock.
This fixes things by checking for NULL in
On 07/31/2011 09:00 PM, Wen Congyang wrote:
> At 07/30/2011 05:32 AM, Eric Blake Write:
>> Currently, we attempt to run sync job and async job at the same time. It
>> means that the monitor commands for two jobs can be run in any order.
>>
>>
>> v3: incorporate Wen's feedback - in particular, virPr
On 07/29/2011 08:53 PM, Wen Congyang wrote:
> At 07/30/2011 05:37 AM, Eric Blake write:
>> On 07/29/2011 03:32 PM, Eric Blake wrote:
>>> Currently, we attempt to run sync job and async job at the same time. It
>>> means that the monitor commands for two jobs can be run in any order.
>>>
>>
>>>
>>>
2011/8/1 Eric Blake :
> On 07/28/2011 12:07 PM, Matthias Bolte wrote:
>> 2011/7/27 Matthias Bolte :
>>> doRemoteClose doesn't free the virNetClientPtr and this creates a
>>> 260kb leak per remote connection. This happens because
>>> virNetClientFree doesn't remove the last ref, because virNetClient
于 2011年08月01日 23:39, Eric Blake 写道:
On 08/01/2011 09:34 AM, Osier Yang wrote:
This patch introduces a internal RPC API "virNetServerClose", which
is standalone with "virNetServerFree". it closes all the socket fds,
and unlinks the unix socket paths, regardless of whether the socket
is still ref
On 07/28/2011 12:07 PM, Matthias Bolte wrote:
> 2011/7/27 Matthias Bolte :
>> doRemoteClose doesn't free the virNetClientPtr and this creates a
>> 260kb leak per remote connection. This happens because
>> virNetClientFree doesn't remove the last ref, because virNetClientNew
>> creates the virNetCli
On 08/01/2011 09:45 AM, Alex Jia wrote:
> whether or not previous return value is -1, the following codes will be
> executed for a inactive guest in src/qemu/qemu_driver.c:
> ret = virDomainSaveConfig(driver->configDir, persistentDef);
> and if everything is okay, 'ret' is assigned to 0, the previ
On 08/01/2011 09:34 AM, Osier Yang wrote:
> This patch introduces a internal RPC API "virNetServerClose", which
> is standalone with "virNetServerFree". it closes all the socket fds,
> and unlinks the unix socket paths, regardless of whether the socket
> is still referenced or not.
>
> This is to
whether or not previous return value is -1, the following codes will be
executed for a inactive guest in src/qemu/qemu_driver.c:
ret = virDomainSaveConfig(driver->configDir, persistentDef);
and if everything is okay, 'ret' is assigned to 0, the previous 'ret'
will be overwritten, this patch will f
On 08/01/2011 11:23 PM, Eric Blake wrote:
On 08/01/2011 09:06 AM, Alex Jia wrote:
whether or not previous return value is -1, the following codes will be
executed for a inactive guest in qemuDomainSetMemoryParameters:
ret = virDomainSaveConfig(driver->configDir, persistentDef);
and if everything
On 08/01/2011 09:06 AM, Alex Jia wrote:
> whether or not previous return value is -1, the following codes will be
> executed for a inactive guest in qemuDomainSetMemoryParameters:
> ret = virDomainSaveConfig(driver->configDir, persistentDef);
> and if everything is okay, 'ret' is assigned to 0, the
于 2011年08月01日 22:28, Eric Blake 写道:
On 08/01/2011 08:38 AM, Osier Yang wrote:
+++ b/src/rpc/virnetsocket.c
@@ -1222,3 +1222,19 @@ void virNetSocketRemoveIOCallback(virNetSocketPtr sock)
virMutexUnlock(&sock->lock);
}
+
+void virNetSocketClose(virNetSocketPtr sock)
+{
Can this be called
whether or not previous return value is -1, the following codes will be
executed for a inactive guest in qemuDomainSetMemoryParameters:
ret = virDomainSaveConfig(driver->configDir, persistentDef);
and if everything is okay, 'ret' is assigned to 0, the previous 'ret'
will be overwritten, this patch
This patch introduces a internal RPC API "virNetServerClose", which
is standalone with "virNetServerFree". it closes all the socket fds,
and unlinks the unix socket paths, regardless of whether the socket
is still referenced or not.
This is to address regression bug:
https://bugzilla.redhat.com/s
On 08/01/2011 05:57 PM, Daniel Veillard wrote:
On Mon, Aug 01, 2011 at 05:05:28PM +0800, a...@redhat.com wrote:
whether or not previous return value is -1, the following codes will be
executed for a inactive guest in src/qemu/qemu_driver.c:
ret = virDomainSaveConfig(driver->configDir, persistent
On 08/01/2011 08:38 AM, Osier Yang wrote:
> +++ b/src/rpc/virnetsocket.c
> @@ -1222,3 +1222,19 @@ void virNetSocketRemoveIOCallback(virNetSocketPtr sock)
>
> virMutexUnlock(&sock->lock);
> }
> +
> +void virNetSocketClose(virNetSocketPtr sock)
> +{
Can this be called on more than one cleanu
At 08/01/2011 05:04 PM, Daniel Veillard write:
On Mon, Aug 01, 2011 at 04:51:38PM +0800, Wen Congyang wrote:
At 07/30/2011 03:02 PM, Daniel Veillard Write:
I actually tagged and pushed the rc2 tarball and rpms yesterday
but completely forgot to send the associated mail, oops !
ftp://libvir
2011/8/1 Wen Congyang :
> At 08/01/2011 06:02 PM, Matthias Bolte write:
>>
>> 2011/8/1 Wen Congyang:
>>>
>>> At 07/30/2011 03:02 PM, Daniel Veillard Write:
I actually tagged and pushed the rc2 tarball and rpms yesterday
but completely forgot to send the associated mail, oops !
>
On 08/01/2011 10:05 PM, ajia wrote:
On 08/01/2011 08:38 PM, Guannan Ren wrote:
On 08/01/2011 05:04 PM, Daniel Veillard wrote:
On Mon, Aug 01, 2011 at 04:51:38PM +0800, Wen Congyang wrote:
At 07/30/2011 03:02 PM, Daniel Veillard Write:
I actually tagged and pushed the rc2 tarball and rpms yest
On 08/01/2011 08:38 PM, Guannan Ren wrote:
On 08/01/2011 05:04 PM, Daniel Veillard wrote:
On Mon, Aug 01, 2011 at 04:51:38PM +0800, Wen Congyang wrote:
At 07/30/2011 03:02 PM, Daniel Veillard Write:
I actually tagged and pushed the rc2 tarball and rpms yesterday
but completely forgot to send t
This patch introduces a internal RPC API "virNetServerClose", which
is standalone with "virNetServerFree". it closes all the socket fds,
and unlinks the unix socket paths, regardless of whether the socket
is still referenced or not.
This is to address regression bug:
https://bugzilla.redhat.com/s
At 08/01/2011 06:02 PM, Matthias Bolte write:
2011/8/1 Wen Congyang:
At 07/30/2011 03:02 PM, Daniel Veillard Write:
I actually tagged and pushed the rc2 tarball and rpms yesterday
but completely forgot to send the associated mail, oops !
ftp://libvirt.org/libvirt/libvirt-0.9.4-rc2.tar.gz
On 08/01/2011 02:08 AM, Matthias Bolte wrote:
>
> The invalid reads by __strspn_sse42 and __strspn_sse42 are actually
> bugs in glibc where it uses optimized code on too short strings.
Not so much bugs in glibc (as long as the short reads do not cross page
boundaries, and glibc does not use the u
2011/8/1 Daniel Veillard :
> On Mon, Aug 01, 2011 at 02:43:25PM +0200, Matthias Bolte wrote:
>> This commands don't have a --pool option, so don't tell
>> vshCommandOptVolBy that there could be one. This made
>> vshCommandOptString for pooloptname fail and an "missing option"
>> error was reported.
On Mon, Aug 01, 2011 at 02:43:25PM +0200, Matthias Bolte wrote:
> This commands don't have a --pool option, so don't tell
> vshCommandOptVolBy that there could be one. This made
> vshCommandOptString for pooloptname fail and an "missing option"
> error was reported.
>
> Make pooloptname optional f
On Mon, Aug 01, 2011 at 08:38:42PM +0800, Guannan Ren wrote:
> On 08/01/2011 05:04 PM, Daniel Veillard wrote:
> > Okay, so I count 3 issues we should fix before pushing 0.9.4 out
> >- this one (can you open a bugzilla for tracking), are you gonna
> > provide a patch ? Dan Berrange won't
On Sun, Jul 31, 2011 at 04:59:11PM +0800, Guannan Ren wrote:
> * src/qemu/qemu.conf lock_manager = "sanlock"
>
> ---
> src/qemu/qemu.conf |7 +++
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
> index 8058352..79c6e85 100644
>
On 07/30/2011 01:15 PM, Richard W.M. Jones wrote:
> On Thu, Jul 28, 2011 at 12:31:10PM -0400, Cole Robinson wrote:
>> - Use libguestfs to show guest packagelist and more (Richard W.M. Jones)
>
> I had one complaint that the dependency on python-libguestfs pulls in
> qemu (from someone using virt-m
于 2011年08月01日 17:35, Wen Congyang 写道:
At 08/01/2011 05:04 PM, Daniel Veillard Write:
On Mon, Aug 01, 2011 at 04:51:38PM +0800, Wen Congyang wrote:
At 07/30/2011 03:02 PM, Daniel Veillard Write:
I actually tagged and pushed the rc2 tarball and rpms yesterday
but completely forgot to send the as
This commands don't have a --pool option, so don't tell
vshCommandOptVolBy that there could be one. This made
vshCommandOptString for pooloptname fail and an "missing option"
error was reported.
Make pooloptname optional for vshCommandOptVolBy.
---
tools/virsh.c |6 +++---
1 files changed, 3
On 08/01/2011 05:04 PM, Daniel Veillard wrote:
On Mon, Aug 01, 2011 at 04:51:38PM +0800, Wen Congyang wrote:
At 07/30/2011 03:02 PM, Daniel Veillard Write:
I actually tagged and pushed the rc2 tarball and rpms yesterday
but completely forgot to send the associated mail, oops !
ftp://libvir
于 2011年08月01日 19:14, Matthias Bolte 写道:
2011/8/1 Osier Yang:
Introduced by f9a837da73a11ef, the condition is not changed after
the else clause is removed. So now it quit with "domain is not
running" when the domain is running. However, when the domain is
not running, it reports "no job is active
2011/8/1 Osier Yang :
> Introduced by f9a837da73a11ef, the condition is not changed after
> the else clause is removed. So now it quit with "domain is not
> running" when the domain is running. However, when the domain is
> not running, it reports "no job is active".
>
> How to reproduce:
>
> 1)
>
于 2011年08月01日 16:07, Matthias Bolte 写道:
Reported by Alex Jia.
---
src/conf/network_conf.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 6714c20..b11c482 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/netwo
whether or not previous return value is -1, the following codes will be
executed for a inactive guest in qemuDomainSetMemoryParameters:
ret = virDomainSaveConfig(driver->configDir, persistentDef);
and if everything is okay, 'ret' is assigned to 0, the previous 'ret'
will be overwritten, this patch
On Mon, Aug 01, 2011 at 05:05:28PM +0800, a...@redhat.com wrote:
> whether or not previous return value is -1, the following codes will be
> executed for a inactive guest in src/qemu/qemu_driver.c:
> ret = virDomainSaveConfig(driver->configDir, persistentDef);
> and if everything is okay, 'ret' is
2011/8/1 Wen Congyang :
> At 07/30/2011 03:02 PM, Daniel Veillard Write:
>> I actually tagged and pushed the rc2 tarball and rpms yesterday
>> but completely forgot to send the associated mail, oops !
>>
>> ftp://libvirt.org/libvirt/libvirt-0.9.4-rc2.tar.gz
>>
>> Hopefully it fixes most of the p
2011/8/1 Osier Yang :
> 于 2011年08月01日 16:07, Matthias Bolte 写道:
>>
>> Reported by Alex Jia.
>> ---
>> src/conf/network_conf.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
>> index 6714c20..b11c482 100644
>> ---
At 08/01/2011 05:04 PM, Daniel Veillard Write:
> On Mon, Aug 01, 2011 at 04:51:38PM +0800, Wen Congyang wrote:
>> At 07/30/2011 03:02 PM, Daniel Veillard Write:
>>> I actually tagged and pushed the rc2 tarball and rpms yesterday
>>> but completely forgot to send the associated mail, oops !
>>>
>>>
Introduced by f9a837da73a11ef, the condition is not changed after
the else clause is removed. So now it quit with "domain is not
running" when the domain is running. However, when the domain is
not running, it reports "no job is active".
How to reproduce:
1)
% virsh start $domain
% virsh domjobab
On Mon, Aug 01, 2011 at 04:51:38PM +0800, Wen Congyang wrote:
> At 07/30/2011 03:02 PM, Daniel Veillard Write:
> > I actually tagged and pushed the rc2 tarball and rpms yesterday
> > but completely forgot to send the associated mail, oops !
> >
> >ftp://libvirt.org/libvirt/libvirt-0.9.4-rc2.ta
whether or not previous return value is -1, the following codes will be
executed for a inactive guest in src/qemu/qemu_driver.c:
ret = virDomainSaveConfig(driver->configDir, persistentDef);
and if everything is okay, 'ret' is assigned to 0, the previous 'ret'
will be overwritten, this patch will f
At 07/30/2011 03:02 PM, Daniel Veillard Write:
> I actually tagged and pushed the rc2 tarball and rpms yesterday
> but completely forgot to send the associated mail, oops !
>
>ftp://libvirt.org/libvirt/libvirt-0.9.4-rc2.tar.gz
>
> Hopefully it fixes most of the problems raised with rc1, inclu
2011/8/1 Alex Jia :
> On 07/30/2011 03:02 PM, Daniel Veillard wrote:
>>
>> I actually tagged and pushed the rc2 tarball and rpms yesterday
>> but completely forgot to send the associated mail, oops !
>>
>> ftp://libvirt.org/libvirt/libvirt-0.9.4-rc2.tar.gz
>>
>> Hopefully it fixes most of the pr
Reported by Alex Jia.
---
src/conf/network_conf.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 6714c20..b11c482 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -169,6 +169,8 @@ void virNetwor
63 matches
Mail list logo
