Re: [libvirt] [PATCH 0/4] snapshot improvements

2011-08-08 Thread Philipp Hahn
Hello Eic, hello list, On Saturday 06 August 2011 02:00:04 Eric Blake wrote: There's still a lot to go before virsh snapshot can manage disk snapshots in addition to checkpoints, but I wanted to get the review started on these. Even with these patches, there are some major bugs with

Re: [libvirt] [PATCH 4/4] virsh: concatenate qemu-monitor-command arguments

2011-08-08 Thread Daniel P. Berrange
On Fri, Aug 05, 2011 at 06:00:08PM -0600, Eric Blake wrote: Call me lazy, but: virsh qemu-monitor-command dom --hmp info status is nicer than: virsh qemu-monitor-command dom --hmp 'info status' This does introduce a quoting problem though. eg consider virsh qemu-monitor-command dom

[libvirt] How to avoid failure of migration/restoring/starting if cdrom is ejected inside guest?

2011-08-08 Thread Osier Yang
Hello list, There is problem of migration if the changedable medium is ejected inside guest, this is caused by qemu closes the block driver backend once the medium is ejected, but it doesn't gives a way to let libvirt known the fact. So, libvirt will try to migrate the guest with the media still

[libvirt] Re: libvirt-0.9.1 to 0.9.3-r1: managedsave/save won't start/restore at saved state

2011-08-08 Thread Nicolas Sebrecht
The 05/08/11, Laine Stump wrote: So, I've tried yet another thing. I made a tarball of the whole working system and installed it on the testing bare metal (Core i3-2100). The 'start' command after 'managedsave' still fails. Then, I tried to change kvm related kernel compilation option and

[libvirt] [PATCH] storage: avoid missing break in default branch of switch statement

2011-08-08 Thread ajia
Detected by Coverity. * src/storage/storage_backend.c: avoid missing break in default branch. https://bugzilla.redhat.com/show_bug.cgi?id=721335 Signed-off-by: Alex Jia a...@redhat.com --- src/storage/storage_backend.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[libvirt] Documentation

2011-08-08 Thread Rafael Fernández López
Hi all, Reading libvirt documentation I have found that there is an example that is pretty broken. I'm referring to http://libvirt.org/guide/html/Application_Development_Guide-Guest_Domains-Listing.html, example 4.6. I attach a patch (untested) that fixes some logic, type and function signature

[libvirt] [RFC] Host CPU passthrough

2011-08-08 Thread Jiri Denemark
Hi, AFAIK this topic is not new but I think we still do not have a good solution for it. Libvirt already supports specifying what CPU and its features a guest should see but imagine one wants to run a guest on the best possible CPU. The current way is to copy the cpu element from capabilities XML

Re: [libvirt] [RFC v2] Export KVM Host Power Management capabilities

2011-08-08 Thread Srivatsa S. Bhat
On 08/05/2011 09:21 PM, Eric Blake wrote: On 08/05/2011 05:54 AM, Srivatsa S. Bhat wrote: This patch exports KVM Host Power Management capabilities as XML so that higher-level systems management software can make use of these features available in the host. The script pm-is-supported (from

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Anthony Liguori
On 08/08/2011 03:42 AM, Shribman, Aidan wrote: Subject: [PATCH v4] XBZRLE delta for live migration of large memory apps From: Aidan Shribmanaidan.shrib...@sap.com By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM downtime and total live-migration time of VMs running memory

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Alexander Graf
On 08.08.2011, at 15:29, Anthony Liguori wrote: On 08/08/2011 03:42 AM, Shribman, Aidan wrote: Subject: [PATCH v4] XBZRLE delta for live migration of large memory apps From: Aidan Shribmanaidan.shrib...@sap.com By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Anthony Liguori
On 08/08/2011 08:41 AM, Alexander Graf wrote: On 08.08.2011, at 15:29, Anthony Liguori wrote: One thing that strikes me about this algorithm is that it's very good for a particular type of workload--shockingly good really. I think workload aware migration compression is possible for a lot

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Avi Kivity
On 08/08/2011 04:29 PM, Anthony Liguori wrote: One thing that strikes me about this algorithm is that it's very good for a particular type of workload--shockingly good really. Poking bytes at random places in memory is fairly generic. If you have a lot of small objects, and modify a subset

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Avi Kivity
On 08/08/2011 04:41 PM, Alexander Graf wrote: In general, I believe it's a good idea to keep looking at libvirt as a vm management layer and only a vm management layer. Very much yes. -- error compiling committee.c: too many arguments to function -- libvir-list mailing list

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Daniel P. Berrange
On Mon, Aug 08, 2011 at 08:29:51AM -0500, Anthony Liguori wrote: On 08/08/2011 03:42 AM, Shribman, Aidan wrote: Subject: [PATCH v4] XBZRLE delta for live migration of large memory apps From: Aidan Shribmanaidan.shrib...@sap.com By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can

Re: [libvirt] [PATCH] storage: avoid missing break in default branch of switch statement

2011-08-08 Thread Eric Blake
On 08/08/2011 04:20 AM, Alex Jia wrote: Detected by Coverity. * src/storage/storage_backend.c: avoid missing break in default branch. https://bugzilla.redhat.com/show_bug.cgi?id=721335 Signed-off-by: Alex Jiaa...@redhat.com --- src/storage/storage_backend.c |1 + 1 files changed, 1

Re: [libvirt] How to avoid failure of migration/restoring/starting if cdrom is ejected inside guest?

2011-08-08 Thread Dave Allan
On Mon, Aug 08, 2011 at 05:47:24PM +0800, Osier Yang wrote: Hello list, There is problem of migration if the changedable medium is ejected inside guest, this is caused by qemu closes the block driver backend once the medium is ejected, but it doesn't gives a way to let libvirt known the

Re: [libvirt] [PATCH] storage: avoid missing break in default branch of switch statement

2011-08-08 Thread Alex Jia
On 08/08/2011 10:04 PM, Eric Blake wrote: On 08/08/2011 04:20 AM, Alex Jia wrote: Detected by Coverity. * src/storage/storage_backend.c: avoid missing break in default branch. https://bugzilla.redhat.com/show_bug.cgi?id=721335 Signed-off-by: Alex Jiaa...@redhat.com ---

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Anthony Liguori
On 08/08/2011 08:51 AM, Avi Kivity wrote: On 08/08/2011 04:29 PM, Anthony Liguori wrote: One thing that strikes me about this algorithm is that it's very good for a particular type of workload--shockingly good really. Poking bytes at random places in memory is fairly generic. If you have a

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Avi Kivity
On 08/08/2011 05:15 PM, Anthony Liguori wrote: I think workload aware migration compression is possible for a lot of different types of workloads. That makes me a bit wary of QEMU growing quite a lot of compression mechanisms. It makes me think that this logic may really belong at a higher

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Anthony Liguori
On 08/08/2011 09:23 AM, Avi Kivity wrote: On 08/08/2011 05:15 PM, Anthony Liguori wrote: If we did .so plugins, which I'm really not opposed to, I'd want the interface to be something like: typedef struct MigrationTransportClass { ssize_t (*writev)(MigrationTransport *obj, struct iovec *iov,

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Avi Kivity
On 08/08/2011 05:33 PM, Anthony Liguori wrote: If we have a shared object helper, the thread should be maintained by qemu proper, not the plugin. I wouldn't call it migration transport, but instead a compression/decompression plugin. I don't think it merits a plugin at all though. There's

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Avi Kivity
On 08/08/2011 05:04 PM, Daniel P. Berrange wrote: My main concern with all these scenarios where libvirt touches the actual data stream though is that we're introducing extra data copies into the migration path which potentially waste CPU cycles. If QEMU can directly XBZRLE encode data into the

Re: [libvirt] How to avoid failure of migration/restoring/starting if cdrom is ejected inside guest?

2011-08-08 Thread Osier Yang
于 2011年08月08日 22:04, Dave Allan 写道: On Mon, Aug 08, 2011 at 05:47:24PM +0800, Osier Yang wrote: Hello list, There is problem of migration if the changedable medium is ejected inside guest, this is caused by qemu closes the block driver backend once the medium is ejected, but it doesn't gives a

Re: [libvirt] [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Anthony Liguori
On 08/08/2011 09:39 AM, Avi Kivity wrote: The other option is to allow 1-off compression algorithms in the form of plugins. I think in this case, plugins are a pretty good compromise in terms of isolating complexity while allowing something that at least works very well for one particular type

[libvirt] [RFC v3] Export KVM Host Power Management capabilities

2011-08-08 Thread Srivatsa S. Bhat
This patch exports KVM Host Power Management capabilities as XML so that higher-level systems management software can make use of these features available in the host. The script pm-is-supported (from pm-utils package) is run to discover if Suspend-to-RAM (S3) or Suspend-to-Disk (S4) is

Re: [libvirt] How to avoid failure of migration/restoring/starting if cdrom is ejected inside guest?

2011-08-08 Thread Dave Allan
On Mon, Aug 08, 2011 at 10:45:19PM +0800, Osier Yang wrote: 于 2011年08月08日 22:04, Dave Allan 写道: On Mon, Aug 08, 2011 at 05:47:24PM +0800, Osier Yang wrote: Hello list, There is problem of migration if the changedable medium is ejected inside guest, this is caused by qemu closes the block

Re: [libvirt] [RFC v2] Export KVM Host Power Management capabilities

2011-08-08 Thread Daniel P. Berrange
On Fri, Aug 05, 2011 at 11:52:07PM +0530, Vaidyanathan Srinivasan wrote: * Daniel P. Berrange berra...@redhat.com [2011-08-05 17:11:50]: On Fri, Aug 05, 2011 at 05:24:13PM +0530, Srivatsa S. Bhat wrote: This patch exports KVM Host Power Management capabilities as XML so that

Re: [libvirt] [PATCH] build: fix regression in large file support

2011-08-08 Thread Eric Blake
On 08/08/2011 09:53 AM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=728772 points out that libvirt commit 1c93fbbb pulled in a gnulib regression that broke large file support. * .gnulib: Update to latest, for largefile fix. --- Pushing under the trivial rule. .gnulib |

Re: [libvirt] [RFC v3] Export KVM Host Power Management capabilities

2011-08-08 Thread Eric Blake
On 08/08/2011 09:18 AM, Srivatsa S. Bhat wrote: Open issues: --- 1. Design new APIs in libvirt to actually exploit the host power management features instead of relying on external programs. This was discussed in [4]. As pointed out in [4], until we have additional use for this

Re: [libvirt] [RFC v3] Export KVM Host Power Management capabilities

2011-08-08 Thread Eric Blake
On 08/08/2011 10:18 AM, Eric Blake wrote: Correction on my bitmask idea: + if(caps-host.isPMQuerySuccess) { if (caps-host.powerMgmt) { unsigned int pm = caps-host.powerMgmt; virBufferAddLit(xml, power_management\n); while (pm) { int bit = ffs(pm) - 1; virBufferAsprintf(xml, %s/\n,

Re: [libvirt] How to avoid failure of migration/restoring/starting if cdrom is ejected inside guest?

2011-08-08 Thread Eric Blake
On 08/08/2011 09:22 AM, Dave Allan wrote: If the medium is ejected inside guest, and the source of the medium is removed or renamed. libvirt will still tries to do cgroup setting before starting the guest on dest side, that's the real problem. As one will think it's reasonable to remove the

Re: [libvirt] [PATCH 4/4] virsh: concatenate qemu-monitor-command arguments

2011-08-08 Thread Eric Blake
On 08/08/2011 03:40 AM, Daniel P. Berrange wrote: On Fri, Aug 05, 2011 at 06:00:08PM -0600, Eric Blake wrote: Call me lazy, but: virsh qemu-monitor-command dom --hmp info status is nicer than: virsh qemu-monitor-command dom --hmp 'info status' This does introduce a quoting problem though.

Re: [libvirt] How to avoid failure of migration/restoring/starting if cdrom is ejected inside guest?

2011-08-08 Thread Dave Allan
On Mon, Aug 08, 2011 at 11:53:26AM -0600, Eric Blake wrote: On 08/08/2011 09:22 AM, Dave Allan wrote: If the medium is ejected inside guest, and the source of the medium is removed or renamed. libvirt will still tries to do cgroup setting before starting the guest on dest side, that's the real

Re: [libvirt] [PATCH] build: fix regression in large file support

2011-08-08 Thread Guido Günther
Hi Eric, On Mon, Aug 08, 2011 at 09:53:39AM -0600, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=728772 points out that libvirt commit 1c93fbbb pulled in a gnulib regression that broke large file support. I had a quick look and rerunning this pulls in quite some auto* changes.

[libvirt] Python stream callback removal

2011-08-08 Thread Dave Allan
I'm trying to write an example serial console implementation in python (attached), but I'm having some trouble getting stream events to do what I want. The console itself works fine as long as the domain stays up, but as soon as the domain shuts down the python script goes into a tight loop

Re: [libvirt] How to avoid failure of migration/restoring/starting if cdrom is ejected inside guest?

2011-08-08 Thread Osier Yang
于 2011年08月09日 02:09, Dave Allan 写道: On Mon, Aug 08, 2011 at 11:53:26AM -0600, Eric Blake wrote: On 08/08/2011 09:22 AM, Dave Allan wrote: If the medium is ejected inside guest, and the source of the medium is removed or renamed. libvirt will still tries to do cgroup setting before starting the

Re: [libvirt] How to avoid failure of migration/restoring/starting if cdrom is ejected inside guest?

2011-08-08 Thread Dave Allan
On Tue, Aug 09, 2011 at 09:58:10AM +0800, Osier Yang wrote: 于 2011年08月09日 01:53, Eric Blake 写道: On 08/08/2011 09:22 AM, Dave Allan wrote: If the medium is ejected inside guest, and the source of the medium is removed or renamed. libvirt will still tries to do cgroup setting before starting

Re: [libvirt] How to avoid failure of migration/restoring/starting if cdrom is ejected inside guest?

2011-08-08 Thread Dave Allan
On Tue, Aug 09, 2011 at 10:07:57AM +0800, Osier Yang wrote: 于 2011年08月09日 02:09, Dave Allan 写道: On Mon, Aug 08, 2011 at 11:53:26AM -0600, Eric Blake wrote: On 08/08/2011 09:22 AM, Dave Allan wrote: If the medium is ejected inside guest, and the source of the medium is removed or renamed.

Re: [libvirt] How to avoid failure of migration/restoring/starting if cdrom is ejected inside guest?

2011-08-08 Thread Osier Yang
于 2011年08月09日 11:02, Dave Allan 写道: On Tue, Aug 09, 2011 at 10:07:57AM +0800, Osier Yang wrote: 于 2011年08月09日 02:09, Dave Allan 写道: On Mon, Aug 08, 2011 at 11:53:26AM -0600, Eric Blake wrote: On 08/08/2011 09:22 AM, Dave Allan wrote: If the medium is ejected inside guest, and the source of

Re: [libvirt] [Libvirt] [PATCH v2] Fix bug #611823 prohibit pools with duplicate storage

2011-08-08 Thread Lei Li
On 08/03/2011 05:29 AM, Daniel P. Berrange wrote: On Wed, Aug 03, 2011 at 12:52:50AM +0800, Lei Li wrote: On 08/02/2011 07:11 PM, Daniel P. Berrange wrote: On Mon, Aug 01, 2011 at 02:12:51PM -0600, Eric Blake wrote: On 07/31/2011 10:58 PM, Lei Li wrote: Make sure the unique storage pool

Re: [libvirt] [RFC v2] Export KVM Host Power Management capabilities

2011-08-08 Thread Vaidyanathan Srinivasan
* Daniel P. Berrange berra...@redhat.com [2011-08-08 16:38:48]: On Fri, Aug 05, 2011 at 11:52:07PM +0530, Vaidyanathan Srinivasan wrote: * Daniel P. Berrange berra...@redhat.com [2011-08-05 17:11:50]: On Fri, Aug 05, 2011 at 05:24:13PM +0530, Srivatsa S. Bhat wrote: This patch