Hello Eric,
you're patch looks very similar to mine, which I created myself yesterday, but
hadn't had time to actually send after doing the testing. I'll attach it just
FYI.
On Wednesday 10 August 2011 01:28:42 Eric Blake wrote:
qemuDomainSnapshotRevertInactive has the same FIXMEs as
Hi
I am using 0.9.4 version of libvirt and want to limit bandwidth.
I installed libvirt on ubuntu 11.04 using libvirt source.
For this i am using the QOS configuration
devices
interface type='network'
source network='default'/
target dev='vnet0'/
*bandwidth
inbound
small correction
it is not mbps ,it is MBps
On Wed, Aug 10, 2011 at 12:06 PM, Upendra Moturi upendr...@hexagrid.comwrote:
Hi
I am using 0.9.4 version of libvirt and want to limit bandwidth.
I installed libvirt on ubuntu 11.04 using libvirt source.
For this i am using the QOS configuration
On Tue, Mar 22, 2011 at 04:08:10PM -0600, Eric Blake wrote:
On 03/22/2011 02:36 PM, Cole Robinson wrote:
The following XML:
serial type='udp'
source mode='connect' service=''/
/serial
is accepted by domain_conf.c but maps to the qemu command line:
-chardev
When instantiating a filter, a VM may disappear and remove its tap
interfaces. Tolerate this case and don't report an error.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
---
src/nwfilter/nwfilter_gentech_driver.c | 14 +++---
1 file changed, 11 insertions(+), 3
On 08/10/2011 12:24 AM, Philipp Hahn wrote:
Hello Eric,
you're patch looks very similar to mine, which I created myself yesterday, but
hadn't had time to actually send after doing the testing. I'll attach it just
FYI.
On Wednesday 10 August 2011 01:28:42 Eric Blake wrote:
How in the world is managedsave supposed to work on transient domains?
The moment you save a domain, the qemu process is ended; but ending the
qemu process means that a transient domain no longer has any state
tracked by libvirt.
Should libvirt be temporarily defining a domain when creating a
Transient domains reject attempts to set autostart, and using
virDomainCreate to restart a domain only works on persistent
domains. Therefore, managed save makes no sense on transient
domains, and should be rejected up front rather than creating
an otherwise unrecoverable managed save file.
*
---
tools/console.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/console.c b/tools/console.c
index 11087e5..171ebc9 100644
--- a/tools/console.c
+++ b/tools/console.c
@@ -95,7 +95,7 @@ virConsoleShutdown(virConsolePtr con)
virStreamFree(con-st);
if
On 08/09/2011 11:45 PM, Laine Stump wrote:
This should have been done with the rest of the patch for virtual
switch / network device abstraction.
And I should have called you on this before the 0.9.4 release - oh well :)
+ A portgroup provides a method of easily putting guest
+
On 08/10/2011 02:55 AM, Upendra Moturi wrote:
Hi,
does this patch solve your problem? I am setting the MTU to fixed
2kb. Doing tests with scp seems to indicate that this improved the
situation -- at least for me.
Stefan
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
---
On Wed, Aug 10, 2011 at 05:03:23PM +0200, Juerg Haefliger wrote:
---
tools/console.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/console.c b/tools/console.c
index 11087e5..171ebc9 100644
--- a/tools/console.c
+++ b/tools/console.c
@@ -95,7 +95,7 @@
On 08/10/2011 01:15 AM, Daniel Veillard wrote:
On Tue, Mar 22, 2011 at 04:08:10PM -0600, Eric Blake wrote:
On 03/22/2011 02:36 PM, Cole Robinson wrote:
The following XML:
serial type='udp'
source mode='connect' service=''/
/serial
is accepted by domain_conf.c but maps to
On 08/10/2011 04:34 AM, Stefan Berger wrote:
When instantiating a filter, a VM may disappear and remove its tap
interfaces. Tolerate this case and don't report an error.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
ACK with one nit:
+ rc = 0;
+ goto exit;
+ }
+
rc =
On 08/10/2011 09:04 AM, Stefan Berger wrote:
On 08/10/2011 02:55 AM, Upendra Moturi wrote:
Hi,
does this patch solve your problem? I am setting the MTU to fixed 2kb.
Doing tests with scp seems to indicate that this improved the situation
-- at least for me.
Stefan
Signed-off-by: Stefan
On 08/05/2011 06:00 PM, Eric Blake wrote:
I noticed some inconsistent use of 'else'.
* src/qemu/qemu_driver.c (qemuCPUCompare)
(qemuDomainSnapshotCreateXML, qemuDomainRevertToSnapshot)
(qemuDomainSnapshotDiscard): Match coding conventions.
---
No functional changes.
I've pushed this under
On 08/10/2011 09:09 AM, Dave Allan wrote:
On Wed, Aug 10, 2011 at 05:03:23PM +0200, Juerg Haefliger wrote:
---
tools/console.c |2 +-
-if (con-stdinWatch != -1)
+if (con-stdoutWatch != -1)
virEventRemoveHandle(con-stdoutWatch);
con-stdinWatch = -1;
This series is a collection of changes related to pidfiles. First
we define some wrappers around fcntl()'s lock file capability.
Then all existing pidfile APIs from src/util/util.h are moved into
a new file src/util/virpidfile.h. Next a new API for doing a sanity
check on a PID (using
From: Daniel P. Berrange berra...@redhat.com
In some cases the caller of virPidFileRead might like extra checks
to determine whether the pid just read is really the one they are
expecting. This adds virPidFileReadIfValid which will check whether
the pid is still alive with kill(0, -1), and (on
From: Daniel P. Berrange berra...@redhat.com
The functions for manipulating pidfiles are in util/util.{c,h}.
We will shortly be adding some further pidfile related functions.
To avoid further growing util.c, this moves the pidfile related
functions into a dedicated virpidfile.{c,h}. The functions
From: Daniel P. Berrange berra...@redhat.com
Add some simple wrappers around the fcntl() discretionary file
locking capability.
* src/util/util.c, src/util/util.h, src/libvirt_private.syms: Add
virFileLock and virFileUnlock APIs
---
src/libvirt_private.syms |2 +
src/util/virfile.c
From: Daniel P. Berrange berra...@redhat.com
In daemons using pidfiles to protect against concurrent
execution there is a possibility that a crash may leave a stale
pidfile on disk, which then prevents later restart of the daemon.
To avoid this problem, introduce a pair of APIs which make
use of
On 08/10/2011 11:05 AM, Eric Blake wrote:
On 08/09/2011 11:45 PM, Laine Stump wrote:
This should have been done with the rest of the patch for virtual
switch / network device abstraction.
And I should have called you on this before the 0.9.4 release - oh
well :)
A long time ago I used to
On 08/10/2011 11:20 AM, Eric Blake wrote:
On 08/10/2011 09:04 AM, Stefan Berger wrote:
On 08/10/2011 02:55 AM, Upendra Moturi wrote:
Hi,
does this patch solve your problem? I am setting the MTU to fixed 2kb.
Doing tests with scp seems to indicate that this improved the situation
-- at least
On 04/13/2011 02:43 AM, kadir yüceer wrote:
Hello all,
I've been posting questions about my issue to the user list but it seems
nobody can answer, so I had to try this list, sorry if there is any
disturbance.
Here is the case:
I've been trying to develop a java app that can register callbacks
Hello Eric,
thank you for the long description of active
Am Mittwoch 10 August 2011 14:18:22 schrieb Eric Blake:
Right now, qemu's _only_ use of active (which is set to non-zero by
qemuDomainSnapshotSetCurrentActive) is to tell qemuBuildCommandLine to
use -loadvm to revert to that point,
On 07/25/2011 02:25 PM, j...@alien8.de wrote:
From: Julian Stecklinajstec...@os.inf.tu-dresden.de
I noticed that event handling in the libvirt Java bindings is incomplete.
The first patch adds required data types and constants. The second relaxes
the visibility of the Domain constructor,
On 08/10/2011 11:40 AM, Avi Kivity wrote:
On 08/10/2011 07:23 PM, Anthony Liguori wrote:
Right now we have capabilties in the form of -help output.
If -help says
-no-xzbrle disable xzbrle support
(or -migration-compression xzbrle=off, or something) that's sufficient
for management tools.
[BCC'ing those who have responded to earlier RFC's]
I've posted previous RFCs for improving snapshot support:
ideas on managing a subset of disks:
https://www.redhat.com/archives/libvir-list/2011-May/msg00042.html
ideas on managing snapshots of storage volumes not tied to a domain
Found this while revising the previous patch to use xpath rather
than strstr for undoing the escapse.
* tools/virsh.c (cmdSnapshotCreateAs): Escape user input.
---
tools/virsh.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
Sometimes, full XML is too much; since most snapshot commands
operate on a snapshot name, there should be an easy way to get
at the current snapshot's name.
* tools/virsh.c (cmdSnapshotCurrent): Add an option.
* tools/virsh.pod (snapshot-current): Document it.
---
v2: use xpath instead of
On Tue, Aug 09, 2011 at 05:50:55PM +0200, Michal Novotny wrote:
Hi,
this is the patch to the bridge driver and libvirt XML
file to include support for the SRV records in the DNS.
The syntax is based on DNSMasq man page and tests for
both xml2xml and xml2argv were added as well.
On Wed, Aug 10, 2011 at 12:20:15PM -0400, Laine Stump wrote:
On 08/10/2011 11:05 AM, Eric Blake wrote:
On 08/09/2011 11:45 PM, Laine Stump wrote:
This should have been done with the rest of the patch for virtual
switch / network device abstraction.
And I should have called you on this
On Wed, Aug 10, 2011 at 08:54:20AM -0600, Eric Blake wrote:
Transient domains reject attempts to set autostart, and using
virDomainCreate to restart a domain only works on persistent
domains. Therefore, managed save makes no sense on transient
domains, and should be rejected up front rather
On Wed, Aug 10, 2011 at 05:02:36PM -0600, Eric Blake wrote:
Sometimes, full XML is too much; since most snapshot commands
operate on a snapshot name, there should be an easy way to get
at the current snapshot's name.
* tools/virsh.c (cmdSnapshotCurrent): Add an option.
* tools/virsh.pod
On Wed, Aug 10, 2011 at 05:02:37PM -0600, Eric Blake wrote:
Found this while revising the previous patch to use xpath rather
than strstr for undoing the escapse.
typo, escape
* tools/virsh.c (cmdSnapshotCreateAs): Escape user input.
---
tools/virsh.c |4 ++--
1 files changed, 2
On Thu, Aug 11, 2011 at 10:13:34AM +0800, Daniel Veillard wrote:
On Tue, Aug 09, 2011 at 05:50:55PM +0200, Michal Novotny wrote:
Hi,
this is the patch to the bridge driver and libvirt XML
file to include support for the SRV records in the DNS.
The syntax is based on DNSMasq man page and
On 08/10/2011 08:19 PM, Daniel Veillard wrote:
On Wed, Aug 10, 2011 at 08:54:20AM -0600, Eric Blake wrote:
Transient domains reject attempts to set autostart, and using
virDomainCreate to restart a domain only works on persistent
domains. Therefore, managed save makes no sense on transient
On 08/10/2011 10:13 PM, Daniel Veillard wrote:
On Tue, Aug 09, 2011 at 05:50:55PM +0200, Michal Novotny wrote:
+char *portString = NULL;
+char *priorityString = NULL;
+char *weightString = NULL;
+int port;
+int priority;
+int weight;
+int ret = 0;
+
+if
On 08/10/2011 08:33 PM, Daniel Veillard wrote:
On Wed, Aug 10, 2011 at 05:02:37PM -0600, Eric Blake wrote:
Found this while revising the previous patch to use xpath rather
than strstr for undoing the escapse.
typo, escape
I adjusted the message to fix that, then pushed this one first
On 08/10/2011 08:32 PM, Daniel Veillard wrote:
On Wed, Aug 10, 2011 at 05:02:36PM -0600, Eric Blake wrote:
Sometimes, full XML is too much; since most snapshot commands
operate on a snapshot name, there should be an easy way to get
at the current snapshot's name.
* tools/virsh.c
Down the road, I want to add virDomainSnapshotGetParent, and use
the new API rather than xml scraping; but this virsh command can
be implemented even without the new API.
* tools/virsh.c (cmdSnapshotParent): New command.
* tools/virsh.pod (snapshot-parent): Document it.
---
Adding this will make
On 08/09/2011 11:50 AM, Michal Novotny wrote:
Hi,
this is the patch to the bridge driver and libvirt XML
file to include support for the SRV records in the DNS.
The syntax is based on DNSMasq man page and tests for
both xml2xml and xml2argv were added as well.
Signed-off-by: Michal
virNetworkDNSHostsDefParseXML was calling VIR_ALLOC(def-hosts) if
def-nhosts was 0. This is a waste of time, though, since
VIR_REALLOC_N is called a few lines further down, prior to any use of
def-hosts.
---
src/conf/network_conf.c |8
1 files changed, 0 insertions(+), 8 deletions(-)
While the first encountered dns host record is being parsed, it's
possible for virNetworkDef::hosts to point to memory that has been
allocated, but virNetworkDef::nhosts to still be 0. If there is a
failure during that time, virNetworkDef::hosts will be leaked.
Although this isn't currently the
Pushed under the trivial rule.
Someone in an IRC channel or an email pointed out a few days ago that
the examples of IPv6 addresses in the libvirt documentation were not
in the officially reserved documentation range. This addresses their
concern.
---
docs/formatnetwork.html.in |8
46 matches
Mail list logo
