On Wed, Aug 10, 2011 at 10:09:56PM -0600, Eric Blake wrote:
Down the road, I want to add virDomainSnapshotGetParent, and use
the new API rather than xml scraping; but this virsh command can
be implemented even without the new API.
* tools/virsh.c (cmdSnapshotParent): New command.
*
On Thu, Aug 11, 2011 at 12:14:41AM -0400, Laine Stump wrote:
While the first encountered dns host record is being parsed, it's
possible for virNetworkDef::hosts to point to memory that has been
allocated, but virNetworkDef::nhosts to still be 0. If there is a
failure during that time,
Hello,
On Wednesday 10 August 2011 17:25:58 Eric Blake wrote:
On 08/10/2011 09:09 AM, Dave Allan wrote:
On Wed, Aug 10, 2011 at 05:03:23PM +0200, Juerg Haefliger wrote:
---
tools/console.c |2 +-
-if (con-stdinWatch != -1)
+if (con-stdoutWatch != -1)
Excellent, that
On Thu, Aug 11, 2011 at 12:15:03AM -0400, Laine Stump wrote:
virNetworkDNSHostsDefParseXML was calling VIR_ALLOC(def-hosts) if
def-nhosts was 0. This is a waste of time, though, since
VIR_REALLOC_N is called a few lines further down, prior to any use of
def-hosts.
---
On 08/10/2011 10:27 PM, Anthony Liguori wrote:
This may be acceptable, wait until the entire migration cluster is
xzbrle capable before enabling it. If not, add a monitor command.
1) xzbrle needs to be disabled by default. That way management tools
don't unknowingly enable it by not passing
On Thu, Aug 11, 2011 at 11:17:09AM +0300, Avi Kivity wrote:
On 08/10/2011 10:27 PM, Anthony Liguori wrote:
This may be acceptable, wait until the entire migration cluster is
xzbrle capable before enabling it. If not, add a monitor command.
1) xzbrle needs to be disabled by default. That
On 08/11/2011 12:16 PM, Daniel P. Berrange wrote:
On Thu, Aug 11, 2011 at 11:17:09AM +0300, Avi Kivity wrote:
On 08/10/2011 10:27 PM, Anthony Liguori wrote:
This may be acceptable, wait until the entire migration cluster is
xzbrle capable before enabling it. If not, add a monitor command.
On Wed, Aug 10, 2011 at 02:27:41PM -0500, Anthony Liguori wrote:
On 08/10/2011 11:40 AM, Avi Kivity wrote:
Instead of teaching management tools how to deal with all of these
things, let's just fix this problem once. It just takes:
a) A query-migration-caps command that returns a dict with
After adding option to have directiories as storage volumes virsh reported
type of this storage volumes as 'file'. This patch fixes this type in data
structures and fixes the virsh output.
https://bugzilla.redhat.com/show_bug.cgi?id=727088
Peter Krempa (2):
storage: Directory shouldn't be
Fix internals of libvirt for new storage volume type.
Libvirt reported an invalid type of the volume.
BZ #727088
---
include/libvirt/libvirt.h.in |1 +
src/storage/storage_backend_fs.c |4
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git
Fix of output of detailed volume list. BZ #727088
---
tools/virsh.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 1d660d0..5d88d84 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -8989,10 +8989,19 @@
Am 11.08.2011 00:08, schrieb Eric Blake:
[BCC'ing those who have responded to earlier RFC's]
I've posted previous RFCs for improving snapshot support:
ideas on managing a subset of disks:
https://www.redhat.com/archives/libvir-list/2011-May/msg00042.html
ideas on managing snapshots of
On 08/10/2011 11:14 AM, Eric Blake wrote:
On 08/10/2011 04:34 AM, Stefan Berger wrote:
When instantiating a filter, a VM may disappear and remove its tap
interfaces. Tolerate this case and don't report an error.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
ACK with one nit:
+
From: Anthony Liguori [mailto:anth...@codemonkey.ws]
Sent: Wednesday, August 10, 2011 10:28 PM
To: Avi Kivity
Cc: Blue Swirl; Stefan Hajnoczi; Shribman, Aidan; qemu-devel
Developers; libvir-list@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of
large memory
Thanks for your reply.
The patch it appears still has problem.
I have changed only mtu value as 2kb instead of burst value in the
network.c file
With average as 2048 , burst as 2048 and peak 2048
scp copied at 30-40KB/s
With average as 4096 , burst as 4096 and peak 4096
scp copied at same
Early errors during start of libvirtd didn't have
an error reporting mechanism and caused libvirtd
to exit silently (only the return value indicated
an error). This patch adds error messages printed
to stderr if verbose parameter is specified to the
daemon.
fixes:
On 08/11/2011 03:03 AM, Shribman, Aidan wrote:
From: Anthony Liguori [mailto:anth...@codemonkey.ws]
Sent: Wednesday, August 10, 2011 10:28 PM
To: Avi Kivity
Cc: Blue Swirl; Stefan Hajnoczi; Shribman, Aidan; qemu-devel
Developers; libvir-list@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4] XBZRLE
On 08/11/2011 03:17 AM, Avi Kivity wrote:
3) a management tool should be able to query the source and
destination, and then enable xzbrle if both sides support it.
You can argue that (3) could be static. A command could be added to
toggle it dynamically through the monitor.
But no matter what,
Thanks for your review, Daniel. I already sent v2 of the patch now ;-)
Michal
On 08/11/2011 04:42 AM, Daniel Veillard wrote:
On Thu, Aug 11, 2011 at 10:13:34AM +0800, Daniel Veillard wrote:
On Tue, Aug 09, 2011 at 05:50:55PM +0200, Michal Novotny wrote:
Hi,
this is the patch to the bridge
From: Michal Novotny mig...@gmail.com
Hi,
this is the second version of my patch to the bridge driver and
libvirt XML file to include support for the SRV records in the DNS.
The syntax is based on DNSMasq man page and tests for both xml2xml
and xml2argv were added as well.
Differences between v1
On 08/11/2011 04:00 AM, Kevin Wolf wrote:
Am 11.08.2011 00:08, schrieb Eric Blake:
After re-reading the feedback received on those threads, I think I've
settled on a pretty robust design for my first round of adding
improvements to the management of snapshots tied to a domain, while
leaving the
Hi,
this is the second version of my patch to the bridge driver and
libvirt XML file to include support for the SRV records in the DNS.
The syntax is based on DNSMasq man page and tests for both xml2xml
and xml2argv were added as well.
Differences between v1 and v2:
- A minor rewrite of integer
Hi,
this is the second version of my patch to the bridge driver and
libvirt XML file to include support for the SRV records in the DNS.
The syntax is based on DNSMasq man page and tests for both xml2xml
and xml2argv were added as well.
Differences between v1 and v2:
- A minor rewrite of integer
Hi,
this is the second version of my patch to the bridge driver and
libvirt XML file to include support for the SRV records in the DNS.
The syntax is based on DNSMasq man page and tests for both xml2xml
and xml2argv were added as well.
Differences between v1 and v2:
- A minor rewrite of integer
Oops, sorry. This e-mail is not valid since I did try using git
send-email but I was unable to see it in the archives nor my inbox so I
guess the issue was caused by my sendmail daemon that was not working
properly. Please ignore this e-mail.
Thanks,
Michal
On 08/11/2011 03:21 PM, Michal
Please ignore previous mails (done by my sendmail was not working fine
and please review this one instead).
Thanks,
Michal
On 08/11/2011 03:22 PM, Michal Novotny wrote:
Hi,
this is the second version of my patch to the bridge driver and
libvirt XML file to include support for the SRV records
On 08/11/2011 08:07 AM, Upendra Moturi wrote:
Thanks for your reply.
The patch it appears still has problem.
I have changed only mtu value as 2kb instead of burst value in the
network.c file
With average as 2048 , burst as 2048 and peak 2048
scp copied at 30-40KB/s
All test I did were with the
On 08/11/2011 09:39 AM, Stefan Berger wrote:
On 08/11/2011 08:07 AM, Upendra Moturi wrote:
Thanks for your reply.
The patch it appears still has problem.
I have changed only mtu value as 2kb instead of burst value in the
network.c file
With average as 2048 , burst as 2048 and peak 2048
scp
Thanks for your clarification.
I am using 2.6.38-8-server kernel.
Will test with 3.0.0 kernel
On Thu, Aug 11, 2011 at 7:18 PM, Stefan Berger
stef...@linux.vnet.ibm.com wrote:
On 08/11/2011 09:39 AM, Stefan Berger wrote:
On 08/11/2011 08:07 AM, Upendra Moturi wrote:
Thanks for your reply.
Hello,
On Thursday 11 August 2011 08:35:25 Philipp Hahn wrote:
While testing it I noticed the following behaviour:
1. Start virsh
2. Do qemu-monitor-command $SOME_VM info\ chardev to get the path of the
pty used for the console → /dev/pts/Y
3. Execute console $SOME_VM from within the same
[ CCed qemu-devel, just in case someone's interested ]
Am 11.08.2011 15:23, schrieb Eric Blake:
[ Okay, some of it is handled later in this document, but I think it's
still useful to leave this summary in my mail. External VM state is
something that you don't seem to have covered yet - can't
Hi,
this is the second version of my patch to the bridge driver and
libvirt XML file to include support for the SRV records in the DNS.
The syntax is based on DNSMasq man page and tests for both xml2xml
and xml2argv were added as well.
Differences between v1 and v2:
- A minor rewrite of integer
On 08/05/2011 11:14 AM, Eric Blake wrote:
Our logic throws off analyzer tools:
ptr var = NULL;
if (flags == 0) flags = live ? _LIVE : _CONFIG;
if (flags _LIVE) do stuff
if (flags _CONFIG) var = non-null;
if (flags _LIVE) do more stuff
else if (flags _CONFIG) use var
the tools keep thinking
On 08/11/2011 09:54 AM, Upendra Moturi wrote:
Thanks for your clarification.
I am using 2.6.38-8-server kernel.
Will test with 3.0.0 kernel
Also works on 2.6.38.8-35.fc15.x86_64 kernel.
Stefan
On Thu, Aug 11, 2011 at 7:18 PM, Stefan Berger
stef...@linux.vnet.ibm.com wrote:
On
From: Daniel P. Berrange berra...@redhat.com
* remote.html.in: Remove obsolete notes about internals of the
RPC protocol
* internals/rpc.html.in: Extensive docs on RPC protocol/API
* sitemap.html.in: Add new page
---
docs/internals/rpc.html.in | 876
Currently only tabs and blanks are used for tokenizing the description,
which breaks when a term is at the end of a line or has () appended to
it.
1. Use also other white space characters such as new-lines and carriage
return for splitting.
2. Remove some common non-word characters from the
While working with the documentation, I found some issues I'd like to
improve.
Philipp Hahn (3):
Align table cells on top
Improve tokenizing of linkable terms
Fix references to self.warning()
docs/apibuild.py | 48 ++--
docs/libvirt.css |4
Only the class CParser declares a method warning(), but the other
classes still try to call their self.warning() method, which fails.
Move the warning() functions to its own base classe and inherit from
that in all other classes.
Signed-off-by: Philipp Hahn h...@univention.de
---
---
tools/virsh.c | 120 +++
tools/virsh.pod | 11 +
2 files changed, 131 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 1d660d0..b4c6e21 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -1161,6
---
src/driver.h | 14 +-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/src/driver.h b/src/driver.h
index 5136fb5..8101df3 100644
--- a/src/driver.h
+++ b/src/driver.h
@@ -351,7 +351,17 @@ typedef int
(virDomainPtr domain,
---
src/conf/domain_conf.c | 19 +++
src/conf/domain_conf.h |1 +
2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 010ce57..053f324 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@
Adds a optional element to XML definition of domains for
modification of link state of network interfaces.
---
docs/formatdomain.html.in | 21 +
docs/schemas/domain.rng | 11 +++
2 files changed, 32 insertions(+), 0 deletions(-)
diff --git
---
src/remote/remote_driver.c |2 ++
src/remote/remote_protocol.x | 21 -
src/remote_protocol-structs | 16
3 files changed, 38 insertions(+), 1 deletions(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index
This API adds methods to modify link state of virtual
interfaces of a domain.
Idea of this API is to enable simulation of unplugging
(virtual) cable from the machine to test networks or
to allow propagation of topology changes on the host.
---
include/libvirt/libvirt.h.in | 24
Hypervisors provide means for controling link state of virtual NICs. Ability
to control this can be usefully used for various aplications. These patches
add (or propose) an API for controling link states of these nics.
API functions added:
When the description of an entry is too long and needs multiple lines,
all other table cells of the same row are currently vertically aligned
on center. Without row borders or different background colors for
alternating rows this is hard to read.
Change the style-sheet to align the table cells of
---
src/libvirt.c | 122 +
1 files changed, 122 insertions(+), 0 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index c8af3e1..53b7a11 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -6421,6 +6421,128 @@ error:
}
/**
+ *
Adds support for QMP and text monitor access to qemu.
---
src/qemu/qemu_monitor.c | 19 +
src/qemu/qemu_monitor.h |3 ++
src/qemu/qemu_monitor_json.c | 23
src/qemu/qemu_monitor_json.h |4 +++
src/qemu/qemu_monitor_text.c | 47
Adds a capability flag based on version number to detect if qemu
supports setting link state.
---
src/qemu/qemu_capabilities.c |5 +
src/qemu/qemu_capabilities.h |1 +
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c
Adds support for the new API. While starting a qemu link state
cannot be set with an command line argument and therefore is done
by entering monitor.
---
src/qemu/qemu_driver.c | 228 +++
src/qemu/qemu_process.c | 37
2 files changed, 265
On 08/11/2011 02:28 AM, Daniel Veillard wrote:
On Thu, Aug 11, 2011 at 12:15:03AM -0400, Laine Stump wrote:
virNetworkDNSHostsDefParseXML was calling VIR_ALLOC(def-hosts) if
def-nhosts was 0. This is a waste of time, though, since
VIR_REALLOC_N is called a few lines further down, prior to any
On 07/26/2011 08:51 AM, Corey Bryant wrote:
+static int raw_open_fd(BlockDriverState *bs, const char *filename,
int flags)
+{
+BDRVRawState *s = bs-opaque;
+const char *fd_str;
+int fd;
+
+/* extract the file descriptor - fail if it's not fd: */
+if
On Thu, Aug 11, 2011 at 05:27:39PM +0200, Peter Krempa wrote:
Adds a optional element to XML definition of domains for
modification of link state of network interfaces.
---
docs/formatdomain.html.in | 21 +
docs/schemas/domain.rng | 11 +++
2 files changed,
On 08/11/2011 08:11 AM, Kevin Wolf wrote:
I agree with you. It feels a bit backwards for snapshots, but it's
really the only reasonable thing to do if you're using external
snapshots. That you can't rename block devices is actually a very point
point, too.
There's one more point to consider: If
On 08/10/2011 04:08 PM, Eric Blake wrote:
I'm not sure I covered this well earlier, but another useful definition is:
current snapshot - if this exists, it is the snapshot that would
become the parent if a new snapshot were created; or put another way, it
is the snapshot to which our current
On 08/11/2011 09:12 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
* remote.html.in: Remove obsolete notes about internals of the
RPC protocol
* internals/rpc.html.in: Extensive docs on RPC protocol/API
* sitemap.html.in: Add new page
---
On 08/11/2011 07:38 AM, Michal Novotny wrote:
Please ignore previous mails (done by my sendmail was not working fine
and please review this one instead).
It may have also been an issue of sendmail sending from a different
address, and your patches being stuck in the moderator queue waiting
On 08/11/2011 08:51 AM, Laine Stump wrote:
On 08/05/2011 11:14 AM, Eric Blake wrote:
}
} else if (flags VIR_DOMAIN_AFFECT_CONFIG) {
+ /* Clang can't see that if we get here, persistentDef was set. */
+ sa_assert(persistentDef);
+
for (i = 0; i nparams; i++) {
virTypedParameterPtr param
On 08/11/2011 12:23 AM, Daniel Veillard wrote:
On Wed, Aug 10, 2011 at 10:09:56PM -0600, Eric Blake wrote:
Down the road, I want to add virDomainSnapshotGetParent, and use
the new API rather than xml scraping; but this virsh command can
be implemented even without the new API.
* tools/virsh.c
On 08/11/2011 06:18 AM, Peter Krempa wrote:
Early errors during start of libvirtd didn't have
an error reporting mechanism and caused libvirtd
to exit silently (only the return value indicated
an error). This patch adds error messages printed
to stderr if verbose parameter is specified to the
On 08/11/2011 03:37 AM, Peter Krempa wrote:
After adding option to have directiories as storage volumes virsh reported
type of this storage volumes as 'file'. This patch fixes this type in data
structures and fixes the virsh output.
https://bugzilla.redhat.com/show_bug.cgi?id=727088
Peter
On 08/11/2011 06:44 AM, Philipp Hahn wrote:
Currently only tabs and blanks are used for tokenizing the description,
which breaks when a term is at the end of a line or has () appended to
it.
1. Use also other white space characters such as new-lines and carriage
return for splitting.
2.
On 08/11/2011 06:40 AM, Philipp Hahn wrote:
When the description of an entry is too long and needs multiple lines,
all other table cells of the same row are currently vertically aligned
on center. Without row borders or different background colors for
alternating rows this is hard to read.
On Thu, Aug 11, 2011 at 04:06:59PM +0200, Philipp Hahn wrote:
Hello,
On Thursday 11 August 2011 08:35:25 Philipp Hahn wrote:
While testing it I noticed the following behaviour:
1. Start virsh
2. Do qemu-monitor-command $SOME_VM info\ chardev to get the path of the
pty used for the
On 08/11/2011 06:50 AM, Philipp Hahn wrote:
Only the class CParser declares a method warning(), but the other
classes still try to call their self.warning() method, which fails.
Move the warning() functions to its own base classe and inherit from
s/classe/class/
that in all other classes.
On 08/11/2011 09:27 AM, Peter Krempa wrote:
Adds a optional element to XML definition of domains for
modification of link state of network interfaces.
---
docs/formatdomain.html.in | 21 +
docs/schemas/domain.rng | 11 +++
2 files changed, 32 insertions(+),
On 08/11/2011 09:27 AM, Peter Krempa wrote:
This API adds methods to modify link state of virtual
interfaces of a domain.
Idea of this API is to enable simulation of unplugging
(virtual) cable from the machine to test networks or
to allow propagation of topology changes on the host.
---
On 08/11/2011 09:27 AM, Peter Krempa wrote:
---
src/libvirt.c | 122 +
1 files changed, 122 insertions(+), 0 deletions(-)
For new API, I've lately been squashing the definition (libvirt.h.in,
patch 2/10), backend callback (driver.h
On 08/11/2011 09:27 AM, Peter Krempa wrote:
---
src/conf/domain_conf.c | 19 +++
src/conf/domain_conf.h |1 +
2 files changed, 20 insertions(+), 0 deletions(-)
This patch is useful, even without the new API.
@@ -3077,6 +3081,14 @@ virDomainNetDefParseXML(virCapsPtr
On 08/11/2011 09:27 AM, Peter Krempa wrote:
---
tools/virsh.c | 120 +++
tools/virsh.pod | 11 +
2 files changed, 131 insertions(+), 0 deletions(-)
Again, I think the new virsh commands can be useful, but would need to
map on
On 08/11/2011 09:27 AM, Peter Krempa wrote:
Adds support for QMP and text monitor access to qemu.
---
src/qemu/qemu_monitor.c | 19 +
src/qemu/qemu_monitor.h |3 ++
src/qemu/qemu_monitor_json.c | 23
src/qemu/qemu_monitor_json.h |4
On 08/11/2011 09:27 AM, Peter Krempa wrote:
Adds a capability flag based on version number to detect if qemu
supports setting link state.
---
src/qemu/qemu_capabilities.c |5 +
src/qemu/qemu_capabilities.h |1 +
2 files changed, 6 insertions(+), 0 deletions(-)
No testsuite
On 08/11/2011 09:27 AM, Peter Krempa wrote:
Adds support for the new API. While starting a qemu link state
cannot be set with an command line argument and therefore is done
by entering monitor.
---
src/qemu/qemu_driver.c | 228 +++
On 08/10/2011 04:08 PM, Eric Blake wrote:
Undefining
++
In one regards, undefining a domain that has snapshots is just as bad as
undefining a domain with managed save state - since libvirt is
maintaining metadata about snapshot hierarchies, leaving this metadata
behind _will_ interfere
On 08/11/2011 09:22 AM, Michal Novotny wrote:
Hi,
this is the second version of my patch to the bridge driver and
libvirt XML file to include support for the SRV records in the DNS.
The syntax is based on DNSMasq man page and tests for both xml2xml
and xml2argv were added as well.
Differences
On 08/11/2011 02:51 PM, Laine Stump wrote:
+
+ /* Following attributes are optional but we had to make sure their
NULL above */
s/their/they're/
Right, because VIR_REALLOC_N doesn't 0-fill the new memory (it doesn't
know how many there were before).
But VIR_EXPAND_N and VIR_RESIZE_N _do_
On 08/11/2011 02:50 PM, Eric Blake wrote:
On 08/10/2011 04:08 PM, Eric Blake wrote:
Undefining
++
Meanwhile, I propose changing the default behavior of
virDomainUndefine[Flags] to reject attempts to undefine a domain with
any defined snapshots, and to add a new flag for
The public API documents that undefine may be used to transition a
running persistent domain into a transient one. Many drivers still
do not support this usage, but virsh shouldn't be getting in the
way of those that do support it.
* tools/virsh.c (cmdUndefine): Allow undefine on active domains;
We forgot to add virDomainUndefineFlags for a couple of hypervisors.
This wires up trivial versions (since neither hypervisor supports
managed save yet, they do not need to support any flags).
* src/vbox/vbox_tmpl.c (vboxDomainCreateXML): Update caller.
(vboxDomainUndefine): Move guts...
On Thu, Aug 11, 2011 at 08:39:22PM -0600, Eric Blake wrote:
The public API documents that undefine may be used to transition a
running persistent domain into a transient one. Many drivers still
do not support this usage, but virsh shouldn't be getting in the
way of those that do support it.
On Thu, Aug 11, 2011 at 08:39:23PM -0600, Eric Blake wrote:
We forgot to add virDomainUndefineFlags for a couple of hypervisors.
This wires up trivial versions (since neither hypervisor supports
managed save yet, they do not need to support any flags).
* src/vbox/vbox_tmpl.c
On Thu, Aug 11, 2011 at 02:44:00PM +0200, Philipp Hahn wrote:
Currently only tabs and blanks are used for tokenizing the description,
which breaks when a term is at the end of a line or has () appended to
it.
1. Use also other white space characters such as new-lines and carriage
return
82 matches
Mail list logo
