---
lib/connectAPI.py |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/connectAPI.py b/lib/connectAPI.py
index 702a088..cfa4fea 100644
--- a/lib/connectAPI.py
+++ b/lib/connectAPI.py
@@ -44,7 +44,7 @@ class ConnectAPI(object):
def open(self, uri):
于 2011年08月16日 15:18, Wayne Sun 写道:
---
lib/connectAPI.py |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/connectAPI.py b/lib/connectAPI.py
index 702a088..cfa4fea 100644
--- a/lib/connectAPI.py
+++ b/lib/connectAPI.py
@@ -44,7 +44,7 @@ class
On 08/16/2011 03:18 PM, Wayne Sun wrote:
---
lib/connectAPI.py |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/connectAPI.py b/lib/connectAPI.py
index 702a088..cfa4fea 100644
--- a/lib/connectAPI.py
+++ b/lib/connectAPI.py
@@ -44,7 +44,7 @@ class
This is related to: https://bugzilla.redhat.com/show_bug.cgi?id=638633#c14
I had started to reply to it in the comments of the bug, but my reply
became too long, and expanded into an issue wider than that single bug,
so I figured I'd better discuss it here instead.
A synopsis: It's possible
* src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence
clang warning.
Detected by ccc-analyzer:
CC libvirt_driver_qemu_la-qemu_migration.lo
qemu/qemu_migration.c:2046:5: warning: Value stored to 'ret' is never read
ret = qemuMigrationConfirm(driver, sconn, vm,
^
I just tred compiling 0.9.4 and git head on Centos 6.0, for the
possible libvirt.org server replacement and it fails in both cases
with:
CC libvirtd-remote.o
remote.c: In function 'remoteDispatchAuthPolkit':
remote.c:2161: error: invalid initializer
This correspond to the following macro
On 08/16/2011 06:02 PM, Osier Yang wrote:
于 2011年08月16日 17:24, Alex Jia 写道:
* src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence
clang warning.
Detected by ccc-analyzer:
CC libvirt_driver_qemu_la-qemu_migration.lo
qemu/qemu_migration.c:2046:5: warning: Value stored
于 2011年08月16日 17:24, Alex Jia 写道:
* src/qemu/qemu_migration.c: avoid dead 'ret' assignment and silence
clang warning.
Detected by ccc-analyzer:
CC libvirt_driver_qemu_la-qemu_migration.lo
qemu/qemu_migration.c:2046:5: warning: Value stored to 'ret' is never read
ret =
When virStreamAbort is called on a stream that has not been used yet,
quite confusing error is returned: this function is not supported by
the connection driver. Let's just ignore such streams as there's
nothing to abort anyway.
---
src/libvirt.c |8 ++--
1 files changed, 6 insertions(+),
If migration failed on source daemon, the migration is automatically
canceled by the daemon itself. Thus we don't need to call
virDomainMigrateConfirm3(cancelled=1). Calling it doesn't cause any harm
but the resulting error message printed in logs may confuse people.
---
src/libvirt.c | 41
This patch prints file name of currently parsed document
if an parse error occurs. While parsing XML documments from
string, user may specify NULL as URL and the original error message
(not containing filename information) is printed.
Fixes BZ #726771
---
src/util/xml.c | 16
Patch a53ab1094e93f1b6d93ad9be63d8ccc5fd19a2a9 introduces printing
file name on XML errors. This corrects the URL string to be NULL and
therefrore to print an error message not containing bogus filename
domain.xml.
---
src/conf/domain_conf.c|2 +-
src/security/virt-aa-helper.c |2
On 08/15/2011 09:21 AM, Daniel Veillard wrote:
On Sun, Aug 14, 2011 at 03:43:52AM -0400, Laine Stump wrote:
In some versions of qemu, both virtio-blk-pci and virtio-net-pci
devices can have an event_idx setting that determines some details of
event processing. When it is enabled, it reduces the
On 08/12/2011 07:25 AM, Michal Novotny wrote:
Hi,
this is the third version of my patch to the bridge driver and
libvirt XML file to include support for the SRV records in the DNS.
The syntax is based on DNSMasq man page and tests for both xml2xml
and xml2argv were added as well.
Differences
On 08/14/2011 10:49 AM, Zdenek Styblik wrote:
On 08/14/11 16:17, Zdenek Styblik wrote:
Hi,
I've noticed libvirt is persisting to have dnsmasq present and use it.
Version of libvirt in question is 0.9.4.
There is no dnsmasq present on the Host during libvirt compilation, yet
it seems to me
On 08/11/2011 04:08 PM, Eric Blake wrote:
On 08/11/2011 09:27 AM, Peter Krempa wrote:
---
src/libvirt.c | 122
+
1 files changed, 122 insertions(+), 0 deletions(-)
For new API, I've lately been squashing the definition
Hi Daniel,
On Sat, Aug 13, 2011 at 08:57:45PM -0700, Daniel P. Berrange wrote:
On Fri, Aug 12, 2011 at 11:54:28PM +0200, Guido Günther wrote:
[..snip..]
In the default libvirt event loop, the 'ff' callback is always invoked
from a clean stack in the event loop, so you never have this problem
On 16/08/2011, at 1:04 PM, Hu Tao wrote:
On Tue, Jul 26, 2011 at 11:03:52AM +0800, Hu Tao wrote:
Hi,
We now have libvirt advanced at 0.9.3, but there is almost no
progress has been made on Virsh Command Reference. I'm now
starting on updating Virsh Command Reference to get it synced
On 08/16/2011 07:34 AM, Justin Clift wrote:
On 16/08/2011, at 1:04 PM, Hu Tao wrote:
On Tue, Jul 26, 2011 at 11:03:52AM +0800, Hu Tao wrote:
Hi,
We now have libvirt advanced at 0.9.3, but there is almost no
progress has been made on Virsh Command Reference.
For future reference, it
On 08/16/2011 03:57 AM, Daniel Veillard wrote:
I just tred compiling 0.9.4 and git head on Centos 6.0, for the
possible libvirt.org server replacement and it fails in both cases
with:
CC libvirtd-remote.o
remote.c: In function 'remoteDispatchAuthPolkit':
remote.c:2161: error: invalid
On 08/15/2011 10:28 PM, Osier Yang wrote:
于 2011年08月16日 00:40, Adam Litke 写道:
Hi Osier,
Just to be clear, this is a cleanup not a bugfix right? The current
code should be working properly as written.
No, virDomainMemoryStats will return empty result if libvirt
communicates to qemu
We don't allow to define domain with same name and different UUID,
or with same UUID, so it's reasonable to not load the domain config
if there is domain with same name already exists.
Otherwise it can cause problem like:
1) % cp /etc/libvirt/qemu/dom.xml /etc/libvirt/qemu/dom_diffuuid.xml
2)
On 08/16/2011 04:44 AM, Jiri Denemark wrote:
When virStreamAbort is called on a stream that has not been used yet,
quite confusing error is returned: this function is not supported by
the connection driver. Let's just ignore such streams as there's
nothing to abort anyway.
---
src/libvirt.c |
On 08/16/2011 04:44 AM, Jiri Denemark wrote:
If migration failed on source daemon, the migration is automatically
canceled by the daemon itself. Thus we don't need to call
virDomainMigrateConfirm3(cancelled=1). Calling it doesn't cause any harm
but the resulting error message printed in logs may
On 08/16/2011 04:02 AM, Osier Yang wrote:
+++ b/src/qemu/qemu_migration.c
@@ -2050,6 +2050,9 @@ finish:
* do, but fortunately worst case is that there is a
* domain left in 'paused' state on source.
*/
+ if (ret 0)
+ VIR_WARN(Guest %s probably left in 'paused' state on source,
+ vm-def-name);
Stefan has a git repo with QED block streaming support here:
git://repo.or.cz/qemu/stefanha.git stream-command
On 08/15/2011 08:25 PM, Zhi Yong Wu wrote:
On Mon, Aug 15, 2011 at 8:36 PM, Adam Litke a...@us.ibm.com wrote:
On 08/14/2011 11:40 PM, Zhi Yong Wu wrote:
HI, Deniel and Adam.
Have
On 08/16/2011 06:49 AM, Peter Krempa wrote:
This patch prints file name of currently parsed document
if an parse error occurs. While parsing XML documments from
string, user may specify NULL as URL and the original error message
(not containing filename information) is printed.
Fixes BZ #726771
On 08/16/2011 04:37 PM, Eric Blake wrote:
On 08/16/2011 06:49 AM, Peter Krempa wrote:
This patch prints file name of currently parsed document
if an parse error occurs. While parsing XML documments from
string, user may specify NULL as URL and the original error message
(not containing filename
This patch prints file name of currently parsed document
if an parse error occurs. While parsing XML documments from
string, user may specify NULL as URL and the original error message
(not containing filename information) is printed.
Fixes BZ #726771
---
src/util/xml.c | 16
On 08/16/2011 06:49 AM, Peter Krempa wrote:
Patch a53ab1094e93f1b6d93ad9be63d8ccc5fd19a2a9 introduces printing
file name on XML errors. This corrects the URL string to be NULL and
therefrore to print an error message not containing bogus filename
s/therefrore/therefore/
domain.xml.
---
Patch facb914fead15fccb43122db3357dd62ad909522 introduces printing
file name on XML errors. This corrects the URL string to be NULL and
therefrore to print an error message not containing bogus filename
domain.xml.
---
src/conf/domain_conf.c|2 +-
src/security/virt-aa-helper.c |2
On 08/16/2011 09:05 AM, Osier Yang wrote:
We don't allow to define domain with same name and different UUID,
or with same UUID, so it's reasonable to not load the domain config
if there is domain with same name already exists.
Otherwise it can cause problem like:
1) % cp
On 08/16/2011 04:52 PM, Peter Krempa wrote:
This patch prints file name of currently parsed document
if an parse error occurs. While parsing XML documments from
string, user may specify NULL as URL and the original error message
(not containing filename information) is printed.
Fixes BZ #726771
On 08/16/2011 12:28 AM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch moves some of the sriov related pci code from node_device driver
to src/util/pci.[ch]. Some functions had to go thru name and argument list
change to accommodate the move.
Signed-off-by: Roopa
Patch facb914fead15fccb43122db3357dd62ad909522 introduces printing
file name on XML errors. This corrects the URL string to be NULL and
therefore to print an error message not containing bogus filename
domain.xml.
---
src/conf/domain_conf.c|2 +-
src/security/virt-aa-helper.c |2
On 08/16/2011 04:53 PM, Eric Blake wrote:
On 08/16/2011 06:49 AM, Peter Krempa wrote:
Patch a53ab1094e93f1b6d93ad9be63d8ccc5fd19a2a9 introduces printing
file name on XML errors. This corrects the URL string to be NULL and
therefrore to print an error message not containing bogus filename
On 08/16/2011 12:28 AM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch renames getPhysfn to getPhysfnDev and adds code to get the
Physical function and Virtual Function index of the direct attach linkdev (if
the direct attach interface is a SRIOV VF). The idea is to send
On 08/16/2011 12:28 AM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch adds the following helper functions:
pciDeviceIsVirtualFunction: Function to check if a pci device is a sriov VF
pciGetVirtualFunctionIndex: Function to get the VF index of a sriov VF
pciDeviceNetName:
On 08/16/2011 12:28 AM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch adds the following functions to get PF/VF relationship of an SRIOV
network interface:
ifaceIsVirtualFunction: Function to check if a network interface is a SRIOV VF
ifaceGetVirtualFunctionIndex: Function
This patch prints file name of currently parsed document
if an parse error occurs. While parsing XML documments from
string, user may specify NULL as URL and the original error message
(not containing filename information) is printed.
Fixes BZ #726771
---
src/util/xml.c | 16
On Tue, Aug 16, 2011 at 02:24:53PM +0200, Guido Günther wrote:
Hi Daniel,
On Sat, Aug 13, 2011 at 08:57:45PM -0700, Daniel P. Berrange wrote:
On Fri, Aug 12, 2011 at 11:54:28PM +0200, Guido Günther wrote:
[..snip..]
In the default libvirt event loop, the 'ff' callback is always invoked
On Tue, Aug 16, 2011 at 09:15:12AM -0400, Laine Stump wrote:
On 08/14/2011 10:49 AM, Zdenek Styblik wrote:
On 08/14/11 16:17, Zdenek Styblik wrote:
Hi,
I've noticed libvirt is persisting to have dnsmasq present and use it.
Version of libvirt in question is 0.9.4.
There is no dnsmasq
On Tue, Aug 16, 2011 at 09:28:27AM +0800, Zhi Yong Wu wrote:
On Tue, Aug 16, 2011 at 6:52 AM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Mon, Aug 15, 2011 at 1:36 PM, Adam Litke a...@us.ibm.com wrote:
On 08/14/2011 11:40 PM, Zhi Yong Wu wrote:
HI, Deniel and Adam.
Have the patchset
On Tue, Aug 16, 2011 at 08:13:07AM -0600, Eric Blake wrote:
On 08/16/2011 07:34 AM, Justin Clift wrote:
On 16/08/2011, at 1:04 PM, Hu Tao wrote:
On Tue, Jul 26, 2011 at 11:03:52AM +0800, Hu Tao wrote:
Hi,
We now have libvirt advanced at 0.9.3, but there is almost no
progress has been
On Tue, Aug 16, 2011 at 04:44:42AM -0400, Laine Stump wrote:
This is related to: https://bugzilla.redhat.com/show_bug.cgi?id=638633#c14
I had started to reply to it in the comments of the bug, but my
reply became too long, and expanded into an issue wider than that
single bug, so I figured
On 08/12/11 16:18, Christophe Fergeau wrote:
On Fri, Aug 12, 2011 at 04:53:04PM +0300, Alon Levy wrote:
I don't know when libvirt started adding mf=on.
For what it's worth, this was added in
[ adding libvirt list to cc: ]
commit 9f8baf646ea44aa2de47cba5002af39a7ab1ac08
Author: Wen
Visit it! Its cool and fantastic!.
http://hosting.nborges.net/com.page.php?gusiteid=65o5
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 08/16/2011 12:28 AM, Roopa Prabhu wrote:
This patch tries to fix getPhysFn in macvtap.c to get the physical
function(PF) of the direct attach interface, if the interface is a SR-IOV VF.
It moves some of the sriov pci device handling code from node_device_driver
to src/util/pci.[ch].
This
On 08/16/11 15:15, Laine Stump wrote:
On 08/14/2011 10:49 AM, Zdenek Styblik wrote:
On 08/14/11 16:17, Zdenek Styblik wrote:
Hi,
I've noticed libvirt is persisting to have dnsmasq present and
use it. Version of libvirt in question is 0.9.4.
There is no dnsmasq present on the Host during
On 08/16/11 17:38, Daniel P. Berrange wrote:
On Tue, Aug 16, 2011 at 09:15:12AM -0400, Laine Stump wrote:
On 08/14/2011 10:49 AM, Zdenek Styblik wrote:
On 08/14/11 16:17, Zdenek Styblik wrote:
Hi,
I've noticed libvirt is persisting to have dnsmasq present and use it.
Version of libvirt in
Add missing symbols to libvirt_private.syms.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
---
src/libvirt_private.syms |8
1 file changed, 8 insertions(+)
Index: libvirt-acl/src/libvirt_private.syms
===
On 08/16/2011 10:16 AM, Stefan Berger wrote:
Add missing symbols to libvirt_private.syms.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
---
src/libvirt_private.syms | 8
1 file changed, 8 insertions(+)
ACK.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt
This patch creates an optional BeginJob queue size limit. When
active, all other attempts above level will fail. To set this
feature assign desired value to max_queued variable in qemu.conf.
Setting it to 0 turns it off.
---
src/qemu/libvirtd_qemu.aug |1 +
src/qemu/qemu.conf |7
If there is an unresponsive qemu process and libvirt access
it's monitor, it will not get any response and this thread will
block indefinitely, until the qemu process resumes or it's destroyed.
If users continues executing APIs against that domain, libvirt will
run out of worker threads and hangs
If libvirt daemon gets restarted and there is (at least) one
unresponsive qemu, the startup procedure hangs up. This patch creates
one thread per vm in which we try to reconnect to monitor. Therefore,
blocking in one thread will not affect other APIs.
---
src/qemu/qemu_driver.c | 23
This patch annotates APIs with low or high priority.
In low set MUST be all APIs which might eventually access monitor
(and thus block indefinitely). Other APIs may be marked as high
priority. However, some must be (e.g. domainDestroy).
For high priority calls (HPC), there is new thread pool
On 08/13/2011 02:54 AM, Tom Vijlbrief wrote:
A virsh command like:
migrate --live --copy-storage-all Guest qemu+ssh://user@host/system
--persistent --verbose
shows
Migration: [ 0 %]
during the storage copy and does not start counting
untill the ram transfer starts
Patch for including the
On 08/12/2011 04:31 AM, Radek Hladik wrote:
Hi,
I've noticed newer version of curl in last qemu changelog. It seems that
its needed for curl block device. Unfortunatelly, I was not able to find
out more. I tried to look into qemu source code and to some patches but
I am not much wiser.
As I
On 08/12/2011 05:41 AM, Peter Krempa wrote:
Early errors during start of libvirtd didn't have
an error reporting mechanism and caused libvirtd
to exit silently (only the return value indicated
an error).
Libvirt logging is initialized very early using
enviroment variables and the internal error
On 08/16/11 18:07, Zdenek Styblik wrote:
[...]
Well, libvirt.spec has had Require: dnsmasq for at least a couple
years, so any install of a libvirt rpm should fail when dnsmasq
isn't present. I don't know for certain how long the BuildRequires:
dnsmasq has been there, but certainly for at
This patch fixes *some* compilation issues on non-Linux platforms (cygwin).
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
diff --git a/src/util/interface.c b/src/util/interface.c
index aec12f5..5d473b7 100644
--- a/src/util/interface.c
+++ b/src/util/interface.c
@@ -1317,7 +1317,7 @@
On 8/16/11 9:02 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 08/16/2011 12:28 AM, Roopa Prabhu wrote:
This patch tries to fix getPhysFn in macvtap.c to get the physical
function(PF) of the direct attach interface, if the interface is a SR-IOV VF.
It moves some of the sriov pci
On 08/16/2011 11:19 AM, Stefan Berger wrote:
s/main/maint/ in the subject line.
This patch fixes *some* compilation issues on non-Linux platforms (cygwin).
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
int
-pciDeviceNetName(char *device_link_sysfs_path, char **netname)
On 08/16/2011 11:29 AM, Eric Blake wrote:
+++ b/src/util/virpidfile.c
@@ -213,6 +213,8 @@ int virPidFileReadPathIfAlive(const char *path,
#ifdef __linux__
if (virFileLinkPointsTo(procpath, binpath) == 0)
*pid = -1;
+#else
+ (void)binpath;
#endif
Here, I'd rather mark binpath as
2011/8/16 Zdenek Styblik sty...@turnovfree.net:
On 08/16/11 18:07, Zdenek Styblik wrote:
[...]
Well, libvirt.spec has had Require: dnsmasq for at least a couple
years, so any install of a libvirt rpm should fail when dnsmasq
isn't present. I don't know for certain how long the BuildRequires:
From: Daniel P. Berrange berra...@redhat.com
If a stream gets a server initiated abort, the client may still
send an abort request before it receives the server side abort.
This causes the server to send back another abort for the
stream. Since the protocol defines that abort is the last thing
to
On 08/16/2011 01:35 PM, Eric Blake wrote:
On 08/16/2011 11:29 AM, Eric Blake wrote:
+++ b/src/util/virpidfile.c
@@ -213,6 +213,8 @@ int virPidFileReadPathIfAlive(const char *path,
#ifdef __linux__
if (virFileLinkPointsTo(procpath, binpath) == 0)
*pid = -1;
+#else
+ (void)binpath;
#endif
Here,
On 08/16/2011 12:04 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
If a stream gets a server initiated abort, the client may still
send an abort request before it receives the server side abort.
This causes the server to send back another abort for the
stream. Since
On Tue, Aug 16, 2011 at 11:02:23AM -0600, Eric Blake wrote:
On 08/12/2011 04:31 AM, Radek Hladik wrote:
Hi,
I've noticed newer version of curl in last qemu changelog. It seems that
its needed for curl block device. Unfortunatelly, I was not able to find
out more. I tried to look into qemu
On 08/16/2011 12:07 PM, Stefan Berger wrote:
I split this off and pushed the rest.
If procfs's are different, then maybe we should use #if
PROCFS_PID_EXE_LINK_AVAIL here.
Seems like a reasonable name.
What is needed in this case seems to be that /proc/pid/exe is a
symbolic link to the
On Mon, Aug 15, 2011 at 02:19:27PM -0400, Dave Allan wrote:
On Mon, Aug 15, 2011 at 10:12:54AM -0700, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
After running 'virsh console' in interactive mode, there was a
missing call to virStreamAbort, which meant the
On 08/16/2011 02:14 PM, Eric Blake wrote:
On 08/16/2011 12:07 PM, Stefan Berger wrote:
I split this off and pushed the rest.
If procfs's are different, then maybe we should use #if
PROCFS_PID_EXE_LINK_AVAIL here.
Seems like a reasonable name.
What is needed in this case seems to be that
On 08/16/11 20:00, Matthias Bolte wrote:
2011/8/16 Zdenek Styblik sty...@turnovfree.net:
On 08/16/11 18:07, Zdenek Styblik wrote:
[...]
Well, libvirt.spec has had Require: dnsmasq for at least a couple
years, so any install of a libvirt rpm should fail when dnsmasq
isn't present. I don't
On Tue, Aug 16, 2011 at 11:15:04AM -0700, Daniel P. Berrange wrote:
On Mon, Aug 15, 2011 at 02:19:27PM -0400, Dave Allan wrote:
On Mon, Aug 15, 2011 at 10:12:54AM -0700, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
After running 'virsh console' in interactive
On 08/16/2011 02:34 PM, Stefan Berger wrote:
On 08/16/2011 02:14 PM, Eric Blake wrote:
On 08/16/2011 12:07 PM, Stefan Berger wrote:
I split this off and pushed the rest.
If procfs's are different, then maybe we should use #if
PROCFS_PID_EXE_LINK_AVAIL here.
Seems like a reasonable name.
On 08/16/2011 01:01 PM, Stefan Berger wrote:
Following the latter couldn't it just be handled during runtime
altogether?
That actually sounds better.
Stefan
Along those lines I propose this patch below:
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
+int virFileIsLink(const
On 08/16/2011 02:00 PM, Matthias Bolte wrote:
2011/8/16 Zdenek Stybliksty...@turnovfree.net:
On 08/16/11 18:07, Zdenek Styblik wrote:
[...]
Well, libvirt.spec has had Require: dnsmasq for at least a couple
years, so any install of a libvirt rpm should fail when dnsmasq
isn't present. I don't
On 08/16/2011 11:47 AM, Daniel P. Berrange wrote:
On Tue, Aug 16, 2011 at 04:44:42AM -0400, Laine Stump wrote:
This is related to: https://bugzilla.redhat.com/show_bug.cgi?id=638633#c14
I had started to reply to it in the comments of the bug, but my
reply became too long, and expanded into an
On Tue, Aug 16, 2011 at 08:33:04 -0600, Eric Blake wrote:
On 08/16/2011 04:44 AM, Jiri Denemark wrote:
If migration failed on source daemon, the migration is automatically
canceled by the daemon itself. Thus we don't need to call
virDomainMigrateConfirm3(cancelled=1). Calling it doesn't
On 08/16/2011 03:25 PM, Eric Blake wrote:
On 08/16/2011 01:01 PM, Stefan Berger wrote:
Following the latter couldn't it just be handled during runtime
altogether?
That actually sounds better.
Stefan
Along those lines I propose this patch below:
Signed-off-by: Stefan Berger
I was testing a virsh patch, and wanted to see if I had passed the
flags I thought. But with LIBVIRT_DEBUG in the environment, I just
saw:
14:24:52.359: 15022: debug : virDomainSnapshotNum:15586 : dom=0xc9c180, (VM:
name=rhel_6-64, uuid=48f8e8e7-e14f-0e14-02f0-ce71997bdcab),
including a
On 08/15/2011 05:33 PM, Eric Blake wrote:
Filtering for roots is pretty easy to do.
@@ -11180,6 +11181,8 @@ static void virDomainSnapshotObjListCopyNames(void
*payload,
if (data-oom)
return;
+if ((data-flags VIR_DOMAIN_SNAPSHOT_LIST_ROOTS) !obj-def-parent)
+
New flag bits are worth exposing via virsh. Additionally, even
though I recently added 'virsh snapshot-parent', doing it one
snapshot at a time is painful, so make it possible to expand the
snapshot-list table at once. In the case of snapshot-list --roots,
it's possible to emulate this even when
On 08/15/2011 05:33 PM, Eric Blake wrote:
Just as leaving managed save metadata behind can cause problems
when creating a new domain that happens to collide with the name
of the just-deleted domain, the same is true of leaving any
snapshot metadata behind. For safety sake, extend the semantic
On Mon, Aug 08, 2011 at 13:48:59 +0200, Jiri Denemark wrote:
Hi,
AFAIK this topic is not new but I think we still do not have a good solution
for it. Libvirt already supports specifying what CPU and its features a guest
should see but imagine one wants to run a guest on the best possible
On Tue, Aug 16, 2011 at 03:29:04PM -0400, Laine Stump wrote:
On 08/16/2011 11:47 AM, Daniel P. Berrange wrote:
On Tue, Aug 16, 2011 at 04:44:42AM -0400, Laine Stump wrote:
This is related to: https://bugzilla.redhat.com/show_bug.cgi?id=638633#c14
I had started to reply to it in the comments
On 08/15/2011 05:33 PM, Eric Blake wrote:
Audit all changes to the qemu vm-current_snapshot, and make them
update the saved xml file for both the previous and the new
snapshot, so that there is always at most one snapshot with
active1/active in the xml, and that snapshot is used as the
current
On Tue, Aug 16, 2011 at 18:39:12 +0200, Michal Privoznik wrote:
If libvirt daemon gets restarted and there is (at least) one
unresponsive qemu, the startup procedure hangs up. This patch creates
one thread per vm in which we try to reconnect to monitor. Therefore,
blocking in one thread will
On Tue, Aug 16, 2011 at 10:55:32PM +0200, Jiri Denemark wrote:
On Mon, Aug 08, 2011 at 13:48:59 +0200, Jiri Denemark wrote:
Hi,
AFAIK this topic is not new but I think we still do not have a good solution
for it. Libvirt already supports specifying what CPU and its features a
guest
Hi all,
Currently when we start a non-tunneled migration, data go straight from
source qemu to destination qemu. This is nice in that there is no additional
overhead but it also has several disadvantages. If the communication between
source and destination qemu breaks, we only get unexpected
On Tue, Aug 16, 2011 at 17:46:43 -0400, Dave Allan wrote:
On Tue, Aug 16, 2011 at 10:55:32PM +0200, Jiri Denemark wrote:
On Mon, Aug 08, 2011 at 13:48:59 +0200, Jiri Denemark wrote:
Hi,
AFAIK this topic is not new but I think we still do not have a good
solution
for it. Libvirt
Reverting to a state prior to an external snapshot risks
corrupting any other branches in the snapshot hierarchy that
were using the snapshot as a read-only backing file. So
disk snapshot code will default to preventing reverting to
a snapshot that has any children, meaning that deleting just
the
On Tue, Aug 16, 2011 at 11:53:04PM +0200, Jiri Denemark wrote:
Hi all,
Currently when we start a non-tunneled migration, data go straight from
source qemu to destination qemu. This is nice in that there is no additional
overhead but it also has several disadvantages. If the communication
On Tue, Aug 16, 2011 at 05:46:43PM -0400, Dave Allan wrote:
On Tue, Aug 16, 2011 at 10:55:32PM +0200, Jiri Denemark wrote:
On Mon, Aug 08, 2011 at 13:48:59 +0200, Jiri Denemark wrote:
Hi,
AFAIK this topic is not new but I think we still do not have a good
solution
for it.
On Tue, Aug 16, 2011 at 03:46:23PM -0700, Daniel P. Berrange wrote:
On Tue, Aug 16, 2011 at 05:46:43PM -0400, Dave Allan wrote:
On Tue, Aug 16, 2011 at 10:55:32PM +0200, Jiri Denemark wrote:
On Mon, Aug 08, 2011 at 13:48:59 +0200, Jiri Denemark wrote:
Hi,
AFAIK this topic is not
It would technically be possible to have virsh compute the list
of descendants of a given snapshot, then delete those one at
a time. But it's complex, and not worth writing for a first
cut at implementing the new flags.
* tools/virsh.c (cmdSnapshotDelete): Add --children-only,
--metadata.
*
Fixes confusion introduced in commit 98369d3.
* tools/virsh.c (cmdSnapshotParent): Operates on named snapshot,
not current.
---
virsh.pod got it right. I'm pushing this under the trivial rule.
tools/virsh.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
On Mon, Aug 08, 2011 at 01:48:59PM +0200, Jiri Denemark wrote:
Hi,
AFAIK this topic is not new but I think we still do not have a good solution
for it. Libvirt already supports specifying what CPU and its features a guest
should see but imagine one wants to run a guest on the best possible
From: Daniel P. Berrange berra...@redhat.com
If a client had initiated a stream abort, it will have a call
waiting for a reply in the queue. If more data continues to
arrive on the stream, the abort command could mistakenly get
signalled as complete. Remove the code from async data processing
From: Daniel P. Berrange berra...@redhat.com
The I/O event callback processes incoming packets first, and then
does outgoing packets. If the incoming packet caused the stream to
close, then the attempt to process outgoing data resulted in an
error. This caused libvirt to then send an error back
1 - 100 of 110 matches
Mail list logo
