Re: [libvirt] [PATCH] Fix tracking of RPC messages wrt streams

2011-09-01 Thread Daniel Veillard
On Wed, Aug 31, 2011 at 11:06:38AM -0600, Eric Blake wrote: On 08/31/2011 10:48 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Commit 2c85644b0b51fbe5b6244e6773531af29933a727 attempted to fix a problem with tracking RPC messages from streams by doing -

Re: [libvirt] [RFC] Create ptmx as a device

2011-09-01 Thread Daniel Veillard
On Wed, Aug 31, 2011 at 01:18:33PM -0500, Serge Hallyn wrote: Hi, I'm seeing an issue with udev and libvirt-lxc. Libvirt-lxc creates /dev/ptmx as a symlink to /dev/pts/ptmx. When udev starts up, it checks the device type, sees ptmx is 'not right', and replaces it with a 'proper' ptmx.

[libvirt] [PATCH] conf: Substitute OPERATION_INVALID with INTERNAL_ERROR

2011-09-01 Thread Osier Yang
--- src/conf/node_device_conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 4803e2a..6b0ef50 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -1277,7 +1277,7 @@

[libvirt] [PATCH] lxc: Fix incorrect changes on error codes.

2011-09-01 Thread Osier Yang
Fix incorrect changes introduced by commit 6ac47762bb9. --- src/lxc/lxc_driver.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 5587b06..6b716c1 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -1786,7

Re: [libvirt] [PATCH 1/2] make remote_exec_pexpect return the output of command

2011-09-01 Thread Guannan Ren
On 09/01/2011 10:19 AM, Guannan Ren wrote: *utils/Python/utils.py return 0,child.before intead *repos/remoteAccess/tcp_setup.py repos/remoteAccess/tls_setup.py switch over to use new remote_exec_pexpect() --- repos/remoteAccess/tcp_setup.py | 18 +-

[libvirt] [PATCH] nodeinfo: Fix incorrect error codes

2011-09-01 Thread Osier Yang
Introduced by 5e495c8b, except the ones for checking if numa is supported by host, all the NO_SUPPORT are changed back. For the ones about numa checking, change them into INTERNAL_ERROR. --- src/nodeinfo.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [libvirt] [PATCH 3/8] nodeinfo: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-09-01 Thread Osier Yang
于 2011年08月25日 05:48, Daniel P. Berrange 写道: On Tue, Aug 23, 2011 at 05:39:40PM +0800, Osier Yang wrote: --- src/nodeinfo.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index cae2564..b21e555 100644 ---

[libvirt] [PATCH] Source control for storage pool

2011-09-01 Thread Lei Li
Fix bug #611823 storage driver should prohibit pools with duplicate underlying storage. Add API virStoragePoolSourceFindDuplicate() to do uniqueness check based on source location infomation for pool type. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/conf/storage_conf.c | 73

Re: [libvirt] [PATCH] Fix tracking of RPC messages wrt streams

2011-09-01 Thread Guannan Ren
On 09/01/2011 12:48 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Commit 2c85644b0b51fbe5b6244e6773531af29933a727 attempted to fix a problem with tracking RPC messages from streams by doing -if (msg-header.type == VIR_NET_REPLY) { +if

Re: [libvirt] [PATCH 4/8] qemu: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-09-01 Thread Osier Yang
于 2011年08月25日 05:47, Daniel P. Berrange 写道: On Tue, Aug 23, 2011 at 05:39:41PM +0800, Osier Yang wrote: * src/qemu/qemu_command.c: s/VIR_ERR_NO_SUPPORT/VIR_ERR_CONFIG_UNSUPPORTED/ * src/qemu/qemu_driver.c: s/VIR_ERR_NO_SUPPORT/VIR_ERR_OPERATION_INVALID/ * src/qemu/qemu_process.c:

[libvirt] [PATCH] remote: Fix incorrect error codes

2011-09-01 Thread Osier Yang
Introduced by d4b53ef6c. For no internalFlags support, the error code is changed into INTERNAL_ERROR. --- src/remote/remote_driver.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 603d589..79fcac0 100644

Re: [libvirt] [PATCH 6/8] storage: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-09-01 Thread Osier Yang
于 2011年08月25日 05:42, Daniel P. Berrange 写道: On Tue, Aug 23, 2011 at 05:39:43PM +0800, Osier Yang wrote: --- src/storage/storage_backend.c | 12 ++-- src/storage/storage_backend_disk.c|2 +- src/storage/storage_backend_fs.c |2 +-

[libvirt] [PATCH] storage: Fix incorrect error codes

2011-09-01 Thread Osier Yang
Commit 0376f4a69b intended to fix incorrect use of VIR_ERR_NO_SUPPORT, but replacing it with VIR_ERR_OPERATION_INVALID is not proper either. --- src/storage/storage_backend.c | 12 ++-- src/storage/storage_backend_disk.c|2 +- src/storage/storage_backend_fs.c |2

Re: [libvirt] [PATCH 6/8] storage: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-09-01 Thread Osier Yang
于 2011年09月01日 15:20, Osier Yang 写道: 于 2011年08月25日 05:42, Daniel P. Berrange 写道: On Tue, Aug 23, 2011 at 05:39:43PM +0800, Osier Yang wrote: --- src/storage/storage_backend.c | 12 ++-- src/storage/storage_backend_disk.c|2 +- src/storage/storage_backend_fs.c

[libvirt] [PATCH] Revert test: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-09-01 Thread Osier Yang
This reverts commit 172214bd304ff958160307be2efd6614e9868946. --- src/test/test_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 3dfe305..b3e24b4 100644 --- a/src/test/test_driver.c +++

[libvirt] [PATCH] xen: Fix incorrect use of error codes

2011-09-01 Thread Osier Yang
Commit d07aa6a96 intended to fix incorrect use of VIR_ERR_NO_SUPPORT, but some of the changes are not proper, this patch fixes the problems. --- src/xen/xen_hypervisor.c |4 ++-- src/xen/xend_internal.c | 12 ++-- src/xen/xm_internal.c|3 +-- 3 files changed, 9

Re: [libvirt] [PATCH 4/8] qemu: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-09-01 Thread Matthias Bolte
2011/9/1 Osier Yang jy...@redhat.com: 于 2011年08月25日 05:47, Daniel P. Berrange 写道: On Tue, Aug 23, 2011 at 05:39:41PM +0800, Osier Yang wrote: * src/qemu/qemu_command.c: s/VIR_ERR_NO_SUPPORT/VIR_ERR_CONFIG_UNSUPPORTED/ * src/qemu/qemu_driver.c:

Re: [libvirt] [RFC] block I/O throttling: how to enable in libvirt

2011-09-01 Thread Stefan Hajnoczi
On Thu, Sep 01, 2011 at 01:05:31PM +0800, Zhi Yong Wu wrote: On Wed, Aug 31, 2011 at 08:18:19AM +0100, Stefan Hajnoczi wrote: On Tue, Aug 30, 2011 at 2:46 PM, Adam Litke a...@us.ibm.com wrote: On Tue, Aug 30, 2011 at 09:53:33AM +0100, Stefan Hajnoczi wrote: I/O throttling can be applied

[libvirt] [PATCH] qemu: Fix a regression of domain save

2011-09-01 Thread Osier Yang
* src/qemu/qemu_driver.c - qemuDomainSaveInternal: Return directly will keep the domain object locked. --- src/qemu/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4e8c691..a150b08 100644 ---

Re: [libvirt] [PATCH] qemu: Fix a regression of domain save

2011-09-01 Thread Osier Yang
于 2011年09月01日 16:14, Osier Yang 写道: * src/qemu/qemu_driver.c - qemuDomainSaveInternal: Return directly will keep the domain object locked. To be more descriptive, will add the commit which introduces the regression when commit. --- src/qemu/qemu_driver.c |2 +- 1 files changed, 1

Re: [libvirt] [PATCH 4/8] qemu: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-09-01 Thread Osier Yang
于 2011年09月01日 16:04, Matthias Bolte 写道: 2011/9/1 Osier Yangjy...@redhat.com: 于 2011年08月25日 05:47, Daniel P. Berrange 写道: On Tue, Aug 23, 2011 at 05:39:41PM +0800, Osier Yang wrote: * src/qemu/qemu_command.c: s/VIR_ERR_NO_SUPPORT/VIR_ERR_CONFIG_UNSUPPORTED/ * src/qemu/qemu_driver.c:

Re: [libvirt] [PATCH] qemu: Fix a regression of domain save

2011-09-01 Thread Daniel Veillard
On Thu, Sep 01, 2011 at 04:14:13PM +0800, Osier Yang wrote: * src/qemu/qemu_driver.c - qemuDomainSaveInternal: Return directly will keep the domain object locked. --- src/qemu/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [RFC] block I/O throttling: how to enable in libvirt

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 09:11:49AM +0100, Stefan Hajnoczi wrote: On Thu, Sep 01, 2011 at 01:05:31PM +0800, Zhi Yong Wu wrote: On Wed, Aug 31, 2011 at 08:18:19AM +0100, Stefan Hajnoczi wrote: On Tue, Aug 30, 2011 at 2:46 PM, Adam Litke a...@us.ibm.com wrote: On Tue, Aug 30, 2011 at

Re: [libvirt] [RFC] Create ptmx as a device

2011-09-01 Thread Serge Hallyn
Quoting Daniel Veillard (veill...@redhat.com): On Wed, Aug 31, 2011 at 01:18:33PM -0500, Serge Hallyn wrote: Hi, I'm seeing an issue with udev and libvirt-lxc. Libvirt-lxc creates /dev/ptmx as a symlink to /dev/pts/ptmx. When udev starts up, it checks the device type, sees ptmx is

Re: [libvirt] [RFC] Create ptmx as a device

2011-09-01 Thread Daniel P. Berrange
On Wed, Aug 31, 2011 at 01:18:33PM -0500, Serge Hallyn wrote: Hi, I'm seeing an issue with udev and libvirt-lxc. Libvirt-lxc creates /dev/ptmx as a symlink to /dev/pts/ptmx. When udev starts up, it checks the device type, sees ptmx is 'not right', and replaces it with a 'proper' ptmx.

Re: [libvirt] [RFC] Create ptmx as a device

2011-09-01 Thread Daniel Veillard
On Thu, Sep 01, 2011 at 03:52:48AM -0500, Serge Hallyn wrote: Quoting Daniel Veillard (veill...@redhat.com): On Wed, Aug 31, 2011 at 01:18:33PM -0500, Serge Hallyn wrote: Hi, I'm seeing an issue with udev and libvirt-lxc. Libvirt-lxc creates /dev/ptmx as a symlink to

Re: [libvirt] [RFC] Create ptmx as a device

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 02:13:16PM +0800, Daniel Veillard wrote: On Wed, Aug 31, 2011 at 01:18:33PM -0500, Serge Hallyn wrote: Hi, I'm seeing an issue with udev and libvirt-lxc. Libvirt-lxc creates /dev/ptmx as a symlink to /dev/pts/ptmx. When udev starts up, it checks the device

Re: [libvirt] [PATCH] lxc: do not require 'ifconfig' or 'ipconfig' in container

2011-09-01 Thread Daniel P. Berrange
On Wed, Aug 31, 2011 at 02:02:10PM -0500, Serge Hallyn wrote: Quoting Scott Moser (smo...@ubuntu.com): Currently, the lxc implementation invokes 'ip' and 'ifconfig' commands inside a container using 'virRun'. That has the side effect of requiring those commands to be present and to

Re: [libvirt] [PATCH 1/2] BlockJob: Bandwidth parameter is in MB when using text monitor

2011-09-01 Thread Daniel P. Berrange
On Wed, Aug 31, 2011 at 05:15:43PM -0500, Adam Litke wrote: Due to an unfortunate precedent in qemu, the units for the bandwidth parameter to block_job_set_speed are different between the text monitor and the qmp monitor. While the qmp monitor uses bytes/s, the text monitor expects MB/s.

Re: [libvirt] [PATCH 2/2] BlockPull: Set bandwidth limit when using text monitor

2011-09-01 Thread Daniel P. Berrange
On Wed, Aug 31, 2011 at 05:15:44PM -0500, Adam Litke wrote: The libvirt BlockPull API supports the use of an initial bandwidth limit. To implement this in the text monitor we first start the operation with a 'block_stream' command and then issue a 'block_job_set_speed' command to apply the

Re: [libvirt] [PATCH] virsh: prefer unsigned flags

2011-09-01 Thread Daniel P. Berrange
On Wed, Aug 31, 2011 at 09:12:16PM -0600, Eric Blake wrote: * tools/virsh.c (cmdUndefine, cmdSave, cmdSaveImageDumpxml) (cmdSaveImageEdit, cmdManagedSave, cmdRestore, cmdDump) (cmdVcpuPin, cmdSetvcpus, cmdSetmem, cmdSetmaxmem, cmdDumpXML) (cmdDomXMLFromNative, cmdDomXMLToNative, doMigrate)

Re: [libvirt] [PATCH] lxc: Fix incorrect changes on error codes.

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 02:28:12PM +0800, Osier Yang wrote: Fix incorrect changes introduced by commit 6ac47762bb9. --- src/lxc/lxc_driver.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 5587b06..6b716c1

Re: [libvirt] [PATCH] conf: Substitute OPERATION_INVALID with INTERNAL_ERROR

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 02:15:54PM +0800, Osier Yang wrote: --- src/conf/node_device_conf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 4803e2a..6b0ef50 100644 --- a/src/conf/node_device_conf.c

Re: [libvirt] [PATCH] storage: Fix incorrect error codes

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 03:27:33PM +0800, Osier Yang wrote: Commit 0376f4a69b intended to fix incorrect use of VIR_ERR_NO_SUPPORT, but replacing it with VIR_ERR_OPERATION_INVALID is not proper either. --- src/storage/storage_backend.c | 12 ++--

Re: [libvirt] [PATCH 4/8] qemu: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 10:04:49AM +0200, Matthias Bolte wrote: 2011/9/1 Osier Yang jy...@redhat.com: 于 2011年08月25日 05:47, Daniel P. Berrange 写道: On Tue, Aug 23, 2011 at 05:39:41PM +0800, Osier Yang wrote: * src/qemu/qemu_command.c: s/VIR_ERR_NO_SUPPORT/VIR_ERR_CONFIG_UNSUPPORTED/

Re: [libvirt] [PATCH 3/8] nodeinfo: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 02:42:51PM +0800, Osier Yang wrote: 于 2011年08月25日 05:48, Daniel P. Berrange 写道: On Tue, Aug 23, 2011 at 05:39:40PM +0800, Osier Yang wrote: --- src/nodeinfo.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/nodeinfo.c

Re: [libvirt] [PATCH] nodeinfo: Fix incorrect error codes

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 02:45:31PM +0800, Osier Yang wrote: Introduced by 5e495c8b, except the ones for checking if numa is supported by host, all the NO_SUPPORT are changed back. For the ones about numa checking, change them into INTERNAL_ERROR. --- src/nodeinfo.c | 16

Re: [libvirt] [PATCH] remote: Fix incorrect error codes

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 03:17:08PM +0800, Osier Yang wrote: Introduced by d4b53ef6c. For no internalFlags support, the error code is changed into INTERNAL_ERROR. --- src/remote/remote_driver.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [libvirt] [PATCH] Revert test: Cleanup improper VIR_ERR_NO_SUPPORT use

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 03:36:59PM +0800, Osier Yang wrote: This reverts commit 172214bd304ff958160307be2efd6614e9868946. --- src/test/test_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index

Re: [libvirt] [PATCH] Source control for storage pool

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 02:49:04PM +0800, Lei Li wrote: Fix bug #611823 storage driver should prohibit pools with duplicate underlying storage. Add API virStoragePoolSourceFindDuplicate() to do uniqueness check based on source location infomation for pool type. Signed-off-by: Lei Li

Re: [libvirt] [v2 03/13] Add USB controller models

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:19AM +0300, Marc-André Lureau wrote: Changes since v1: - Added pci-ohci --- docs/schemas/domain.rng |9 + src/conf/domain_conf.c | 11 +++ src/conf/domain_conf.h | 13 + src/libvirt_private.syms |2 ++ 4 files

Re: [libvirt] [PATCH] xen: Fix incorrect use of error codes

2011-09-01 Thread Osier Yang
于 2011年09月01日 17:14, Daniel P. Berrange 写道: On Thu, Sep 01, 2011 at 03:57:13PM +0800, Osier Yang wrote: Commit d07aa6a96 intended to fix incorrect use of VIR_ERR_NO_SUPPORT, but some of the changes are not proper, this patch fixes the problems. --- src/xen/xen_hypervisor.c |4 ++--

Re: [libvirt] [PATCH] qemu: Fix a regression of domain save

2011-09-01 Thread Osier Yang
于 2011年09月01日 16:47, Daniel Veillard 写道: On Thu, Sep 01, 2011 at 04:14:13PM +0800, Osier Yang wrote: * src/qemu/qemu_driver.c - qemuDomainSaveInternal: Return directly will keep the domain object locked. --- src/qemu/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [libvirt] [v2 08/13] Add USB hub device

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:24AM +0300, Marc-André Lureau wrote: --- docs/formatdomain.html.in| 27 docs/schemas/domain.rng | 13 ++ src/conf/domain_conf.c | 157 +-

Re: [libvirt] [v2 04/13] Add a new controller type 'usb' with optionnal 'model'

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:20AM +0300, Marc-André Lureau wrote: The model by default is piix3-uchi. Example: controller type='usb' index='0' model='ich9-ehci'/ diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index dbfc7d9..2f32e37 100644 --- a/src/qemu/qemu_command.c

Re: [libvirt] [v2 09/13] Modify USB port to be defined as a port path

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:25AM +0300, Marc-André Lureau wrote: So that devices can be attached to hubs. Example, to attach to first port of a usb-hub on port 1. hub type='usb' address type='usb' bus='0' port='1'/ /hub input type='mouse' type='usb'

Re: [libvirt] [v2 10/13] qemu: don't reserve slot 1 if a PIIX3 USB controller is defined there

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:26AM +0300, Marc-André Lureau wrote: Changes sinces v1: - apply only to piix3 - check if piix3 controller is on correct address, or report error --- src/qemu/qemu_command.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [v2 11/13] qemu: Don't append 0 at usb id, so that it is compatible with legacy -usb

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:27AM +0300, Marc-André Lureau wrote: QEMU uses USB bus name usb.0 when using the legacy -usb argument. If we want to allow USB devices to specify their addresses with legacy -usb, we should either in case of legacy bus name drop the 0 from the address bus, or just

Re: [libvirt] [v2 12/13] Add a usb1 usb2 qemuxml2argv test

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:28AM +0300, Marc-André Lureau wrote: --- tests/qemuxml2argvdata/qemuxml2argv-usb1-usb2.args | 15 tests/qemuxml2argvdata/qemuxml2argv-usb1-usb2.xml | 74 tests/qemuxml2argvtest.c |4 + 3 files

Re: [libvirt] [v2 01/13] Add various USB devices QEMU_CAPS

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:17AM +0300, Marc-André Lureau wrote: Changes since v1: - added pci-ohci - removed extra ich9 companions that came with ich9-ehci --- src/qemu/qemu_capabilities.c | 25 + src/qemu/qemu_capabilities.h |8

Re: [libvirt] [v2 02/13] Split virDomainControllerModel to virDomainControllerModelSCSI

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:18AM +0300, Marc-André Lureau wrote: --- src/conf/domain_conf.c | 26 +++--- src/conf/domain_conf.h | 18 ++ src/esx/esx_driver.c |8 src/libvirt_private.syms |4 ++-- src/vmx/vmx.c|

[libvirt] [test-API][PATCH] Add libvirtd restart test case

2011-09-01 Thread Wayne Sun
* libvirtd restart should not affect the running domains. This test check the libvirtd status before and after libvirtd restart, and also by checking the domain pid to confirm the domain is not affected. --- repos/libvirtd/restart.py | 143

Re: [libvirt] [v2 07/13] Add USB companion controllers support

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:23AM +0300, Marc-André Lureau wrote: Companion controllers take an extra 'master' attribute to associate them. Changes since v1: - use the same bus index for companion controllers - removed the master bus attribute, redundant with controller index ---

Re: [libvirt] [v2 13/13] Add usb-redir device

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:29AM +0300, Marc-André Lureau wrote: diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index e35b76b..0ab08de 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1314,6 +1314,12 @@ 0.4.4 for USB and 0.6.0 for PCI

Re: [libvirt] [PATCH] xen: Fix incorrect use of error codes

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 03:57:13PM +0800, Osier Yang wrote: Commit d07aa6a96 intended to fix incorrect use of VIR_ERR_NO_SUPPORT, but some of the changes are not proper, this patch fixes the problems. --- src/xen/xen_hypervisor.c |4 ++-- src/xen/xend_internal.c | 12 ++--

Re: [libvirt] [v2 05/13] USB controller can have a PCI address child element

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:21AM +0300, Marc-André Lureau wrote: --- .../qemuxml2argv-usb-ich9-ehci-addr.args |1 + .../qemuxml2argv-usb-ich9-ehci-addr.xml| 18 ++ tests/qemuxml2argvtest.c |3 +++ 3 files changed, 22

Re: [libvirt] [v2 06/13] USB devices gain a new USB address child element

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:44:22AM +0300, Marc-André Lureau wrote: --- docs/schemas/domain.rng| 14 + src/conf/domain_conf.c | 62 +++- src/conf/domain_conf.h | 10 +++

Re: [libvirt] [PATCH 1/8] Add on_migrate element to domainXML

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 12:10:20PM -0600, Jim Fehlig wrote: on_migrate can be used to modify default parameters used when migrating a domain. --- docs/formatdomain.html.in | 21 docs/schemas/domain.rng | 13 ++

Re: [libvirt] [PATCH 2/8] Add public API for getting migration speed

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 12:10:21PM -0600, Jim Fehlig wrote: Includes impl of python binding since the generator was not able to cope. Note: Requires gendispatch.pl patch from Matthias Bolte https://www.redhat.com/archives/libvir-list/2011-August/msg01367.html --- docs/apibuild.py

Re: [libvirt] [PATCH 5/8] virsh: Expose virDomainMigrateGetMaxSpeed API

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 12:10:24PM -0600, Jim Fehlig wrote: --- tools/virsh.c | 41 + tools/virsh.pod |4 2 files changed, 45 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 15b9bdd..f6d65c7 100644 ---

Re: [libvirt] [PATCH 4/8] Impl virDomainMigrateGetMaxSpeed in qemu driver

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 12:10:23PM -0600, Jim Fehlig wrote: --- src/qemu/qemu_driver.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f21122d..b932e67 100644 ---

Re: [libvirt] [PATCH 8/8] Use max speed specified in domain conf when migrating

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 12:10:27PM -0600, Jim Fehlig wrote: Prefer qemuMigrationRun() 'resource' parameter, but consider value set in domain conf if 'resource' is 0. --- src/qemu/qemu_migration.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH 7/8] Set qemu migration speed unlimited when migrating to file

2011-09-01 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 12:10:26PM -0600, Jim Fehlig wrote: The qemu migration speed default is 32MiB/s as defined in migration.c /* Migration speed throttling */ static int64_t max_throttle = (32 20); The only reason to throttle migration when targeting a file is user request. If user

Re: [libvirt] [PATCH 0/6] Support online block resizing

2011-09-01 Thread Daniel P. Berrange
On Wed, Aug 31, 2011 at 09:31:58PM +0800, Osier Yang wrote: Upstream QEMU introduced online block resizing to resize the block device when domain is running since commit 6d4a2b3a4795. It simply reuses existing bdrv_truncate method which is used by qemu-img to resize the images. This means it

Re: [libvirt] [PATCH 0/6] Support online block resizing

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 02:14:23PM +0100, Daniel P. Berrange wrote: On Wed, Aug 31, 2011 at 09:31:58PM +0800, Osier Yang wrote: Upstream QEMU introduced online block resizing to resize the block device when domain is running since commit 6d4a2b3a4795. It simply reuses existing bdrv_truncate

Re: [libvirt] [PATCH 0/6] Support online block resizing

2011-09-01 Thread Osier Yang
于 2011年09月01日 21:37, Daniel P. Berrange 写道: On Thu, Sep 01, 2011 at 02:14:23PM +0100, Daniel P. Berrange wrote: On Wed, Aug 31, 2011 at 09:31:58PM +0800, Osier Yang wrote: Upstream QEMU introduced online block resizing to resize the block device when domain is running since commit

[libvirt] [PATCH] conf: Assign newDef of active domain as persistent conf if it is NULL

2011-09-01 Thread Osier Yang
Libvirt loads the domain conf from status XML if it's running when starting up. The problem is there is no record of the original conf. (dom-newDef is NULL here). So libvirt won't be able to restore the domain conf to original one when destroying/shutdown. E.g. 1) attach a device without

[libvirt] Problems with attach-interface command of libvirt

2011-09-01 Thread Tao Siheng
Dear libvirt-developer: I'm a student of computer science and technology in China. I encountered a problem when I want to attach a bridge to an existed Virtual Machine. I used the command attach-interface domain_id bridge br0 --target tap0. br0 was created by brctl and tap0 was created

Re: [libvirt] [PATCH] virsh: prefer unsigned flags

2011-09-01 Thread Eric Blake
On 09/01/2011 03:05 AM, Daniel P. Berrange wrote: On Wed, Aug 31, 2011 at 09:12:16PM -0600, Eric Blake wrote: * tools/virsh.c (cmdUndefine, cmdSave, cmdSaveImageDumpxml) (cmdSaveImageEdit, cmdManagedSave, cmdRestore, cmdDump) (cmdVcpuPin, cmdSetvcpus, cmdSetmem, cmdSetmaxmem, cmdDumpXML)

Re: [libvirt] [PATCH] virsh: improve send-key documentation

2011-09-01 Thread Daniel P. Berrange
On Wed, Aug 31, 2011 at 08:49:28AM -0600, Eric Blake wrote: The 'virsh man' description of send-key was incomplete and used the old style (literal 'optional name' instead of '[name]' metasyntax). Meanwhile, none of the other virsh help texts include examples, so I moved it out of virsh help

Re: [libvirt] [PATCH 2/1] virsh: support 'virsh start --force-boot' on older servers

2011-09-01 Thread Daniel P. Berrange
On Tue, Aug 30, 2011 at 09:54:42AM -0600, Eric Blake wrote: Managed save was added in 0.8.0, virDomainCreateWithFlags in 0.8.2, and FORCE_BOOT in 0.9.5. The virsh flag is more useful if we emulate it for all older servers (note that if a hypervisor fails the query for a managed save image,

[libvirt] [PATCH] Prevent crash from dlclose() of libvirt.so

2011-09-01 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When libvirt calls virInitialize it creates a thread local for the virErrorPtr storage, and registers a callback to cleanup memory when a thread exits. When libvirt is dlclose()d or otherwise made non-resident, the callback function is removed from

[libvirt] [PATCH] virsh: avoid memory leak on cmdVolCreateAs

2011-09-01 Thread ajia
* tools/virsh.c: fix memory leak on cmdVolCreateAs function. * Detected in valgrind run: ==4746== ==4746== 48 (40 direct, 8 indirect) bytes in 1 blocks are definitely lost in loss record 26 of 52 ==4746==at 0x4A04A28: calloc (vg_replace_malloc.c:467) ==4746==by 0x4C76E51: virAlloc

Re: [libvirt] [PATCH] Prevent crash from dlclose() of libvirt.so

2011-09-01 Thread Eric Blake
On 09/01/2011 10:57 AM, Daniel P. Berrange wrote: +++ b/src/Makefile.am @@ -1228,7 +1228,7 @@ libvirt_qemu.def: $(srcdir)/libvirt_qemu.syms libvirt_la_SOURCES = libvirt_la_LDFLAGS = $(VERSION_SCRIPT_FLAGS)$(LIBVIRT_SYMBOL_FILE) \ -version-info $(LIBVIRT_VERSION_INFO) \ -

Re: [libvirt] [PATCH 1/8] Add on_migrate element to domainXML

2011-09-01 Thread Jim Fehlig
Daniel P. Berrange wrote: On Fri, Aug 26, 2011 at 12:10:20PM -0600, Jim Fehlig wrote: on_migrate can be used to modify default parameters used when migrating a domain. --- docs/formatdomain.html.in | 21 docs/schemas/domain.rng |

[libvirt] [PATCH] build: fix 'make check' with pdwtags

2011-09-01 Thread Eric Blake
Problem introduced by commit b12354b. * src/remote_protocol-structs: Remove spurious blank line. --- Pushing under the build-breaker rule. It only affects people that have pdwtags (from the dwarves package) installed. src/remote_protocol-structs |1 - 1 files changed, 0 insertions(+), 1

Re: [libvirt] [PATCH] virsh: avoid memory leak on cmdVolCreateAs

2011-09-01 Thread Eric Blake
On 09/01/2011 11:12 AM, Alex Jia wrote: * tools/virsh.c: fix memory leak on cmdVolCreateAs function. % valgrind -v --leak-check=full virsh vol-create-as default foo.img 10M \ --allocation 0 --format qcow2 --backing-vol bar.img Notes: bar.img doesn't exist. Signed-off-by: Alex

Re: [libvirt] [PATCH 2/1] virsh: support 'virsh start --force-boot' on older servers

2011-09-01 Thread Eric Blake
On 09/01/2011 08:43 AM, Daniel P. Berrange wrote: On Tue, Aug 30, 2011 at 09:54:42AM -0600, Eric Blake wrote: Managed save was added in 0.8.0, virDomainCreateWithFlags in 0.8.2, and FORCE_BOOT in 0.9.5. The virsh flag is more useful if we emulate it for all older servers (note that if a

Re: [libvirt] [PATCH] virsh: improve send-key documentation

2011-09-01 Thread Eric Blake
On 09/01/2011 08:41 AM, Daniel P. Berrange wrote: On Wed, Aug 31, 2011 at 08:49:28AM -0600, Eric Blake wrote: The 'virsh man' description of send-key was incomplete and used the old style (literal 'optional name' instead of '[name]' metasyntax). Meanwhile, none of the other virsh help texts

[libvirt] [PATCHv3.5 40/43] snapshot: wire up disk-only flag to snapshot-create

2011-09-01 Thread Eric Blake
Expose the disk-only flag through virsh. Additionally, make virsh snapshot-create-as take an arbitrary number of diskspecs, which can be used to build up the xml for domainsnapshot. * tools/virsh.c (cmdSnapshotCreate): Add --disk-only. (cmdSnapshotCreateAs): Likewise, and add argv diskspec.

Re: [libvirt] [PATCH] virsh: improve send-key documentation

2011-09-01 Thread Daniel P. Berrange
On Thu, Sep 01, 2011 at 12:49:50PM -0600, Eric Blake wrote: On 09/01/2011 08:41 AM, Daniel P. Berrange wrote: On Wed, Aug 31, 2011 at 08:49:28AM -0600, Eric Blake wrote: The 'virsh man' description of send-key was incomplete and used the old style (literal 'optional name' instead of '[name]'

Re: [libvirt] [PATCH] virsh: improve send-key documentation

2011-09-01 Thread Eric Blake
On 09/01/2011 01:09 PM, Daniel P. Berrange wrote: On Thu, Sep 01, 2011 at 12:49:50PM -0600, Eric Blake wrote: On 09/01/2011 08:41 AM, Daniel P. Berrange wrote: On Wed, Aug 31, 2011 at 08:49:28AM -0600, Eric Blake wrote: The 'virsh man' description of send-key was incomplete and used the old

[libvirt] [PATCH V2 4/8] Impl virDomainMigrateGetMaxSpeed in qemu driver

2011-09-01 Thread Jim Fehlig
From: Jim Fehlig jfeh...@novell.com --- src/qemu/qemu_driver.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a150b08..c5fa106 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH V2 8/8] Use max bandwidth from qemuDomainObjPrivate struct when migrating

2011-09-01 Thread Jim Fehlig
From: Jim Fehlig jfeh...@novell.com Adjust qemuMigrationRun() to use migMaxBandwidth in qemuDomainObjPrivate structure when setting qemu migration speed. Caller-specified 'resource' parameter overrides migMaxBandwidth. --- src/qemu/qemu_migration.c |4 ++-- 1 files changed, 2 insertions(+),

[libvirt] [PATCH V2 6/8] Save migration speed in qemuDomainMigrateSetMaxSpeed

2011-09-01 Thread Jim Fehlig
From: Jim Fehlig jfeh...@novell.com Now that migration speed is stored in qemuDomainObjPrivate structure, save the new value when invoking qemuDomainMigrateSetMaxSpeed(). Allow setting migration speed on inactive domain too. --- src/qemu/qemu_driver.c | 36 +++-

[libvirt] [PATCH V2 7/8] Set qemu migration speed unlimited when migrating to file

2011-09-01 Thread Jim Fehlig
From: Jim Fehlig jfeh...@novell.com The qemu migration speed default is 32MiB/s as defined in migration.c /* Migration speed throttling */ static int64_t max_throttle = (32 20); There's no need to throttle migration when targeting a file, so set migration speed to unlimited prior to migration,

[libvirt] [PATCH V2 3/8] Store max migration bandwidth in qemuDomainObjPrivate struct

2011-09-01 Thread Jim Fehlig
From: Jim Fehlig jfeh...@novell.com The maximum bandwidth that can be consumed when migrating a domain is better classified as an operational vs configuration parameter of the dommain. As such, store this parameter in qemuDomainObjPrivate structure. --- src/qemu/qemu_domain.c |2 ++

Re: [libvirt] specifying rbd images in libvirt

2011-09-01 Thread Sage Weil
On Thu, 1 Sep 2011, Daniel P. Berrange wrote: On Sat, Aug 27, 2011 at 12:19:33PM -0700, Sage Weil wrote: Hi all, Currently, you can specify an rbd (or nbd, sheepdog) image with xml that looks like so: disk type='network' device='disk' driver name='qemu' type='raw'

Re: [libvirt] [PATCH 1/8] Add on_migrate element to domainXML

2011-09-01 Thread Jim Fehlig
Jim Fehlig wrote: [...] I'll push patches 2 and 5, drop 1 and 3, and provide a v2 of 4, 6-8 using your suggestion. Err, patch 3 was updated to store max migration bandwidth in qemuDomainObjPrivate structure instead of domain conf. V2 of 3-4,6-8 sent... BTW, what do folks consider a sane

[libvirt] [PATCHv3 00.5/43] snapshot: fix corner case on OOM during creation

2011-09-01 Thread Eric Blake
Commit 6766ff10 introduced a corner case bug with snapshot creation: if a snapshot is created, but then we hit OOM while trying to create the return value of the function, then we have polluted the internal directory with the snapshot metadata with no way to clean it up from the running libvirtd.

[libvirt] [PATCH] Change my email domain

2011-09-01 Thread Jim Fehlig
I'd like to change my primary email address to jfeh...@suse.com. This patch changes it in AUTHORS and .mailmap. --- .mailmap |3 ++- AUTHORS |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index cdfd9fd..2795047 100644 --- a/.mailmap +++

[libvirt] [PATCH] Don't overwrite errors from xend_{get,req}

2011-09-01 Thread Jim Fehlig
xenDaemonDomainFetch() was overwriting errors reported by xend_get() and xend_req(). E.g. without patch error: failed Xen syscall xenDaemonDomainFetch failed to find this domain with patch error: internal error Xend returned HTTP Content-Length of 73817, which exceeds maximum of 65536 ---

[libvirt] [PATCH] BlockPull: Set initial bandwidth limit if specified

2011-09-01 Thread Adam Litke
The libvirt BlockPull API supports the use of an initial bandwidth limit but the qemu block_stream API does not. To get the desired behavior we use the two APIs strung together: first BlockPull, then BlockJobSetSpeed. We can do this at the driver level to avoid duplicated code in each monitor

Re: [libvirt] [PATCH] Change my email domain

2011-09-01 Thread Eric Blake
On 09/01/2011 04:18 PM, Jim Fehlig wrote: I'd like to change my primary email address to jfeh...@suse.com. This patch changes it in AUTHORS and .mailmap. --- .mailmap |3 ++- AUTHORS |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) ACK. You of all people should know how

Re: [libvirt] [PATCH] Don't overwrite errors from xend_{get,req}

2011-09-01 Thread Eric Blake
On 09/01/2011 04:27 PM, Jim Fehlig wrote: xenDaemonDomainFetch() was overwriting errors reported by xend_get() and xend_req(). E.g. without patch error: failed Xen syscall xenDaemonDomainFetch failed to find this domain with patch error: internal error Xend returned HTTP Content-Length of

Re: [libvirt] [PATCH] Change my email domain

2011-09-01 Thread Jim Fehlig
Eric Blake wrote: On 09/01/2011 04:18 PM, Jim Fehlig wrote: I'd like to change my primary email address to jfeh...@suse.com. This patch changes it in AUTHORS and .mailmap. --- .mailmap |3 ++- AUTHORS |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) ACK. You of all

[libvirt] [PATCH] Increase size of buffer for xend response

2011-09-01 Thread Jim Fehlig
On systems with many pcpus, the sexpr returned by xend can be quite large for dom0 when it is configured to have #vcpus = #pcpus (default). E.g. on a 80 pcpu system, where dom0 had 80 vcpus, the sexpr details for dom0 was 73817 bytes! Increase maximum buffer size to 256k. ---

Re: [libvirt] [PATCH] Don't overwrite errors from xend_{get,req}

2011-09-01 Thread Jim Fehlig
Opps, sent a reply from @novell domain, which is now setting on the list server I suppose... Eric Blake wrote: On 09/01/2011 04:27 PM, Jim Fehlig wrote: xenDaemonDomainFetch() was overwriting errors reported by xend_get() and xend_req(). E.g. without patch error: failed Xen syscall

Re: [libvirt] [RFC] block I/O throttling: how to enable in libvirt

2011-09-01 Thread Gui Jianfeng
On 2011-9-1 16:11, Stefan Hajnoczi wrote: On Thu, Sep 01, 2011 at 01:05:31PM +0800, Zhi Yong Wu wrote: On Wed, Aug 31, 2011 at 08:18:19AM +0100, Stefan Hajnoczi wrote: On Tue, Aug 30, 2011 at 2:46 PM, Adam Litke a...@us.ibm.com wrote: On Tue, Aug 30, 2011 at 09:53:33AM +0100, Stefan Hajnoczi

[libvirt] [v3 02/14] Split virDomainControllerModel to virDomainControllerModelSCSI

2011-09-01 Thread Marc-André Lureau
--- src/conf/domain_conf.c | 26 +++--- src/conf/domain_conf.h | 18 ++ src/esx/esx_driver.c |8 src/libvirt_private.syms |4 ++-- src/vmx/vmx.c| 32 tests/xml2vmxtest.c |2 +-

  1   2   >