Re: [libvirt] [PATCH] Don't treat pci_system_init failure as fatal if no PCI bus is present

2011-09-06 Thread Daniel Veillard
On Mon, Sep 05, 2011 at 09:29:06PM +0200, Soren Hansen wrote: Xen PV domU's have no PCI bus. node_device_udev.c calls pci_system_init which looks for /sys/bus/pci. If it does not find /sys/bus/pci (which it won't in a Xen PV domU) it returns unsuccesfully (ENOENT), which libvirt considers

[libvirt] [test-API][PATCH] Add a case for testing update device flag

2011-09-06 Thread Nan Zhang
--- repos/domain/update_devflag.py | 159 1 files changed, 159 insertions(+), 0 deletions(-) create mode 100644 repos/domain/update_devflag.py diff --git a/repos/domain/update_devflag.py b/repos/domain/update_devflag.py new file mode 100644 index

Re: [libvirt] [test-API][PATCH] Add a case for testing update device flag

2011-09-06 Thread Alex Jia
On 09/06/2011 02:11 PM, Nan Zhang wrote: --- repos/domain/update_devflag.py | 159 1 files changed, 159 insertions(+), 0 deletions(-) create mode 100644 repos/domain/update_devflag.py diff --git a/repos/domain/update_devflag.py

Re: [libvirt] [PATCH] redirdev: allows to specify device address

2011-09-06 Thread Daniel Veillard
On Mon, Sep 05, 2011 at 02:07:52PM +0200, Marc-André Lureau wrote: It is important to be able to attach USB redirected devices to a particular controller (one that supports USB2 for instance). Without this patch, only the default bus was used. redirdev bus='usb' type='spicevmc'

Re: [libvirt] [test-API][PATCH] Add a case for testing update device flag

2011-09-06 Thread Guannan Ren
On 09/06/2011 02:11 PM, Nan Zhang wrote: --- repos/domain/update_devflag.py | 159 1 files changed, 159 insertions(+), 0 deletions(-) create mode 100644 repos/domain/update_devflag.py diff --git a/repos/domain/update_devflag.py

Re: [libvirt] [PATCH 2/2] XML: Suppress printing domain.xml for parse errors on XML strings

2011-09-06 Thread Daniel Veillard
On Mon, Sep 05, 2011 at 02:33:40PM +0200, Peter Krempa wrote: Patch e81778d6184f1850a10eb661eb756b50421d5ac4 introduces printing file name on XML errors. This corrects the URL string to be NULL and therefore to print an error message not containing bogus filename domain.xml. NULL is a valid

Re: [libvirt] [PATCH RFC 1/2] XML: Improve XML parsing error messages

2011-09-06 Thread Daniel Veillard
On Mon, Sep 05, 2011 at 02:33:39PM +0200, Peter Krempa wrote: This patch modifies error handling function for the XML parser provided by libxml2. Originaly only a line number and error message were logged. With this new error handler function, the user is provided with a more complex

Re: [libvirt] [PATCH v3 1/5] link-state: util: Add equality comparision functions for structures

2011-09-06 Thread Daniel Veillard
On Mon, Sep 05, 2011 at 05:26:50PM +0200, Peter Krempa wrote: This patch adds functions to compare structures containing network device configuration for equality. They serve for the purpose of disallowing unsupported changes to live network devices. --- src/util/network.c | 62

Re: [libvirt] [PATCH 2/2] XML: Suppress printing domain.xml for parse errors on XML strings

2011-09-06 Thread Peter Krempa
Dňa 6.9.2011 9:41, Daniel Veillard wrote / napísal(a): On Mon, Sep 05, 2011 at 02:33:40PM +0200, Peter Krempa wrote: Patch e81778d6184f1850a10eb661eb756b50421d5ac4 introduces printing file name on XML errors. This corrects the URL string to be NULL and therefore to print an error message not

Re: [libvirt] [PATCH v3 2/5] link-state: conf: Add element to XML for controling link state

2011-09-06 Thread Daniel Veillard
On Mon, Sep 05, 2011 at 05:26:51PM +0200, Peter Krempa wrote: A new element is introduced to XML that allows to control state of virtual network interfaces in hypervisors. Live modification of the link state allows networking tools propagate topology changes to guest OS or testing of

Re: [libvirt] [PATCH v3 3/5] link-state: qemu: Add monitor handling for link state modification

2011-09-06 Thread Daniel Veillard
On Mon, Sep 05, 2011 at 05:26:52PM +0200, Peter Krempa wrote: This patch adds handlers for modification of guest's interface link state. Both HMP and QMP commands are supported, but as the link state functionality is from the beginning supported in QMP the HMP code will probably never be used.

Re: [libvirt] [PATCH v3 4/5] link-state: qemu: Add net intf modification to virUpdateDeviceFlags

2011-09-06 Thread Daniel Veillard
On Mon, Sep 05, 2011 at 05:26:53PM +0200, Peter Krempa wrote: This patch enables modifying network device configuration using the virUpdateDeviceFlags API method. Matching of devices is accomplished using MAC addresses. While updating live configuration of a running domain, the user is

Re: [libvirt] [PATCH v3 5/5] link-state: virsh: Add wrapper commands for changing link state

2011-09-06 Thread Daniel Veillard
On Mon, Sep 05, 2011 at 05:26:54PM +0200, Peter Krempa wrote: Two new commands are added to virsh that wrap usage of virDomainUpdateDeviceFlags for changing link state of domain's network interfaces. These wrappers extract network devices's xml configuration and modify the link state for easy

Re: [libvirt] [PATCH v2] virsh: Add more human-friendly output of domblkstat command

2011-09-06 Thread Daniel Veillard
On Mon, Sep 05, 2011 at 05:46:39PM +0200, Peter Krempa wrote: Users of virsh complain that output of the domblkstat command is not intuitive enough. This patch adds explanation of fields returned by this command to the help section for domblkstat and the man page of virsh. Also a switch

Re: [libvirt] [PATCH 2/2] XML: Suppress printing domain.xml for parse errors on XML strings

2011-09-06 Thread Daniel Veillard
On Tue, Sep 06, 2011 at 09:58:35AM +0200, Peter Krempa wrote: Dňa 6.9.2011 9:41, Daniel Veillard wrote / napísal(a): On Mon, Sep 05, 2011 at 02:33:40PM +0200, Peter Krempa wrote: Patch e81778d6184f1850a10eb661eb756b50421d5ac4 introduces printing file name on XML errors. This corrects the URL

Re: [libvirt] [PATCH v2] virsh: Add more human-friendly output of domblkstat command

2011-09-06 Thread Peter Krempa
Dňa 6.9.2011 10:39, Daniel Veillard wrote / napísal(a): On Mon, Sep 05, 2011 at 05:46:39PM +0200, Peter Krempa wrote: Users of virsh complain that output of the domblkstat command is not intuitive enough. This patch adds explanation of fields returned by this command to the help section for

[libvirt] [PATCH 1/2] Add VIR_TYPED_PARAM_STRING

2011-09-06 Thread Hu Tao
--- daemon/remote.c | 15 +++ include/libvirt/libvirt.h.in |4 +++- src/remote/remote_driver.c | 15 +++ src/remote/remote_protocol.x |2 ++ 4 files changed, 35 insertions(+), 1 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index

[libvirt] [test-API][PATCH] Add test case for start domain on nfs storage

2011-09-06 Thread Wayne Sun
* This test is for start a domain with img file on nfs storage. Under SElinux boolean virt_use_nfs on or off, combine with setting the dynamic_ownership in /etc/libvirt/qemu.conf, check whether the guest can be started or not. The nfs could be root_squash or no_root_squash. SElinux

Re: [libvirt] [PATCH 1/2] Add VIR_TYPED_PARAM_STRING

2011-09-06 Thread Daniel Veillard
On Tue, Sep 06, 2011 at 06:18:40PM +0800, Hu Tao wrote: --- daemon/remote.c | 15 +++ include/libvirt/libvirt.h.in |4 +++- src/remote/remote_driver.c | 15 +++ src/remote/remote_protocol.x |2 ++ 4 files changed, 35 insertions(+), 1

[libvirt] [PATCH 2/2] add interface for blkio.weight_device

2011-09-06 Thread Hu Tao
This patch adds a parameter --weight-device to virsh command blkiotune for setting/getting blkio.weight_device. --- include/libvirt/libvirt.h.in |9 ++ src/conf/domain_conf.c | 133 - src/conf/domain_conf.h | 15 src/libvirt_private.syms

Re: [libvirt] [PATCH 1/2] Add VIR_TYPED_PARAM_STRING

2011-09-06 Thread Eric Blake
On 09/06/2011 04:44 AM, Daniel Veillard wrote: On Tue, Sep 06, 2011 at 06:18:40PM +0800, Hu Tao wrote: --- daemon/remote.c | 15 +++ include/libvirt/libvirt.h.in |4 +++- src/remote/remote_driver.c | 15 +++ src/remote/remote_protocol.x |2

[libvirt] [PATCH v3] virsh: Add more human-friendly output of domblkstat command

2011-09-06 Thread Peter Krempa
Users of virsh complain that output of the domblkstat command is not intuitive enough. This patch adds explanation of fields returned by this command to the help section for domblkstat and the man page of virsh. Also a switch --human is added for domblkstat that prints the fields with more

Re: [libvirt] [PATCH] mingw: Don't use interface as an identifier

2011-09-06 Thread Eric Blake
On 09/06/2011 07:44 AM, Matthias Bolte wrote: Because it's a define use in MSCOM and its usage as identifier results in a compile error. Lame of the headers to invade the namespace like that, but easy enough to work around. --- tools/virsh.c | 24 ++-- 1 files

[libvirt] [PATCH rfc] xml: Change virtual file names of xml documents parsed in memory

2011-09-06 Thread Peter Krempa
While parsing XML strings from memory, the previous convention in libvirt was to set the virtual file name to domain.xml or something similar. This could potentialy trick the user into looking for a file named domain.xml on the disk in an attempt to fix the error. This patch changes these

[libvirt] [PATCH] esx: Support folders in the path of vpx:// connection URIs

2011-09-06 Thread Matthias Bolte
Allow the datacenter and compute resource parts of the path to be prefixed with folders. Therefore, the way the path is parsed has changed. Before, it was split in 2 or 3 items and the items' meanings were determined by their positions. Now the path can have 2 or more items and the the vCenter

Re: [libvirt] [PATCH] mingw: Don't use interface as an identifier

2011-09-06 Thread Matthias Bolte
2011/9/6 Eric Blake ebl...@redhat.com: On 09/06/2011 07:44 AM, Matthias Bolte wrote: Because it's a define use in MSCOM and its usage as identifier results in a compile error. Lame of the headers to invade the namespace like that, but easy enough to work around. ---  tools/virsh.c |   24

[libvirt] [PATCH] esx: Fix managed object lookup with optional occurrence

2011-09-06 Thread Matthias Bolte
Exit early if managed object is not found, instead of dereferencing a NULL pointer and triggering a segfault. --- src/esx/esx_vi.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index 5c8d79e..f4033eb 100644 ---

Re: [libvirt] [PATCH] libxl: avoid a dereference of a null pointer

2011-09-06 Thread Jim Fehlig
Alex Jia wrote: Variable 'l_disk' initialized to a null pointer value, control jumps to 'case VIR_DOMAIN_DISK_DEVICE_DISK and then taking false branch, Within the expansion of the macro 'libxlError': Field access results in a dereference of a null pointer (loaded from variable 'l_disk'). *

Re: [libvirt] [PATCH 1/2] Add VIR_TYPED_PARAM_STRING

2011-09-06 Thread Daniel Veillard
On Tue, Sep 06, 2011 at 07:09:53AM -0600, Eric Blake wrote: On 09/06/2011 04:44 AM, Daniel Veillard wrote: On Tue, Sep 06, 2011 at 06:18:40PM +0800, Hu Tao wrote: --- daemon/remote.c | 15 +++ include/libvirt/libvirt.h.in |4 +++- src/remote/remote_driver.c