Re: [libvirt] [RFC] API to invoke S3/S4 on a KVM host and also resume from within libvirt

2011-09-19 Thread Vaidyanathan Srinivasan
* Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com [2011-09-12 14:55:26]: Hi, In order to exploit the host power management capabilities like S3/S4, it was proposed to add additional tags in the libvirt capabilities XML to export the power management features supported by the host. The

Re: [libvirt] libvirt-0.9.5 availability of rc2

2011-09-19 Thread Daniel Veillard
On Sun, Sep 18, 2011 at 09:37:22AM -0500, Adam Litke wrote: I am getting SIGABRT and SIGSEGV in libvirtd when trying to catch blockJob events. When running under valgrind I get the following: ==19819== Thread 1: ==19819== Invalid free() / delete / delete[] ==19819==at 0x4C282ED: free

[libvirt] [PATCH] Update to require sanlock 1.8 for license compliance

2011-09-19 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Inexpicably the sanlock code all got placed under the GPLv2-only, so libvirt's use of sanlock introduces a license incompatibility. The sanlock developers have now rearranged the code such that there is a 'sanlock_client.so' which is LGPLv2+ while

[libvirt] [PATCH v6] virsh: Add more human-friendly output of domblkstat command

2011-09-19 Thread Peter Krempa
Users of virsh complain that output of the domblkstat command is not intuitive enough. This patch adds explanation of fields returned by this command to the help section for domblkstat and the man page of virsh. Also a switch --human is added for domblkstat that prints the fields with more

Re: [libvirt] [PATCH v6] virsh: Add more human-friendly output of domblkstat command

2011-09-19 Thread Peter Krempa
I accidentaly posted an older version of this patch :( Please disregard this v6, as it does not compile. Peter -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v7] virsh: Add more human-friendly output of domblkstat command

2011-09-19 Thread Peter Krempa
Users of virsh complain that output of the domblkstat command is not intuitive enough. This patch adds explanation of fields returned by this command to the help section for domblkstat and the man page of virsh. Also a switch --human is added for domblkstat that prints the fields with more

[libvirt] [PATCH] virsh: doc: Fix supported driver types for attach-disk command

2011-09-19 Thread Peter Krempa
Virsh man page lists driver types to be used with attach-device command, but does not specify that those are usable only with the XEN Hypervisor. This patch adds statement, that those options specified are applicable only on the Xen hypervisor and adds option usable with qemu emulator. This

[libvirt] [PATCH] daemon: Error and exit if specified value for timeout is not valid

2011-09-19 Thread Osier Yang
Silently setting timeout as -1 if the specified value is invalid is a bit confused. --- daemon/libvirtd.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index c708ff7..4dd68d5 100644 --- a/daemon/libvirtd.c +++

[libvirt] [PATCH] Remove devname identifier from autogenerated RPC code

2011-09-19 Thread Peter Krempa
Patch 79cf07a missed one instance of devname in source for RPC code generator. --- src/remote/remote_protocol.x |2 +- src/remote_protocol-structs |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index

Re: [libvirt] [PATCH v2] spec: Require augeas for sanlock

2011-09-19 Thread Eric Blake
On 09/18/2011 07:02 PM, Wen Congyang wrote: At 09/15/2011 11:10 PM, Michal Privoznik Write: Even though we BuildRequire augeas in some cases, we need to require it even after if we build with sanlock. virt-sanlock-cleanup use it. --- libvirt.spec.in |2 ++ 1 files changed, 2

Re: [libvirt] [PATCH] qemu: qxl devices don't support multifunction yet

2011-09-19 Thread Marc-André Lureau
Hi hi On Fri, Sep 16, 2011 at 1:38 PM, Marc-André Lureau mlur...@redhat.com wrote: How do we allow other devices to share the slot? It seems to me that qemuDomainPCIAddressSetNextAddr() only allocate whole slot, while making sure there is no conflicts on the same slot. So, if the user

Re: [libvirt] [PATCH v2] spec: Require augeas for sanlock

2011-09-19 Thread Eric Blake
On 09/19/2011 10:22 AM, Eric Blake wrote: On RHEL6.1GA, there is no package named augeas. It only has augeas-libs. On F15, it also only has augeas-libs. What is augeas? Augeas is the package that provides the standalone executable 'augtool' (this is the command line access to the augeas-libs

Re: [libvirt] [PATCH] qemu: qxl devices don't support multifunction yet

2011-09-19 Thread Daniel P. Berrange
On Mon, Sep 19, 2011 at 07:16:22PM +0200, Marc-André Lureau wrote: Hi hi On Fri, Sep 16, 2011 at 1:38 PM, Marc-André Lureau mlur...@redhat.com wrote: How do we allow other devices to share the slot? It seems to me that qemuDomainPCIAddressSetNextAddr() only allocate whole slot, while

Re: [libvirt] [PATCH] Update to require sanlock 1.8 for license compliance

2011-09-19 Thread Eric Blake
On 09/19/2011 04:04 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Inexpicably the sanlock code all got placed under the GPLv2-only, s/Inexpicably/Inexplicably/ so libvirt's use of sanlock introduces a license incompatibility. The sanlock developers have now

Re: [libvirt] [PATCH 1/5] daemon: avoid memory leak

2011-09-19 Thread Eric Blake
On 09/18/2011 10:36 AM, a...@redhat.com wrote: * daemon/remote.c: fix memory leak. Your commit message didn't mention which function you fixed,... Signed-off-by: Alex Jiaa...@redhat.com --- daemon/remote.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH 2/5] qemu: avoid memory leak

2011-09-19 Thread Eric Blake
On 09/18/2011 10:36 AM, a...@redhat.com wrote: * src/qemu/qemu_command.c: fix memory leak. Signed-off-by: Alex Jiaa...@redhat.com --- src/qemu/qemu_command.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

Re: [libvirt] [PATCH 3/5] remote: avoid memory leak

2011-09-19 Thread Eric Blake
On 09/18/2011 10:36 AM, a...@redhat.com wrote: * src/remote/remote_driver.c: fix memory leak. Signed-off-by: Alex Jiaa...@redhat.com --- src/remote/remote_driver.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/remote/remote_driver.c

Re: [libvirt] [PATCH 4/5] util: avoid memory leak

2011-09-19 Thread Eric Blake
On 09/18/2011 10:36 AM, a...@redhat.com wrote: * src/util/pci.c: fix memory leak. Signed-off-by: Alex Jiaa...@redhat.com --- src/util/pci.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/util/pci.c b/src/util/pci.c index 9873f33..8d8e157 100644 ---

Re: [libvirt] [PATCH v2 5/5] vmx: avoid memory leak

2011-09-19 Thread Eric Blake
On 09/18/2011 08:34 PM, a...@redhat.com wrote: * src/vmx/vmx.c: fix memory leak, 'def' has a initial value 'NULL', so 'goto cleanup' is perfected instead of adding a virConfFree before 'return NULL'. Signed-off-by: Alex Jiaa...@redhat.com --- src/vmx/vmx.c |2 +- 1 files changed, 1

Re: [libvirt] [PATCH v7] virsh: Add more human-friendly output of domblkstat command

2011-09-19 Thread Eric Blake
On 09/19/2011 06:23 AM, Peter Krempa wrote: Users of virsh complain that output of the domblkstat command is not intuitive enough. This patch adds explanation of fields returned by this command to the help section for domblkstat and the man page of virsh. Also a switch --human is added for

Re: [libvirt] [PATCH v7] virsh: Add more human-friendly output of domblkstat command

2011-09-19 Thread Peter Krempa
Dňa 19.9.2011 22:24, Eric Blake wrote / napísal(a): ACK with my nits fixed, so I've pushed this. Here's what I squashed in: Uff, thanks for the many suggestions and for fixing it right away. Well, line length is one of my problems. I try to keep them short, but on a wide angle monitor,

[libvirt] [PATCH] Add unsafe cache mode support for disk driver

2011-09-19 Thread Oskari Saarenmaa
QEMU 0.13 introduced cache=unsafe for -drive, this patch exposes it in the libvirt layer. * Introduced a new QEMU capability flag ($prefix_CACHE_UNSAFE), as even if $prefix_CACHE_V2 is set, we can't known if unsafe is supported. * qemuhelptest prints test case name on failure. ---

Re: [libvirt] [PATCH v7] virsh: Add more human-friendly output of domblkstat command

2011-09-19 Thread Eric Blake
On 09/19/2011 02:24 PM, Eric Blake wrote: virsh # domblkstat 1 vda --human Device: vda number of read operations: 3726 number of read bytes: 82815488 number of write operations: 478 number of bytes written: 4965376 For consistency, I think bytes read matches better with bytes written. And

Re: [libvirt] [PATCH] conf: Assign newDef of active domain as persistent conf if it is NULL

2011-09-19 Thread Eric Blake
On 09/01/2011 07:44 AM, Osier Yang wrote: Libvirt loads the domain conf from status XML if it's running when starting up. The problem is there is no record of the original conf. (dom-newDef is NULL here). So libvirt won't be able to restore the domain conf to original one when

Re: [libvirt] [PATCH v7] virsh: Add more human-friendly output of domblkstat command

2011-09-19 Thread Peter Krempa
Dňa 19.9.2011 22:49, Eric Blake wrote / napísal(a): On 09/19/2011 02:24 PM, Eric Blake wrote: virsh # domblkstat 1 vda --human Device: vda number of read operations: 3726 number of read bytes: 82815488 number of write operations: 478 number of bytes written: 4965376 For consistency, I think

Re: [libvirt] [PATCH v7] virsh: Add more human-friendly output of domblkstat command

2011-09-19 Thread Eric Blake
On 09/19/2011 03:04 PM, Peter Krempa wrote: - vshPrint(ctl, %s %s %s\n, device, field, value); + vshPrint(ctl, %-*s %s %s\n, human ? 31 : 0, I think this is not completely correct D'oh - you're right. I justified the wrong field. That's what I get for writing the email with only a compile,

Re: [libvirt] [PATCH] virsh: doc: Fix supported driver types for attach-disk command

2011-09-19 Thread Eric Blake
On 09/19/2011 06:57 AM, Peter Krempa wrote: Virsh man page lists driver types to be used with attach-device command, but does not specify that those are usable only with the XEN Hypervisor. This patch adds statement, that those options specified are applicable only on the Xen hypervisor and

Re: [libvirt] [PATCH] Remove devname identifier from autogenerated RPC code

2011-09-19 Thread Eric Blake
On 09/19/2011 08:14 AM, Peter Krempa wrote: Patch 79cf07a missed one instance of devname in source for RPC code generator. --- src/remote/remote_protocol.x |2 +- src/remote_protocol-structs |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH] daemon: Error and exit if specified value for timeout is not valid

2011-09-19 Thread Eric Blake
On 09/19/2011 08:28 AM, Osier Yang wrote: Silently setting timeout as -1 if the specified value is invalid is a bit confused. --- daemon/libvirtd.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index c708ff7..4dd68d5 100644

Re: [libvirt] [PATCH] storage: Ensure the device path exists before refreshing disk pool

2011-09-19 Thread Eric Blake
On 09/19/2011 08:28 AM, Osier Yang wrote: Doing libvirt_parthelper on an not existed device path will get an unfriendly error message. This patch is to prohibit it. --- src/storage/storage_backend_disk.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] qemu: qxl devices don't support multifunction yet

2011-09-19 Thread Wen Congyang
At 09/20/2011 01:16 AM, Marc-André Lureau Write: Hi hi On Fri, Sep 16, 2011 at 1:38 PM, Marc-André Lureau mlur...@redhat.com wrote: How do we allow other devices to share the slot? It seems to me that qemuDomainPCIAddressSetNextAddr() only allocate whole slot, while making sure there is no

Re: [libvirt] [PATCH 1/5] daemon: avoid memory leak

2011-09-19 Thread Alex Jia
On 09/20/2011 03:03 AM, Eric Blake wrote: On 09/18/2011 10:36 AM, a...@redhat.com wrote: * daemon/remote.c: fix memory leak. Your commit message didn't mention which function you fixed,... Oh, I think 'git' will do this , and sorry about any inconvenient for you. Thanks, Alex

Re: [libvirt] [PATCH] storage: Ensure the device path exists before refreshing disk pool

2011-09-19 Thread Osier Yang
于 2011年09月20日 08:17, Eric Blake 写道: On 09/19/2011 08:28 AM, Osier Yang wrote: Doing libvirt_parthelper on an not existed device path will get an unfriendly error message. This patch is to prohibit it. --- src/storage/storage_backend_disk.c | 8 +++- 1 files changed, 7 insertions(+), 1

Re: [libvirt] [PATCH] daemon: Error and exit if specified value for timeout is not valid

2011-09-19 Thread Osier Yang
于 2011年09月20日 08:16, Eric Blake 写道: On 09/19/2011 08:28 AM, Osier Yang wrote: Silently setting timeout as -1 if the specified value is invalid is a bit confused. --- daemon/libvirtd.c | 6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c

Re: [libvirt] [PATCH] qemu: Prevent disk corruption on domain shutdown

2011-09-19 Thread Wen Congyang
At 09/15/2011 06:07 PM, Jiri Denemark Write: Ever since we introduced fake reboot, we call qemuProcessKill as a reaction to SHUTDOWN event. Unfortunately, qemu doesn't guarantee it flushed all internal buffers before sending SHUTDOWN, in which case killing the process forcibly may result in

Re: [libvirt] [PATCH] Add unsafe cache mode support for disk driver

2011-09-19 Thread Osier Yang
于 2011年09月20日 04:47, Oskari Saarenmaa 写道: QEMU 0.13 introduced cache=unsafe for -drive, this patch exposes it in the libvirt layer. * Introduced a new QEMU capability flag ($prefix_CACHE_UNSAFE), as even if $prefix_CACHE_V2 is set, we can't known if unsafe is supported. *

Re: [libvirt] [PATCH] conf: Assign newDef of active domain as persistent conf if it is NULL

2011-09-19 Thread Osier Yang
于 2011年09月20日 04:58, Eric Blake 写道: On 09/01/2011 07:44 AM, Osier Yang wrote: Libvirt loads the domain conf from status XML if it's running when starting up. The problem is there is no record of the original conf. (dom-newDef is NULL here). So libvirt won't be able to restore the domain conf

Re: [libvirt] libvirt-0.9.5 availability of rc2

2011-09-19 Thread Daniel Veillard
On Mon, Sep 19, 2011 at 08:15:18AM -0500, Adam Litke wrote: On Mon, Sep 19, 2011 at 04:04:04PM +0800, Daniel Veillard wrote: On Sun, Sep 18, 2011 at 09:37:22AM -0500, Adam Litke wrote: Hum, I wonder if remoteRelayDomainEventBlockJob shouldn't strdup the path string instead of using it

Re: [libvirt] specifying rbd images in libvirt

2011-09-19 Thread Sage Weil
On Fri, 16 Sep 2011, Daniel Veillard wrote: I don't think there's anything controversial here. I suspect the main concern is that these fields are named in a sufficiently general fashion so that they can be used for other backend storage types. I guess the best is to start with the

[libvirt] [PATCH 0/5 v2] Improve Ceph Qemu+RBD support

2011-09-19 Thread Sage Weil
The current support for qemu and Ceph RBD (rados block device) has two main deficiencies: authentication doesn't work, and it relies on environment variables (which don't work with latest upstream). This patch set addresses both those problems. The first two patches update the xml schemas and

[libvirt] [PATCH 3/5] qemu: pass virConnectPtr into Domain{Attach, Detach}*

2011-09-19 Thread Sage Weil
The qemu RBD driver needs access to the conn in order to get the secret needed for connecting to the ceph cluster. Signed-off-by: Sage Weil s...@newdream.net --- src/qemu/qemu_command.c |5 +++-- src/qemu/qemu_command.h |3 ++- src/qemu/qemu_driver.c | 17 -

[libvirt] [PATCH 1/5] secret: add Ceph secret type

2011-09-19 Thread Sage Weil
Add a new secret type to store a Ceph authentication key. The ceph_id field contains the name of the key (e.g. 'admin' for the ceph superuser). Signed-off-by: Sage Weil s...@newdream.net --- docs/schemas/secret.rng | 17 +++ include/libvirt/libvirt.h.in |3 ++

[libvirt] [PATCH 2/5] storage: add authId, authDomain to virDomainDiskDef

2011-09-19 Thread Sage Weil
Add additional fields to let you specify the how to authenticate with a network disk type. The authId is the name to authenticate as, and the authDomain optionally describes the domain that user exists in. The latter allows us to locate a secret in using the libvirt secrets API, as the user is

[libvirt] [PATCH 5/5] qemu/rbd: improve rbd device specification

2011-09-19 Thread Sage Weil
This improves the support for qemu rbd devices by adding support for a few key features (e.g., authentication) and cleaning up the way in which rbd configuration options are passed to qemu. And auth member of the disk source xml specifies how librbd should authenticate. The id property is the

[libvirt] [PATCH 4/5] buf: implement generic virBufferEscape

2011-09-19 Thread Sage Weil
Implement a generic helper to escape a given set of characters with a leading '\'. Generalizes virBufferEscapeSexpr(). Signed-off-by: Sage Weil s...@newdream.net --- src/libvirt_private.syms |1 + src/util/buf.c | 33 ++--- src/util/buf.h |

Re: [libvirt] libvirt-0.9.5 availability of rc3

2011-09-19 Thread Jason Helfman
On Mon, Sep 19, 2011 at 09:23:02AM -0700, Jason Helfman thus spake: On Mon, Sep 19, 2011 at 11:56:52AM +0800, Daniel Veillard thus spake: On Sun, Sep 18, 2011 at 08:48:23PM -0700, Jason Helfman wrote: On Sun, Sep 18, 2011 at 06:55:06PM +0800, Daniel Veillard thus spake: I have made a third

Re: [libvirt] libvirt-0.9.5 availability of rc3

2011-09-19 Thread Osier Yang
于 2011年09月20日 12:43, Jason Helfman 写道: On Mon, Sep 19, 2011 at 09:23:02AM -0700, Jason Helfman thus spake: On Mon, Sep 19, 2011 at 11:56:52AM +0800, Daniel Veillard thus spake: On Sun, Sep 18, 2011 at 08:48:23PM -0700, Jason Helfman wrote: On Sun, Sep 18, 2011 at 06:55:06PM +0800, Daniel