When failing on starting a domain, it tries to reattach all the PCI
devices defined in the domain conf, regardless of whether the devices
are still used by other domain. This will cause the devices are deleted
from the list qemu_driver-activePciHostdevs, thus the devices will be
thought as usable
On Fri, Sep 23, 2011 at 10:35:19AM -0600, Eric Blake wrote:
On 09/22/2011 10:05 AM, Laine Stump wrote:
(This addresses Eric's comments in his review of V1. BTW, I'm a bit
surprised nobody has commented about the choice of name/placement of
the new attribute - speak now or forever hold your
On Thu, Sep 22, 2011 at 02:34:55PM -0600, Eric Blake wrote:
Future patches can take advantage of this to generate nicer
XML output with parameterizable indentation.
On the side, I had some temporary test failures as I was using
these functions in later patches, with output that looked like:
On 09/26/2011 05:58 PM, Nan Zhang wrote:
---
repos/domain/update_devflag.py | 276
1 files changed, 276 insertions(+), 0 deletions(-)
create mode 100644 repos/domain/update_devflag.py
diff --git a/repos/domain/update_devflag.py
On Fri, Sep 23, 2011 at 10:23:15AM -0600, Eric Blake wrote:
[...]
Independent of your patch, I also just realized that
virDomainSave[Flags], virDomainRestore[Flags],
virDomainSaveImageGetXMLDesc, virDomainSaveImageDefineXML, and
virDomainCoreDump all have the same design issue: they are not
On 27.09.2011 01:03, Eric Blake wrote:
On 09/26/2011 10:53 AM, Michal Privoznik wrote:
as they are not used with debugging turned off.
Fair enough. ACK.
Thanks, pushed.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Mon, Sep 26, 2011 at 08:17:23PM +0200, Peter Krempa wrote:
Init scripts removed pid file of the daemon. Removing pid files may be
harmful as new api for crash-safe pidfiles is used (introduced by
c8a3a26).
---
daemon/libvirtd.init.in |1 -
daemon/libvirtd.upstart |4
2
On Mon, Sep 26, 2011 at 04:45:48PM -0600, Eric Blake wrote:
Don't force RHEL to build HyperV support yet.
* libvirt.spec.in (%{?rhel}): Provide default for with_hyperv.
---
libvirt.spec.in |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/libvirt.spec.in
On 09/27/2011 10:50 AM, Daniel P. Berrange wrote:
ACK
Daniel
Thanks, pushed.
Peter
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Thu, Sep 22, 2011 at 02:34:55PM -0600, Eric Blake wrote:
Future patches can take advantage of this to generate nicer
XML output with parameterizable indentation.
Hmm, is there any way we can work with virBuffer so that we don't
need to pass an indent level to every single API call ?
eg,
On Tue, Sep 27, 2011 at 01:19:56AM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Add API to fetch, list, retrieve find storage pool(s) on a connection.
---
libvirt-gobject/libvirt-gobject-connection.c | 279
++
On Tue, Sep 27, 2011 at 11:40:45AM +0800, Lei Li wrote:
On 09/27/2011 06:19 AM, Zeeshan Ali (Khattak) wrote:
diff --git a/libvirt-gobject/libvirt-gobject.sym
b/libvirt-gobject/libvirt-gobject.sym
index eae40a2..ff2f4cf 100644
--- a/libvirt-gobject/libvirt-gobject.sym
+++
Libguestfs provides very nice functionality for applications that need
to work with disk images. The includes provisioning applications that
set up or customize disk images. It also includes backup applications
that want to look inside disk image snapshots - both at the block and
file level.
On Tue, Sep 27, 2011 at 01:19:20AM -0400, Laine Stump wrote:
On 09/19/2011 01:32 PM, Daniel P. Berrange wrote:
On Mon, Sep 19, 2011 at 07:16:22PM +0200, Marc-André Lureau wrote:
Hi hi
On Fri, Sep 16, 2011 at 1:38 PM, Marc-André Lureaumlur...@redhat.com
wrote:
How do we allow other
Hi,
For those who are interested, I have posted the notes from the 2011
Linux Plumbers Virtualization micro conference here:
http://wiki.linuxplumbersconf.org/2011:virtualization
Slides can be found by clicking on the presentation and going onto the
Plumbers abstracts.
Cheers,
Jes
--
As these might be not used and make syntax-check complains about checking
them via virCheckFlags.
---
pushing under build-breaker rule
src/locking/lock_driver_nop.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/locking/lock_driver_nop.c
On Tue, Sep 27, 2011 at 10:10:00AM +0100, Stefan Hajnoczi wrote:
Libguestfs provides very nice functionality for applications that need
to work with disk images. The includes provisioning applications that
set up or customize disk images. It also includes backup applications
that want to
Current qemu is able to give us detailed domain status (not just if it
is running or not) which we can translate into a status reason.
---
src/qemu/qemu_monitor.c | 66 +++--
src/qemu/qemu_monitor.h | 25 +++-
Before, URIs such as esx+ssh:// have been declined by the ESX driver
resulting in the remote driver trying to connect to an non-existing
libvirtd.
Now such URIs trigger and error in the ESX driver suggesting to try
again without the transport part in the scheme.
---
src/esx/esx_driver.c | 31
Before, URIs such as hyperv+ssh:// have been declined by the Hyper-V
driver resulting in the remote driver trying to connect to an
non-existing libvirtd.
Now such URIs trigger an error in the Hyper-V driver suggesting to
try again without the transport part in the scheme.
---
On Tue, Sep 27, 2011 at 10:34:19AM +0100, Richard W.M. Jones wrote:
(3) libvirtd runs the libguestfs appliance. It forwards the socket
back to us over the libvirt connection. I think this is what Dan had
in mind, and it's reasonably easy to integrate this into both libvirtd
and libguestfs.
On Tue, Sep 27, 2011 at 10:10:00AM +0100, Stefan Hajnoczi wrote:
Libguestfs provides very nice functionality for applications that need
to work with disk images. The includes provisioning applications that
set up or customize disk images. It also includes backup applications
that want to
On Tue, Sep 27, 2011 at 12:20:31PM +0100, Daniel P. Berrange wrote:
One other point worth mentioning is that libguestfs.so does not want
to directly link to libvirt.so, and vica-verca, to ensure we both
avoid pulling major new dependancy chains for all users.
Actually libguestfs.so in Fedora
On Tue, Sep 27, 2011 at 12:21:05PM +0100, Richard W.M. Jones wrote:
On Tue, Sep 27, 2011 at 10:34:19AM +0100, Richard W.M. Jones wrote:
(3) libvirtd runs the libguestfs appliance. It forwards the socket
back to us over the libvirt connection. I think this is what Dan had
in mind, and it's
On Tue, Sep 27, 2011 at 12:35:21PM +0100, Richard W.M. Jones wrote:
On Tue, Sep 27, 2011 at 12:20:31PM +0100, Daniel P. Berrange wrote:
One other point worth mentioning is that libguestfs.so does not want
to directly link to libvirt.so, and vica-verca, to ensure we both
avoid pulling major
On Tue, Sep 27, 2011 at 12:21:05PM +0100, Richard W.M. Jones wrote:
On Tue, Sep 27, 2011 at 10:34:19AM +0100, Richard W.M. Jones wrote:
(3) libvirtd runs the libguestfs appliance. It forwards the socket
back to us over the libvirt connection. I think this is what Dan had
in mind, and it's
On 09/15/2011 02:05 PM, Peter Krempa wrote:
This patch cleans the cpu baseline function using new libvirt helper
functions and fixes XPath expression that selectscpu elements from
the source file, that can contain concatenatedcapabilities XMLs,
domain XMLs and barecpu elements. The fixed
To put this all into one place:
(1) An ugly new libvirt API that runs febootstrap-supermin-helper to
create the appliance.
(2) Modify guestfs_add_domain to launch a transient domain using
virDomainCreate. (Forget about the live case for the moment).
(3) A new libvirt API to open and forward a
On 09/15/2011 11:40 AM, Peter Krempa wrote:
This patch adds extraction of thecpu element from capabilities and
domain definition XML documents to improve user experience.
https://bugzilla.redhat.com/show_bug.cgi?id=731151
---
tools/virsh.c | 54
On Tue, Sep 27, 2011 at 12:55:19PM +0100, Richard W.M. Jones wrote:
To put this all into one place:
(1) An ugly new libvirt API that runs febootstrap-supermin-helper to
create the appliance.
(2) Modify guestfs_add_domain to launch a transient domain using
virDomainCreate. (Forget about
On Tue, Sep 27, 2011 at 11:56 AM, Daniel P. Berrange
berra...@redhat.com wrote:
Since the return value is annotated '(transfer full)' you need
todo 'g_object_ref(domain)' before putting it into the hash table,
since the hash needs to keep hold of a reference. Also you want
to have a
On Tue, Sep 27, 2011 at 02:59:11PM +0300, Zeeshan Ali (Khattak) wrote:
On Tue, Sep 27, 2011 at 11:56 AM, Daniel P. Berrange
berra...@redhat.com wrote:
Since the return value is annotated '(transfer full)' you need
todo 'g_object_ref(domain)' before putting it into the hash table,
since the
On 09/27/2011 01:20 AM, Daniel Veillard wrote:
@@ -10477,13 +10477,16 @@ virDomainDefFormatInternal(virDomainDefPtr def,
if (def-id == -1)
flags |= VIR_DOMAIN_XML_INACTIVE;
-virBufferAsprintf(buf, domain type='%s', type);
+virBufferAsprintf(buf, %*sdomain type='%s',
On 09/27/2011 03:03 AM, Daniel P. Berrange wrote:
On Thu, Sep 22, 2011 at 02:34:55PM -0600, Eric Blake wrote:
Future patches can take advantage of this to generate nicer
XML output with parameterizable indentation.
Hmm, is there any way we can work with virBuffer so that we don't
need to
SIGTERM handling for -no-shutdown is already fixed in qemu git and
libvirt can safely use it. The downside is that 0.15.50 version of qemu
can be any qemu compiled from git, even that without the fix for
SIGTERM. However, I think this patch is worth it since someone using
qemu from git should
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
libvirt-gconfig is in a separate namespace than libvirt-gobject so there
is not reason to expose 'Config' part of identifiers to high-level
languages.
---
libvirt-gconfig/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
If a domain started with -no-shutdown shuts down while libvirtd is not
running, it will be seen as paused when libvirtd reconnects to it. Use
the paused reason to detect if a domain was stopped because of shutdown
and finish the process just as if a SHUTDOWN event is delivered from
qemu.
---
On 09/27/2011 06:56 AM, Jiri Denemark wrote:
SIGTERM handling for -no-shutdown is already fixed in qemu git and
libvirt can safely use it. The downside is that 0.15.50 version of qemu
can be any qemu compiled from git, even that without the fix for
SIGTERM. However, I think this patch is worth
If migration failed in Prepare phase after virDomainAssignDef and before
a job is started, the domain object was not properly removed.
---
Notes:
Version 2:
- only remove the inactive domain if ret 0
src/qemu/qemu_migration.c | 11 ++-
1 files changed, 6 insertions(+), 5
On Mon, Sep 26, 2011 at 15:56:03 -0600, Eric Blake wrote:
On 09/26/2011 05:50 AM, Jiri Denemark wrote:
If migration failed in Prepare phase after virDomainAssignDef and before
a job is started, the domain object was not properly removed.
---
src/qemu/qemu_migration.c | 11 ++-
On Tue, Sep 27, 2011 at 06:42:22AM -0600, Eric Blake wrote:
On 09/27/2011 01:20 AM, Daniel Veillard wrote:
@@ -10477,13 +10477,16 @@ virDomainDefFormatInternal(virDomainDefPtr def,
if (def-id == -1)
flags |= VIR_DOMAIN_XML_INACTIVE;
-virBufferAsprintf(buf, domain
On Mon, Sep 26, 2011 at 17:00:32 -0600, Eric Blake wrote:
On 09/26/2011 07:11 AM, Jiri Denemark wrote:
Both --copy-storage-{all,inc} options require disk images to be present
on destination host.
---
tools/virsh.pod |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
On Tue, Sep 27, 2011 at 06:50:23AM -0600, Eric Blake wrote:
On 09/27/2011 03:03 AM, Daniel P. Berrange wrote:
On Thu, Sep 22, 2011 at 02:34:55PM -0600, Eric Blake wrote:
Future patches can take advantage of this to generate nicer
XML output with parameterizable indentation.
Hmm, is there
On Tue, Sep 27, 2011 at 07:04:31 -0600, Eric Blake wrote:
On 09/27/2011 06:56 AM, Jiri Denemark wrote:
SIGTERM handling for -no-shutdown is already fixed in qemu git and
libvirt can safely use it. The downside is that 0.15.50 version of qemu
can be any qemu compiled from git, even that
On Mon, Sep 26, 2011 at 16:58:20 -0600, Eric Blake wrote:
On 09/26/2011 06:59 AM, Jiri Denemark wrote:
Some virsh commands start a (long-running) job that can be monitored
using domjobinfo and aborted with domjobabort. Let's be explicit about
this in virsh man page.
---
If user wants to migrate a machine, it's all or nothing. Either he/she
has all storage accessible under same paths, or migration will fail.
But there are some cases, where allowing migration to drop some disks,
may be useful. E.g. when host gets itself to a state where domains need
to be migrated
This element says what to do with cdrom (or floppy) on migration.
Currently, only one attribute is supported: 'optional'. It accepts
'yes' and 'no' values. Setting a cdrom to be optional means, if
destination cannot access disk source, it simply gets free()'d/ejected.
This functionality is
This patch implements previous extension in qemu driver.
That is, during prepare phase check for every source to be accessible.
If not, but marked as optional, simply VIR_FREE the source.
Moreover, if migration is persistent, we must check inactive xml,
which is transfered at the finish phase, as
* libvirt.spec.in (%configure): Drop unused %{one} macro.
* mingw32-libvirt.spec.in (%{rhel}): Compile ESX but not HyperV on
mingw build for RHEL.
(%build): Make configure honor spec conditionals. Reorder to
match libvirt.spec.
* autobuild.sh (mingw): Update list to match.
Suggested by Daniel P.
On 09/27/2011 03:00 AM, Daniel P. Berrange wrote:
On Mon, Sep 26, 2011 at 04:45:48PM -0600, Eric Blake wrote:
Don't force RHEL to build HyperV support yet.
* libvirt.spec.in (%{?rhel}): Provide default for with_hyperv.
---
libvirt.spec.in |4 +++-
1 files changed, 3 insertions(+), 1
On 09/26/2011 11:35 PM, Laine Stump wrote:
On 09/26/2011 04:31 PM, Eric Blake wrote:
Commit ecd8725c dropped attempts to probe the cgconfig service on
new enough Fedora where systemd took over that aspect of the system,
but mistakenly used F14 instead of F15 as the cutoff point.
On 09/27/2011 03:51 AM, Jiri Denemark wrote:
Current qemu is able to give us detailed domain status (not just if it
is running or not) which we can translate into a status reason.
---
src/qemu/qemu_monitor.c | 66 +++--
src/qemu/qemu_monitor.h |
On 09/27/2011 05:12 AM, Matthias Bolte wrote:
Before, URIs such as esx+ssh:// have been declined by the ESX driver
resulting in the remote driver trying to connect to an non-existing
libvirtd.
Now such URIs trigger and error in the ESX driver suggesting to try
again without the transport part
On 09/27/2011 07:04 AM, Jiri Denemark wrote:
If a domain started with -no-shutdown shuts down while libvirtd is not
running, it will be seen as paused when libvirtd reconnects to it. Use
the paused reason to detect if a domain was stopped because of shutdown
and finish the process just as if a
On 09/27/2011 05:14 AM, Matthias Bolte wrote:
Before, URIs such as hyperv+ssh:// have been declined by the Hyper-V
driver resulting in the remote driver trying to connect to an
non-existing libvirtd.
Now such URIs trigger an error in the Hyper-V driver suggesting to
try again without the
On 09/27/2011 07:23 AM, Jiri Denemark wrote:
If migration failed in Prepare phase after virDomainAssignDef and before
a job is started, the domain object was not properly removed.
---
Notes:
Version 2:
- only remove the inactive domain if ret 0
src/qemu/qemu_migration.c | 11
On 09/15/2011 06:05 AM, Peter Krempa wrote:
This patch cleans the cpu baseline function using new libvirt helper
functions and fixes XPath expression that selectscpu elements from
the source file, that can contain concatenatedcapabilities XMLs,
domain XMLs and barecpu elements. The fixed
On 09/15/2011 03:40 AM, Peter Krempa wrote:
This patch adds extraction of thecpu element from capabilities and
domain definition XML documents to improve user experience.
https://bugzilla.redhat.com/show_bug.cgi?id=731151
---
tools/virsh.c | 54
On 09/27/2011 08:39 AM, Michal Privoznik wrote:
This element says what to do with cdrom (or floppy) on migration.
Currently, only one attribute is supported: 'optional'. It accepts
'yes' and 'no' values. Setting a cdrom to be optional means, if
destination cannot access disk source, it simply
On 09/27/2011 02:53 AM, Daniel Veillard wrote:
On Fri, Sep 23, 2011 at 10:35:19AM -0600, Eric Blake wrote:
On 09/22/2011 10:05 AM, Laine Stump wrote:
(This addresses Eric's comments in his review of V1. BTW, I'm a bit
surprised nobody has commented about the choice of name/placement of
the new
Coupled with the recent virsh nodedev-* doc patch, this should now
give a better picture of libvirt node device handling.
* docs/formatnode.html.in: Fill in page.
---
Done mostly by scraping docs/schemas/nodedev.rng, and examples
provided from my laptop with some slight munging (hopefully I'm
On 09/26/2011 05:59 AM, Dmitry Mishin wrote:
Parallels Server Bare Metal is a virtualization solution which allows to run
both Containers (OpenVZ-like) and virtual machines (like any other hardware
hypervisor).
Any web page link so we can familiarize ourselves with the project?
This patch
I repost this, this time by also including the libvirt mailing list.
Info on my libvirt: it's the version in Ubuntu 11.04 Natty which is
0.8.8-1ubuntu6.5 . I didn't recompile this one, while Kernel and
qemu-kvm are vanilla and compiled by hand as described below.
My original message follows:
This patch fixes the regression with using named pipes for qemu serial
devices noted in:
https://bugzilla.redhat.com/show_bug.cgi?id=740478
The problem was that, while new code in libvirt looks for a single
bidirectional fifo of the name given in the config, then relabels that
and continues
Sigh. I just looked at my bugzilla mail backlog and saw that this
morning Dan Berrange voted for the simpler method of fixing this, but I
didn't notice it before implementing this patch.
I'll be back shortly with a v2 that does it the other way.
On 09/27/2011 02:36 PM, Laine Stump wrote:
The AppArmor security driver adds only the path specified in the domain
XML for character devices of type 'pipe'. It should be using path.in
and path.out. We do this by creating a new vah_add_file_chardev() and
use it for char devices instead of vah_add_file(). Also adjust
valid_path() to accept
Hi everyone,
Any feedback on this series? I touch a few pieces outside of the RBD bits
here...
Thanks!
sage
On Mon, 19 Sep 2011, Sage Weil wrote:
The current support for qemu and Ceph RBD (rados block device) has two
main deficiencies: authentication doesn't work, and it relies on
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-connection.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libvirt-gobject/libvirt-gobject-connection.c
b/libvirt-gobject/libvirt-gobject-connection.c
index 074fe53..f97b50a 100644
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-connection.c | 126 ++
1 files changed, 69 insertions(+), 57 deletions(-)
diff --git a/libvirt-gobject/libvirt-gobject-connection.c
b/libvirt-gobject/libvirt-gobject-connection.c
index
On 08/04/2011 09:41 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
A previous commit gave the LXC driver the ability to mount
block devices for the container filesystem. Through use of
the loopback device functionality, we can build on this to
support use of plain
pod2man from perl-5.8.8 (RHEL 5) errors out on ill-formed POD:
*** ERROR: unterminated I... at line 1114 in file virsh.pod
*** ERROR: unterminated I... at line 1851 in file virsh.pod
Newer pod2man appears to be more tolerant (which is a shame,
because it meant that this error is harder to
(v2: change to only relabel the uni-direction fifo pair if they're
found, otherwise only relabel the bidirectional fifo, per comment in BZ
by Dan Berrange)
This patch fixes the regression with using named pipes for qemu serial
devices noted in:
The man page suggest that the cpu_shares parameter of schedinfo
allows values 0-262144, but the kernel remaps values 0 and 1 to
the minimum 2, just document that behaviour:
[root@test ~]# cat /cgroup/cpu/libvirt/qemu/cpu.shares
1024
[root@test ~]# echo 0 /cgroup/cpu/libvirt/qemu/cpu.shares
This patch is based on a improvement suggested by Kazuhiro Kikuchi
of Fujitsu, it gives a description of the target parameter for that
command
* tools/virsh.pod: add description for target parameter of
attach-interface
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 6e3febb..ca37e57
I have some time this week to work on libvirt and thought Daniel's
suggestion [1] for adding AHCI support in the qemu driver would be a
useful endeavor.
I've managed to start a qemu instance using AHCI with attached hackery,
iff I have a controller defined. E.g.
disk type='file' device='disk'
75 matches
Mail list logo
