Hello,
I sometimes get foreign qcow2 images with embedded snapshots. Without the
corresponding XML files libvirt doesn't recognize them. Therefor I created
the attached script to fake-create the missing snapshot XML files.
Be advised that the XML files might not work in all cases, especially whe
Tested by: Royce Lv
Patch works as expected:
tested with cmd "snapshot-create domain_name --disk-only"
(1)when without hmp cmd support ,snapshot failed,0 size source file deleted
(2)when source file creating failed,no snapshot taken and no crash with
"need_unlink" flag set
--
libvir-list mail
Hello,
I think it's time to plan for the next release, it may be a bit late to
target the end of the month but I would think entering freeze around
Friday 28 allowing for a release of 0.9.7 around Nov 4th should give
people enough time to get reviews and push feeatures in,
so unless there is
On 10/20/2011 03:08 AM, Peter Krempa wrote:
Dňa 29.9.2011 18:22, Eric Blake wrote / napísal(a):
is the first public instance of being
used as a sub-element, although we have two other private uses
(runtime state, and migration cookie). Although indentation has
no effect on XML parsing, using
This email is just for your attention. I'm relatively new to work in a
community, so I didn't pay much attention to the readability of the
comments last email. It seems comments lie in a large patch like this is
easily to be omitted. So I cut the codes, leave codes associated with
the comments.
When using the xml as below:
--
/home/soulxu/data/work-code/qemu-kvm/x86_64-softmmu/qemu-system-x86_64
--
Then can't startup qemu, the error message as below:
virsh # start test
于 2011年10月19日 21:55, Eric Blake 写道:
On 10/18/2011 11:32 PM, Xu He Jie wrote:
Hmm, you are right. domain_conf didn't separate with different layer. So
I found another place that in the qemu layer for the fix. The patch as
below:
Signed-off-by: Xu He Jie
---
src/qemu/qemu_command.c | 10 +++-
于 2011年10月19日 21:08, Eric Blake 写道:
On 10/18/2011 08:06 PM, Xu He Jie wrote:
More likely, the difference is not in gcc, but in ld policy - Ubuntu
recently changed policy to no longer allow implicit link dependencies
by default (that is, if A links against B, and B links against C,
older distros
On 10/19/2011 06:22 PM, MATSUDA, Daiki wrote:
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 83f4f3c..eaf8bbd 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -4312,6 +4312,7 @@ static virDriver remote_driver = {
.domainSuspend = remoteDomain
(2011/10/06 2:31), Daniel P. Berrange wrote:
The QEMU guest agent "/usr/bin/qemu-ga" has some handy functions
for controlling the guest, not least, shutdown/reboot and filesystem
freeze/thaw.
In Fedora 15/16 the semantics of the ACPI power button have been
changed to suspend-to-RAM which breaks
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 83f4f3c..eaf8bbd 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -4312,6 +4312,7 @@ static virDriver remote_driver = {
.domainSuspend = remoteDomainSuspend, /* 0.3.0 */
.domainResume
2011/10/19 David Stevens :
>
> -Matthias Bolte wrote: -
>
>>
>>Well, you miss the point that nwfilters is meant as a general
>>firewall
>>interface. ebtables/iptables just happens to be an implementation of
>>this interface. Using ebtables/iptables specific shell scripts would
>>replace th
On 10/19/2011 04:55 PM, David Stevens wrote:
-Stefan Berger wrote: -
>
>The problem is that at the moment rules (in the 'root' table) can
>have priorities [0, 1000]. So nothing prevents one to write a
>rule
>with priority 0. However, due to how nwfilters works right now
>th
-Matthias Bolte wrote: ->>Well, you miss the point that nwfilters is meant as a general>firewall>interface. ebtables/iptables just happens to be an implementation of>this interface. Using ebtables/iptables specific shell scripts would>replace the generic interface with something specific t
Let's keep the signal and default signal handler name in sync.
gobject signals are generally not namespaced this way, removing
this prefix makes things look a bit nicer.
---
libvirt-gobject/libvirt-gobject-connection.c |8
libvirt-gobject/libvirt-gobject-connection.h |8
A binding for virDomainResume().
---
libvirt-gobject/libvirt-gobject-domain.c | 21 +
libvirt-gobject/libvirt-gobject-domain.h |2 ++
libvirt-gobject/libvirt-gobject.sym |1 +
3 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/libvirt-gobject/libvirt
---
Makefile.am |2 +-
configure.ac| 19 +++
vapi/Makefile.am| 37 +
vapi/libvirt-gobject-1.0.deps |1 +
vapi/libvirt-gobject-1.0.metada |2 ++
5 files changed, 60 insertio
-Stefan Berger wrote: - > >The problem is that at the moment rules (in the 'root' table) can>have priorities [0, 1000]. So nothing prevents one to write a>rule>with priority 0. However, due to how nwfilters works right now>the>jumps into the protocol-specific tables
Quoting Eric Blake (ebl...@redhat.com):
> >+VIR_FORCE_CLOSE(*ttymaster);
> >+VIR_FREE(*ttyName)
>
> How did this ever pass compile-testing without that semicolon?
It didn't. So I fixed it. Then apparently did not do a new
git format-patch before sending. Grr.
...
> ACK to the
On 10/18/2011 07:39 PM, Serge E. Hallyn wrote:
New version, compile-tested only tonight. I followed the suggestion
about using posix_openpt(), though its manpage worries me - does libvirt
need to compile on any platforms that don't have that fn? (In which case
we can add the trivial define if w
* .gitignore: Add exemption.
---
Pushing under the trivial rule (I almost did a 'git add' of the
test binary).
.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore
index 41fa50f..b04db58 100644
--- a/.gitignore
+++ b/.gitignore
@@ -74,6 +74,
On 10/19/2011 03:02 PM, David Stevens wrote:
Stefan,
Can't you achieve the same thing by reserving an early block
of priorities (and a late one, for system stuff that should be done late)?
The problem is that at the moment rules (in the 'root' table) can have
priorities [0, 1000]. S
2011/10/19 David Stevens :
> I also think that nwfilters ought to reflect the underlying
> filter
> mechanisms as much as possible. Really, I'd prefer they were simply
> parameterized shell scripts of ebtables/iptables commands run at significant
> events (start-up, shutdown, migrate)
Dňa 29.9.2011 18:22, Eric Blake wrote / napísal(a):
is the first public instance of being
used as a sub-element, although we have two other private uses
(runtime state, and migration cookie). Although indentation has
no effect on XML parsing, using it makes the output more consistent.
This u
Stefan, Can't you achieve the same thing by reserving an early blockof priorities (and a late one, for system stuff that should be done late)? If you use negative numbers, then you lose the capability ofever extending priorities to interpret the negative number as "from the
On 09/29/2011 06:22 PM, Eric Blake wrote:
Rather than having to adjust all callers in a chain to deal with
indentation, it is nicer to have virBuffer do auto-indentation.
* src/util/buf.h (_virBuffer): Increase size.
(virBufferAdjustIndent, virBufferGetIndent): New prototypes.
* src/libvirt_priv
So far rules' priorities have only been valid in the range [0,1000].
Now I am extending their priority into the range [-1000, 1000] for subsequently
being able to sort rules and the access of (jumps into) chains following
priorities.
Signed-off-by: Stefan Berger
---
src/conf/nwfilter_conf.c
When saving config files we just overwrite old content of the file. In
case something fails during that process (e.g. disk gets full) we lose
both old and new content. This patch makes the process more robust by
writing the new content into a separate file and only if that succeeds
the original fil
Add a function to the virHashTable for getting an array of the hash table's
keys and have the keys (optionally) sorted.
Signed-off-by: Stefan Berger
---
src/libvirt_private.syms |3 +
src/util/hash.c | 98 +++
src/util/hash.h |
Use scripts for the renaming and cleaning up of chains. This allows us to get
rid of some of the code that is only capable of renaming and removing chains
whose names are hardcoded.
A shell function 'collect_chains' is introduced that is given the name
of an ebtables chain and then recursively det
The following series of patches re-does some of the inner workings
of nwfilters with the goal to enable users to write filters that have other
than the system-known chains supported right now ('root','arp','rarp','ipv4'
and 'ipv6'). Ideally users should be able to provide a chain name in the
chains
Use the previously introduced chain priorities to sort the chains for access
from an interface's 'root' table and have them created in the proper order.
This gets rid of a lot of code that was previously creating the chains in a
more hardcoded way.
To determine what protocol a filter is used for
Add test case for the chain names with known prefixes and the chain
priority.
Signed-off-by: Stefan Berger
---
tests/nwfilterxml2xmlin/chain_prefixtest1.xml | 37 +
tests/nwfilterxml2xmlout/chain_prefixtest1.xml | 21 ++
tests/nwfilterxml2xmltest.c
It still needs to be enhanced to be fully portable and working even if
fsync() implementation is insane (e.g., on OSX).
---
Notes:
Although ideally gnulib would provide us with a sane fsync() and
fdatasync() replacements (it already does so for fsync on Win32)
so this could probably be
For better handling of the sorting of chains introduce an internally used
priority. Use a lookup table to store the priorities. For now their actual
values do not matter just that the values cause the chains to be properly
sorted through changes in the following patches. However, the values are
cho
This patch enables chains that have a known prefix in their name.
Known prefixes are: 'ipv4', 'ipv6', 'arp', 'rarp'. All prefixes
are also protocols that can be evaluated on the ebtables level.
Following the prefix they will be automatically connected to an interface's
'root' chain and jumped into
Jiri Denemark (4):
Introduce virFileSync
Introduce virFileRewrite for safe file rewrite
Introduce virXMLSaveFile as a wrapper for virFileRewrite
Use virXMLSaveFile when writing XML config
src/conf/domain_conf.c | 32 +---
src/conf/network_conf.c | 34 +--
Every time we write XML into a file we call virEmitXMLWarning to write a
warning that the file is automatically generated. virXMLSaveFile
simplifies this into a single step and makes rewriting existing XML file
safe by using virFileRewrite internally.
---
src/conf/domain_conf.c | 25 ++
The previous patch extends the priority of filtering rules into negative
numbers. We now use this possibility to interleave the jumping into
chains with filtering rules to for example create the 'root' table of
an interface with the following sequence of rules:
Bridge chain: libvirt-I-vnet0, entri
This patch extends the filter XML to support priorities of chains
in the XML. An example would be:
[...]
The permitted values for priorities are [-1000, 1000].
By setting the pririty of a chain the order in which it is accessed
from the interface root chain can be influenced.
Signed-off-by: St
Use the name of the chain rather than its type index (enum).
This pushes the later enablement of chains with user-given names
into the XML parser. For now we still only allow those names that
are well known ('root', 'arp', 'rarp', 'ipv4' and 'ipv6').
Signed-off-by: Stefan Berger
---
src/conf/nw
---
src/conf/domain_conf.c | 49 +---
src/conf/network_conf.c | 34 +-
src/conf/nwfilter_conf.c | 68 +++---
src/conf/storage_conf.c | 37 +++--
src/qemu/qemu_domain.c | 19 +
This attribute says what to do with cdrom (or floppy) if
the source is missing. It accepts:
- mandatory - fail if missing for any reason (the default)
- requisite - fail if missing on boot up, drop if missing on
migrate/restore/revert
- optional - drop if missing at any start attempt
This is a 3rd version of patches [1].
Diff to v2 includes Daniel's review and some other improvements.
The aim of these patches is to mark CDROM and floppy optional,
thus they might get dropped during migration, domain startup,
restore, etc. The granularity is set on disk level, so user
can decide
This patch implements on_missing feature in qemu driver.
Upon qemu startup process an accessibility of CDROMs
and floppy disks is checked. The source might get dropped
if unavailable and on_missing is set accordingly.
No event is emit thought. Look for follow up patch.
---
src/qemu/qemu_domain.c
This function checks if a given path is accessible under
given uid and gid.
---
src/util/util.c | 76 +++
src/util/util.h |3 ++
2 files changed, 79 insertions(+), 0 deletions(-)
diff --git a/src/util/util.c b/src/util/util.c
index dac616b
If a disk source gets dropped because it is not accessible,
mgmt application might want to be informed about this. Therefore
we need to emit an event. The event presented in this patch
is however a bit superset of what written above. The reason is simple:
an intention to be easily expanded, e.g. on
On 10/19/2011 01:44 AM, Daniel P. Berrange wrote:
On Tue, Oct 18, 2011 at 09:16:01PM +0200, Philipp Hahn wrote:
Add test cases for parsing the qemu-name-space.
This is based on qemuxml2argv{test,data/}, but can not reside in
qemuxml2argv{test,data/} because ...
ACK
Pushed.
--
Eric Blake
On 10/18/2011 11:32 PM, Xu He Jie wrote:
Hmm, you are right. domain_conf didn't separate with different layer. So
I found another place that in the qemu layer for the fix. The patch as
below:
Signed-off-by: Xu He Jie
---
src/qemu/qemu_command.c | 10 +++---
1 files changed, 7 insertions(+),
On 10/19/2011 01:44 AM, Daniel P. Berrange wrote:
On Tue, Oct 18, 2011 at 06:22:49PM +0200, Philipp Hahn wrote:
The XML parser for the qemu specific extensions expects the qemu name-space
to be bound to the 'qemu' prefix. This is too strict, since the name of the
name-space-prefix is only mend a
于 2011年10月19日 20:30, Osier Yang 写道:
> * src/qemu/qemu_hostdev.c (qemuDomainReAttachHostdevDevices):
> pciDeviceListFree(pcidevs) at the end free()s the device even if
> it's in use by other domain, this is complete wrong, and will
> cause race. E.g.
>
> # sh test1.sh
> Device pci__00_19_0 detta
On 10/18/2011 08:06 PM, Xu He Jie wrote:
More likely, the difference is not in gcc, but in ld policy - Ubuntu
recently changed policy to no longer allow implicit link dependencies
by default (that is, if A links against B, and B links against C,
older distros allowed A to use symbols from C witho
On 10/19/2011 03:25 AM, lvroyce wrote:
Tested by:lvroyce
test with cmd snapshot-create domain --disk-only ,patch works when qmp
or hmp monitor accessible,
Got trace below when issue cmd "snapshot-delete domain --snapshotname
name",no "delvm/savevm" in qmp, only "delvm/savevm" commands in hmp.Is
* src/qemu/qemu_hostdev.c (qemuDomainReAttachHostdevDevices):
pciDeviceListFree(pcidevs) at the end free()s the device even if
it's in use by other domain, this is complete wrong, and will
cause race. E.g.
# sh test1.sh
Device pci__00_19_0 dettached
Domain test started
Device attached succes
On 09/29/2011 06:22 PM, Eric Blake wrote:
The next patch wants to add some sanity checking, which would
be a different error than ENOMEM. Many existing callers blindly
report OOM failure if virBuf reports an error, and this will be
wrong in the (unlikely) case that they actually had a usage erro
On 09/29/2011 06:22 PM, Eric Blake wrote:
* tests/testutils.c (virtTestDifference): Make it easier to
diagnose test failures.
ACK,
Peter
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 09/29/2011 06:22 PM, Eric Blake wrote:
Although the compiler wasn't complaining (since it was the pointer,
rather than what was being pointed to, that was actually const), it
looks quite suspicious to call a function with an argument labeled
const when the nature of the pointer (virBufferPtr)
Today, the same error encounters on my Ubuntu 11.10.
After apply this patch, I can make Libvirt successfully.
, Xu He Jie wrote:
于 2011年10月18日 22:45, Eric Blake 写道:
On 10/18/2011 02:06 AM, Xu He Jie wrote:
From: soulxu
When I compile libvirt with gcc-4.6.1 in ubuntu 11.10, got error as
belo
Tested by:lvroyce
test with cmd snapshot-create domain --disk-only ,patch works when qmp
or hmp monitor accessible,
Got trace below when issue cmd "snapshot-delete domain --snapshotname
name",no "delvm/savevm" in qmp, only "delvm/savevm" commands in hmp.Is
this for future compability?
2011-
On 10/18/2011 04:53 PM, Philipp Hahn wrote:
Signed-off-by: Philipp Hahn
---
ACK and pushed.
Peter
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From: "Daniel P. Berrange"
The statement
virBufferAdd(buf, "''", 2);
triggers a syntax-check warning
* src/util/buf.c: Replace virBufferAdd with virBufferAddLit
---
src/util/buf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Pushed as a build-breaker fix
diff --git a/
On Tue, Oct 18, 2011 at 12:55:25PM -0700, David L Stevens wrote:
>
>
> This patch adds support for "continue" and "return" actions
> in filter rules.
>
> Signed-off-by: David L Stevens
>
> diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c
> index 04bfa22..3e28806 100644
>
On Tue, Oct 18, 2011 at 09:16:01PM +0200, Philipp Hahn wrote:
> Add test cases for parsing the qemu-name-space.
> This is based on qemuxml2argv{test,data/}, but can not reside in
> qemuxml2argv{test,data/} because ...
>
> 1. qemuxmlns-qemu-ns-domain.xml is not schema-valid and breaks
> domainschem
On Tue, Oct 18, 2011 at 06:22:49PM +0200, Philipp Hahn wrote:
> The XML parser for the qemu specific extensions expects the qemu name-space
> to be bound to the 'qemu' prefix. This is too strict, since the name of the
> name-space-prefix is only mend as an internal lookup key. Only the associated
>
On Tue, Oct 18, 2011 at 02:09:55PM -0600, Eric Blake wrote:
> On 10/18/2011 01:35 PM, Guido Günther wrote:
> >Make the empty string return '' to match cmdEcho's behavior.
> >---
> > src/util/buf.c | 15 ++-
> > 1 files changed, 10 insertions(+), 5 deletions(-)
>
> ACK.
Pushed the wh
65 matches
Mail list logo
