Hello,
I think it's time to plan for the next release, it may be a bit late to
target the end of the month but I would think entering freeze around
Friday 28 allowing for a release of 0.9.7 around Nov 4th should give
people enough time to get reviews and push feeatures in,
so unless there is
Tested by: Royce Lv
Patch works as expected:
tested with cmd snapshot-create domain_name --disk-only
(1)when without hmp cmd support ,snapshot failed,0 size source file deleted
(2)when source file creating failed,no snapshot taken and no crash with
need_unlink flag set
--
libvir-list mailing
Hello,
I sometimes get foreign qcow2 images with embedded snapshots. Without the
corresponding XML files libvirt doesn't recognize them. Therefor I created
the attached script to fake-create the missing snapshot XML files.
Be advised that the XML files might not work in all cases, especially
On 09/30/2011 12:22 AM, Eric Blake wrote:
diff --git a/tests/domainsnapshotxml2xmlout/all_parameters.xml
b/tests/domainsnapshotxml2xmlout/all_parameters.xml
index ed4a600..eb2ee85 100644
--- a/tests/domainsnapshotxml2xmlout/all_parameters.xml
+++
Hi David,
font face=Default Sans Serif,Verdana,Arial,Helvetica,sans-serif
size=2divbr/divfont color=#990099-Matthias Bolte a
class=moz-txt-link-rfc2396E
href=mailto:matthias.bo...@googlemail.com;lt;matthias.bo...@googlemail.comgt;/a
wrote:
On 18.10.2011 09:32, Hu Tao wrote:
Adds two options, inbound and outbound, to attach-interface to set
bandwidth when attaching interfaces
---
tools/virsh.c | 89 +-
tools/virsh.pod |5 ++-
2 files changed, 91 insertions(+), 3
On Wed, Oct 19, 2011 at 11:10:59PM +0200, Marc-André Lureau wrote:
---
Makefile.am |2 +-
configure.ac| 19 +++
vapi/Makefile.am| 37 +
vapi/libvirt-gobject-1.0.deps |1 +
On Wed, Oct 19, 2011 at 03:14:20PM -0600, David Stevens wrote:
-Matthias Bolte [1]matthias.bo...@googlemail.com wrote: -
Well, you miss the point that nwfilters is meant as a general
firewall
interface. ebtables/iptables just happens to be an implementation of
this
On Wed, Oct 19, 2011 at 11:11:01PM +0200, Marc-André Lureau wrote:
A binding for virDomainResume().
---
libvirt-gobject/libvirt-gobject-domain.c | 21 +
libvirt-gobject/libvirt-gobject-domain.h |2 ++
libvirt-gobject/libvirt-gobject.sym |1 +
3 files
On Thu, Oct 20, 2011 at 08:50:35AM +0200, Philipp Hahn wrote:
Hello,
I sometimes get foreign qcow2 images with embedded snapshots. Without the
corresponding XML files libvirt doesn't recognize them. Therefor I created
the attached script to fake-create the missing snapshot XML files.
Be
On Wed, Oct 19, 2011 at 04:42:55PM +0200, Michal Privoznik wrote:
This is a 3rd version of patches [1].
Diff to v2 includes Daniel's review and some other improvements.
The aim of these patches is to mark CDROM and floppy optional,
thus they might get dropped during migration, domain
Dňa 29.9.2011 18:22, Eric Blake wrote / napísal(a):
Add a test for the simple parts of my indentation changes, and
fix the fallout.
* tests/domainsnapshotxml2xmltest.c: New test.
* tests/Makefile.am (domainsnapshotxml2xmltest_SOURCES): Build it.
* src/conf/domain_conf.c
On Wed, Oct 19, 2011 at 02:47:36PM -0600, Eric Blake wrote:
Looks good (better would be using openpty(), once gnulib changes
that to LGPLv2+, but I'll deal with that in a later patch). So,
while waiting on gnulib changes, I'll temporarily #ifdef out this
code so that I don't break mingw
On Wed, Oct 19, 2011 at 04:42:56PM +0200, Michal Privoznik wrote:
This attribute says what to do with cdrom (or floppy) if
the source is missing. It accepts:
- mandatory - fail if missing for any reason (the default)
- requisite - fail if missing on boot up, drop if missing on
On Wed, Oct 19, 2011 at 04:42:57PM +0200, Michal Privoznik wrote:
This function checks if a given path is accessible under
given uid and gid.
---
src/util/util.c | 76
+++
src/util/util.h |3 ++
2 files changed, 79 insertions(+), 0
On Wed, Oct 19, 2011 at 04:42:58PM +0200, Michal Privoznik wrote:
This patch implements on_missing feature in qemu driver.
Upon qemu startup process an accessibility of CDROMs
and floppy disks is checked. The source might get dropped
if unavailable and on_missing is set accordingly.
No event
On Wed, Oct 19, 2011 at 07:26:24PM +0200, Jiri Denemark wrote:
It still needs to be enhanced to be fully portable and working even if
fsync() implementation is insane (e.g., on OSX).
---
Notes:
Although ideally gnulib would provide us with a sane fsync() and
fdatasync() replacements
On Wed, Oct 19, 2011 at 04:42:59PM +0200, Michal Privoznik wrote:
If a disk source gets dropped because it is not accessible,
mgmt application might want to be informed about this. Therefore
we need to emit an event. The event presented in this patch
is however a bit superset of what written
On Wed, Oct 19, 2011 at 07:26:25PM +0200, Jiri Denemark wrote:
When saving config files we just overwrite old content of the file. In
case something fails during that process (e.g. disk gets full) we lose
both old and new content. This patch makes the process more robust by
writing the new
On Wed, Oct 19, 2011 at 07:26:26PM +0200, Jiri Denemark wrote:
Every time we write XML into a file we call virEmitXMLWarning to write a
warning that the file is automatically generated. virXMLSaveFile
simplifies this into a single step and makes rewriting existing XML file
safe by using
On Wed, Oct 19, 2011 at 07:26:27PM +0200, Jiri Denemark wrote:
---
src/conf/domain_conf.c | 49 +---
src/conf/network_conf.c | 34 +-
src/conf/nwfilter_conf.c | 68
+++---
The 20/10/11, Daniel P. Berrange wrote:
On Thu, Oct 20, 2011 at 08:50:35AM +0200, Philipp Hahn wrote:
Hello,
I sometimes get foreign qcow2 images with embedded snapshots. Without the
corresponding XML files libvirt doesn't recognize them. Therefor I created
the attached script to
On 09/29/2011 06:22 PM, Eric Blake wrote:
The improvements to virBuffer, along with a paradigm shift to pass
the original buffer through rather than creating a second buffer,
allow us to shave off quite a few lines of code.
* src/util/sysinfo.h (virSysinfoFormat): Alter signature.
*
To support managed mode of host PCI device, we record the original
states (unbind_from_stub, remove_slot, and reprobe) so that could
reattach the device to host with original driver. But there is no XML
for theses attrs, and thus after daemon is restarted, we lose the
original states. It's easy to
On Thu, Oct 20, 2011 at 12:14:57PM +0200, Peter Krempa wrote:
On 09/29/2011 06:22 PM, Eric Blake wrote:
The improvements to virBuffer, along with a paradigm shift to pass
the original buffer through rather than creating a second buffer,
allow us to shave off quite a few lines of code.
*
Hi,
There is a little difference between the output of domxml-to-native and the
actual commandline.
No matter qemu is in control or readline mode, domxml-to-native always converts
it to readline mode.
That is because the parameter monitor_json for qemuBuildCommandLine() is
always set to false
We have a new type dir in addition to file and block, but
virsh doen't know it. Fix it.
Additionally, the patch lets virsh output unknown if not matched
any of them.
---
tools/virsh.c | 19 ---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/tools/virsh.c
于 2011年10月20日 18:44, Ryota Ozaki 写道:
We have a new type dir in addition to file and block, but
s/type/vol type/
virsh doen't know it. Fix it.
s/doen't/doesn't/
Additionally, the patch lets virsh output unknown if not matched
any of them.
---
tools/virsh.c | 19 ---
1
On 09/29/2011 06:22 PM, Eric Blake wrote:
Auto-indent makes life a bit easier; this patch also drops unused
arguments and fixes a flag name.
* src/conf/cpu_conf.h (virCPUFormatFlags): Fix typo.
(virCPUDefFormat, virCPUDefFormatBuf): Drop unused arguments.
* src/conf/cpu_conf.c (virCPUDefFormat,
On 09/29/2011 06:22 PM, Eric Blake wrote:
More simplifications possible due to auto-indent. Also,
bandwidth withinactual was only using 6 instead of 8 spaces.
* src/util/network.h (virVirtualPortProfileFormat)
(virBandwidthDefFormat): Alter signature.
* src/util/network.c
On Thu, Oct 20, 2011 at 03:03:25PM +0200, Peter Krempa wrote:
On 10/20/2011 12:20 PM, Daniel P. Berrange wrote:
On Thu, Oct 20, 2011 at 12:14:57PM +0200, Peter Krempa wrote:
On 09/29/2011 06:22 PM, Eric Blake wrote:
The improvements to virBuffer, along with a paradigm shift to pass
the
On 10/20/2011 12:20 PM, Daniel P. Berrange wrote:
On Thu, Oct 20, 2011 at 12:14:57PM +0200, Peter Krempa wrote:
On 09/29/2011 06:22 PM, Eric Blake wrote:
The improvements to virBuffer, along with a paradigm shift to pass
the original buffer through rather than creating a second buffer,
allow
From: Daniel P. Berrange berra...@redhat.com
While Xen only has a single paravirt console, UML, and
QEMU both support multiple paravirt consoles. The LXC
driver can also be trivially made to support multiple
consoles. This patch extends the XML to allow multiple
console elements in the XML. It
From: Daniel P. Berrange berra...@redhat.com
When no target element was set at all, the default console
target type was not being honoured
* src/conf/domain_conf.c: Set default target type for consoles
with no target
---
src/conf/domain_conf.c |3 +++
1 files changed, 3 insertions(+), 0
From: Daniel P. Berrange berra...@redhat.com
To allow virDomainOpenConsole to access non-primary consoles,
device aliases are required to be set. Until now only the QEMU
driver has done this. Update LXC UML to set aliases for any
console devices
* src/lxc/lxc_driver.c, src/uml/uml_driver.c: Set
From: Daniel P. Berrange berra...@redhat.com
Currently the LXC controller only supports setup of a single
text console. This is wired up to the container init's stdio,
as well as /dev/console and /dev/tty1. Extending support for
multiple consoles, means wiring up additional PTYs to /dev/tty2,
The current XML schema only allows for a single console element
per guest. Many hypervisors support multiple paravirt consoles,
and it'd be desirable to support that. This series does just that,
enabling multiple consoles for UML, QEMU and LXC
--
libvir-list mailing list
libvir-list@redhat.com
From: Daniel P. Berrange berra...@redhat.com
The current I/O code for LXC uses a hand crafted event loop
to forward I/O between the container host app, based on
epoll to handle EOF on PTYs. This event loop is not easily
extendable to add more consoles, or monitor other types of
file descriptors.
From: Daniel P. Berrange berra...@redhat.com
qemuBuildVirtioSerialPortDevStr was mistakenly accessing the
target.name field in the virDomainChrDef object for chardevs
belonging to a console. Those chardevs only have port set,
and if there's 1 console, the 1port number results in
trying to
This is a 4rd version of patches [1].
Diff to v3 includes Daniel's review and some other improvements.
The aim of these patches is to mark CDROM and floppy optional,
thus they might get dropped during migration, domain startup,
restore, etc. The granularity is set on disk level, so user
can
From: Daniel P. Berrange berra...@redhat.com
The default console type may vary based on the OS type. ie a Xen
paravirt guests wants a 'xen' console, while a fullvirt guests
wants a 'serial' console.
A plain integer default console type in the capabilities does
not suffice. Instead introduce a
This patch is rather cosmetic as it only moves device alias
assignation from command line construction just before that.
However, it is needed in connotation of previous and next patch.
---
src/qemu/qemu_command.c |5 +
src/qemu/qemu_command.h |1 +
src/qemu/qemu_driver.c |3
This function checks if a given path is accessible under
given uid and gid.
---
src/util/util.c | 78 +++
src/util/util.h |3 ++
2 files changed, 81 insertions(+), 0 deletions(-)
diff --git a/src/util/util.c b/src/util/util.c
index
This attribute says what to do with cdrom (or floppy) if
the source is missing. It accepts:
- mandatory - fail if missing for any reason (the default)
- requisite - fail if missing on boot up, drop if missing on
migrate/restore/revert
- optional - drop if missing at any start
This patch implements on_missing feature in qemu driver.
Upon qemu startup process an accessibility of CDROMs
and floppy disks is checked. The source might get dropped
if unavailable and on_missing is set accordingly.
No event is emit thought. Look for follow up patch.
---
src/qemu/qemu_domain.c
If a disk source gets dropped because it is not accessible,
mgmt application might want to be informed about this. Therefore
we need to emit an event. The event presented in this patch
is however a bit superset of what written above. The reason is simple:
an intention to be easily expanded, e.g.
On Thu, Oct 20, 2011 at 04:52:52PM +0200, Michal Privoznik wrote:
If a disk source gets dropped because it is not accessible,
mgmt application might want to be informed about this. Therefore
we need to emit an event. The event presented in this patch
is however a bit superset of what written
On Thu, Oct 20, 2011 at 04:52:50PM +0200, Michal Privoznik wrote:
This patch is rather cosmetic as it only moves device alias
assignation from command line construction just before that.
However, it is needed in connotation of previous and next patch.
---
src/qemu/qemu_command.c |5
On Thu, Oct 20, 2011 at 04:52:49PM +0200, Michal Privoznik wrote:
This function checks if a given path is accessible under
given uid and gid.
---
src/util/util.c | 78
+++
src/util/util.h |3 ++
2 files changed, 81 insertions(+), 0
On Thu, Oct 20, 2011 at 04:52:48PM +0200, Michal Privoznik wrote:
This attribute says what to do with cdrom (or floppy) if
the source is missing. It accepts:
- mandatory - fail if missing for any reason (the default)
- requisite - fail if missing on boot up, drop if missing on
On Thu, Oct 20, 2011 at 04:52:51PM +0200, Michal Privoznik wrote:
This patch implements on_missing feature in qemu driver.
Upon qemu startup process an accessibility of CDROMs
and floppy disks is checked. The source might get dropped
if unavailable and on_missing is set accordingly.
No event
On 10/20/2011 08:52 AM, Michal Privoznik wrote:
This function checks if a given path is accessible under
given uid and gid.
---
src/util/util.c | 78 +++
src/util/util.h |3 ++
2 files changed, 81 insertions(+), 0 deletions(-)
diff
From: Roopa Prabhu ropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1.
There are still some inconsistencies in the file with respect
to what the return variable is initialized to. Can be fixed
as a separate patch if needed. The scope of this patch is just
to fix the
On 10/20/2011 10:42 PM, Roopa Prabhu wrote:
From: Roopa Prabhu ropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1.
There are still some inconsistencies in the file with respect
to what the return variable is initialized to. Can be fixed
as a separate patch if
From: Roopa Prabhu ropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1.
There are still some inconsistencies in the file with respect
to what the return variable is initialized to. Can be fixed
as a separate patch if needed. The scope of this patch is just
to fix the
On 10/20/11 10:22 AM, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
wrote:
On 10/20/2011 10:42 PM, Roopa Prabhu wrote:
From: Roopa Prabhu ropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1.
There are still some inconsistencies in the file with respect
to
We're working on libvirt support for block device authentication [1]. To
authenticate, rbd needs a username and a secret. Normally, to
avoid putting the secret on the command line, you can store the secret
in a file and pass the file to qemu, but when this is automated,
there's no good way to
On 10/20/2011 01:46 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1.
There are still some inconsistencies in the file with respect
to what the return variable is initialized to. Can be fixed
as a separate patch if needed.
On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote:
We're working on libvirt support for block device authentication [1]. To
authenticate, rbd needs a username and a secret. Normally, to
avoid putting the secret on the command line, you can store the secret
in a file and pass the file
In a recent expansion of the documentation on network forward modes, I
incorrectly stated that incoming sessions to guests on routed networks
were blocked. This is true for guests on NATed networks, but not
routed. This patch corrects that error, and adds a pointer to the
nwfilter page for those
On 10/20/2011 01:29 PM, Laine Stump wrote:
In a recent expansion of the documentation on network forward modes, I
incorrectly stated that incoming sessions to guests on routed networks
were blocked. This is true for guests on NATed networks, but not
routed. This patch corrects that error, and
On 10/16/2011 08:49 PM, Osier Yang wrote:
Oh, you already made the patch, :)
? 2011?10?15? 07:11, Eric Blake ??:
Clarify some of the effects of managed passthroughhostdev devices;
with today's recent changes, a nodedev-reattach is only needed to
pair up to an explicit nodedev-dettach (but
That's a long subject; do 'git shortlog -30' to get a feel for the
average commit message length. I shortened it to:
qemu: allow json in domxml-to-native
On 10/20/2011 04:37 AM, tangchen wrote:
Hi,
There is a little difference between the output of domxml-to-native and the
actual
Rather than making all clients of monitor commands that are JSON-only
check whether yajl support was compiled in, it is simpler to just
avoid setting the capability bit up front if we can't use the capability.
* src/qemu/qemu_capabilities.c (qemuCapsComputeCmdFlags): Only set
capability bit if we
On 10/20/2011 02:57 AM, Daniel P. Berrange wrote:
On Thu, Oct 20, 2011 at 08:50:35AM +0200, Philipp Hahn wrote:
Hello,
I sometimes get foreign qcow2 images with embedded snapshots. Without the
corresponding XML files libvirt doesn't recognize them. Therefor I created
the attached script to
On 10/20/11 11:57 AM, Laine Stump la...@laine.org wrote:
On 10/20/2011 01:46 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1.
There are still some inconsistencies in the file with respect
to what the return variable is
On 10/20/2011 12:24 PM, Daniel P. Berrange wrote:
On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote:
We're working on libvirt support for block device authentication [1]. To
authenticate, rbd needs a username and a secret. Normally, to
avoid putting the secret on the command line, you
On 10/17/2011 07:43 PM, Hai Dong Li wrote:
Okay, forget the context line.
What I wanted to say is that the function virBufferAdd in the buf.c
still has the const before the virBufferPtr while the declaration of
this function in buf.h has const removed, after applying this patch.
Ah, yes, and
On 10/19/2011 04:21 AM, Peter Krempa wrote:
On 09/29/2011 06:22 PM, Eric Blake wrote:
The next patch wants to add some sanity checking, which would
be a different error than ENOMEM. Many existing callers blindly
report OOM failure if virBuf reports an error, and this will be
wrong in the
On 10/19/2011 04:06 AM, Peter Krempa wrote:
On 09/29/2011 06:22 PM, Eric Blake wrote:
* tests/testutils.c (virtTestDifference): Make it easier to
diagnose test failures.
ACK,
Pushed now.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
On 10/19/2011 11:51 AM, Peter Krempa wrote:
On 09/29/2011 06:22 PM, Eric Blake wrote:
Rather than having to adjust all callers in a chain to deal with
indentation, it is nicer to have virBuffer do auto-indentation.
virBufferAdd(const virBufferPtr buf, const char *str, int len)
{
unsigned
On 10/19/2011 10:04 PM, Hai Dong Li wrote:
On 10/20/2011 03:08 AM, Peter Krempa wrote:
Dňa 29.9.2011 18:22, Eric Blake wrote / napísal(a):
domainsnapshot is the first public instance ofdomain being
used as a sub-element, although we have two other private uses
(runtime state, and migration
On 10/20/2011 01:23 AM, Hai Dong Li wrote:
On 09/30/2011 12:22 AM, Eric Blake wrote:
diff --git a/tests/domainsnapshotxml2xmlout/all_parameters.xml
b/tests/domainsnapshotxml2xmlout/all_parameters.xml
index ed4a600..eb2ee85 100644
--- a/tests/domainsnapshotxml2xmlout/all_parameters.xml
+++
On 10/20/2011 04:20 AM, Daniel P. Berrange wrote:
On Thu, Oct 20, 2011 at 12:14:57PM +0200, Peter Krempa wrote:
On 09/29/2011 06:22 PM, Eric Blake wrote:
The improvements to virBuffer, along with a paradigm shift to pass
the original buffer through rather than creating a second buffer,
allow
---
libvirt-gobject/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libvirt-gobject/Makefile.am b/libvirt-gobject/Makefile.am
index 7013675..1c36fb0 100644
--- a/libvirt-gobject/Makefile.am
+++ b/libvirt-gobject/Makefile.am
@@ -99,7 +99,7 @@ CLEANFILES =
On 10/20/2011 06:35 AM, Peter Krempa wrote:
On 09/29/2011 06:22 PM, Eric Blake wrote:
Auto-indent makes life a bit easier; this patch also drops unused
arguments and fixes a flag name.
* src/conf/cpu_conf.h (virCPUFormatFlags): Fix typo.
(virCPUDefFormat, virCPUDefFormatBuf): Drop unused
On 10/20/2011 07:00 AM, Peter Krempa wrote:
On 09/29/2011 06:22 PM, Eric Blake wrote:
More simplifications possible due to auto-indent. Also,
bandwidth withinactual was only using 6 instead of 8 spaces.
+++ b/src/util/network.h
@@ -1,7 +1,7 @@
/*
* network.h: network helper APIs for libvirt
---
vapi/Makefile.am | 20 +++-
1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/vapi/Makefile.am b/vapi/Makefile.am
index 129ce58..1e94a87 100644
--- a/vapi/Makefile.am
+++ b/vapi/Makefile.am
@@ -11,25 +11,27 @@ vapi_DATA = \
On 10/19/2011 01:51 AM, Daniel P. Berrange wrote:
On Tue, Oct 18, 2011 at 12:55:25PM -0700, David L Stevens wrote:
This patch adds support for continue and return actions
in filter rules.
Signed-off-by: David L Stevensdlstev...@us.ibm.com
ACK
Though it'd be good to update
于 2011年10月21日 04:16, Eric Blake 写道:
On 10/16/2011 08:49 PM, Osier Yang wrote:
Oh, you already made the patch, :)
? 2011?10?15? 07:11, Eric Blake ??:
Clarify some of the effects of managed passthroughhostdev devices;
with today's recent changes, a nodedev-reattach is only needed to
pair up to
At 10/21/2011 04:39 AM, Eric Blake Write:
Rather than making all clients of monitor commands that are JSON-only
check whether yajl support was compiled in, it is simpler to just
avoid setting the capability bit up front if we can't use the capability.
* src/qemu/qemu_capabilities.c
tested-by :Royce Lvlvro...@linux.vnet.ibm.com
patch workes expected,qemu version 0.15.50.reboot domain with ACPI support.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 2011-10-21 5:48, Josh Durgin wrote:
On 10/20/2011 12:24 PM, Daniel P. Berrange wrote:
On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote:
We're working on libvirt support for block device authentication
[1]. To
authenticate, rbd needs a username and a secret. Normally, to
avoid
Eric,
Thanks -- looks good to me.
return is useful for doing multiple chains on one packet --
drop if
it isn't acceptable and return to do further checks in other chains for
the
acceptable ones.
The current fixed-set of protocol chains are mutually exclusive
which
84 matches
Mail list logo
