This email is automatically generated.
The test result is based on the following git commit:
9765653 qemu: allow getting < max typed parameters
For details, please see attachment.
Regards,
Alex
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-li
commit 27908453 introduces a regression, and it will
cause libvirt crashed when starting network.
The reason is that tapfd may be NULL, but we dereference
it without checking whether it is NULL.
---
src/util/bridge.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
d
Send and receive string typed parameters across RPC.
* src/remote/remote_protocol.x (remote_typed_param_value): Add
another union value.
* daemon/remote.c (remoteSerializeTypedParameters)
(remoteDeserializeTypedParameters): Handle strings on rpc.
* src/remote/remote_driver.c (remoteFreeTypedParame
Qemu will be the first driver to make use of a typed string in the
next round of additions. Separate out the trivial addition.
* src/qemu/qemu_driver.c (qemudSupportsFeature): Advertise feature.
(qemuDomainGetBlkioParameters, qemuDomainGetMemoryParameters)
(qemuGetSchedulerParametersFlags, qemudD
This allows strings to be transported between client and server
in the context of name-type-value virTypedParameter functions.
For compatibility,
o new clients will not send strings to old servers, based on
a feature check
o new servers will not send strings to old clients without th
This builds on v4:
https://www.redhat.com/archives/libvir-list/2011-October/msg00446.html
It only implements the front end of supporting typed strings across
an RPC call; I'm still working on refactoring the back half of the
v4 series to actually wire up blkio device weights to be the first
use th
On 10/20/2011 08:47 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
The current I/O code for LXC uses a hand crafted event loop
to forward I/O between the container& host app, based on
epoll to handle EOF on PTYs. This event loop is not easily
extendable to add more consoles, or monito
On 10/20/2011 08:47 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
qemuBuildVirtioSerialPortDevStr was mistakenly accessing the
target.name field in the virDomainChrDef object for chardevs
belonging to a console. Those chardevs only have port set,
and if there's> 1 console, the> 1por
On 10/20/2011 08:47 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
While Xen only has a single paravirt console, UML, and
QEMU both support multiple paravirt consoles. The LXC
driver can also be trivially made to support multiple
consoles. This patch extends the XML to allow multiple
Document the parameter names that will be used by
virDomain{Get,Set}SchedulerParameters{,Flags}, rather than
hard-coding those names in each driver, to match what is
done with memory, blkio, and blockstats parameters.
* include/libvirt/libvirt.h.in (VIR_DOMAIN_SCHEDULER_CPU_SHARES)
(VIR_DOMAIN_SCH
On 11/01/2011 04:47 AM, Stefan Berger wrote:
On 10/31/2011 07:33 PM, Eric Blake wrote:
Since all virTypedParameter APIs allow us to return the number
of slots we actually populated, we should allow the user to
call with nparams too small (without overrunning their array)
or too large (ignoring t
2011/10/21 Patrice LACHANCE :
> Hello
Sorry for the late response.
> Based on http://www.redhat.com/archives/libvir-list/2010-July/msg00480.html,
> I created this quick patch to accept connection to vSphere 5.x
The patch looks good in general.
> Notes:
> - I had to remove the warnings for versi
2011/11/1 Eric Blake :
> On 11/01/2011 10:21 AM, Matthias Bolte wrote:
>>
>> Allow the datacenter and compute resource parts of the path
>> to be prefixed with folders. Therefore, the way the path is
>> parsed has changed. Before, it was split in 2 or 3 items and
>> the items' meanings were determi
From: "Zeeshan Ali (Khattak)"
This frees us from maintaining the sections file.
---
docs/libvirt-gconfig/Libvirt-gconfig-sections.txt | 166 --
docs/libvirt-gconfig/Makefile.am |2 +-
docs/libvirt-glib/Libvirt-glib-sections.txt | 22 --
docs/libvirt-glib
On 11/01/2011 05:11 AM, Daniel P. Berrange wrote:
On Tue, Nov 01, 2011 at 05:49:06PM +0800, Wen Ruo Lv wrote:
with /etc/libvirt/libvirt.conf below:
uri_aliases = [
"hail=qemu:///system",
"sleet=qemu+ssh://root 9 115 122 57/system",
"sam=qemu+unix:///system?socket=/var/run/libvirt/libvi
On 11/01/2011 01:15 AM, Alexander Biryukov wrote:
Good afternoon.
I apologize for my English.
Error on page: http://libvirt.org/formatdomain.html
To be more precise in the line ""
Thanks; I'm pushing this as the trivial fix:
diff --git i/docs/formatdomain.html.in w/docs/formatdomain.html.in
i
On 11/01/2011 10:21 AM, Matthias Bolte wrote:
Allow the datacenter and compute resource parts of the path
to be prefixed with folders. Therefore, the way the path is
parsed has changed. Before, it was split in 2 or 3 items and
the items' meanings were determined by their positions. Now
the path c
On 11/01/2011 10:28 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
If an LXC VM fails to start, quite a few cleanup paths will
result in the original error message being overwritten. Some
other cleanup paths also forgot to actually terminate the VM.
* src/lxc/lxc_driver.c: Ensure VM i
From: "Daniel P. Berrange"
If an LXC VM fails to start, quite a few cleanup paths will
result in the original error message being overwritten. Some
other cleanup paths also forgot to actually terminate the VM.
* src/lxc/lxc_driver.c: Ensure VM is terminated on startup
failure and preserve orig
Allow the datacenter and compute resource parts of the path
to be prefixed with folders. Therefore, the way the path is
parsed has changed. Before, it was split in 2 or 3 items and
the items' meanings were determined by their positions. Now
the path can have 2 or more items and the the vCenter serv
On Tue, Nov 01, 2011 at 09:21:50AM -0600, Eric Blake wrote:
> On 11/01/2011 09:02 AM, Daniel P. Berrange wrote:
> >From: "Daniel P. Berrange"
> >
> >The LXC code for mounting container filesystems from block devices
> >tries all filesystems in /etc/filesystems and possibly those in
> >/proc/filesys
On 11/01/2011 09:02 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
The LXC code for mounting container filesystems from block devices
tries all filesystems in /etc/filesystems and possibly those in
/proc/filesystems. The regular mount binary, however, first tries
using libblkid to dete
On 11/01/2011 11:02 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
If we looped through /etc/filesystems trying to mount with each
type and failed all options, we forget to actually raise an
error message.
* src/lxc/lxc_container.c: Raise error if unable to detect
the filesystems.
On Tue, Nov 01, 2011 at 14:49:46 +, Daniel P. Berrange wrote:
> On Tue, Nov 01, 2011 at 03:46:06PM +0100, Jiri Denemark wrote:
> > From: Michal Privoznik
> >
> > If daemon is using SASL it reads client data into a cache. This cache is
> > big (usually 65KB) and can thus contain 2 or more mess
On 11/01/2011 07:00 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
The kernel automounter is mostly broken wrt to containers. Most
notably if you start a new filesystem namespace and then attempt
to unmount any autofs filesystem, it will typically fail with a
wierd error message like
From: "Daniel P. Berrange"
The LXC code for mounting container filesystems from block devices
tries all filesystems in /etc/filesystems and possibly those in
/proc/filesystems. The regular mount binary, however, first tries
using libblkid to detect the format. Add support for doing the same
in li
On 11/01/2011 08:31 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
The /etc/filesystems file can contain a '*' on the last line to
indicate that /proc/filessystems should be tried next. We have
a check that this '*' only occurs on the last line. Unfortunately
when we then start reading
On 11/01/2011 09:02 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
If we looped through /etc/filesystems trying to mount with each
type and failed all options, we forget to actually raise an
error message.
* src/lxc/lxc_container.c: Raise error if unable to detect
the filesystems.
On 11/01/2011 08:31 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
Only some of the return paths of lxcContainerWaitForContinue will
have set errno. In other paths we need to set it manually to avoid
the caller getting a random stale errno value
* src/lxc/lxc_container.c: Set errno in
From: "Daniel P. Berrange"
If we looped through /etc/filesystems trying to mount with each
type and failed all options, we forget to actually raise an
error message.
* src/lxc/lxc_container.c: Raise error if unable to detect
the filesystems. Also fix existing error message
---
src/lxc/lxc_con
On 11/01/2011 08:31 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange"
We already have a /var/lib/libvirt/images for OS install images.
We need a separate /var/lib/libvirt/filesystems for OS install
trees, since SELinux labelling will be different
* libvirt.spec.in: Add /var/lib/libvirt/f
On Tue, Nov 01, 2011 at 03:46:06PM +0100, Jiri Denemark wrote:
> From: Michal Privoznik
>
> If daemon is using SASL it reads client data into a cache. This cache is
> big (usually 65KB) and can thus contain 2 or more messages. However,
> on socket event we can dispatch only one message. So if we
From: Michal Privoznik
If daemon is using SASL it reads client data into a cache. This cache is
big (usually 65KB) and can thus contain 2 or more messages. However,
on socket event we can dispatch only one message. So if we read two
messages at once, the second will not be dispatched as the socke
On Tue, Nov 01, 2011 at 02:14:54PM +0100, Michal Privoznik wrote:
> If daemon is using SASL it reads client data into a cache. This cache is
> big (usually 65KB) and can thus contain 2 or more messages. However,
> on socket event we can dispatch only one message. So if we read two
> messages at onc
On Tue, Nov 01, 2011 at 10:59:39AM +0800, Jiff Shen wrote:
> Hi,
>
> We are using Ubuntu 10.04 eucalyptus 1.6.2 and libvirt 0.7.5. We found
> eucalyptus-nc sometimes hangs in virDomainCreateXML, and never gets
> response from libvirtd.
> After 2 days of investigation, I found there is another libv
On 11/01/2011 04:44 AM, Justin Clift wrote:
Fails on OSX 10.6.8, with this:
make all-am
Undefined symbols:
"_ptsname_r", referenced from:
_virFileOpenTty in libvirt_util.a(libvirt_util_la-util.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[3
Hi,
We are using Ubuntu 10.04 eucalyptus 1.6.2 and libvirt 0.7.5. We found
eucalyptus-nc sometimes hangs in virDomainCreateXML, and never gets
response from libvirtd.
After 2 days of investigation, I found there is another libvirt client
connects to libvirtd 'qemu:///system', which is the same URI
On Tue, Nov 01, 2011 at 14:14:54 +0100, Michal Privoznik wrote:
> If daemon is using SASL it reads client data into a cache. This cache is
> big (usually 65KB) and can thus contain 2 or more messages. However,
> on socket event we can dispatch only one message. So if we read two
> messages at once,
If daemon is using SASL it reads client data into a cache. This cache is
big (usually 65KB) and can thus contain 2 or more messages. However,
on socket event we can dispatch only one message. So if we read two
messages at once, the second will not be dispatched as the socket event
goes away with fi
From: "Daniel P. Berrange"
The kernel automounter is mostly broken wrt to containers. Most
notably if you start a new filesystem namespace and then attempt
to unmount any autofs filesystem, it will typically fail with a
wierd error message like
Failed to unmount '/.oldroot/sys/kernel/security'
From: "Daniel P. Berrange"
The /etc/filesystems file can contain a '*' on the last line to
indicate that /proc/filessystems should be tried next. We have
a check that this '*' only occurs on the last line. Unfortunately
when we then start reading /proc/filesystems, we mistakenly think
we've seen
From: "Daniel P. Berrange"
Only some of the return paths of lxcContainerWaitForContinue will
have set errno. In other paths we need to set it manually to avoid
the caller getting a random stale errno value
* src/lxc/lxc_container.c: Set errno in lxcContainerWaitForContinue
---
src/lxc/lxc_conta
From: "Daniel P. Berrange"
We already have a /var/lib/libvirt/images for OS install images.
We need a separate /var/lib/libvirt/filesystems for OS install
trees, since SELinux labelling will be different
* libvirt.spec.in: Add /var/lib/libvirt/filesystems
* src/Makefile.am: Create /var/lib/libvi
This email is automatically generated.
The test result is based on the following git commit:
c85013b Fix storage pool source comparison to avoid comparing with self
Analysis summary report:
Files analyzed : 232
Total LoC input to cov-analyze : 326003
Funct
When PyGrub is used as the bootloader in Xen, it gets passed the first
bootable disk. Xend supports a "bootable"-flag for this, which was
previously unused.
In commit c2969ec7aec5c40519aadf422ab5c47a21938bff the bootable=1 flag
was used to re-order the disks when converting from SEXPR to XML, such
Allow /capabilities/guest/features/deviceboot.
Signed-off-by: Philipp Hahn
---
docs/schemas/capability.rng |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng
index 99b4a9a..0a63a1c 100644
--- a/docs/schemas/capab
Add support for adding the bootable S-Expr to disks. This is needd for
Xen-PV domains using GyPgrub as the boot loader.
Signed-off-by: Philipp Hahn
---
src/xen/xend_internal.c |4 ++--
src/xenxs/xen_sxpr.c| 13 +++--
src/xenxs/xen_sxpr.h|2 +-
3 files changed, 14 insert
When using PyGrub as the boot-loader for Xen-PV domains, Xend passes the first
disk marked as bootable to it. Xend automatically sets this flag to 1 for the
first disk created for a domain.
Until commit c1a98d88255197a8446d08c0b1589861660e9064 the order of disks could
be changed by re-ordering the
Adapt all Xen-sexpr tests to now contain the extra '(bootbale [01])'
flag. It is explicitly set, otherwise Xend remembers the old state
and only ever adds the bootable indicator.
Signed-off-by: Philipp Hahn
---
v2: Add deviceboot capability.
---
tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml
On 10/31/2011 07:33 PM, Eric Blake wrote:
Since all virTypedParameter APIs allow us to return the number
of slots we actually populated, we should allow the user to
call with nparams too small (without overrunning their array)
or too large (ignoring the tail of the array that we can't fill),
rath
On Tue, Nov 01, 2011 at 02:37:27AM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)"
>
> This patch adds gtk-doc-based documentation. The generated docs aren't
> very complete (or even correct) but this is a good start.
> ---
> Makefile.am
On 10/31/2011 07:33 PM, Eric Blake wrote:
virDomainBlockStatsFlags was missing a check that was present in
virDomainGetMemoryParameters. Additionally, I found that the
existing descriptions were a bit hard to read. A later patch
will fix qemu to return fewer than max parameters if @nparams
was
On Tue, Nov 01, 2011 at 12:08:58PM +0100, Guido Günther wrote:
> Hi Daniel,
>
> On Tue, Oct 11, 2011 at 11:26:59AM +0100, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange"
> >
> > If we are comparing storage pools we must skip comparing with
> > ourself, so that re-defining an existing po
On Tue, Nov 01, 2011 at 05:49:06PM +0800, Wen Ruo Lv wrote:
>
> with /etc/libvirt/libvirt.conf below:
> uri_aliases = [
> "hail=qemu:///system",
> "sleet=qemu+ssh://root 9 115 122 57/system",
> "sam=qemu+unix:///system?socket=/var/run/libvirt/libvirt-sock",
> ]
> Neither "virsh -c hailly" no
Hi Daniel,
On Tue, Oct 11, 2011 at 11:26:59AM +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"
>
> If we are comparing storage pools we must skip comparing with
> ourself, so that re-defining an existing pool works
>
> * conf/storage_conf.c: Skip self when comparing
> ---
> src/co
On 31/10/2011, at 8:51 PM, Daniel Veillard wrote:
> We are now entering the freeze for libvirt-0.9.7 .
> We may make an exception for patch set which got a few round of reviews
> though, like Stefan's ones (v4 IIRC), and anything which we know may
> need fixing in the API before the release.
>
>
On Mon, Oct 31, 2011 at 04:23:35PM -0500, Christian Benvenuti (benve) wrote:
> > -Original Message-
> > From: qemu-devel-bounces+benve=cisco@nongnu.org [mailto:qemu-devel-
> > bounces+benve=cisco@nongnu.org] On Behalf Of Daniel P. Berrange
> > Sent: Monday, October 31, 2011 3:49 AM
with /etc/libvirt/libvirt.conf below:
uri_aliases = [
"hail=qemu:///system",
"sleet=qemu+ssh://root 9 115 122 57/system",
"sam=qemu+unix:///system?socket=/var/run/libvirt/libvirt-sock",
]
Neither "virsh -c hailly" nor "hai" should result in matching
"hail=qemu:///system"
Fix URI alias pref
On 2011?11?01? 15:12, Philipp Hahn wrote:
Now you have it the other way around, that any prefix matches:
"virsh -c hai" will match "hail".
Why not simply use STREQ instead of STREQLEN?
Sincerely
Philipp
ooops..You're right.But here I think we can't use STREQ because in
config file the com
Hello Wen,
On Tuesday 01 November 2011 04:08:24 Wen Ruo Lv wrote:
> With /etc/libvirt/libvirt.conf below:
> uri_aliases = [
> "hail=qemu:///system",
> "sleet=qemu+ssh://root 9 115 122 57/system",
> "sam=qemu+unix:///system?socket=/var/run/libvirt/libvirt-sock",
> ]
> Issue "virsh -c hailly"
60 matches
Mail list logo