[libvirt] build failed with warning failed to load external entity api.html.tmp

2011-11-08 Thread Wenyi Gao
I got the latest code and build it with following error on Ubuntu 11.10: .. make all-am make[3]: Entering directory `/home/wayne/workspace/project/libvirt/tools' CC virsh-console.o CC virsh-virsh.o CCLD virsh GENvirt-xml-validate GENvirt-pki-validate make[3]:

Re: [libvirt] [PATCH] [configure] Fix libvirt dependency, and use $VAPIGEN

2011-11-08 Thread Nirbheek Chauhan
On Mon, Nov 7, 2011 at 10:10 PM, Eric Blake ebl...@redhat.com wrote: To make it easier for yourself, add this to libvirt-glib/.git/config: [format]        subjectprefix = libvirt-glib PATCH (or similarly for any other libvrit-SUB project).  Then your patches will automatically be prefixed

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Wen Congyang
At 11/08/2011 02:22 PM, Justin Clift Write: On 08/11/2011, at 5:17 PM, Justin Clift wrote: Hi guys, Just tried make rpm with git head, on RHEL 6.x. It gave the following failure: make[1]: Leaving directory `/home/jc/git_repos/libvirt' make[1]: Entering directory

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Wenyi Gao
On 2011年11月08日 16:58, Wen Congyang wrote: At 11/08/2011 02:22 PM, Justin Clift Write: On 08/11/2011, at 5:17 PM, Justin Clift wrote: Hi guys, Just tried make rpm with git head, on RHEL 6.x. It gave the following failure: make[1]: Leaving directory `/home/jc/git_repos/libvirt' make[1]:

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Wen Congyang
At 11/08/2011 05:09 PM, Wenyi Gao Write: On 2011年11月08日 16:58, Wen Congyang wrote: At 11/08/2011 02:22 PM, Justin Clift Write: On 08/11/2011, at 5:17 PM, Justin Clift wrote: Hi guys, Just tried make rpm with git head, on RHEL 6.x. It gave the following failure: make[1]: Leaving

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Wenyi Gao
On 2011年11月08日 17:19, Wen Congyang wrote: At 11/08/2011 05:09 PM, Wenyi Gao Write: On 2011年11月08日 16:58, Wen Congyang wrote: At 11/08/2011 02:22 PM, Justin Clift Write: On 08/11/2011, at 5:17 PM, Justin Clift wrote: Hi guys, Just tried make rpm with git head, on RHEL 6.x. It gave the

Re: [libvirt] [PATCHv2] build: fix build on platforms without ptsname_r

2011-11-08 Thread Daniel P. Berrange
On Fri, Nov 04, 2011 at 08:06:05PM -0600, Eric Blake wrote: MacOS lacks ptsname_r, and gnulib doesn't (yet) provide it. But we can avoid it altogether, by using gnulib openpty() instead. Note that we do _not_ want the pt_chown module; all systems that we currently port to can either properly

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Justin Clift
On 08/11/2011, at 8:19 PM, Wen Congyang wrote: snip I seems that NEWS is not included in dist on your machine. Here is my Makefile: DIST_COMMON = README $(am__configure_deps) $(srcdir)/Makefile.am \ $(srcdir)/Makefile.in $(srcdir)/config.h.in \ $(srcdir)/libvirt.pc.in

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Hong Xiang
Please follow Congyang's suggestion to install systemtap-sdt-devel package and redo configure. On 11/08/2011 05:40 PM, Wenyi Gao wrote: On 2011年11月08日 17:33, Hong Xiang wrote: I believe it's due to missing xsltproc binary? Wenyi, same as your earlier failed to load external entity api.html.tmp

[libvirt] Release of libvirt-0.9.7

2011-11-08 Thread Daniel Veillard
With a bit of delay to catch the last set of patches, the release is finally out ! You can get 0.9.7 from ftp://libvirt.org/libvirt/ This is a release mostly focusing on bug fixes and cleanup though there is some features too, including a lot of improvements on the snapshot code. There is

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Wenyi Gao
On 2011年11月08日 17:33, Hong Xiang wrote: I believe it's due to missing xsltproc binary? Wenyi, same as your earlier failed to load external entity api.html.tmp warning. On 11/08/2011 05:23 PM, Wenyi Gao wrote: I also got the error on ubuntu 11.10 when run make distcheck libvirt$ make distcheck

[libvirt] [libvirt-glib 01/23] Add helpers in libvirt-gconfig-helpers.[ch]

2011-11-08 Thread Christophe Fergeau
These helper functions will be useful later on. These functions are not made available to the library user since we don't want to expose too much our libxml internals. --- examples/Makefile.am |1 + libvirt-gconfig/Makefile.am |5 +

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Hong Xiang
I believe it's due to missing xsltproc binary? Wenyi, same as your earlier failed to load external entity api.html.tmp warning. On 11/08/2011 05:23 PM, Wenyi Gao wrote: I also got the error on ubuntu 11.10 when run make distcheck libvirt$ make distcheck { test ! -d libvirt-0.9.6 || { find

Re: [libvirt] [PATCH 4/5] blkiotune: add interface for blkiotune.device_weight

2011-11-08 Thread Stefan Berger
On 11/08/2011 06:00 AM, Hu Tao wrote: This adds per-device weights toblkiotune. Note that the cgroups implementation only supports weights per block device, and not per-file within the device; hence this option must be global to the domain definition rather than tied to individual device/disk

Re: [libvirt] [PATCH 5/5] blkiotune: add qemu support for blkiotune.device_weight

2011-11-08 Thread Stefan Berger
On 11/08/2011 06:00 AM, Hu Tao wrote: Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. --- src/libvirt_private.syms |1 + src/qemu/qemu_cgroup.c | 22 + src/qemu/qemu_driver.c | 216

Re: [libvirt] qemu error: Could not allocate dynamic translator buffer

2011-11-08 Thread Richard W.M. Jones
Sorry, forgot to put the versions: qemu-kvm-0.15.1-1.fc16.x86_64 libvirt-0.9.6-2.fc16.x86_64 kernel 3.1.0-7.fc16.x86_64 Note that this is running inside a guest. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines.

Re: [libvirt] [PATCH 01/33] Remove 'brControl' object

2011-11-08 Thread Stefan Berger
On 11/03/2011 01:29 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The bridge management APIs in src/util/bridge.c require a brControl object to be passed around. This holds the file descriptor for the control socket. This extra object complicates use of the API for

[libvirt] qemu error: Could not allocate dynamic translator buffer

2011-11-08 Thread Richard W.M. Jones
I'm getting a very odd error from qemu: 2011-11-08 13:06:03.403: starting up LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin QEMU_AUDIO_DRV=none /usr/bin/qemu-system-x86_64 -S -M pc-0.14 -no-kvm -m 1024 -smp 1,sockets=1,cores=1,threads=1 -name fedora15_x86_64 -uuid

Re: [libvirt] [PATCH 02/33] Make all brXXX APIs raise errors, instead of returning errnos

2011-11-08 Thread Stefan Berger
On 11/03/2011 01:29 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Currently every caller of the brXXX APIs has to store the returned errno value and then raise an error message. This results in inconsistent error messages across drivers, additional burden on the

Re: [libvirt] [PATCH 03/33] Rename all brXXXX APIs to follow new convention

2011-11-08 Thread Stefan Berger
On 11/03/2011 01:29 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The existing brXXX APIs in src/util/bridge.h are renamed to follow one of three different conventions - virNetDevXXX - operations for any type of interface - virNetDevBridgeXXX - operations

Re: [libvirt] [PATCH 04/33] Turn two int parameters into bools in bridge APIs

2011-11-08 Thread Stefan Berger
On 11/03/2011 01:30 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com * src/util/bridge.c, src/util/bridge.h: s/int/bool/ in virNetDevSetOnline and virNetDevBridgeSetSTP --- src/util/bridge.c | 18 +- src/util/bridge.h |8 2 files

Re: [libvirt] [PATCH 06/33] Add an API for retrieving the MAC address of an interface

2011-11-08 Thread Stefan Berger
On 11/03/2011 01:30 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com * src/util/bridge.c, src/util/bridge.h: Add virNetDevGetMAC --- src/util/bridge.c | 35 +++ src/util/bridge.h |3 +++ 2 files changed, 38 insertions(+), 0

Re: [libvirt] [PATCH 05/33] Expose MTU management APIs

2011-11-08 Thread Stefan Berger
On 11/03/2011 01:30 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The MTU management APIs are useful to other code inside libvirt, so should be exposed as non-static APIs. * src/util/bridge.c, src/util/bridge.h: Expose virNetDevSetMTU, virNetDevSetMTUFromDevice

Re: [libvirt] [PATCH 07/33] Remove usage of brctl command line tool

2011-11-08 Thread Stefan Berger
On 11/03/2011 01:30 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Convert the virNetDevBridgeSetSTP and virNetDevBridgeSetSTPDelay to use ioctls instead of spawning brctl. Implement the virNetDevBridgeGetSTP and virNetDevBridgeGetSTPDelay methods which were declared

Re: [libvirt] [libvirt-glib 11/23] Use gvir_config_object_to_xml

2011-11-08 Thread Christophe Fergeau
On Fri, Oct 07, 2011 at 11:40:56AM +0200, Christophe Fergeau wrote: s/gvir_config_object_get_doc/gvir_config_object_to_xml/ Prefer gvir_config_object_to_xml over gvir_config_object_get_doc since the latter will be removed soon. This one needs an additional diff --git

[libvirt] [PATCH] Allow non-blocking message sending on virNetClient

2011-11-08 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Split the existing virNetClientSend into two parts virNetClientSend and virNetClientSendNoReply, instead of having a 'bool expectReply' parameter. Add a new virNetClientSendNonBlock which returns 2 on full send, 1 on partial send, 0 on no send, -1 on

Re: [libvirt] [PATCH 09/33] Santize naming of socket address APIs

2011-11-08 Thread Stefan Berger
On 11/03/2011 01:30 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The socket address APIs in src/util/network.h either take the form virSocketAddrXXX, virSocketXXX or virSocketXXXAddr. Sanitize this so everything is virSocketAddr, and ensure that the

Re: [libvirt] [PATCH 10/33] Adjust naming of network device bandwidth management APIs

2011-11-08 Thread Stefan Berger
On 11/03/2011 01:30 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Rename virBandwidth to virNetDevBandwidth, and virRate to virNetDevBandwidthRate. * src/util/network.c, src/util/network.h: Rename bandwidth structs and APIs * src/conf/domain_conf.c,

Re: [libvirt] nwfilter - limit VM traffic to specific mac address

2011-11-08 Thread Stefan Berger
On 11/07/2011 04:25 AM, Shahar Havivi wrote: Hi, I want to limit VM traffic to a specific MAC address, ie VMs cannot traffic each other other then a specific gateway. I am using custom nwfilter name: isolatedprivatevlan-vdsm.xml located in /etc/libvirt/nwfilter/: filter

Re: [libvirt] [PATCHv2] build: fix build on platforms without ptsname_r

2011-11-08 Thread Eric Blake
On 11/08/2011 02:29 AM, Daniel P. Berrange wrote: Alas, this is just complicated enough that I don't feel comfortable pushing it under the build-breaker rule, even though I have verified that it fixes builds on both FreeBSD and Cygwin, as well as still behaves correctly with LXC containers on

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Eric Blake
On 11/08/2011 02:37 AM, Justin Clift wrote: Found the problem with the NEWS file. It's because libxslt wasn't installed. Should we be adding libxslt as a maintainer's prereq in bootstrap.conf? That is, I think bootstrap.conf should require all packages necessary to create a functional

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Eric Blake
On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Hmm. virsh attach-disk --type cdrom --mode readonly myguest hdc might look a bit nicer as: virsh attach-disk --type cdrom --mode readonly

[libvirt] [PATCH 1/2] build: allow for local gnulib diffs

2011-11-08 Thread Eric Blake
Commit f7bd00c12 pulled in a gnulib module that fails to compile on mingw. While it would be nice to pull in a newer version of .gnulib that fixes this, it is difficult to backport any .gnulib update to older releases. So, it makes sense to take advantage of gnulib-tool's ability to support

[libvirt] [PATCH 0/2] Fix 0.9.7 for mingw

2011-11-08 Thread Eric Blake
I'm proposing two options to fix the build failure mentioned here: https://www.redhat.com/archives/libvir-list/2011-November/msg00309.html without having to cut a release of 0.9.8. Note that this email is presenting a diff of a diff - that is, patch 2/2 is a diff that creates two new files, whose

[libvirt] [PATCH 2/2] build: fix mingw build of gnulib openpty

2011-11-08 Thread Eric Blake
Commit f7bd00c12 pulled in a gnulib module that fails to compile on mingw. Work around it while waiting for an upstream gnulib fix. * gnulib/local/lib/pty.in.h (openpty): Provide forward declarations of opaque structs not present on mingw. * gnulib/local/lib/openpty.c (openpty): Provide stub for

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Wen Congyang
At 11/09/2011 06:52 AM, Eric Blake Write: On 11/08/2011 02:37 AM, Justin Clift wrote: Found the problem with the NEWS file. It's because libxslt wasn't installed. Should we be adding libxslt as a maintainer's prereq in bootstrap.conf? That is, I think bootstrap.conf should require all

Re: [libvirt] [PATCH 1/5] API: add VIR_TYPED_PARAM_STRING

2011-11-08 Thread Hu Tao
On Tue, Nov 08, 2011 at 07:34:50AM -0500, Stefan Berger wrote: On 11/08/2011 06:00 AM, Hu Tao wrote: Hi Hu, previously I had looked at v6. I suppose this is v7. I'll ACK what I had previously ack'ed in v6. Yes, this is v7. Thanks for ACK again. -- Thanks, Hu Tao -- libvir-list

Re: [libvirt] [PATCH 09/33] Santize naming of socket address APIs

2011-11-08 Thread Laine Stump
make check fails to build after applying this patch: CC sockettest.o sockettest.c:28:27: fatal error: virsocketaddr.h: No such file or directory compilation terminated. On 11/03/2011 01:30 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The socket address

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Xu He Jie
于 2011年11月09日 07:08, Eric Blake 写道: On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Hmm. virsh attach-disk --type cdrom --mode readonly myguest hdc might look a bit nicer as: virsh attach-disk

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Osier Yang
On 11/09/2011 10:34 AM, Xu He Jie wrote: 于 2011年11月09日 07:08, Eric Blake 写道: On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Hmm. virsh attach-disk --type cdrom --mode readonly myguest hdc

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Xu He Jie
于 2011年11月09日 11:05, Osier Yang 写道: On 11/09/2011 10:34 AM, Xu He Jie wrote: 于 2011年11月09日 07:08, Eric Blake 写道: On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Hmm. virsh attach-disk --type

[libvirt] [PATCH] qemu: Fix improper error message for disk detaching

2011-11-08 Thread Osier Yang
s/virDomainDeviceTypeToString/virDomainDiskDeviceTypeToString/ Report by Xu He Jie x...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 118197a..cee689b 100644 ---

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Osier Yang
On 11/09/2011 11:29 AM, Xu He Jie wrote: 于 2011年11月09日 11:05, Osier Yang 写道: On 11/09/2011 10:34 AM, Xu He Jie wrote: 于 2011年11月09日 07:08, Eric Blake 写道: On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from

Re: [libvirt] [PATCH] qemu: Fix improper error message for disk detaching

2011-11-08 Thread Xu He Jie
于 2011年11月09日 12:27, Osier Yang 写道: s/virDomainDeviceTypeToString/virDomainDiskDeviceTypeToString/ Report by Xu He Jiex...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

[libvirt] [test-API][PATCH 3/3] update parser to add clean keyword

2011-11-08 Thread Guannan Ren
--- parser.py | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/parser.py b/parser.py index 085a1f2..883de89 100644 --- a/parser.py +++ b/parser.py @@ -391,12 +391,21 @@ class CaseFileParser(object): if len(tripped_caselist) == 2 and

[libvirt] [test-API][PATCH 1/3] add new clean keyword to clean environment after each testcase

2011-11-08 Thread Guannan Ren
testcase1 option1 avalue option2 bvalue clean testcase2 option1 cvalue option2 dvalue clean --- generator.py | 44 1 files changed, 32 insertions(+), 12 deletions(-) diff --git a/generator.py

[libvirt] [test-API][PATCH 2/3] clean keyword update in libvirt-test-api, mapper, proxy part

2011-11-08 Thread Guannan Ren
--- libvirt-test-api.py |7 +++ mapper.py | 24 +++- proxy.py| 13 + 3 files changed, 35 insertions(+), 9 deletions(-) diff --git a/libvirt-test-api.py b/libvirt-test-api.py index 8a4bacd..171e13c 100644 --- a/libvirt-test-api.py

Re: [libvirt] [PATCH] qemu: Fix improper error message for disk detaching

2011-11-08 Thread Osier Yang
On 11/09/2011 01:02 PM, Xu He Jie wrote: 于 2011年11月09日 12:27, Osier Yang 写道: s/virDomainDeviceTypeToString/virDomainDiskDeviceTypeToString/ Report by Xu He Jiex...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH] lxc: plug memory leak

2011-11-08 Thread ajia
From: Alex Jia a...@redhat.com Detected by Coverity. Leak introduced in commit 9d201a5. * src/lxc/lxc_driver.c: Clean up on failure. Signed-off-by: Alex Jia a...@redhat.com --- src/lxc/lxc_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/lxc/lxc_driver.c

[libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-08 Thread Justin Clift
Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: make[3]: Entering directory `/home/jc/git_repos/libvirt/src' CC libvirt_util_la-bitmap.lo CC libvirt_util_la-authhelper.lo CC libvirt_util_la-bridge.lo CC

[libvirt] [PATCH] lxc: plug memory leak

2011-11-08 Thread ajia
From: Alex Jia a...@redhat.com Detected by Coverity. Leak introduced in commit 0f31f7b. * src/lxc/lxc_driver.c: Clean up on failure. Signed-off-by: Alex Jia a...@redhat.com --- src/lxc/lxc_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/lxc/lxc_driver.c

Re: [libvirt] [PATCH 11/33] Rename virVirtualPortProfileParams APIs

2011-11-08 Thread Laine Stump
On 11/03/2011 01:30 PM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Rename the virVirtualPortProfileParams struct to be virNetDevVPortProfile, and rename the APIs to match this prefix. * src/util/network.c, src/util/network.h: Rename port profile APIs *

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-08 Thread Wen Congyang
At 11/09/2011 03:01 PM, Justin Clift Write: On 09/11/2011, at 9:52 AM, Eric Blake wrote: On 11/08/2011 02:37 AM, Justin Clift wrote: Found the problem with the NEWS file. It's because libxslt wasn't installed. Should we be adding libxslt as a maintainer's prereq in bootstrap.conf? That