Re: [libvirt] make docs fails on EL5

2011-11-15 Thread Osier Yang
于 2011年11月16日 11:12, shu ming 写道: It seems tit is he same issue as the thread below, the docs can not be generated in some Linux distros. It may be caused by the incompatibility of document tools in these distros. http://www.mail-archive.com/libvir-list@redhat.com/msg47624.html They are not

Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume

2011-11-15 Thread Dave Allan
On Tue, Nov 15, 2011 at 05:26:59PM -0700, Eric Blake wrote: > On 11/15/2011 04:18 PM, Eric Blake wrote: > >> 2. Do the 'virsh snapshot-create abc --disk-only' with libvirt-0.9.6 or > >> upper. > > > > But here, since you failed to use the --xmlfile option with XML > > describing the new qcow2 file

Re: [libvirt] make docs fails on EL5

2011-11-15 Thread shu ming
It seems tit is he same issue as the thread below, the docs can not be generated in some Linux distros. It may be caused by the incompatibility of document tools in these distros. http://www.mail-archive.com/libvir-list@redhat.com/msg47624.html On 2011-11-16 1:27, Daniel Berteaud wrote: Hi. I

Re: [libvirt] [PATCH] util : fix compile error on fedora14 Add src/util/virnetdevbandwidth.h, src/util/virnetdevveth.h, src/util/virnetdevvportprofile.h to private symbols.

2011-11-15 Thread Eli Qiao
于 2011年11月16日 11:02, Osier Yang 写道: 于 2011年11月16日 09:36, ta...@linux.vnet.ibm.com 写道: From: Eli Qiao Signed-off-by: Eli Qiao --- src/libvirt_private.syms | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_priv

Re: [libvirt] [PATCH] util : fix compile error on fedora14 Add src/util/virnetdevbandwidth.h, src/util/virnetdevveth.h, src/util/virnetdevvportprofile.h to private symbols.

2011-11-15 Thread Osier Yang
于 2011年11月16日 09:36, ta...@linux.vnet.ibm.com 写道: From: Eli Qiao Signed-off-by: Eli Qiao --- src/libvirt_private.syms | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7b96a3c..f178662 100644

Re: [libvirt] [PATCH] util : fix compile error on fedora14 Add src/util/virnetdevbandwidth.h, src/util/virnetdevveth.h, src/util/virnetdevvportprofile.h to private symbols.

2011-11-15 Thread Hong Xiang
I got the compile error too on RHEL workstation 6.1 with latest git source, and this patch fixes it. On 11/16/2011 09:36 AM, ta...@linux.vnet.ibm.com wrote: > From: Eli Qiao > > > Signed-off-by: Eli Qiao > --- > src/libvirt_private.syms | 19 +++ > 1 files changed, 19 insert

[libvirt] [PATCH] util : fix compile error on fedora14 Add src/util/virnetdevbandwidth.h, src/util/virnetdevveth.h, src/util/virnetdevvportprofile.h to private symbols.

2011-11-15 Thread taget
From: Eli Qiao Signed-off-by: Eli Qiao --- src/libvirt_private.syms | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7b96a3c..f178662 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_pri

Re: [libvirt] [PATCH v5 4/4] qemu/rbd: improve rbd device specification

2011-11-15 Thread Josh Durgin
On 11/15/2011 04:05 PM, Eric Blake wrote: On 10/31/2011 07:29 PM, Josh Durgin wrote: From: Sage Weil Sorry for letting my review of this slip 2 weeks. This improves the support for qemu rbd devices by adding support for a few key features (e.g., authentication) and cleaning up the way in wh

Re: [libvirt] [PATCH V1 1/9] Add support for VLAN filtering

2011-11-15 Thread Eric Blake
On 10/26/2011 09:11 AM, Stefan Berger wrote: Apologies for delaying so long on reviewing this. > This patch adds support for filtering of VLAN (802.1Q) traffic to the > parser and makes us of the ebtables support for VLAN filtering. This code > now enables the filtering of traffic in chains with

Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume

2011-11-15 Thread Eric Blake
On 11/15/2011 04:18 PM, Eric Blake wrote: >> 2. Do the 'virsh snapshot-create abc --disk-only' with libvirt-0.9.6 or >> upper. > > But here, since you failed to use the --xmlfile option with XML > describing the new qcow2 file name (or used snapshot-create-as with the > --diskspec option), you are

Re: [libvirt] [PATCH v5 4/4] qemu/rbd: improve rbd device specification

2011-11-15 Thread Eric Blake
On 10/31/2011 07:29 PM, Josh Durgin wrote: > From: Sage Weil Sorry for letting my review of this slip 2 weeks. > > This improves the support for qemu rbd devices by adding support for a few > key features (e.g., authentication) and cleaning up the way in which > rbd configuration options are pa

Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume

2011-11-15 Thread Eric Blake
On 11/15/2011 03:48 PM, MATSUDA, Daiki wrote: > I tested some cases and found it. > 1. The guest use the raw disk volume or LVM2 volume, such as following > the config file using raw disk volume created by RHEL 6.1 Virt Manager. > > > > >function='0x0'/> > H

Re: [libvirt] [PATCH] Fix build with polkit0

2011-11-15 Thread Jim Fehlig
Eric Blake wrote: > On 11/15/2011 03:39 PM, Jim Fehlig wrote: > >> I missed adding libvirt_driver_remote.la to libvirtd_LDADD in >> commit b8adfcc6, which didn't cause a problem in 0.9.6 but >> results in this build error in 0.9.7 >> >> libvirtd-remote.o: In function `remoteDispatchAuthPolkit':

Re: [libvirt] [PATCH v3] Add support for systemd init service

2011-11-15 Thread Eric Blake
On 11/15/2011 04:35 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Followup to > > https://www.redhat.com/archives/libvir-list/2011-November/msg00580.html > > This patch adds support for a systemd init service for libvirtd > and libvirt-guests. The libvirtd.service is *not* wr

Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume

2011-11-15 Thread MATSUDA, Daiki
(2011/11/16 0:35), Dave Allan wrote: On Mon, Nov 14, 2011 at 04:02:21PM -0700, Eric Blake wrote: On 11/13/2011 09:08 PM, MATSUDA, Daiki wrote: NACK. There is nothing inherently wrong with the source file not being a qcow2 file. The whole point of creating a runtime snapshot is that the origin

Re: [libvirt] [PATCHv4 3/4] blkiotune: add interface for blkiotune.device_weight

2011-11-15 Thread Eric Blake
On 11/15/2011 12:15 AM, Hu Tao wrote: > We can filter out 0-weight here: > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index b35c83c..5160003 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_conf.c > @@ -10893,6 +10893,7 @@ virDomainDefFormatInternal(virDomainDef

Re: [libvirt] [PATCH] Fix build with polkit0

2011-11-15 Thread Eric Blake
On 11/15/2011 03:39 PM, Jim Fehlig wrote: > I missed adding libvirt_driver_remote.la to libvirtd_LDADD in > commit b8adfcc6, which didn't cause a problem in 0.9.6 but > results in this build error in 0.9.7 > > libvirtd-remote.o: In function `remoteDispatchAuthPolkit': > remote.c:(.text+0x188dd): u

[libvirt] [PATCH] Fix build with polkit0

2011-11-15 Thread Jim Fehlig
I missed adding libvirt_driver_remote.la to libvirtd_LDADD in commit b8adfcc6, which didn't cause a problem in 0.9.6 but results in this build error in 0.9.7 libvirtd-remote.o: In function `remoteDispatchAuthPolkit': remote.c:(.text+0x188dd): undefined reference to `virNetServerGetDBusConn' --- d

Re: [libvirt] [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight

2011-11-15 Thread Eric Blake
On 11/15/2011 12:22 AM, Hu Tao wrote: > On Mon, Nov 14, 2011 at 09:30:02PM -0700, Eric Blake wrote: >> From: Hu Tao >> >> Implement setting/getting per-device blkio weights in qemu, >> using the cgroups blkio.weight_device tunable. >> >> +/* deviceWeightStr in the form of /device/path,weight,/dev

Re: [libvirt] compile fail on FreeBSD

2011-11-15 Thread Eric Blake
On 11/15/2011 04:08 AM, Daniel P. Berrange wrote: > On Fri, Nov 11, 2011 at 05:31:14PM -0700, Eric Blake wrote: >> This failure on FreeBSD 8.2 popped up this week, and I suspect Dan's >> virnetdev refactoring, but haven't had time to further investigate and >> fix it: >> >> util/virnetdev.c: In fun

Re: [libvirt] [PATCH] Fix tip of git

2011-11-15 Thread Eric Blake
On 11/15/2011 12:40 PM, Stefan Berger wrote: > I get these type of compilation errors: > > In file included from util/virnetdevvportprofile.c:25:0: > util/virnetdevvportprofile.h:49:13: error: expected > specifier-qualifier-list before 'uint8_t' > util/virnetdevvportprofile.c: In function 'virNetD

Re: [libvirt] Upgrade-problems from qemu-0.14.1 + libvirt-0.8.4 to qemu-0.15.1 + libvirt-0.9.6: Why I think multifunction=on is a bad idea...

2011-11-15 Thread Eric Blake
On 11/15/2011 02:19 PM, Philipp Hahn wrote: > Hello, > > this mail is something between a bug report and a warning to other users of > libvirt, before they also experience the problem I encountered today: > > I just hat the painful experience of trying to install some newer versions of > qemu(-

[libvirt] Upgrade-problems from qemu-0.14.1 + libvirt-0.8.4 to qemu-0.15.1 + libvirt-0.9.6: Why I think multifunction=on is a bad idea...

2011-11-15 Thread Philipp Hahn
Hello, this mail is something between a bug report and a warning to other users of libvirt, before they also experience the problem I encountered today: I just hat the painful experience of trying to install some newer versions of qemu(-kvm) and libvirt on a system with many managedsave-states

[libvirt] [PATCH] Fix tip of git

2011-11-15 Thread Stefan Berger
I get these type of compilation errors: In file included from util/virnetdevvportprofile.c:25:0: util/virnetdevvportprofile.h:49:13: error: expected specifier-qualifier-list before 'uint8_t' util/virnetdevvportprofile.c: In function 'virNetDevVPortProfileEqual': util/virnetdevvportprofile.c:45:

Re: [libvirt] [libvirt-glib 33/37] Implement gvir_config_device_chardev_set_source

2011-11-15 Thread Christophe Fergeau
On Sat, Nov 12, 2011 at 12:00:33AM +0100, Marc-André Lureau wrote: > On Thu, Nov 10, 2011 at 9:34 PM, Christophe Fergeau > wrote: > > +    source_type = > > gvir_config_chardev_source_class_get_nick(G_OBJECT_TYPE(source)); > > > > I don't see why this is necessarily a class method, I virtual me

Re: [libvirt] [libvirt-glib 29/37] Add GVirConfigDeviceInput

2011-11-15 Thread Marc-André Lureau
On Tue, Nov 15, 2011 at 7:25 PM, Christophe Fergeau wrote: > What are you referring to? GVirConfigGraphicsSpice and GVirConfigInterface? > yes, all the classes that are nodes under -- Marc-André Lureau -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/

Re: [libvirt] [libvirt-glib 32/37] Add gobject boilerplate for chardev handling

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 11:52:27PM +0100, Marc-André Lureau wrote: > On Thu, Nov 10, 2011 at 9:34 PM, Christophe Fergeau > wrote: > > +       gvir_config_device_chardev_set_source; > > +       gvir_config_device_chardev_set_target; > > There is no definition for these symbols in this commit, you

Re: [libvirt] [libvirt-glib 2/3] Add some basic information to README

2011-11-15 Thread Alon Levy
On Tue, Nov 15, 2011 at 08:12:28PM +0200, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" > > --- > README | 29 + > 1 files changed, 29 insertions(+), 0 deletions(-) > > diff --git a/README b/README > index e69de29..866ec53 100644 > --- a/README > +++

Re: [libvirt] [libvirt-glib 30/37] Add basic GVirConfigGraphicsSpice

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 08:40:58PM +0100, Marc-André Lureau wrote: > Same comment as for "interface", do we want to have specialized > classes for various type. > > In this case, you should also add a base Graphics class. Looking at the format again (http://libvirt.org/formatdomain.html#elementsG

Re: [libvirt] [libvirt-glib 29/37] Add GVirConfigDeviceInput

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 08:32:30PM +0100, Marc-André Lureau wrote: > just a comment about naming. > > If we use prefix "Device" before devices class, I think it should be > done for the rest of the class for consistency. What are you referring to? GVirConfigGraphicsSpice and GVirConfigInterface?

Re: [libvirt] [RFC PATCH v2 4/4] PowerPC : Bifurcate arch-specific qemu initialization code from generic qemu command line generation.

2011-11-15 Thread Prerna Saxena
Hi Daniel, Thanks for taking a look. On 11/15/2011 04:33 PM, Daniel P. Berrange wrote: On Mon, Nov 14, 2011 at 08:26:55PM +0530, Prerna Saxena wrote: From ae7764be4454be1900fc3ee0a03bf819d5cd12de Mon Sep 17 00:00:00 2001 From: Prerna Saxena Date: Mon, 14 Nov 2011 19:43:26 +0530 Subject: [PATCH

Re: [libvirt] [libvirt-glib 28/37] Add GVirConfigInterfaceNetwork

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 08:27:48PM +0100, Marc-André Lureau wrote: > On Thu, Nov 10, 2011 at 9:34 PM, Christophe Fergeau > wrote: > > Make GVirConfigInterface an abstract base class, and move the > > actual code in subclasses. This will make handling of the various > > types of network interfaces

[libvirt] [libvirt-glib 1/3] Also distribute private headers

2011-11-15 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" Private headers just shouldn't be installed but still distributed as they are required during the build. Fixes `make distcheck`. --- libvirt-gobject/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/Makefile.am b

[libvirt] [libvirt-glib 2/3] Add some basic information to README

2011-11-15 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- README | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/README b/README index e69de29..866ec53 100644 --- a/README +++ b/README @@ -0,0 +1,29 @@ +libvirt-glib + + +libvirt is a C toolkit to interac

[libvirt] [libvirt-glib 3/3] Release 0.0.1

2011-11-15 Thread Zeeshan Ali (Khattak)
From: "Zeeshan Ali (Khattak)" --- NEWS |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index e69de29..015fab8 100644 --- a/NEWS +++ b/NEWS @@ -0,0 +1,5 @@ +0.0.1 += + +First public release. + -- 1.7.7.1 -- libvir-list mailing list libvir-list@redhat

Re: [libvirt] [libvirt-glib 26/37] Add gvir_config_interface_set_source

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 08:08:37PM +0100, Marc-André Lureau wrote: > On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau > wrote: > > The way it's done is just a band-aid though. The need for this > > 'type' member in GVirConfigInterface and GVirConfigDeviceDisk is > > a clear indication that the

Re: [libvirt] [libvirt-glib 25/37] Add gvir_config_interface_set_network_type

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 08:15:02PM +0100, Marc-André Lureau wrote: > it's missing include of libvirt-gconfig-helpers-private.h This file doesn't use any function from this header, that's why it's not included (I've just checked that compilation goes fine). It will get added when I rework the patch

[libvirt] make docs fails on EL5

2011-11-15 Thread Daniel Berteaud
Hi. I usually build all the latest libvirt version on EL5 (CentOS x86_64), and, up to libvirt 0.9.3, I could get it to build without major issue, but starting with libvirt 0.9.4, I cannot get the rpm to build (I'm using a quite simple plague/mock setup), I always have this error: make[2]: Enterin

Re: [libvirt] [libvirt-glib 23/37] Add test for adding a disk device

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 07:05:18PM +0100, Marc-André Lureau wrote: > On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau > wrote: > >  devices = g_list_append(devices, disk); > > +    gvir_config_domain_set_devices(domain, devices); > > +    g_list_free(devices); > > +    devices = NULL; > > >

Re: [libvirt] [libvirt-glib 22/37] More GVirConfigDeviceDisk setters

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 06:43:10PM +0100, Marc-André Lureau wrote: > > + > > +void gvir_config_device_disk_set_source(GVirConfigDeviceDisk *disk, > > +                                        const char *source) > > +{ > > +    xmlNodePtr source_node; > > +    const char *attribute_name; > > + > > +

Re: [libvirt] [libvirt-glib 20/37] Improve gvir_config_object_new_child

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 04:52:11PM +0100, Marc-André Lureau wrote: > Having gvir_config_object_add_child() and > gvir_config_object_replace_child() would be more obvious (even the > internal code should be splitted) Thanks for the naming suggestions :) I'm not fully satisfied with how most of the

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Eric Blake
On 11/15/2011 04:34 AM, Stefan Berger wrote: > What about this here: > > --- a/src/util/buf.c > +++ b/src/util/buf.c > @@ -466,7 +466,11 @@ virBufferEscape(virBufferPtr buf, const char > *toescape, > cur = str; > out = escaped; > while (*cur != 0) { > -if (strchr(toescape, *

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Eric Blake
On 11/15/2011 04:41 AM, Daniel P. Berrange wrote: >> while (*cur != 0) { >> -if (strchr(toescape, *cur)) >> +/* strchr work-around for gcc 4.3 & 4.4 bug with -Wlogical-op >> + * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36513 >> + */ >> +char needle[2]

Re: [libvirt] network route collision only checked IPv4 addr

2011-11-15 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 05:20:40PM +0800, Jenna Johnson wrote: > folks, > Noticed that in function "networkStartNetworkVirtual" only have IPv4 > addr checked in "networkCheckRouteCollision",will it be a problem that we > don't check IPv6 addr? We primarily put the check in there because we ha

Re: [libvirt] [PATCH 6/6 (v2)] Allow non-blocking message sending on virNetClient

2011-11-15 Thread Jiri Denemark
On Mon, Nov 14, 2011 at 12:03:52 +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Split the existing virNetClientSend into two parts > virNetClientSend and virNetClientSendNoReply, instead > of having a 'bool expectReply' parameter. This is done by a separate patch, so remove th

Re: [libvirt] [PATCH 4/6] Split virNetClientSend into 2 methods

2011-11-15 Thread Jiri Denemark
On Fri, Nov 11, 2011 at 16:22:02 +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Stop multiplexing virNetClientSend for two different purposes, > instead add virNetClientSendWithReply and virNetClientSendNoReply > > * src/rpc/virnetclient.c, src/rpc/virnetclient.h: Replace >

Re: [libvirt] bug: try to take disk snapshot for LVM2 Volume

2011-11-15 Thread Dave Allan
On Mon, Nov 14, 2011 at 04:02:21PM -0700, Eric Blake wrote: > On 11/13/2011 09:08 PM, MATSUDA, Daiki wrote: > >> NACK. There is nothing inherently wrong with the source file not being > >> a qcow2 file. The whole point of creating a runtime snapshot is that > >> the original file (of _any_ format

Re: [libvirt] [PATCH 5/6] Refactor code for enabling/disabling I/O callback in remote client

2011-11-15 Thread Jiri Denemark
On Fri, Nov 11, 2011 at 16:22:03 +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > * src/rpc/virnetclient.c: Add helper for setting I/O callback events > --- > src/rpc/virnetclient.c | 15 +-- > 1 files changed, 13 insertions(+), 2 deletions(-) ACK Jirka -- libvi

Re: [libvirt] [PATCH 2/6] Explicitly track whether the buck is held in remote client

2011-11-15 Thread Jiri Denemark
On Fri, Nov 11, 2011 at 16:22:00 +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Instead of inferring whether the buck is held from the waitDispatch > pointer, use an explicit 'bool haveTheBuck' field > > * src/rpc/virnetclient.c: Explicitly track the buck > --- > src/rpc/virn

Re: [libvirt] [PATCH 1/6] Remove all linked list handling from remote client event loop

2011-11-15 Thread Jiri Denemark
On Fri, Nov 11, 2011 at 16:21:59 +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Directly messing around with the linked list is potentially > dangerous. Introduce some helper APIs to deal with list > manipulating the list > > * src/rpc/virnetclient.c: Create linked list handle

Re: [libvirt] [PATCH 3/6] Refactor code for passing the buck in the remote client

2011-11-15 Thread Jiri Denemark
On Fri, Nov 11, 2011 at 16:22:01 +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Remove some duplication by pulling the code for passing the > buck out into a helper method > > * src/rpc/virnetclient.c: Introduce virNetClientIOEventLoopPassTheBuck > --- > src/rpc/virnetclient.

[libvirt] network route collision only checked IPv4 addr

2011-11-15 Thread Jenna Johnson
folks, Noticed that in function "networkStartNetworkVirtual" only have IPv4 addr checked in "networkCheckRouteCollision",will it be a problem that we don't check IPv6 addr? -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-users] listDomains() not working on Xen

2011-11-15 Thread Preethi Ramesh
Thanks! I tried virsh -c xen:///system list --all and I got: Domain 0 running test idle I'm able to successfully ping the test VM also. How can I get the list of active VMs now? On Tue, Nov 15, 2011 at 11:00 AM, Matthias Bolte < matthias.bo...@googlemail.com> wrote: > 2011/11/15 PRE

Re: [libvirt] [libvirt-glib 18/37] Add gobject boilerplate for GVirConfigDeviceDisk

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 04:40:56PM +0100, Marc-André Lureau wrote: > > +static void gvir_config_device_disk_class_init(GVirConfigDeviceDiskClass > > *klass) > > +{ > > + > > +    g_type_class_add_private(klass, sizeof(GVirConfigDeviceDiskPrivate)); > > +} > > There is an extra line here, in previ

Re: [libvirt] [libvirt-glib 13/37] Add gvir_config_os_set_{machine, arch}

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 04:21:17PM +0100, Marc-André Lureau wrote: > It could be merged with previous patches. Yes, done. Christophe pgpCKvyHU9WKJ.pgp Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-glib 11/37] Implement gvir_config_os_set_os_type

2011-11-15 Thread Marc-André Lureau
On Tue, Nov 15, 2011 at 3:18 PM, Christophe Fergeau wrote: > What do you mean exactly? Having a warning in genum_get_nick and drop the > != NULL test? Or only to add the warning in genum_get_nick, and not add a > warning here? I can easily add a g_warn_if_reached() in genum_get_nick Yeah, I meant

Re: [libvirt] [libvirt-glib 04/37] Add some GVirConfigClock setters

2011-11-15 Thread Marc-André Lureau
On Tue, Nov 15, 2011 at 2:37 PM, Christophe Fergeau wrote: > g_return_if_fail(klock != NULL); I think better is: g_return_if_fail(GVIR_IS_CONFIG_CLOCK(klock)); > libxml2 provides http://xmlsoft.org/html/libxml-xmlstring.html#BAD_CAST > which isn't really easy on the eyes. I've got more patches w

Re: [libvirt] [libvirt-glib 14/37] Implement gvir_config_domain_set_os

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 04:25:29PM +0100, Marc-André Lureau wrote: > On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau > wrote: > > +/* Must come last since it uses types defined in the other headers */ > > +#include > > This is weird, can't libvirt-gconfig/libvirt-gconfig-domain.h include >

Re: [libvirt] [libvirt-glib 12/37] Add more GVirConfigOs setters

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 04:20:05PM +0100, Marc-André Lureau wrote: > Hi > > Please merge with previous patch. > > > +    if (enable) > > +        xmlNewProp(node, (xmlChar*)"enable", (xmlChar*)"yes"); > > +    else > > +        xmlNewProp(node, (xmlChar*)"enable", (xmlChar*)"no"); > > +} > > mig

Re: [libvirt] [libvirt-glib 11/37] Implement gvir_config_os_set_os_type

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 03:58:40PM +0100, Marc-André Lureau wrote: > On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau > wrote: > > --- > >  libvirt-gconfig/libvirt-gconfig-os.c |   14 ++ > >  libvirt-gconfig/libvirt-gconfig-os.h |    6 ++ > >  libvirt-gconfig/libvirt-gconfig.sy

Re: [libvirt] [libvirt-glib 11/37] Implement gvir_config_os_set_os_type

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 04:15:46PM +0100, Marc-André Lureau wrote: > it's actually missing gvir_config_os_set_os_type in the sym file, that > you added in following patch. > > I would suggest to merge the two patches. Done. Christophe pgpN5pW4zgSSp.pgp Description: PGP signature -- libvir-list

Re: [libvirt] [libvirt-glib 07/37] Implement gvir_config_clock_set_offset

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 03:47:36PM +0100, Marc-André Lureau wrote: > > On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau > wrote: > > --- > >  libvirt-gconfig/libvirt-gconfig-clock.c |   19 +++ > >  libvirt-gconfig/libvirt-gconfig-clock.h |    8 > >  libvirt-gconfig/li

Re: [libvirt] [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-15 Thread Anthony Liguori
On 11/15/2011 07:20 AM, Juan Quintela wrote: Again, I think defaulting DAS to cache=none|directsync is what makes the most sense here. I think it is the only sane solution. Otherwise, we need to write the equivalent of a lock manager, to know _who_ has the storage, and distributed lock manager

Re: [libvirt] [libvirt-glib 06/37] Use glib-mkenums to register enums with glib

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 03:43:41PM +0100, Marc-André Lureau wrote: > actually, > > @@ -28,6 +31,8 @@ GCONFIG_SOURCE_FILES = \ > libvirt-gconfig-clock.c \ > libvirt-gconfig-domain.c \ > libvirt-gconfig-domain-snapshot.c \ > +

Re: [libvirt] [libvirt-glib 05/37] Add gvir_config_domain_set_clock

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 03:41:02PM +0100, Marc-André Lureau wrote: > On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau > wrote: > > The implementation is likely to need to be completed later. We > > might want to store pointers from GVirConfigDomain to the associated > > GVirConfigClock, from G

Re: [libvirt] [libvirt-glib 04/37] Add some GVirConfigClock setters

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 03:39:01PM +0100, Marc-André Lureau wrote: > > +void gvir_config_clock_set_timezone(GVirConfigClock *klock, > > +                                    const char *tz) > > +{ > > +    xmlNodePtr node; > > +    xmlChar *encoded_tz; > > in general, I think we should add g_return

Re: [libvirt] [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-15 Thread Avi Kivity
On 11/14/2011 11:58 AM, Kevin Wolf wrote: > Am 12.11.2011 11:25, schrieb Avi Kivity: > > On 11/11/2011 12:15 PM, Kevin Wolf wrote: > >> Am 10.11.2011 22:30, schrieb Anthony Liguori: > >>> Live migration with qcow2 or any other image format is just not going to > >>> work > >>> right now even with

Re: [libvirt] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions

2011-11-15 Thread Juan Quintela
Anthony Liguori wrote: > On 11/14/2011 04:16 AM, Daniel P. Berrange wrote: >> On Sat, Nov 12, 2011 at 12:25:34PM +0200, Avi Kivity wrote: >>> On 11/11/2011 12:15 PM, Kevin Wolf wrote: Am 10.11.2011 22:30, schrieb Anthony Liguori: > Live migration with qcow2 or any other image format is ju

Re: [libvirt] [libvirt-users] listDomains() not working on Xen

2011-11-15 Thread Matthias Bolte
2011/11/15 PREETHI RAMESH : > Hey all, > I've been trying to make listDomains() work on Xen but it simply returns an > array of null values. Also, while displaying the length of the array > returned by listDomains(). Upon using the same function in KVM, I'm able to > retrieve the complete array of

Re: [libvirt] [PATCH v2 1/2] XML definitions for guest NUMA and parsing routines

2011-11-15 Thread Daniel P. Berrange
On Fri, Nov 11, 2011 at 06:21:45PM +0530, Bharata B Rao wrote: > XML definitions for guest NUMA and parsing routines. > > From: Bharata B Rao > > This patch adds XML definitions for guest NUMA specification and contains > routines to parse the same. The guest NUMA specification looks like this:

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Stefan Berger
On 11/15/2011 06:41 AM, Daniel P. Berrange wrote: On Tue, Nov 15, 2011 at 06:34:27AM -0500, Stefan Berger wrote: Is the difference just that we're deferencing a char * for the second arg rather than using a constant value ? Would it suffice to do int c = *cur; if (strchr(toescape, c)) I

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Justin Clift
On 15/11/2011, at 10:34 PM, Stefan Berger wrote: > +/* strchr work-around for gcc 4.3 & 4.4 bug with -Wlogical-op > + * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36513 > + */ Cool, that's good investigation Stefan. :) + Justin -- Aeolus Community Manager http://www.aeol

Re: [libvirt] [PATCH v2 2/2] qemu: Generate -numa option

2011-11-15 Thread Daniel P. Berrange
On Fri, Nov 11, 2011 at 06:23:04PM +0530, Bharata B Rao wrote: > qemu: Generate -numa option > > From: Bharata B Rao > > Add routines to generate -numa QEMU command line option based on > ... XML specifications. > > Signed-off-by: Bharata B Rao > --- > > src/conf/cpu_conf.c

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 06:34:27AM -0500, Stefan Berger wrote: > On 11/14/2011 10:36 PM, Eric Blake wrote: > >On 11/14/2011 05:54 PM, Stefan Berger wrote: > >>On 11/11/2011 04:06 PM, Eric Blake wrote: > >>>On 11/08/2011 11:46 PM, Justin Clift wrote: > Hi guys, > > Just checking 0.9.7 o

Re: [libvirt] [PATCH] Add support for systemd init service

2011-11-15 Thread Daniel P. Berrange
On Fri, Nov 11, 2011 at 12:18:32PM -0700, Eric Blake wrote: > On 11/11/2011 07:32 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > This patch adds support for a systemd init service for libvirtd > > and libvirt-guests. The libvirtd.service is *not* written to use > > socket ac

Re: [libvirt] [PATCH] Add support for systemd init service

2011-11-15 Thread Daniel P. Berrange
On Fri, Nov 11, 2011 at 05:19:33PM +0100, Paolo Bonzini wrote: > On 11/11/2011 03:32 PM, Daniel P. Berrange wrote: > >+%makeinstall SYSTEMD_UNIT_DIR=%{?buildroot:%{buildroot}}%{_unitdir} > > Is this correct since DESTDIR is prepended to it? Shouldn't it just > be just %{_unitdir}? Otherwise look

Re: [libvirt] Non-zero constant warning on RHEL 6.1 with 0.9.7

2011-11-15 Thread Stefan Berger
On 11/14/2011 10:36 PM, Eric Blake wrote: On 11/14/2011 05:54 PM, Stefan Berger wrote: On 11/11/2011 04:06 PM, Eric Blake wrote: On 11/08/2011 11:46 PM, Justin Clift wrote: Hi guys, Just checking 0.9.7 on RHEL 6.1 x86_64. Noticed this when compiling with make -j 3: CC libvirt_lxc-

[libvirt] [PATCH v3] Add support for systemd init service

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Followup to https://www.redhat.com/archives/libvir-list/2011-November/msg00580.html This patch adds support for a systemd init service for libvirtd and libvirt-guests. The libvirtd.service is *not* written to use socket activation, since we want libvirtd to start on

[libvirt] listDomains() not working on Xen

2011-11-15 Thread PREETHI RAMESH
Hey all, I've been trying to make listDomains() work on Xen but it simply returns an array of null values. Also, while displaying the length of the array returned by listDomains(). Upon using the same function in KVM, I'm able to retrieve the complete array of active machines. I'm positive that act

Re: [libvirt] [libvirt-glib 01/37] Add gvir_config_object_new_child helper

2011-11-15 Thread Daniel P. Berrange
On Tue, Nov 15, 2011 at 12:15:17PM +0100, Christophe Fergeau wrote: > Hey, > > On Fri, Nov 11, 2011 at 03:28:34PM +0100, Marc-André Lureau wrote: > > The functions declaration should be put in -private.h . Marking > > definition G_GNUC_INTERNAL would also make it more obvious. > > > > It would al

[libvirt] [PATCH 11/16] Move virNetDevGetIPv4Address to virnetdev.c

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move the virNetDevGetIPv4Address function to virnetdev.c * util/interface.c, util/interface.h: Remove virNetDevGetIPv4Address * util/virnetdev.c, util/virnetdev.h: Add virNetDevGetIPv4Address --- src/util/interface.c | 63

[libvirt] [PATCH 16/16] Move ifaceMacvtapLinkDump and ifaceGetNthParent functions

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move the ifaceMacvtapLinkDump and ifaceGetNthParent functions into virnetdevvportprofile.c since they are specific to that code. This avoids polluting the headers with the Linux specific netlink data types * src/util/interface.c, src/util/interface.h: Move ifaceMacvt

Re: [libvirt] [libvirt-glib 03/37] Add gobject boilerplate for GVirConfigClock and GVirConfigTimer

2011-11-15 Thread Christophe Fergeau
On Fri, Nov 11, 2011 at 03:33:51PM +0100, Marc-André Lureau wrote: > On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau > wrote: > > +struct _GVirConfigClockPrivate > > +{ > > +    gboolean unused; > > +}; > > (does it really matter if the struct is empty?) Yes, there's a runtime warning if si

[libvirt] [PATCH 13/16] Move virNetDevValidateConfig to virnetdev.c

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" * src/util/interface.c, src/util/interface.h: Remove virNetDevValidateConfig * src/util/virnetdev.c, src/util/virnetdev.h: Add virNetDevValidateConfig --- src/util/interface.c | 89 -- src/util/interface.h |4 -- sr

[libvirt] [PATCH 01/16] Rename Macvtap management APIs

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" In preparation for code re-organization, rename the Macvtap management APIs to have the following patterns virNetDevMacVLanX - macvlan/macvtap interface management virNetDevVPortProfile - virtual port profile management * src/util/macvtap.c, src/util/m

[libvirt] [PATCH 07/16] Move MAC address replacement functions to virnetdev.c

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move virNetDevReplaceMacAddress and virNetDevRestoreMacAddress to the virnetdev.c file where they naturally belong * util/interface.c, util/interface.h: Remove virNetDevReplaceMacAddress and virNetDevRestoreMacAddress * util/virnetdev.c, util/virnetdev.h: Add virNe

Re: [libvirt] [libvirt-glib 01/37] Add gvir_config_object_new_child helper

2011-11-15 Thread Christophe Fergeau
Hey, On Fri, Nov 11, 2011 at 03:28:34PM +0100, Marc-André Lureau wrote: > The functions declaration should be put in -private.h . Marking > definition G_GNUC_INTERNAL would also make it more obvious. > > It would also less confuse gir-scanner which doesn't know about libxml types. At this point,

[libvirt] [PATCH 09/16] Move virNetDevGetIndex & virNetDevGetVLanID to virnetdev.c

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move virNetDevGetIndex & virNetDevGetVLanID to virnetdev.c to suit their functional purpose * util/interface.c, util/interface.h: Remove virNetDevGetIndex & virNetDevGetVLanID * util/virnetdev.c, util/virnetdev.h: Add virNetDevGetIndex & virNetDevGetVLanID --- src

[libvirt] [PATCH 10/16] Rename ifaceGetIPAddress to virNetDevGetIPv4Address

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" To match up with the existing virNetDevSetIPv4Address, rename ifaceGetIPAddress to virNetDevGetIPv4Address * util/interface.h, util/interface.c: Rename API * network/bridge_driver.c: Update for API rename --- src/libvirt_private.syms|2 +- src/network/bridge_d

[libvirt] [PATCH 06/16] Rename interface MAC address replacement APIs

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Rename ifaceReplaceMacAddress to virNetDevReplaceMacAddress and ifaceRestoreMacAddress to virNetDevRestoreMacAddress. * util/interface.c, util/interface.h, util/virnetdevmacvlan.c: Rename APIs --- src/libvirt_private.syms|4 ++-- src/util/interface.c

[libvirt] [PATCH 08/16] Rename ifaceGetIndex and ifaceGetVLAN

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Rename the ifaceGetIndex method to virNetDevGetIndex and ifaceGetVlanID to virNetDevGetVLanID. Also change the error reporting behaviour to always raise errors and return -1 on failure * util/interface.c, util/interface.h: Rename ifaceGetIndex and ifaceGetVLAN * nwfi

[libvirt] [PATCH 12/16] Rename ifaceCheck to virNetDevValidateConfig

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Rename the ifaceCheck method to virNetDevValidateConfig and change so that it always raises an error and returns -1 on error. * src/util/interface.c, src/util/interface.h: Rename ifaceCheck to virNetDevValidateConfig * src/nwfilter/nwfilter_gentech_driver.c, src/nw

[libvirt] [PATCH 03/16] Rename high level macvlan creation APIs

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Rename virNetDevMacVLanCreate to virNetDevMacVLanCreateWithVPortProfile and virNetDevMacVLanDelete to virNetDevMacVLanDeleteWithVPortProfile To make way for renaming the other macvlan creation APIs in interface.c * util/virnetdevmacvlan.c, util/virnetdevmacvlan.h, q

[libvirt] [PATCH 15/16] Move functions for dealing with physical/virtual devices

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move virNetDevIsVirtualFunction, virNetDevGetVirtualFunctionIndex and virNetDevGetPhysicalFunction to virnetdev.c * src/util/interface.c, src/util/interface.h, src/util/virnetdev.c, src/util/virnetdev.h: Move APIs --- src/util/interface.c | 146

[libvirt] [PATCH 04/16] Rename low level macvlan creation APIs

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Rename ifaceMacvtapLinkAdd to virNetDevMacVLanCreate and ifaceLinkDel to virNetDevMacVLanDelete. Strictly speaking the latter isn't restricted to macvlan devices, but that's the only use libvirt has for it. * util/interface.c, util/interface.h, util/virnetdevmacvlan.

[libvirt] [PATCH 05/16] Move the low level macvlan creation APIs

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Move the low level macvlan creation APIs into the virnetdevmacvlan.c file where they more naturally belong * util/interface.c, util/interface.h: Remove virNetDevMacVLanCreate and virNetDevMacVLanDelete * util/virnetdevmacvlan.c, util/virnetdevmacvlan.h: Add virNetD

[libvirt] [PATCH 14/16] Rename APIs for dealing with virtual/physical functions

2011-11-15 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Rename ifaceIsVirtualFunction to virNetDevIsVirtualFunction, ifaceGetVirtualFunctionIndex to virNetDevGetVirtualFunctionIndex and ifaceGetPhysicalFunction to virNetDevGetPhysicalFunction * src/util/interface.c, src/util/interface.h: Rename APIs * src/util/virnetdevvpor

[libvirt] [PATCH 00/16 v2] Refactor all network device handling code

2011-11-15 Thread Daniel P. Berrange
This is an update to https://www.redhat.com/archives/libvir-list/2011-November/msg00168.html Changes in v2: - Pushed first 17 patches - Rebased remaining patches to current GIT master -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] compile fail on FreeBSD

2011-11-15 Thread Daniel P. Berrange
On Fri, Nov 11, 2011 at 05:31:14PM -0700, Eric Blake wrote: > This failure on FreeBSD 8.2 popped up this week, and I suspect Dan's > virnetdev refactoring, but haven't had time to further investigate and > fix it: > > util/virnetdev.c: In function 'virNetDevExists': > util/virnetdev.c:93: error: s

Re: [libvirt] [RFC PATCH v2 4/4] PowerPC : Bifurcate arch-specific qemu initialization code from generic qemu command line generation.

2011-11-15 Thread Daniel P. Berrange
On Mon, Nov 14, 2011 at 08:26:55PM +0530, Prerna Saxena wrote: > From ae7764be4454be1900fc3ee0a03bf819d5cd12de Mon Sep 17 00:00:00 2001 > From: Prerna Saxena > Date: Mon, 14 Nov 2011 19:43:26 +0530 > Subject: [PATCH 4/4] Separate out arch-specific qemu initialization from > generic qemu commandli

  1   2   >